Re: Major page store issue found in 7.8.0, release a 7.8.1?
Please also wicket 8 - this one is a real problem - Ursprüngliche Mail - > Von: "Emond Papegaaij" > An: dev@wicket.apache.org > CC: "Martijn Dashorst" > Gesendet: Mittwoch, 30. August 2017 13:10:27 > Betreff: Re: Major page store issue found in 7.8.0, release a 7.8.1? > I've applied to fix to 6.x, 7.x and 8 (master). IMHO this issue warrants a > patch-release for at least 6 (6.27.1) and 7 (7.8.1). > > Best regards, > Emond > > On dinsdag 29 augustus 2017 15:26:06 CEST Martijn Dashorst wrote: >> https://issues.apache.org/jira/browse/WICKET-6387 >> >> The original fix apparently introduces the behavior that our logged out >> users don't remove stale pages from the pagestore because the session is >> marked "updating" >> >> Any site with major traffic that uses the page store will be affected by >> this. In Emond and my assessment this will necessitate a 7.8.1 fix as soon >> as possible. >> >> Does anyone have a better suggestion than Emond proposes in WICKET-6387? (I >> owe you a beer then), and do you agree that a 7.8.1 should be rolled? >> > > Martijn
Re: Major page store issue found in 7.8.0, release a 7.8.1?
I've applied to fix to 6.x, 7.x and 8 (master). IMHO this issue warrants a patch-release for at least 6 (6.27.1) and 7 (7.8.1). Best regards, Emond On dinsdag 29 augustus 2017 15:26:06 CEST Martijn Dashorst wrote: > https://issues.apache.org/jira/browse/WICKET-6387 > > The original fix apparently introduces the behavior that our logged out > users don't remove stale pages from the pagestore because the session is > marked "updating" > > Any site with major traffic that uses the page store will be affected by > this. In Emond and my assessment this will necessitate a 7.8.1 fix as soon > as possible. > > Does anyone have a better suggestion than Emond proposes in WICKET-6387? (I > owe you a beer then), and do you agree that a 7.8.1 should be rolled? > > Martijn
Re: Major page store issue found in 7.8.0, release a 7.8.1?
Is Wicket 8 affected as well? On Tue, Aug 29, 2017 at 4:27 PM, Emond Papegaaij wrote: > I've created an issue to track this regression and a PR with my proposed > fix: > https://github.com/apache/wicket/pull/231 > > Emond > > On dinsdag 29 augustus 2017 15:26:06 CEST Martijn Dashorst wrote: > > https://issues.apache.org/jira/browse/WICKET-6387 > > > > The original fix apparently introduces the behavior that our logged out > > users don't remove stale pages from the pagestore because the session is > > marked "updating" > > > > Any site with major traffic that uses the page store will be affected by > > this. In Emond and my assessment this will necessitate a 7.8.1 fix as > soon > > as possible. > > > > Does anyone have a better suggestion than Emond proposes in WICKET-6387? > (I > > owe you a beer then), and do you agree that a 7.8.1 should be rolled? > > > > Martijn > > >
Re: Major page store issue found in 7.8.0, release a 7.8.1?
I've created an issue to track this regression and a PR with my proposed fix: https://github.com/apache/wicket/pull/231 Emond On dinsdag 29 augustus 2017 15:26:06 CEST Martijn Dashorst wrote: > https://issues.apache.org/jira/browse/WICKET-6387 > > The original fix apparently introduces the behavior that our logged out > users don't remove stale pages from the pagestore because the session is > marked "updating" > > Any site with major traffic that uses the page store will be affected by > this. In Emond and my assessment this will necessitate a 7.8.1 fix as soon > as possible. > > Does anyone have a better suggestion than Emond proposes in WICKET-6387? (I > owe you a beer then), and do you agree that a 7.8.1 should be rolled? > > Martijn
Major page store issue found in 7.8.0, release a 7.8.1?
https://issues.apache.org/jira/browse/WICKET-6387 The original fix apparently introduces the behavior that our logged out users don't remove stale pages from the pagestore because the session is marked "updating" Any site with major traffic that uses the page store will be affected by this. In Emond and my assessment this will necessitate a 7.8.1 fix as soon as possible. Does anyone have a better suggestion than Emond proposes in WICKET-6387? (I owe you a beer then), and do you agree that a 7.8.1 should be rolled? Martijn
