Re: org.apache.wicket.util.string.StringEscapeUtils vs apache.commons.lang3.StringEscapeUtils

2016-06-08 Thread Francois Meillet
Agree to keep things lights

Thanks Martin,
François







> Le 8 juin 2016 à 11:58, Martin Grigorov  a écrit :
> 
> Hi Francois,
> 
> This has been done long time ago (Wicket 1.0/1.1).
> The idea is to keep Wicket light, without dependencies.
> Only the classes Wicket internals needed were copied.
> In Wicket 7.0.0 we introduced dependency to commons-fileupload to be able
> to update it. This also included commons-io as transitive dependency.
> In Wicket 7.1.0 commons-collections4 has been added for LinkedMap solely.
> This might be a good move or bad. We will see. So far no one complained
> about the extra dependencies.
> 
> Martin Grigorov
> Wicket Training and Consulting
> https://twitter.com/mtgrigorov
> 
> On Wed, Jun 8, 2016 at 11:51 AM, Francois Meillet <
> francois.meil...@gmail.com> wrote:
> 
>> Hi,
>> 
>> Why use a copy of the org.apache.commons.lang3.StringEscapeUtils and not
>> directly the lib ?
>> 
>> Thanks
>> François
>> 
>> 
>> 
>> 
>> 
>> 
>> 
>> 



Re: org.apache.wicket.util.string.StringEscapeUtils vs apache.commons.lang3.StringEscapeUtils

2016-06-08 Thread Martin Grigorov
Hi Francois,

This has been done long time ago (Wicket 1.0/1.1).
The idea is to keep Wicket light, without dependencies.
Only the classes Wicket internals needed were copied.
In Wicket 7.0.0 we introduced dependency to commons-fileupload to be able
to update it. This also included commons-io as transitive dependency.
In Wicket 7.1.0 commons-collections4 has been added for LinkedMap solely.
This might be a good move or bad. We will see. So far no one complained
about the extra dependencies.

Martin Grigorov
Wicket Training and Consulting
https://twitter.com/mtgrigorov

On Wed, Jun 8, 2016 at 11:51 AM, Francois Meillet <
francois.meil...@gmail.com> wrote:

> Hi,
>
> Why use a copy of the org.apache.commons.lang3.StringEscapeUtils and not
> directly the lib ?
>
> Thanks
> François
>
>
>
>
>
>
>
>


org.apache.wicket.util.string.StringEscapeUtils vs apache.commons.lang3.StringEscapeUtils

2016-06-08 Thread Francois Meillet
Hi,

Why use a copy of the org.apache.commons.lang3.StringEscapeUtils and not 
directly the lib ?

Thanks
François