Re: [Dev] Setup the WebSocket security in msf4j WebSocket server
Hi Sivaramya, In MSF4J HTTPS working. Since HTTP and WS use the same server connector configuration for WS too. Which means if HTTPS is configured when running MSF4J then WSS also working. @Danesh can please you provide the specifics? :) Thanks, Irunika *Irunika Weeraratne* *Software Engineer | WSO2, Inc. <http://wso2.com/>* *Email : irun...@wso2.com <irun...@wso2.com>* *LinkedIn : https://lk.linkedin.com/in/irunika <https://lk.linkedin.com/in/irunika>* *Mobile : +94712403314* *Lean . Enterprise . Middleware* On Fri, Dec 8, 2017 at 10:15 AM, SajithAR Ariyarathna <sajit...@wso2.com> wrote: > [+ MSF4J & transport folks] > > Kindly requests your assistance on this. > Thanks. > > On Fri, Dec 8, 2017 at 10:12 AM, Sivaramya Sivanathan <sivara...@wso2.com> > wrote: > >> Hi all, >> >> I am using msf4j 2.4.3 WebSocket server for the siddhi-io-websocket >> unit test. Can anyone guide me how to setup the WebSocket security in msf4j >> WebSocket server? >> >> Thank you, >> Sivaramya Sivanathan >> Associate Software Engineer | WSO2 >> Tel: 0770874960 >> WSO2 Inc : http://wso2.org >> <http://www.google.com/url?q=http%3A%2F%2Fwso2.org=D=1=AFQjCNE_eTDfyl2ibPcq0hcXvRDNVuQmMg> >> LinkedIn | www.linkedin.com/in/sivaramya >> > > > > -- > Sajith Janaprasad Ariyarathna > Senior Software Engineer; WSO2, Inc.; http://wso2.com/ > <https://wso2.com/signature> > ___ Dev mailing list Dev@wso2.org http://wso2.org/cgi-bin/mailman/listinfo/dev
Re: [Dev] Should we refactor CarbonMessage
Hi Shafreen and Asitha, In the first place, they were introduced after a long discussion in WebSocket scenarios. This was because when the WebSocket messages are arrived to transport level we already knew what kind of message it is. Eg: Text, Binary, Control, Status So I made sense to create the same type of carbon message in the transport. Then carbon message types were used to identify the scenarios we had to address in the application layer. Eg: If the carbon message is an instance of TextCarbonMessage we know what to do in the first place. Also converting text into byte buffer in the transport and then converting it again into text in the application layer doesn't make sense. Because of that, those message types were introduced. IMO while we reduce the no. of carbon message types we might need to keep some of the types because it will affect the performance. Also, we can always override the methods in default carbon message if in order to work with default scenarios. WDYT? Thanks, Irunika *Irunika Weeraratne* *Software Engineer | WSO2, Inc. <http://wso2.com/>* *Email : irun...@wso2.com <irun...@wso2.com>* *LinkedIn : https://lk.linkedin.com/in/irunika <https://lk.linkedin.com/in/irunika>* *Mobile : +94712403314* *Lean . Enterprise . Middleware* On Wed, Jul 5, 2017 at 3:54 PM, Asitha Nanayakkara <asi...@wso2.com> wrote: > Hi Shafreen, > > I would suggest having a single Carbon Message with the option to set > different types of data sources as the data source for the message. For > that, we might need to go through the existing other message types and > think what kind of functionality to be added to carbon message. If our > intention is not to extend carbon message, we can make it a final class. If > not we have to design it to be extended by other users. > > When reading the payload multiple times (building the message) we need to > clone messages (since data is represented as a stream). In pass through > scenarios, we should avoid cloning the message and use the stream once. > IMO we can implement this functionality by way of having package level > methods for transport to read from the internal blocking queue and write to > the output stream. If we invoke other public methods they will make a clone > of the message data and use. This way we avoid unnecessary cloning in a > pass-through scenario. And reading from the blocking queue can only be done > from the transport. Outside users have to use message data source to read > the content, which might clone the data. > > WDYT? > > Regards, > Asitha > > On Wed, Jul 5, 2017 at 3:14 PM, Shafreen Anfar <shafr...@wso2.com> wrote: > >> Hi All, >> >> It seems there is room to improve the current CarbonMessage >> implementation. Following are few main areas where we can improve its >> functionality. >> >>- At the moment there are too many ways to get the message body from >>the CarbonMessage >>- getMessageBody() >> - getInputStream() - This is a http specific impl. >> - getMessageDateSource() >> >> >>- There are too many types of CarbonMessages in carbon-messaging that >>are only used by a specific transport implementation >> - BinaryCarbonMessage >> - ControlCarbonMessage >> - DefaultCarbonMessage >> - MapCarbonMessage >> - SerializableCarbonMessage >> - StatusCarbonMessage >> - StreamingCarbonMessage >> - TextCarbonMessage >> >> >>- Most of above CarbonMessages do not adhere to the contract that is >>imposed by the CarbonMessage interface. >> >> Considering these facts, I believe we should refactor CarbonMessage >> before others starting using it in their implementations. Please let us >> know your thoughts as well :) >> >> -- >> Regards, >> *Shafreen* >> Software Engineer >> WSO2 Inc >> Mobile : 077-556-395-1 >> > > > > -- > *Asitha Nanayakkara* <http://asitha.github.io/> > Senior Software Engineer > WSO2, Inc. <http://wso2.com/> > Mob: +94 77 853 0682 <+94%2077%20853%200682> > [image: https://wso2.com/signature] <https://wso2.com/signature> > > ___ Dev mailing list Dev@wso2.org http://wso2.org/cgi-bin/mailman/listinfo/dev
Re: [Dev] Modifying Carbon-Messaging Client Connector
Hi, I have a different perspective on this. What if we come up with our own session interface that can be used across > all the transports. For instance, in case of, websockets, I suppose > following are the APIs we want, > > - getID() > - write() // this should be able to handle text and binary payloads > - close() > - isValid() > If we look at the JSR-356 <http://www.oracle.com/technetwork/articles/java/jsr356-1937161.html>specification, there are a lot more APIs we have to introduce in this scenario. IMHO if we follow our own path we might miss things in the first place and might have to add new APIs in the future. Also not Ballerina but MSF4J is directly using java.websocket.Session API in the implementation. So we'd better go with the current approach. I think we can have a init method which returns an Object in the current implementation. So if someone needs a return object user can cast it and use. eg: Object init(CarbonMessage cMsg, Map<String, Object> properties); WDYT? Thanks, Irunika *Irunika Weeraratne* *Software Engineer | WSO2, Inc. <http://wso2.com/>* *Email : irun...@wso2.com <irun...@wso2.com>* *LinkedIn : https://lk.linkedin.com/in/irunika <https://lk.linkedin.com/in/irunika>* *Mobile : +94712403314* *Lean . Enterprise . Middleware* On Tue, Jul 4, 2017 at 3:43 PM, Shafreen Anfar <shafr...@wso2.com> wrote: > Hi All, > > What if we come up with our own session interface that can be used across > all the transports. For instance, in case of, websockets, I suppose > following are the APIs we want, > > - getID() > - write() // this should be able to handle text and binary payloads > - close() > - isValid() > > On Thu, Jun 29, 2017 at 4:08 PM, Irunika Weeraratne <irun...@wso2.com> > wrote: > >> Adding Amjadh and Arshardh >> >> *Irunika Weeraratne* >> *Software Engineer | WSO2, Inc. <http://wso2.com/>* >> *Email : irun...@wso2.com <irun...@wso2.com>* >> *LinkedIn : https://lk.linkedin.com/in/irunika >> <https://lk.linkedin.com/in/irunika>* >> *Mobile : +94712403314 <+94%2071%20240%203314>* >> *Lean . Enterprise . Middleware* >> >> >> On Thu, Jun 29, 2017 at 4:01 PM, Irunika Weeraratne <irun...@wso2.com> >> wrote: >> >>> Hi, >>> In the current client connector implementation, there is no way to >>> initiate a connection. Only send method is available. IMHO it makes >>> complications for protocols other than HTTP. >>> eg: JMS subscriber, Initiate WebSocket client, initiate File connector >>> >>> IMO it is better to have a init method for client connector and also it >>> is better to return an object in "send methods" other than a boolean so it >>> will reduce the complications for other protocol basis work. >>> >>> WDYT? >>> >>> Thanks, >>> Irunika >>> >>> *Irunika Weeraratne* >>> *Software Engineer | WSO2, Inc. <http://wso2.com/>* >>> *Email : irun...@wso2.com <irun...@wso2.com>* >>> *LinkedIn : https://lk.linkedin.com/in/irunika >>> <https://lk.linkedin.com/in/irunika>* >>> *Mobile : +94712403314 <+94%2071%20240%203314>* >>> *Lean . Enterprise . Middleware* >>> >>> >> > > > -- > Regards, > *Shafreen* > Software Engineer > WSO2 Inc > Mobile : 077-556-395-1 > ___ Dev mailing list Dev@wso2.org http://wso2.org/cgi-bin/mailman/listinfo/dev
Re: [Dev] Modifying Carbon-Messaging Client Connector
Adding Amjadh and Arshardh *Irunika Weeraratne* *Software Engineer | WSO2, Inc. <http://wso2.com/>* *Email : irun...@wso2.com <irun...@wso2.com>* *LinkedIn : https://lk.linkedin.com/in/irunika <https://lk.linkedin.com/in/irunika>* *Mobile : +94712403314* *Lean . Enterprise . Middleware* On Thu, Jun 29, 2017 at 4:01 PM, Irunika Weeraratne <irun...@wso2.com> wrote: > Hi, > In the current client connector implementation, there is no way to > initiate a connection. Only send method is available. IMHO it makes > complications for protocols other than HTTP. > eg: JMS subscriber, Initiate WebSocket client, initiate File connector > > IMO it is better to have a init method for client connector and also it is > better to return an object in "send methods" other than a boolean so it > will reduce the complications for other protocol basis work. > > WDYT? > > Thanks, > Irunika > > *Irunika Weeraratne* > *Software Engineer | WSO2, Inc. <http://wso2.com/>* > *Email : irun...@wso2.com <irun...@wso2.com>* > *LinkedIn : https://lk.linkedin.com/in/irunika > <https://lk.linkedin.com/in/irunika>* > *Mobile : +94712403314 <+94%2071%20240%203314>* > *Lean . Enterprise . Middleware* > > ___ Dev mailing list Dev@wso2.org http://wso2.org/cgi-bin/mailman/listinfo/dev
[Dev] Modifying Carbon-Messaging Client Connector
Hi, In the current client connector implementation, there is no way to initiate a connection. Only send method is available. IMHO it makes complications for protocols other than HTTP. eg: JMS subscriber, Initiate WebSocket client, initiate File connector IMO it is better to have a init method for client connector and also it is better to return an object in "send methods" other than a boolean so it will reduce the complications for other protocol basis work. WDYT? Thanks, Irunika *Irunika Weeraratne* *Software Engineer | WSO2, Inc. <http://wso2.com/>* *Email : irun...@wso2.com <irun...@wso2.com>* *LinkedIn : https://lk.linkedin.com/in/irunika <https://lk.linkedin.com/in/irunika>* *Mobile : +94712403314* *Lean . Enterprise . Middleware* ___ Dev mailing list Dev@wso2.org http://wso2.org/cgi-bin/mailman/listinfo/dev
[Dev] Please Review and Merge (WebSocket Client Connector)
Hi, Please review and merge this PR. https://github.com/wso2/carbon-transports/pull/287 Thanks, Irunika *Irunika Weeraratne* *Software Engineer | WSO2, Inc. <http://wso2.com/>* *Email : irun...@wso2.com <irun...@wso2.com>* *LinkedIn : https://lk.linkedin.com/in/irunika <https://lk.linkedin.com/in/irunika>* *Mobile : +94712403314* *Lean . Enterprise . Middleware* ___ Dev mailing list Dev@wso2.org http://wso2.org/cgi-bin/mailman/listinfo/dev
Re: [Dev] Changes for carbon-transport release-4.3.0-m1
Hi all, We need to come to a conclusion for this issue. In the current carbon-transport, in master branch we don't have OSGi support. But for MSF4J we need it. But we have OSGi support in the carbon-transports release-4.3.0-m1 branch. The issue is AFAIK there is a kernel dependency for OSGi and we need to get rid of it. Because of that, it had not been merged to master branch. But it has been used through a milestone release "4.3.0-m2" until the problem is sorted out. Of course, we can add necessary features for milestone release but there will be more inconsistencies if we continue this way. Can we please discuss on how we should proceed further since some work seems stuck with this issue? Thanks, Irunika *Irunika Weeraratne* *Software Engineer | WSO2, Inc. <http://wso2.com/>* *Email : irun...@wso2.com <irun...@wso2.com>* *LinkedIn : https://lk.linkedin.com/in/irunika <https://lk.linkedin.com/in/irunika>* *Mobile : +94712403314* *Lean . Enterprise . Middleware* On Mon, Apr 24, 2017 at 12:45 PM, Irunika Weeraratne <irun...@wso2.com> wrote: > Hi all, > There is a requirement to implement WebSocket session user properties for > *"[Architecture] > [Identity Cloud] Outbound on-premise user store"*. > Currently, MSF4J is in carbon-transport release-4.3.0-m1. We need to add > current changes to that release version. > So first I tried to merge the current master branch to release-4.3.0-m1. > But there are many file changes and it seems it is too risky to merge them > and do the change within this limited time. > So is it ok *not* to merge master branch to release-4.3.0-m1 branch and > do the necessary change only in release-4.3.0-m1 branch and do a milestone > release for now? > WDYT? > > Thanks, > Irunika > *Irunika Weeraratne* > *Software Engineer | WSO2, Inc. <http://wso2.com/>* > *Email : irun...@wso2.com <irun...@wso2.com>* > *LinkedIn : https://lk.linkedin.com/in/irunika > <https://lk.linkedin.com/in/irunika>* > *Mobile : +94712403314 <+94%2071%20240%203314>* > *Lean . Enterprise . Middleware* > > ___ Dev mailing list Dev@wso2.org http://wso2.org/cgi-bin/mailman/listinfo/dev
[Dev] Changes for carbon-transport release-4.3.0-m1
Hi all, There is a requirement to implement WebSocket session user properties for *"[Architecture] [Identity Cloud] Outbound on-premise user store"*. Currently, MSF4J is in carbon-transport release-4.3.0-m1. We need to add current changes to that release version. So first I tried to merge the current master branch to release-4.3.0-m1. But there are many file changes and it seems it is too risky to merge them and do the change within this limited time. So is it ok *not* to merge master branch to release-4.3.0-m1 branch and do the necessary change only in release-4.3.0-m1 branch and do a milestone release for now? WDYT? Thanks, Irunika *Irunika Weeraratne* *Software Engineer | WSO2, Inc. <http://wso2.com/>* *Email : irun...@wso2.com <irun...@wso2.com>* *LinkedIn : https://lk.linkedin.com/in/irunika <https://lk.linkedin.com/in/irunika>* *Mobile : +94712403314* *Lean . Enterprise . Middleware* ___ Dev mailing list Dev@wso2.org http://wso2.org/cgi-bin/mailman/listinfo/dev
Re: [Dev] MSF4J Websocket security token transmit
Hi Godwin, Yes we can do it. Can we have a small dicussion on Monday? Thanks, Irunika On Apr 21, 2017 8:00 PM, "Godwin Shrimal" <god...@wso2.com> wrote: > @adding Thusitha. > > As described above currently there is no way to extract headers from > Session in MSF4J and no interceptor support yet with websocket. Shall we > add the capability to extract headers from Session ? > > > Thanks > Godwin > > > On Fri, Apr 21, 2017 at 5:32 PM, Godwin Shrimal <god...@wso2.com> wrote: > >> Hi All, >> >> Here we are using websocket sever as MSF4J and client as netty, my >> problem is currently there is no way to extract headers from Session while >> handshake. >> >> Thanks >> Godwin >> >> On Fri, Apr 21, 2017 at 12:21 PM, Ayyoob Hamza <ayy...@wso2.com> wrote: >> >>> Hi >>> What would be solution if we are to initiate the connection from the >>> browser itself, AFAIK websocket library for browsers does not support >>> adding headers. >>> >>> Thanks, >>> >>> *Ayyoob Hamza* >>> *Senior Software Engineer* >>> WSO2 Inc.; http://wso2.com >>> email: ayy...@wso2.com cell: +94 77 1681010 <%2B94%2077%207779495> >>> >>> On Fri, Apr 21, 2017 at 11:32 AM, Irunika Weeraratne <irun...@wso2.com> >>> wrote: >>> >>>> Hi Godwin, >>>> IMHO the best way to do it using HTTP header. Are you using netty >>>> directly? If that so there is a way to add necessary headers for the >>>> initial handshake and we can check them in the server side. >>>> >>>> Thanks, >>>> Irunika >>>> >>>> *Irunika Weeraratne* >>>> *Software Engineer | WSO2, Inc. <http://wso2.com/>* >>>> *Email : irun...@wso2.com <irun...@wso2.com>* >>>> *LinkedIn : https://lk.linkedin.com/in/irunika >>>> <https://lk.linkedin.com/in/irunika>* >>>> *Mobile : +94712403314 <+94%2071%20240%203314>* >>>> *Lean . Enterprise . Middleware* >>>> >>>> >>>> On Fri, Apr 21, 2017 at 11:27 AM, Arshardh Ifthikar <arsha...@wso2.com> >>>> wrote: >>>> >>>>> You can find it here: https://docs.wso2.com/display/ >>>>> AM210/Create+a+WebSocket+API >>>>> >>>>> Thanks >>>>> >>>>> On Fri, Apr 21, 2017 at 11:24 AM, Godwin Shrimal <god...@wso2.com> >>>>> wrote: >>>>> >>>>>> Can you please share the relevant API Manager source ? >>>>>> >>>>>> >>>>>> Thanks >>>>>> Godwin >>>>>> >>>>>> On Fri, Apr 21, 2017 at 11:22 AM, Arshardh Ifthikar < >>>>>> arsha...@wso2.com> wrote: >>>>>> >>>>>>> Hi, >>>>>>> >>>>>>> IMHO the best approach would be to send it via a header in the >>>>>>> initial HTTP request used to establish the connection. This is the >>>>>>> method >>>>>>> we follow to send the access token for websocket APIs in the API >>>>>>> Manager. >>>>>>> >>>>>>> Thanks >>>>>>> Arshardh >>>>>>> >>>>>>> On Fri, Apr 21, 2017 at 11:11 AM, Godwin Shrimal <god...@wso2.com> >>>>>>> wrote: >>>>>>> >>>>>>>> Hi All, >>>>>>>> >>>>>>>> What is the best way to transmit a security token in web socket >>>>>>>> while establishing a connection ? Currently we are passing through path >>>>>>>> parameter such as wss://localhost:8080/server/ >>>>>>>> >>>>>>>> Is it secure to sent it via path parameter ? If not what is the >>>>>>>> correct approach ? >>>>>>>> >>>>>>>> >>>>>>>> Thanks >>>>>>>> Godwin >>>>>>>> >>>>>>>> -- >>>>>>>> *Godwin Amila Shrimal* >>>>>>>> WSO2 Inc.; http://wso2.com >>>>>>>> lean.enterprise.middleware >>>>>>>> >>>>>>>> mobile: *+94772264165* >>>>>>>> linkedin: *http://lnkd.in/KUum6D <http://lnkd.in/KUum6D>* >
Re: [Dev] MSF4J Websocket security token transmit
Hi Godwin, IMHO the best way to do it using HTTP header. Are you using netty directly? If that so there is a way to add necessary headers for the initial handshake and we can check them in the server side. Thanks, Irunika *Irunika Weeraratne* *Software Engineer | WSO2, Inc. <http://wso2.com/>* *Email : irun...@wso2.com <irun...@wso2.com>* *LinkedIn : https://lk.linkedin.com/in/irunika <https://lk.linkedin.com/in/irunika>* *Mobile : +94712403314* *Lean . Enterprise . Middleware* On Fri, Apr 21, 2017 at 11:27 AM, Arshardh Ifthikar <arsha...@wso2.com> wrote: > You can find it here: https://docs.wso2.com/display/ > AM210/Create+a+WebSocket+API > > Thanks > > On Fri, Apr 21, 2017 at 11:24 AM, Godwin Shrimal <god...@wso2.com> wrote: > >> Can you please share the relevant API Manager source ? >> >> >> Thanks >> Godwin >> >> On Fri, Apr 21, 2017 at 11:22 AM, Arshardh Ifthikar <arsha...@wso2.com> >> wrote: >> >>> Hi, >>> >>> IMHO the best approach would be to send it via a header in the initial >>> HTTP request used to establish the connection. This is the method we follow >>> to send the access token for websocket APIs in the API Manager. >>> >>> Thanks >>> Arshardh >>> >>> On Fri, Apr 21, 2017 at 11:11 AM, Godwin Shrimal <god...@wso2.com> >>> wrote: >>> >>>> Hi All, >>>> >>>> What is the best way to transmit a security token in web socket while >>>> establishing a connection ? Currently we are passing through path parameter >>>> such as wss://localhost:8080/server/ >>>> >>>> Is it secure to sent it via path parameter ? If not what is the correct >>>> approach ? >>>> >>>> >>>> Thanks >>>> Godwin >>>> >>>> -- >>>> *Godwin Amila Shrimal* >>>> WSO2 Inc.; http://wso2.com >>>> lean.enterprise.middleware >>>> >>>> mobile: *+94772264165* >>>> linkedin: *http://lnkd.in/KUum6D <http://lnkd.in/KUum6D>* >>>> twitter: https://twitter.com/godwinamila >>>> <http://wso2.com/signature> >>>> >>>> ___ >>>> Dev mailing list >>>> Dev@wso2.org >>>> http://wso2.org/cgi-bin/mailman/listinfo/dev >>>> >>>> >>> >>> >>> -- >>> *Arshardh Ifthikar* >>> Trainee Software Engineer >>> WSO2, Inc. >>> Mobile: +94719806525 <+94%2071%20980%206525> >>> >> >> >> >> -- >> *Godwin Amila Shrimal* >> WSO2 Inc.; http://wso2.com >> lean.enterprise.middleware >> >> mobile: *+94772264165* >> linkedin: *http://lnkd.in/KUum6D <http://lnkd.in/KUum6D>* >> twitter: https://twitter.com/godwinamila >> <http://wso2.com/signature> >> > > > > -- > *Arshardh Ifthikar* > Trainee Software Engineer > WSO2, Inc. > Mobile: +94719806525 <+94%2071%20980%206525> > ___ Dev mailing list Dev@wso2.org http://wso2.org/cgi-bin/mailman/listinfo/dev
[Dev] PR of Client Connector for WebSocket
Hi all, Please review and comment on the $subject. https://github.com/wso2/carbon-transports/pull/260 Thanks and best regards, Irunika *Irunika Weeraratne* *Software Engineer | WSO2, Inc. <http://wso2.com/>* *Email : irun...@wso2.com <irun...@wso2.com>* *LinkedIn : https://lk.linkedin.com/in/irunika <https://lk.linkedin.com/in/irunika>* *Mobile : +94712403314 <+94%2071%20240%203314>* *Lean . Enterprise . Middleware* ___ Dev mailing list Dev@wso2.org http://wso2.org/cgi-bin/mailman/listinfo/dev
[Dev] PR - WebSocket Server Connector Support for Ballerina
Hi, Please review the PR and comment. https://github.com/ballerinalang/ballerina/pull/2210 Thanks, Irunika *Irunika Weeraratne* *Software Engineer | WSO2, Inc. <http://wso2.com/>* *Email : irun...@wso2.com <irun...@wso2.com>* *LinkedIn : https://lk.linkedin.com/in/irunika <https://lk.linkedin.com/in/irunika>* *Mobile : +94712403314 <+94%2071%20240%203314>* *Lean . Enterprise . Middleware* ___ Dev mailing list Dev@wso2.org http://wso2.org/cgi-bin/mailman/listinfo/dev
Re: [Dev] Please Review and Merge (WebSocket Suppport for Carbon-Messaging)
Hi all, Above PR has been closed since it ha2 two branches merged and make so many confusions and also make it very hard to maintain the code. So all the comments from the above PR will be resolved and cleaned in https://github.com/wso2/msf4j/pull/365 Please review and comment. Thanks and best regards, Irunika *Irunika Weeraratne* *Software Engineer | WSO2, Inc. <http://wso2.com/>* *Email : irun...@wso2.com <irun...@wso2.com>* *LinkedIn : https://lk.linkedin.com/in/irunika <https://lk.linkedin.com/in/irunika>* *Mobile : +94712403314* *Lean . Enterprise . Middleware* On Wed, Mar 8, 2017 at 6:21 PM, Irunika Weeraratne <irun...@wso2.com> wrote: > Hi all, > Please review the new changes did and comment. > > https://github.com/wso2/msf4j/pull/364 > > Thanks, > Irunika > > *Irunika Weeraratne* > *Software Engineer | WSO2, Inc. <http://wso2.com/>* > *Email : irun...@wso2.com <irun...@wso2.com>* > *LinkedIn : https://lk.linkedin.com/in/irunika > <https://lk.linkedin.com/in/irunika>* > *Mobile : +94712403314 <+94%2071%20240%203314>* > *Lean . Enterprise . Middleware* > > > On Wed, Feb 1, 2017 at 3:28 PM, Irunika Weeraratne <irun...@wso2.com> > wrote: > >> Hi all, >> Created new pull request with necessary changes[1]. >> >> please review and merge. >> >> [1]https://github.com/wso2/carbon-messaging/pull/41 >> >> Thanks, >> Irunika >> >> *Irunika Weeraratne* >> *Software Engineer | WSO2, Inc. <http://wso2.com/>* >> *Email : irun...@wso2.com <irun...@wso2.com>* >> *LinkedIn : https://lk.linkedin.com/in/irunika >> <https://lk.linkedin.com/in/irunika>* >> *Mobile : +94712403314 <+94%2071%20240%203314>* >> *Lean . Enterprise . Middleware* >> >> >> On Mon, Jan 30, 2017 at 8:34 PM, Irunika Weeraratne <irun...@wso2.com> >> wrote: >> >>> Hi Senduran, >>> Yes. We can use a general control message type instead of ping and pong >>> messages. So I removed ping and pong carbon message types from >>> Carbon-Messaging and added new message type ". >>> >>> Please review and merge. >>> >>> Thanks, >>> Irunika >>> >>> *Irunika Weeraratne* >>> *Software Engineer | WSO2, Inc. <http://wso2.com/>* >>> *Email : irun...@wso2.com <irun...@wso2.com>* >>> *LinkedIn : https://lk.linkedin.com/in/irunika >>> <https://lk.linkedin.com/in/irunika>* >>> *Mobile : +94712403314 <+94%2071%20240%203314>* >>> *Lean . Enterprise . Middleware* >>> >>> >>> On Mon, Jan 30, 2017 at 2:20 PM, Senduran Balasubramaniyam < >>> sendu...@wso2.com> wrote: >>> >>>> Hi Irunika, >>>> >>>> The above PR has PingCarbonMessage and PongCarbonMessage. It will be >>>> better if you could rename those two classes to generalized name. >>>> >>>> Regards >>>> Senduran >>>> >>>> On Fri, Jan 27, 2017 at 2:47 PM, Kishanthan Thangarajah < >>>> kishant...@wso2.com> wrote: >>>> >>>>> Looks ok. >>>>> >>>>> Senduran/Shafreen, can we merge this PR? >>>>> >>>>> On Thu, Jan 26, 2017 at 7:27 PM, Irunika Weeraratne <irun...@wso2.com> >>>>> wrote: >>>>> >>>>>> Hi, >>>>>> Fixed the issues mentioned. >>>>>> Please review and merge. >>>>>> >>>>>> Thanks, >>>>>> Irunika >>>>>> >>>>>> *Irunika Weeraratne* >>>>>> *Software Engineer | WSO2, Inc. <http://wso2.com/>* >>>>>> *Email : irun...@wso2.com <irun...@wso2.com>* >>>>>> *LinkedIn : https://lk.linkedin.com/in/irunika >>>>>> <https://lk.linkedin.com/in/irunika>* >>>>>> *Mobile : +94712403314 <+94%2071%20240%203314>* >>>>>> *Lean . Enterprise . Middleware* >>>>>> >>>>>> >>>>>> On Thu, Jan 26, 2017 at 7:04 PM, Irunika Weeraratne <irun...@wso2.com >>>>>> > wrote: >>>>>> >>>>>>> Noted. >>>>>>> >>>>>>> Thanks, >>>>>>> Irunika >>>>>>> >>>>>>> *Irunika Weeraratne* >>>>>>> *Software Engineer | WSO2, Inc. <http://wso2.com/>* >>>>>>> *Email : irun...@wso2.com <iru
Re: [Dev] Please Review and Merge (WebSocket Suppport for Carbon-Messaging)
Hi all, Above PR has been closed since it ha2 two branches merged and make so many confusions and also make it very hard to maintain the code. So all the comments from the above PR will be resolved and cleaned in https://github.com/wso2/msf4j/pull/365 Please review and comment. Thanks and best regards, Irunika *Irunika Weeraratne* *Software Engineer | WSO2, Inc. <http://wso2.com/>* *Email : irun...@wso2.com <irun...@wso2.com>* *LinkedIn : https://lk.linkedin.com/in/irunika <https://lk.linkedin.com/in/irunika>* *Mobile : +94712403314* *Lean . Enterprise . Middleware* On Thu, Mar 9, 2017 at 10:36 AM, Irunika Weeraratne <irun...@wso2.com> wrote: > Thanks Vidura. Will check. > > *Irunika Weeraratne* > *Software Engineer | WSO2, Inc. <http://wso2.com/>* > *Email : irun...@wso2.com <irun...@wso2.com>* > *LinkedIn : https://lk.linkedin.com/in/irunika > <https://lk.linkedin.com/in/irunika>* > *Mobile : +94712403314 <+94%2071%20240%203314>* > *Lean . Enterprise . Middleware* > > > On Thu, Mar 9, 2017 at 10:34 AM, Vidura Nanayakkara <vidu...@wso2.com> > wrote: > >> Hi Irunika, >> >> Added some comments in [1] <https://github.com/wso2/msf4j/pull/364>. >> Please do check. >> >> [1] MSF4J Web Socket Pull Request >> <https://github.com/wso2/msf4j/pull/364> >> >> Thank you, >> Vidura Nanayakkara >> >> On Wed, Mar 8, 2017 at 6:21 PM, Irunika Weeraratne <irun...@wso2.com> >> wrote: >> >>> Hi all, >>> Please review the new changes did and comment. >>> >>> https://github.com/wso2/msf4j/pull/364 >>> >>> Thanks, >>> Irunika >>> >>> *Irunika Weeraratne* >>> *Software Engineer | WSO2, Inc. <http://wso2.com/>* >>> *Email : irun...@wso2.com <irun...@wso2.com>* >>> *LinkedIn : https://lk.linkedin.com/in/irunika >>> <https://lk.linkedin.com/in/irunika>* >>> *Mobile : +94712403314 <+94%2071%20240%203314>* >>> *Lean . Enterprise . Middleware* >>> >>> >>> On Wed, Feb 1, 2017 at 3:28 PM, Irunika Weeraratne <irun...@wso2.com> >>> wrote: >>> >>>> Hi all, >>>> Created new pull request with necessary changes[1]. >>>> >>>> please review and merge. >>>> >>>> [1]https://github.com/wso2/carbon-messaging/pull/41 >>>> >>>> Thanks, >>>> Irunika >>>> >>>> *Irunika Weeraratne* >>>> *Software Engineer | WSO2, Inc. <http://wso2.com/>* >>>> *Email : irun...@wso2.com <irun...@wso2.com>* >>>> *LinkedIn : https://lk.linkedin.com/in/irunika >>>> <https://lk.linkedin.com/in/irunika>* >>>> *Mobile : +94712403314 <+94%2071%20240%203314>* >>>> *Lean . Enterprise . Middleware* >>>> >>>> >>>> On Mon, Jan 30, 2017 at 8:34 PM, Irunika Weeraratne <irun...@wso2.com> >>>> wrote: >>>> >>>>> Hi Senduran, >>>>> Yes. We can use a general control message type instead of ping and >>>>> pong messages. So I removed ping and pong carbon message types from >>>>> Carbon-Messaging and added new message type ". >>>>> >>>>> Please review and merge. >>>>> >>>>> Thanks, >>>>> Irunika >>>>> >>>>> *Irunika Weeraratne* >>>>> *Software Engineer | WSO2, Inc. <http://wso2.com/>* >>>>> *Email : irun...@wso2.com <irun...@wso2.com>* >>>>> *LinkedIn : https://lk.linkedin.com/in/irunika >>>>> <https://lk.linkedin.com/in/irunika>* >>>>> *Mobile : +94712403314 <+94%2071%20240%203314>* >>>>> *Lean . Enterprise . Middleware* >>>>> >>>>> >>>>> On Mon, Jan 30, 2017 at 2:20 PM, Senduran Balasubramaniyam < >>>>> sendu...@wso2.com> wrote: >>>>> >>>>>> Hi Irunika, >>>>>> >>>>>> The above PR has PingCarbonMessage and PongCarbonMessage. It will be >>>>>> better if you could rename those two classes to generalized name. >>>>>> >>>>>> Regards >>>>>> Senduran >>>>>> >>>>>> On Fri, Jan 27, 2017 at 2:47 PM, Kishanthan Thangarajah < >>>>>> kishant...@wso2.com> wrote: >>>>>> >>>>>>> Looks ok. >>>>>>> >>
Re: [Dev] Please Review and Merge (WebSocket Suppport for Carbon-Messaging)
Thanks Vidura. Will check. *Irunika Weeraratne* *Software Engineer | WSO2, Inc. <http://wso2.com/>* *Email : irun...@wso2.com <irun...@wso2.com>* *LinkedIn : https://lk.linkedin.com/in/irunika <https://lk.linkedin.com/in/irunika>* *Mobile : +94712403314* *Lean . Enterprise . Middleware* On Thu, Mar 9, 2017 at 10:34 AM, Vidura Nanayakkara <vidu...@wso2.com> wrote: > Hi Irunika, > > Added some comments in [1] <https://github.com/wso2/msf4j/pull/364>. > Please do check. > > [1] MSF4J Web Socket Pull Request <https://github.com/wso2/msf4j/pull/364> > > Thank you, > Vidura Nanayakkara > > On Wed, Mar 8, 2017 at 6:21 PM, Irunika Weeraratne <irun...@wso2.com> > wrote: > >> Hi all, >> Please review the new changes did and comment. >> >> https://github.com/wso2/msf4j/pull/364 >> >> Thanks, >> Irunika >> >> *Irunika Weeraratne* >> *Software Engineer | WSO2, Inc. <http://wso2.com/>* >> *Email : irun...@wso2.com <irun...@wso2.com>* >> *LinkedIn : https://lk.linkedin.com/in/irunika >> <https://lk.linkedin.com/in/irunika>* >> *Mobile : +94712403314 <+94%2071%20240%203314>* >> *Lean . Enterprise . Middleware* >> >> >> On Wed, Feb 1, 2017 at 3:28 PM, Irunika Weeraratne <irun...@wso2.com> >> wrote: >> >>> Hi all, >>> Created new pull request with necessary changes[1]. >>> >>> please review and merge. >>> >>> [1]https://github.com/wso2/carbon-messaging/pull/41 >>> >>> Thanks, >>> Irunika >>> >>> *Irunika Weeraratne* >>> *Software Engineer | WSO2, Inc. <http://wso2.com/>* >>> *Email : irun...@wso2.com <irun...@wso2.com>* >>> *LinkedIn : https://lk.linkedin.com/in/irunika >>> <https://lk.linkedin.com/in/irunika>* >>> *Mobile : +94712403314 <+94%2071%20240%203314>* >>> *Lean . Enterprise . Middleware* >>> >>> >>> On Mon, Jan 30, 2017 at 8:34 PM, Irunika Weeraratne <irun...@wso2.com> >>> wrote: >>> >>>> Hi Senduran, >>>> Yes. We can use a general control message type instead of ping and pong >>>> messages. So I removed ping and pong carbon message types from >>>> Carbon-Messaging and added new message type ". >>>> >>>> Please review and merge. >>>> >>>> Thanks, >>>> Irunika >>>> >>>> *Irunika Weeraratne* >>>> *Software Engineer | WSO2, Inc. <http://wso2.com/>* >>>> *Email : irun...@wso2.com <irun...@wso2.com>* >>>> *LinkedIn : https://lk.linkedin.com/in/irunika >>>> <https://lk.linkedin.com/in/irunika>* >>>> *Mobile : +94712403314 <+94%2071%20240%203314>* >>>> *Lean . Enterprise . Middleware* >>>> >>>> >>>> On Mon, Jan 30, 2017 at 2:20 PM, Senduran Balasubramaniyam < >>>> sendu...@wso2.com> wrote: >>>> >>>>> Hi Irunika, >>>>> >>>>> The above PR has PingCarbonMessage and PongCarbonMessage. It will be >>>>> better if you could rename those two classes to generalized name. >>>>> >>>>> Regards >>>>> Senduran >>>>> >>>>> On Fri, Jan 27, 2017 at 2:47 PM, Kishanthan Thangarajah < >>>>> kishant...@wso2.com> wrote: >>>>> >>>>>> Looks ok. >>>>>> >>>>>> Senduran/Shafreen, can we merge this PR? >>>>>> >>>>>> On Thu, Jan 26, 2017 at 7:27 PM, Irunika Weeraratne <irun...@wso2.com >>>>>> > wrote: >>>>>> >>>>>>> Hi, >>>>>>> Fixed the issues mentioned. >>>>>>> Please review and merge. >>>>>>> >>>>>>> Thanks, >>>>>>> Irunika >>>>>>> >>>>>>> *Irunika Weeraratne* >>>>>>> *Software Engineer | WSO2, Inc. <http://wso2.com/>* >>>>>>> *Email : irun...@wso2.com <irun...@wso2.com>* >>>>>>> *LinkedIn : https://lk.linkedin.com/in/irunika >>>>>>> <https://lk.linkedin.com/in/irunika>* >>>>>>> *Mobile : +94712403314 <+94%2071%20240%203314>* >>>>>>> *Lean . Enterprise . Middleware* >>>>>>> >>>>>>> >>>>>>> On Thu, Jan 26, 2017 at 7:04 PM, I
Re: [Dev] Please Review and Merge (WebSocket Suppport for Carbon-Messaging)
Hi all, Please review the new changes did and comment. https://github.com/wso2/msf4j/pull/364 Thanks, Irunika *Irunika Weeraratne* *Software Engineer | WSO2, Inc. <http://wso2.com/>* *Email : irun...@wso2.com <irun...@wso2.com>* *LinkedIn : https://lk.linkedin.com/in/irunika <https://lk.linkedin.com/in/irunika>* *Mobile : +94712403314* *Lean . Enterprise . Middleware* On Wed, Feb 1, 2017 at 3:28 PM, Irunika Weeraratne <irun...@wso2.com> wrote: > Hi all, > Created new pull request with necessary changes[1]. > > please review and merge. > > [1]https://github.com/wso2/carbon-messaging/pull/41 > > Thanks, > Irunika > > *Irunika Weeraratne* > *Software Engineer | WSO2, Inc. <http://wso2.com/>* > *Email : irun...@wso2.com <irun...@wso2.com>* > *LinkedIn : https://lk.linkedin.com/in/irunika > <https://lk.linkedin.com/in/irunika>* > *Mobile : +94712403314 <+94%2071%20240%203314>* > *Lean . Enterprise . Middleware* > > > On Mon, Jan 30, 2017 at 8:34 PM, Irunika Weeraratne <irun...@wso2.com> > wrote: > >> Hi Senduran, >> Yes. We can use a general control message type instead of ping and pong >> messages. So I removed ping and pong carbon message types from >> Carbon-Messaging and added new message type ". >> >> Please review and merge. >> >> Thanks, >> Irunika >> >> *Irunika Weeraratne* >> *Software Engineer | WSO2, Inc. <http://wso2.com/>* >> *Email : irun...@wso2.com <irun...@wso2.com>* >> *LinkedIn : https://lk.linkedin.com/in/irunika >> <https://lk.linkedin.com/in/irunika>* >> *Mobile : +94712403314 <+94%2071%20240%203314>* >> *Lean . Enterprise . Middleware* >> >> >> On Mon, Jan 30, 2017 at 2:20 PM, Senduran Balasubramaniyam < >> sendu...@wso2.com> wrote: >> >>> Hi Irunika, >>> >>> The above PR has PingCarbonMessage and PongCarbonMessage. It will be >>> better if you could rename those two classes to generalized name. >>> >>> Regards >>> Senduran >>> >>> On Fri, Jan 27, 2017 at 2:47 PM, Kishanthan Thangarajah < >>> kishant...@wso2.com> wrote: >>> >>>> Looks ok. >>>> >>>> Senduran/Shafreen, can we merge this PR? >>>> >>>> On Thu, Jan 26, 2017 at 7:27 PM, Irunika Weeraratne <irun...@wso2.com> >>>> wrote: >>>> >>>>> Hi, >>>>> Fixed the issues mentioned. >>>>> Please review and merge. >>>>> >>>>> Thanks, >>>>> Irunika >>>>> >>>>> *Irunika Weeraratne* >>>>> *Software Engineer | WSO2, Inc. <http://wso2.com/>* >>>>> *Email : irun...@wso2.com <irun...@wso2.com>* >>>>> *LinkedIn : https://lk.linkedin.com/in/irunika >>>>> <https://lk.linkedin.com/in/irunika>* >>>>> *Mobile : +94712403314 <+94%2071%20240%203314>* >>>>> *Lean . Enterprise . Middleware* >>>>> >>>>> >>>>> On Thu, Jan 26, 2017 at 7:04 PM, Irunika Weeraratne <irun...@wso2.com> >>>>> wrote: >>>>> >>>>>> Noted. >>>>>> >>>>>> Thanks, >>>>>> Irunika >>>>>> >>>>>> *Irunika Weeraratne* >>>>>> *Software Engineer | WSO2, Inc. <http://wso2.com/>* >>>>>> *Email : irun...@wso2.com <irun...@wso2.com>* >>>>>> *LinkedIn : https://lk.linkedin.com/in/irunika >>>>>> <https://lk.linkedin.com/in/irunika>* >>>>>> *Mobile : +94712403314 <+94%2071%20240%203314>* >>>>>> *Lean . Enterprise . Middleware* >>>>>> >>>>>> >>>>>> On Thu, Jan 26, 2017 at 4:34 PM, Kishanthan Thangarajah < >>>>>> kishant...@wso2.com> wrote: >>>>>> >>>>>>> PR has some formatting issue to be fixed. Can you look into it? >>>>>>> >>>>>>> On Thu, Jan 26, 2017 at 12:03 PM, Irunika Weeraratne < >>>>>>> irun...@wso2.com> wrote: >>>>>>> >>>>>>>> Hi all, >>>>>>>> Can you please review and merge the PR? >>>>>>>> >>>>>>>> Thanks, >>>>>>>> Irunika >>>>>>>> >>>>>>>> *Irunika Weeraratne* >>>>>>>> *Software
Re: [Dev] WSO2 Committers += Nisala Nanayakkara
Congratulations Nisala *Irunika Weeraratne* *Software Engineer | WSO2, Inc. <http://wso2.com/>* *Email : irun...@wso2.com <irun...@wso2.com>* *LinkedIn : https://lk.linkedin.com/in/irunika <https://lk.linkedin.com/in/irunika>* *Mobile : +94712403314* *Lean . Enterprise . Middleware* On Tue, Feb 28, 2017 at 2:20 PM, Heshitha Hettihewa <heshit...@wso2.com> wrote: > Congratz Nisala!!! :) > > On Tue, Feb 28, 2017 at 2:18 PM, Chanaka Cooray <chana...@wso2.com> wrote: > >> Congratz Nisala :) >> >> On Tue, Feb 28, 2017 at 2:16 PM, Sinthuja Ragendran <sinth...@wso2.com> >> wrote: >> >>> Hi All, >>> >>> It's my pleasure to welcome Nisala Nanayakkara as a WSO2 Committer. >>> >>> Nisala has been a valuable contributor to the Dashboard Server Team and >>> then Platform Team. In recognition of his contribution, dedication and >>> commitment he has been voted as a WSO2 committer. >>> >>> Nisala, welcome aboard and keep up the good work! >>> >>> Thanks, >>> Sinthuja. >>> >>> -- >>> *Sinthuja Rajendran* >>> Technical Lead >>> WSO2, Inc.:http://wso2.com >>> >>> Blog: http://sinthu-rajan.blogspot.com/ >>> Mobile: +94774273955 <+94%2077%20427%203955> >>> >>> >>> >>> ___ >>> Dev mailing list >>> Dev@wso2.org >>> http://wso2.org/cgi-bin/mailman/listinfo/dev >>> >>> >> >> >> -- >> Chanaka Cooray >> Software Engineer, WSO2 Inc. http://wso2.com >> Email: chana...@wso2.com >> Mobile: +94713149860 <+94%2071%20314%209860> >> <https://wso2.com/signature> >> >> ___ >> Dev mailing list >> Dev@wso2.org >> http://wso2.org/cgi-bin/mailman/listinfo/dev >> >> > > > -- > Heshitha Hettihewa > *Software Engineer* > Mobile : +94716866386 > <%2B94%20%280%29%20773%20451194> > heshit...@wso2.com > > ___ > Dev mailing list > Dev@wso2.org > http://wso2.org/cgi-bin/mailman/listinfo/dev > > ___ Dev mailing list Dev@wso2.org http://wso2.org/cgi-bin/mailman/listinfo/dev
[Dev] Fixed the Issue with Testng Configurations
Hi all, There was a problem with testng is not aware of the test classes configured in the testng.xml. Please find the following PR fixing the problem. Please review and merge. https://github.com/wso2/carbon-transports/pull/226 Thanks, Irunika *Irunika Weeraratne* *Software Engineer | WSO2, Inc. <http://wso2.com/>* *Email : irun...@wso2.com <irun...@wso2.com>* *LinkedIn : https://lk.linkedin.com/in/irunika <https://lk.linkedin.com/in/irunika>* *Mobile : +94712403314* *Lean . Enterprise . Middleware* ___ Dev mailing list Dev@wso2.org http://wso2.org/cgi-bin/mailman/listinfo/dev
[Dev] Test Cases for WebSocket in Carbon-Transport
Hi all, Please review the PR and give feedback. https://github.com/wso2/carbon-transports/pull/223 Thanks, Irunika *Irunika Weeraratne* *Software Engineer | WSO2, Inc. <http://wso2.com/>* *Email : irun...@wso2.com <irun...@wso2.com>* *LinkedIn : https://lk.linkedin.com/in/irunika <https://lk.linkedin.com/in/irunika>* *Mobile : +94712403314* *Lean . Enterprise . Middleware* ___ Dev mailing list Dev@wso2.org http://wso2.org/cgi-bin/mailman/listinfo/dev
Re: [Dev] Please Review and Merge (WebSocket Suppport for Carbon-Messaging)
Hi all, Created new pull request with necessary changes[1]. please review and merge. [1]https://github.com/wso2/carbon-messaging/pull/41 Thanks, Irunika *Irunika Weeraratne* *Software Engineer | WSO2, Inc. <http://wso2.com/>* *Email : irun...@wso2.com <irun...@wso2.com>* *LinkedIn : https://lk.linkedin.com/in/irunika <https://lk.linkedin.com/in/irunika>* *Mobile : +94712403314* *Lean . Enterprise . Middleware* On Mon, Jan 30, 2017 at 8:34 PM, Irunika Weeraratne <irun...@wso2.com> wrote: > Hi Senduran, > Yes. We can use a general control message type instead of ping and pong > messages. So I removed ping and pong carbon message types from > Carbon-Messaging and added new message type ". > > Please review and merge. > > Thanks, > Irunika > > *Irunika Weeraratne* > *Software Engineer | WSO2, Inc. <http://wso2.com/>* > *Email : irun...@wso2.com <irun...@wso2.com>* > *LinkedIn : https://lk.linkedin.com/in/irunika > <https://lk.linkedin.com/in/irunika>* > *Mobile : +94712403314 <+94%2071%20240%203314>* > *Lean . Enterprise . Middleware* > > > On Mon, Jan 30, 2017 at 2:20 PM, Senduran Balasubramaniyam < > sendu...@wso2.com> wrote: > >> Hi Irunika, >> >> The above PR has PingCarbonMessage and PongCarbonMessage. It will be >> better if you could rename those two classes to generalized name. >> >> Regards >> Senduran >> >> On Fri, Jan 27, 2017 at 2:47 PM, Kishanthan Thangarajah < >> kishant...@wso2.com> wrote: >> >>> Looks ok. >>> >>> Senduran/Shafreen, can we merge this PR? >>> >>> On Thu, Jan 26, 2017 at 7:27 PM, Irunika Weeraratne <irun...@wso2.com> >>> wrote: >>> >>>> Hi, >>>> Fixed the issues mentioned. >>>> Please review and merge. >>>> >>>> Thanks, >>>> Irunika >>>> >>>> *Irunika Weeraratne* >>>> *Software Engineer | WSO2, Inc. <http://wso2.com/>* >>>> *Email : irun...@wso2.com <irun...@wso2.com>* >>>> *LinkedIn : https://lk.linkedin.com/in/irunika >>>> <https://lk.linkedin.com/in/irunika>* >>>> *Mobile : +94712403314 <+94%2071%20240%203314>* >>>> *Lean . Enterprise . Middleware* >>>> >>>> >>>> On Thu, Jan 26, 2017 at 7:04 PM, Irunika Weeraratne <irun...@wso2.com> >>>> wrote: >>>> >>>>> Noted. >>>>> >>>>> Thanks, >>>>> Irunika >>>>> >>>>> *Irunika Weeraratne* >>>>> *Software Engineer | WSO2, Inc. <http://wso2.com/>* >>>>> *Email : irun...@wso2.com <irun...@wso2.com>* >>>>> *LinkedIn : https://lk.linkedin.com/in/irunika >>>>> <https://lk.linkedin.com/in/irunika>* >>>>> *Mobile : +94712403314 <+94%2071%20240%203314>* >>>>> *Lean . Enterprise . Middleware* >>>>> >>>>> >>>>> On Thu, Jan 26, 2017 at 4:34 PM, Kishanthan Thangarajah < >>>>> kishant...@wso2.com> wrote: >>>>> >>>>>> PR has some formatting issue to be fixed. Can you look into it? >>>>>> >>>>>> On Thu, Jan 26, 2017 at 12:03 PM, Irunika Weeraratne < >>>>>> irun...@wso2.com> wrote: >>>>>> >>>>>>> Hi all, >>>>>>> Can you please review and merge the PR? >>>>>>> >>>>>>> Thanks, >>>>>>> Irunika >>>>>>> >>>>>>> *Irunika Weeraratne* >>>>>>> *Software Engineer | WSO2, Inc. <http://wso2.com/>* >>>>>>> *Email : irun...@wso2.com <irun...@wso2.com>* >>>>>>> *LinkedIn : https://lk.linkedin.com/in/irunika >>>>>>> <https://lk.linkedin.com/in/irunika>* >>>>>>> *Mobile : +94712403314 <+94%2071%20240%203314>* >>>>>>> *Lean . Enterprise . Middleware* >>>>>>> >>>>>>> >>>>>>> On Wed, Jan 25, 2017 at 3:35 PM, Irunika Weeraratne < >>>>>>> irun...@wso2.com> wrote: >>>>>>> >>>>>>>> Hi all, >>>>>>>> I modified the Carbon-Messaging according to the requirements. >>>>>>>> Please review and merge. >>>>>>>> https://github.com/wso2/carbon-messaging/pull/40 >>>>>>>>
Re: [Dev] Please Review and Merge (WebSocket Suppport for Carbon-Messaging)
Hi Senduran, Yes. We can use a general control message type instead of ping and pong messages. So I removed ping and pong carbon message types from Carbon-Messaging and added new message type ". Please review and merge. Thanks, Irunika *Irunika Weeraratne* *Software Engineer | WSO2, Inc. <http://wso2.com/>* *Email : irun...@wso2.com <irun...@wso2.com>* *LinkedIn : https://lk.linkedin.com/in/irunika <https://lk.linkedin.com/in/irunika>* *Mobile : +94712403314* *Lean . Enterprise . Middleware* On Mon, Jan 30, 2017 at 2:20 PM, Senduran Balasubramaniyam < sendu...@wso2.com> wrote: > Hi Irunika, > > The above PR has PingCarbonMessage and PongCarbonMessage. It will be > better if you could rename those two classes to generalized name. > > Regards > Senduran > > On Fri, Jan 27, 2017 at 2:47 PM, Kishanthan Thangarajah < > kishant...@wso2.com> wrote: > >> Looks ok. >> >> Senduran/Shafreen, can we merge this PR? >> >> On Thu, Jan 26, 2017 at 7:27 PM, Irunika Weeraratne <irun...@wso2.com> >> wrote: >> >>> Hi, >>> Fixed the issues mentioned. >>> Please review and merge. >>> >>> Thanks, >>> Irunika >>> >>> *Irunika Weeraratne* >>> *Software Engineer | WSO2, Inc. <http://wso2.com/>* >>> *Email : irun...@wso2.com <irun...@wso2.com>* >>> *LinkedIn : https://lk.linkedin.com/in/irunika >>> <https://lk.linkedin.com/in/irunika>* >>> *Mobile : +94712403314 <+94%2071%20240%203314>* >>> *Lean . Enterprise . Middleware* >>> >>> >>> On Thu, Jan 26, 2017 at 7:04 PM, Irunika Weeraratne <irun...@wso2.com> >>> wrote: >>> >>>> Noted. >>>> >>>> Thanks, >>>> Irunika >>>> >>>> *Irunika Weeraratne* >>>> *Software Engineer | WSO2, Inc. <http://wso2.com/>* >>>> *Email : irun...@wso2.com <irun...@wso2.com>* >>>> *LinkedIn : https://lk.linkedin.com/in/irunika >>>> <https://lk.linkedin.com/in/irunika>* >>>> *Mobile : +94712403314 <+94%2071%20240%203314>* >>>> *Lean . Enterprise . Middleware* >>>> >>>> >>>> On Thu, Jan 26, 2017 at 4:34 PM, Kishanthan Thangarajah < >>>> kishant...@wso2.com> wrote: >>>> >>>>> PR has some formatting issue to be fixed. Can you look into it? >>>>> >>>>> On Thu, Jan 26, 2017 at 12:03 PM, Irunika Weeraratne <irun...@wso2.com >>>>> > wrote: >>>>> >>>>>> Hi all, >>>>>> Can you please review and merge the PR? >>>>>> >>>>>> Thanks, >>>>>> Irunika >>>>>> >>>>>> *Irunika Weeraratne* >>>>>> *Software Engineer | WSO2, Inc. <http://wso2.com/>* >>>>>> *Email : irun...@wso2.com <irun...@wso2.com>* >>>>>> *LinkedIn : https://lk.linkedin.com/in/irunika >>>>>> <https://lk.linkedin.com/in/irunika>* >>>>>> *Mobile : +94712403314 <+94%2071%20240%203314>* >>>>>> *Lean . Enterprise . Middleware* >>>>>> >>>>>> >>>>>> On Wed, Jan 25, 2017 at 3:35 PM, Irunika Weeraratne <irun...@wso2.com >>>>>> > wrote: >>>>>> >>>>>>> Hi all, >>>>>>> I modified the Carbon-Messaging according to the requirements. >>>>>>> Please review and merge. >>>>>>> https://github.com/wso2/carbon-messaging/pull/40 >>>>>>> >>>>>>> Thanks, >>>>>>> Irunika >>>>>>> >>>>>>> *Irunika Weeraratne* >>>>>>> *Software Engineer | WSO2, Inc. <http://wso2.com/>* >>>>>>> *Email : irun...@wso2.com <irun...@wso2.com>* >>>>>>> *LinkedIn : https://lk.linkedin.com/in/irunika >>>>>>> <https://lk.linkedin.com/in/irunika>* >>>>>>> *Mobile : +94712403314 <+94%2071%20240%203314>* >>>>>>> *Lean . Enterprise . Middleware* >>>>>>> >>>>>>> >>>>>>> On Mon, Jan 2, 2017 at 12:47 PM, Irunika Weeraratne < >>>>>>> irun...@wso2.com> wrote: >>>>>>> >>>>>>>> Hi all, >>>>>>>> I did necessary changes after the review. >>>>>>
Re: [Dev] Please Review and Merge (WebSocket Suppport for Carbon-Messaging)
Hi, Fixed the issues mentioned. Please review and merge. Thanks, Irunika *Irunika Weeraratne* *Software Engineer | WSO2, Inc. <http://wso2.com/>* *Email : irun...@wso2.com <irun...@wso2.com>* *LinkedIn : https://lk.linkedin.com/in/irunika <https://lk.linkedin.com/in/irunika>* *Mobile : +94712403314* *Lean . Enterprise . Middleware* On Thu, Jan 26, 2017 at 7:04 PM, Irunika Weeraratne <irun...@wso2.com> wrote: > Noted. > > Thanks, > Irunika > > *Irunika Weeraratne* > *Software Engineer | WSO2, Inc. <http://wso2.com/>* > *Email : irun...@wso2.com <irun...@wso2.com>* > *LinkedIn : https://lk.linkedin.com/in/irunika > <https://lk.linkedin.com/in/irunika>* > *Mobile : +94712403314 <+94%2071%20240%203314>* > *Lean . Enterprise . Middleware* > > > On Thu, Jan 26, 2017 at 4:34 PM, Kishanthan Thangarajah < > kishant...@wso2.com> wrote: > >> PR has some formatting issue to be fixed. Can you look into it? >> >> On Thu, Jan 26, 2017 at 12:03 PM, Irunika Weeraratne <irun...@wso2.com> >> wrote: >> >>> Hi all, >>> Can you please review and merge the PR? >>> >>> Thanks, >>> Irunika >>> >>> *Irunika Weeraratne* >>> *Software Engineer | WSO2, Inc. <http://wso2.com/>* >>> *Email : irun...@wso2.com <irun...@wso2.com>* >>> *LinkedIn : https://lk.linkedin.com/in/irunika >>> <https://lk.linkedin.com/in/irunika>* >>> *Mobile : +94712403314 <+94%2071%20240%203314>* >>> *Lean . Enterprise . Middleware* >>> >>> >>> On Wed, Jan 25, 2017 at 3:35 PM, Irunika Weeraratne <irun...@wso2.com> >>> wrote: >>> >>>> Hi all, >>>> I modified the Carbon-Messaging according to the requirements. >>>> Please review and merge. >>>> https://github.com/wso2/carbon-messaging/pull/40 >>>> >>>> Thanks, >>>> Irunika >>>> >>>> *Irunika Weeraratne* >>>> *Software Engineer | WSO2, Inc. <http://wso2.com/>* >>>> *Email : irun...@wso2.com <irun...@wso2.com>* >>>> *LinkedIn : https://lk.linkedin.com/in/irunika >>>> <https://lk.linkedin.com/in/irunika>* >>>> *Mobile : +94712403314 <+94%2071%20240%203314>* >>>> *Lean . Enterprise . Middleware* >>>> >>>> >>>> On Mon, Jan 2, 2017 at 12:47 PM, Irunika Weeraratne <irun...@wso2.com> >>>> wrote: >>>> >>>>> Hi all, >>>>> I did necessary changes after the review. >>>>> Please review and merge >>>>> https://github.com/wso2/carbon-messaging/pull/40 >>>>> >>>>> Thanks, >>>>> Irunika >>>>> >>>>> *Irunika Weeraratne* >>>>> *Software Engineer | WSO2, Inc. <http://wso2.com/>* >>>>> *Email : irun...@wso2.com <irun...@wso2.com>* >>>>> *LinkedIn : https://lk.linkedin.com/in/irunika >>>>> <https://lk.linkedin.com/in/irunika>* >>>>> *Mobile : +94712403314 <+94%2071%20240%203314>* >>>>> *Lean . Enterprise . Middleware* >>>>> >>>>> >>>>> On Fri, Dec 23, 2016 at 1:36 PM, Irunika Weeraratne <irun...@wso2.com> >>>>> wrote: >>>>> >>>>>> Noted. >>>>>> >>>>>> Thanks, >>>>>> Irunika >>>>>> >>>>>> *Irunika Weeraratne* >>>>>> *Software Engineer | WSO2, Inc. <http://wso2.com/>* >>>>>> *Email : irun...@wso2.com <irun...@wso2.com>* >>>>>> *LinkedIn : https://lk.linkedin.com/in/irunika >>>>>> <https://lk.linkedin.com/in/irunika>* >>>>>> *Mobile : +94712403314 <+94%2071%20240%203314>* >>>>>> *Lean . Enterprise . Middleware* >>>>>> >>>>>> >>>>>> On Fri, Dec 23, 2016 at 1:30 PM, Kishanthan Thangarajah < >>>>>> kishant...@wso2.com> wrote: >>>>>> >>>>>>> Adding @dev >>>>>>> >>>>>>> @Irunika, always copy the relevant mailing list. >>>>>>> >>>>>>> On Fri, Dec 23, 2016 at 1:17 PM, Irunika Weeraratne < >>>>>>> irun...@wso2.com> wrote: >>>>>>> >>>>>>>> Hi, >>>>>>>> Please review and merge >>>>>>>> https://github.com/wso2/carbon-messaging/pull/39 >>>>>>>> >>>>>>>> Thanks, >>>>>>>> Irunika >>>>>>>> *Irunika Weeraratne* >>>>>>>> *Software Engineer | WSO2, Inc. <http://wso2.com/>* >>>>>>>> *Email : irun...@wso2.com <irun...@wso2.com>* >>>>>>>> *LinkedIn : https://lk.linkedin.com/in/irunika >>>>>>>> <https://lk.linkedin.com/in/irunika>* >>>>>>>> *Mobile : +94712403314 <+94%2071%20240%203314>* >>>>>>>> *Lean . Enterprise . Middleware* >>>>>>>> >>>>>>>> >>>>>>> >>>>>>> >>>>>>> -- >>>>>>> *Kishanthan Thangarajah* >>>>>>> Technical Lead, >>>>>>> Platform Technologies Team, >>>>>>> WSO2, Inc. >>>>>>> lean.enterprise.middleware >>>>>>> >>>>>>> Mobile - +94773426635 <+94%2077%20342%206635> >>>>>>> Blog - *http://kishanthan.wordpress.com >>>>>>> <http://kishanthan.wordpress.com>* >>>>>>> Twitter - *http://twitter.com/kishanthan >>>>>>> <http://twitter.com/kishanthan>* >>>>>>> >>>>>> >>>>>> >>>>> >>>> >>> >> >> >> -- >> *Kishanthan Thangarajah* >> Technical Lead, >> Platform Technologies Team, >> WSO2, Inc. >> lean.enterprise.middleware >> >> Mobile - +94773426635 <+94%2077%20342%206635> >> Blog - *http://kishanthan.wordpress.com >> <http://kishanthan.wordpress.com>* >> Twitter - *http://twitter.com/kishanthan <http://twitter.com/kishanthan>* >> > > ___ Dev mailing list Dev@wso2.org http://wso2.org/cgi-bin/mailman/listinfo/dev
Re: [Dev] Please Review and Merge (WebSocket Suppport for Carbon-Messaging)
Noted. Thanks, Irunika *Irunika Weeraratne* *Software Engineer | WSO2, Inc. <http://wso2.com/>* *Email : irun...@wso2.com <irun...@wso2.com>* *LinkedIn : https://lk.linkedin.com/in/irunika <https://lk.linkedin.com/in/irunika>* *Mobile : +94712403314* *Lean . Enterprise . Middleware* On Thu, Jan 26, 2017 at 4:34 PM, Kishanthan Thangarajah <kishant...@wso2.com > wrote: > PR has some formatting issue to be fixed. Can you look into it? > > On Thu, Jan 26, 2017 at 12:03 PM, Irunika Weeraratne <irun...@wso2.com> > wrote: > >> Hi all, >> Can you please review and merge the PR? >> >> Thanks, >> Irunika >> >> *Irunika Weeraratne* >> *Software Engineer | WSO2, Inc. <http://wso2.com/>* >> *Email : irun...@wso2.com <irun...@wso2.com>* >> *LinkedIn : https://lk.linkedin.com/in/irunika >> <https://lk.linkedin.com/in/irunika>* >> *Mobile : +94712403314 <+94%2071%20240%203314>* >> *Lean . Enterprise . Middleware* >> >> >> On Wed, Jan 25, 2017 at 3:35 PM, Irunika Weeraratne <irun...@wso2.com> >> wrote: >> >>> Hi all, >>> I modified the Carbon-Messaging according to the requirements. >>> Please review and merge. >>> https://github.com/wso2/carbon-messaging/pull/40 >>> >>> Thanks, >>> Irunika >>> >>> *Irunika Weeraratne* >>> *Software Engineer | WSO2, Inc. <http://wso2.com/>* >>> *Email : irun...@wso2.com <irun...@wso2.com>* >>> *LinkedIn : https://lk.linkedin.com/in/irunika >>> <https://lk.linkedin.com/in/irunika>* >>> *Mobile : +94712403314 <+94%2071%20240%203314>* >>> *Lean . Enterprise . Middleware* >>> >>> >>> On Mon, Jan 2, 2017 at 12:47 PM, Irunika Weeraratne <irun...@wso2.com> >>> wrote: >>> >>>> Hi all, >>>> I did necessary changes after the review. >>>> Please review and merge >>>> https://github.com/wso2/carbon-messaging/pull/40 >>>> >>>> Thanks, >>>> Irunika >>>> >>>> *Irunika Weeraratne* >>>> *Software Engineer | WSO2, Inc. <http://wso2.com/>* >>>> *Email : irun...@wso2.com <irun...@wso2.com>* >>>> *LinkedIn : https://lk.linkedin.com/in/irunika >>>> <https://lk.linkedin.com/in/irunika>* >>>> *Mobile : +94712403314 <+94%2071%20240%203314>* >>>> *Lean . Enterprise . Middleware* >>>> >>>> >>>> On Fri, Dec 23, 2016 at 1:36 PM, Irunika Weeraratne <irun...@wso2.com> >>>> wrote: >>>> >>>>> Noted. >>>>> >>>>> Thanks, >>>>> Irunika >>>>> >>>>> *Irunika Weeraratne* >>>>> *Software Engineer | WSO2, Inc. <http://wso2.com/>* >>>>> *Email : irun...@wso2.com <irun...@wso2.com>* >>>>> *LinkedIn : https://lk.linkedin.com/in/irunika >>>>> <https://lk.linkedin.com/in/irunika>* >>>>> *Mobile : +94712403314 <+94%2071%20240%203314>* >>>>> *Lean . Enterprise . Middleware* >>>>> >>>>> >>>>> On Fri, Dec 23, 2016 at 1:30 PM, Kishanthan Thangarajah < >>>>> kishant...@wso2.com> wrote: >>>>> >>>>>> Adding @dev >>>>>> >>>>>> @Irunika, always copy the relevant mailing list. >>>>>> >>>>>> On Fri, Dec 23, 2016 at 1:17 PM, Irunika Weeraratne <irun...@wso2.com >>>>>> > wrote: >>>>>> >>>>>>> Hi, >>>>>>> Please review and merge >>>>>>> https://github.com/wso2/carbon-messaging/pull/39 >>>>>>> >>>>>>> Thanks, >>>>>>> Irunika >>>>>>> *Irunika Weeraratne* >>>>>>> *Software Engineer | WSO2, Inc. <http://wso2.com/>* >>>>>>> *Email : irun...@wso2.com <irun...@wso2.com>* >>>>>>> *LinkedIn : https://lk.linkedin.com/in/irunika >>>>>>> <https://lk.linkedin.com/in/irunika>* >>>>>>> *Mobile : +94712403314 <+94%2071%20240%203314>* >>>>>>> *Lean . Enterprise . Middleware* >>>>>>> >>>>>>> >>>>>> >>>>>> >>>>>> -- >>>>>> *Kishanthan Thangarajah* >>>>>> Technical Lead, >>>>>> Platform Technologies Team, >>>>>> WSO2, Inc. >>>>>> lean.enterprise.middleware >>>>>> >>>>>> Mobile - +94773426635 <+94%2077%20342%206635> >>>>>> Blog - *http://kishanthan.wordpress.com >>>>>> <http://kishanthan.wordpress.com>* >>>>>> Twitter - *http://twitter.com/kishanthan >>>>>> <http://twitter.com/kishanthan>* >>>>>> >>>>> >>>>> >>>> >>> >> > > > -- > *Kishanthan Thangarajah* > Technical Lead, > Platform Technologies Team, > WSO2, Inc. > lean.enterprise.middleware > > Mobile - +94773426635 <+94%2077%20342%206635> > Blog - *http://kishanthan.wordpress.com <http://kishanthan.wordpress.com>* > Twitter - *http://twitter.com/kishanthan <http://twitter.com/kishanthan>* > ___ Dev mailing list Dev@wso2.org http://wso2.org/cgi-bin/mailman/listinfo/dev
Re: [Dev] Please Review and Merge (WebSocket Suppport for Carbon-Messaging)
Hi all, Can you please review and merge the PR? Thanks, Irunika *Irunika Weeraratne* *Software Engineer | WSO2, Inc. <http://wso2.com/>* *Email : irun...@wso2.com <irun...@wso2.com>* *LinkedIn : https://lk.linkedin.com/in/irunika <https://lk.linkedin.com/in/irunika>* *Mobile : +94712403314* *Lean . Enterprise . Middleware* On Wed, Jan 25, 2017 at 3:35 PM, Irunika Weeraratne <irun...@wso2.com> wrote: > Hi all, > I modified the Carbon-Messaging according to the requirements. > Please review and merge. > https://github.com/wso2/carbon-messaging/pull/40 > > Thanks, > Irunika > > *Irunika Weeraratne* > *Software Engineer | WSO2, Inc. <http://wso2.com/>* > *Email : irun...@wso2.com <irun...@wso2.com>* > *LinkedIn : https://lk.linkedin.com/in/irunika > <https://lk.linkedin.com/in/irunika>* > *Mobile : +94712403314 <+94%2071%20240%203314>* > *Lean . Enterprise . Middleware* > > > On Mon, Jan 2, 2017 at 12:47 PM, Irunika Weeraratne <irun...@wso2.com> > wrote: > >> Hi all, >> I did necessary changes after the review. >> Please review and merge >> https://github.com/wso2/carbon-messaging/pull/40 >> >> Thanks, >> Irunika >> >> *Irunika Weeraratne* >> *Software Engineer | WSO2, Inc. <http://wso2.com/>* >> *Email : irun...@wso2.com <irun...@wso2.com>* >> *LinkedIn : https://lk.linkedin.com/in/irunika >> <https://lk.linkedin.com/in/irunika>* >> *Mobile : +94712403314 <+94%2071%20240%203314>* >> *Lean . Enterprise . Middleware* >> >> >> On Fri, Dec 23, 2016 at 1:36 PM, Irunika Weeraratne <irun...@wso2.com> >> wrote: >> >>> Noted. >>> >>> Thanks, >>> Irunika >>> >>> *Irunika Weeraratne* >>> *Software Engineer | WSO2, Inc. <http://wso2.com/>* >>> *Email : irun...@wso2.com <irun...@wso2.com>* >>> *LinkedIn : https://lk.linkedin.com/in/irunika >>> <https://lk.linkedin.com/in/irunika>* >>> *Mobile : +94712403314 <+94%2071%20240%203314>* >>> *Lean . Enterprise . Middleware* >>> >>> >>> On Fri, Dec 23, 2016 at 1:30 PM, Kishanthan Thangarajah < >>> kishant...@wso2.com> wrote: >>> >>>> Adding @dev >>>> >>>> @Irunika, always copy the relevant mailing list. >>>> >>>> On Fri, Dec 23, 2016 at 1:17 PM, Irunika Weeraratne <irun...@wso2.com> >>>> wrote: >>>> >>>>> Hi, >>>>> Please review and merge >>>>> https://github.com/wso2/carbon-messaging/pull/39 >>>>> >>>>> Thanks, >>>>> Irunika >>>>> *Irunika Weeraratne* >>>>> *Software Engineer | WSO2, Inc. <http://wso2.com/>* >>>>> *Email : irun...@wso2.com <irun...@wso2.com>* >>>>> *LinkedIn : https://lk.linkedin.com/in/irunika >>>>> <https://lk.linkedin.com/in/irunika>* >>>>> *Mobile : +94712403314 <+94%2071%20240%203314>* >>>>> *Lean . Enterprise . Middleware* >>>>> >>>>> >>>> >>>> >>>> -- >>>> *Kishanthan Thangarajah* >>>> Technical Lead, >>>> Platform Technologies Team, >>>> WSO2, Inc. >>>> lean.enterprise.middleware >>>> >>>> Mobile - +94773426635 <+94%2077%20342%206635> >>>> Blog - *http://kishanthan.wordpress.com >>>> <http://kishanthan.wordpress.com>* >>>> Twitter - *http://twitter.com/kishanthan >>>> <http://twitter.com/kishanthan>* >>>> >>> >>> >> > ___ Dev mailing list Dev@wso2.org http://wso2.org/cgi-bin/mailman/listinfo/dev
Re: [Dev] Please Review and Merge (WebSocket Suppport for Carbon-Messaging)
Hi all, I modified the Carbon-Messaging according to the requirements. Please review and merge. https://github.com/wso2/carbon-messaging/pull/40 Thanks, Irunika *Irunika Weeraratne* *Software Engineer | WSO2, Inc. <http://wso2.com/>* *Email : irun...@wso2.com <irun...@wso2.com>* *LinkedIn : https://lk.linkedin.com/in/irunika <https://lk.linkedin.com/in/irunika>* *Mobile : +94712403314* *Lean . Enterprise . Middleware* On Mon, Jan 2, 2017 at 12:47 PM, Irunika Weeraratne <irun...@wso2.com> wrote: > Hi all, > I did necessary changes after the review. > Please review and merge > https://github.com/wso2/carbon-messaging/pull/40 > > Thanks, > Irunika > > *Irunika Weeraratne* > *Software Engineer | WSO2, Inc. <http://wso2.com/>* > *Email : irun...@wso2.com <irun...@wso2.com>* > *LinkedIn : https://lk.linkedin.com/in/irunika > <https://lk.linkedin.com/in/irunika>* > *Mobile : +94712403314 <+94%2071%20240%203314>* > *Lean . Enterprise . Middleware* > > > On Fri, Dec 23, 2016 at 1:36 PM, Irunika Weeraratne <irun...@wso2.com> > wrote: > >> Noted. >> >> Thanks, >> Irunika >> >> *Irunika Weeraratne* >> *Software Engineer | WSO2, Inc. <http://wso2.com/>* >> *Email : irun...@wso2.com <irun...@wso2.com>* >> *LinkedIn : https://lk.linkedin.com/in/irunika >> <https://lk.linkedin.com/in/irunika>* >> *Mobile : +94712403314 <+94%2071%20240%203314>* >> *Lean . Enterprise . Middleware* >> >> >> On Fri, Dec 23, 2016 at 1:30 PM, Kishanthan Thangarajah < >> kishant...@wso2.com> wrote: >> >>> Adding @dev >>> >>> @Irunika, always copy the relevant mailing list. >>> >>> On Fri, Dec 23, 2016 at 1:17 PM, Irunika Weeraratne <irun...@wso2.com> >>> wrote: >>> >>>> Hi, >>>> Please review and merge >>>> https://github.com/wso2/carbon-messaging/pull/39 >>>> >>>> Thanks, >>>> Irunika >>>> *Irunika Weeraratne* >>>> *Software Engineer | WSO2, Inc. <http://wso2.com/>* >>>> *Email : irun...@wso2.com <irun...@wso2.com>* >>>> *LinkedIn : https://lk.linkedin.com/in/irunika >>>> <https://lk.linkedin.com/in/irunika>* >>>> *Mobile : +94712403314 <+94%2071%20240%203314>* >>>> *Lean . Enterprise . Middleware* >>>> >>>> >>> >>> >>> -- >>> *Kishanthan Thangarajah* >>> Technical Lead, >>> Platform Technologies Team, >>> WSO2, Inc. >>> lean.enterprise.middleware >>> >>> Mobile - +94773426635 <+94%2077%20342%206635> >>> Blog - *http://kishanthan.wordpress.com >>> <http://kishanthan.wordpress.com>* >>> Twitter - *http://twitter.com/kishanthan >>> <http://twitter.com/kishanthan>* >>> >> >> > ___ Dev mailing list Dev@wso2.org http://wso2.org/cgi-bin/mailman/listinfo/dev
Re: [Dev] Please Review and Merge (WebSocket Suppport for Carbon-Messaging)
Hi all, I did necessary changes after the review. Please review and merge https://github.com/wso2/carbon-messaging/pull/40 Thanks, Irunika *Irunika Weeraratne* *Software Engineer | WSO2, Inc. <http://wso2.com/>* *Email : irun...@wso2.com <irun...@wso2.com>* *LinkedIn : https://lk.linkedin.com/in/irunika <https://lk.linkedin.com/in/irunika>* *Mobile : +94712403314* *Lean . Enterprise . Middleware* On Fri, Dec 23, 2016 at 1:36 PM, Irunika Weeraratne <irun...@wso2.com> wrote: > Noted. > > Thanks, > Irunika > > *Irunika Weeraratne* > *Software Engineer | WSO2, Inc. <http://wso2.com/>* > *Email : irun...@wso2.com <irun...@wso2.com>* > *LinkedIn : https://lk.linkedin.com/in/irunika > <https://lk.linkedin.com/in/irunika>* > *Mobile : +94712403314 <+94%2071%20240%203314>* > *Lean . Enterprise . Middleware* > > > On Fri, Dec 23, 2016 at 1:30 PM, Kishanthan Thangarajah < > kishant...@wso2.com> wrote: > >> Adding @dev >> >> @Irunika, always copy the relevant mailing list. >> >> On Fri, Dec 23, 2016 at 1:17 PM, Irunika Weeraratne <irun...@wso2.com> >> wrote: >> >>> Hi, >>> Please review and merge >>> https://github.com/wso2/carbon-messaging/pull/39 >>> >>> Thanks, >>> Irunika >>> *Irunika Weeraratne* >>> *Software Engineer | WSO2, Inc. <http://wso2.com/>* >>> *Email : irun...@wso2.com <irun...@wso2.com>* >>> *LinkedIn : https://lk.linkedin.com/in/irunika >>> <https://lk.linkedin.com/in/irunika>* >>> *Mobile : +94712403314 <+94%2071%20240%203314>* >>> *Lean . Enterprise . Middleware* >>> >>> >> >> >> -- >> *Kishanthan Thangarajah* >> Technical Lead, >> Platform Technologies Team, >> WSO2, Inc. >> lean.enterprise.middleware >> >> Mobile - +94773426635 <+94%2077%20342%206635> >> Blog - *http://kishanthan.wordpress.com >> <http://kishanthan.wordpress.com>* >> Twitter - *http://twitter.com/kishanthan <http://twitter.com/kishanthan>* >> > > ___ Dev mailing list Dev@wso2.org http://wso2.org/cgi-bin/mailman/listinfo/dev
Re: [Dev] Please Review and Merge (WebSocket Suppport for Carbon-Messaging)
Noted. Thanks, Irunika *Irunika Weeraratne* *Software Engineer | WSO2, Inc. <http://wso2.com/>* *Email : irun...@wso2.com <irun...@wso2.com>* *LinkedIn : https://lk.linkedin.com/in/irunika <https://lk.linkedin.com/in/irunika>* *Mobile : +94712403314* *Lean . Enterprise . Middleware* On Fri, Dec 23, 2016 at 1:30 PM, Kishanthan Thangarajah <kishant...@wso2.com > wrote: > Adding @dev > > @Irunika, always copy the relevant mailing list. > > On Fri, Dec 23, 2016 at 1:17 PM, Irunika Weeraratne <irun...@wso2.com> > wrote: > >> Hi, >> Please review and merge >> https://github.com/wso2/carbon-messaging/pull/39 >> >> Thanks, >> Irunika >> *Irunika Weeraratne* >> *Software Engineer | WSO2, Inc. <http://wso2.com/>* >> *Email : irun...@wso2.com <irun...@wso2.com>* >> *LinkedIn : https://lk.linkedin.com/in/irunika >> <https://lk.linkedin.com/in/irunika>* >> *Mobile : +94712403314 <+94%2071%20240%203314>* >> *Lean . Enterprise . Middleware* >> >> > > > -- > *Kishanthan Thangarajah* > Technical Lead, > Platform Technologies Team, > WSO2, Inc. > lean.enterprise.middleware > > Mobile - +94773426635 <+94%2077%20342%206635> > Blog - *http://kishanthan.wordpress.com <http://kishanthan.wordpress.com>* > Twitter - *http://twitter.com/kishanthan <http://twitter.com/kishanthan>* > ___ Dev mailing list Dev@wso2.org http://wso2.org/cgi-bin/mailman/listinfo/dev
Re: [Dev] Carbon-Messaging for WebSocket Protocol
K thanks. *Irunika Weeraratne* *Software Engineer | WSO2, Inc. <http://wso2.com/>* *Email : irun...@wso2.com <irun...@wso2.com>* *LinkedIn : https://lk.linkedin.com/in/irunika <https://lk.linkedin.com/in/irunika>* *Mobile : +94712403314* *Lean . Enterprise . Middleware* On Thu, Dec 1, 2016 at 12:10 PM, Isuru Ranawaka <isu...@wso2.com> wrote: > Hi Irunika, > > It is not necessary for one way messaging otherwise it should. > > On Thu, Dec 1, 2016 at 12:07 PM, Irunika Weeraratne <irun...@wso2.com> > wrote: > >> Hi, >> I'm currently working on adding WebSocket support for MSF4J. For incoming >> WebSocketFrames from the clients, there is a possibility to use existing >> Carbon-Messaging. >> But in Websocket, after receiving the CarbonMesssage to the correct >> endpoint it is not necessary to send a Callback to the client. >> So with the existing implementation is it necessary to call >> Callback.done() method? >> >> Thanks, >> Irunika >> *Irunika Weeraratne* >> *Software Engineer | WSO2, Inc. <http://wso2.com/>* >> *Email : irun...@wso2.com <irun...@wso2.com>* >> *LinkedIn : https://lk.linkedin.com/in/irunika >> <https://lk.linkedin.com/in/irunika>* >> *Mobile : +94712403314 <071%20240%203314>* >> *Lean . Enterprise . Middleware* >> >> > > > -- > Best Regards > Isuru Ranawaka > M: +94714629880 > Blog : http://isurur.blogspot.com/ > ___ Dev mailing list Dev@wso2.org http://wso2.org/cgi-bin/mailman/listinfo/dev
[Dev] Carbon-Messaging for WebSocket Protocol
Hi, I'm currently working on adding WebSocket support for MSF4J. For incoming WebSocketFrames from the clients, there is a possibility to use existing Carbon-Messaging. But in Websocket, after receiving the CarbonMesssage to the correct endpoint it is not necessary to send a Callback to the client. So with the existing implementation is it necessary to call Callback.done() method? Thanks, Irunika *Irunika Weeraratne* *Software Engineer | WSO2, Inc. <http://wso2.com/>* *Email : irun...@wso2.com <irun...@wso2.com>* *LinkedIn : https://lk.linkedin.com/in/irunika <https://lk.linkedin.com/in/irunika>* *Mobile : +94712403314* *Lean . Enterprise . Middleware* ___ Dev mailing list Dev@wso2.org http://wso2.org/cgi-bin/mailman/listinfo/dev
Re: [Dev] WSO2 Committers += Malintha Fernando
Congratulations Malintha!!! Best Regards, Irunika *Irunika Weeraratne* *Software Engineer | WSO2, Inc. <http://wso2.com/>* *Email : irun...@wso2.com <irun...@wso2.com>* *LinkedIn : https://lk.linkedin.com/in/irunikaw <https://lk.linkedin.com/in/irunikaw>* *Mobile : +94712403314* *Lean . Enterprise . Middleware* On Tue, Nov 8, 2016 at 2:43 PM, Sameera Gunarathne <samee...@wso2.com> wrote: > Congrats Malintha!!! > > On Tue, Nov 8, 2016 at 2:38 PM, Maneesha Wijesekara <manee...@wso2.com> > wrote: > >> Congratulations Malintha..!! >> >> On Tue, Nov 8, 2016 at 1:47 PM, Dilshani Subasinghe <dilsh...@wso2.com> >> wrote: >> >>> Congrats Malintha :) >>> >>> On Tue, Nov 8, 2016 at 1:45 PM, Heshitha Hettihewa <heshit...@wso2.com> >>> wrote: >>> >>>> Congratz Malintha!!! >>>> >>>> On Tue, Nov 8, 2016 at 1:32 PM, Chandana Napagoda <chand...@wso2.com> >>>> wrote: >>>> >>>>> Hi Devs, >>>>> >>>>> It is my pleasure to welcome Malintha Fernando as a WSO2 Committer. >>>>> Malintha has made some great contributions to WSO2 Governance Registry and >>>>> WSO2 Enterprise Store products during the last few months and in >>>>> recognition of his commitment and contributions, he has been voted as a >>>>> Committer for WSO2. >>>>> >>>>> @Malintha, welcome aboard and keep up the good work. >>>>> >>>>> Best Regards, >>>>> Chandana >>>>> >>>>> -- >>>>> *Chandana Napagoda* >>>>> Associate Technical Lead >>>>> WSO2 Inc. - http://wso2.org >>>>> >>>>> *Email : chand...@wso2.com <chand...@wso2.com>**Mobile : >>>>> +94718169299 <%2B94718169299>* >>>>> >>>>> *Blog :http://cnapagoda.blogspot.com >>>>> <http://cnapagoda.blogspot.com> | http://chandana.napagoda.com >>>>> <http://chandana.napagoda.com>* >>>>> >>>>> *Linkedin : http://www.linkedin.com/in/chandananapagoda >>>>> <http://www.linkedin.com/in/chandananapagoda>* >>>>> >>>>> >>>>> ___ >>>>> Dev mailing list >>>>> Dev@wso2.org >>>>> http://wso2.org/cgi-bin/mailman/listinfo/dev >>>>> >>>>> >>>> >>>> >>>> -- >>>> Heshitha Hettihewa >>>> *Software Engineer* >>>> Mobile : +94716866386 >>>> <%2B94%20%280%29%20773%20451194> >>>> heshit...@wso2.com >>>> >>>> ___ >>>> Dev mailing list >>>> Dev@wso2.org >>>> http://wso2.org/cgi-bin/mailman/listinfo/dev >>>> >>>> >>> >>> >>> -- >>> Best Regards, >>> >>> Dilshani Subasinghe >>> Software Engineer - QA *|* WSO2 >>> lean *|* enterprise *|* middleware >>> >>> Mobile : +94773375185 >>> Blog: dilshani.me >>> >>> <https://wso2.com/signature> >>> >>> ___ >>> Dev mailing list >>> Dev@wso2.org >>> http://wso2.org/cgi-bin/mailman/listinfo/dev >>> >>> >> >> >> -- >> Maneesha Wijesekara >> Software Engineer - EE Team >> WSO2 Inc. >> >> Email: manee...@wso2.com >> Linkedin: http://linkedin.com/in/maneeshawijesekara >> Mobile: +94712443119 >> >> ___ >> Dev mailing list >> Dev@wso2.org >> http://wso2.org/cgi-bin/mailman/listinfo/dev >> >> > > > -- > Sameera Gunarathne > Software Engineer, WSO2 Inc. http://wso2.com > <http://l.facebook.com/l.php?u=http%3A%2F%2Fwso2.com=gAQEswASa> > Email: samee...@wso2.com > Mobile: +94714155561 > > ___ > Dev mailing list > Dev@wso2.org > http://wso2.org/cgi-bin/mailman/listinfo/dev > > ___ Dev mailing list Dev@wso2.org http://wso2.org/cgi-bin/mailman/listinfo/dev
Re: [Dev] WSO2 Committers += Shan Mahanama
Congratulations Shan!!! Best regards, Irunika *Irunika Weeraratne* *Software Engineer | WSO2, Inc. <http://wso2.com/>* *Email : irun...@wso2.com <irun...@wso2.com>* *LinkedIn : https://lk.linkedin.com/in/irunikaw <https://lk.linkedin.com/in/irunikaw>* *Mobile : +94712403314* *Lean . Enterprise . Middleware* On Tue, Nov 8, 2016 at 9:06 AM, Eranda Rajapakshe <eran...@wso2.com> wrote: > Congrats Shan! > > On Tue, Nov 8, 2016 at 7:51 AM, Yasima Dewmini <yas...@wso2.com> wrote: > >> Congratz Shan! >> >> On Mon, Nov 7, 2016 at 11:47 PM, Menaka Jayawardena <men...@wso2.com> >> wrote: >> >>> Congratz Shan! >>> >>> On Mon, Nov 7, 2016 at 1:21 PM, Fathima Dilhasha <dilha...@wso2.com> >>> wrote: >>> >>>> Congratz Shan :) >>>> >>>> On Mon, Nov 7, 2016 at 1:05 PM, Thanuja Uruththirakodeeswaran < >>>> thanu...@wso2.com> wrote: >>>> >>>>> Congratz Shan!!! >>>>> >>>>> On Mon, Nov 7, 2016 at 12:14 PM, Niranjan Karunanandham < >>>>> niran...@wso2.com> wrote: >>>>> >>>>>> Hi all, >>>>>> >>>>>> It's my pleasure to announce Shan Mahanama as a WSO2 Committer. Shan >>>>>> has been a valuable contributor for Platform team. And in recognition of >>>>>> his contribution to WSO2, he has been voted as a WSO2 Committer. >>>>>> >>>>>> Shan, Congratulations and keep up the good work! >>>>>> >>>>>> Regards, >>>>>> Nira. >>>>>> >>>>>> -- >>>>>> >>>>>> >>>>>> *Niranjan Karunanandham* >>>>>> Associate Technical Lead - WSO2 Inc. >>>>>> WSO2 Inc.: http://www.wso2.com >>>>>> >>>>>> >>>>>> ___ >>>>>> Dev mailing list >>>>>> Dev@wso2.org >>>>>> http://wso2.org/cgi-bin/mailman/listinfo/dev >>>>>> >>>>>> >>>>> >>>>> >>>>> -- >>>>> Thanuja Uruththirakodeeswaran >>>>> Software Engineer >>>>> WSO2 Inc.;http://wso2.com >>>>> lean.enterprise.middleware >>>>> >>>>> mobile: +94 774363167 >>>>> >>>>> <http://wso2.com/signature> >>>>> >>>>> ___ >>>>> Dev mailing list >>>>> Dev@wso2.org >>>>> http://wso2.org/cgi-bin/mailman/listinfo/dev >>>>> >>>>> >>>> >>>> >>>> -- >>>> Fathima Dilhasha >>>> *Software Engineer* >>>> Mobile : +94 (0) 771663314 <%2B94%20%280%29%20773655496> >>>> <%2B94%20%280%29%20773%20451194> >>>> dilha...@wso2.com >>>> >>>> ___ >>>> Dev mailing list >>>> Dev@wso2.org >>>> http://wso2.org/cgi-bin/mailman/listinfo/dev >>>> >>>> >>> >>> >>> -- >>> *Menaka Jayawardena* >>> *Software Engineer - WSO2 Inc* >>> *Tel : 071 350 5470/ 071 885 1183* >>> >>> >>> ___ >>> Dev mailing list >>> Dev@wso2.org >>> http://wso2.org/cgi-bin/mailman/listinfo/dev >>> >>> >> >> >> -- >> http://wso2.com/signatureYasima Dewmini >> Software Engineer, WSO2, Inc. >> Email: yas...@wso2.com >> Mobile: +94713117081 >> >> ___ >> Dev mailing list >> Dev@wso2.org >> http://wso2.org/cgi-bin/mailman/listinfo/dev >> >> > > > -- > *Eranda Rajapakshe* > Software Engineer > WSO2 Inc. > Mobile : +94784822608 > > ___ > Dev mailing list > Dev@wso2.org > http://wso2.org/cgi-bin/mailman/listinfo/dev > > ___ Dev mailing list Dev@wso2.org http://wso2.org/cgi-bin/mailman/listinfo/dev
