Re: [Dev] [DEV] Defining environment variables for C5 config based deployment
Hi Tharindu, +1 for the change and reviewed the PR. Best Regards, Vidura Nanayakkara On Thu, Oct 25, 2018 at 5:57 AM Pubudu Gunatilaka wrote: > Hi Tharindu, > > If I have not mistaken you have used double underscore for the namespace > and single underscore for config variables. As we are using camel case in > Java, variables cannot have underscore. > > +1 for the change. > > Thank you! > > On Wed, Oct 24, 2018 at 11:38 PM Tharindu Dharmarathna > wrote: > >> Hi Sajith, >> >> As per my findings, we couldn't have variable names with underscores as >> the config created from the configuration class we wrote. If we write >> variable names with underscores it didn't get broke as it check for the >> first part of environment variable as a namespace. >> >> Thanks >> >> On Wed, Oct 24, 2018 at 11:31 PM Sajith Ariyarathna >> wrote: >> >>> Hi Tharindu, >>> >>> What if there are underscores in the variable name? How do we deal with >>> that? >>> >>> Thanks. >>> >>> On Wed, Oct 24, 2018 at 11:16 PM Danesh Kuruppu wrote: >>> >>>> +1 for the change. >>>> >>>> @Vidura Nanayakkara Can you please review these >>>> changes. >>>> >>>> Thanks >>>> Danesh >>>> >>>> On Wed, Oct 24, 2018 at 10:52 PM Tharindu Dharmarathna < >>>> tharin...@wso2.com> wrote: >>>> >>>>> Hi All, >>>>> >>>>> We had come across the following issue when configuring environment >>>>> variables for API Manager 3.0. >>>>> >>>>> We had the following type of deployment.yaml as default. >>>>> >>>>> wso2.configuration: >>>>> complexBean: >>>>> name: default >>>>> Bean: >>>>> name: default >>>>> >>>>> >>>>> in order to set the environment variable for *name *under >>>>> complexBean, we have to write environment variable as follows. >>>>> >>>>> WSO2.CONFIGURATION_COMPLEXTESTBEAN_NAME="default" >>>>> >>>>> Which is not supported to create an environment variable couldn't have >>>>> a dot (.) in the name. >>>>> >>>>> In order to fix this issue, I had come up with make Underscore ( _ ) >>>>> in namespace value. Once it fixed it looks like follows. >>>>> >>>>> WSO2_CONFIGURATION_COMPLEXTESTBEAN_NAME="default" >>>>> >>>>> Please find the git issue create [1] and pull request for fix [2]. >>>>> >>>>> [1] - https://github.com/wso2/carbon-config/issues/66 >>>>> [2] - https://github.com/wso2/carbon-config/issues/66 >>>>> >>>>> >>>>> Thanks >>>>> >>>>> *Tharindu Dharmarathna*Associate Technical Lead >>>>> WSO2 Inc.; http://wso2.com >>>>> lean.enterprise.middleware >>>>> >>>> >>>> >>>> -- >>>> >>>> *Danesh Kuruppu* >>>> Associate Technical Lead | WSO2 >>>> >>>> Email: dan...@wso2.com >>>> Mobile: +94 (77) 1690552 >>>> Web: WSO2 Inc <https://wso2.com/signature> >>>> >>>> >>>> ___ >>>> Dev mailing list >>>> Dev@wso2.org >>>> http://wso2.org/cgi-bin/mailman/listinfo/dev >>>> >>> >>> >>> -- >>> Sajith Janaprasad Ariyarathna >>> WSO2, Inc.; http://wso2.com/ >>> <https://wso2.com/signature> >>> >> >> >> -- >> >> *Tharindu Dharmarathna*Associate Technical Lead >> WSO2 Inc.; http://wso2.com >> lean.enterprise.middleware >> >> mobile: *+94779109091* >> ___ >> Dev mailing list >> Dev@wso2.org >> http://wso2.org/cgi-bin/mailman/listinfo/dev >> > > > -- > *Pubudu Gunatilaka* > Committer and PMC Member - Apache Stratos > Associate Technical Lead > WSO2, Inc.: http://wso2.com > mobile : +94774078049 <%2B94772207163> > > ___ > Dev mailing list > Dev@wso2.org > http://wso2.org/cgi-bin/mailman/listinfo/dev > -- Vidura Nanayakkara Senior Software Engineer WSO2, Inc. http://wso2.com <http://wso2.com/>- lean . enterprise . middleware Mobile : +94 (0) 717 919277 ___ Dev mailing list Dev@wso2.org http://wso2.org/cgi-bin/mailman/listinfo/dev
Re: [Dev] [MSF4J] Skip global request interceptors at service level
Hi Waruna, No, we do not have a way of skipping global interceptors at class/method level. Best Regards, Vidura Nanayakkara On Thu, Feb 8, 2018 at 7:08 PM, Waruna Jayaweera wrote: > Hi, > We can add interceptors with annotations in class level, method level as > per [1]. Do we have any way to skip any global interceptors at class/method > level? > > [1] https://github.com/wso2/msf4j/tree/master/samples/intercepto > r#general-order-of-interceptors > > Thanks, > Waruna > > -- > Regards, > > Waruna Lakshitha Jayaweera > Senior Software Engineer > WSO2 Inc; http://wso2.com > phone: +94713255198 <+94%2071%20325%205198> > http://waruapz.blogspot.com/ > > -- Best Regards, *Vidura Nanayakkara* Software Engineer Email : vidu...@wso2.com Mobile : +94 (0) 717 919277 Web : http://wso2.com ___ Dev mailing list Dev@wso2.org http://wso2.org/cgi-bin/mailman/listinfo/dev
Re: [Dev] MSF4J (v2.4.1) Metrics sample throws NPE
Hi All, The above issue is resolved with PR [1]. [1] https://github.com/wso2/msf4j/pull/490 Best Regards, Vidura Nanayakkara On Fri, Oct 27, 2017 at 11:30 AM, Vidura Nanayakkara wrote: > Hi Chanaka, > > I was able to reproduce this issue and opened the git issue [1] to track > this down. The null pointer exception is thrown when metrics configuration > is retrieved due to carbon config resolver being not set. I will look into > this and let you know once this is fixed asap. > > [1] https://github.com/wso2/msf4j/issues/482 > > On Fri, Oct 27, 2017 at 10:03 AM, Viduranga Gunarathne > wrote: > >> Hi, >> I too encountered the same issue, when I used the following code as >> stated in the sample[1]: >> >> public static void main(String[] args) { >> new MicroservicesRunner() >> .addInterceptor(new MetricsInterceptor()) >> .deploy(new HelloService()) >> .deploy(new DemoService()) >> .start(); >> } >> >> It seems the "addInterceptor()" method is deprecated. >> >> The workaround to this was as follows: >> *No need to pass an instance of "MetricsInterceptor" >> >> public static void main(String[] args) { >> new MicroservicesRunner() >> .addGlobalRequestInterceptor() >> .addGlobalResponseInterceptor() >> .deploy(new HelloService()) >> .deploy(new DemoService()) >> .start(); >> } >> >> This worked out for me. >> Hope this helps! >> >> [1] https://github.com/wso2/msf4j/tree/master/samples/metrics >> >> Thanks, >> Viduranga. >> >> >> >> On Thu, Oct 26, 2017 at 9:40 AM, Chanaka Fernando >> wrote: >> >>> Hi Devs, >>> >>> When I try to run metrics sample[1] in MSF4J, I'm getting the below NPE >>> during the invocation of the service. >>> >>> [msf4j.executor.workerpool-1] INFO org.wso2.msf4j.analytics.metrics.Metrics >>> - Initializing Metrics Services >>> [msf4j.executor.workerpool-1] ERROR >>> org.wso2.msf4j.analytics.metrics.MetricsInterceptor >>> - Exception while executing request interceptor class >>> org.wso2.msf4j.analytics.metrics.MetricsInterceptor >>> java.lang.NullPointerException >>> at org.wso2.carbon.metrics.core.Metrics.(Metrics.java:78) >>> at org.wso2.msf4j.analytics.metrics.Metrics.initializeServices( >>> Metrics.java:62) >>> at org.wso2.msf4j.analytics.metrics.Metrics.getMetricService(Me >>> trics.java:83) >>> at org.wso2.msf4j.analytics.metrics.MetricsInterceptor.preCall( >>> MetricsInterceptor.java:96) >>> at org.wso2.msf4j.Interceptor.interceptRequest(Interceptor.java:65) >>> at org.wso2.msf4j.interceptor.InterceptorExecutor.executeReques >>> tInterceptor(InterceptorExecutor.java:321) >>> at org.wso2.msf4j.interceptor.InterceptorExecutor.executeGlobal >>> RequestInterceptors(InterceptorExecutor.java:206) >>> at org.wso2.msf4j.interceptor.InterceptorExecutor.executeGlobal >>> RequestInterceptors(InterceptorExecutor.java:52) >>> at org.wso2.msf4j.internal.router.HttpMethodInfo.invokeResource >>> (HttpMethodInfo.java:179) >>> at org.wso2.msf4j.internal.router.HttpMethodInfo.invoke(HttpMet >>> hodInfo.java:143) >>> at org.wso2.msf4j.internal.MSF4JMessageProcessor.dispatchMethod >>> (MSF4JMessageProcessor.java:248) >>> at org.wso2.msf4j.internal.MSF4JMessageProcessor.lambda$receive >>> $0(MSF4JMessageProcessor.java:160) >>> at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPool >>> Executor.java:1142) >>> at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoo >>> lExecutor.java:617) >>> at java.lang.Thread.run(Thread.java:745) >>> >>> Did anyone encounter such an issue? >>> >>> [1] https://github.com/wso2/msf4j/tree/master/samples/metrics >>> >>> Thanks, >>> Chanaka >>> -- >>> Thank you and Best Regards, >>> Chanaka Fernando >>> Senior Technical Lead >>> m: +94 773337238 <+94%2077%20333%207238> >>> https://wso2.com <https://wso2.com/signature> >>> >>> >>> >>> >>> >>> >>> >>> ___ >>> Dev mailing list >>> Dev@wso2.org >>> http://wso2.org/cgi-bin/mailman/listinfo/dev >>> >>> >> >> >> -- >> Regards, >> >> *Viduranga Gunarathne* >> >> *Software Engineer Intern* >> >> >> *WSO2* >> Email : vidura...@wso2.com >> Mobile : +94712437484 <+94%2071%20243%207484> >> Web : http://wso2.com >> [image: https://wso2.com/signature] <https://wso2.com/signature> >> >> ___ >> Dev mailing list >> Dev@wso2.org >> http://wso2.org/cgi-bin/mailman/listinfo/dev >> >> > Best Regards, > > *Vidura Nanayakkara* > > Email : vidu...@wso2.com > Mobile : +94 (0) 717 919277 <+94%2071%20791%209277> > Web : http://wso2.com > -- Best Regards, *Vidura Nanayakkara* Software Engineer Email : vidu...@wso2.com Mobile : +94 (0) 717 919277 Web : http://wso2.com ___ Dev mailing list Dev@wso2.org http://wso2.org/cgi-bin/mailman/listinfo/dev
Re: [Dev] MSF4J (v2.4.1) Metrics sample throws NPE
Hi Chanaka, I was able to reproduce this issue and opened the git issue [1] to track this down. The null pointer exception is thrown when metrics configuration is retrieved due to carbon config resolver being not set. I will look into this and let you know once this is fixed asap. [1] https://github.com/wso2/msf4j/issues/482 On Fri, Oct 27, 2017 at 10:03 AM, Viduranga Gunarathne wrote: > Hi, > I too encountered the same issue, when I used the following code as stated > in the sample[1]: > > public static void main(String[] args) { > new MicroservicesRunner() > .addInterceptor(new MetricsInterceptor()) > .deploy(new HelloService()) > .deploy(new DemoService()) > .start(); > } > > It seems the "addInterceptor()" method is deprecated. > > The workaround to this was as follows: > *No need to pass an instance of "MetricsInterceptor" > > public static void main(String[] args) { > new MicroservicesRunner() > .addGlobalRequestInterceptor() > .addGlobalResponseInterceptor() > .deploy(new HelloService()) > .deploy(new DemoService()) > .start(); > } > > This worked out for me. > Hope this helps! > > [1] https://github.com/wso2/msf4j/tree/master/samples/metrics > > Thanks, > Viduranga. > > > > On Thu, Oct 26, 2017 at 9:40 AM, Chanaka Fernando > wrote: > >> Hi Devs, >> >> When I try to run metrics sample[1] in MSF4J, I'm getting the below NPE >> during the invocation of the service. >> >> [msf4j.executor.workerpool-1] INFO org.wso2.msf4j.analytics.metrics.Metrics >> - Initializing Metrics Services >> [msf4j.executor.workerpool-1] ERROR >> org.wso2.msf4j.analytics.metrics.MetricsInterceptor >> - Exception while executing request interceptor class >> org.wso2.msf4j.analytics.metrics.MetricsInterceptor >> java.lang.NullPointerException >> at org.wso2.carbon.metrics.core.Metrics.(Metrics.java:78) >> at org.wso2.msf4j.analytics.metrics.Metrics.initializeServices( >> Metrics.java:62) >> at org.wso2.msf4j.analytics.metrics.Metrics.getMetricService(Me >> trics.java:83) >> at org.wso2.msf4j.analytics.metrics.MetricsInterceptor.preCall( >> MetricsInterceptor.java:96) >> at org.wso2.msf4j.Interceptor.interceptRequest(Interceptor.java:65) >> at org.wso2.msf4j.interceptor.InterceptorExecutor.executeReques >> tInterceptor(InterceptorExecutor.java:321) >> at org.wso2.msf4j.interceptor.InterceptorExecutor.executeGlobal >> RequestInterceptors(InterceptorExecutor.java:206) >> at org.wso2.msf4j.interceptor.InterceptorExecutor.executeGlobal >> RequestInterceptors(InterceptorExecutor.java:52) >> at org.wso2.msf4j.internal.router.HttpMethodInfo.invokeResource >> (HttpMethodInfo.java:179) >> at org.wso2.msf4j.internal.router.HttpMethodInfo.invoke(HttpMet >> hodInfo.java:143) >> at org.wso2.msf4j.internal.MSF4JMessageProcessor.dispatchMethod >> (MSF4JMessageProcessor.java:248) >> at org.wso2.msf4j.internal.MSF4JMessageProcessor.lambda$receive >> $0(MSF4JMessageProcessor.java:160) >> at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPool >> Executor.java:1142) >> at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoo >> lExecutor.java:617) >> at java.lang.Thread.run(Thread.java:745) >> >> Did anyone encounter such an issue? >> >> [1] https://github.com/wso2/msf4j/tree/master/samples/metrics >> >> Thanks, >> Chanaka >> -- >> Thank you and Best Regards, >> Chanaka Fernando >> Senior Technical Lead >> m: +94 773337238 <+94%2077%20333%207238> >> https://wso2.com <https://wso2.com/signature> >> >> >> >> >> >> >> >> ___ >> Dev mailing list >> Dev@wso2.org >> http://wso2.org/cgi-bin/mailman/listinfo/dev >> >> > > > -- > Regards, > > *Viduranga Gunarathne* > > *Software Engineer Intern* > > > *WSO2* > Email : vidura...@wso2.com > Mobile : +94712437484 <+94%2071%20243%207484> > Web : http://wso2.com > [image: https://wso2.com/signature] <https://wso2.com/signature> > > ___ > Dev mailing list > Dev@wso2.org > http://wso2.org/cgi-bin/mailman/listinfo/dev > > Best Regards, *Vidura Nanayakkara* Email : vidu...@wso2.com Mobile : +94 (0) 717 919277 <+94%2071%20791%209277> Web : http://wso2.com ___ Dev mailing list Dev@wso2.org http://wso2.org/cgi-bin/mailman/listinfo/dev
Re: [Dev] Disabling hostname verification on Kernel 4.4.17-SNAPSHOT
Hi Kishanthan, The documentation for enabling the host names (using *httpclient.hostnameVerifier *property) is already available in [1] (old configuration is also removed from the docs). [1] https://docs.wso2.com/display/ADMIN44x/Enabling+HostName+Verification Best Regards, ViduraNanayakkara On Fri, Aug 18, 2017 at 12:26 PM, Kishanthan Thangarajah < kishant...@wso2.com> wrote: > Hi ViduraN, > > Shall we make sure that all the above information is captured in the > documentation? > > Thanks, > > On Thu, Aug 17, 2017 at 3:22 PM, Vidura Nanayakkara > wrote: > >> Hi, >> >> On Thu, Aug 17, 2017 at 7:49 AM, Chandana Napagoda >> wrote: >> >>> Hi >>> >>> Could you please point the fix you have made to address this issue? >>> >> >> As Shariq mentioned, *org.wso2.ignoreHostnameVerification *property was >> removed from Kernel 4.4.17 onwards. With PR [1], commons-httpclient >> library coming from kernel will handle host name verification by itself. >> The property *org.wso2.ignoreHostnameVerification* is replaced by >> *httpclient.hostnameVerifier*. The possible values for >> *httpclient.hostnameVerifier *is as described below: >> >>- DefaultAndLocalhost - Verify host name without being strict with >>sub-domains (*.foo.com is allowed to match with a.b.foo.com) and also >>allow local host >>- AllowAll - Allows all hosts >>- Strict - Verify all hosts while being strict with sub-domains (*. >>foo.com is not allowed to match with a.b.foo.com) >> >> Example: httpclient.hostnameVerifier="Strict" >> >> By default, host name verification will happen for all hosts without >> being strict with sub-domains (*.foo.com is allowed to match with >> a.b.foo.com) >> >> Since host name verification is handled by the commons-httpclient library >> coming from the kernel (with PR [1]), other components do not need to worry >> about handling host name verification. For instance, handling host name >> verification is removed from the jaggery component in PR [2]. >> >> [1] https://github.com/wso2/wso2-commons-httpclient/pull/5 >> [2] https://github.com/wso2/jaggery/pull/174/ >> >> >>> >>> Regards, >>> Chandana >>> >>> On Thu, Aug 17, 2017 at 7:20 AM, Muhammed Shariq >>> wrote: >>> >>>> On Wed, Aug 16, 2017 at 11:45 PM, Kishanthan Thangarajah < >>>> kishant...@wso2.com> wrote: >>>> >>>>> >>>>> >>>>> On Wed, Aug 16, 2017 at 9:48 PM, Nuwandi Wickramasinghe < >>>>> nuwan...@wso2.com> wrote: >>>>> >>>>>> Hi all, >>>>>> >>>>>> With the latest IS pack built with kernel 4.4.17-SNAPSHOT, we can >>>>>> successfully turn off the hostname verification with >>>>>> *-Dhttpclient.hostnameVerifier=AllowAll*. >>>>>> >>>>> >>>>> What was the original issue? Farasath has followed the same steps (IS >>>>> with 4.4.17-SNAPSHOT) and mentioned that the above property was not >>>>> working >>>>> according to the mail above. >>>>> >>>>> >>>>>> Need to do some code changes from Identity Server side to make the >>>>>> newly introduced property effective for some components. >>>>>> >>>>> >>>>> What are the code changes? This property is only used in httpclient >>>>> coming from kernel. So why changes are required at IS side? >>>>> >>>> >>>> Prior to kernel 4.4.17 there was a property >>>> *-Dorg.wso2.ignoreHostnameVerification=true >>>> *that was used to disable hostname verification. IINM, the issue here >>>> is some components use this property to disable hostname verification, but >>>> since it's that property has been removed since 4.4.17 that might be >>>> causing some issue, so they are investigating on IS side. >>>> >>>> Nuwandi / Fara - correct me if I am wrong. >>>> >>>>> >>>>> >>>>>> Since no improvement is needed from kernel side, can we please go >>>>>> ahead with the kernel 4.4.17 release? >>>>>> >>>>>> *-Dhttpclient.hostnameVerifier *is only applicable since 4.4.17, but >>>>>> our documentation says it's applicable from 4.4.10 ([1]). Better to fix >>>>>> the
Re: [Dev] Disabling hostname verification on Kernel 4.4.17-SNAPSHOT
d.java:748) >>>>>>> Caused by: javax.net.ssl.SSLHandshakeException: >>>>>>> java.security.cert.CertificateException: No name matching >>>>>>> idp.wso2.com found >>>>>>> at sun.security.ssl.Alerts.getSSLException(Alerts.java:192) >>>>>>> at sun.security.ssl.SSLSocketImpl.fatal(SSLSocketImpl.java:1949) >>>>>>> at sun.security.ssl.Handshaker.fatalSE(Handshaker.java:302) >>>>>>> at sun.security.ssl.Handshaker.fatalSE(Handshaker.java:296) >>>>>>> at sun.security.ssl.ClientHandshaker.serverCertificate(ClientHa >>>>>>> ndshaker.java:1514) >>>>>>> at sun.security.ssl.ClientHandshaker.processMessage(ClientHands >>>>>>> haker.java:216) >>>>>>> at sun.security.ssl.Handshaker.processLoop(Handshaker.java:1026) >>>>>>> at sun.security.ssl.Handshaker.process_record(Handshaker.java:961) >>>>>>> at sun.security.ssl.SSLSocketImpl.readRecord(SSLSocketImpl.java >>>>>>> :1062) >>>>>>> at sun.security.ssl.SSLSocketImpl.performInitialHandshake(SSLSo >>>>>>> cketImpl.java:1375) >>>>>>> at sun.security.ssl.SSLSocketImpl.startHandshake(SSLSocketImpl. >>>>>>> java:1403) >>>>>>> at sun.security.ssl.SSLSocketImpl.startHandshake(SSLSocketImpl. >>>>>>> java:1387) >>>>>>> at sun.net.www.protocol.https.HttpsClient.afterConnect(HttpsCli >>>>>>> ent.java:559) >>>>>>> at sun.net.www.protocol.https.AbstractDelegateHttpsURLConnectio >>>>>>> n.connect(AbstractDelegateHttpsURLConnection.java:185) >>>>>>> at sun.net.www.protocol.https.HttpsURLConnectionImpl.connect(Ht >>>>>>> tpsURLConnectionImpl.java:153) >>>>>>> at org.apache.jsp.login_jsp._jspService(login_jsp.java:777) >>>>>>> at org.apache.jasper.runtime.HttpJspBase.service(HttpJspBase.ja >>>>>>> va:70) >>>>>>> at javax.servlet.http.HttpServlet.service(HttpServlet.java:731) >>>>>>> at org.apache.jasper.servlet.JspServletWrapper.service(JspServl >>>>>>> etWrapper.java:439) >>>>>>> ... 44 more >>>>>>> Caused by: java.security.cert.CertificateException: No name >>>>>>> matching idp.wso2.com found >>>>>>> at sun.security.util.HostnameChecker.matchDNS(HostnameChecker.j >>>>>>> ava:221) >>>>>>> at sun.security.util.HostnameChecker.match(HostnameChecker.java:95) >>>>>>> at sun.security.ssl.X509TrustManagerImpl.checkIdentity(X509Trus >>>>>>> tManagerImpl.java:455) >>>>>>> at sun.security.ssl.X509TrustManagerImpl.checkIdentity(X509Trus >>>>>>> tManagerImpl.java:436) >>>>>>> at sun.security.ssl.X509TrustManagerImpl.checkTrusted(X509Trust >>>>>>> ManagerImpl.java:200) >>>>>>> at sun.security.ssl.X509TrustManagerImpl.checkServerTrusted(X50 >>>>>>> 9TrustManagerImpl.java:124) >>>>>>> at sun.security.ssl.ClientHandshaker.serverCertificate(ClientHa >>>>>>> ndshaker.java:1496) >>>>>>> ... 58 more >>>>>>> >>>>>>> >>>>>>> Is the information in [1] still valid? >>>>>>> >>>>>>> Chandana pointed out there has been a http client version upgrade in >>>>>>> Kernel 4.4.17. Could this be a reason for this? >>>>>>> >>>>>>> >>>>>>> [1] https://docs.wso2.com/display/ADMIN44x/Enabling+HostName >>>>>>> +Verification >>>>>>> >>>>>>> >>>>>>> Thanks, >>>>>>> Farasath Ahamed >>>>>>> Software Engineer, WSO2 Inc.; http://wso2.com >>>>>>> Mobile: +94777603866 >>>>>>> Blog: blog.farazath.com >>>>>>> Twitter: @farazath619 <https://twitter.com/farazath619> >>>>>>> <http://wso2.com/signature> >>>>>>> >>>>>>> >>>>>>> >>>>>>> ___ >>>>>>> Dev mailing list >>>>>>> Dev@wso2.org >>>>>>> http://wso2.org/cgi-bin/mailman/listinfo/dev >>>>>>> >>>>>>> >>>>>>> >>>>>> >>>>> >>>>> ___ >>>>> Dev mailing list >>>>> Dev@wso2.org >>>>> http://wso2.org/cgi-bin/mailman/listinfo/dev >>>>> >>>>> >>>> >>>> >>>> -- >>>> >>>> Best Regards, >>>> >>>> Nuwandi Wickramasinghe >>>> >>>> Software Engineer >>>> >>>> WSO2 Inc. >>>> >>>> Web : http://wso2.com >>>> >>>> Mobile : 0719214873 <071%20921%204873> >>>> >>> >>> >>> >>> -- >>> *Kishanthan Thangarajah* >>> Technical Lead, >>> Platform Technologies Team, >>> WSO2, Inc. >>> lean.enterprise.middleware >>> >>> Mobile - +94773426635 <+94%2077%20342%206635> >>> Blog - *http://kishanthan.wordpress.com >>> <http://kishanthan.wordpress.com>* >>> Twitter - *http://twitter.com/kishanthan >>> <http://twitter.com/kishanthan>* >>> >>> ___ >>> Dev mailing list >>> Dev@wso2.org >>> http://wso2.org/cgi-bin/mailman/listinfo/dev >>> >>> >> >> >> -- >> Thanks, >> Shariq >> Associate Technical Lead >> >> ___ >> Dev mailing list >> Dev@wso2.org >> http://wso2.org/cgi-bin/mailman/listinfo/dev >> >> > > > -- > *Chandana Napagoda* > Associate Technical Lead > WSO2 Inc. - http://wso2.org > > *Email : chand...@wso2.com **Mobile : +94718169299 > <+94%2071%20816%209299>* > > *Blog :http://blog.napagoda.com <http://blog.napagoda.com> | > http://chandana.napagoda.com <http://chandana.napagoda.com>* > > *Linkedin : http://www.linkedin.com/in/chandananapagoda > <http://www.linkedin.com/in/chandananapagoda>* > > > ___ > Dev mailing list > Dev@wso2.org > http://wso2.org/cgi-bin/mailman/listinfo/dev > > Best Regards, Vidura Nanayakkara -- Best Regards, *Vidura Nanayakkara* Software Engineer Email : vidu...@wso2.com Mobile : +94 (0) 717 919277 Web : http://wso2.com ___ Dev mailing list Dev@wso2.org http://wso2.org/cgi-bin/mailman/listinfo/dev
Re: [Dev] [DEV] Can we bind custom interceptors in msf4j2.3.0-m2
Hi Ishara, So, can we have the support to be able to plug custom interceptors for > microservices? I f you are asking about the dynamic interceptors similar to the dynamic binding of filters in JAX-RS spec [1], MSF4J currently do not support dynamic binding of interceptors. [1] https://access.redhat.com/documentation/en-us/red_hat_jboss_fuse/6.3/html/apache_cxf_development_guide/jaxrs20filters#JAXRS20Filters-DynamicBinding Best Regards, Vidura Nanayakkara On Thu, Jun 1, 2017 at 1:19 PM, Ishara Cooray wrote: > Thanks for the clarification Vidura. > > So, can we have the support to be able to plug custom interceptors for > microservices? > > > Thanks & Regards, > Ishara Cooray > Senior Software Engineer > Mobile : +9477 262 9512 <+94%2077%20262%209512> > WSO2, Inc. | http://wso2.com/ > Lean . Enterprise . Middleware > > On Thu, Jun 1, 2017 at 1:02 PM, Vidura Nanayakkara > wrote: > >> Hi Ishara, >> >> On Thu, Jun 1, 2017 at 12:29 PM, Ishara Cooray wrote: >> >>> According to the new Interceptor support in msf4j-2.3.0-m2 >>> >>> AFAIU, >>> We can bind interceptors for a given microservice as below. >>> >>> InterceptorService is the micro service that is going to be intercepted by >>> RequestInterceptors and Responseinterceptors annotated by >>> >>> @RequestInterceptor and @ResponseInterceptor >>> >>> @Component( >>>> name = "InterceptorService", >>>> service = Microservice.class, >>>> immediate = true >>>> )@Path("/interceptor-service")public class InterceptorService implements >>>> Microservice { >>>> >>>> >>>> private static final Logger log = >>>> LoggerFactory.getLogger(InterceptorService.class); >>>> >>>> >>>> /** * Method for getting the micro-service name. * * >>>> @return name of the micro-service. */ >>>> @GET >>>> @Path("/service-name") >>>> @RequestInterceptor( >>>> >>>> HTTPRequestLogger.class) >>>> @ResponseInterceptor(HTTPResponseLogger.class) >>>> public String getServiceName() { >>>> log.info("HTTP Method Execution - getServiceName()"); >>>> return "WSO2 Service"; >>>> } >>>> } >>>> >>>> 1. Can we use @RequestInterceptor and @ResponseInterceptor annotations >>> to the class level so that it will apply for every resource invocation? >>> >> >> Yes, you can use @RequestInterceptor and @ResponseInterceptor to the >> class level so that it will apply to every resource invocation in the >> service. >> >> Example: >> >> @Path("/stockquote") >> >> @RequestInterceptor( >> >> HTTPRequestLogger.class) >> >> @ResponseInterceptor({HTTPResponseLogger.class, >> LogTextResponseInterceptor.class}) >> >> public class StockQuoteService { >> // Your resource methods here >> } >> >> Furthermore, if you want to apply the interceptors to all the services in a >> micro-service in OSGi mode please refer [1] and for non-OSGi mode please >> refer [2] and [3]. >> >> >>> 2. Can we plug a custom request/response interceptors? >>> >>> Can it be supported something similar to below. >>> We have a class called ABCRequestInterceptor which implements >>> RequestInterceptor >>> and there can be classes that extends >>> ABCRequestInterceptor >>> >>> But , we bind the interceptor as >>> >>> @RequestInterceptor(ABCRequestInterceptor.class) >>> >>> Will this bind extended Interceptors too to the InterceptorService? >>> >> >> In this case the ABCRequestInterceptor will be the interceptor which >> gets executed. Please note that the other interceptors which is extended >> from this class do not get executed (The class you mention in the >> annotation is taken exactly as it is) >> >> >>> >>> Thanks & Regards, >>> Ishara Cooray >>> Senior Software Engineer >>> Mobile : +9477 262 9512 <+94%2077%20262%209512> >>> WSO2, Inc. | http://wso2.com/ >>> Lean . Enterprise . Middleware >>> >> >> >> [1] https://github.com/wso2/msf4j/blob/release-2.3.0-m1/samples/ >> interceptor/osgi-interceptor-service/README.md >> [2] https://github.com/wso2/msf4j/tree/release-2.3.0-m1/samp >> les/interceptor/fatjar-interceptor-service >> [3] https://github.com/wso2/msf4j/blob/release-2.3.0-m1/samp >> les/interceptor/fatjar-interceptor-service/src/main/java/ >> org/wso2/msf4j/samples/fatjarinterceptorservice/Application.java >> >> Best Regards, >> Vidura Nanayakkara >> >> -- >> Best Regards, >> >> *Vidura Nanayakkara* >> Software Engineer >> >> Email : vidu...@wso2.com >> Mobile : +94 (0) 717 919277 <+94%2071%20791%209277> >> Web : http://wso2.com >> Blog : https://medium.com/@viduran >> LinkedIn : https://lk.linkedin.com/in/vidura-nanayakkara >> > > -- Best Regards, *Vidura Nanayakkara* Software Engineer Email : vidu...@wso2.com Mobile : +94 (0) 717 919277 Web : http://wso2.com Blog : https://medium.com/@viduran LinkedIn : https://lk.linkedin.com/in/vidura-nanayakkara ___ Dev mailing list Dev@wso2.org http://wso2.org/cgi-bin/mailman/listinfo/dev
Re: [Dev] [DEV] Can we bind custom interceptors in msf4j2.3.0-m2
Hi Ishara, On Thu, Jun 1, 2017 at 12:29 PM, Ishara Cooray wrote: > According to the new Interceptor support in msf4j-2.3.0-m2 > > AFAIU, > We can bind interceptors for a given microservice as below. > > InterceptorService is the micro service that is going to be intercepted by > RequestInterceptors and Responseinterceptors annotated by > > @RequestInterceptor and @ResponseInterceptor > > @Component( >> name = "InterceptorService", >> service = Microservice.class, >> immediate = true >> )@Path("/interceptor-service")public class InterceptorService implements >> Microservice { >> >> >> private static final Logger log = >> LoggerFactory.getLogger(InterceptorService.class); >> >> >> /** * Method for getting the micro-service name. * * @return >> name of the micro-service. */ >> @GET >> @Path("/service-name") >> @RequestInterceptor( >> >> HTTPRequestLogger.class) >> @ResponseInterceptor(HTTPResponseLogger.class) >> public String getServiceName() { >> log.info("HTTP Method Execution - getServiceName()"); >> return "WSO2 Service"; >> } >> } >> >> 1. Can we use @RequestInterceptor and @ResponseInterceptor annotations > to the class level so that it will apply for every resource invocation? > Yes, you can use @RequestInterceptor and @ResponseInterceptor to the class level so that it will apply to every resource invocation in the service. Example: @Path("/stockquote") @RequestInterceptor( HTTPRequestLogger.class) @ResponseInterceptor({HTTPResponseLogger.class, LogTextResponseInterceptor.class}) public class StockQuoteService { // Your resource methods here } Furthermore, if you want to apply the interceptors to all the services in a micro-service in OSGi mode please refer [1] and for non-OSGi mode please refer [2] and [3]. > 2. Can we plug a custom request/response interceptors? > > Can it be supported something similar to below. > We have a class called ABCRequestInterceptor which implements > RequestInterceptor > and there can be classes that extends > ABCRequestInterceptor > > But , we bind the interceptor as > > @RequestInterceptor(ABCRequestInterceptor.class) > > Will this bind extended Interceptors too to the InterceptorService? > In this case the ABCRequestInterceptor will be the interceptor which gets executed. Please note that the other interceptors which is extended from this class do not get executed (The class you mention in the annotation is taken exactly as it is) > > Thanks & Regards, > Ishara Cooray > Senior Software Engineer > Mobile : +9477 262 9512 <+94%2077%20262%209512> > WSO2, Inc. | http://wso2.com/ > Lean . Enterprise . Middleware > [1] https://github.com/wso2/msf4j/blob/release-2.3.0-m1/samples/interceptor/osgi-interceptor-service/README.md [2] https://github.com/wso2/msf4j/tree/release-2.3.0-m1/samples/interceptor/fatjar-interceptor-service [3] https://github.com/wso2/msf4j/blob/release-2.3.0-m1/samples/interceptor/fatjar-interceptor-service/src/main/java/org/wso2/msf4j/samples/fatjarinterceptorservice/Application.java Best Regards, Vidura Nanayakkara -- Best Regards, *Vidura Nanayakkara* Software Engineer Email : vidu...@wso2.com Mobile : +94 (0) 717 919277 Web : http://wso2.com Blog : https://medium.com/@viduran LinkedIn : https://lk.linkedin.com/in/vidura-nanayakkara ___ Dev mailing list Dev@wso2.org http://wso2.org/cgi-bin/mailman/listinfo/dev
Re: [Dev] [C5] Kernel build fails due to OSGI test failure
Hi Milinda, This is due to missing 'server.name' environment variable that is required by an OSGi test. [1] Tries to set the environment variable 'server.name' but it is not set in Linux environments due to Linux allows only uppercase letters, digits, and the '_' (underscore) for an environment variable name [2]. This issue is reported in [3] and will be fixed with PR [4]. [1] https://github.com/wso2/carbon-kernel/blob/master/ tests/osgi-tests/src/test/java/org/wso2/carbon/osgi/config/ PropertyResolveConfigProviderOSGITest.java#L59 [2] https://stackoverflow.com/questions/2821043/allowed-characters-in-linux- environment-variable-names [3] https://github.com/wso2/carbon-kernel/issues/1383 [4] https://github.com/wso2/carbon-kernel/pull/1384 Best Regards, Vidura Nanayakkara On Thu, May 25, 2017 at 4:54 PM, Milinda Wickramasinghe wrote: > Hi Kernel team / All, > > When trying to build the Carbon-Kernel from a fresh clone, it fails giving > the following error. > > osgi> [2017-05-25 15:56:49,471] ERROR > {org.wso2.carbon.config.provider.ConfigProviderImpl} >> - Environment variable server.name not found. Placeholder: id: >> test-carbon-kernel >> > > More info on the error can be found in the attachment > "osgi-test-failure-kernel.txt". > > Am I doing something wrong here? or is this a known issue? > > Appreciate your feedback on this. > > Thanks and Best Regards, > Milinda. > > *Software Engineer - Platform Security Team* > Mobile : +94 (0) 777 890 864 <%2B94%20%280%29%20773%20451194> > milin...@wso2.com > -- Best Regards, *Vidura Nanayakkara* Software Engineer Email : vidu...@wso2.com Mobile : +94 (0) 717 919277 Web : http://wso2.com Blog : https://medium.com/@viduran LinkedIn : https://lk.linkedin.com/in/vidura-nanayakkara ___ Dev mailing list Dev@wso2.org http://wso2.org/cgi-bin/mailman/listinfo/dev
[Dev] [UUF] Concrete User Class Instead of the User Interface
Hi All, As per the discussions in [1], we are in the process of introducing extensible authorization for Carbon UUF. According to these new introductions the org.wso2.carbon.uuf.spi.auth.User interface will be changed to org.wso2.carbon.uuf.api.auth.User class [2]. The methods of the org.wso2.carbon.uuf.api.auth.User class [2] would be as depicted in the diagram below: This would be a breaking change for authentication mechanisms implemented using the existing org.wso2.carbon.uuf.spi.auth.User interface (e.g:- [3]). [1] Architecture mail thread "[UUF] Extensible Authorization for UUF" [2] https://github.com/wso2/carbon-uuf/pull/254/files#diff-d90f2b12f93e9fe0f0bdcb85390ae6f1 [3] https://github.com/wso2/product-is/blob/master/portal/client-services/org.wso2.is.portal.user.client.api/src/main/java/org/wso2/is/portal/user/client/api/bean/UUFUser.java Best Regards, *Vidura Nanayakkara* Software Engineer Email : vidu...@wso2.com Mobile : +94 (0) 717 919277 Web : http://wso2.com Blog : https://medium.com/@viduran <http://wso2.com/> LinkedIn : https://lk.linkedin.com/in/vidura-nanayakkara <http://wso2.com/> ___ Dev mailing list Dev@wso2.org http://wso2.org/cgi-bin/mailman/listinfo/dev
Re: [Dev] Security Patch Releases - API Manager 2.1.0
Hi Gayakshika, I checked the above 3 patches. Here are the affected products for each patch (security) *WSO2-CARBON-PATCH-4.4.0-0665* - WSO2 API Manager 2.0.0 - WSO2 App Manager 1.2.0 - WSO2 Business Process Server 3.6.0 - WSO2 Complex Event Processor 4.2.0 - WSO2 Data Analytics Server 3.1.0 - WSO2 Data Services Server 3.5.1 - WSO2 Enterprise Service Bus 5.0.0 - WSO2 Identity Server 5.2.0 - WSO2 Machine Learner 1.2.0 *WSO2-CARBON-PATCH-4.4.0-0666* - WSO2 API Manager 2.0.0 - WSO2 App Manager 1.2.0 - WSO2 Machine Learner 1.2.0 - WSO2 Governance Registry 5.3.0 *WSO2-CARBON-PATCH-4.4.0-0676* - WSO2 App Manager 1.2.0 As you can see there is clearly a mistake in the website page you have referred. Here is how they should be corrected - There is no WSO2 API Manager 1.2.0. This should be WSO2 API Manager 2.0.0 - The patches are affected to WSO2 App Manager 1.2.0 ("APP" is mistakenly taken as "API") Thank you, Vidura Nanayakkara On Tue, Apr 25, 2017 at 4:54 PM, Gayakshika Gimhani [IT/EKO/LOITS] < gayakshi...@lolctech.com> wrote: > Hi, > > > > I referred below link for the security patch releases for API Manager > 2.1.0. > > http://wso2.com/security-patch-releases/api-manager > > > > I just want to confirm the product versions for first three patches are > correct as the API Manager is not mentioned under the *AFFECTED PRODUCTS *of > their *Security Advisory Links* > > > > > > > > > > Thanks & best regards! > > > > *K.M.Gayakshika Gimhani* > > Trainee Software Engineer > > LOLC Technologies > > Email: gayakshi...@lolc.com > > > > > > > > > > ___ > Dev mailing list > Dev@wso2.org > http://wso2.org/cgi-bin/mailman/listinfo/dev > > -- Best Regards, *Vidura Nanayakkara* Software Engineer Email : vidu...@wso2.com Mobile : +94 (0) 717 919277 Web : http://wso2.com Blog : https://medium.com/@viduran <http://wso2.com/> LinkedIn : https://lk.linkedin.com/in/vidura-nanayakkara <http://wso2.com/> ___ Dev mailing list Dev@wso2.org http://wso2.org/cgi-bin/mailman/listinfo/dev
Re: [Dev] Is there a hard and fast rule to chose java 8 streams over for loops
_ >>>> Dev mailing list >>>> Dev@wso2.org >>>> http://wso2.org/cgi-bin/mailman/listinfo/dev >>>> >>>> >>> >>> >>> -- >>> *Tharika Madurapperuma* >>> Software Engineer | WSO2, Inc. >>> >>> Email : thar...@wso2.com >>> Mobile : +94777875624 <+94%2077%20787%205624> >>> Web : http://wso2.com >>> >>> <http://wso2.com/signature> >>> >>> ___ >>> Dev mailing list >>> Dev@wso2.org >>> http://wso2.org/cgi-bin/mailman/listinfo/dev >>> >>> >> >> >> -- >> Pumudu Ruhunage >> Software Engineer | WSO2 Inc >> M: +94 779 664493 | http://wso2.com >> <https://wso2.com/signature> >> >> ___ >> Dev mailing list >> Dev@wso2.org >> http://wso2.org/cgi-bin/mailman/listinfo/dev >> >> > > ___ > Dev mailing list > Dev@wso2.org > http://wso2.org/cgi-bin/mailman/listinfo/dev > > Best Regards, *Vidura Nanayakkara* Software Engineer Email : vidu...@wso2.com Mobile : +94 (0) 717 919277 Web : http://wso2.com ___ Dev mailing list Dev@wso2.org http://wso2.org/cgi-bin/mailman/listinfo/dev
[Dev] [Carbon-Utils] Carbon Utils
Hi All, We have moved carbon utils out of carbon kernel to a separate repo [1] <https://github.com/wso2/carbon-utils>. However, there is no carbon utils feature implemented for carbon utils yet. Since we are using carbon utils dependency inside the carbon kernel, IMO we should create a carbon utils feature as well. We also will be needing this feature when building a carbon kernel distribution and else where required. WDYT? [1] Carbon Utils <https://github.com/wso2/carbon-utils> Best Regards, *Vidura Nanayakkara* Software Engineer Email : vidu...@wso2.com Mobile : +94 (0) 717 919277 Web : http://wso2.com ___ Dev mailing list Dev@wso2.org http://wso2.org/cgi-bin/mailman/listinfo/dev
[Dev] [Carbon Config] Carbon Configuration OSGi Sample
Hi All, I am in the process if including an OSGi sample to demonstrate Carbon Configuration in OSGi mode. This sample will be included in [1] <https://github.com/wso2/carbon-config/>. In order to run this sample, we can direct the user to follow either of the following paths. 1. Download Carbon Kernel and copy the sample's OSGi bundles to the relevant location 2. Build a distribution of the Carbon Kernel and then copy the sample's OSGi bundle to the relevant location. If we are to follow the 2nd approach, then the user do not have to download the Carbon Kernel from the website (easy for the user). However, this approach cannot be done since Carbon Configuration needs to be released before the Kernel release. So as an alternative approach we can create a distribution that only has the OSGi runtime, Carbon configuration feature and the Carbon Secure Vault feature. Should I proceed with the above approach or approach #1? [1] Carbon Configuration Repository <https://github.com/wso2/carbon-config/> Best Regards, *Vidura Nanayakkara* Software Engineer Email : vidu...@wso2.com Mobile : +94 (0) 717 919277 Web : http://wso2.com Blog : https://medium.com/@viduran <http://wso2.com/> LinkedIn : https://lk.linkedin.com/in/vidura-nanayakkara <http://wso2.com/> ___ Dev mailing list Dev@wso2.org http://wso2.org/cgi-bin/mailman/listinfo/dev
Re: [Dev] [MSF4J] Can we provide HTTP handler args in Interceptor level?
Hi Sanjeewa and Malintha, Myself and Azeez had a discussion on the discussed enhancement in MSF4J and we agreed to deliver it. We will be releasing MSF4J along with this change, Carbon Metrics and Interceptors. We will let you know the ETA probably in this week. Thank you, Vidura Nanayakkara On Tue, Mar 14, 2017 at 1:20 PM, Sanjeewa Malalgoda wrote: > Hi All, > Appreciate your urgent attention on this as we are depend on this feature > for our M2 release. > > Thanks, > sanjeewa. > > On Thu, Mar 9, 2017 at 6:18 PM, Malintha Amarasinghe > wrote: > >> Hi Azeez, >> >> We would be very grateful if you can review the suggested approach above >> by Vidura. >> >> Thanks!and >> Malintha >> >> On Thu, Mar 2, 2017 at 12:41 PM, Vidura Nanayakkara >> wrote: >> >>> Hi Azeez, >>> >>> We had a discussion regarding this. Following are the solutions we >>> decided >>> >>>- Set object handler as a property in the Request instance (just >>>like we are setting the HTTP method according to [1] >>><https://github.com/wso2/msf4j/pull/338>) >>> >>> With this change you can access the handler through the Request instance >>> just like as shown below: >>> >>> request.getProperty("HANDLER") >>> >>> >>>- Include method arguments in the Request instance. >>> >>> As for what we suggested in the previous discussion, >>> >>> *I have also tried is to build the Request inside the Interceptor and >>> get the Java method and the args from the Request (which was suggested >>> during the offline discussion)* >>> >>> With the pull request [1] <https://github.com/wso2/msf4j/pull/338> we >>> are building the Request before the interceptors are executed. So this is >>> handled. >>> >>> WDYT? >>> >>> [1] Interceptors pull request <https://github.com/wso2/msf4j/pull/338> >>> >>> On Thu, Mar 2, 2017 at 10:33 AM, Vidura Nanayakkara >>> wrote: >>> >>>> Hi Malintha, >>>> >>>> As for the questions, you asked regarding the 1st approach I suggested: >>>> >>>> >>>> * - Write a custom context provider of your own which will describe how >>>> the injected value is generated by implementing a certain interface.In the >>>> custom context provider, will we have access to the internal objects like >>>> [1] so that we can use them to generate the custom context object?* >>>> >>>> As per my understanding using approach 1 (custom context providers) it >>>> would be a no. As I mentioned in the previous response, by default we can >>>> access the Request, Response, HttpStreamer, FormParamIterator and >>>> MultivaluedMap instances using the @Context annotation. If you need access >>>> to the MSF4J internal objects like [1] >>>> <https://github.com/wso2/msf4j/blob/v2.1.1/core/src/main/java/org/wso2/msf4j/internal/MSF4JMessageProcessor.java#L129>, >>>> we need to make it accessible by default using the @Context annotation. >>>> >>>> The purpose of the custom context provider is to help you inject custom >>>> values by specifying the logic on how the value are generated (probably to >>>> feed the arguments to your interceptors and the HTTP methods). >>>> >>>>- *Register the custom context provider to the MSF4J* >>>>- *Inject the value using @Context annotation (Ex:- @Context(String >>>>key) Object[] arguments)* >>>> >>>> *Will it be possible to access the injected values within Interceptors? >>>> Since one of our requirement is to come up with an Interceptor to validate >>>> ETags in a central place, we need to access them within the Interceptor.* >>>> >>>> Yes, this would be an enhancement to MSF4J (with or without custom >>>> context provider implementation). >>>> >>>> However, it would be great if we can have a discussion regarding this. >>>> >>>> [1] HttpResourceModel MSF4J internal object >>>> <https://github.com/wso2/msf4j/blob/v2.1.1/core/src/main/java/org/wso2/msf4j/internal/MSF4JMessageProcessor.java#L129> >>>> >>>> >>>> On Wed, Mar 1, 2017 at 10:41 AM, Malintha Amarasinghe < >>>> malint...@wso2.com> wrote: >>>> >>>>> >>>>> >>>>> On Wed, Mar 1, 201
Re: [Dev] Please Review and Merge (WebSocket Suppport for Carbon-Messaging)
Hi Irunika, Added some comments in [1] <https://github.com/wso2/msf4j/pull/364>. Please do check. [1] MSF4J Web Socket Pull Request <https://github.com/wso2/msf4j/pull/364> Thank you, Vidura Nanayakkara On Wed, Mar 8, 2017 at 6:21 PM, Irunika Weeraratne wrote: > Hi all, > Please review the new changes did and comment. > > https://github.com/wso2/msf4j/pull/364 > > Thanks, > Irunika > > *Irunika Weeraratne* > *Software Engineer | WSO2, Inc. <http://wso2.com/>* > *Email : irun...@wso2.com * > *LinkedIn : https://lk.linkedin.com/in/irunika > <https://lk.linkedin.com/in/irunika>* > *Mobile : +94712403314 <+94%2071%20240%203314>* > *Lean . Enterprise . Middleware* > > > On Wed, Feb 1, 2017 at 3:28 PM, Irunika Weeraratne > wrote: > >> Hi all, >> Created new pull request with necessary changes[1]. >> >> please review and merge. >> >> [1]https://github.com/wso2/carbon-messaging/pull/41 >> >> Thanks, >> Irunika >> >> *Irunika Weeraratne* >> *Software Engineer | WSO2, Inc. <http://wso2.com/>* >> *Email : irun...@wso2.com * >> *LinkedIn : https://lk.linkedin.com/in/irunika >> <https://lk.linkedin.com/in/irunika>* >> *Mobile : +94712403314 <+94%2071%20240%203314>* >> *Lean . Enterprise . Middleware* >> >> >> On Mon, Jan 30, 2017 at 8:34 PM, Irunika Weeraratne >> wrote: >> >>> Hi Senduran, >>> Yes. We can use a general control message type instead of ping and pong >>> messages. So I removed ping and pong carbon message types from >>> Carbon-Messaging and added new message type ". >>> >>> Please review and merge. >>> >>> Thanks, >>> Irunika >>> >>> *Irunika Weeraratne* >>> *Software Engineer | WSO2, Inc. <http://wso2.com/>* >>> *Email : irun...@wso2.com * >>> *LinkedIn : https://lk.linkedin.com/in/irunika >>> <https://lk.linkedin.com/in/irunika>* >>> *Mobile : +94712403314 <+94%2071%20240%203314>* >>> *Lean . Enterprise . Middleware* >>> >>> >>> On Mon, Jan 30, 2017 at 2:20 PM, Senduran Balasubramaniyam < >>> sendu...@wso2.com> wrote: >>> >>>> Hi Irunika, >>>> >>>> The above PR has PingCarbonMessage and PongCarbonMessage. It will be >>>> better if you could rename those two classes to generalized name. >>>> >>>> Regards >>>> Senduran >>>> >>>> On Fri, Jan 27, 2017 at 2:47 PM, Kishanthan Thangarajah < >>>> kishant...@wso2.com> wrote: >>>> >>>>> Looks ok. >>>>> >>>>> Senduran/Shafreen, can we merge this PR? >>>>> >>>>> On Thu, Jan 26, 2017 at 7:27 PM, Irunika Weeraratne >>>>> wrote: >>>>> >>>>>> Hi, >>>>>> Fixed the issues mentioned. >>>>>> Please review and merge. >>>>>> >>>>>> Thanks, >>>>>> Irunika >>>>>> >>>>>> *Irunika Weeraratne* >>>>>> *Software Engineer | WSO2, Inc. <http://wso2.com/>* >>>>>> *Email : irun...@wso2.com * >>>>>> *LinkedIn : https://lk.linkedin.com/in/irunika >>>>>> <https://lk.linkedin.com/in/irunika>* >>>>>> *Mobile : +94712403314 <+94%2071%20240%203314>* >>>>>> *Lean . Enterprise . Middleware* >>>>>> >>>>>> >>>>>> On Thu, Jan 26, 2017 at 7:04 PM, Irunika Weeraratne >>>>> > wrote: >>>>>> >>>>>>> Noted. >>>>>>> >>>>>>> Thanks, >>>>>>> Irunika >>>>>>> >>>>>>> *Irunika Weeraratne* >>>>>>> *Software Engineer | WSO2, Inc. <http://wso2.com/>* >>>>>>> *Email : irun...@wso2.com * >>>>>>> *LinkedIn : https://lk.linkedin.com/in/irunika >>>>>>> <https://lk.linkedin.com/in/irunika>* >>>>>>> *Mobile : +94712403314 <+94%2071%20240%203314>* >>>>>>> *Lean . Enterprise . Middleware* >>>>>>> >>>>>>> >>>>>>> On Thu, Jan 26, 2017 at 4:34 PM, Kishanthan Thangarajah < >>>>>>> kishant...@wso2.com> wrote: >>>>>>> >>>>>>>> PR has some formatting issue to be fixed
Re: [Dev] [MSF4J] Can we provide HTTP handler args in Interceptor level?
Hi Azeez, We had a discussion regarding this. Following are the solutions we decided - Set object handler as a property in the Request instance (just like we are setting the HTTP method according to [1] <https://github.com/wso2/msf4j/pull/338>) With this change you can access the handler through the Request instance just like as shown below: request.getProperty("HANDLER") - Include method arguments in the Request instance. As for what we suggested in the previous discussion, *I have also tried is to build the Request inside the Interceptor and get the Java method and the args from the Request (which was suggested during the offline discussion)* With the pull request [1] <https://github.com/wso2/msf4j/pull/338> we are building the Request before the interceptors are executed. So this is handled. WDYT? [1] Interceptors pull request <https://github.com/wso2/msf4j/pull/338> On Thu, Mar 2, 2017 at 10:33 AM, Vidura Nanayakkara wrote: > Hi Malintha, > > As for the questions, you asked regarding the 1st approach I suggested: > > > * - Write a custom context provider of your own which will describe how > the injected value is generated by implementing a certain interface.In the > custom context provider, will we have access to the internal objects like > [1] so that we can use them to generate the custom context object?* > > As per my understanding using approach 1 (custom context providers) it > would be a no. As I mentioned in the previous response, by default we can > access the Request, Response, HttpStreamer, FormParamIterator and > MultivaluedMap instances using the @Context annotation. If you need access > to the MSF4J internal objects like [1] > <https://github.com/wso2/msf4j/blob/v2.1.1/core/src/main/java/org/wso2/msf4j/internal/MSF4JMessageProcessor.java#L129>, > we need to make it accessible by default using the @Context annotation. > > The purpose of the custom context provider is to help you inject custom > values by specifying the logic on how the value are generated (probably to > feed the arguments to your interceptors and the HTTP methods). > >- *Register the custom context provider to the MSF4J* >- *Inject the value using @Context annotation (Ex:- @Context(String >key) Object[] arguments)* > > *Will it be possible to access the injected values within Interceptors? > Since one of our requirement is to come up with an Interceptor to validate > ETags in a central place, we need to access them within the Interceptor.* > > Yes, this would be an enhancement to MSF4J (with or without custom context > provider implementation). > > However, it would be great if we can have a discussion regarding this. > > [1] HttpResourceModel MSF4J internal object > <https://github.com/wso2/msf4j/blob/v2.1.1/core/src/main/java/org/wso2/msf4j/internal/MSF4JMessageProcessor.java#L129> > > > On Wed, Mar 1, 2017 at 10:41 AM, Malintha Amarasinghe > wrote: > >> >> >> On Wed, Mar 1, 2017 at 9:19 AM, Thusitha Thilina Dayaratne < >> thusit...@wso2.com> wrote: >> >>> Hi Malintha, >>> >>> ATM if you try to access the request payload at the interceptor level, >>> you won't be able to access that again in the service level and it will >>> cause the particular thread to get wait. >>> Shall we have a quick discussion on that today? That will help to come >>> up with a solution for this. >>> >> Sure Thusitha. Let's have a discussion today. That would be great. >> >> Thanks! >> Malintha >> >>> >>> Thanks >>> Thusitha >>> >>> On Tue, Feb 28, 2017 at 10:29 PM, Malintha Amarasinghe < >>> malint...@wso2.com> wrote: >>> >>>> + NuwanD, Sanjeewa >>>> >>>> On Tue, Feb 28, 2017 at 10:28 PM, Malintha Amarasinghe < >>>> malint...@wso2.com> wrote: >>>> >>>>> Hi Vidura, >>>>> >>>>> I went through the links and the approaches you suggested and I have a >>>>> couple of questions. I have also tried is to build the Request inside the >>>>> Interceptor and get the Java method and the args from the Request (which >>>>> was suggested during the offline discussion). For that, I tried to get >>>>> this >>>>> block of code [1] (which builds the request) inside the Interceptor. And >>>>> that was successful, but I needed access to some of the internal objects >>>>> in >>>>> MSF4J request path. Ex: HttpResourceModel object [2]. They are not >>>>> currently available in Interceptor level, so I
Re: [Dev] [MSF4J] Can we provide HTTP handler args in Interceptor level?
Hi Malintha, As for the questions, you asked regarding the 1st approach I suggested: * - Write a custom context provider of your own which will describe how the injected value is generated by implementing a certain interface.In the custom context provider, will we have access to the internal objects like [1] so that we can use them to generate the custom context object?* As per my understanding using approach 1 (custom context providers) it would be a no. As I mentioned in the previous response, by default we can access the Request, Response, HttpStreamer, FormParamIterator and MultivaluedMap instances using the @Context annotation. If you need access to the MSF4J internal objects like [1] <https://github.com/wso2/msf4j/blob/v2.1.1/core/src/main/java/org/wso2/msf4j/internal/MSF4JMessageProcessor.java#L129>, we need to make it accessible by default using the @Context annotation. The purpose of the custom context provider is to help you inject custom values by specifying the logic on how the value are generated (probably to feed the arguments to your interceptors and the HTTP methods). - *Register the custom context provider to the MSF4J* - *Inject the value using @Context annotation (Ex:- @Context(String key) Object[] arguments)* *Will it be possible to access the injected values within Interceptors? Since one of our requirement is to come up with an Interceptor to validate ETags in a central place, we need to access them within the Interceptor.* Yes, this would be an enhancement to MSF4J (with or without custom context provider implementation). However, it would be great if we can have a discussion regarding this. [1] HttpResourceModel MSF4J internal object <https://github.com/wso2/msf4j/blob/v2.1.1/core/src/main/java/org/wso2/msf4j/internal/MSF4JMessageProcessor.java#L129> On Wed, Mar 1, 2017 at 10:41 AM, Malintha Amarasinghe wrote: > > > On Wed, Mar 1, 2017 at 9:19 AM, Thusitha Thilina Dayaratne < > thusit...@wso2.com> wrote: > >> Hi Malintha, >> >> ATM if you try to access the request payload at the interceptor level, >> you won't be able to access that again in the service level and it will >> cause the particular thread to get wait. >> Shall we have a quick discussion on that today? That will help to come up >> with a solution for this. >> > Sure Thusitha. Let's have a discussion today. That would be great. > > Thanks! > Malintha > >> >> Thanks >> Thusitha >> >> On Tue, Feb 28, 2017 at 10:29 PM, Malintha Amarasinghe < >> malint...@wso2.com> wrote: >> >>> + NuwanD, Sanjeewa >>> >>> On Tue, Feb 28, 2017 at 10:28 PM, Malintha Amarasinghe < >>> malint...@wso2.com> wrote: >>> >>>> Hi Vidura, >>>> >>>> I went through the links and the approaches you suggested and I have a >>>> couple of questions. I have also tried is to build the Request inside the >>>> Interceptor and get the Java method and the args from the Request (which >>>> was suggested during the offline discussion). For that, I tried to get this >>>> block of code [1] (which builds the request) inside the Interceptor. And >>>> that was successful, but I needed access to some of the internal objects in >>>> MSF4J request path. Ex: HttpResourceModel object [2]. They are not >>>> currently available in Interceptor level, so I had to modify ms4fj-core bit >>>> locally (just to check) to get them inside the Interceptor. >>>> >>>> Let's say we are following the approach 1. >>>> >>>>- *Write a custom context provider of your own which will describe >>>>how the injected value is generated by implementing a certain >>>> interface.* >>>> >>>> In the custom context provider, will we have access to the internal >>>> objects like [1] so that we can use them to generate the custom context >>>> object? >>>> >>>>- *Register the custom context provider to the MSF4J* >>>>- *Inject the value using @Context annotation (Ex:- @Context(String >>>>key) Object[] arguments)* >>>> >>>> Will it be possible to access the injected values within Interceptors? >>>> Since one of our requirement is to come up with an Interceptor to validate >>>> ETags in a central place, we need to access them within the Interceptor. >>>> >>>> [1] https://github.com/wso2/msf4j/blob/v2.1.1/core/src/main/ >>>> java/org/wso2/msf4j/internal/MSF4JMessageProcessor.java#L137-L144 >>>> [2] https://github.com/wso2/msf4j/blob/v2.1.1/core/src/main/java >>>
[Dev] Configuration Maven Plugin Repository
Hi, In relation to the discussions, we had in "Invitation: C5 Carbon Configuration @ Mon Feb 27, 2017 2pm - 3pm (IST) (WSO2 Engineering Group)", we came to the conclusion that "org.wso2.carbon.configuration" should be moved to a separate repository. However, we did not discuss into which repository should the maven configuration plugin (org.wso2.carbon.extensions.configuration.maven.plugin) should belong. I am assuming it should be moved to the same repository as "org.wso2.carbon.configuration". WDYT? Best Regards, *Vidura Nanayakkara* Email : vidu...@wso2.com Mobile : +94 (0) 717 919277 Web : http://wso2.com ___ Dev mailing list Dev@wso2.org http://wso2.org/cgi-bin/mailman/listinfo/dev
Re: [Dev] [MSF4J] Please Review and Merge the PR - MSF4J Interceptors
[Adding Waruna, Ashen] Hi Sanjeewa, As per the offline discussion, we had on the 21st of February, the following tasks have to be proceeded with before releasing MSF4J with the above enhancement. - MSF4J and carbon-transports depends on carbon-metrics. Therefore we need to have a carbon-metrics released in order to proceed with the MSF4J and carbon-transports releases. - ThusithaD is currently working on carbon-transports. However, this can be released only after carbon-metrics is released. - MSF4J needs to be released first with the carbon-metrics and carbon-transports. We will provide an ETA ASAP On Mon, Feb 27, 2017 at 7:18 PM, Sanjeewa Malalgoda wrote: > Hi Azeez, Thusitha, > Can we get MSF4J release with this fix? > > Thanks, > sanjeewa. > > On Thu, Feb 16, 2017 at 3:25 PM, Vidura Nanayakkara > wrote: > >> Hi all, >> >> Please review and merge the PR [1] >> <https://github.com/wso2/msf4j/pull/338>. The relevant GitHub issues are >> [2] <https://github.com/wso2/msf4j/issues/335> and [3] >> <https://github.com/wso2/msf4j/issues/336>. The relevant email >> discussion in the Architecture mail thread could be found at [4] >> <http://wso2-oxygen-tank.10903.n7.nabble.com/MSF4J-MSF4J-Filter-Configuration-td145277.html> >> . >> >> Please do clarify any issue with me if anything is not clear or feel free >> to ask for a meeting if required :) >> >> [1] https://github.com/wso2/msf4j/pull/338 >> <https://github.com/wso2/msf4j/pull/338> >> [2] https://github.com/wso2/msf4j/issues/335 >> <https://github.com/wso2/msf4j/issues/335> >> [3] https://github.com/wso2/msf4j/issues/336 >> <https://github.com/wso2/msf4j/issues/336> >> [4] http://wso2-oxygen-tank.10903.n7.nabble.com/MSF4J-MSF4J- >> Filter-Configuration-td145277.html >> <http://wso2-oxygen-tank.10903.n7.nabble.com/MSF4J-MSF4J-Filter-Configuration-td145277.html> >> >> Best Regards, >> >> *Vidura Nanayakkara* >> Software Engineer >> >> Email : vidu...@wso2.com >> Mobile : +94 (0) 717 919277 <071%20791%209277> >> Web : http://wso2.com >> Blog : https://medium.com/@viduran <http://wso2.com/> >> Twitter : http://twitter.com/viduranana >> LinkedIn : https://lk.linkedin.com/in/vidura-nanayakkara >> <http://wso2.com/> >> >> ___ >> Dev mailing list >> Dev@wso2.org >> http://wso2.org/cgi-bin/mailman/listinfo/dev >> >> > > > -- > > *Sanjeewa Malalgoda* > WSO2 Inc. > Mobile : +94713068779 <+94%2071%20306%208779> > > <http://sanjeewamalalgoda.blogspot.com/>blog :http://sanjeewamalalgoda. > blogspot.com/ <http://sanjeewamalalgoda.blogspot.com/> > > > -- Best Regards, *Vidura Nanayakkara* Software Engineer Email : vidu...@wso2.com Mobile : +94 (0) 717 919277 Web : http://wso2.com Blog : https://medium.com/@viduran <http://wso2.com/> Twitter : http://twitter.com/viduranana LinkedIn : https://lk.linkedin.com/in/vidura-nanayakkara <http://wso2.com/> ___ Dev mailing list Dev@wso2.org http://wso2.org/cgi-bin/mailman/listinfo/dev
Re: [Dev] [MSF4J] Can we provide HTTP handler args in Interceptor level?
[Adding Azeez] Hi, In relation to the offline discussion we had, it was clear that the above functionality is not sufficient for your requirement. As per the offline discussion, the suggested approach was to use custom contexts. [1] , [2] <https://www.blackpepper.co.uk/blog/custom-context-providers-for-cxf-with-the-context-annotation> describes an Apache CXF example of using custom contexts. Currently in MSF4J using @Context annotation we can inject the Request, Response, HttpStreamer, FormParamIterator and MultivaluedMap instances. However, these are not accessible via interceptors as per the current implementation. The approach we were using to inject values is by using the approach I have explained in the previous email. Therefore to solve the above problem, there are 2 solutions we can introduce to MSF4J. 1. *Introduce custom injection and lifecycle management [1] <https://jersey.java.net/documentation/latest/ioc.html>, [2] <https://www.blackpepper.co.uk/blog/custom-context-providers-for-cxf-with-the-context-annotation> to MSF4J.* Using this approach what you should basically do is: - Write a custom context provider of your own which will describe how the injected value is generated by implementing a certain interface. - Register the custom context provider to the MSF4J - Inject the value using @Context annotation (Ex:- @Context(String key) Object[] arguments) 1. *Have a Map map that could be injected using @Context annotation* Using this approach what you basically do is: - Add the arguments you need to inject using the @Context annotation using @SetContext(String key, Object value). This can be done inside interceptors or HTTP methods - Inject the value to using @Context(String key) WDYT? [1] Custom Injection and Lifecycle Management <https://jersey.java.net/documentation/latest/ioc.html> [2] Custom Context Providers for CXF with the Context Annotation <https://www.blackpepper.co.uk/blog/custom-context-providers-for-cxf-with-the-context-annotation> On Mon, Feb 27, 2017 at 9:59 AM, Vidura Nanayakkara wrote: > Hi Malintha, > > You can access the `Request` instance from the interceptors. You also can > access the same Request instance from the HTTP resource by injecting the > request to the HTTP method (`@Context Request request`). You also can set > any argument in the request using `request.setProperty(String key, Object > value)` method and retrieve the value using `request.getProperty(String > key)` method. Will this be sufficient for your requirement? > > > > On Mon, Feb 27, 2017 at 5:55 AM, Thusitha Thilina Dayaratne < > thusit...@wso2.com> wrote: > >> Hi Malintha, >> >> Thank you very much for the PR. We did some restructuring for the >> interceptors to cater product requirementsts[1]. Therefore we won't be able >> to directly merge this. But surely we will check what we can do with this. >> >> [1] - https://github.com/wso2/msf4j/pull/338 >> >> Thanks >> Thusitha >> >> On Sun, Feb 26, 2017 at 4:04 PM, Malintha Amarasinghe > > wrote: >> >>> Hi, >>> >>> Currently in MSF4J Interceptor level, we can get the HTTP handler method >>> which would be invoked by calling serviceMethodInfo.getMethod(). >>> >>> Additionally, It will be useful to have request parameters as well in >>> order to perform various types of request validations in Interceptor level >>> such as Bean validation and ETag validation. >>> >>> Tried to do a fix which adds a new field to ServiceMethodInfo class as >>> args[] [1]. But this required some API changes. >>> >>> Thanks! >>> >>> [1] https://github.com/wso2/msf4j/pull/356 >>> >>> -- >>> Malintha Amarasinghe >>> Software Engineer >>> *WSO2, Inc. - lean | enterprise | middleware* >>> http://wso2.com/ >>> >>> Mobile : +94 712383306P >>> >> >> >> >> -- >> Thusitha Dayaratne >> Software Engineer >> WSO2 Inc. - lean . enterprise . middleware | wso2.com >> >> Mobile +94712756809 <+94%2071%20275%206809> >> Blog alokayasoya.blogspot.com >> Abouthttp://about.me/thusithathilina >> <http://wso2.com/signature> >> >> >> _______ >> Dev mailing list >> Dev@wso2.org >> http://wso2.org/cgi-bin/mailman/listinfo/dev >> >> > > > -- > Best Regards, > > *Vidura Nanayakkara* > Software Engineer > > Email : vidu...@wso2.com > Mobile : +94 (0) 717 919277 <+94%2071%20791%209277> > Web : http://wso2.com > Blog : https://medium
Re: [Dev] [MSF4J] Can we provide HTTP handler args in Interceptor level?
Hi Malintha, You can access the `Request` instance from the interceptors. You also can access the same Request instance from the HTTP resource by injecting the request to the HTTP method (`@Context Request request`). You also can set any argument in the request using `request.setProperty(String key, Object value)` method and retrieve the value using `request.getProperty(String key)` method. Will this be sufficient for your requirement? On Mon, Feb 27, 2017 at 5:55 AM, Thusitha Thilina Dayaratne < thusit...@wso2.com> wrote: > Hi Malintha, > > Thank you very much for the PR. We did some restructuring for the > interceptors to cater product requirementsts[1]. Therefore we won't be able > to directly merge this. But surely we will check what we can do with this. > > [1] - https://github.com/wso2/msf4j/pull/338 > > Thanks > Thusitha > > On Sun, Feb 26, 2017 at 4:04 PM, Malintha Amarasinghe > wrote: > >> Hi, >> >> Currently in MSF4J Interceptor level, we can get the HTTP handler method >> which would be invoked by calling serviceMethodInfo.getMethod(). >> >> Additionally, It will be useful to have request parameters as well in >> order to perform various types of request validations in Interceptor level >> such as Bean validation and ETag validation. >> >> Tried to do a fix which adds a new field to ServiceMethodInfo class as >> args[] [1]. But this required some API changes. >> >> Thanks! >> >> [1] https://github.com/wso2/msf4j/pull/356 >> >> -- >> Malintha Amarasinghe >> Software Engineer >> *WSO2, Inc. - lean | enterprise | middleware* >> http://wso2.com/ >> >> Mobile : +94 712383306P >> > > > > -- > Thusitha Dayaratne > Software Engineer > WSO2 Inc. - lean . enterprise . middleware | wso2.com > > Mobile +94712756809 <+94%2071%20275%206809> > Blog alokayasoya.blogspot.com > Abouthttp://about.me/thusithathilina > <http://wso2.com/signature> > > > ___ > Dev mailing list > Dev@wso2.org > http://wso2.org/cgi-bin/mailman/listinfo/dev > > -- Best Regards, *Vidura Nanayakkara* Software Engineer Email : vidu...@wso2.com Mobile : +94 (0) 717 919277 Web : http://wso2.com Blog : https://medium.com/@viduran <http://wso2.com/> Twitter : http://twitter.com/viduranana LinkedIn : https://lk.linkedin.com/in/vidura-nanayakkara <http://wso2.com/> ___ Dev mailing list Dev@wso2.org http://wso2.org/cgi-bin/mailman/listinfo/dev
Re: [Dev] WSO2 Committers += Chanaka Cooray
Congratulations Chanaka :) On Fri, Feb 24, 2017 at 5:30 PM, Menaka Jayawardena wrote: > Congratz Chanaka! > > On Fri, Feb 24, 2017 at 3:37 PM, Nisala Nanayakkara > wrote: > >> Congratz Chanaka :D >> >> On Fri, Feb 24, 2017 at 3:36 PM, Niranjan Karunanandham < >> niran...@wso2.com> wrote: >> >>> Hi All, >>> >>> It's my pleasure to welcome Chanaka Cooray as a WSO2 Committer. >>> >>> Chanaka has been a valuable contributor to the Platform Team. In >>> recognition of his contribution, dedication and commitment he has been >>> voted as a WSO2 committer. >>> >>> Chanaka, welcome aboard and keep up the good work! >>> >>> Regards, >>> Nira >>> >>> -- >>> >>> >>> *Niranjan Karunanandham* >>> Associate Technical Lead - WSO2 Inc. >>> WSO2 Inc.: http://www.wso2.com >>> >>> >>> ___ >>> Dev mailing list >>> Dev@wso2.org >>> http://wso2.org/cgi-bin/mailman/listinfo/dev >>> >>> >> >> >> -- >> *Nisala Niroshana Nanayakkara,* >> Software Engineer >> Mobile:(+94)717600022 >> WSO2 Inc., http://wso2.com/ >> >> ___ >> Dev mailing list >> Dev@wso2.org >> http://wso2.org/cgi-bin/mailman/listinfo/dev >> >> > > > -- > *Menaka Jayawardena* > *Software Engineer - WSO2 Inc* > *Tel : 071 350 5470* > *LinkedIn: https://lk.linkedin.com/in/menakajayawardena > <https://lk.linkedin.com/in/menakajayawardena>* > *Blog: https://menakamadushanka.wordpress.com/ > <https://menakamadushanka.wordpress.com/>* > > > ___ > Dev mailing list > Dev@wso2.org > http://wso2.org/cgi-bin/mailman/listinfo/dev > > -- Best Regards, *Vidura Nanayakkara* Software Engineer Email : vidu...@wso2.com Mobile : +94 (0) 717 919277 Web : http://wso2.com Blog : https://medium.com/@viduran <http://wso2.com/> Twitter : http://twitter.com/viduranana LinkedIn : https://lk.linkedin.com/in/vidura-nanayakkara <http://wso2.com/> ___ Dev mailing list Dev@wso2.org http://wso2.org/cgi-bin/mailman/listinfo/dev
[Dev] [MSF4J] Please Review and Merge the PR - MSF4J Session Management
Hi all, Please review and merge the PR [1] <https://github.com/wso2/msf4j/pull/352>. The relevant GitHub issues could be found at [2] <https://github.com/wso2/msf4j/issues/349>. Please do clarify any issue with me if anything is not clear or feel free to ask for a meeting if required :) [1] https://github.com/wso2/msf4j/pull/352 <https://github.com/wso2/msf4j/pull/352> [2] https://github.com/wso2/msf4j/issues/349 <https://github.com/wso2/msf4j/issues/349> Best Regards, *Vidura Nanayakkara* Software Engineer Email : vidu...@wso2.com Mobile : +94 (0) 717 919277 Web : http://wso2.com Blog : https://medium.com/@viduran <http://wso2.com/> Twitter : http://twitter.com/viduranana LinkedIn : https://lk.linkedin.com/in/vidura-nanayakkara <http://wso2.com/> ___ Dev mailing list Dev@wso2.org http://wso2.org/cgi-bin/mailman/listinfo/dev
[Dev] [MSF4J] Please Review and Merge the PR - MSF4J Interceptors
Hi all, Please review and merge the PR [1] <https://github.com/wso2/msf4j/pull/338>. The relevant GitHub issues are [2] <https://github.com/wso2/msf4j/issues/335> and [3] <https://github.com/wso2/msf4j/issues/336>. The relevant email discussion in the Architecture mail thread could be found at [4] <http://wso2-oxygen-tank.10903.n7.nabble.com/MSF4J-MSF4J-Filter-Configuration-td145277.html> . Please do clarify any issue with me if anything is not clear or feel free to ask for a meeting if required :) [1] https://github.com/wso2/msf4j/pull/338 <https://github.com/wso2/msf4j/pull/338> [2] https://github.com/wso2/msf4j/issues/335 <https://github.com/wso2/msf4j/issues/335> [3] https://github.com/wso2/msf4j/issues/336 <https://github.com/wso2/msf4j/issues/336> [4] http://wso2-oxygen-tank.10903.n7.nabble.com/MSF4J-MSF4J-Filter-Configuration-td145277.html <http://wso2-oxygen-tank.10903.n7.nabble.com/MSF4J-MSF4J-Filter-Configuration-td145277.html> Best Regards, *Vidura Nanayakkara* Software Engineer Email : vidu...@wso2.com Mobile : +94 (0) 717 919277 Web : http://wso2.com Blog : https://medium.com/@viduran <http://wso2.com/> Twitter : http://twitter.com/viduranana LinkedIn : https://lk.linkedin.com/in/vidura-nanayakkara <http://wso2.com/> ___ Dev mailing list Dev@wso2.org http://wso2.org/cgi-bin/mailman/listinfo/dev