Re: [Dev] [AS] Polling Station Sample JS Code Patch for Google Chrome and Other Browsers

[Shashika Karunatilaka]

HI Rasika,

Please create public JIRA here [1] and attach your fix.

[1] https://wso2.org/jira/browse/WSAS

On Thu, Feb 12, 2015 at 5:27 PM, Rasika Perera  wrote:

> Hi all,
>
> WSO2 AS v5.2.1, Polling Station sample
>  does not work
> with Google Chrome and exceptional user agents. Because it is hard coded
> for IE, Gecko based(FF) and Opera. The documentation already has a
> recommendation for Firefox.
>
> [image: Inline image 1]
>
> Since, nowadays XMLSerializer() is supported by all `webkit` and `gecko`
> based browsers, I did a code patch for the `WSRequest.js` file.
>
> Now it is working for any user agent with `gecko-` or `web-kit` engines
> including Google Chrome and Safari.
>
> Please consider adding this file to the next release.
>
> NOTE: diff file and modified version of the file is attached.
>
> --
> With Regards,
>
> *Rasika Perera*
> Software Engineer
> M: +94 71 680 9060 E: rasi...@wso2.com
> LinkedIn: http://lk.linkedin.com/in/rasika90
>
> WSO2 Inc. www.wso2.com
> lean.enterprise.middleware
>
> ___
> Dev mailing list
> Dev@wso2.org
> http://wso2.org/cgi-bin/mailman/listinfo/dev
>
>


-- 
Shashika Prabath Karunatilaka,
Software Engineer,
WSO2, Inc: http://wso2.com/
mobile : +94 77 7487792
___
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev

Re: [Dev] [AS] Polling Station Sample JS Code Patch for Google Chrome and Other Browsers

[Supun Malinga]

Hi Rasika,

You can send a PR to product-as git repo.
https://github.com/wso2/product-as

thanks,

On Thu, Feb 12, 2015 at 5:37 PM, Shashika Karunatilaka 
wrote:

> HI Rasika,
>
> Please create public JIRA here [1] and attach your fix.
>
> [1] https://wso2.org/jira/browse/WSAS
>
> On Thu, Feb 12, 2015 at 5:27 PM, Rasika Perera  wrote:
>
>> Hi all,
>>
>> WSO2 AS v5.2.1, Polling Station sample
>>  does not work
>> with Google Chrome and exceptional user agents. Because it is hard coded
>> for IE, Gecko based(FF) and Opera. The documentation already has a
>> recommendation for Firefox.
>>
>> [image: Inline image 1]
>>
>> Since, nowadays XMLSerializer() is supported by all `webkit` and `gecko`
>> based browsers, I did a code patch for the `WSRequest.js` file.
>>
>> Now it is working for any user agent with `gecko-` or `web-kit` engines
>> including Google Chrome and Safari.
>>
>> Please consider adding this file to the next release.
>>
>> NOTE: diff file and modified version of the file is attached.
>>
>> --
>> With Regards,
>>
>> *Rasika Perera*
>> Software Engineer
>> M: +94 71 680 9060 E: rasi...@wso2.com
>> LinkedIn: http://lk.linkedin.com/in/rasika90
>>
>> WSO2 Inc. www.wso2.com
>> lean.enterprise.middleware
>>
>> ___
>> Dev mailing list
>> Dev@wso2.org
>> http://wso2.org/cgi-bin/mailman/listinfo/dev
>>
>>
>
>
> --
> Shashika Prabath Karunatilaka,
> Software Engineer,
> WSO2, Inc: http://wso2.com/
> mobile : +94 77 7487792
>



-- 
Supun Malinga,

Senior Software Engineer,
WSO2 Inc.
http://wso2.com
email: sup...@wso2.com 
mobile: +94 (0)71 56 91 321
___
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev

Re: [Dev] [AS] Polling Station Sample JS Code Patch for Google Chrome and Other Browsers

[Rasika Perera]

​Thank you Supun and Shashika for prompt replies. I created a JIRA ticket
[1] and sent a PR request to the product git repo[2].

[1] https://wso2.org/jira/browse/WSAS-1896
[2] https://github.com/wso2/product-as/pull/43

On Thu, Feb 12, 2015 at 5:40 PM, Supun Malinga  wrote:

> Hi Rasika,
>
> You can send a PR to product-as git repo.
> https://github.com/wso2/product-as
>
> thanks,
>
> On Thu, Feb 12, 2015 at 5:37 PM, Shashika Karunatilaka  > wrote:
>
>> HI Rasika,
>>
>> Please create public JIRA here [1] and attach your fix.
>>
>> [1] https://wso2.org/jira/browse/WSAS
>>
>> On Thu, Feb 12, 2015 at 5:27 PM, Rasika Perera  wrote:
>>
>>> Hi all,
>>>
>>> WSO2 AS v5.2.1, Polling Station sample
>>>  does not work
>>> with Google Chrome and exceptional user agents. Because it is hard coded
>>> for IE, Gecko based(FF) and Opera. The documentation already has a
>>> recommendation for Firefox.
>>>
>>> [image: Inline image 1]
>>>
>>> Since, nowadays XMLSerializer() is supported by all `webkit` and `gecko`
>>> based browsers, I did a code patch for the `WSRequest.js` file.
>>>
>>> Now it is working for any user agent with `gecko-` or `web-kit` engines
>>> including Google Chrome and Safari.
>>>
>>> Please consider adding this file to the next release.
>>>
>>> NOTE: diff file and modified version of the file is attached.
>>>
>>> --
>>> With Regards,
>>>
>>> *Rasika Perera*
>>> Software Engineer
>>> M: +94 71 680 9060 E: rasi...@wso2.com
>>> LinkedIn: http://lk.linkedin.com/in/rasika90
>>>
>>> WSO2 Inc. www.wso2.com
>>> lean.enterprise.middleware
>>>
>>> ___
>>> Dev mailing list
>>> Dev@wso2.org
>>> http://wso2.org/cgi-bin/mailman/listinfo/dev
>>>
>>>
>>
>>
>> --
>> Shashika Prabath Karunatilaka,
>> Software Engineer,
>> WSO2, Inc: http://wso2.com/
>> mobile : +94 77 7487792
>>
>
>
>
> --
> Supun Malinga,
>
> Senior Software Engineer,
> WSO2 Inc.
> http://wso2.com
> email: sup...@wso2.com 
> mobile: +94 (0)71 56 91 321
>



-- 
With Regards,

*Rasika Perera*
Software Engineer
M: +94 71 680 9060 E: rasi...@wso2.com
LinkedIn: http://lk.linkedin.com/in/rasika90

WSO2 Inc. www.wso2.com
lean.enterprise.middleware
___
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev