Hi Asanka,
Thanks for the response and its very clear now, then hopefully we can
modify same method to delete the Git repo for tenant. As you told there is
a problem with the variable naming and it should be tenant domain name.
Thanks
Godwin
On Sun, Sep 28, 2014 at 3:48 PM, Asanka Dissanayake asan...@wso2.com
wrote:
On Sun, Sep 28, 2014 at 9:36 AM, Godwin Amila Shrimal god...@wso2.com
wrote:
Hi
There is a method called *deleteTenantRepo* in
GITBlitBasedGITRepositoryProvider class in above carbon component. as per
the following line it concatenate */defApp *string literal with
tenantId to assign for the repo name. What does mean by *defApp. *I
checked the repo names created in git server
(*git.appfactory.private.wso2.com:8443
http://git.appfactory.private.wso2.com:8443*) and it is created with
tenant domain name and not with tenantId as well.
Any usage of this method ?
String defaultTenantRepo = tenantId + /defApp;
AFAIK , this method is not used now. So the reason is this,
in GitBlit, we can't create only a folder . for example if we need to
create a folder to contain repos for tenant foo, we just can't create
foo/ in the GitBlit. So earlier what we did is , we create a default
repository , during the tenant creation. So it creates a repo with name
*foo/defApp.git* for tenant foo, and then delete the* defApp.git*
repository*(this method was used for this*) . So the folder *foo/ *remains.
We implemented that for the sake of completion. But later we realized that
there is no point of creating a repo and deleting it right after. and that
could create some ambiguities later. So we omitted this behavior and
decided to create a repository for the tenant during the time of first
application creation.
and there is a confusion on the variable naming :(. Since this is String ,
I think this should be tenant domain.
hope this helps .
Thanks,
Asanka D
Thanks
Godwin
--
*Godwin Amila Shrimal*
Senior Software Engineer
WSO2 Inc.; http://wso2.com
lean.enterprise.middleware
mobile: *+94772264165*
linkedin: *http://lnkd.in/KUum6D http://lnkd.in/KUum6D*
twitter: https://twitter.com/godwinamila
___
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev
--
*Asanka DissanayakeSoftware Engineer*
*WSO2 Inc. - lean . enterprise . middleware | wso2.com http://wso2.com/*
*email: asan...@wso2.com ruch...@wso2.com, blog:
cyberwaadiya.blogspot.com
http://cyberwaadiya.blogspot.com, asankastechtalks.wordpress.com
http://asankastechtalks.wordpress.com mobile: +94 71 8373821*
--
*Godwin Amila Shrimal*
Senior Software Engineer
WSO2 Inc.; http://wso2.com
lean.enterprise.middleware
mobile: *+94772264165*
linkedin: *http://lnkd.in/KUum6D http://lnkd.in/KUum6D*
twitter: https://twitter.com/godwinamila
___
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev
