Re: [Dev] [IS] Review and Merge
HI Damith, It seems like in JDBCIdentityDataStore, load method we are not handling caching properly. It should be stored the UserIdentityClaimsDO object into cache once retrieved from DB. Please fix that as well. Thanks Isura. On Tue, May 5, 2015 at 11:25 PM, Damith Senanayake wrote: > Hi, > upon feedback from the team, I have updated the fix to use the realm > configuration to obtain userstore manager domain name; > > please find the fix for IDENTITY - 3235 at > https://github.com/wso2/carbon-identity/pull/250. > > Thanks. > > On Thu, Apr 30, 2015 at 4:13 PM, Damith Senanayake > wrote: > >> Please pardon the mistake. The pull request is as follows : >> https://github.com/wso2/carbon-identity/pull/250 >> >> On Thu, Apr 30, 2015 at 2:02 PM, Damith Senanayake >> wrote: >> >>> Hi, >>> >>> Fix for [1] available at [2] >>> [1] https://wso2.org/jira/browse/IDENTITY-3235 >>> [2]https://github.com/wso2/carbon-identity/pull/245 >>> >>> -- >>> *-Damith Senanayake-* >>> +94712205272 >>> >> >> >> >> -- >> *-Damith Senanayake-* >> +94712205272 >> > > > > -- > *-Damith Senanayake-* > +94712205272 > > ___ > Dev mailing list > Dev@wso2.org > http://wso2.org/cgi-bin/mailman/listinfo/dev > > -- Isura Dilhara Karunaratne Senior Software Engineer Mob +94 772 254 810 ___ Dev mailing list Dev@wso2.org http://wso2.org/cgi-bin/mailman/listinfo/dev
Re: [Dev] [IS] Review and Merge
Hi, upon feedback from the team, I have updated the fix to use the realm configuration to obtain userstore manager domain name; please find the fix for IDENTITY - 3235 at https://github.com/wso2/carbon-identity/pull/250. Thanks. On Thu, Apr 30, 2015 at 4:13 PM, Damith Senanayake wrote: > Please pardon the mistake. The pull request is as follows : > https://github.com/wso2/carbon-identity/pull/250 > > On Thu, Apr 30, 2015 at 2:02 PM, Damith Senanayake > wrote: > >> Hi, >> >> Fix for [1] available at [2] >> [1] https://wso2.org/jira/browse/IDENTITY-3235 >> [2]https://github.com/wso2/carbon-identity/pull/245 >> >> -- >> *-Damith Senanayake-* >> +94712205272 >> > > > > -- > *-Damith Senanayake-* > +94712205272 > -- *-Damith Senanayake-* +94712205272 ___ Dev mailing list Dev@wso2.org http://wso2.org/cgi-bin/mailman/listinfo/dev
Re: [Dev] [IS] Review and Merge
Please pardon the mistake. The pull request is as follows : https://github.com/wso2/carbon-identity/pull/250 On Thu, Apr 30, 2015 at 2:02 PM, Damith Senanayake wrote: > Hi, > > Fix for [1] available at [2] > [1] https://wso2.org/jira/browse/IDENTITY-3235 > [2]https://github.com/wso2/carbon-identity/pull/245 > > -- > *-Damith Senanayake-* > +94712205272 > -- *-Damith Senanayake-* +94712205272 ___ Dev mailing list Dev@wso2.org http://wso2.org/cgi-bin/mailman/listinfo/dev
[Dev] [IS] Review and Merge
Hi, Fix for [1] available at [2] [1] https://wso2.org/jira/browse/IDENTITY-3235 [2]https://github.com/wso2/carbon-identity/pull/245 -- *-Damith Senanayake-* +94712205272 ___ Dev mailing list Dev@wso2.org http://wso2.org/cgi-bin/mailman/listinfo/dev
