Re: [Dev] [Kernel] Why don't we support "##" on web app names?
Hi Kalpa,
Thanks for pointing it out.
AFAIU what we should do is searching for invalid # sequences such as "###".
Because a WAR names such as api#v1.0##1.war is accepted by our underlying
Tomcat and that approach is highly helpful when we want to indicate the
correct version number of a webapp without effecting the context.
WDYT?
On Fri, Jun 24, 2016 at 1:33 PM, Kalpa Welivitigoda wrote:
> Hi Thilini,
>
> I guess it is related to https://wso2.org/jira/browse/WSAS-1350
>
> On Fri, Jun 24, 2016 at 1:01 PM, Thilini Cooray wrote:
>
>> Hi team,
>>
>> Why have we specifically captured web app names with version separator
>> ("##") as not supported [1] ?
>>
>> AFAIU Apache Tomcat supports this property [2].
>> This property is useful when we want to provide the versioning on the WAR
>> name but do not need to change the web app context (Ex : patch release of a
>> webapp). Because changing web app context on every patch release of an API
>> will highly affect its clients.
>>
>> [1]
>> https://github.com/wso2/carbon-deployment/blob/4.6.x/components/webapp-mgt/org.wso2.carbon.webapp.mgt/src/main/java/org/wso2/carbon/webapp/mgt/AbstractWebappDeployer.java#L402
>> [2]
>> https://tomcat.apache.org/tomcat-7.0-doc/config/context.html#Defining_a_context
>>
>> Thanks.
>>
>> --
>> Best Regards,
>>
>> *Thilini Cooray*
>> Software Engineer
>> Mobile : +94 (0) 774 570 112 <%2B94%20%280%29%20773%20451194>
>> E-mail : thili...@wso2.com
>>
>> WSO2 Inc. www.wso2.com
>> lean.enterprise.middleware
>>
>
>
>
> --
> Best Regards,
>
> Kalpa Welivitigoda
> Senior Software Engineer, WSO2 Inc. http://wso2.com
> Email: kal...@wso2.com
> Mobile: +94776509215
>
--
Best Regards,
*Thilini Cooray*
Software Engineer
Mobile : +94 (0) 774 570 112 <%2B94%20%280%29%20773%20451194>
E-mail : thili...@wso2.com
WSO2 Inc. www.wso2.com
lean.enterprise.middleware
___
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev
Re: [Dev] [Kernel] Why don't we support "##" on web app names?
Hi Thilini,
I guess it is related to https://wso2.org/jira/browse/WSAS-1350
On Fri, Jun 24, 2016 at 1:01 PM, Thilini Cooray wrote:
> Hi team,
>
> Why have we specifically captured web app names with version separator
> ("##") as not supported [1] ?
>
> AFAIU Apache Tomcat supports this property [2].
> This property is useful when we want to provide the versioning on the WAR
> name but do not need to change the web app context (Ex : patch release of a
> webapp). Because changing web app context on every patch release of an API
> will highly affect its clients.
>
> [1]
> https://github.com/wso2/carbon-deployment/blob/4.6.x/components/webapp-mgt/org.wso2.carbon.webapp.mgt/src/main/java/org/wso2/carbon/webapp/mgt/AbstractWebappDeployer.java#L402
> [2]
> https://tomcat.apache.org/tomcat-7.0-doc/config/context.html#Defining_a_context
>
> Thanks.
>
> --
> Best Regards,
>
> *Thilini Cooray*
> Software Engineer
> Mobile : +94 (0) 774 570 112 <%2B94%20%280%29%20773%20451194>
> E-mail : thili...@wso2.com
>
> WSO2 Inc. www.wso2.com
> lean.enterprise.middleware
>
--
Best Regards,
Kalpa Welivitigoda
Senior Software Engineer, WSO2 Inc. http://wso2.com
Email: kal...@wso2.com
Mobile: +94776509215
___
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev
[Dev] [Kernel] Why don't we support "##" on web app names?
Hi team,
Why have we specifically captured web app names with version separator
("##") as not supported [1] ?
AFAIU Apache Tomcat supports this property [2].
This property is useful when we want to provide the versioning on the WAR
name but do not need to change the web app context (Ex : patch release of a
webapp). Because changing web app context on every patch release of an API
will highly affect its clients.
[1]
https://github.com/wso2/carbon-deployment/blob/4.6.x/components/webapp-mgt/org.wso2.carbon.webapp.mgt/src/main/java/org/wso2/carbon/webapp/mgt/AbstractWebappDeployer.java#L402
[2]
https://tomcat.apache.org/tomcat-7.0-doc/config/context.html#Defining_a_context
Thanks.
--
Best Regards,
*Thilini Cooray*
Software Engineer
Mobile : +94 (0) 774 570 112 <%2B94%20%280%29%20773%20451194>
E-mail : thili...@wso2.com
WSO2 Inc. www.wso2.com
lean.enterprise.middleware
___
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev
