Re: [Dev] [AS/Carbon] Please Review and Merge
Merged. On Tue, May 5, 2015 at 11:10 AM, Thusitha Thilina Dayaratne < thusit...@wso2.com> wrote: > Hi, > > Please review and merge the following PR[1] > [1] - https://github.com/wso2/carbon-deployment/pull/92 > > Thanks > Best Regards > > On Thu, Apr 30, 2015 at 5:27 PM, Thusitha Thilina Dayaratne < > thusit...@wso2.com> wrote: > >> Hi Kasun, >> >> Noted. >> I will look in to that as well. >> >> Thanks >> >> On Thu, Apr 30, 2015 at 5:24 PM, KasunG Gajasinghe >> wrote: >> >>> Hi Thusitha, >>> >>> We will need make the package, "org.wso2.carbon.tomcat.jndi", visible >>> to Tomcat CRE since we have extended the default JNDi implementation of >>> Tomcat. Likewise, we will need to see what other packages especially inside >>> org.wso2.carbon.tomcat we need make visible for the Tomcat CRE. >>> >>> On Thu, Apr 30, 2015 at 5:12 PM, Thusitha Thilina Dayaratne < >>> thusit...@wso2.com> wrote: >>> Hi, I've created the following JIRA issue[1] for this fix. [1] https://wso2.org/jira/browse/WSAS-1946 Thanks Best Regards On Thu, Apr 30, 2015 at 4:48 PM, Thusitha Thilina Dayaratne < thusit...@wso2.com> wrote: > Hi, > > Please review and merged the following PR[1] > [1] - https://github.com/wso2/product-as/pull/59 > > Thanks > Best Regards > > -- > Thusitha Dayaratne > Software Engineer > WSO2 Inc. - lean . enterprise . middleware | wso2.com > > Mobile +94712756809 > Blog alokayasoya.blogspot.com > Abouthttp://about.me/thusithathilina > > -- Thusitha Dayaratne Software Engineer WSO2 Inc. - lean . enterprise . middleware | wso2.com Mobile +94712756809 Blog alokayasoya.blogspot.com Abouthttp://about.me/thusithathilina >>> >>> >>> -- >>> >>> *Kasun Gajasinghe*Senior Software Engineer, WSO2 Inc. >>> email: kasung AT spamfree wso2.com >>> linked-in: http://lk.linkedin.com/in/gajasinghe >>> blog: http://kasunbg.org >>> >>> >>> >> >> >> >> -- >> Thusitha Dayaratne >> Software Engineer >> WSO2 Inc. - lean . enterprise . middleware | wso2.com >> >> Mobile +94712756809 >> Blog alokayasoya.blogspot.com >> Abouthttp://about.me/thusithathilina >> >> > > > -- > Thusitha Dayaratne > Software Engineer > WSO2 Inc. - lean . enterprise . middleware | wso2.com > > Mobile +94712756809 > Blog alokayasoya.blogspot.com > Abouthttp://about.me/thusithathilina > > -- *Kasun Gajasinghe*Senior Software Engineer, WSO2 Inc. email: kasung AT spamfree wso2.com linked-in: http://lk.linkedin.com/in/gajasinghe blog: http://kasunbg.org ___ Dev mailing list Dev@wso2.org http://wso2.org/cgi-bin/mailman/listinfo/dev
Re: [Dev] [AS/Carbon] Please Review and Merge
Hi, Please review and merge the following PR[1] [1] - https://github.com/wso2/carbon-deployment/pull/92 Thanks Best Regards On Thu, Apr 30, 2015 at 5:27 PM, Thusitha Thilina Dayaratne < thusit...@wso2.com> wrote: > Hi Kasun, > > Noted. > I will look in to that as well. > > Thanks > > On Thu, Apr 30, 2015 at 5:24 PM, KasunG Gajasinghe > wrote: > >> Hi Thusitha, >> >> We will need make the package, "org.wso2.carbon.tomcat.jndi", visible to >> Tomcat CRE since we have extended the default JNDi implementation of >> Tomcat. Likewise, we will need to see what other packages especially inside >> org.wso2.carbon.tomcat we need make visible for the Tomcat CRE. >> >> On Thu, Apr 30, 2015 at 5:12 PM, Thusitha Thilina Dayaratne < >> thusit...@wso2.com> wrote: >> >>> Hi, >>> >>> I've created the following JIRA issue[1] for this fix. >>> [1] https://wso2.org/jira/browse/WSAS-1946 >>> >>> Thanks >>> Best Regards >>> >>> On Thu, Apr 30, 2015 at 4:48 PM, Thusitha Thilina Dayaratne < >>> thusit...@wso2.com> wrote: >>> Hi, Please review and merged the following PR[1] [1] - https://github.com/wso2/product-as/pull/59 Thanks Best Regards -- Thusitha Dayaratne Software Engineer WSO2 Inc. - lean . enterprise . middleware | wso2.com Mobile +94712756809 Blog alokayasoya.blogspot.com Abouthttp://about.me/thusithathilina >>> >>> >>> -- >>> Thusitha Dayaratne >>> Software Engineer >>> WSO2 Inc. - lean . enterprise . middleware | wso2.com >>> >>> Mobile +94712756809 >>> Blog alokayasoya.blogspot.com >>> Abouthttp://about.me/thusithathilina >>> >>> >> >> >> -- >> >> *Kasun Gajasinghe*Senior Software Engineer, WSO2 Inc. >> email: kasung AT spamfree wso2.com >> linked-in: http://lk.linkedin.com/in/gajasinghe >> blog: http://kasunbg.org >> >> >> > > > > -- > Thusitha Dayaratne > Software Engineer > WSO2 Inc. - lean . enterprise . middleware | wso2.com > > Mobile +94712756809 > Blog alokayasoya.blogspot.com > Abouthttp://about.me/thusithathilina > > -- Thusitha Dayaratne Software Engineer WSO2 Inc. - lean . enterprise . middleware | wso2.com Mobile +94712756809 Blog alokayasoya.blogspot.com Abouthttp://about.me/thusithathilina ___ Dev mailing list Dev@wso2.org http://wso2.org/cgi-bin/mailman/listinfo/dev
Re: [Dev] [AS/Carbon] Please Review and Merge
Hi Kasun, Noted. I will look in to that as well. Thanks On Thu, Apr 30, 2015 at 5:24 PM, KasunG Gajasinghe wrote: > Hi Thusitha, > > We will need make the package, "org.wso2.carbon.tomcat.jndi", visible to > Tomcat CRE since we have extended the default JNDi implementation of > Tomcat. Likewise, we will need to see what other packages especially inside > org.wso2.carbon.tomcat we need make visible for the Tomcat CRE. > > On Thu, Apr 30, 2015 at 5:12 PM, Thusitha Thilina Dayaratne < > thusit...@wso2.com> wrote: > >> Hi, >> >> I've created the following JIRA issue[1] for this fix. >> [1] https://wso2.org/jira/browse/WSAS-1946 >> >> Thanks >> Best Regards >> >> On Thu, Apr 30, 2015 at 4:48 PM, Thusitha Thilina Dayaratne < >> thusit...@wso2.com> wrote: >> >>> Hi, >>> >>> Please review and merged the following PR[1] >>> [1] - https://github.com/wso2/product-as/pull/59 >>> >>> Thanks >>> Best Regards >>> >>> -- >>> Thusitha Dayaratne >>> Software Engineer >>> WSO2 Inc. - lean . enterprise . middleware | wso2.com >>> >>> Mobile +94712756809 >>> Blog alokayasoya.blogspot.com >>> Abouthttp://about.me/thusithathilina >>> >>> >> >> >> -- >> Thusitha Dayaratne >> Software Engineer >> WSO2 Inc. - lean . enterprise . middleware | wso2.com >> >> Mobile +94712756809 >> Blog alokayasoya.blogspot.com >> Abouthttp://about.me/thusithathilina >> >> > > > -- > > *Kasun Gajasinghe*Senior Software Engineer, WSO2 Inc. > email: kasung AT spamfree wso2.com > linked-in: http://lk.linkedin.com/in/gajasinghe > blog: http://kasunbg.org > > > -- Thusitha Dayaratne Software Engineer WSO2 Inc. - lean . enterprise . middleware | wso2.com Mobile +94712756809 Blog alokayasoya.blogspot.com Abouthttp://about.me/thusithathilina ___ Dev mailing list Dev@wso2.org http://wso2.org/cgi-bin/mailman/listinfo/dev
Re: [Dev] [AS/Carbon] Please Review and Merge
Hi Thusitha, We will need make the package, "org.wso2.carbon.tomcat.jndi", visible to Tomcat CRE since we have extended the default JNDi implementation of Tomcat. Likewise, we will need to see what other packages especially inside org.wso2.carbon.tomcat we need make visible for the Tomcat CRE. On Thu, Apr 30, 2015 at 5:12 PM, Thusitha Thilina Dayaratne < thusit...@wso2.com> wrote: > Hi, > > I've created the following JIRA issue[1] for this fix. > [1] https://wso2.org/jira/browse/WSAS-1946 > > Thanks > Best Regards > > On Thu, Apr 30, 2015 at 4:48 PM, Thusitha Thilina Dayaratne < > thusit...@wso2.com> wrote: > >> Hi, >> >> Please review and merged the following PR[1] >> [1] - https://github.com/wso2/product-as/pull/59 >> >> Thanks >> Best Regards >> >> -- >> Thusitha Dayaratne >> Software Engineer >> WSO2 Inc. - lean . enterprise . middleware | wso2.com >> >> Mobile +94712756809 >> Blog alokayasoya.blogspot.com >> Abouthttp://about.me/thusithathilina >> >> > > > -- > Thusitha Dayaratne > Software Engineer > WSO2 Inc. - lean . enterprise . middleware | wso2.com > > Mobile +94712756809 > Blog alokayasoya.blogspot.com > Abouthttp://about.me/thusithathilina > > -- *Kasun Gajasinghe*Senior Software Engineer, WSO2 Inc. email: kasung AT spamfree wso2.com linked-in: http://lk.linkedin.com/in/gajasinghe blog: http://kasunbg.org ___ Dev mailing list Dev@wso2.org http://wso2.org/cgi-bin/mailman/listinfo/dev
Re: [Dev] [AS/Carbon] Please Review and Merge
Hi, I've created the following JIRA issue[1] for this fix. [1] https://wso2.org/jira/browse/WSAS-1946 Thanks Best Regards On Thu, Apr 30, 2015 at 4:48 PM, Thusitha Thilina Dayaratne < thusit...@wso2.com> wrote: > Hi, > > Please review and merged the following PR[1] > [1] - https://github.com/wso2/product-as/pull/59 > > Thanks > Best Regards > > -- > Thusitha Dayaratne > Software Engineer > WSO2 Inc. - lean . enterprise . middleware | wso2.com > > Mobile +94712756809 > Blog alokayasoya.blogspot.com > Abouthttp://about.me/thusithathilina > > -- Thusitha Dayaratne Software Engineer WSO2 Inc. - lean . enterprise . middleware | wso2.com Mobile +94712756809 Blog alokayasoya.blogspot.com Abouthttp://about.me/thusithathilina ___ Dev mailing list Dev@wso2.org http://wso2.org/cgi-bin/mailman/listinfo/dev
Re: [Dev] [AS/Carbon] Please Review and Merge
Merged. On Thu, Apr 30, 2015 at 4:48 PM, Thusitha Thilina Dayaratne < thusit...@wso2.com> wrote: > Hi, > > Please review and merged the following PR[1] > [1] - https://github.com/wso2/product-as/pull/59 > > Thanks > Best Regards > > -- > Thusitha Dayaratne > Software Engineer > WSO2 Inc. - lean . enterprise . middleware | wso2.com > > Mobile +94712756809 > Blog alokayasoya.blogspot.com > Abouthttp://about.me/thusithathilina > > -- *Kasun Gajasinghe*Senior Software Engineer, WSO2 Inc. email: kasung AT spamfree wso2.com linked-in: http://lk.linkedin.com/in/gajasinghe blog: http://kasunbg.org ___ Dev mailing list Dev@wso2.org http://wso2.org/cgi-bin/mailman/listinfo/dev
[Dev] [AS/Carbon] Please Review and Merge
Hi, Please review and merged the following PR[1] [1] - https://github.com/wso2/product-as/pull/59 Thanks Best Regards -- Thusitha Dayaratne Software Engineer WSO2 Inc. - lean . enterprise . middleware | wso2.com Mobile +94712756809 Blog alokayasoya.blogspot.com Abouthttp://about.me/thusithathilina ___ Dev mailing list Dev@wso2.org http://wso2.org/cgi-bin/mailman/listinfo/dev