[Dev] Review and merge PR for reading conf folder path by carbon

2018-03-13 Thread Lasantha Dharmakeerthi
Hi all,

Spark Analytics Executor read the conf folder path as following way. Since
IoT server has changed the folder structure it is causing an issue.

carbonConfDir = carbonHome + File.separator + "repository" + File.separator
+ "conf";

Therefore I think the correct way is to get the path as following way.

carbonConfDir = CarbonUtils.getCarbonConfigDirPath();

I have fixed it in the following PR and please review and merge.
https://github.com/wso2/carbon-analytics/pull/1185

Thank You and Best Regards,
Lasantha.

-- 
*Dharmakeerthi Lasantha*
Software Engineer - WSO2

Email - lasant...@wso2.com
Mobile - +94774928852
Web - http://wso2.com/
http://wso2.com/signature
___
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev


Re: [Dev] Review and merge PR for reading conf folder path by carbon

2018-03-13 Thread SajithAR Ariyarathna
PR is merged. Fix will be available in carbon-analytics v1.3.22 version.

Thanks.

On Tue, Mar 13, 2018 at 7:56 PM, Lasantha Dharmakeerthi 
wrote:

> Hi all,
>
> Spark Analytics Executor read the conf folder path as following way. Since
> IoT server has changed the folder structure it is causing an issue.
>
> carbonConfDir = carbonHome + File.separator + "repository" +
> File.separator + "conf";
>
> Therefore I think the correct way is to get the path as following way.
>
> carbonConfDir = CarbonUtils.getCarbonConfigDirPath();
>
> I have fixed it in the following PR and please review and merge.
> https://github.com/wso2/carbon-analytics/pull/1185
>
> Thank You and Best Regards,
> Lasantha.
>
> --
> *Dharmakeerthi Lasantha*
> Software Engineer - WSO2
>
> Email - lasant...@wso2.com
> Mobile - +94774928852 <+94%2077%20492%208852>
> Web - http://wso2.com/
> http://wso2.com/signature
>



-- 
Sajith Janaprasad Ariyarathna
Senior Software Engineer; WSO2, Inc.;  http://wso2.com/

___
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev