Re: [Dev] Apply modified configuration files with feature installation

2016-03-29 Thread Lakshani Gamage
Thanks Niranjan.

On Tue, Mar 29, 2016 at 1:52 PM, Niranjan Karunanandham 
wrote:

> Hi Lakshani,
>
> This depends on how the feature is defined. AFAIK currently we do not have
> a way to update configuration files (which are owned by one feature) when a
> feature is being installed, i.e., say feature, F1, requires the
> configuration file, C1, to be modified, but the C1 is packed in feature,
> F2, that is already installed in the product.
>
> IMO defining where the configuration should reside, needs to be decided
> when creating a feature. It would be better if the feature contains its own
> configuration files and gets copied to required location as defined in the
> p2.inf of the feature. IMO for datasources, this can be handled by having a
> separate file to have the datasources, such as abc-datasources.xml and this
> file needs to be packed with the core feature for the product.
>
> Regards,
> Nira
>
> On Tue, Mar 29, 2016 at 1:36 PM, Charitha Goonetilleke  > wrote:
>
>> Hi All,
>>
>> AFAIK, only option we have is to make sure our custom configs are updated
>> accordingly when we are bumping version of particular component or feature
>> which provide that config. Anyway if we could write tool to execute during
>> the build time to generate relevant config files, with our customization by
>> referring the original one, above problem can be sorted out. WDYT?
>>
>>
>>
>> On Tue, Mar 29, 2016 at 12:16 PM, Lakshani Gamage 
>> wrote:
>>
>>> Hi all,
>>>
>>> Some products have done modifications to some configuration files (
>>> carbon.xml, registry xml etc). If the features of those product are
>>> installed from p2-repo, features are not working properly as customization 
>>> in
>>> config files are missing.
>>>
>>> For example, according to product app manager repo, there are some
>>> customized configuration files (master-datasource.xml, carbon.xml,
>>> registry.xml, sso-idp-cofig.xml etc).
>>>
>>> App manager has packed all customized files, as those files are copied
>>> to pack from bin.xml.
>>>
>>> But If we are going to install app manager features from p2-repo, those
>>> customization go missing. Therefore installed app manager features are
>>> not working properly.  However we can't  bundle those modified
>>> configuration files with app manager features as those configuration files
>>> are coming from several other features. ( carbon, registry, identity
>>> features etc)
>>>
>>> What is the best option to apply those modification with feature
>>>  installations from p2-repo? Thoughts?
>>>
>>> Thanks,
>>> Lakshani.
>>>
>>> --
>>> Lakshani Gamage
>>>
>>> *Software Engineer, WSO2*
>>>
>>> *Mobile : +94 71 5478184 <%2B94%20%280%29%20773%20451194>*
>>> *Blog : http://lakshanigamage.blogspot.com/
>>> *
>>>
>>> ___
>>> Dev mailing list
>>> Dev@wso2.org
>>> http://wso2.org/cgi-bin/mailman/listinfo/dev
>>>
>>>
>>
>>
>> --
>> *Charitha Goonetilleke*
>> Software Engineer
>> WSO2 Inc.; http://wso2.com
>> lean.enterprise.middleware
>>
>> mobile: +94 77 751 3669 <%2B94777513669>
>> Twitter:@CharithaWs , fb: charithag
>> , linkedin: charithag
>> 
>>
>> ___
>> Dev mailing list
>> Dev@wso2.org
>> http://wso2.org/cgi-bin/mailman/listinfo/dev
>>
>>
>
>
> --
>
> *Niranjan Karunanandham*
> Senior Software Engineer - WSO2 Inc.
> WSO2 Inc.: http://www.wso2.com
>



-- 
Lakshani Gamage

*Software Engineer, WSO2*

*Mobile : +94 71 5478184 <%2B94%20%280%29%20773%20451194>*
*Blog : http://lakshanigamage.blogspot.com/
*
___
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev


Re: [Dev] Apply modified configuration files with feature installation

2016-03-29 Thread Niranjan Karunanandham
Hi Lakshani,

This depends on how the feature is defined. AFAIK currently we do not have
a way to update configuration files (which are owned by one feature) when a
feature is being installed, i.e., say feature, F1, requires the
configuration file, C1, to be modified, but the C1 is packed in feature,
F2, that is already installed in the product.

IMO defining where the configuration should reside, needs to be decided
when creating a feature. It would be better if the feature contains its own
configuration files and gets copied to required location as defined in the
p2.inf of the feature. IMO for datasources, this can be handled by having a
separate file to have the datasources, such as abc-datasources.xml and this
file needs to be packed with the core feature for the product.

Regards,
Nira

On Tue, Mar 29, 2016 at 1:36 PM, Charitha Goonetilleke 
wrote:

> Hi All,
>
> AFAIK, only option we have is to make sure our custom configs are updated
> accordingly when we are bumping version of particular component or feature
> which provide that config. Anyway if we could write tool to execute during
> the build time to generate relevant config files, with our customization by
> referring the original one, above problem can be sorted out. WDYT?
>
>
>
> On Tue, Mar 29, 2016 at 12:16 PM, Lakshani Gamage 
> wrote:
>
>> Hi all,
>>
>> Some products have done modifications to some configuration files (
>> carbon.xml, registry xml etc). If the features of those product are
>> installed from p2-repo, features are not working properly as customization in
>> config files are missing.
>>
>> For example, according to product app manager repo, there are some
>> customized configuration files (master-datasource.xml, carbon.xml,
>> registry.xml, sso-idp-cofig.xml etc).
>>
>> App manager has packed all customized files, as those files are copied to
>> pack from bin.xml.
>>
>> But If we are going to install app manager features from p2-repo, those
>> customization go missing. Therefore installed app manager features are
>> not working properly.  However we can't  bundle those modified
>> configuration files with app manager features as those configuration files
>> are coming from several other features. ( carbon, registry, identity
>> features etc)
>>
>> What is the best option to apply those modification with feature
>>  installations from p2-repo? Thoughts?
>>
>> Thanks,
>> Lakshani.
>>
>> --
>> Lakshani Gamage
>>
>> *Software Engineer, WSO2*
>>
>> *Mobile : +94 71 5478184 <%2B94%20%280%29%20773%20451194>*
>> *Blog : http://lakshanigamage.blogspot.com/
>> *
>>
>> ___
>> Dev mailing list
>> Dev@wso2.org
>> http://wso2.org/cgi-bin/mailman/listinfo/dev
>>
>>
>
>
> --
> *Charitha Goonetilleke*
> Software Engineer
> WSO2 Inc.; http://wso2.com
> lean.enterprise.middleware
>
> mobile: +94 77 751 3669 <%2B94777513669>
> Twitter:@CharithaWs , fb: charithag
> , linkedin: charithag
> 
>
> ___
> Dev mailing list
> Dev@wso2.org
> http://wso2.org/cgi-bin/mailman/listinfo/dev
>
>


-- 

*Niranjan Karunanandham*
Senior Software Engineer - WSO2 Inc.
WSO2 Inc.: http://www.wso2.com
___
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev


Re: [Dev] Apply modified configuration files with feature installation

2016-03-29 Thread Charitha Goonetilleke
Hi All,

AFAIK, only option we have is to make sure our custom configs are updated
accordingly when we are bumping version of particular component or feature
which provide that config. Anyway if we could write tool to execute during
the build time to generate relevant config files, with our customization by
referring the original one, above problem can be sorted out. WDYT?



On Tue, Mar 29, 2016 at 12:16 PM, Lakshani Gamage  wrote:

> Hi all,
>
> Some products have done modifications to some configuration files (
> carbon.xml, registry xml etc). If the features of those product are
> installed from p2-repo, features are not working properly as customization in
> config files are missing.
>
> For example, according to product app manager repo, there are some
> customized configuration files (master-datasource.xml, carbon.xml,
> registry.xml, sso-idp-cofig.xml etc).
>
> App manager has packed all customized files, as those files are copied to
> pack from bin.xml.
>
> But If we are going to install app manager features from p2-repo, those
> customization go missing. Therefore installed app manager features are
> not working properly.  However we can't  bundle those modified
> configuration files with app manager features as those configuration files
> are coming from several other features. ( carbon, registry, identity
> features etc)
>
> What is the best option to apply those modification with feature
>  installations from p2-repo? Thoughts?
>
> Thanks,
> Lakshani.
>
> --
> Lakshani Gamage
>
> *Software Engineer, WSO2*
>
> *Mobile : +94 71 5478184 <%2B94%20%280%29%20773%20451194>*
> *Blog : http://lakshanigamage.blogspot.com/
> *
>
> ___
> Dev mailing list
> Dev@wso2.org
> http://wso2.org/cgi-bin/mailman/listinfo/dev
>
>


-- 
*Charitha Goonetilleke*
Software Engineer
WSO2 Inc.; http://wso2.com
lean.enterprise.middleware

mobile: +94 77 751 3669 <%2B94777513669>
Twitter:@CharithaWs , fb: charithag
, linkedin: charithag

___
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev


[Dev] Apply modified configuration files with feature installation

2016-03-29 Thread Lakshani Gamage
Hi all,

Some products have done modifications to some configuration files (
carbon.xml, registry xml etc). If the features of those product are
installed from p2-repo, features are not working properly as customization in
config files are missing.

For example, according to product app manager repo, there are some
customized configuration files (master-datasource.xml, carbon.xml,
registry.xml, sso-idp-cofig.xml etc).

App manager has packed all customized files, as those files are copied to
pack from bin.xml.

But If we are going to install app manager features from p2-repo, those
customization go missing. Therefore installed app manager features are not
working properly.  However we can't  bundle those modified configuration
files with app manager features as those configuration files are coming
from several other features. ( carbon, registry, identity features etc)

What is the best option to apply those modification with feature
 installations from p2-repo? Thoughts?

Thanks,
Lakshani.

-- 
Lakshani Gamage

*Software Engineer, WSO2*

*Mobile : +94 71 5478184 <%2B94%20%280%29%20773%20451194>*
*Blog : http://lakshanigamage.blogspot.com/
*
___
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev