Re: [Dev] Disabling JNDI Binding in Carbon Datsources SPI On Demand

2018-02-14 Thread Ruwan Abeykoon
Hi Jayanga,
+1. This is something we need to seamlessly integrate offline tools, which
uses the same Datasource XML.

I propose removing singleton on DatasourceManager, and pass a Properties to
the constructor.

Cheers,
Ruwan

On Wed, Feb 14, 2018 at 2:50 PM, Jayanga Kaushalya 
wrote:

> Hi all,
>
> Carbon Datasources [1] currently do not support JNDI binding in non-osgi
> mode. But it'll try to bind JNDI if there is a JNDI tag presents in the
> datasources.xml. But if we remove or comment the JNDI tags, it'll ignore
> the JNDI bindings as continue with the data source name. It is better if we
> can disable the JNDI binding explicitly by providing a external
> configuration even though JNDI tags are present in the datasources.xml.
> WDYT ?
>
> [1] https://github.com/wso2/carbon-datasources
>
> Thanks!
>
> *Jayanga Kaushalya*
> Senior Software Engineer
> Mobile: +94777860160 <+94%2077%20786%200160>
> WSO2 Inc. | http://wso2.com
> lean.enterprise.middleware
>
>
>
___
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev


[Dev] Disabling JNDI Binding in Carbon Datsources SPI On Demand

2018-02-14 Thread Jayanga Kaushalya
Hi all,

Carbon Datasources [1] currently do not support JNDI binding in non-osgi
mode. But it'll try to bind JNDI if there is a JNDI tag presents in the
datasources.xml. But if we remove or comment the JNDI tags, it'll ignore
the JNDI bindings as continue with the data source name. It is better if we
can disable the JNDI binding explicitly by providing a external
configuration even though JNDI tags are present in the datasources.xml.
WDYT ?

[1] https://github.com/wso2/carbon-datasources

Thanks!

*Jayanga Kaushalya*
Senior Software Engineer
Mobile: +94777860160
WSO2 Inc. | http://wso2.com
lean.enterprise.middleware
___
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev