Re: [Dev] Include carbon.yml and other config files in Carbon Core feature

[Niranjan Karunanandham]

Hi all,

I had a offline discussion with Sameera and KasunG with regard to this.
Please see the comments below based on the discussion:

On Mon, Apr 18, 2016 at 11:55 AM, Niranjan Karunanandham 
wrote:

> Hi all,
>
> Below is the current C5 source code structure:
>
> | -- archetypes
> | -- base
> | -- core
> | -- distribution (contains the conf files which are copied to the
> distribution via the bin.xml)
> | -- features
>
> | -- org.wso2.carbon.core.runtime.feature
> | -- org.wso2.carbon.core.server.feature
>
> | -- launcher
> | -- parent (parent pom)
> | -- tests
> | -- tools (Bundle Generator)
>
>
> Any particular reason as to why we have separate folder for each component
> such as launcher, tools, core and base? Can we move these to a folder
> called component since these are packed with the kernel and have the source
> code structure as below:
>
> | -- archetypes
> | -- components
>
> | -- base
> | -- core
> | -- launcher
> | -- tools (Bundle Generator)
>
> | -- distribution (contains the conf files which are copied to the
> distribution via the bin.xml)
> | -- features
>
> | -- org.wso2.carbon.core.runtime.feature
> | -- org.wso2.carbon.core.server.feature
>
> | -- parent (parent pom)
> | -- tests
>
> It was suggested to leave this as it is since changing it will not have
any impact.


> In-addition shall we bundle these components with a feature (either new
> say launcher feature or existing) and have its corresponding configuration
> files (including scripts like carbon.sh, if present) packed in the feature.
> In this case, we will not need to copy these config files via the bin.xml.
> In addition to this, other products will obtain these files when they
> install the feature without having to keep copy of this file in their
> distribution source code.
>
It was suggested to rename the org.wso2.carbon.core.server.feature to
org.wso2.carbon.kernel.feature and it will contain all the carbon kernel
features. The org.wso2.carbon.runtime.feature (instead of
org.wso2.carbon.core.runtime.feature) will contain all the runtime bundles
such as org.eclipse.equinox.simpleconfigurator, etc...

It was suggested that all the files in the distribution folder which are
packed using the bin.xml (assembly plugin), should be packed with
org.wso2.carbon.kernel.feature and when this feature is installed then it
will copy all those files to the location specified in the feature's p2.inf.


>
> WDYT?
>
> Regards,
> Nira
>
>
> On Mon, Apr 11, 2016 at 9:57 AM, Niranjan Karunanandham  > wrote:
>
>> Hi all,
>>
>> i have created a JIRA [1] for this. Along with the conf folder, shall we
>> include* bin folder* (in the distribution/carbon-home) as well into
>> org.wso2.carbon.core.server.feature? WDYT?
>>
>> [1] - https://wso2.org/jira/browse/CARBON-15851
>>
>> Regards,
>> Nira
>>
>> On Tue, Apr 5, 2016 at 3:45 PM, Kishanthan Thangarajah <
>> kishant...@wso2.com> wrote:
>>
>>>
>>>
>>> On Tue, Apr 5, 2016 at 3:32 PM, Niranjan Karunanandham <
>>> niran...@wso2.com> wrote:
>>>
 Hi Kishanthan,

 On Tue, Apr 5, 2016 at 3:23 PM, Kishanthan Thangarajah <
 kishant...@wso2.com> wrote:

> +1
>
> Also by default, we need to have place holders for name, id and
> version properties rather than having hard coded values. The product team
> can then put their relevant values at build time. Let's add this also 
> along
> with this change.
>
 By default shall we have the above values as empty in the carbon.yml.
 If it is not defined pick it up from System properties (using the place
 holder carbon.name, carbon.id and carbon.version for name, id and
 version respectively). If both are not define then get the values from a
 Constant. WDYT?

>>>
>>> IMO, let's have it like this.
>>>
>>> id: ${server.key}
>>> name: ${server.name}
>>> version: ${server.version}
>>>
>>> If no value is set for this under system property or env property, we
>>> should use the default values which comes from the configuration bean. The
>>> product team can use their own values when building a product.
>>>
>>>

>
>
> On Tue, Apr 5, 2016 at 3:14 PM, Aruna Karunarathna 
> wrote:
>
>> On Fri, Apr 1, 2016 at 2:31 PM, Niranjan Karunanandham <
>> niran...@wso2.com> wrote:
>>
>>> Hi Devs,
>>>
>>> In Carbon 5, the carbon.yml, log4j2.xml and etc., are in the
>>> distribution folder and copied to the distribution pack via bin.xml. Why
>>> don't we add these configuration files to Carbon Server Feature
>>> (org.wso2.carbon.core.server.feature) which are copied to the packed 
>>> when
>>> the feature is installed. WDYT?
>>>
>>> +1. we should bring the configurations also when we install the core
>> feature.
>>
>> Regards,
>>> Nira
>>>
>>> --
>>>
>>> *Niranjan Karunanandham*
>>> Senior Software Engineer - WSO2 Inc.
>>> WSO2 Inc.: http://www.wso2.com
>>>
>>> 

Re: [Dev] Include carbon.yml and other config files in Carbon Core feature

[Niranjan Karunanandham]

Hi all,

Below is the current C5 source code structure:

| -- archetypes
| -- base
| -- core
| -- distribution (contains the conf files which are copied to the
distribution via the bin.xml)
| -- features

| -- org.wso2.carbon.core.runtime.feature
| -- org.wso2.carbon.core.server.feature

| -- launcher
| -- parent (parent pom)
| -- tests
| -- tools (Bundle Generator)


Any particular reason as to why we have separate folder for each component
such as launcher, tools, core and base? Can we move these to a folder
called component since these are packed with the kernel and have the source
code structure as below:

| -- archetypes
| -- components

| -- base
| -- core
| -- launcher
| -- tools (Bundle Generator)

| -- distribution (contains the conf files which are copied to the
distribution via the bin.xml)
| -- features

| -- org.wso2.carbon.core.runtime.feature
| -- org.wso2.carbon.core.server.feature

| -- parent (parent pom)
| -- tests


In-addition shall we bundle these components with a feature (either new say
launcher feature or existing) and have its corresponding configuration
files (including scripts like carbon.sh, if present) packed in the feature.
In this case, we will not need to copy these config files via the bin.xml.
In addition to this, other products will obtain these files when they
install the feature without having to keep copy of this file in their
distribution source code.

WDYT?

Regards,
Nira


On Mon, Apr 11, 2016 at 9:57 AM, Niranjan Karunanandham 
wrote:

> Hi all,
>
> i have created a JIRA [1] for this. Along with the conf folder, shall we
> include* bin folder* (in the distribution/carbon-home) as well into
> org.wso2.carbon.core.server.feature? WDYT?
>
> [1] - https://wso2.org/jira/browse/CARBON-15851
>
> Regards,
> Nira
>
> On Tue, Apr 5, 2016 at 3:45 PM, Kishanthan Thangarajah <
> kishant...@wso2.com> wrote:
>
>>
>>
>> On Tue, Apr 5, 2016 at 3:32 PM, Niranjan Karunanandham > > wrote:
>>
>>> Hi Kishanthan,
>>>
>>> On Tue, Apr 5, 2016 at 3:23 PM, Kishanthan Thangarajah <
>>> kishant...@wso2.com> wrote:
>>>
 +1

 Also by default, we need to have place holders for name, id and version
 properties rather than having hard coded values. The product team can then
 put their relevant values at build time. Let's add this also along with
 this change.

>>> By default shall we have the above values as empty in the carbon.yml. If
>>> it is not defined pick it up from System properties (using the place holder
>>> carbon.name, carbon.id and carbon.version for name, id and version
>>> respectively). If both are not define then get the values from a Constant.
>>> WDYT?
>>>
>>
>> IMO, let's have it like this.
>>
>> id: ${server.key}
>> name: ${server.name}
>> version: ${server.version}
>>
>> If no value is set for this under system property or env property, we
>> should use the default values which comes from the configuration bean. The
>> product team can use their own values when building a product.
>>
>>
>>>


 On Tue, Apr 5, 2016 at 3:14 PM, Aruna Karunarathna 
 wrote:

> On Fri, Apr 1, 2016 at 2:31 PM, Niranjan Karunanandham <
> niran...@wso2.com> wrote:
>
>> Hi Devs,
>>
>> In Carbon 5, the carbon.yml, log4j2.xml and etc., are in the
>> distribution folder and copied to the distribution pack via bin.xml. Why
>> don't we add these configuration files to Carbon Server Feature
>> (org.wso2.carbon.core.server.feature) which are copied to the packed when
>> the feature is installed. WDYT?
>>
>> +1. we should bring the configurations also when we install the core
> feature.
>
> Regards,
>> Nira
>>
>> --
>>
>> *Niranjan Karunanandham*
>> Senior Software Engineer - WSO2 Inc.
>> WSO2 Inc.: http://www.wso2.com
>>
>> ___
>> Dev mailing list
>> Dev@wso2.org
>> http://wso2.org/cgi-bin/mailman/listinfo/dev
>>
>>
>
>
> --
>
> *Aruna Sujith Karunarathna *
> WSO2, Inc | lean. enterprise. middleware.
> #20, Palm Grove, Colombo 03, Sri Lanka
> Mobile: +94 71 9040362 | Work: +94 112145345
> Email: ar...@wso2.com | Web: www.wso2.com
>
>



 --
 *Kishanthan Thangarajah*
 Associate Technical Lead,
 Platform Technologies Team,
 WSO2, Inc.
 lean.enterprise.middleware

 Mobile - +94773426635
 Blog - *http://kishanthan.wordpress.com
 *
 Twitter - *http://twitter.com/kishanthan
 *

>>>
>>>
>>> Regards,
>>> Nira
>>>
>>> --
>>>
>>> *Niranjan Karunanandham*
>>> Senior Software Engineer - WSO2 Inc.
>>> WSO2 Inc.: http://www.wso2.com
>>>
>>
>>
>>
>> --
>> *Kishanthan Thangarajah*
>> Associate Technical Lead,
>> Platform Technologies Team,
>> WSO2, Inc.
>> lean.enterprise.middleware
>>
>> Mobile - +94773426635
>> Blog - *http://kishanthan.wordpress.com

Re: [Dev] Include carbon.yml and other config files in Carbon Core feature

[Niranjan Karunanandham]

Hi all,

i have created a JIRA [1] for this. Along with the conf folder, shall we
include* bin folder* (in the distribution/carbon-home) as well into
org.wso2.carbon.core.server.feature? WDYT?

[1] - https://wso2.org/jira/browse/CARBON-15851

Regards,
Nira

On Tue, Apr 5, 2016 at 3:45 PM, Kishanthan Thangarajah 
wrote:

>
>
> On Tue, Apr 5, 2016 at 3:32 PM, Niranjan Karunanandham 
> wrote:
>
>> Hi Kishanthan,
>>
>> On Tue, Apr 5, 2016 at 3:23 PM, Kishanthan Thangarajah <
>> kishant...@wso2.com> wrote:
>>
>>> +1
>>>
>>> Also by default, we need to have place holders for name, id and version
>>> properties rather than having hard coded values. The product team can then
>>> put their relevant values at build time. Let's add this also along with
>>> this change.
>>>
>> By default shall we have the above values as empty in the carbon.yml. If
>> it is not defined pick it up from System properties (using the place holder
>> carbon.name, carbon.id and carbon.version for name, id and version
>> respectively). If both are not define then get the values from a Constant.
>> WDYT?
>>
>
> IMO, let's have it like this.
>
> id: ${server.key}
> name: ${server.name}
> version: ${server.version}
>
> If no value is set for this under system property or env property, we
> should use the default values which comes from the configuration bean. The
> product team can use their own values when building a product.
>
>
>>
>>>
>>>
>>> On Tue, Apr 5, 2016 at 3:14 PM, Aruna Karunarathna 
>>> wrote:
>>>
 On Fri, Apr 1, 2016 at 2:31 PM, Niranjan Karunanandham <
 niran...@wso2.com> wrote:

> Hi Devs,
>
> In Carbon 5, the carbon.yml, log4j2.xml and etc., are in the
> distribution folder and copied to the distribution pack via bin.xml. Why
> don't we add these configuration files to Carbon Server Feature
> (org.wso2.carbon.core.server.feature) which are copied to the packed when
> the feature is installed. WDYT?
>
> +1. we should bring the configurations also when we install the core
 feature.

 Regards,
> Nira
>
> --
>
> *Niranjan Karunanandham*
> Senior Software Engineer - WSO2 Inc.
> WSO2 Inc.: http://www.wso2.com
>
> ___
> Dev mailing list
> Dev@wso2.org
> http://wso2.org/cgi-bin/mailman/listinfo/dev
>
>


 --

 *Aruna Sujith Karunarathna *
 WSO2, Inc | lean. enterprise. middleware.
 #20, Palm Grove, Colombo 03, Sri Lanka
 Mobile: +94 71 9040362 | Work: +94 112145345
 Email: ar...@wso2.com | Web: www.wso2.com


>>>
>>>
>>>
>>> --
>>> *Kishanthan Thangarajah*
>>> Associate Technical Lead,
>>> Platform Technologies Team,
>>> WSO2, Inc.
>>> lean.enterprise.middleware
>>>
>>> Mobile - +94773426635
>>> Blog - *http://kishanthan.wordpress.com
>>> *
>>> Twitter - *http://twitter.com/kishanthan
>>> *
>>>
>>
>>
>> Regards,
>> Nira
>>
>> --
>>
>> *Niranjan Karunanandham*
>> Senior Software Engineer - WSO2 Inc.
>> WSO2 Inc.: http://www.wso2.com
>>
>
>
>
> --
> *Kishanthan Thangarajah*
> Associate Technical Lead,
> Platform Technologies Team,
> WSO2, Inc.
> lean.enterprise.middleware
>
> Mobile - +94773426635
> Blog - *http://kishanthan.wordpress.com *
> Twitter - *http://twitter.com/kishanthan *
>



-- 

*Niranjan Karunanandham*
Senior Software Engineer - WSO2 Inc.
WSO2 Inc.: http://www.wso2.com
___
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev

Re: [Dev] Include carbon.yml and other config files in Carbon Core feature

[Kishanthan Thangarajah]

On Tue, Apr 5, 2016 at 3:32 PM, Niranjan Karunanandham 
wrote:

> Hi Kishanthan,
>
> On Tue, Apr 5, 2016 at 3:23 PM, Kishanthan Thangarajah <
> kishant...@wso2.com> wrote:
>
>> +1
>>
>> Also by default, we need to have place holders for name, id and version
>> properties rather than having hard coded values. The product team can then
>> put their relevant values at build time. Let's add this also along with
>> this change.
>>
> By default shall we have the above values as empty in the carbon.yml. If
> it is not defined pick it up from System properties (using the place holder
> carbon.name, carbon.id and carbon.version for name, id and version
> respectively). If both are not define then get the values from a Constant.
> WDYT?
>

IMO, let's have it like this.

id: ${server.key}
name: ${server.name}
version: ${server.version}

If no value is set for this under system property or env property, we
should use the default values which comes from the configuration bean. The
product team can use their own values when building a product.


>
>>
>>
>> On Tue, Apr 5, 2016 at 3:14 PM, Aruna Karunarathna 
>> wrote:
>>
>>> On Fri, Apr 1, 2016 at 2:31 PM, Niranjan Karunanandham <
>>> niran...@wso2.com> wrote:
>>>
 Hi Devs,

 In Carbon 5, the carbon.yml, log4j2.xml and etc., are in the
 distribution folder and copied to the distribution pack via bin.xml. Why
 don't we add these configuration files to Carbon Server Feature
 (org.wso2.carbon.core.server.feature) which are copied to the packed when
 the feature is installed. WDYT?

 +1. we should bring the configurations also when we install the core
>>> feature.
>>>
>>> Regards,
 Nira

 --

 *Niranjan Karunanandham*
 Senior Software Engineer - WSO2 Inc.
 WSO2 Inc.: http://www.wso2.com

 ___
 Dev mailing list
 Dev@wso2.org
 http://wso2.org/cgi-bin/mailman/listinfo/dev


>>>
>>>
>>> --
>>>
>>> *Aruna Sujith Karunarathna *
>>> WSO2, Inc | lean. enterprise. middleware.
>>> #20, Palm Grove, Colombo 03, Sri Lanka
>>> Mobile: +94 71 9040362 | Work: +94 112145345
>>> Email: ar...@wso2.com | Web: www.wso2.com
>>>
>>>
>>
>>
>>
>> --
>> *Kishanthan Thangarajah*
>> Associate Technical Lead,
>> Platform Technologies Team,
>> WSO2, Inc.
>> lean.enterprise.middleware
>>
>> Mobile - +94773426635
>> Blog - *http://kishanthan.wordpress.com
>> *
>> Twitter - *http://twitter.com/kishanthan *
>>
>
>
> Regards,
> Nira
>
> --
>
> *Niranjan Karunanandham*
> Senior Software Engineer - WSO2 Inc.
> WSO2 Inc.: http://www.wso2.com
>



-- 
*Kishanthan Thangarajah*
Associate Technical Lead,
Platform Technologies Team,
WSO2, Inc.
lean.enterprise.middleware

Mobile - +94773426635
Blog - *http://kishanthan.wordpress.com *
Twitter - *http://twitter.com/kishanthan *
___
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev

Re: [Dev] Include carbon.yml and other config files in Carbon Core feature

[Niranjan Karunanandham]

Hi Kishanthan,

On Tue, Apr 5, 2016 at 3:23 PM, Kishanthan Thangarajah 
wrote:

> +1
>
> Also by default, we need to have place holders for name, id and version
> properties rather than having hard coded values. The product team can then
> put their relevant values at build time. Let's add this also along with
> this change.
>
By default shall we have the above values as empty in the carbon.yml. If it
is not defined pick it up from System properties (using the place holder
carbon.name, carbon.id and carbon.version for name, id and version
respectively). If both are not define then get the values from a Constant.
WDYT?


>
>
> On Tue, Apr 5, 2016 at 3:14 PM, Aruna Karunarathna  wrote:
>
>> On Fri, Apr 1, 2016 at 2:31 PM, Niranjan Karunanandham > > wrote:
>>
>>> Hi Devs,
>>>
>>> In Carbon 5, the carbon.yml, log4j2.xml and etc., are in the
>>> distribution folder and copied to the distribution pack via bin.xml. Why
>>> don't we add these configuration files to Carbon Server Feature
>>> (org.wso2.carbon.core.server.feature) which are copied to the packed when
>>> the feature is installed. WDYT?
>>>
>>> +1. we should bring the configurations also when we install the core
>> feature.
>>
>> Regards,
>>> Nira
>>>
>>> --
>>>
>>> *Niranjan Karunanandham*
>>> Senior Software Engineer - WSO2 Inc.
>>> WSO2 Inc.: http://www.wso2.com
>>>
>>> ___
>>> Dev mailing list
>>> Dev@wso2.org
>>> http://wso2.org/cgi-bin/mailman/listinfo/dev
>>>
>>>
>>
>>
>> --
>>
>> *Aruna Sujith Karunarathna *
>> WSO2, Inc | lean. enterprise. middleware.
>> #20, Palm Grove, Colombo 03, Sri Lanka
>> Mobile: +94 71 9040362 | Work: +94 112145345
>> Email: ar...@wso2.com | Web: www.wso2.com
>>
>>
>
>
>
> --
> *Kishanthan Thangarajah*
> Associate Technical Lead,
> Platform Technologies Team,
> WSO2, Inc.
> lean.enterprise.middleware
>
> Mobile - +94773426635
> Blog - *http://kishanthan.wordpress.com *
> Twitter - *http://twitter.com/kishanthan *
>


Regards,
Nira

-- 

*Niranjan Karunanandham*
Senior Software Engineer - WSO2 Inc.
WSO2 Inc.: http://www.wso2.com
___
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev

Re: [Dev] Include carbon.yml and other config files in Carbon Core feature

[Kishanthan Thangarajah]

+1

Also by default, we need to have place holders for name, id and version
properties rather than having hard coded values. The product team can then
put their relevant values at build time. Let's add this also along with
this change.


On Tue, Apr 5, 2016 at 3:14 PM, Aruna Karunarathna  wrote:

> On Fri, Apr 1, 2016 at 2:31 PM, Niranjan Karunanandham 
> wrote:
>
>> Hi Devs,
>>
>> In Carbon 5, the carbon.yml, log4j2.xml and etc., are in the distribution
>> folder and copied to the distribution pack via bin.xml. Why don't we add
>> these configuration files to Carbon Server Feature
>> (org.wso2.carbon.core.server.feature) which are copied to the packed when
>> the feature is installed. WDYT?
>>
>> +1. we should bring the configurations also when we install the core
> feature.
>
> Regards,
>> Nira
>>
>> --
>>
>> *Niranjan Karunanandham*
>> Senior Software Engineer - WSO2 Inc.
>> WSO2 Inc.: http://www.wso2.com
>>
>> ___
>> Dev mailing list
>> Dev@wso2.org
>> http://wso2.org/cgi-bin/mailman/listinfo/dev
>>
>>
>
>
> --
>
> *Aruna Sujith Karunarathna *
> WSO2, Inc | lean. enterprise. middleware.
> #20, Palm Grove, Colombo 03, Sri Lanka
> Mobile: +94 71 9040362 | Work: +94 112145345
> Email: ar...@wso2.com | Web: www.wso2.com
>
>



-- 
*Kishanthan Thangarajah*
Associate Technical Lead,
Platform Technologies Team,
WSO2, Inc.
lean.enterprise.middleware

Mobile - +94773426635
Blog - *http://kishanthan.wordpress.com *
Twitter - *http://twitter.com/kishanthan *
___
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev

Re: [Dev] Include carbon.yml and other config files in Carbon Core feature

[Aruna Karunarathna]

On Fri, Apr 1, 2016 at 2:31 PM, Niranjan Karunanandham 
wrote:

> Hi Devs,
>
> In Carbon 5, the carbon.yml, log4j2.xml and etc., are in the distribution
> folder and copied to the distribution pack via bin.xml. Why don't we add
> these configuration files to Carbon Server Feature
> (org.wso2.carbon.core.server.feature) which are copied to the packed when
> the feature is installed. WDYT?
>
> +1. we should bring the configurations also when we install the core
feature.

Regards,
> Nira
>
> --
>
> *Niranjan Karunanandham*
> Senior Software Engineer - WSO2 Inc.
> WSO2 Inc.: http://www.wso2.com
>
> ___
> Dev mailing list
> Dev@wso2.org
> http://wso2.org/cgi-bin/mailman/listinfo/dev
>
>


-- 

*Aruna Sujith Karunarathna *
WSO2, Inc | lean. enterprise. middleware.
#20, Palm Grove, Colombo 03, Sri Lanka
Mobile: +94 71 9040362 | Work: +94 112145345
Email: ar...@wso2.com | Web: www.wso2.com
___
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev

[Dev] Include carbon.yml and other config files in Carbon Core feature

[Niranjan Karunanandham]

Hi Devs,

In Carbon 5, the carbon.yml, log4j2.xml and etc., are in the distribution
folder and copied to the distribution pack via bin.xml. Why don't we add
these configuration files to Carbon Server Feature
(org.wso2.carbon.core.server.feature) which are copied to the packed when
the feature is installed. WDYT?

Regards,
Nira

-- 

*Niranjan Karunanandham*
Senior Software Engineer - WSO2 Inc.
WSO2 Inc.: http://www.wso2.com
___
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev