Re: [Dev] Please Merge PR [PPasS] [Configurator]

2015-05-11 Thread Anuruddha Liyanarachchi
Hi Imesh,

I have now changed the code based on feedback.
Please review and merge the PR.

Thanks

On Sat, May 9, 2015 at 2:16 PM, Imesh Gunaratne im...@wso2.com wrote:

 Hi Anuruddha,

 Thanks for the pull request. I have added some feedback, please fix them
 and resend.

 Thanks

 On Fri, May 8, 2015 at 2:35 PM, Lahiru Sandaruwan lahi...@wso2.com
 wrote:

 Reviewing.

 Thanks.

 On Fri, May 8, 2015 at 2:31 PM, Anuruddha Liyanarachchi 
 anurudd...@wso2.com wrote:

 Hi,

 $subject please for [1].

 [1]https://github.com/wso2/product-private-paas/pull/69

 --
 *Thanks and Regards,*
 Anuruddha Lanka Liyanarachchi
 Software Engineer - WSO2
 Mobile : +94 (0) 712762611
 Tel  : +94 112 145 345
 a thili...@wso2.comnurudd...@wso2.com




 --
 --
 Lahiru Sandaruwan
 Committer and PMC member, Apache Stratos,
 Senior Software Engineer,
 WSO2 Inc., http://wso2.com
 lean.enterprise.middleware

 phone: +94773325954
 email: lahi...@wso2.com blog: http://lahiruwrites.blogspot.com/
 linked-in: http://lk.linkedin.com/pub/lahiru-sandaruwan/16/153/146




 --
 *Imesh Gunaratne*
 Senior Technical Lead
 WSO2 Inc: http://wso2.com
 T: +94 11 214 5345 M: +94 77 374 2057
 W: http://imesh.gunaratne.org
 Lean . Enterprise . Middleware




-- 
*Thanks and Regards,*
Anuruddha Lanka Liyanarachchi
Software Engineer - WSO2
Mobile : +94 (0) 712762611
Tel  : +94 112 145 345
a thili...@wso2.comnurudd...@wso2.com
___
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev


Re: [Dev] Please Merge PR [PPasS] [Configurator]

2015-05-09 Thread Imesh Gunaratne
Hi Anuruddha,

Thanks for the pull request. I have added some feedback, please fix them
and resend.

Thanks

On Fri, May 8, 2015 at 2:35 PM, Lahiru Sandaruwan lahi...@wso2.com wrote:

 Reviewing.

 Thanks.

 On Fri, May 8, 2015 at 2:31 PM, Anuruddha Liyanarachchi 
 anurudd...@wso2.com wrote:

 Hi,

 $subject please for [1].

 [1]https://github.com/wso2/product-private-paas/pull/69

 --
 *Thanks and Regards,*
 Anuruddha Lanka Liyanarachchi
 Software Engineer - WSO2
 Mobile : +94 (0) 712762611
 Tel  : +94 112 145 345
 a thili...@wso2.comnurudd...@wso2.com




 --
 --
 Lahiru Sandaruwan
 Committer and PMC member, Apache Stratos,
 Senior Software Engineer,
 WSO2 Inc., http://wso2.com
 lean.enterprise.middleware

 phone: +94773325954
 email: lahi...@wso2.com blog: http://lahiruwrites.blogspot.com/
 linked-in: http://lk.linkedin.com/pub/lahiru-sandaruwan/16/153/146




-- 
*Imesh Gunaratne*
Senior Technical Lead
WSO2 Inc: http://wso2.com
T: +94 11 214 5345 M: +94 77 374 2057
W: http://imesh.gunaratne.org
Lean . Enterprise . Middleware
___
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev


Re: [Dev] Please Merge PR [PPasS] [Configurator]

2015-05-08 Thread Lahiru Sandaruwan
Reviewing.

Thanks.

On Fri, May 8, 2015 at 2:31 PM, Anuruddha Liyanarachchi anurudd...@wso2.com
 wrote:

 Hi,

 $subject please for [1].

 [1]https://github.com/wso2/product-private-paas/pull/69

 --
 *Thanks and Regards,*
 Anuruddha Lanka Liyanarachchi
 Software Engineer - WSO2
 Mobile : +94 (0) 712762611
 Tel  : +94 112 145 345
 a thili...@wso2.comnurudd...@wso2.com




-- 
--
Lahiru Sandaruwan
Committer and PMC member, Apache Stratos,
Senior Software Engineer,
WSO2 Inc., http://wso2.com
lean.enterprise.middleware

phone: +94773325954
email: lahi...@wso2.com blog: http://lahiruwrites.blogspot.com/
linked-in: http://lk.linkedin.com/pub/lahiru-sandaruwan/16/153/146
___
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev


[Dev] Please Merge PR [PPasS] [Configurator]

2015-05-08 Thread Anuruddha Liyanarachchi
Hi,

$subject please for [1].

[1]https://github.com/wso2/product-private-paas/pull/69

-- 
*Thanks and Regards,*
Anuruddha Lanka Liyanarachchi
Software Engineer - WSO2
Mobile : +94 (0) 712762611
Tel  : +94 112 145 345
a thili...@wso2.comnurudd...@wso2.com
___
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev