[Dev] Support multiple Set-Cookie header in Integration Server

[Nuwan Wimalasekara]

Hi
 In our code, We are using a map to keep the headers. Even if there are
multiple headers with same name with the incoming request, We only keep
one. As the design we are unable to handle the multiple headers with same
name at the moment.

However HttpMessage received from netty includes all the headers and it
keep multiple headers with same name since it use java.util.LinkedList to
keep the headers. So we also should use List to support multiple header
with same name and be careful when adding and updating the headers. Because
we have to check whether It is a new header or updating  the existing header

Is there any intentional reason to use map in keeping the herders.
Appreciate your thought on this


[1] https://wso2.org/jira/browse/CTRANSPORT-10

Thanks,
Nuwanw

-- 
Nuwan Wimalasekara
Associate Technical Lead
WSO2, Inc.: http://wso2.com
lean. enterprise. middleware

phone: +94 71 668 4620
___
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev

Re: [Dev] Support multiple Set-Cookie header in Integration Server

[Afkham Azeez]

I think this is a poor design oversight and no specific reason, and we
haven't thought about multi-valued headers. Please go ahead and change the
API.

On Mon, Aug 29, 2016 at 12:16 PM, Nuwan Wimalasekara 
wrote:

> Hi
>  In our code, We are using a map to keep the headers. Even if there are
> multiple headers with same name with the incoming request, We only keep
> one. As the design we are unable to handle the multiple headers with same
> name at the moment.
>
> However HttpMessage received from netty includes all the headers and it
> keep multiple headers with same name since it use java.util.LinkedList to
> keep the headers. So we also should use List to support multiple header
> with same name and be careful when adding and updating the headers. Because
> we have to check whether It is a new header or updating  the existing header
>
> Is there any intentional reason to use map in keeping the herders.
> Appreciate your thought on this
>
>
> [1] https://wso2.org/jira/browse/CTRANSPORT-10
>
> Thanks,
> Nuwanw
>
> --
> Nuwan Wimalasekara
> Associate Technical Lead
> WSO2, Inc.: http://wso2.com
> lean. enterprise. middleware
>
> phone: +94 71 668 4620
>
>
>
>


-- 
*Afkham Azeez*
Director of Architecture; WSO2, Inc.; http://wso2.com
Member; Apache Software Foundation; http://www.apache.org/
* *
*email: **az...@wso2.com* 
* cell: +94 77 3320919blog: **http://blog.afkham.org*

*twitter: **http://twitter.com/afkham_azeez*

*linked-in: **http://lk.linkedin.com/in/afkhamazeez
*

*Lean . Enterprise . Middleware*
___
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev