Re: [Dev] [ES] Please review & merge the PR

2015-06-29 Thread Udara Rathnayake
functionality tested in chrome 37.0.X and PR merged.

Regards,
UdaraR

On Mon, Jun 29, 2015 at 3:02 PM, Jerad Rutnam  wrote:

> Hi Tanya,
>
> I have developed a custom function for popover drop-down and implemented
> it to both publisher & store. Sent a PR [1] with the fix. Please check &
> merge it.
>
> [1] - https://github.com/wso2/carbon-store/pull/80
>
> Cheers,
> Jerad
>
> On Thu, Jun 25, 2015 at 1:06 PM, Jerad Rutnam  wrote:
>
>> Hi Tanya,
>>
>> It's the default popover function comes with bootstrap framework. Anyway
>> as I mentioned I will develop a custom function for this. And will update
>> you once it's done.
>>
>> Cheers!
>> Jerad
>>
>> On Thu, Jun 25, 2015 at 11:48 AM, Tanya Madurapperuma 
>> wrote:
>>
>>> Hi Jerad,
>>>
>>> As informed to you offline  with this PR, tile icon doesn't show the pop
>>> up in older versions of chrome (checked in 37.0.2062.94)
>>> When I revert your commit it loads without any issue.
>>> Appreciate if you can have a look.
>>>
>>> Thanks,
>>> Tanya
>>>
>>> On Thu, Jun 25, 2015 at 8:53 AM, Jerad Rutnam  wrote:
>>>
 Thanks a lot for merging it Udara.

 Cheers!
 Jerad

 On Wed, Jun 24, 2015 at 7:06 PM, Udara Rathnayake 
 wrote:

> PR merged,
>
> Regards,
> UdaraR
>
> On Wed, Jun 24, 2015 at 5:47 PM, Jerad Rutnam  wrote:
>
>> Hi ES Team,
>>
>> Please merge this PR [1] which contains some UI fixes,
>>
>> - [STORE-783] - Sign in page head text update
>> - [STORE-784] - Asset menu close on outside click
>> - [STORE-786] - Fixed asset menu cuts when there is no content
>> - Renamed "font" folder to "fonts" & updated font-wso2 library
>> - Asset drop menu style tweak
>> - Fix for footer position bottom in store
>> - Updated font-wso2 in both Publisher & Store
>>
>> [1] - https://github.com/wso2/carbon-store/pull/63
>>
>> Thanks,
>> Jerad
>>
>> On Mon, Jun 22, 2015 at 1:44 PM, Jerad Rutnam  wrote:
>>
>>> Hi ES Team,
>>>
>>> Please check and merge the PR [1], which contains,
>>>
>>> - [STORE-786] - Fixed asset menu cuts when there is no content
>>> 
>>> - [STORE-784] - Asset menu close on outside click
>>> 
>>> - [STORE-783] - Sign in page head text update
>>> 
>>>
>>> [1] - *https://github.com/wso2/carbon-store/pull/63
>>> *
>>>
>>> Thanks,
>>> Jerad
>>>
>>> --
>>> *Jerad Rutnam*
>>> *Software Engineer*
>>>
>>> WSO2 Inc.
>>> lean | enterprise | middleware
>>> M : +94 77 959 1609 | E : je...@wso2.com | W : www.wso2.com
>>>
>>
>>
>>
>> --
>> *Jerad Rutnam*
>> *Software Engineer*
>>
>> WSO2 Inc.
>> lean | enterprise | middleware
>> M : +94 77 959 1609 | E : je...@wso2.com | W : www.wso2.com
>>
>
>


 --
 *Jerad Rutnam*
 *Software Engineer*

 WSO2 Inc.
 lean | enterprise | middleware
 M : +94 77 959 1609 | E : je...@wso2.com | W : www.wso2.com

>>>
>>>
>>>
>>> --
>>> Tanya Madurapperuma
>>>
>>> Senior Software Engineer,
>>> WSO2 Inc. : wso2.com
>>> Mobile : +94718184439
>>> Blog : http://tanyamadurapperuma.blogspot.com
>>>
>>
>>
>>
>> --
>> *Jerad Rutnam*
>> *Software Engineer*
>>
>> WSO2 Inc.
>> lean | enterprise | middleware
>> M : +94 77 959 1609 | E : je...@wso2.com | W : www.wso2.com
>>
>
>
>
> --
> *Jerad Rutnam*
> *Software Engineer*
>
> WSO2 Inc.
> lean | enterprise | middleware
> M : +94 77 959 1609 | E : je...@wso2.com | W : www.wso2.com
>
___
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev


Re: [Dev] [ES] Please review & merge the PR

2015-06-29 Thread Jerad Rutnam
Hi Tanya,

I have developed a custom function for popover drop-down and implemented it
to both publisher & store. Sent a PR [1] with the fix. Please check & merge
it.

[1] - https://github.com/wso2/carbon-store/pull/80

Cheers,
Jerad

On Thu, Jun 25, 2015 at 1:06 PM, Jerad Rutnam  wrote:

> Hi Tanya,
>
> It's the default popover function comes with bootstrap framework. Anyway
> as I mentioned I will develop a custom function for this. And will update
> you once it's done.
>
> Cheers!
> Jerad
>
> On Thu, Jun 25, 2015 at 11:48 AM, Tanya Madurapperuma 
> wrote:
>
>> Hi Jerad,
>>
>> As informed to you offline  with this PR, tile icon doesn't show the pop
>> up in older versions of chrome (checked in 37.0.2062.94)
>> When I revert your commit it loads without any issue.
>> Appreciate if you can have a look.
>>
>> Thanks,
>> Tanya
>>
>> On Thu, Jun 25, 2015 at 8:53 AM, Jerad Rutnam  wrote:
>>
>>> Thanks a lot for merging it Udara.
>>>
>>> Cheers!
>>> Jerad
>>>
>>> On Wed, Jun 24, 2015 at 7:06 PM, Udara Rathnayake 
>>> wrote:
>>>
 PR merged,

 Regards,
 UdaraR

 On Wed, Jun 24, 2015 at 5:47 PM, Jerad Rutnam  wrote:

> Hi ES Team,
>
> Please merge this PR [1] which contains some UI fixes,
>
> - [STORE-783] - Sign in page head text update
> - [STORE-784] - Asset menu close on outside click
> - [STORE-786] - Fixed asset menu cuts when there is no content
> - Renamed "font" folder to "fonts" & updated font-wso2 library
> - Asset drop menu style tweak
> - Fix for footer position bottom in store
> - Updated font-wso2 in both Publisher & Store
>
> [1] - https://github.com/wso2/carbon-store/pull/63
>
> Thanks,
> Jerad
>
> On Mon, Jun 22, 2015 at 1:44 PM, Jerad Rutnam  wrote:
>
>> Hi ES Team,
>>
>> Please check and merge the PR [1], which contains,
>>
>> - [STORE-786] - Fixed asset menu cuts when there is no content
>> 
>> - [STORE-784] - Asset menu close on outside click
>> 
>> - [STORE-783] - Sign in page head text update
>> 
>>
>> [1] - *https://github.com/wso2/carbon-store/pull/63
>> *
>>
>> Thanks,
>> Jerad
>>
>> --
>> *Jerad Rutnam*
>> *Software Engineer*
>>
>> WSO2 Inc.
>> lean | enterprise | middleware
>> M : +94 77 959 1609 | E : je...@wso2.com | W : www.wso2.com
>>
>
>
>
> --
> *Jerad Rutnam*
> *Software Engineer*
>
> WSO2 Inc.
> lean | enterprise | middleware
> M : +94 77 959 1609 | E : je...@wso2.com | W : www.wso2.com
>


>>>
>>>
>>> --
>>> *Jerad Rutnam*
>>> *Software Engineer*
>>>
>>> WSO2 Inc.
>>> lean | enterprise | middleware
>>> M : +94 77 959 1609 | E : je...@wso2.com | W : www.wso2.com
>>>
>>
>>
>>
>> --
>> Tanya Madurapperuma
>>
>> Senior Software Engineer,
>> WSO2 Inc. : wso2.com
>> Mobile : +94718184439
>> Blog : http://tanyamadurapperuma.blogspot.com
>>
>
>
>
> --
> *Jerad Rutnam*
> *Software Engineer*
>
> WSO2 Inc.
> lean | enterprise | middleware
> M : +94 77 959 1609 | E : je...@wso2.com | W : www.wso2.com
>



-- 
*Jerad Rutnam*
*Software Engineer*

WSO2 Inc.
lean | enterprise | middleware
M : +94 77 959 1609 | E : je...@wso2.com | W : www.wso2.com
___
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev


Re: [Dev] [ES] Please review & merge the PR

2015-06-25 Thread Jerad Rutnam
Hi Tanya,

It's the default popover function comes with bootstrap framework. Anyway as
I mentioned I will develop a custom function for this. And will update you
once it's done.

Cheers!
Jerad

On Thu, Jun 25, 2015 at 11:48 AM, Tanya Madurapperuma 
wrote:

> Hi Jerad,
>
> As informed to you offline  with this PR, tile icon doesn't show the pop
> up in older versions of chrome (checked in 37.0.2062.94)
> When I revert your commit it loads without any issue.
> Appreciate if you can have a look.
>
> Thanks,
> Tanya
>
> On Thu, Jun 25, 2015 at 8:53 AM, Jerad Rutnam  wrote:
>
>> Thanks a lot for merging it Udara.
>>
>> Cheers!
>> Jerad
>>
>> On Wed, Jun 24, 2015 at 7:06 PM, Udara Rathnayake 
>> wrote:
>>
>>> PR merged,
>>>
>>> Regards,
>>> UdaraR
>>>
>>> On Wed, Jun 24, 2015 at 5:47 PM, Jerad Rutnam  wrote:
>>>
 Hi ES Team,

 Please merge this PR [1] which contains some UI fixes,

 - [STORE-783] - Sign in page head text update
 - [STORE-784] - Asset menu close on outside click
 - [STORE-786] - Fixed asset menu cuts when there is no content
 - Renamed "font" folder to "fonts" & updated font-wso2 library
 - Asset drop menu style tweak
 - Fix for footer position bottom in store
 - Updated font-wso2 in both Publisher & Store

 [1] - https://github.com/wso2/carbon-store/pull/63

 Thanks,
 Jerad

 On Mon, Jun 22, 2015 at 1:44 PM, Jerad Rutnam  wrote:

> Hi ES Team,
>
> Please check and merge the PR [1], which contains,
>
> - [STORE-786] - Fixed asset menu cuts when there is no content
> 
> - [STORE-784] - Asset menu close on outside click
> 
> - [STORE-783] - Sign in page head text update
> 
>
> [1] - *https://github.com/wso2/carbon-store/pull/63
> *
>
> Thanks,
> Jerad
>
> --
> *Jerad Rutnam*
> *Software Engineer*
>
> WSO2 Inc.
> lean | enterprise | middleware
> M : +94 77 959 1609 | E : je...@wso2.com | W : www.wso2.com
>



 --
 *Jerad Rutnam*
 *Software Engineer*

 WSO2 Inc.
 lean | enterprise | middleware
 M : +94 77 959 1609 | E : je...@wso2.com | W : www.wso2.com

>>>
>>>
>>
>>
>> --
>> *Jerad Rutnam*
>> *Software Engineer*
>>
>> WSO2 Inc.
>> lean | enterprise | middleware
>> M : +94 77 959 1609 | E : je...@wso2.com | W : www.wso2.com
>>
>
>
>
> --
> Tanya Madurapperuma
>
> Senior Software Engineer,
> WSO2 Inc. : wso2.com
> Mobile : +94718184439
> Blog : http://tanyamadurapperuma.blogspot.com
>



-- 
*Jerad Rutnam*
*Software Engineer*

WSO2 Inc.
lean | enterprise | middleware
M : +94 77 959 1609 | E : je...@wso2.com | W : www.wso2.com
___
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev


Re: [Dev] [ES] Please review & merge the PR

2015-06-24 Thread Tanya Madurapperuma
Hi Jerad,

As informed to you offline  with this PR, tile icon doesn't show the pop up
in older versions of chrome (checked in 37.0.2062.94)
When I revert your commit it loads without any issue.
Appreciate if you can have a look.

Thanks,
Tanya

On Thu, Jun 25, 2015 at 8:53 AM, Jerad Rutnam  wrote:

> Thanks a lot for merging it Udara.
>
> Cheers!
> Jerad
>
> On Wed, Jun 24, 2015 at 7:06 PM, Udara Rathnayake  wrote:
>
>> PR merged,
>>
>> Regards,
>> UdaraR
>>
>> On Wed, Jun 24, 2015 at 5:47 PM, Jerad Rutnam  wrote:
>>
>>> Hi ES Team,
>>>
>>> Please merge this PR [1] which contains some UI fixes,
>>>
>>> - [STORE-783] - Sign in page head text update
>>> - [STORE-784] - Asset menu close on outside click
>>> - [STORE-786] - Fixed asset menu cuts when there is no content
>>> - Renamed "font" folder to "fonts" & updated font-wso2 library
>>> - Asset drop menu style tweak
>>> - Fix for footer position bottom in store
>>> - Updated font-wso2 in both Publisher & Store
>>>
>>> [1] - https://github.com/wso2/carbon-store/pull/63
>>>
>>> Thanks,
>>> Jerad
>>>
>>> On Mon, Jun 22, 2015 at 1:44 PM, Jerad Rutnam  wrote:
>>>
 Hi ES Team,

 Please check and merge the PR [1], which contains,

 - [STORE-786] - Fixed asset menu cuts when there is no content
 
 - [STORE-784] - Asset menu close on outside click
 
 - [STORE-783] - Sign in page head text update
 

 [1] - *https://github.com/wso2/carbon-store/pull/63
 *

 Thanks,
 Jerad

 --
 *Jerad Rutnam*
 *Software Engineer*

 WSO2 Inc.
 lean | enterprise | middleware
 M : +94 77 959 1609 | E : je...@wso2.com | W : www.wso2.com

>>>
>>>
>>>
>>> --
>>> *Jerad Rutnam*
>>> *Software Engineer*
>>>
>>> WSO2 Inc.
>>> lean | enterprise | middleware
>>> M : +94 77 959 1609 | E : je...@wso2.com | W : www.wso2.com
>>>
>>
>>
>
>
> --
> *Jerad Rutnam*
> *Software Engineer*
>
> WSO2 Inc.
> lean | enterprise | middleware
> M : +94 77 959 1609 | E : je...@wso2.com | W : www.wso2.com
>



-- 
Tanya Madurapperuma

Senior Software Engineer,
WSO2 Inc. : wso2.com
Mobile : +94718184439
Blog : http://tanyamadurapperuma.blogspot.com
___
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev


Re: [Dev] [ES] Please review & merge the PR

2015-06-24 Thread Jerad Rutnam
Thanks a lot for merging it Udara.

Cheers!
Jerad

On Wed, Jun 24, 2015 at 7:06 PM, Udara Rathnayake  wrote:

> PR merged,
>
> Regards,
> UdaraR
>
> On Wed, Jun 24, 2015 at 5:47 PM, Jerad Rutnam  wrote:
>
>> Hi ES Team,
>>
>> Please merge this PR [1] which contains some UI fixes,
>>
>> - [STORE-783] - Sign in page head text update
>> - [STORE-784] - Asset menu close on outside click
>> - [STORE-786] - Fixed asset menu cuts when there is no content
>> - Renamed "font" folder to "fonts" & updated font-wso2 library
>> - Asset drop menu style tweak
>> - Fix for footer position bottom in store
>> - Updated font-wso2 in both Publisher & Store
>>
>> [1] - https://github.com/wso2/carbon-store/pull/63
>>
>> Thanks,
>> Jerad
>>
>> On Mon, Jun 22, 2015 at 1:44 PM, Jerad Rutnam  wrote:
>>
>>> Hi ES Team,
>>>
>>> Please check and merge the PR [1], which contains,
>>>
>>> - [STORE-786] - Fixed asset menu cuts when there is no content
>>> 
>>> - [STORE-784] - Asset menu close on outside click
>>> 
>>> - [STORE-783] - Sign in page head text update
>>> 
>>>
>>> [1] - *https://github.com/wso2/carbon-store/pull/63
>>> *
>>>
>>> Thanks,
>>> Jerad
>>>
>>> --
>>> *Jerad Rutnam*
>>> *Software Engineer*
>>>
>>> WSO2 Inc.
>>> lean | enterprise | middleware
>>> M : +94 77 959 1609 | E : je...@wso2.com | W : www.wso2.com
>>>
>>
>>
>>
>> --
>> *Jerad Rutnam*
>> *Software Engineer*
>>
>> WSO2 Inc.
>> lean | enterprise | middleware
>> M : +94 77 959 1609 | E : je...@wso2.com | W : www.wso2.com
>>
>
>


-- 
*Jerad Rutnam*
*Software Engineer*

WSO2 Inc.
lean | enterprise | middleware
M : +94 77 959 1609 | E : je...@wso2.com | W : www.wso2.com
___
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev


Re: [Dev] [ES] Please review & merge the PR

2015-06-24 Thread Udara Rathnayake
PR merged,

Regards,
UdaraR

On Wed, Jun 24, 2015 at 5:47 PM, Jerad Rutnam  wrote:

> Hi ES Team,
>
> Please merge this PR [1] which contains some UI fixes,
>
> - [STORE-783] - Sign in page head text update
> - [STORE-784] - Asset menu close on outside click
> - [STORE-786] - Fixed asset menu cuts when there is no content
> - Renamed "font" folder to "fonts" & updated font-wso2 library
> - Asset drop menu style tweak
> - Fix for footer position bottom in store
> - Updated font-wso2 in both Publisher & Store
>
> [1] - https://github.com/wso2/carbon-store/pull/63
>
> Thanks,
> Jerad
>
> On Mon, Jun 22, 2015 at 1:44 PM, Jerad Rutnam  wrote:
>
>> Hi ES Team,
>>
>> Please check and merge the PR [1], which contains,
>>
>> - [STORE-786] - Fixed asset menu cuts when there is no content
>> 
>> - [STORE-784] - Asset menu close on outside click
>> 
>> - [STORE-783] - Sign in page head text update
>> 
>>
>> [1] - *https://github.com/wso2/carbon-store/pull/63
>> *
>>
>> Thanks,
>> Jerad
>>
>> --
>> *Jerad Rutnam*
>> *Software Engineer*
>>
>> WSO2 Inc.
>> lean | enterprise | middleware
>> M : +94 77 959 1609 | E : je...@wso2.com | W : www.wso2.com
>>
>
>
>
> --
> *Jerad Rutnam*
> *Software Engineer*
>
> WSO2 Inc.
> lean | enterprise | middleware
> M : +94 77 959 1609 | E : je...@wso2.com | W : www.wso2.com
>
___
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev


Re: [Dev] [ES] Please review & merge the PR

2015-06-24 Thread Jerad Rutnam
Hi ES Team,

Please merge this PR [1] which contains some UI fixes,

- [STORE-783] - Sign in page head text update
- [STORE-784] - Asset menu close on outside click
- [STORE-786] - Fixed asset menu cuts when there is no content
- Renamed "font" folder to "fonts" & updated font-wso2 library
- Asset drop menu style tweak
- Fix for footer position bottom in store
- Updated font-wso2 in both Publisher & Store

[1] - https://github.com/wso2/carbon-store/pull/63

Thanks,
Jerad

On Mon, Jun 22, 2015 at 1:44 PM, Jerad Rutnam  wrote:

> Hi ES Team,
>
> Please check and merge the PR [1], which contains,
>
> - [STORE-786] - Fixed asset menu cuts when there is no content
> 
> - [STORE-784] - Asset menu close on outside click
> 
> - [STORE-783] - Sign in page head text update
> 
>
> [1] - *https://github.com/wso2/carbon-store/pull/63
> *
>
> Thanks,
> Jerad
>
> --
> *Jerad Rutnam*
> *Software Engineer*
>
> WSO2 Inc.
> lean | enterprise | middleware
> M : +94 77 959 1609 | E : je...@wso2.com | W : www.wso2.com
>



-- 
*Jerad Rutnam*
*Software Engineer*

WSO2 Inc.
lean | enterprise | middleware
M : +94 77 959 1609 | E : je...@wso2.com | W : www.wso2.com
___
Dev mailing list
Dev@wso2.org
http://wso2.org/cgi-bin/mailman/listinfo/dev