Re: [Dev] XML Comments support in ESB configurations - Dev Studio update
Hi Jagath, Currenlty org.apache.synapse.mediators.AbstractMediator.getCommentsList() and org.apache.synapse.mediators.AbstractMediator.setCommentsList(ListString) methods haven't been defined in org.apache.synapse.Mediator interface. Did we do this intentionally ? It will be more convenient for us to have these two methods in org.apache.synapse.Mediator interface because we are relying on org.apache.synapse.Mediator interface to manipulate generic attributes such as shortDescription in our code. Is it possible to define these methods in the org.apache.synapse.Mediator interface ? Thanks, Viraj. On Sun, May 10, 2015 at 10:01 PM, Viraj Rajaguru vi...@wso2.com wrote: Hi Jagath, Thanks for informing us. We will use latest Synapse and Carbon libraries which contain this fix and do the relevant changes in DevS side to incorporate this feature. Thanks, Viraj. On Sun, May 10, 2015 at 6:47 PM, Jagath Sisirakumara Ariyarathne jaga...@wso2.com wrote: Hi DS Team, XML comments support in ESB configurations has been implemented to fix the Jira [1] with related documentation in [2]. [1] - https://wso2.org/jira/browse/ESBJAVA-3673 [2] - https://docs.google.com/document/d/1SRHBiCdXsZvvTDeX0qONzag8qbBRzh7ks9xNywyNrXA/edit#heading=h.6a7z1ncf8cph Could you please do the needful to incorporate changes required in Dev Studio editors for the $subject. Related PRs for synapse and carbon-mediation sources can be found in [3],[4]; [3] - https://github.com/wso2/wso2-synapse/pull/137 [4] - https://github.com/wso2/carbon-mediation/pull/105 Thanks. -- Jagath Ariyarathne Technical Lead WSO2 Inc. http://wso2.com/ Email: jaga...@wso2.com Mob : +94 77 386 7048 -- Viraj Rajaguru Senior Software Engineer WSO2 Inc. : http://wso2.com Mobile: +94 77 3683068 -- Viraj Rajaguru Senior Software Engineer WSO2 Inc. : http://wso2.com Mobile: +94 77 3683068 ___ Dev mailing list Dev@wso2.org http://wso2.org/cgi-bin/mailman/listinfo/dev
Re: [Dev] XML Comments support in ESB configurations - Dev Studio update
Hi Viraj, Comments list is added to AbstractMediator since it was implemented in few mediators at the initial implementation. But going forward, as you mentioned, it would be better if we define it in Mediator interface. @Kasun, Isuru, We can define getCommentsList() and setCommentsList() in Mediator interface. Then it should be implemented in all mediator classes even though it is not used in some of classes. Appreciate your feedback here. Thanks. On Mon, Jun 15, 2015 at 7:55 PM, Viraj Rajaguru vi...@wso2.com wrote: Hi Jagath, Currenlty org.apache.synapse.mediators.AbstractMediator.getCommentsList() and org.apache.synapse.mediators.AbstractMediator.setCommentsList(ListString) methods haven't been defined in org.apache.synapse.Mediator interface. Did we do this intentionally ? It will be more convenient for us to have these two methods in org.apache.synapse.Mediator interface because we are relying on org.apache.synapse.Mediator interface to manipulate generic attributes such as shortDescription in our code. Is it possible to define these methods in the org.apache.synapse.Mediator interface ? Thanks, Viraj. On Sun, May 10, 2015 at 10:01 PM, Viraj Rajaguru vi...@wso2.com wrote: Hi Jagath, Thanks for informing us. We will use latest Synapse and Carbon libraries which contain this fix and do the relevant changes in DevS side to incorporate this feature. Thanks, Viraj. On Sun, May 10, 2015 at 6:47 PM, Jagath Sisirakumara Ariyarathne jaga...@wso2.com wrote: Hi DS Team, XML comments support in ESB configurations has been implemented to fix the Jira [1] with related documentation in [2]. [1] - https://wso2.org/jira/browse/ESBJAVA-3673 [2] - https://docs.google.com/document/d/1SRHBiCdXsZvvTDeX0qONzag8qbBRzh7ks9xNywyNrXA/edit#heading=h.6a7z1ncf8cph Could you please do the needful to incorporate changes required in Dev Studio editors for the $subject. Related PRs for synapse and carbon-mediation sources can be found in [3],[4]; [3] - https://github.com/wso2/wso2-synapse/pull/137 [4] - https://github.com/wso2/carbon-mediation/pull/105 Thanks. -- Jagath Ariyarathne Technical Lead WSO2 Inc. http://wso2.com/ Email: jaga...@wso2.com Mob : +94 77 386 7048 -- Viraj Rajaguru Senior Software Engineer WSO2 Inc. : http://wso2.com Mobile: +94 77 3683068 -- Viraj Rajaguru Senior Software Engineer WSO2 Inc. : http://wso2.com Mobile: +94 77 3683068 -- Jagath Ariyarathne Technical Lead WSO2 Inc. http://wso2.com/ Email: jaga...@wso2.com Mob : +94 77 386 7048 ___ Dev mailing list Dev@wso2.org http://wso2.org/cgi-bin/mailman/listinfo/dev
Re: [Dev] XML Comments support in ESB configurations - Dev Studio update
Hi Jagath, Thanks for informing us. We will use latest Synapse and Carbon libraries which contain this fix and do the relevant changes in DevS side to incorporate this feature. Thanks, Viraj. On Sun, May 10, 2015 at 6:47 PM, Jagath Sisirakumara Ariyarathne jaga...@wso2.com wrote: Hi DS Team, XML comments support in ESB configurations has been implemented to fix the Jira [1] with related documentation in [2]. [1] - https://wso2.org/jira/browse/ESBJAVA-3673 [2] - https://docs.google.com/document/d/1SRHBiCdXsZvvTDeX0qONzag8qbBRzh7ks9xNywyNrXA/edit#heading=h.6a7z1ncf8cph Could you please do the needful to incorporate changes required in Dev Studio editors for the $subject. Related PRs for synapse and carbon-mediation sources can be found in [3],[4]; [3] - https://github.com/wso2/wso2-synapse/pull/137 [4] - https://github.com/wso2/carbon-mediation/pull/105 Thanks. -- Jagath Ariyarathne Technical Lead WSO2 Inc. http://wso2.com/ Email: jaga...@wso2.com Mob : +94 77 386 7048 -- Viraj Rajaguru Senior Software Engineer WSO2 Inc. : http://wso2.com Mobile: +94 77 3683068 ___ Dev mailing list Dev@wso2.org http://wso2.org/cgi-bin/mailman/listinfo/dev
