[jira] [Resolved] (YUNIKORN-64) Add zap encoders for time and duration
[
https://issues.apache.org/jira/browse/YUNIKORN-64?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Wilfred Spiegelenburg resolved YUNIKORN-64.
---
Fix Version/s: 0.8
Assignee: Wilfred Spiegelenburg
Resolution: Fixed
shim and core code have both been fixed
unit test code has comments on side effects of test functions and how to
resolve them
> Add zap encoders for time and duration
> --
>
> Key: YUNIKORN-64
> URL: https://issues.apache.org/jira/browse/YUNIKORN-64
> Project: Apache YuniKorn
> Issue Type: Task
> Components: core - common
>Reporter: Wilfred Spiegelenburg
>Assignee: Wilfred Spiegelenburg
>Priority: Major
> Labels: pull-request-available
> Fix For: 0.8
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> In YUNIKORN-62 a nil pointer caused a panic. The fix was to change the log
> call from a Duration to a String.
> The real issue is the fact that the encoders for certain types are not set in
> the logger. This is most likely an OS or internationalisation configuration
> related issue. In the code we fail here:
> {code}
> panic: runtime error: invalid memory address or nil pointer
> dereference[signal SIGSEGV: segmentation violation code=0x1 addr=0x0
> pc=0x11ac568] goroutine 51
> [running]:go.uber.org/zap/zapcore.(*jsonEncoder).AppendDuration(0xc007eca390,
> 0x77370eba)
> /Users/wyang/go/pkg/mod/go.uber.org/zap@v1.13.0/zapcore/json_encoder.go:239
> {code}
> That links to the source code here:
> {code}
> 237 func (enc *jsonEncoder) AppendDuration(val time.Duration) {
> 238 cur := enc.buf.Len()
> 239 enc.EncodeDuration(val, enc)
> {code}
> That can only happen if the {{EncodeDuration}} function is nil.
> This links back to a similar [zap issue
> #645|https://github.com/uber-go/zap/issues/645] for time stamps. In the
> comments it says that the encoders are not optional for certain parts. We
> should make sure that the encoders are set correctly as that looks like it is
> the correct solution.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org
For additional commands, e-mail: dev-h...@yunikorn.apache.org
[jira] [Created] (YUNIKORN-73) Temporarily disable the badge on github
Weiwei Yang created YUNIKORN-73: --- Summary: Temporarily disable the badge on github Key: YUNIKORN-73 URL: https://issues.apache.org/jira/browse/YUNIKORN-73 Project: Apache YuniKorn Issue Type: Improvement Components: documentation Reporter: Weiwei Yang Assignee: Weiwei Yang Seems like our UT is not very stable on github, let's disable the badge and reenable it once we have a stable UT env. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org For additional commands, e-mail: dev-h...@yunikorn.apache.org
[jira] [Resolved] (YUNIKORN-67) Dockerfile from image/file is not used anymore
[ https://issues.apache.org/jira/browse/YUNIKORN-67?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kinga Marton resolved YUNIKORN-67. -- Fix Version/s: 0.8 Resolution: Fixed > Dockerfile from image/file is not used anymore > -- > > Key: YUNIKORN-67 > URL: https://issues.apache.org/jira/browse/YUNIKORN-67 > Project: Apache YuniKorn > Issue Type: Improvement > Components: shim - kubernetes >Reporter: Kinga Marton >Assignee: Kinga Marton >Priority: Minor > Labels: pull-request-available > Fix For: 0.8 > > Time Spent: 20m > Remaining Estimate: 0h > > With the following commit: > [https://github.com/apache/incubator-yunikorn-k8shim/commit/e79c44d00f2ef155d65ed796362f18edcedb6855#diff-b67911656ef5d18c4ae36cb6741b7965] > the reference from image/file/Dockerfile was removed, so it seems that this > is not used anymore during the image build. I would suggest to remove it. > [~wwei] is there any hidden usage of the file or it is safe to delete it? -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org For additional commands, e-mail: dev-h...@yunikorn.apache.org
[jira] [Created] (YUNIKORN-72) data race in unit test: TestTaskStateTransitions
Wilfred Spiegelenburg created YUNIKORN-72: - Summary: data race in unit test: TestTaskStateTransitions Key: YUNIKORN-72 URL: https://issues.apache.org/jira/browse/YUNIKORN-72 Project: Apache YuniKorn Issue Type: Test Components: test - unit Reporter: Wilfred Spiegelenburg Attachments: yunikorn-67_test_fail.txt Once in a while the TestTaskStateTransitions test fails in the shim with a data race. The test is flaky and needs to be fixed. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org For additional commands, e-mail: dev-h...@yunikorn.apache.org
[jira] [Created] (YUNIKORN-71) Fix flaky unit tests from incubator-yunikorn-k8shim
Kinga Marton created YUNIKORN-71: Summary: Fix flaky unit tests from incubator-yunikorn-k8shim Key: YUNIKORN-71 URL: https://issues.apache.org/jira/browse/YUNIKORN-71 Project: Apache YuniKorn Issue Type: Bug Components: core - scheduler Reporter: Kinga Marton There are a couple of tests what are failing intermittently, even in case of a documentation change only. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org For additional commands, e-mail: dev-h...@yunikorn.apache.org
[jira] [Created] (YUNIKORN-70) Add unit tests with code coverage to yunikorn-web
Akhil PB created YUNIKORN-70: Summary: Add unit tests with code coverage to yunikorn-web Key: YUNIKORN-70 URL: https://issues.apache.org/jira/browse/YUNIKORN-70 Project: Apache YuniKorn Issue Type: Task Reporter: Akhil PB Assignee: Akhil PB -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org For additional commands, e-mail: dev-h...@yunikorn.apache.org
