[VOTE] Release Apache YuniKorn 1.4.0 RC1
+1 - Verified signatures and checksums - Built on Ubuntu 23.04(amd64) with go1.21.1, deployed to k8s v1.27.5(3 nodes). - Checked UI/Application/Container metrics issues fixed. (YUNIKORN-2010/YUNIKORN-2025) - Run e2e tests. (Only two e2e tests failed in my env, persistent_volume and user_group_limit) - Run a simple preemption test For e2e test, manually created pvc pods still function correctly, user_group_limit e2e test issue has been confirmed in Slack Dev channel, I think both are non-block issues on the test code.
Re: [VOTE] Release Apache YuniKorn 1.4.0 RC1
+1 - Verified signatures and checksums - Verified LICENSE and NOTICE files - Built images from source on Mac M1 (arm64) with go 1.21 - Deployed YuniKorn with a local kind cluster (version 1.27.1), verified with a few test jobs - Verified YuniKorn UI and REST APIs Thanks Wilfred! Best regards Rainie On Fri, Nov 17, 2023 at 5:33 AM TingYao wrote: > +1 > > - Verified signatures and checksums > - Verified LICENSE and NOTICE files > - Built images from source on Mac M1 (arm64) with go 1.21 > - Run the scheduler with a local kind cluster (version 1.27.1), run simple > jobs and worked fine > > Thanks > Tingyao > > Craig Condit 於 2023年11月17日 週五 上午4:40寫道： > > > +1 (binding). > > > > - Verified keys and sums > > - Built images from source with go 1.21.4 on Mac (amd64) > > - Ran e2e tests and some simple applications > > > > Only issue encountered was it seems the (relatively) new UserGroupLimit > > e2e tests are not stable. Given this is a brand new feature and that test > > was recently committed, I don’t see this as a blocker. > > > > Craig > > > > > > > On Nov 15, 2023, at 3:36 AM, Wilfred Spiegelenburg < > wilfr...@apache.org> > > wrote: > > > > > > Hello everyone, > > > > > > I would like to call a vote for releasing Apache YuniKorn 1.4.0 RC1. > > > It is a large release with 250+ jiras included. > > > Please note that K8s v1.23 and earlier are no longer supported. > > > > > > The release artefacts have been uploaded here: > > > https://dist.apache.org/repos/dist/dev/yunikorn/1.4.0-RC1/ > > > > > > My public key is located in the KEYS file: > > > https://downloads.apache.org//yunikorn/KEYS > > > > > > JIRA issues that have been resolved in this release: > > > https://issues.apache.org/jira/issues/?filter=12352769 > > > > > > The release contains a number of incompatible changes that could > > > impact the release verification. Please read the draft release notes > > > attached to this vote for further details. > > > > > > Git tags for each component are as follows: > > > yunikorn-scheduler-interface: v1.4.0-1 > > > yunikorn-core: v1.4.0-1 > > > yunikorn-k8shim: v1.4.0-2 > > > yunikorn-web: v1.4.0-2 > > > yunikorn-release: v1.4.0-1 > > > > > > Once the release is voted on and approved, all repos will be tagged > > > 1.4.0 for consistency. > > > > > > Please review and vote. The vote will be open for at least 72 hours > > > and closes on Saturday 18 November 2023, 10:00:00 UTC > > > > > > [ ] +1 Approve > > > [ ] +0 No opinion > > > [ ] -1 Disapprove (and the reason why) > > > > > > > > > Thank you, > > > Wilfred > > > > > > - > > > To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org > > > For additional commands, e-mail: dev-h...@yunikorn.apache.org > > > > > > > > > - > > To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org > > For additional commands, e-mail: dev-h...@yunikorn.apache.org > > > > >
[jira] [Created] (YUNIKORN-2159) Clean up AppManager implementation
Craig Condit created YUNIKORN-2159: -- Summary: Clean up AppManager implementation Key: YUNIKORN-2159 URL: https://issues.apache.org/jira/browse/YUNIKORN-2159 Project: Apache YuniKorn Issue Type: Sub-task Components: shim - kubernetes Reporter: Craig Condit Assignee: Craig Condit The current shim recovery and app management code is highly complex and difficult to follow, making cleanup difficult. There are multiple abstractions in the existing code that are no longer relevant now that there is a single AppManager implementation. These should be consolidated to make future refactoring easier. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org For additional commands, e-mail: dev-h...@yunikorn.apache.org
[jira] [Resolved] (YUNIKORN-2033) Add MaxApplications in Template
[ https://issues.apache.org/jira/browse/YUNIKORN-2033?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Bacsko resolved YUNIKORN-2033. Fix Version/s: 1.5.0 Resolution: Fixed Merged to master. > Add MaxApplications in Template > --- > > Key: YUNIKORN-2033 > URL: https://issues.apache.org/jira/browse/YUNIKORN-2033 > Project: Apache YuniKorn > Issue Type: Improvement > Components: core - scheduler >Reporter: Kuan-Po Tseng >Assignee: Kuan-Po Tseng >Priority: Major > Labels: pull-request-available > Fix For: 1.5.0 > > > this is a follow up in https://issues.apache.org/jira/browse/YUNIKORN-193. > Currently we leave MaxApplications in ChildTemplate while Template didn't use > it. And looks like we didn't implement MaxApplications in unmanaged queue > either. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org For additional commands, e-mail: dev-h...@yunikorn.apache.org
[jira] [Resolved] (YUNIKORN-2157) Data race in TestStoreWithLimitedSize
[
https://issues.apache.org/jira/browse/YUNIKORN-2157?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Peter Bacsko resolved YUNIKORN-2157.
Fix Version/s: 1.5.0
Resolution: Fixed
> Data race in TestStoreWithLimitedSize
> -
>
> Key: YUNIKORN-2157
> URL: https://issues.apache.org/jira/browse/YUNIKORN-2157
> Project: Apache YuniKorn
> Issue Type: Bug
> Components: core - scheduler, test - unit
>Reporter: Peter Bacsko
>Assignee: Peter Bacsko
>Priority: Major
> Labels: pull-request-available
> Fix For: 1.5.0
>
>
> We found a race condition in our internal build env:
> {noformat}
> ==
> WARNING: DATA RACE
> Read at 0x013045a0 by goroutine 32:
>github.com/apache/yunikorn-core/pkg/events.(*EventStore).CollectEvents()
>/redacted/yunikorn-core/pkg/events/event_store.go:67 +0x1a8
>
> github.com/apache/yunikorn-core/pkg/events.(*EventPublisher).StartService.func1()
>/redacted/yunikorn-core/pkg/events/event_publisher.go:55 +0xd1
>
> Previous write at 0x013045a0 by goroutine 44:
>github.com/apache/yunikorn-core/pkg/events.TestStoreWithLimitedSize.func1()
>/redacted/yunikorn-core/pkg/events/event_store_test.go:59 +0x24
>runtime.deferreturn()
>/redacted/common/go/src/runtime/panic.go:477 +0x30
>testing.tRunner()
>/redacted/common/go/src/testing/testing.go:1595 +0x238
>testing.(*T).Run.func1()
>/redacted/common/go/src/testing/testing.go:1648 +0x44
>
> Goroutine 32 (running) created at:
>github.com/apache/yunikorn-core/pkg/events.(*EventPublisher).StartService()
>/redacted/yunikorn-core/pkg/events/event_publisher.go:50 +0xdc
>github.com/apache/yunikorn-core/pkg/events.TestPublisherSendsEvent()
>/redacted/yunikorn-core/pkg/events/event_publisher_test.go:122 +0x224
>testing.tRunner()
>/redacted/common/go/src/testing/testing.go:1595 +0x238
>testing.(*T).Run.func1()
>/redacted/common/go/src/testing/testing.go:1648 +0x44
>
> Goroutine 44 (finished) created at:
>testing.(*T).Run()
>/redacted/common/go/src/testing/testing.go:1648 +0x82a
>testing.runTests.func1()
>/redacted/common/go/src/testing/testing.go:2054 +0x84
>testing.tRunner()
>/redacted/common/go/src/testing/testing.go:1595 +0x238
>testing.runTests()
>/redacted/common/go/src/testing/testing.go:2052 +0x896
>testing.(*M).Run()
>/redacted/common/go/src/testing/testing.go:1925 +0xb57
>main.main()
>_testmain.go:121 +0x2e4
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org
For additional commands, e-mail: dev-h...@yunikorn.apache.org
Re: [VOTE] Release Apache YuniKorn 1.4.0 RC1
+1 - Verified signatures and checksums - Verified LICENSE and NOTICE files - Built images from source on Mac M1 (arm64) with go 1.21 - Run the scheduler with a local kind cluster (version 1.27.1), run simple jobs and worked fine Thanks Tingyao Craig Condit 於 2023年11月17日 週五 上午4:40寫道： > +1 (binding). > > - Verified keys and sums > - Built images from source with go 1.21.4 on Mac (amd64) > - Ran e2e tests and some simple applications > > Only issue encountered was it seems the (relatively) new UserGroupLimit > e2e tests are not stable. Given this is a brand new feature and that test > was recently committed, I don’t see this as a blocker. > > Craig > > > > On Nov 15, 2023, at 3:36 AM, Wilfred Spiegelenburg > wrote: > > > > Hello everyone, > > > > I would like to call a vote for releasing Apache YuniKorn 1.4.0 RC1. > > It is a large release with 250+ jiras included. > > Please note that K8s v1.23 and earlier are no longer supported. > > > > The release artefacts have been uploaded here: > > https://dist.apache.org/repos/dist/dev/yunikorn/1.4.0-RC1/ > > > > My public key is located in the KEYS file: > > https://downloads.apache.org//yunikorn/KEYS > > > > JIRA issues that have been resolved in this release: > > https://issues.apache.org/jira/issues/?filter=12352769 > > > > The release contains a number of incompatible changes that could > > impact the release verification. Please read the draft release notes > > attached to this vote for further details. > > > > Git tags for each component are as follows: > > yunikorn-scheduler-interface: v1.4.0-1 > > yunikorn-core: v1.4.0-1 > > yunikorn-k8shim: v1.4.0-2 > > yunikorn-web: v1.4.0-2 > > yunikorn-release: v1.4.0-1 > > > > Once the release is voted on and approved, all repos will be tagged > > 1.4.0 for consistency. > > > > Please review and vote. The vote will be open for at least 72 hours > > and closes on Saturday 18 November 2023, 10:00:00 UTC > > > > [ ] +1 Approve > > [ ] +0 No opinion > > [ ] -1 Disapprove (and the reason why) > > > > > > Thank you, > > Wilfred > > > > - > > To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org > > For additional commands, e-mail: dev-h...@yunikorn.apache.org > > > > > - > To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org > For additional commands, e-mail: dev-h...@yunikorn.apache.org > >
