[jira] [Resolved] (YUNIKORN-2529) Newly added nodes show 'ready:false' under node attributes

2024-04-02 Thread Craig Condit (Jira)


 [ 
https://issues.apache.org/jira/browse/YUNIKORN-2529?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Craig Condit resolved YUNIKORN-2529.

Fix Version/s: 1.6.0
   Resolution: Implemented

Resolving as this was fixed by YUNIKORN-2530.

> Newly added nodes show 'ready:false' under node attributes
> --
>
> Key: YUNIKORN-2529
> URL: https://issues.apache.org/jira/browse/YUNIKORN-2529
> Project: Apache YuniKorn
>  Issue Type: Bug
>  Components: webapp
>Affects Versions: 1.5.0
>Reporter: Craig Condit
>Assignee: Craig Condit
>Priority: Major
> Fix For: 1.6.0
>
>
> In the web UI, the attributes column for nodes shows 'ready:false' for newly 
> added nodes.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org
For additional commands, e-mail: dev-h...@yunikorn.apache.org



[jira] [Resolved] (YUNIKORN-2530) Remove unnecessary ready flag on node

2024-04-02 Thread Craig Condit (Jira)


 [ 
https://issues.apache.org/jira/browse/YUNIKORN-2530?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Craig Condit resolved YUNIKORN-2530.

Fix Version/s: 1.6.0
   Resolution: Fixed

Merged all PRs to master.

> Remove unnecessary ready flag on node
> -
>
> Key: YUNIKORN-2530
> URL: https://issues.apache.org/jira/browse/YUNIKORN-2530
> Project: Apache YuniKorn
>  Issue Type: Improvement
>  Components: core - scheduler, scheduler-interface, shim - kubernetes
>Reporter: Craig Condit
>Assignee: Craig Condit
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.6.0
>
>
> YuniKorn has had a "ready" flag for nodes for a long time, however this flag 
> is not set correctly and serves no purpose to the scheduler. In Kubernetes, 
> readiness is a far more complex concept anyway, and a single true/false value 
> is insufficient. Therefore, we should remove the ready flag to simplify the 
> interface. This will also fix a minor issue in the Web UI where ready:false 
> is shown for newly added nodes.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org
For additional commands, e-mail: dev-h...@yunikorn.apache.org



[jira] [Created] (YUNIKORN-2531) Create unit tests for AsyncRMCallback

2024-04-02 Thread Peter Bacsko (Jira)
Peter Bacsko created YUNIKORN-2531:
--

 Summary: Create unit tests for AsyncRMCallback
 Key: YUNIKORN-2531
 URL: https://issues.apache.org/jira/browse/YUNIKORN-2531
 Project: Apache YuniKorn
  Issue Type: Test
  Components: shim - kubernetes
Reporter: Peter Bacsko
Assignee: Peter Bacsko


There are no unit tests for the {{AsyncRMCallback}} type in the shim 
(scheduler_callback.go). It's tested indirectly but we have no idea about the 
coverage or how it behaves in rare scenarios.

At least longer methods such as {{UpdateApplication()}}, {{UpdateAllocation()}} 
and {{UpdateNode()}} should be covered.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org
For additional commands, e-mail: dev-h...@yunikorn.apache.org



[jira] [Created] (YUNIKORN-2530) Remove unnecessary ready flag on node

2024-04-02 Thread Craig Condit (Jira)
Craig Condit created YUNIKORN-2530:
--

 Summary: Remove unnecessary ready flag on node
 Key: YUNIKORN-2530
 URL: https://issues.apache.org/jira/browse/YUNIKORN-2530
 Project: Apache YuniKorn
  Issue Type: Improvement
  Components: core - scheduler, scheduler-interface, shim - kubernetes
Reporter: Craig Condit
Assignee: Craig Condit


YuniKorn has had a "ready" flag for nodes for a long time, however this flag is 
not set correctly and serves no purpose to the scheduler. In Kubernetes, 
readiness is a far more complex concept anyway, and a single true/false value 
is insufficient. Therefore, we should remove the ready flag to simplify the 
interface. This will also fix a minor issue in the Web UI where ready:false is 
shown for newly added nodes.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org
For additional commands, e-mail: dev-h...@yunikorn.apache.org



[jira] [Created] (YUNIKORN-2529) Newly added nodes show 'ready:false' under node attributes

2024-04-02 Thread Craig Condit (Jira)
Craig Condit created YUNIKORN-2529:
--

 Summary: Newly added nodes show 'ready:false' under node attributes
 Key: YUNIKORN-2529
 URL: https://issues.apache.org/jira/browse/YUNIKORN-2529
 Project: Apache YuniKorn
  Issue Type: Bug
  Components: webapp
Affects Versions: 1.5.0
Reporter: Craig Condit
Assignee: Craig Condit


In the web UI, the attributes column for nodes shows 'ready:false' for newly 
added nodes.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org
For additional commands, e-mail: dev-h...@yunikorn.apache.org



[jira] [Created] (YUNIKORN-2528) Increase coverage for UGM code

2024-04-02 Thread Peter Bacsko (Jira)
Peter Bacsko created YUNIKORN-2528:
--

 Summary: Increase coverage for UGM code
 Key: YUNIKORN-2528
 URL: https://issues.apache.org/jira/browse/YUNIKORN-2528
 Project: Apache YuniKorn
  Issue Type: Sub-task
  Components: core - scheduler
Reporter: Peter Bacsko


The following branches are not covered properly by unit tests:
 # {{GroupTracker.decreaseTrackedResource()}}: when {{gt == nil}}
 # {{Manager.DecreaseTrackedResource()}}: when there's no UserTracker
 # {{Manager.DecreaseTrackedResource()}}: when there's no GroupTracker
 # {{Manager.DecreaseTrackedResource()}}: when groupTracker decrement returns 
true
 # {{QueueTracker.decreaseTrackedResource()}}: when there's no child tracker

See https://app.codecov.io/gh/apache/yunikorn-core/pull/810.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org
For additional commands, e-mail: dev-h...@yunikorn.apache.org



[jira] [Closed] (YUNIKORN-2038) Testing the performance under multiple Taint & Toleration settings

2024-04-02 Thread Hsuan Zong Wu (Jira)


 [ 
https://issues.apache.org/jira/browse/YUNIKORN-2038?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Hsuan Zong Wu closed YUNIKORN-2038.
---
Resolution: Duplicate

> Testing the performance under multiple Taint & Toleration settings
> --
>
> Key: YUNIKORN-2038
> URL: https://issues.apache.org/jira/browse/YUNIKORN-2038
> Project: Apache YuniKorn
>  Issue Type: Sub-task
>  Components: documentation, shim - kubernetes
>Reporter: Hsuan Zong Wu
>Assignee: Chen, Kai-Chun
>Priority: Major
>
> *Test Case*
> Deploy Jobs with 10,000 Pods at the same time, but randomly set Taints & 
> Tolerations on nodes, Pods and observe the throughput between different 
> schedulers.
> *Expected Results*
> 1. Compare the Kube-Scheduler, Yunikorn standard mode, Yunikorn plugin mode.
> 2. record the test files in k8shim
> 3. record the random seed used in test & results & charts in Yunikorn-site.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org
For additional commands, e-mail: dev-h...@yunikorn.apache.org



[jira] [Closed] (YUNIKORN-2039) Testing the performance under multiple Affinity & Anti-Affinity settings

2024-04-02 Thread Hsuan Zong Wu (Jira)


 [ 
https://issues.apache.org/jira/browse/YUNIKORN-2039?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Hsuan Zong Wu closed YUNIKORN-2039.
---
Resolution: Duplicate

> Testing the performance under multiple Affinity & Anti-Affinity settings
> 
>
> Key: YUNIKORN-2039
> URL: https://issues.apache.org/jira/browse/YUNIKORN-2039
> Project: Apache YuniKorn
>  Issue Type: Sub-task
>  Components: documentation, shim - kubernetes
>Reporter: Hsuan Zong Wu
>Assignee: Hsuan Zong Wu
>Priority: Major
>
> *Test Case*
> Deploy Jobs with 10,000 Pods at the same time, but randomly configure 
> Affinity and Anti-Affinity settings on the Pods. This setup enables us to 
> monitor and assess the throughput variances across different schedulers.
> *Expected Results*
> 1. Compare the Kube-Scheduler, Yunikorn standard mode, Yunikorn plugin mode.
> 2. Test both node (anti-)affinity & pod (anti-)affinity.
> 3. Record the test files in k8shim.
> 4. Record the random seed used in test & results & charts in Yunikorn-site.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org
For additional commands, e-mail: dev-h...@yunikorn.apache.org



[jira] [Created] (YUNIKORN-2527) Allow remove and re-add configured queue within cleanup time

2024-04-02 Thread Wilfred Spiegelenburg (Jira)
Wilfred Spiegelenburg created YUNIKORN-2527:
---

 Summary: Allow remove and re-add configured queue within cleanup 
time 
 Key: YUNIKORN-2527
 URL: https://issues.apache.org/jira/browse/YUNIKORN-2527
 Project: Apache YuniKorn
  Issue Type: Bug
  Components: core - common
Reporter: Wilfred Spiegelenburg
Assignee: Wilfred Spiegelenburg


When we remove a queue from the config it is marked for cleanup. If we re-add 
the same queue in the config again before the cleanup gets executed the queue 
still gets removed.

reproduction:
 * edit config map remove a queue, save
 * immediately edit configmap add the same queue back, save
 * wait for the cleanup to happen



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org
For additional commands, e-mail: dev-h...@yunikorn.apache.org