[jira] [Resolved] (YUNIKORN-2590) Handler tests should check for nil request on create
[
https://issues.apache.org/jira/browse/YUNIKORN-2590?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chia-Ping Tsai resolved YUNIKORN-2590.
--
Fix Version/s: 1.6.0
Resolution: Fixed
> Handler tests should check for nil request on create
>
>
> Key: YUNIKORN-2590
> URL: https://issues.apache.org/jira/browse/YUNIKORN-2590
> Project: Apache YuniKorn
> Issue Type: Improvement
> Components: core - common, test - unit
>Reporter: Wilfred Spiegelenburg
>Assignee: Hsien-Cheng(Ryan) Huang
>Priority: Major
> Labels: newbie, pull-request-available
> Fix For: 1.6.0
>
>
> In the handler_test.go file we have an anti pattern showing a large number
> (40+) warnings in an IDE:
> {quote}'req' might have 'nil' or other unexpected value as its corresponding
> error variable might be not 'nil'
> {quote}
> The warning are due to the fact that we have the following pattern:
> {code:java}
> req, err = http.NewRequest("GET", "path", strings.NewReader(""))
> req = req.WithContext(context.WithValue(req.Context(), httprouter.ParamsKey,
> httprouter.Params{})){code}
> There is no error assertion after the request creation. We should add a
> simple {{assert.NilError(t, err, "HTTP request create failed")}} inserted
> between creating and using the request.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
-
To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org
For additional commands, e-mail: dev-h...@yunikorn.apache.org
[jira] [Resolved] (YUNIKORN-2620) Remove redundant variable `errorExpected` from configvalidator_test.go
[ https://issues.apache.org/jira/browse/YUNIKORN-2620?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Bacsko resolved YUNIKORN-2620. Fix Version/s: 1.6.0 Resolution: Fixed Merged to master. > Remove redundant variable `errorExpected` from configvalidator_test.go > -- > > Key: YUNIKORN-2620 > URL: https://issues.apache.org/jira/browse/YUNIKORN-2620 > Project: Apache YuniKorn > Issue Type: Improvement >Reporter: Chia-Ping Tsai >Assignee: Yun Sun >Priority: Minor > Labels: pull-request-available > Fix For: 1.6.0 > > > This is similar to YUNIKORN-2598. We can check the existent of `validateFunc` > instead of having a extra boolean flag. -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org For additional commands, e-mail: dev-h...@yunikorn.apache.org
[jira] [Created] (YUNIKORN-2622) /debug/pprof/symbol response is different from example response in docs
Hsien-Cheng(Ryan) Huang created YUNIKORN-2622: - Summary: /debug/pprof/symbol response is different from example response in docs Key: YUNIKORN-2622 URL: https://issues.apache.org/jira/browse/YUNIKORN-2622 Project: Apache YuniKorn Issue Type: Bug Components: documentation Reporter: Hsien-Cheng(Ryan) Huang Assignee: Hsien-Cheng(Ryan) Huang tested response on 1.5.1: num_symbols: 1 while doc: binary https://yunikorn.apache.org/docs/next/api/system/#success-response-9 -- This message was sent by Atlassian Jira (v8.20.10#820010) - To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org For additional commands, e-mail: dev-h...@yunikorn.apache.org
Re: [VOTE] Release Apache YuniKorn 1.5.1 RC1
+1 (non-binding)
Testing environment: Ubuntu 24.04, go1.22.3 linux/amd64
*
e2e tests passed in kind 1.29.2, 1.28.7, 1.27.11
*
make test failed on core, others are fine
*
the root cause is parallel testing (2+ process try to bind port:9080, and one
of them raise an ERROR core.rest webservice/webservice.go:74 {"error": "listen
tcp :9080: bind: address already in use"})
*
by removing the --race flag to stop parallel testing, it passed.
*
It is unrelated to the prod environment, so it shouldn't be a release blocker
*
test all web APIs
*
run example spark job
best regards,
Hsien-Cheng(Ryan) Huang
From: Shravan Achar
Sent: May 11, 2024 12:55 AM
To: dev@yunikorn.apache.org
Subject: RE: [VOTE] Release Apache YuniKorn 1.5.1 RC1
+1 Approve
On 2024/05/10 08:40:22 Peter Bacsko wrote:
> Hello everyone,
>
> I would like to call a vote for releasing Apache YuniKorn 1.5.1 RC1.
> This is a minor release which contains only bugfixes.
>
> The release artefacts have been uploaded here:
> https://dist.apache.org/repos/dist/dev/yunikorn/1.5.1-RC1/
>
> My public key is located in the KEYS file:
> https://downloads.apache.org//yunikorn/KEYS
>
> JIRA issues that have been resolved in this release:
>https://issues.apache.org/jira/issues/?filter=12353383
>
> The release solves a deadlock issue. If possible, test Yunikorn with
> workloads that put Yunikorn under stress (ie. thousands/tens of thousands
> of pods).
>
> Git tags for each component are as follows:
> yunikorn-scheduler-interface: v1.5.1-1
> yunikorn-core: v1.5.1-1
> yunikorn-k8shim: v1.5.1-1
> yunikorn-web: v1.5.1-1
> yunikorn-release: v1.5.1-1
>
> Once the release is voted on and approved, all repos will be tagged
> 1.5.1 for consistency.
>
> Please review and vote. The vote will be open for at least 96 hours
> and closes on Tuesday 14 May 2024, 20:00:00 CEST.
>
> [ ] +1 Approve
> [ ] +0 No opinion
> [ ] -1 Disapprove (and the reason why)
>
>
> Thank you,
> Peter
>
-
To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org
For additional commands, e-mail: dev-h...@yunikorn.apache.org
