[jira] [Resolved] (YUNIKORN-2624) Enable hotlinking to YuniKorn

2024-06-03 Thread Kuan Po Tseng (Jira)


 [ 
https://issues.apache.org/jira/browse/YUNIKORN-2624?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kuan Po Tseng resolved YUNIKORN-2624.
-
 Fix Version/s: 1.6.0
Target Version: 1.6.0
Resolution: Resolved

merged to master, thanks [~denis.coric] !

> Enable hotlinking to YuniKorn
> -
>
> Key: YUNIKORN-2624
> URL: https://issues.apache.org/jira/browse/YUNIKORN-2624
> Project: Apache YuniKorn
>  Issue Type: Sub-task
>  Components: webapp
>Reporter: Denis Coric
>Assignee: Denis Coric
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.6.0
>
>
> Enable third-party apps to set links to YuniKorn that will populate partition 
> and queue and application ID using the query parameters.
> Queue, Partition, and Application ID should be pre-selected and all details 
> shown on the page using the existing details view and stored in the 
> application storage using the existing functionality. 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org
For additional commands, e-mail: dev-h...@yunikorn.apache.org



[jira] [Created] (YUNIKORN-2661) Fix hard-coded boolean in setLimit

2024-06-03 Thread Peter Bacsko (Jira)
Peter Bacsko created YUNIKORN-2661:
--

 Summary: Fix hard-coded boolean in setLimit
 Key: YUNIKORN-2661
 URL: https://issues.apache.org/jira/browse/YUNIKORN-2661
 Project: Apache YuniKorn
  Issue Type: Bug
  Components: core - scheduler
Reporter: Peter Bacsko
Assignee: Peter Bacsko


Inside the UGM code {{setLimit()}}, we don't pass down {{doWildcardCheck}}, so 
this variables never reaches the leafs:

{noformat}
/ Note: Lock free call. The Lock of the linked tracker (UserTracker and 
GroupTracker) should be held before calling this function.
func (qt *QueueTracker) setLimit(hierarchy []string, maxResource 
*resources.Resource, maxApps uint64, useWildCard bool, trackType trackingType, 
doWildCardCheck bool) {
log.Log(log.SchedUGM).Debug("Setting limits",
zap.String("queue path", qt.queuePath),
zap.Strings("hierarchy", hierarchy),
zap.Uint64("max applications", maxApps),
zap.Stringer("max resources", maxResource),
zap.Bool("use wild card", useWildCard))
// depth first: all the way to the leaf, create if not exists
// more than 1 in the slice means we need to recurse down
if len(hierarchy) > 1 {
childName := hierarchy[1]
if qt.childQueueTrackers[childName] == nil {
qt.childQueueTrackers[childName] = 
newQueueTracker(qt.queuePath, childName, trackType)
}
qt.childQueueTrackers[childName].setLimit(hierarchy[1:], 
maxResource, maxApps, useWildCard, trackType, false)
...
{noformat}

Fix this and create a unit test for {{setLimit()}}.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

-
To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org
For additional commands, e-mail: dev-h...@yunikorn.apache.org