[ https://issues.apache.org/jira/browse/YUNIKORN-2583?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Peter Bacsko resolved YUNIKORN-2583. ------------------------------------ Resolution: Won't Do > Possible log spew on DEBUG level from objects.Node > -------------------------------------------------- > > Key: YUNIKORN-2583 > URL: https://issues.apache.org/jira/browse/YUNIKORN-2583 > Project: Apache YuniKorn > Issue Type: Bug > Components: core - common > Reporter: Peter Bacsko > Assignee: Peter Bacsko > Priority: Major > Labels: pull-request-available > > When a predicate fails for a given node, we print a message on DEBUG level. > The problem is, we keep doing this in every scheduling cycle, flooding the > logs: > {noformat} > 2024-04-17T21:32:19.446Z DEBUG core.scheduler.node objects/node.go:403 > running predicates failed {"allocationKey": > "2be04314-bed0-4385-9ae7-50ed0ef9d9d5", "nodeID": "kwok-node-zzn7w", > "allocateFlag": true, "error": "predicates were not running because pod or > node was not found in cache"} > 2024-04-17T21:33:24.417Z DEBUG core.scheduler.node objects/node.go:403 > running predicates failed {"allocationKey": > "2be04314-bed0-4385-9ae7-50ed0ef9d9d5", "nodeID": "kwok-node-zzn7w", > "allocateFlag": true, "error": "predicates were not running because pod or > node was not found in cache"} > 2024-04-17T21:33:24.417Z DEBUG core.scheduler.node objects/node.go:403 > running predicates failed {"allocationKey": > "2be04314-bed0-4385-9ae7-50ed0ef9d9d5", "nodeID": "kwok-node-zzn7w", > "allocateFlag": true, "error": "predicates were not running because pod or > node was not found in cache"} > {noformat} > Another problematic part is {{preAllocateCheck()}} we have an allocation ask > with a zero resource: > {noformat} > unc (sn *Node) preAllocateCheck(res *resources.Resource, resKey string) bool { > // cannot allocate zero or negative resource > if !resources.StrictlyGreaterThanZero(res) { > log.Log(log.SchedNode).Debug("pre alloc check: requested > resource is zero", > zap.String("nodeID", sn.NodeID)) <-- will be printed > from every node > return false > } > ... > {noformat} > We need to reduce the amount of output with RateLimitedLogger. -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@yunikorn.apache.org For additional commands, e-mail: dev-h...@yunikorn.apache.org