[GitHub] zeppelin pull request #1484: [branch-0.6] Take care of comma/tab escape in c...

[minahlee]

Github user minahlee closed the pull request at:

https://github.com/apache/zeppelin/pull/1484


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1486: [ZEPPELIN-1518] Fix for: Lambda expressions are not wo...

[minahlee]

Github user minahlee commented on the issue:

https://github.com/apache/zeppelin/pull/1486
  
Tested, it fixes the bug. Btw do we need this patch only in branch-0.6 not 
to master?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1441: [ ZEPPELIN-967 ] Implement search bar in job manager

[cloverhearts]

Github user cloverhearts commented on the issue:

https://github.com/apache/zeppelin/pull/1441
  
@corneadoug 
sorry, could you please review for this pr?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1461: [MINOR] Rearrange the contents in "About Zeppelin"

[AhyoungRyu]

Github user AhyoungRyu commented on the issue:

https://github.com/apache/zeppelin/pull/1461
  
@corneadoug Thanks! I retriggered CI just for sure. After checking CI then 
will merge this :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1491: Fix version of cachebust

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/zeppelin/pull/1491


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1461: [MINOR] Rearrange the contents in "About Zeppelin"

[corneadoug]

Github user corneadoug commented on the issue:

https://github.com/apache/zeppelin/pull/1461
  
@AhyoungRyu Tested, LGTM!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1491: Fix version of cachebust

[khalidhuseynov]

Github user khalidhuseynov commented on the issue:

https://github.com/apache/zeppelin/pull/1491
  
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1489: ZEPPELIN-1321 Zeppelin HTTP and HTTPS port should be m...

[Leemoonsoo]

Github user Leemoonsoo commented on the issue:

https://github.com/apache/zeppelin/pull/1489
  
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1488: [ZEPPELIN-1519] Fix notebook importer AM/PM omission p...

[Leemoonsoo]

Github user Leemoonsoo commented on the issue:

https://github.com/apache/zeppelin/pull/1488
  
Thanks. LGTM and merge if there're no more discussions.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1490: [ZEPPELIN-1480] Blocking message pending 10000 for BLO...

[Leemoonsoo]

Github user Leemoonsoo commented on the issue:

https://github.com/apache/zeppelin/pull/1490
  
@corneadoug i commented translation on the issue.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1490: [ZEPPELIN-1480] Blocking message pending 10000 ...

[Leemoonsoo]

GitHub user Leemoonsoo reopened a pull request:

https://github.com/apache/zeppelin/pull/1490

[ZEPPELIN-1480] Blocking message pending 1 for BLOCKING

### What is this PR for?
This patch try to address problem described in ZEPPELIN-1480


### What type of PR is it?
Bug Fix

### Todos
* [x] - Make websocket send thread safe

### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-1480

### How should this be tested?
Create multiple paragraphs (for example 10 ```%sh date``` paragraphs) and 
schedule it every 10sec `0/10 * * * * ?`

### Screenshots (if appropriate)

### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/Leemoonsoo/zeppelin ZEPPELIN-1480

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/1490.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1490


commit 0b607435303d85058f73cfe443e5a94d03c7e82e
Author: Lee moon soo 
Date:   2016-10-05T23:01:26Z

make websocket send threadsafe




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1490: [ZEPPELIN-1480] Blocking message pending 10000 ...

[Leemoonsoo]

Github user Leemoonsoo closed the pull request at:

https://github.com/apache/zeppelin/pull/1490


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1491: Fix version of cachebust

[corneadoug]

GitHub user corneadoug reopened a pull request:

https://github.com/apache/zeppelin/pull/1491

Fix version of cachebust

### What is this PR for?
A dependency update of grunt-cache-bust is breaking the build.
https://github.com/hollandben/grunt-cache-bust/issues/204
So fixing the dependency version


### What type of PR is it?
Hot Fix

### Screenshot (before)
![screen shot 2016-10-06 at 12 22 40 
pm](https://cloud.githubusercontent.com/assets/710411/19139450/bcad1494-8bbf-11e6-8b22-b9344055e876.png)

### How should this be tested?
Clean your repo, and do mvn package in zeppelin-web

### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/corneadoug/incubator-zeppelin fix/cacheBust

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/1491.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1491


commit 81e26a5f508b5e389d0cc5d102d0083f81d3f1dc
Author: Damien CORNEAU 
Date:   2016-10-06T02:56:34Z

Fix version of cachebust




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1363: [ZEPPELIN-1371]add text/numeric conversion support to ...

[corneadoug]

Github user corneadoug commented on the issue:

https://github.com/apache/zeppelin/pull/1363
  
@Peilin-Yang Yes, you will need to rebase first though


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #133: [ZEPPELIN-127] Fix issue raised by ZEPPELIN-127 related...

[Leemoonsoo]

Github user Leemoonsoo commented on the issue:

https://github.com/apache/zeppelin/pull/133
  
@doanduyhai I see. Thanks for the explanation.

Current master branch works with both scala-2.10 and scala-2.11 without 
rebuild, depending on which version of spark SPARK_HOME points. is displayUtils 
works in this way, too?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1471: Closes [ZEPPELIN-1505] Add Scio interpreter

[ravwojdyla]

Github user ravwojdyla commented on the issue:

https://github.com/apache/zeppelin/pull/1471
  
@AhyoungRyu sorry I missed it. Will go ahead and add all the licenses. 
Thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1479: Notebook: HDFS as a backend storage (Read & Write Mode...

[hayssams]

Github user hayssams commented on the issue:

https://github.com/apache/zeppelin/pull/1479
  
@Leemoonsoo  Just pushed the changes to make hadoop lib provided.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1363: [ZEPPELIN-1371]add text/numeric conversion support to ...

[Peilin-Yang]

Github user Peilin-Yang commented on the issue:

https://github.com/apache/zeppelin/pull/1363
  
@corneadoug merged your PR.
Do you think now it is the good time to merge this one?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1487: [ZEPPELIN-1520] Test with the local mode of Apache Spa...

[jongyoul]

Github user jongyoul commented on the issue:

https://github.com/apache/zeppelin/pull/1487
  
Ready to review


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1489: ZEPPELIN-1321 Zeppelin HTTP and HTTPS port should be m...

[r-kamath]

Github user r-kamath commented on the issue:

https://github.com/apache/zeppelin/pull/1489
  
@Leemoonsoo 8f9006a


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #133: [ZEPPELIN-127] Fix issue raised by ZEPPELIN-127 related...

[doanduyhai]

Github user doanduyhai commented on the issue:

https://github.com/apache/zeppelin/pull/133
  
@Leemoonsoo 

Yes we do need this patch because `DisplayUtils` has been disabled 
temporarily because of the issue it causes. This patch fixes the issue and 
re-enable `DisplayUtils`


![image](https://cloud.githubusercontent.com/assets/1532977/19117234/973368e6-8b18-11e6-9dcf-7a4796751290.png)



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #133: [ZEPPELIN-127] Fix issue raised by ZEPPELIN-127 related...

[Leemoonsoo]

Github user Leemoonsoo commented on the issue:

https://github.com/apache/zeppelin/pull/133
  
master branch runs 
```
val wbIPR=Array(8.40,  8.09,  7.56,  6.83,  5.88,  
4.72,  3.36,  1.78,  0.0)
val 
pressureIPR=Array(0.00,1000.00,2000.00,3000.00,4000.00,5000.00,6000.00,7000.00,8000.00)
case class IPR (w:Array[Double],p:Array[Double])
val iprInit=IPR(wbIPR,pressureIPR)
val iprList=sc.parallelize((1.0 to 0.9 by -0.001).map(k => 
IPR(iprInit.w.map(_ * k), iprInit.p)).zipWithIndex,5)
iprList.count()
```
with out this patch. Do we still need this patch?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1479: Notebook: HDFS as a backend storage (Read & Write Mode...

[Leemoonsoo]

Github user Leemoonsoo commented on the issue:

https://github.com/apache/zeppelin/pull/1479
  
Thanks for the contribution.

How about let user set not only `HADOOP_CONF_DIR` but also `HADOOP_HOME` in 
conf/zeppelin-env.sh to use HDFS notebook storage?

Then hadoop dependencies in zeppelin-zengine can be provided scope, and 
that'll reduce binary package size. Also that'll allow user set different 
hadoop version without rebuild.

what do you think?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1489: ZEPPELIN-1321 Zeppelin HTTP and HTTPS port should be m...

[prabhjyotsingh]

Github user prabhjyotsingh commented on the issue:

https://github.com/apache/zeppelin/pull/1489
  
Tested on local, LGTM.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1483: [ZEPPELIN-1509] Run certain SparkInterpreter tests onl...

[prabhjyotsingh]

Github user prabhjyotsingh commented on the issue:

https://github.com/apache/zeppelin/pull/1483
  
nice ! LGTM.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1483: [ZEPPELIN-1509] Run certain SparkInterpreter tests onl...

[Leemoonsoo]

Github user Leemoonsoo commented on the issue:

https://github.com/apache/zeppelin/pull/1483
  
LGTM!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1484: [branch-0.6] Take care of comma/tab escape in csv/tsv ...

[Leemoonsoo]

Github user Leemoonsoo commented on the issue:

https://github.com/apache/zeppelin/pull/1484
  
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1486: [ZEPPELIN-1518] Fix for: Lambda expressions are not wo...

[Leemoonsoo]

Github user Leemoonsoo commented on the issue:

https://github.com/apache/zeppelin/pull/1486
  
Thanks @mvitaly for the contribution!

Looks good to me!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1483: [ZEPPELIN-1509] Run certain SparkInterpreter tests onl...

[astroshim]

Github user astroshim commented on the issue:

https://github.com/apache/zeppelin/pull/1483
  
@minahlee Thank you for your effort!! :+1: 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1489: ZEPPELIN-1321 Zeppelin HTTP and HTTPS port should be m...

[r-kamath]

Github user r-kamath commented on the issue:

https://github.com/apache/zeppelin/pull/1489
  
@Leemoonsoo sure. will update.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1489: ZEPPELIN-1321 Zeppelin HTTP and HTTPS port should be m...

[Leemoonsoo]

Github user Leemoonsoo commented on the issue:

https://github.com/apache/zeppelin/pull/1489
  
Shell we have an entry for this change in [upgrading 
section](https://github.com/apache/zeppelin/blob/master/docs/install/upgrade.md#upgrading-from-zeppelin-06-to-07)?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1489: ZEPPELIN-1321 Zeppelin HTTP and HTTPS port should be m...

[r-kamath]

Github user r-kamath commented on the issue:

https://github.com/apache/zeppelin/pull/1489
  
Travis failure is unrelated and only on one of the build profile



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Created] (ZEPPELIN-1522) Not correct (change) display of the height of diagram in IE

[Ivan Savin (JIRA)]

Ivan Savin created ZEPPELIN-1522:


 Summary: Not correct (change) display of the height of diagram in 
IE
 Key: ZEPPELIN-1522
 URL: https://issues.apache.org/jira/browse/ZEPPELIN-1522
 Project: Zeppelin
  Issue Type: Bug
  Components: front-end
Affects Versions: 0.7.0
Reporter: Ivan Savin


I modify my diagram using Firefox. When I see the result in IE, it is very 
narrow. But it is OK (the same size) in Chrome



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (ZEPPELIN-1521) Not correct display of the lower axe in Chrome

[Ivan Savin (JIRA)]

Ivan Savin created ZEPPELIN-1521:


 Summary: Not correct display of the lower axe in Chrome
 Key: ZEPPELIN-1521
 URL: https://issues.apache.org/jira/browse/ZEPPELIN-1521
 Project: Zeppelin
  Issue Type: Bug
  Components: python-interpreter
Affects Versions: 0.7.0
Reporter: Ivan Savin


For display data on picture, I give DataFrame with string column mon-YY (e.g. 
jan-16) to Zeppelin (z.show).
It is correct In Firefox and IE, but Chrome adds strange TimeStamp nubmber.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] zeppelin pull request #1489: ZEPPELIN-1321 Zeppelin HTTP and HTTPS port shou...

[r-kamath]

GitHub user r-kamath opened a pull request:

https://github.com/apache/zeppelin/pull/1489

ZEPPELIN-1321 Zeppelin HTTP and HTTPS port should be managed seperately

### What is this PR for?
Use a different variable for ssl port number
- add new property for ssl port

### What type of PR is it?
Improvement

### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-1321

### How should this be tested?
Add ZEPPELIN_SSL_PORT or  zeppelin.server.ssl.port in zeppelin env or site 
xml and configure the rest of ssl properties and start zeppelin.

### Screenshots (if appropriate)
n/a

### Questions:
* Does the licenses files need update? n/a
* Is there breaking changes for older versions? n/a
* Does this needs documentation? Updated install doc

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/r-kamath/zeppelin ZEPPELIN-1321

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/1489.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1489


commit 41899b15e04b7f9468cb09177d24edd6978057b5
Author: Renjith Kamath 
Date:   2016-10-05T09:15:13Z

ZEPPELIN-1321 Zeppelin HTTP and HTTPS port should be managed seperately

- add new property for ssl port




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1488: [ZEPPELIN-1519] Fix notebook importer AM/PM omi...

[sixmen]

GitHub user sixmen opened a pull request:

https://github.com/apache/zeppelin/pull/1488

[ZEPPELIN-1519] Fix notebook importer AM/PM omission problem

### What is this PR for?
When loading note from storage (or importing note), AM/PM informations are 
gone. So dates are always in AM.
Fix this problem.

### What type of PR is it?
Bug Fix

### Todos

### What is the Jira issue?
* https://issues.apache.org/jira/browse/ZEPPELIN-1519

### How should this be tested?
Do some changes on sample notebooks, and see file changes.

### Screenshots (if appropriate)

### Questions:
* Does the licenses files need update? NO
* Is there breaking changes for older versions? NO
* Does this needs documentation? NO



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/sixmen/zeppelin fix-date-import

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/1488.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1488


commit 833e5126f9c96b15b090388d327aef5e94b0e6fb
Author: Sangmin Yoon 
Date:   2016-10-05T08:58:02Z

fix notebook importer AM/PM omission problem




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1441: [ ZEPPELIN-967 ] Implement search bar in job manager

[cloverhearts]

Github user cloverhearts commented on the issue:

https://github.com/apache/zeppelin/pull/1441
  
code rebase


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Refactor time !

[Jungtaek Lim]

Hi Jongyoul,

I strongly agree that changing requirement of JDK version is definitely
breaking change. May be better to treat it to separate issue.
I just think it's good food for thought, not meant to do it now. If
Zeppelin project plans to have major version (1.0.0 finally), that would be
a chance to do it.

2016년 10월 5일 (수) 오후 4:25, Jongyoul Lee 님이 작성:

> Hello Jungtaek,
>
> I agree that it's relatively easy to run Zeppelin with JDK 8 because
> Zeppelin is not linked with another project directly. But as you told, it
> bothers admin or system engineer, sometimes it's impossible for some
> reasons. Thus personally, we should keep backward compatibility.
>
> On Wed, Oct 5, 2016 at 4:05 PM, Jungtaek Lim  wrote:
>
> > I also think there's also many places to use old version of JDK in
> > production. But unlike library projects, Zeppelin doesn't become
> dependency
> > of other projects, so no need to consider other projects and also users'
> > own projects, which greatly lowers the barrier.
> > Installing JDK/JRE 8 and using it from Zeppelin doesn't harm their
> business
> > logic and projects since users can maintain multiple version of JVMs
> > anyway. (yes it could be bothering but possible to do... :) )
> >
> > We just need to consider compatibility of existing interpreters, and user
> > codes which will be run in interpreters.
> >
> > - Jungtaek Lim (HeartSaVioR)
> >
> > 2016년 10월 5일 (수) 오후 3:51, Jongyoul Lee 님이 작성:
> >
> > > Hello,
> > >
> > > Concerning JDK, I mean it, too. In production level, it may be hard to
> > > change it.
> > >
> > > On Wed, Oct 5, 2016 at 3:36 PM, DuyHai Doan 
> > wrote:
> > >
> > > > > "Concerning #2, Zeppelin's backend has a lot of map and the map has
> > > > mutable states. Thus we should also think of read-write-lock."
> > > >
> > > > Agree, the impl of ConcurrentHashMap deals with this by splitting the
> > > > internal map into buckets and the access to each bucket is
> synchronized
> > > so
> > > > that if you have 2 concurrent operations on the map and they fall
> into
> > > > different buckets it doesn't incur any lock
> > > >
> > > > For List, the CopyOnWriteArrayList is expensive on write because it
> > > copies
> > > > the content of the list for each mutation. But this impl makes the
> > > > assumption that the read ratio is much higher than the write ratio.
> > > >
> > > > Etc ... We need to check on case by case basis which impl is the best
> > > >
> > > > > "Personally, moving to Java8 is very attractive but we divide it
> with
> > > > others because upgrading to the version of JDK influences users'
> > > > experiences."
> > > >
> > > > Upgrading to Java 8 would require users to upgrade JDK server-side
> > only,
> > > > what is the impact on user experience ?
> > > >
> > > > On Wed, Oct 5, 2016 at 8:08 AM, Jongyoul Lee 
> > wrote:
> > > >
> > > > > Thanks for starting this thread.
> > > > >
> > > > > Concerning #2, Zeppelin's backend has a lot of map and the map has
> > > > mutable
> > > > > states. Thus we should also think of read-write-lock.
> > > > >
> > > > > Personally, moving to Java8 is very attractive but we divide it
> with
> > > > others
> > > > > because upgrading to the version of JDK influences users'
> > experiences.
> > > > >
> > > > > On Wed, Oct 5, 2016 at 11:28 AM, Anthony Corbacho <
> > > > > anthonycorba...@apache.org> wrote:
> > > > >
> > > > > > I think about the abuse of @Inject and circular deps, it is just
> > > matter
> > > > > of
> > > > > > education.
> > > > > >
> > > > > > On Tue, Oct 4, 2016 at 8:05 PM, DuyHai Doan <
> doanduy...@gmail.com>
> > > > > wrote:
> > > > > >
> > > > > > > About DI I have no strong opinion on the topic.
> > > > > > >
> > > > > > > I have coded frameworks with just manual DI (through
> constructor
> > > and
> > > > > > > context objects) and it works pretty well, even for a big
> > project,
> > > as
> > > > > > long
> > > > > > > as the context objects have meaningfull names
> > > > > > >
> > > > > > > Using DI frameworks like Spring or Guice is also a valid
> choice,
> > > > > > especially
> > > > > > > for a backend. The only thing to be really cautious about are
> > > > circular
> > > > > > > dependencies. Using @Inject is very easy and people tend to
> abuse
> > > it
> > > > > > > everywhere and end up with horrible cyclic dependencies
> > > > > > >
> > > > > > >
> > > > > > >
> > > > > > > On Tue, Oct 4, 2016 at 12:54 PM, Anthony Corbacho <
> > > > > > > anthonycorba...@apache.org> wrote:
> > > > > > >
> > > > > > > > You made my day, this is the kind of email i really like !!
> > > > > > > >
> > > > > > > > I think its a great idea and i am willing to spend sometime
> on
> > > it.
> > > > > > > >
> > > > > > > > I also want to move to a DI (guice) architecture , let me
> know
> > > what
> > > > > you
> > > > > > > > think about it.
> > > > > > > >
> > > > > > > > On Tuesday, 4 October 2016, DuyHai 

Re: Refactor time !

[Jungtaek Lim]

I also think there's also many places to use old version of JDK in
production. But unlike library projects, Zeppelin doesn't become dependency
of other projects, so no need to consider other projects and also users'
own projects, which greatly lowers the barrier.
Installing JDK/JRE 8 and using it from Zeppelin doesn't harm their business
logic and projects since users can maintain multiple version of JVMs
anyway. (yes it could be bothering but possible to do... :) )

We just need to consider compatibility of existing interpreters, and user
codes which will be run in interpreters.

- Jungtaek Lim (HeartSaVioR)

2016년 10월 5일 (수) 오후 3:51, Jongyoul Lee 님이 작성:

> Hello,
>
> Concerning JDK, I mean it, too. In production level, it may be hard to
> change it.
>
> On Wed, Oct 5, 2016 at 3:36 PM, DuyHai Doan  wrote:
>
> > > "Concerning #2, Zeppelin's backend has a lot of map and the map has
> > mutable states. Thus we should also think of read-write-lock."
> >
> > Agree, the impl of ConcurrentHashMap deals with this by splitting the
> > internal map into buckets and the access to each bucket is synchronized
> so
> > that if you have 2 concurrent operations on the map and they fall into
> > different buckets it doesn't incur any lock
> >
> > For List, the CopyOnWriteArrayList is expensive on write because it
> copies
> > the content of the list for each mutation. But this impl makes the
> > assumption that the read ratio is much higher than the write ratio.
> >
> > Etc ... We need to check on case by case basis which impl is the best
> >
> > > "Personally, moving to Java8 is very attractive but we divide it with
> > others because upgrading to the version of JDK influences users'
> > experiences."
> >
> > Upgrading to Java 8 would require users to upgrade JDK server-side only,
> > what is the impact on user experience ?
> >
> > On Wed, Oct 5, 2016 at 8:08 AM, Jongyoul Lee  wrote:
> >
> > > Thanks for starting this thread.
> > >
> > > Concerning #2, Zeppelin's backend has a lot of map and the map has
> > mutable
> > > states. Thus we should also think of read-write-lock.
> > >
> > > Personally, moving to Java8 is very attractive but we divide it with
> > others
> > > because upgrading to the version of JDK influences users' experiences.
> > >
> > > On Wed, Oct 5, 2016 at 11:28 AM, Anthony Corbacho <
> > > anthonycorba...@apache.org> wrote:
> > >
> > > > I think about the abuse of @Inject and circular deps, it is just
> matter
> > > of
> > > > education.
> > > >
> > > > On Tue, Oct 4, 2016 at 8:05 PM, DuyHai Doan 
> > > wrote:
> > > >
> > > > > About DI I have no strong opinion on the topic.
> > > > >
> > > > > I have coded frameworks with just manual DI (through constructor
> and
> > > > > context objects) and it works pretty well, even for a big project,
> as
> > > > long
> > > > > as the context objects have meaningfull names
> > > > >
> > > > > Using DI frameworks like Spring or Guice is also a valid choice,
> > > > especially
> > > > > for a backend. The only thing to be really cautious about are
> > circular
> > > > > dependencies. Using @Inject is very easy and people tend to abuse
> it
> > > > > everywhere and end up with horrible cyclic dependencies
> > > > >
> > > > >
> > > > >
> > > > > On Tue, Oct 4, 2016 at 12:54 PM, Anthony Corbacho <
> > > > > anthonycorba...@apache.org> wrote:
> > > > >
> > > > > > You made my day, this is the kind of email i really like !!
> > > > > >
> > > > > > I think its a great idea and i am willing to spend sometime on
> it.
> > > > > >
> > > > > > I also want to move to a DI (guice) architecture , let me know
> what
> > > you
> > > > > > think about it.
> > > > > >
> > > > > > On Tuesday, 4 October 2016, DuyHai Doan 
> > > wrote:
> > > > > >
> > > > > > > Hello devs
> > > > > > >
> > > > > > > The code base of Zeppelin has grown very fast in the last 12
> > months
> > > > and
> > > > > > > it's great. It means that we have more and more contributors.
> > > > > > >
> > > > > > > However, to make the project maintainable at long term, we need
> > > > regular
> > > > > > > code refactoring.
> > > > > > >
> > > > > > > I have some ideas to share with you
> > > > > > >
> > > > > > > 1) Use Java 8 to benefit from Lambda & streams.
> > > > > > >
> > > > > > >   Now that Java 8 is well established, it is a good time to
> > upgrade
> > > > the
> > > > > > > project. I believe some interpreters also need Java 8.
> Cassandra
> > > > > > > interpreter right now does not have unit tests for the latest
> > > > features
> > > > > > > because the Embedded Cassandra server used for testing requires
> > > Java
> > > > 8.
> > > > > > >
> > > > > > >  It would also be a good opportunity to go through the code
> base
> > > and
> > > > > > > replace some boilerplate for() loop with manual filtering by
> the
> > > > stream
> > > > > > > shortcut :  list.stream().filter(..).map(). It would improve

Re: Refactor time !

[Jongyoul Lee]

Hello,

Concerning JDK, I mean it, too. In production level, it may be hard to
change it.

On Wed, Oct 5, 2016 at 3:36 PM, DuyHai Doan  wrote:

> > "Concerning #2, Zeppelin's backend has a lot of map and the map has
> mutable states. Thus we should also think of read-write-lock."
>
> Agree, the impl of ConcurrentHashMap deals with this by splitting the
> internal map into buckets and the access to each bucket is synchronized so
> that if you have 2 concurrent operations on the map and they fall into
> different buckets it doesn't incur any lock
>
> For List, the CopyOnWriteArrayList is expensive on write because it copies
> the content of the list for each mutation. But this impl makes the
> assumption that the read ratio is much higher than the write ratio.
>
> Etc ... We need to check on case by case basis which impl is the best
>
> > "Personally, moving to Java8 is very attractive but we divide it with
> others because upgrading to the version of JDK influences users'
> experiences."
>
> Upgrading to Java 8 would require users to upgrade JDK server-side only,
> what is the impact on user experience ?
>
> On Wed, Oct 5, 2016 at 8:08 AM, Jongyoul Lee  wrote:
>
> > Thanks for starting this thread.
> >
> > Concerning #2, Zeppelin's backend has a lot of map and the map has
> mutable
> > states. Thus we should also think of read-write-lock.
> >
> > Personally, moving to Java8 is very attractive but we divide it with
> others
> > because upgrading to the version of JDK influences users' experiences.
> >
> > On Wed, Oct 5, 2016 at 11:28 AM, Anthony Corbacho <
> > anthonycorba...@apache.org> wrote:
> >
> > > I think about the abuse of @Inject and circular deps, it is just matter
> > of
> > > education.
> > >
> > > On Tue, Oct 4, 2016 at 8:05 PM, DuyHai Doan 
> > wrote:
> > >
> > > > About DI I have no strong opinion on the topic.
> > > >
> > > > I have coded frameworks with just manual DI (through constructor and
> > > > context objects) and it works pretty well, even for a big project, as
> > > long
> > > > as the context objects have meaningfull names
> > > >
> > > > Using DI frameworks like Spring or Guice is also a valid choice,
> > > especially
> > > > for a backend. The only thing to be really cautious about are
> circular
> > > > dependencies. Using @Inject is very easy and people tend to abuse it
> > > > everywhere and end up with horrible cyclic dependencies
> > > >
> > > >
> > > >
> > > > On Tue, Oct 4, 2016 at 12:54 PM, Anthony Corbacho <
> > > > anthonycorba...@apache.org> wrote:
> > > >
> > > > > You made my day, this is the kind of email i really like !!
> > > > >
> > > > > I think its a great idea and i am willing to spend sometime on it.
> > > > >
> > > > > I also want to move to a DI (guice) architecture , let me know what
> > you
> > > > > think about it.
> > > > >
> > > > > On Tuesday, 4 October 2016, DuyHai Doan 
> > wrote:
> > > > >
> > > > > > Hello devs
> > > > > >
> > > > > > The code base of Zeppelin has grown very fast in the last 12
> months
> > > and
> > > > > > it's great. It means that we have more and more contributors.
> > > > > >
> > > > > > However, to make the project maintainable at long term, we need
> > > regular
> > > > > > code refactoring.
> > > > > >
> > > > > > I have some ideas to share with you
> > > > > >
> > > > > > 1) Use Java 8 to benefit from Lambda & streams.
> > > > > >
> > > > > >   Now that Java 8 is well established, it is a good time to
> upgrade
> > > the
> > > > > > project. I believe some interpreters also need Java 8. Cassandra
> > > > > > interpreter right now does not have unit tests for the latest
> > > features
> > > > > > because the Embedded Cassandra server used for testing requires
> > Java
> > > 8.
> > > > > >
> > > > > >  It would also be a good opportunity to go through the code base
> > and
> > > > > > replace some boilerplate for() loop with manual filtering by the
> > > stream
> > > > > > shortcut :  list.stream().filter(..).map(). It would improve
> > greatly
> > > > > code
> > > > > > readability
> > > > > >
> > > > > > 2) Multi threading
> > > > > >
> > > > > >  I've seen the usage of synchronize block at a few places in the
> > code
> > > > > base.
> > > > > > Although perfectly valid, it has a cost at runtime and since more
> > and
> > > > > more
> > > > > > people are asking for multi-tenancy or using a single Zeppelin
> > > instance
> > > > > to
> > > > > > server multiple users, I guess the synchronized blocks has a huge
> > > cost.
> > > > > >
> > > > > > There are some solid alternatives:
> > > > > >
> > > > > >  - ConcurrentHashMap if we synchronized on a map
> > > > > >  - CopyOnWriteArrayList if we synchronized on a list.
> > > > > >
> > > > > > Of cours each sychronize block should be taken carefully not to
> > > > introduce
> > > > > > regression
> > > > > >
> > > > > > 3) Thread management
> > > > > >
> > > > > > I've seen some usage of 

[GitHub] zeppelin pull request #1487: [WIP] [ZEPPELIN-1520] Test with the local mode ...

[jongyoul]

GitHub user jongyoul opened a pull request:

https://github.com/apache/zeppelin/pull/1487

[WIP] [ZEPPELIN-1520] Test with the local mode of Apache Spark

### What is this PR for?
Simplify travis test to reduce usage of resources

### What type of PR is it?
[Improvement]

### Todos
* [] - Remove start-up/stop SparkCluster

### What is the Jira issue?
* https://issues.apache.org/jira/browse/ZEPPELIN-1520

### How should this be tested?
Travis will pass without any error

### Screenshots (if appropriate)

### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/jongyoul/zeppelin ZEPPELIN-1520

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/1487.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1487


commit 2aac444a0681a4402ec84dc9b8ac9832395230e0
Author: Jongyoul Lee 
Date:   2016-10-05T06:46:07Z

Remove scripts of start/stop SparkCluster




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Refactor time !

[DuyHai Doan]

> "Concerning #2, Zeppelin's backend has a lot of map and the map has
mutable states. Thus we should also think of read-write-lock."

Agree, the impl of ConcurrentHashMap deals with this by splitting the
internal map into buckets and the access to each bucket is synchronized so
that if you have 2 concurrent operations on the map and they fall into
different buckets it doesn't incur any lock

For List, the CopyOnWriteArrayList is expensive on write because it copies
the content of the list for each mutation. But this impl makes the
assumption that the read ratio is much higher than the write ratio.

Etc ... We need to check on case by case basis which impl is the best

> "Personally, moving to Java8 is very attractive but we divide it with
others because upgrading to the version of JDK influences users'
experiences."

Upgrading to Java 8 would require users to upgrade JDK server-side only,
what is the impact on user experience ?

On Wed, Oct 5, 2016 at 8:08 AM, Jongyoul Lee  wrote:

> Thanks for starting this thread.
>
> Concerning #2, Zeppelin's backend has a lot of map and the map has mutable
> states. Thus we should also think of read-write-lock.
>
> Personally, moving to Java8 is very attractive but we divide it with others
> because upgrading to the version of JDK influences users' experiences.
>
> On Wed, Oct 5, 2016 at 11:28 AM, Anthony Corbacho <
> anthonycorba...@apache.org> wrote:
>
> > I think about the abuse of @Inject and circular deps, it is just matter
> of
> > education.
> >
> > On Tue, Oct 4, 2016 at 8:05 PM, DuyHai Doan 
> wrote:
> >
> > > About DI I have no strong opinion on the topic.
> > >
> > > I have coded frameworks with just manual DI (through constructor and
> > > context objects) and it works pretty well, even for a big project, as
> > long
> > > as the context objects have meaningfull names
> > >
> > > Using DI frameworks like Spring or Guice is also a valid choice,
> > especially
> > > for a backend. The only thing to be really cautious about are circular
> > > dependencies. Using @Inject is very easy and people tend to abuse it
> > > everywhere and end up with horrible cyclic dependencies
> > >
> > >
> > >
> > > On Tue, Oct 4, 2016 at 12:54 PM, Anthony Corbacho <
> > > anthonycorba...@apache.org> wrote:
> > >
> > > > You made my day, this is the kind of email i really like !!
> > > >
> > > > I think its a great idea and i am willing to spend sometime on it.
> > > >
> > > > I also want to move to a DI (guice) architecture , let me know what
> you
> > > > think about it.
> > > >
> > > > On Tuesday, 4 October 2016, DuyHai Doan 
> wrote:
> > > >
> > > > > Hello devs
> > > > >
> > > > > The code base of Zeppelin has grown very fast in the last 12 months
> > and
> > > > > it's great. It means that we have more and more contributors.
> > > > >
> > > > > However, to make the project maintainable at long term, we need
> > regular
> > > > > code refactoring.
> > > > >
> > > > > I have some ideas to share with you
> > > > >
> > > > > 1) Use Java 8 to benefit from Lambda & streams.
> > > > >
> > > > >   Now that Java 8 is well established, it is a good time to upgrade
> > the
> > > > > project. I believe some interpreters also need Java 8. Cassandra
> > > > > interpreter right now does not have unit tests for the latest
> > features
> > > > > because the Embedded Cassandra server used for testing requires
> Java
> > 8.
> > > > >
> > > > >  It would also be a good opportunity to go through the code base
> and
> > > > > replace some boilerplate for() loop with manual filtering by the
> > stream
> > > > > shortcut :  list.stream().filter(..).map(). It would improve
> greatly
> > > > code
> > > > > readability
> > > > >
> > > > > 2) Multi threading
> > > > >
> > > > >  I've seen the usage of synchronize block at a few places in the
> code
> > > > base.
> > > > > Although perfectly valid, it has a cost at runtime and since more
> and
> > > > more
> > > > > people are asking for multi-tenancy or using a single Zeppelin
> > instance
> > > > to
> > > > > server multiple users, I guess the synchronized blocks has a huge
> > cost.
> > > > >
> > > > > There are some solid alternatives:
> > > > >
> > > > >  - ConcurrentHashMap if we synchronized on a map
> > > > >  - CopyOnWriteArrayList if we synchronized on a list.
> > > > >
> > > > > Of cours each sychronize block should be taken carefully not to
> > > introduce
> > > > > regression
> > > > >
> > > > > 3) Thread management
> > > > >
> > > > > I've seen some usage of new Thread() {...}.run(); it may be a good
> > time
> > > > to
> > > > > introduce ThreadPool and pass them along (inside context objects
> for
> > > > > example) to have a more centralized thread management
> > > > >
> > > > > The advantage of having thread pool is that we can manage them in a
> > > > single
> > > > > place, monitor them and expose the info through JMX and also
> control
> > > > system
> > > > > resource 

[jira] [Created] (ZEPPELIN-1520) Using local mode of Apache Spark while testing Zeppelin via travis.

[Jongyoul Lee (JIRA)]

Jongyoul Lee created ZEPPELIN-1520:
--

 Summary: Using local mode of Apache Spark while testing Zeppelin 
via travis.
 Key: ZEPPELIN-1520
 URL: https://issues.apache.org/jira/browse/ZEPPELIN-1520
 Project: Zeppelin
  Issue Type: Improvement
  Components: zeppelin-server
Reporter: Jongyoul Lee
Assignee: Jongyoul Lee


For now, travis of Apache Zeppelin downloads Apache Spark and running it. But 
it's enough to test Zeppelin with Spark's local mode and it will returns the 
same.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[GitHub] zeppelin issue #1483: [ZEPPELIN-1509] Run certain SparkInterpreter tests onl...

[jongyoul]

Github user jongyoul commented on the issue:

https://github.com/apache/zeppelin/pull/1483
  
How about removing Spark 1.1.* and 1.2.* in Zeppelin's support list? It's 
too old and even Apache Spark removes their download URL in their official web.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1458: [ZEPPELIN-1486] Allow configuring whether shown values...

[jongyoul]

Github user jongyoul commented on the issue:

https://github.com/apache/zeppelin/pull/1458
  
@spektom I agree with you not to add zeppelin-env.* because it depends on 
Live only.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: Refactor time !

[Jongyoul Lee]

Thanks for starting this thread.

Concerning #2, Zeppelin's backend has a lot of map and the map has mutable
states. Thus we should also think of read-write-lock.

Personally, moving to Java8 is very attractive but we divide it with others
because upgrading to the version of JDK influences users' experiences.

On Wed, Oct 5, 2016 at 11:28 AM, Anthony Corbacho <
anthonycorba...@apache.org> wrote:

> I think about the abuse of @Inject and circular deps, it is just matter of
> education.
>
> On Tue, Oct 4, 2016 at 8:05 PM, DuyHai Doan  wrote:
>
> > About DI I have no strong opinion on the topic.
> >
> > I have coded frameworks with just manual DI (through constructor and
> > context objects) and it works pretty well, even for a big project, as
> long
> > as the context objects have meaningfull names
> >
> > Using DI frameworks like Spring or Guice is also a valid choice,
> especially
> > for a backend. The only thing to be really cautious about are circular
> > dependencies. Using @Inject is very easy and people tend to abuse it
> > everywhere and end up with horrible cyclic dependencies
> >
> >
> >
> > On Tue, Oct 4, 2016 at 12:54 PM, Anthony Corbacho <
> > anthonycorba...@apache.org> wrote:
> >
> > > You made my day, this is the kind of email i really like !!
> > >
> > > I think its a great idea and i am willing to spend sometime on it.
> > >
> > > I also want to move to a DI (guice) architecture , let me know what you
> > > think about it.
> > >
> > > On Tuesday, 4 October 2016, DuyHai Doan  wrote:
> > >
> > > > Hello devs
> > > >
> > > > The code base of Zeppelin has grown very fast in the last 12 months
> and
> > > > it's great. It means that we have more and more contributors.
> > > >
> > > > However, to make the project maintainable at long term, we need
> regular
> > > > code refactoring.
> > > >
> > > > I have some ideas to share with you
> > > >
> > > > 1) Use Java 8 to benefit from Lambda & streams.
> > > >
> > > >   Now that Java 8 is well established, it is a good time to upgrade
> the
> > > > project. I believe some interpreters also need Java 8. Cassandra
> > > > interpreter right now does not have unit tests for the latest
> features
> > > > because the Embedded Cassandra server used for testing requires Java
> 8.
> > > >
> > > >  It would also be a good opportunity to go through the code base and
> > > > replace some boilerplate for() loop with manual filtering by the
> stream
> > > > shortcut :  list.stream().filter(..).map(). It would improve greatly
> > > code
> > > > readability
> > > >
> > > > 2) Multi threading
> > > >
> > > >  I've seen the usage of synchronize block at a few places in the code
> > > base.
> > > > Although perfectly valid, it has a cost at runtime and since more and
> > > more
> > > > people are asking for multi-tenancy or using a single Zeppelin
> instance
> > > to
> > > > server multiple users, I guess the synchronized blocks has a huge
> cost.
> > > >
> > > > There are some solid alternatives:
> > > >
> > > >  - ConcurrentHashMap if we synchronized on a map
> > > >  - CopyOnWriteArrayList if we synchronized on a list.
> > > >
> > > > Of cours each sychronize block should be taken carefully not to
> > introduce
> > > > regression
> > > >
> > > > 3) Thread management
> > > >
> > > > I've seen some usage of new Thread() {...}.run(); it may be a good
> time
> > > to
> > > > introduce ThreadPool and pass them along (inside context objects for
> > > > example) to have a more centralized thread management
> > > >
> > > > The advantage of having thread pool is that we can manage them in a
> > > single
> > > > place, monitor them and expose the info through JMX and also control
> > > system
> > > > resource by defining max thread number and thread pool queue
> > > >
> > > > 4) Server monitoring
> > > > I hear many users on the field complain about the fact that they have
> > to
> > > > restart Zeppelin server regularly because it "hangs" after running a
> > long
> > > > time.
> > > >
> > > > If we can expose some system metrics through JMX, it would help
> people
> > > > monitor the state of Zeppelin server and take appropriate actions
> > > >
> > > > Right now we may only focus on monitoring the server itself, not the
> > > > interpreter JVMs processes. It can be done in a 2nd step
> > > >
> > > >
> > > > What do you think about the ideas ?
> > > >
> > >
> >
>



-- 
이종열, Jongyoul Lee, 李宗烈
http://madeng.net