[GitHub] zeppelin pull request #1782: [ZEPPELIN-1837] Fix possible reason of DepInter...
GitHub user DrIgor reopened a pull request: https://github.com/apache/zeppelin/pull/1782 [ZEPPELIN-1837] Fix possible reason of DepInterpreterTest failure ### What is this PR for? Fix possible reason of DepInterpreterTest failure ### What type of PR is it? [Bug Fix] ### What is the Jira issue? [ZEPPELIN-1837](https://issues.apache.org/jira/browse/ZEPPELIN-1837) ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No DepInterpreterTest will use random temporary folder for repo `DefaultRepositorySystem.resolveDependencies` throws NPE at line 352 if `ArtifactResolutionException` is thrown during `collectDependencies`. Artifact is found but it is impossible to download it (for example folder can't be created) I think the reason is that several tests use "local-repo" folder for repository. While one test tries to download artifact, another deletes repository (or some another distructive thing) You can merge this pull request into a Git repository by running: $ git pull https://github.com/DrIgor/zeppelin ZEPPELIN-1837 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/1782.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1782 commit a2af13583f0f5be975e9f1780140d683a66d3983 Author: Igor Drozdov Date: 2016-12-19T10:00:39Z Fix possible reason of DepInterpreterTest failure DepInterpreterTest will use random temporary folder for repo `DefaultRepositorySystem.resolveDependencies` throws NPE at line 352 if `ArtifactResolutionException` is thrown during `collectDependencies`. Artifact is found but it is impossible to download it (for example folder can't be created) I think the reason is that several tests use "local-repo" folder for repository. While one test tries to download artifact, another deletes repository (or some another distructive thing) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #1782: [ZEPPELIN-1837] Fix possible reason of DepInter...
Github user DrIgor closed the pull request at: https://github.com/apache/zeppelin/pull/1782 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #1765: [WIP] ZEPPELIN-1761. CI: ZeppelinSparkClusterTe...
Github user zjffdu closed the pull request at: https://github.com/apache/zeppelin/pull/1765 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #1765: [WIP] ZEPPELIN-1761. CI: ZeppelinSparkClusterTe...
GitHub user zjffdu reopened a pull request: https://github.com/apache/zeppelin/pull/1765 [WIP] ZEPPELIN-1761. CI: ZeppelinSparkClusterTest .pySpark* fail the build ### What is this PR for? Add more logging as I could not reproduce it locally. ### What type of PR is it? [ Improvement ] ### Todos * [ ] - Task ### What is the Jira issue? * https://issues.apache.org/jira/browse/ZEPPELIN-1761 ### How should this be tested? Outline the steps to test the PR here. ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No You can merge this pull request into a Git repository by running: $ git pull https://github.com/zjffdu/zeppelin ZEPPELIN-1761 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/1765.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1765 commit 5aaf4f5dce24fa4d5a01e25f45e1704829646d2c Author: Jeff Zhang Date: 2016-12-15T07:29:07Z ZEPPELIN-1761. CI: ZeppelinSparkClusterTest .pySpark* fail the build --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1736: [ZEPPELIN-1757] Menu of paragraph includes keyboard sh...
Github user soralee commented on the issue: https://github.com/apache/zeppelin/pull/1736 Ping Ping ! Ci is green. It's time to ready to review this PR :smile: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1782: [ZEPPELIN-1837] Fix possible reason of DepInterpreterT...
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/1782 Could you file CI links? :) also --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #1782: [ZEPPELIN-1837] Fix possible reason of DepInter...
Github user DrIgor closed the pull request at: https://github.com/apache/zeppelin/pull/1782 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #1782: [ZEPPELIN-1837] Fix possible reason of DepInter...
GitHub user DrIgor reopened a pull request: https://github.com/apache/zeppelin/pull/1782 [ZEPPELIN-1837] Fix possible reason of DepInterpreterTest failure ### What is this PR for? Fix possible reason of DepInterpreterTest failure ### What type of PR is it? [Bug Fix] ### What is the Jira issue? [ZEPPELIN-1837](https://issues.apache.org/jira/browse/ZEPPELIN-1837) ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No DepInterpreterTest will use random temporary folder for repo `DefaultRepositorySystem.resolveDependencies` throws NPE at line 352 if `ArtifactResolutionException` is thrown during `collectDependencies`. Artifact is found but it is impossible to download it (for example folder can't be created) I think the reason is that several tests use "local-repo" folder for repository. While one test tries to download artifact, another deletes repository (or some another distructive thing) You can merge this pull request into a Git repository by running: $ git pull https://github.com/DrIgor/zeppelin ZEPPELIN-1837 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/1782.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1782 commit a2af13583f0f5be975e9f1780140d683a66d3983 Author: Igor Drozdov Date: 2016-12-19T10:00:39Z Fix possible reason of DepInterpreterTest failure DepInterpreterTest will use random temporary folder for repo `DefaultRepositorySystem.resolveDependencies` throws NPE at line 352 if `ArtifactResolutionException` is thrown during `collectDependencies`. Artifact is found but it is impossible to download it (for example folder can't be created) I think the reason is that several tests use "local-repo" folder for repository. While one test tries to download artifact, another deletes repository (or some another distructive thing) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1782: [ZEPPELIN-1837] Fix possible reason of DepInterpreterT...
Github user DrIgor commented on the issue: https://github.com/apache/zeppelin/pull/1782 @1ambda yes, of course * https://travis-ci.org/apache/zeppelin/builds/185383249 * https://travis-ci.org/apache/zeppelin/builds/185389810 * https://travis-ci.org/apache/zeppelin/builds/185398627 I'm new to travis. Should I wait until build completed before reopening pull request again? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Created] (ZEPPELIN-1842) Sync mechanism doesn't work on start if anonymous mode is on
Khalid Huseynov created ZEPPELIN-1842: - Summary: Sync mechanism doesn't work on start if anonymous mode is on Key: ZEPPELIN-1842 URL: https://issues.apache.org/jira/browse/ZEPPELIN-1842 Project: Zeppelin Issue Type: Improvement Reporter: Khalid Huseynov Assignee: Khalid Huseynov Fix For: 0.7.0 Previously we had sync on start, however after multi-tenancy issues it was deleted in https://github.com/apache/zeppelin/commit/dfbea2eb988e6b9ebf017d6a35f0ba590ce2873e. To keep backward compatibility it should be possible to sync on start when anonymous mode is on (no authentication) until all these procedures are available on frontend. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[GitHub] zeppelin pull request #1765: [WIP] ZEPPELIN-1761. CI: ZeppelinSparkClusterTe...
GitHub user zjffdu reopened a pull request: https://github.com/apache/zeppelin/pull/1765 [WIP] ZEPPELIN-1761. CI: ZeppelinSparkClusterTest .pySpark* fail the build ### What is this PR for? Add more logging as I could not reproduce it locally. ### What type of PR is it? [ Improvement ] ### Todos * [ ] - Task ### What is the Jira issue? * https://issues.apache.org/jira/browse/ZEPPELIN-1761 ### How should this be tested? Outline the steps to test the PR here. ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No You can merge this pull request into a Git repository by running: $ git pull https://github.com/zjffdu/zeppelin ZEPPELIN-1761 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/1765.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1765 commit 5aaf4f5dce24fa4d5a01e25f45e1704829646d2c Author: Jeff Zhang Date: 2016-12-15T07:29:07Z ZEPPELIN-1761. CI: ZeppelinSparkClusterTest .pySpark* fail the build --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #1765: [WIP] ZEPPELIN-1761. CI: ZeppelinSparkClusterTe...
Github user zjffdu closed the pull request at: https://github.com/apache/zeppelin/pull/1765 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #1786: [ZEPPELIN-1842] sync on start when anonymous al...
GitHub user khalidhuseynov opened a pull request: https://github.com/apache/zeppelin/pull/1786 [ZEPPELIN-1842] sync on start when anonymous allowed ### What is this PR for? this is to keep backward compatibility when it's possible to sync on start in anonymous mode. ### What type of PR is it? Bug Fix | Improvement ### Todos * [x] - add sync call with condition ### What is the Jira issue? [ZEPPELIN-1842](https://issues.apache.org/jira/browse/ZEPPELIN-1842) ### How should this be tested? 1. enable secondary storage (e.g. s3, azure, [here](https://zeppelin.apache.org/docs/0.7.0-SNAPSHOT/storage/storage.html#notebook-storage-in-s3)) 2. keep anonymous mode without authentication 3. start zeppelin -> notes should be synced ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no You can merge this pull request into a Git repository by running: $ git pull https://github.com/khalidhuseynov/incubator-zeppelin fix/sync-anonymous Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/1786.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1786 commit 66bfa9e46603d79408e82adff76948cbbb90db26 Author: Khalid Huseynov Date: 2016-12-20T09:28:01Z sync on start when anonymous allowed --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1786: [ZEPPELIN-1842] sync on start when anonymous allowed
Github user khalidhuseynov commented on the issue: https://github.com/apache/zeppelin/pull/1786 this is ready for review, /cc @AhyoungRyu for help in review --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #1782: [ZEPPELIN-1837] Fix possible reason of DepInter...
GitHub user DrIgor reopened a pull request: https://github.com/apache/zeppelin/pull/1782 [ZEPPELIN-1837] Fix possible reason of DepInterpreterTest failure ### What is this PR for? Fix possible reason of DepInterpreterTest failure ### What type of PR is it? [Bug Fix] ### What is the Jira issue? [ZEPPELIN-1837](https://issues.apache.org/jira/browse/ZEPPELIN-1837) ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No DepInterpreterTest will use random temporary folder for repo `DefaultRepositorySystem.resolveDependencies` throws NPE at line 352 if `ArtifactResolutionException` is thrown during `collectDependencies`. Artifact is found but it is impossible to download it (for example folder can't be created) I think the reason is that several tests use "local-repo" folder for repository. While one test tries to download artifact, another deletes repository (or some another distructive thing) You can merge this pull request into a Git repository by running: $ git pull https://github.com/DrIgor/zeppelin ZEPPELIN-1837 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/1782.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1782 commit a2af13583f0f5be975e9f1780140d683a66d3983 Author: Igor Drozdov Date: 2016-12-19T10:00:39Z Fix possible reason of DepInterpreterTest failure DepInterpreterTest will use random temporary folder for repo `DefaultRepositorySystem.resolveDependencies` throws NPE at line 352 if `ArtifactResolutionException` is thrown during `collectDependencies`. Artifact is found but it is impossible to download it (for example folder can't be created) I think the reason is that several tests use "local-repo" folder for repository. While one test tries to download artifact, another deletes repository (or some another distructive thing) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #1782: [ZEPPELIN-1837] Fix possible reason of DepInter...
Github user DrIgor closed the pull request at: https://github.com/apache/zeppelin/pull/1782 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1775: [ZEPPELIN-1745] View revisions in non-editable mode
Github user cloverhearts commented on the issue: https://github.com/apache/zeppelin/pull/1775 good feature! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1716: [ ZEPPELIN-531 ] execute and stop note in job menu
Github user cloverhearts commented on the issue: https://github.com/apache/zeppelin/pull/1716 Hello @bzz , could you please review? ci is green. I think ready for merge on this pr. Thank you :) Have a nice day. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1758: [ZEPPELIN-1787] Add an example of Flink Notebook
Github user AlexanderShoshin commented on the issue: https://github.com/apache/zeppelin/pull/1758 I am confused a bit :) @AhyoungRyu, do I need to drop my last commit or not? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1758: [ZEPPELIN-1787] Add an example of Flink Notebook
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/1758 @AlexanderShoshin Right that would be better. So sorry about that ã _ã --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #1782: [ZEPPELIN-1837] Fix possible reason of DepInter...
Github user DrIgor closed the pull request at: https://github.com/apache/zeppelin/pull/1782 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #1782: [ZEPPELIN-1837] Fix possible reason of DepInter...
GitHub user DrIgor reopened a pull request: https://github.com/apache/zeppelin/pull/1782 [ZEPPELIN-1837] Fix possible reason of DepInterpreterTest failure ### What is this PR for? Fix possible reason of DepInterpreterTest failure ### What type of PR is it? [Bug Fix] ### What is the Jira issue? [ZEPPELIN-1837](https://issues.apache.org/jira/browse/ZEPPELIN-1837) ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No DepInterpreterTest will use random temporary folder for repo `DefaultRepositorySystem.resolveDependencies` throws NPE at line 352 if `ArtifactResolutionException` is thrown during `collectDependencies`. Artifact is found but it is impossible to download it (for example folder can't be created) I think the reason is that several tests use "local-repo" folder for repository. While one test tries to download artifact, another deletes repository (or some another distructive thing) You can merge this pull request into a Git repository by running: $ git pull https://github.com/DrIgor/zeppelin ZEPPELIN-1837 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/1782.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1782 commit a2af13583f0f5be975e9f1780140d683a66d3983 Author: Igor Drozdov Date: 2016-12-19T10:00:39Z Fix possible reason of DepInterpreterTest failure DepInterpreterTest will use random temporary folder for repo `DefaultRepositorySystem.resolveDependencies` throws NPE at line 352 if `ArtifactResolutionException` is thrown during `collectDependencies`. Artifact is found but it is impossible to download it (for example folder can't be created) I think the reason is that several tests use "local-repo" folder for repository. While one test tries to download artifact, another deletes repository (or some another distructive thing) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1738: Strings should not be concatenated using '+' in a loop
Github user bitchelov commented on the issue: https://github.com/apache/zeppelin/pull/1738 @Leemoonsoo https://issues.apache.org/jira/secure/ViewProfile.jspa?name=Sergey+Sokur --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1738: Strings should not be concatenated using '+' in a loop
Github user bitchelov commented on the issue: https://github.com/apache/zeppelin/pull/1738 @AhyoungRyu ok, ill update jira issue. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1783: Zeppelin 727
Github user FireArrow commented on the issue: https://github.com/apache/zeppelin/pull/1783 I agree with @AhyoungRyu. What she describes is the common way to link to paragraphs, so it seems reasonable to assume that is what users are used to. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1758: [ZEPPELIN-1787] Add an example of Flink Notebook
Github user AlexanderShoshin commented on the issue: https://github.com/apache/zeppelin/pull/1758 @bzz, I am not sure. We already have a *Word Count* example there to describe `Flink` usage. Where should we place the link to this example? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1782: [ZEPPELIN-1837] Fix possible reason of DepInterpreterT...
Github user DrIgor commented on the issue: https://github.com/apache/zeppelin/pull/1782 @bzz @1ambda I attached CI logs Failures are: * `ZeppelinIT.testAngularDisplay:157->AbstractZeppelinIT.waitForText:84 » StaleElementReference` * `AngularElemTest:` `AngularElem` - `should provide onclick method *** FAILED ***` `The code passed to eventually never returned normally. Attempted 1 times over 359.286866 milliseconds. Last failure message: 0 was not equal to 1. (AbstractAngularElemTest.scala:64)` * `RemoteSchedulerTest.test:150 expected:<0> but was:<1>` * `InterpreterIT.testShowDescriptionOnInterpreterCreate:69 » ElementNotVisible Element is not currently visible and so may not be interacted with` * `AngularElemTest:` `AngularElem` - `should provide onclick method *** FAILED ***` `The code passed to eventually never returned normally. Attempted 1 times over 198.575701 milliseconds. Last failure message: 0 was not equal to 1. (AbstractAngularElemTest.scala:64)` Seems to be unrelated to dependency resolution --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1782: [ZEPPELIN-1837] Fix possible reason of DepInterpreterT...
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/1782 Those are other flaky tests already reported. You can search JIRA [here](https://issues.apache.org/jira/issues/?jql=project%20%3D%20ZEPPELIN%20and%20text%20~%20%22testShowDescriptionOnInterpreterCreate%22) Thanks for triggering CI multiple times. Regarding to your question, i am also not sure. But if i were a travis CI developer, i wouldn't create new CI build if there is already connected, running one. (it's just my guess) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1758: [ZEPPELIN-1787] Add an example of Flink Notebook
Github user rawkintrevo commented on the issue: https://github.com/apache/zeppelin/pull/1758 @AlexanderShoshin I think what @zjffdu and @bzz meant was that you could possibly call out this notebook in some where like [`docs/interpreter/flink.md`](https://github.com/apache/zeppelin/blob/master/docs/interpreter/flink.md) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1759: [ZEPPELIN-922] New interpreter registration mechanism ...
Github user DrIgor commented on the issue: https://github.com/apache/zeppelin/pull/1759 Ping-ping! :-) What should I do to complete pull request? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1776: [ZEPPELIN-1824] Add MetaData exploration to JDBC Inter...
Github user pmccaffrey6 commented on the issue: https://github.com/apache/zeppelin/pull/1776 Hey @bzz, Great catch! Sorry about that. I removed the unnecessary import. The error seems unrelated. It comes from: ``` 1470 21:03:56,259 ERROR org.apache.zeppelin.AbstractZeppelinIT:136 - Exception in ZeppelinIT while testSparkInterpreterDependencyLoading 1471 org.openqa.selenium.TimeoutException: Timed out after 60 seconds waiting for org.apache.zeppelin.AbstractZeppelinIT$1@7918cba6 ... Stack Trace ... 1507 Caused by: org.openqa.selenium.NoSuchElementException: Unable to locate element: {"method":"xpath","selector":"(//div[@ng-controller=\"ParagraphCtrl\"])[1]//div[contains(@class, 'control')]//span[1][contains(.,'FINISHED')]"} ``` As for the other excellent points that @DrIgor noted (including the great point about using logger), those issues are present both in `getMetaData()` as well as `executeSql()` methods. Would you prefer that I make those changes to the `getMetaData()` method in this PR or refactor both `getMetaData()` and `executeSql()` in a separate PR? As always, thanks for your review! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1757: [ZEPPELIN-1074] Enhance SSL Support
Github user lresende commented on the issue: https://github.com/apache/zeppelin/pull/1757 No worries @AhyoungRyu I will make the suggested changes and add ZEPPELIN-1811 to this pr as well. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #1787: ZEPPELIN-1815. Support Spark 2.1
GitHub user zjffdu opened a pull request: https://github.com/apache/zeppelin/pull/1787 ZEPPELIN-1815. Support Spark 2.1 ### What is this PR for? This PR is to update the max supported spark version to be 2.1 as Spark 2.1 is released. I didn't change pom file and travis script to update spark version. I think we can wait for some time until we confirm spark 2.1 is stable enough. ### What type of PR is it? [Improvement] ### Todos * [ ] - Task ### What is the Jira issue? * https://issues.apache.org/jira/browse/ZEPPELIN-1815 ### How should this be tested? Tested on spark 2.1 ### Screenshots (if appropriate) ![sparkr_progress](https://cloud.githubusercontent.com/assets/164491/21373523/b380f44a-c75a-11e6-9004-e85009f9143a.gif) ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No You can merge this pull request into a Git repository by running: $ git pull https://github.com/zjffdu/zeppelin ZEPPELIN-1815 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/1787.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1787 commit f7e72c93901dc291b3d322b4862ba83ae714d247 Author: Jeff Zhang Date: 2016-12-21T00:01:48Z ZEPPELIN-1815. Support Spark 2.1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1787: ZEPPELIN-1815. Support Spark 2.1
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/1787 @Leemoonsoo @felixcheung Please help review. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1757: [ZEPPELIN-1074][ZEPPELIN-1811] Enhance SSL Support
Github user lresende commented on the issue: https://github.com/apache/zeppelin/pull/1757 @AhyoungRyu @felixcheung Please take a look and let me know if I should update any other pieces. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #1788: ZEPPELIN-1826. Flaky Test: ZeppelinSparkCluster...
GitHub user zjffdu opened a pull request: https://github.com/apache/zeppelin/pull/1788 ZEPPELIN-1826. Flaky Test: ZeppelinSparkClusterTest.zRunTest ### What is this PR for? Fix the flaky test of ZeppelinSparkClusterTest.zRunTest. The issue is that z.run is not a blocking call so we still need the check the paragraph status. (see code change for details). Besides that, I also add more logging. This helps me a lot. ### What type of PR is it? [Improvement] ### Todos * [ ] - Task ### What is the Jira issue? * https://issues.apache.org/jira/browse/ZEPPELIN-1826 ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No You can merge this pull request into a Git repository by running: $ git pull https://github.com/zjffdu/zeppelin ZEPPELIN-1826 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/1788.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1788 commit 5c2279125758adbffd1068e1a9359d3d88a45905 Author: Jeff Zhang Date: 2016-12-15T07:29:07Z ZEPPELIN-1826. Flaky Test: ZeppelinSparkClusterTest.zRunTest --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1788: ZEPPELIN-1826. Flaky Test: ZeppelinSparkClusterTest.zR...
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/1788 @Leemoonsoo @jongyoul @bzz Please help review --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1787: ZEPPELIN-1815. Support Spark 2.1
Github user felixcheung commented on the issue: https://github.com/apache/zeppelin/pull/1787 Looks fine. Would you like to get this in before Spark 2.1 artifacts are in maven? I think we should reword the JIRA if that's the case - I don't think we should say we support 2.1 until we have 2.1 in the build (pom), travis etc. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1787: ZEPPELIN-1815. Support Spark 2.1
Github user felixcheung commented on the issue: https://github.com/apache/zeppelin/pull/1787 and btw, could you please test with the last 2.1 RC5 instead of snapshot builds. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1788: ZEPPELIN-1826. Flaky Test: ZeppelinSparkClusterTest.zR...
Github user felixcheung commented on the issue: https://github.com/apache/zeppelin/pull/1788 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #1749: [ZEPPELIN-1298] Address invalid ticket warnings...
Github user asfgit closed the pull request at: https://github.com/apache/zeppelin/pull/1749 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1757: [ZEPPELIN-1074][ZEPPELIN-1811] Enhance SSL Support
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/1757 @lresende Thanks! Looks nice. BTW the [Build from Source](https://zeppelin.apache.org/docs/0.7.0-SNAPSHOT/install/install.html#building-from-source) section went to too down side. How about putting it in the above [Apache Zeppelin configuration](https://zeppelin.apache.org/docs/0.7.0-SNAPSHOT/install/install.html#apache-zeppelin-configuration) section instead? Other than that LGTM ð --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1759: [ZEPPELIN-922] New interpreter registration mechanism ...
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/1759 As I posted the reason of CI failure in the above, it's not relevant. So will merge into master if there are no more comments. Thanks @DrIgor! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1787: ZEPPELIN-1815. Support Spark 2.1
Github user bikassaha commented on the issue: https://github.com/apache/zeppelin/pull/1787 In a different jira, should we consider removing this check for 2.1, 2.2 since its unlikely that Spark will break common APIs in dot releases. Perhaps the policy can change to adding a check when a known incompatible Spark version shows up (until that gets supported in Zeppelin). Thoughts? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1787: ZEPPELIN-1815. Support Spark 2.1
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/1787 @bikassaha zeppelin use spark repl api heavily. And spark repl is not stable as RDD/DataFrame api (It happens in spark 1.x), so it is possible to have changes in spark repl for spark feature release. Another thing is that zeppelin may need some update to support spark new features, so we need to check spark version. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1694: [ZEPPELIN-1718] Prevent anonymous user to set note per...
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/1694 CI is all green now! Ready to review. Here are some brief summaries what I did. Since from this PR `anonymous`(non authenticated) user can't set note permission, related test cases also need to be updated accordingly. Currently we have two test cases which check note permission as `anonymous` user. - `testPermissions()` in [`NotebookRestApiTest.java`](https://github.com/apache/zeppelin/pull/1694/files#diff-c24f6ba26c704f590c0a1b04233b0e26) added by #681 - `testSearch()` in [`ZeppelinRestApiTest.java`](https://github.com/apache/zeppelin/pull/1694/files#diff-c24f6ba26c704f590c0a1b04233b0e26) added by #833 So I rewrote them based on #1567's [`NotebookSecurityRestApiTest.java`](https://github.com/apache/zeppelin/pull/1567/files#diff-ef00c5495c90ccb911fd20dc127326c9) to be tested as authenticated users. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1780: [BugFix] Tutorial note json format.
Github user astroshim commented on the issue: https://github.com/apache/zeppelin/pull/1780 @bzz I agree with you and I will follow your word! Thanks. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1775: [ZEPPELIN-1745] View revisions in non-editable mode
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/1775 For other reviewers - If you are using git 2.10+, Notebook revision feature will not work. Checkout [ZEPPELIN-1737](https://issues.apache.org/jira/browse/ZEPPELIN-1737) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---