[GitHub] zeppelin issue #1891: [ZEPPELIN-1941] Fix cron job with release resource opt...

2017-01-11 Thread jongyoul
Github user jongyoul commented on the issue:

https://github.com/apache/zeppelin/pull/1891
  
Thanks for the contribution. Can you make a test case for it?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1889: [MINOR] Rename Pig tutorial note to consider priority

2017-01-11 Thread jongyoul
Github user jongyoul commented on the issue:

https://github.com/apache/zeppelin/pull/1889
  
Let's merge it now. :-)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1840: [ZEPPELIN-1730, 1587] add spark impersonation through ...

2017-01-11 Thread jongyoul
Github user jongyoul commented on the issue:

https://github.com/apache/zeppelin/pull/1840
  
Merged it into master and branch-0.7


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin pull request #1840: [ZEPPELIN-1730, 1587] add spark impersonation t...

2017-01-11 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/zeppelin/pull/1840


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin pull request #1891: [ZEPPELIN-1941] Fix cron job with release resou...

2017-01-11 Thread OopsOutOfMemory
GitHub user OopsOutOfMemory opened a pull request:

https://github.com/apache/zeppelin/pull/1891

[ZEPPELIN-1941] Fix cron job with release resource option dead lock

### What is this PR for?
There is a deadlock in concurrent cron job execution with release resource 
option.
`Scenario`:
Two notebook run with cron job that release resource after job finished.

In `Notebook.CronJob.execute()` method:

`T1. note.runAll(); // locked paragraphs(lock) and wait to 
interpreterSettings(lock)`

`T2. notebook.getInterpreterFactory().restart() 
//locked(interpreterSettings) and wait for paragraphs(lock) during jobAbort.`

This will trigger a deadlock that cause zeppelin hang.

### What type of PR is it?
[Bug Fix ]

### Todos
* [x] - Fix this by avoid acquire lock in job abort method.

### What is the Jira issue?
* Open an issue on Jira https://issues.apache.org/jira/browse/ZEPPELIN/
* Put link here, and add [ZEPPELIN-*Jira number*] in PR title, eg. 
[ZEPPELIN-533]

### How should this be tested?
Outline the steps to test the PR here.

### Screenshots (if appropriate)

### Questions:
* Does the licenses files need update?
* Is there breaking changes for older versions?
* Does this needs documentation?


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/OopsOutOfMemory/zeppelin fix_dead_lock_cronjob

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/1891.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1891


commit 44e604323e09f8b2854b4031e6c1125015d66914
Author: victor.sheng 
Date:   2017-01-12T06:54:26Z

fix cron job with release resource option dead lock




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1879: [HOTFIX : ZEPPELIN-1932] paragraph blur error

2017-01-11 Thread minahlee
Github user minahlee commented on the issue:

https://github.com/apache/zeppelin/pull/1879
  
@cloverhearts Can you also look into 
https://github.com/apache/zeppelin/blob/master/zeppelin-web/src/app/notebook/paragraph/paragraph.controller.js#L764
 this line?

I see another error related to editor.
![screen shot 2017-01-12 at 3 49 44 
pm](https://cloud.githubusercontent.com/assets/8503346/21879897/01df6686-d8df-11e6-9300-c6dc8dc9c8fa.png)

How to reproduce
1. go to `Basic Features (Spark)` tutorial notebook
2. run first markdown paragraph



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1861: ZEPPELIN-1293. Livy Interpreter: Automatically attach ...

2017-01-11 Thread felixcheung
Github user felixcheung commented on the issue:

https://github.com/apache/zeppelin/pull/1861
  
nope, 
merging if no more comment


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1747: [MINOR] Remove unused import. Naming convention.

2017-01-11 Thread jongyoul
Github user jongyoul commented on the issue:

https://github.com/apache/zeppelin/pull/1747
  
LGTM. Merging if there's no more discussion


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1883: Bump up version to 0.8.0-SNAPSHOT

2017-01-11 Thread jongyoul
Github user jongyoul commented on the issue:

https://github.com/apache/zeppelin/pull/1883
  
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1883: Bump up version to 0.8.0-SNAPSHOT

2017-01-11 Thread minahlee
Github user minahlee commented on the issue:

https://github.com/apache/zeppelin/pull/1883
  
@jongyoul I made this branch before helium-dev separation PR merged, almost 
missed it! Thank you for pointing out.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin pull request #1890: [BUILD] Update/release script

2017-01-11 Thread minahlee
GitHub user minahlee opened a pull request:

https://github.com/apache/zeppelin/pull/1890

[BUILD] Update/release script

### What is this PR for?
* Change hadoop profile from `hadoop-2.4` to `hadoop-2.6`
* Use `SCALA_VERSION` variable instead of hardcoding
* Specify projects to be built for netinst package instead of excluding 
unnecessary projects.

### What type of PR is it?
Build

### What is the Jira issue?

### How should this be tested?
Outline the steps to test the PR here.

### Screenshots (if appropriate)

### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/minahlee/zeppelin update/release_script

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/1890.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1890


commit da9080ad32f4c862ae2deaf1557df84c573fcb9f
Author: Mina Lee 
Date:   2017-01-11T06:40:18Z

Update hadoop profile from 2.4 to 2.6

commit 1479d26963e4df376b120eb93d81276a6888c60d
Author: Mina Lee 
Date:   2017-01-12T06:23:31Z

Use scala variable instead of hardcoding
Specify project to build for net-inst package instead of adding exluding 
projects everytime zeppelin have new interpreter




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1889: [MINOR] Rename Pig tutorial note to consider priority

2017-01-11 Thread zjffdu
Github user zjffdu commented on the issue:

https://github.com/apache/zeppelin/pull/1889
  
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1882: [MINOR] Small Selenium test fixes

2017-01-11 Thread jongyoul
Github user jongyoul commented on the issue:

https://github.com/apache/zeppelin/pull/1882
  
Merged it into master and branch-0.7


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1889: [MINOR] Rename Pig tutorial note to consider priority

2017-01-11 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue:

https://github.com/apache/zeppelin/pull/1889
  
@zjffdu Sorry for the confusion. If you don't mind, could you take a look 
into this? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin pull request #1889: [MINOR] Rename Pig tutorial note to consider pr...

2017-01-11 Thread AhyoungRyu
GitHub user AhyoungRyu opened a pull request:

https://github.com/apache/zeppelin/pull/1889

[MINOR] Rename Pig tutorial note to consider priority

### What is this PR for?
After #1830 merged, Pig tutorial note placed as a first under `Zeppelin 
Tutorial` folder. I told to @zjffdu, I thought the note name should be same 
with Spark ("Basic Feature (Spark)") in [this 
comment](https://github.com/apache/zeppelin/pull/1830#discussion_r95522394) 
(because they have same contents). 

https://cloud.githubusercontent.com/assets/10060731/21879248/a6d9b88a-d8da-11e6-8f43-5ef192e5895c.png;
 width="300px">

But considering the number of Spark and Pig users, the Spark tutorial note 
needs to be placed as first I think.

https://cloud.githubusercontent.com/assets/10060731/21879244/a488e3d0-d8da-11e6-9e0b-c91ca890c611.png;
 width="300px">
 
### What type of PR is it?
Rename Pig tutorial note 

### What is the Jira issue?
N/A

### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/AhyoungRyu/zeppelin rename/pigTutorialNote

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/1889.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1889


commit f08fd6910bcfb2f5ea3960fc76e08df34c102db3
Author: AhyoungRyu 
Date:   2017-01-12T06:15:14Z

Rename Pig tutorial note to consider priority




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Created] (ZEPPELIN-1943) broken logo url in web dev mode

2017-01-11 Thread Sora Lee (JIRA)
Sora Lee created ZEPPELIN-1943:
--

 Summary: broken logo url in web dev mode
 Key: ZEPPELIN-1943
 URL: https://issues.apache.org/jira/browse/ZEPPELIN-1943
 Project: Zeppelin
  Issue Type: Bug
Affects Versions: 0.7.0
Reporter: Sora Lee
Assignee: Sora Lee
Priority: Minor


zeppelin logo image is broken in web dev mode like attached screenshot.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[GitHub] zeppelin issue #1858: [ZEPPELIN-1229] Clear browser cache with version hasht...

2017-01-11 Thread minahlee
Github user minahlee commented on the issue:

https://github.com/apache/zeppelin/pull/1858
  
Merge if there is no more discussion


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1858: [ZEPPELIN-1229] Clear browser cache with version hasht...

2017-01-11 Thread minahlee
Github user minahlee commented on the issue:

https://github.com/apache/zeppelin/pull/1858
  
Tested LGTM. @felizbear do you mind to review this?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1861: ZEPPELIN-1293. Livy Interpreter: Automatically attach ...

2017-01-11 Thread zjffdu
Github user zjffdu commented on the issue:

https://github.com/apache/zeppelin/pull/1861
  
ping @felixcheung any more comments ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1879: [HOTFIX : ZEPPELIN-1932] paragraph blur error

2017-01-11 Thread minahlee
Github user minahlee commented on the issue:

https://github.com/apache/zeppelin/pull/1879
  
Merge if there is no more discussion


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin pull request #1834: [ZEPPELIN-1864] Improvement to show folder and ...

2017-01-11 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/zeppelin/pull/1834


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin pull request #1830: ZEPPELIN-1867. Update document for pig interpre...

2017-01-11 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/zeppelin/pull/1830


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin pull request #1834: [ZEPPELIN-1864] Improvement to show folder and ...

2017-01-11 Thread soralee
Github user soralee closed the pull request at:

https://github.com/apache/zeppelin/pull/1834


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin pull request #1834: [ZEPPELIN-1864] Improvement to show folder and ...

2017-01-11 Thread soralee
GitHub user soralee reopened a pull request:

https://github.com/apache/zeppelin/pull/1834

[ZEPPELIN-1864] Improvement to show folder and note after searching note

### What is this PR for?
This PR is for improvement to show folder and note after using the filter. 
And I found some bugs and fixed like this.

the following list is improvement and bug fixed.
1. After using the filter in Zeppelin Home, every note is shown by the form 
[FolderName/NoteName] like below. It would be nice to show folder icon and note 
icon as previous status.

![z1864_f_b](https://cloud.githubusercontent.com/assets/8110458/21604777/79dbb228-d1e8-11e6-974d-737520729d68.gif)
 
2. When using the filter, some functions and icons next to note and folder 
are disappeared.

![z1864_f_2_b](https://cloud.githubusercontent.com/assets/8110458/21605057/f5a0143e-d1e9-11e6-86f3-ebff5be4c41d.gif)

3. When using the filter, the `Rename Note` function doesn't work. ( When I 
was handling this PR, this bug was discovered.)

![z1864_f_4_b](https://cloud.githubusercontent.com/assets/8110458/21606384/71305796-d1f2-11e6-91a4-2ec14b8b4959.gif)


### What type of PR is it?
[ Bug Fix | Improvement ]

### Todos
* [x] - improve to show folder and note when finishing to use filter.
* [x] - some functions and icons next to note and folder are appeared when 
using filter.
* [x] - fix `Rename Note` function when using the filter.

### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-1864

### How should this be tested?
 - **[Test 1]** Before/After using the filter, check the list structure of 
your notes. It must be same appearance.

 - **[Test 2]** When using the filter, check the notes. Some icons and 
functions next to note and folder must be appeared.

 - **[Test 3]** When using the filter, click `Rename Note`. It must be 
appeared the path of Note.

### Screenshots (if appropriate)
**Test 1**.

![z1864_f_1_a](https://cloud.githubusercontent.com/assets/8110458/21606849/a79dbf82-d1f5-11e6-8d48-3a1977099ab1.gif)

**Test 2**.

![z1864_f_2_a](https://cloud.githubusercontent.com/assets/8110458/21606880/d1cf9550-d1f5-11e6-9311-ee54424d7e76.gif)

**Test 3**.

![z1864_f_4_a](https://cloud.githubusercontent.com/assets/8110458/21606272/9e0b096a-d1f1-11e6-8bfb-ab1ea1a30b88.gif)


### Questions:
* Does the licenses files need update? N/A
* Is there breaking changes for older versions? N/A
* Does this needs documentation? N/A


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/soralee/zeppelin ZEPPELIN-1864

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/1834.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1834


commit 69d6d6d710c72e07d28e0c29978fe24e15002f8d
Author: soralee 
Date:   2017-01-03T09:35:55Z

Improvement to show folder and note after searching note

commit 61680e5f814ca67dc015406852315a1a92d4e7a8
Author: soralee 
Date:   2017-01-03T11:51:31Z

Improvement to show folder and note after searching note

commit 3e4b8ae80f53e9c7b4709bb41a65ac31b0f62fb4
Author: soralee 
Date:   2017-01-09T09:19:11Z

fix for that filter of navbar and home don't work

commit fd2c2438d6fbc3880194cd6c6e3ed1993b71f3a0
Author: soralee 
Date:   2017-01-11T06:04:53Z

resolve conflict

commit 6fb53aa420e39ee9144513d2b68521bbac1f83a5
Author: soralee 
Date:   2017-01-11T06:26:23Z

resolve conflict




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1875: [ZEPPELIN-1926] Remove grunt googlefonts task

2017-01-11 Thread 1ambda
Github user 1ambda commented on the issue:

https://github.com/apache/zeppelin/pull/1875
  
@felixcheung 

I think it's ok since all LICENSEs will be merged into a single file

- 
https://github.com/apache/zeppelin/blob/master/dev/create_release.sh#L93-#L96


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1842: [ZEPPELIN-1619] Load js package as a plugin visualizat...

2017-01-11 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue:

https://github.com/apache/zeppelin/pull/1842
  
Thanks for the reviews and verifications!

@AhyoungRyu Addressed all the comments and fixed drag and drop problem.
When there is 0 or 1 visualization, reorder doesn't make any sense and i 
think we don't need to bother user with reorder feature in this case.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Created] (ZEPPELIN-1942) frontend-maven-plugin doesn't support npm scripts

2017-01-11 Thread Hoon Park (JIRA)
Hoon Park created ZEPPELIN-1942:
---

 Summary: frontend-maven-plugin doesn't support npm scripts
 Key: ZEPPELIN-1942
 URL: https://issues.apache.org/jira/browse/ZEPPELIN-1942
 Project: Zeppelin
  Issue Type: Bug
  Components: build
Reporter: Hoon Park


Even we installed node 6.9.1, {{yarn run build}} tried to use 0.10.x

{code}
[ERROR] npm ERR! node -v v0.10.36
[ERROR] npm ERR! npm -v 1.4.28
{code}

{code}
[ERROR] npm ERR! zeppelin-web@0.0.0 lint:js: `eslint src test Gruntfile.js`
[ERROR] npm ERR! Exit status 8
[ERROR] npm ERR! 
[ERROR] npm ERR! Failed at the zeppelin-web@0.0.0 lint:js script.
[ERROR] npm ERR! This is most likely a problem with the zeppelin-web package,
[ERROR] npm ERR! not with npm itself.
[ERROR] npm ERR! Tell the author that this fails on your system:
[ERROR] npm ERR! eslint src test Gruntfile.js
[ERROR] npm ERR! You can get their info via:
[ERROR] npm ERR! npm owner ls zeppelin-web
[ERROR] npm ERR! There is likely additional logging output above.
[ERROR] npm ERR! System Linux 4.8.12-040812-generic
[ERROR] npm ERR! command "/home/travis/.nvm/v0.10.36/bin/node" 
"/home/travis/.nvm/v0.10.36/bin/npm" "run" "lint:js"
[ERROR] npm ERR! cwd /home/travis/build/apache/zeppelin/zeppelin-web
[ERROR] npm ERR! node -v v0.10.36
[ERROR] npm ERR! npm -v 1.4.28
[ERROR] npm ERR! code ELIFECYCLE
[ERROR] npm ERR! 
[ERROR] npm ERR! Additional logging details can be found in:
[ERROR] npm ERR! 
/home/travis/build/apache/zeppelin/zeppelin-web/npm-debug.log
[ERROR] npm ERR! not ok code 0
[ERROR] ERROR: "lint:js" exited with 1.
[ERROR] error Command failed with exit code 1.
[ERROR] Failed to execute goal 
com.github.eirslett:frontend-maven-plugin:1.3:yarn (yarn build) on project 
zeppelin-web: Failed to run task: 'yarn run build' failed. (error code 1) -> 
[Help 1]
{code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[GitHub] zeppelin pull request #1888: [ZEPPELIN-1941] Fix deadlock in cron job

2017-01-11 Thread OopsOutOfMemory
GitHub user OopsOutOfMemory opened a pull request:

https://github.com/apache/zeppelin/pull/1888

[ZEPPELIN-1941] Fix deadlock in cron job

### What is this PR for?
There is a deadlock in concurrent cron job execution with release resource 
option.
Scenario:
Two notebook run with cron job that release resource after job finished.
In Notebook.CronJob.execute() method:
T1. note.runAll(); // locked paragraphs(lock) and wait to 
interpreterSettings(lock)
T2. notebook.getInterpreterFactory().restart() 
//locked(interpreterSettings) and wait for paragraphs(lock) during jobAbort.
This will trigger a deadlock that cause zeppelin hang.

### What type of PR is it?
[Bug Fix ]

### Todos
* [ ] - Fix this by remove locking interpreterSettings in restart method

### What is the Jira issue?
* Open an issue on Jira https://issues.apache.org/jira/browse/ZEPPELIN/
* Put link here, and add [ZEPPELIN-*Jira number*] in PR title, eg. 
[ZEPPELIN-533]

### How should this be tested?
Outline the steps to test the PR here.

### Screenshots (if appropriate)

### Questions:
* Does the licenses files need update?
* Is there breaking changes for older versions?
* Does this needs documentation?


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/OopsOutOfMemory/zeppelin cronjob_dl

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/1888.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1888


commit 81de4055498bce9da44e381930a917c5f2565123
Author: victor.sheng 
Date:   2017-01-12T00:15:25Z

fix deadlock in cron job




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Created] (ZEPPELIN-1941) Zeppelin CronJob with release option result in deadlock

2017-01-11 Thread Li Sheng (JIRA)
Li Sheng created ZEPPELIN-1941:
--

 Summary: Zeppelin CronJob with release option result in deadlock
 Key: ZEPPELIN-1941
 URL: https://issues.apache.org/jira/browse/ZEPPELIN-1941
 Project: Zeppelin
  Issue Type: Bug
  Components: Interpreters
Affects Versions: 0.6.2, 0.6.1, 0.6.0
Reporter: Li Sheng
 Fix For: 0.7.0


There is a deadlock in concurrent cron job with release resource option.

Scenario:
 Two notebook run with cron job that release resource after job finished.
 
  In Notebook.CronJob.execute() method:
  T1. note.runAll(); // locked paragraphs(lock) and wait to 
interpreterSettings(lock)

  T2. notebook.getInterpreterFactory().restart()   
//locked(interpreterSettings) and wait for paragraphs(lock) during jobAbort.

  This will trigger a deadlock that cause zeppelin hang.

  Detail stack trace please refer `deadlock_cronjob.jstack`



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[GitHub] zeppelin issue #1600: Using HDFS to backup and restore notebook

2017-01-11 Thread placeybordeaux
Github user placeybordeaux commented on the issue:

https://github.com/apache/zeppelin/pull/1600
  
I built with ```mvn clean package```, but got the same results with ```mvn 
clean package -Pspark-1.6 -Phadoop-2.6 -Pyarn -Ppyspark -Psparkr 
-Pscala-2.10```. It's likely this is just a problem on my side.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin pull request #1887: [ZEPPELIN-1940] most of eslint rules are NOT ap...

2017-01-11 Thread 1ambda
GitHub user 1ambda opened a pull request:

https://github.com/apache/zeppelin/pull/1887

[ZEPPELIN-1940] most of eslint rules are NOT applied at all

### What is this PR for?

**Most fixes are about applying lint rules. It's automatically fixed using 
`eslint --fix` command.**
**So please review `Gruntfile.js`, `.eslint`, `package.json` in 
`zeppelin-web` directory**

As a result of the PR,

- Restored javascript lint system
- Fixed 1500+ lint errors
- Found some buggy code (e.g `Unexpected 'this' no-invalid-this` See the 
screenshot section)

We are using google style guide but it is not used at all because of 
invalid `.eslint` configuration. Thus I made some changes to fix it.

- Moved eslint from grunt to webpack (faster)
- Changed invalid config `"preset": "google"` to `"extends": ["google"]`
- Fixed 1500+ lint errors automatically using `eslint --fix` command
- Left some lint errors i cannot fix immediately as warnings or disabled

```
"guard-for-in": [1], // warning
"no-invalid-this": [1], // warning
"prefer-rest-params": [1], // warning
"require-jsdoc": [0], // disabled
"valid-jsdoc": [0]  // disabled
```

- Also, Modified 20+ lint errors by hand

```

@ ./src/index.js 29:0-65

ERROR in ./src/app/visualization/builtins/visualization-areachart.js
Module build failed: Duplicate declaration "self"

  73 | this.chart.style(this.config.style || 'stack');
  74 |
> 75 | let self = this;
 | ^


/Users/lambda/github/apache-zeppelin/zeppelin-master/zeppelin-web/src/app/visualization/visualization.js
  134:14  error  Unexpected var, use let or const instead  no-var
  138:14  error  Unexpected var, use let or const instead  no-var

...
```

- Additionally, introduced `eslint:recommended` ruleset for several rules 
which google style is not opinionated so that we can keep clear, unified rules.


### What type of PR is it?

[Bug Fix | Improvement]

### Todos
* [x] - Moved eslint (build) task from grunt to npm (package.json)
* [x] - Brought eslint (dev) task from grunt to webpack
* [x] - Fixed `.eslint` to applied google ruleset
* [x] - Modifed some lint errors while leaving others as warning which i 
cannot fix right now (e.g docs)
* [x] - Introduced eslint recommended ruleset

### What is the Jira issue?

[ZEPPELIN-1940](https://issues.apache.org/jira/browse/ZEPPELIN-1940)

### How should this be tested?

- execute `npm run dev` and `npm run build` to check whether lint works well

### Screenshots (if appropriate)

### Image: found some invalid code using restored lint


![image](https://cloud.githubusercontent.com/assets/4968473/21866851/2937c408-d88f-11e6-9385-b9fcca6ce477.png)

### Image: found some errors using restored lint


![image](https://cloud.githubusercontent.com/assets/4968473/21866822/10966dfa-d88f-11e6-803c-bfe6f12960dd.png)

### Image: Some code fixed by hand

```
➜  zeppelin-web git:(remove-grunt-eslint) npm run lint:js -- --quiet

> zeppelin-web@0.0.0 lint:js 
/Users/lambda/github/apache-zeppelin/zeppelin-master/zeppelin-web
> eslint src test Gruntfile.js "--quiet"


/Users/lambda/github/apache-zeppelin/zeppelin-master/zeppelin-web/src/app/handsontable/handsonHelper.js
  159:58  error  Use the rest parameters instead of 'arguments'  
prefer-rest-params
  163:55  error  Use the rest parameters instead of 'arguments'  
prefer-rest-params


/Users/lambda/github/apache-zeppelin/zeppelin-master/zeppelin-web/src/app/notebook/notebook.controller.js
  635:20  error  Unexpected var, use let or const instead  no-var
  648:20  error  Unexpected var, use let or const instead  no-var


/Users/lambda/github/apache-zeppelin/zeppelin-master/zeppelin-web/src/app/notebook/paragraph/paragraph.controller.js
  929:28  error  Use the rest parameters instead of 'arguments'  
prefer-rest-params
  930:66  error  Use the rest parameters instead of 'arguments'  
prefer-rest-params


/Users/lambda/github/apache-zeppelin/zeppelin-master/zeppelin-web/src/app/notebook/paragraph/result/result.controller.js
  386:9   error  Unexpected var, use let or const insteadno-var
  433:9   error  Unexpected var, use let or const insteadno-var
  453:9   error  Unexpected var, use let or const insteadno-var
  867:28  error  Use the rest parameters instead of 'arguments'  
prefer-rest-params
  868:66  error  Use the rest parameters instead of 'arguments'  
prefer-rest-params


/Users/lambda/github/apache-zeppelin/zeppelin-master/zeppelin-web/src/app/tabledata/transformation.js
  52:7   error  Unexpected var, use let 

[jira] [Created] (ZEPPELIN-1940) eslint DOESN"T apply style guide

2017-01-11 Thread Hoon Park (JIRA)
Hoon Park created ZEPPELIN-1940:
---

 Summary: eslint DOESN"T apply style guide 
 Key: ZEPPELIN-1940
 URL: https://issues.apache.org/jira/browse/ZEPPELIN-1940
 Project: Zeppelin
  Issue Type: Improvement
  Components: front-end
Reporter: Hoon Park


We use google javascript style guide and it is specified in {{.eslint}} like 

{code}
"preset": "google"
{code}

But it should be {{"extends"}} instead of {{"preset"}}. So currently google 
rules is not used at all.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


Re: branch-0.7 cut

2017-01-11 Thread Ashwin Shankar
Hey Mina,
When can we expect the 0.7 release to be officially out?

Thanks,
Ashwin

On Tue, Jan 10, 2017 at 11:22 PM, Mina Lee  wrote:

> I would like to inform you that branch-0.7 has cut.
> You can check it through apache git repository URL [1] but it seems like it
> takes some time for Github mirror.
>
> PMCs/Commiters, please note that you need to merge bug fix both to master
> and branch-0.7
> if it needs to be included in 0.7.x release.
>
> Thanks,
> Mina
>
> [1] https://git-wip-us.apache.org/repos/asf?p=zeppelin.git;a=summary
>
> On Wed, Jan 11, 2017 at 3:09 PM Hyung Sung Shim  wrote:
>
> > Thanks Mina! 
> >
> > 2017-01-10 18:23 GMT-08:00 Mina Lee :
> >
> > > Moon, thank you for reminding.
> > > I think it would be beneficial to community to provide public docker
> > image.
> > > I will definitely take it into account as infra part already has been
> > taken
> > > cared and Dockerfile is almost ready.
> > >
> > > On Wed, Jan 11, 2017 at 4:10 AM moon soo Lee  wrote:
> > >
> > > > Thanks Mina taking care of it. Sounds good to me.
> > > >
> > > > One thing is, shell we try have docker image in this release?
> > > > Following issues tracks the the job
> > > > https://issues.apache.org/jira/browse/ZEPPELIN-1711
> > > > https://issues.apache.org/jira/browse/INFRA-12781
> > > >
> > > > I don't think it need to be a blocker for 0.7.0 release, but if they
> > can
> > > be
> > > > resolved by the time we create release candidate and have docker
> image
> > in
> > > > the release, it would be great.
> > > >
> > > > Thanks,
> > > > moon
> > > >
> > > > On Mon, Jan 9, 2017 at 10:24 PM Mina Lee  wrote:
> > > >
> > > > > Hi,
> > > > >
> > > > > It's been almost 3 month since we did 0.6.2 release and there were
> > > number
> > > > > of improvements and bug fixes.
> > > > > Most of the items that we planned for 0.7.0 release [1] are ready
> > > > > so I am planning to cut branch-0.7 on 10th Jan 11pm(PST).
> > > > >
> > > > > After branch cut, bug fixes, documentation patches and issues
> linked
> > > as a
> > > > > blocker in jira [2] will be merged both to branch-0.7, master
> branch
> > > but
> > > > > new features will be merged only to master branch.
> > > > >
> > > > > Thanks,
> > > > > Mina
> > > > >
> > > > > [1]
> > > > https://cwiki.apache.org/confluence/display/ZEPPELIN/
> Zeppelin+Roadmap
> > > > > [2] https://issues.apache.org/jira/browse/ZEPPELIN-1795
> > > > >
> > > >
> > >
> >
>



-- 
Thanks,
Ashwin


[GitHub] zeppelin pull request #725: Added CSV and Tableau export functionality

2017-01-11 Thread markncooper
Github user markncooper closed the pull request at:

https://github.com/apache/zeppelin/pull/725


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #725: Added CSV and Tableau export functionality

2017-01-11 Thread markncooper
Github user markncooper commented on the issue:

https://github.com/apache/zeppelin/pull/725
  
Yeah, I'll abort this change as it's been implemented by others.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1883: Bump up version to 0.8.0-SNAPSHOT

2017-01-11 Thread prabhjyotsingh
Github user prabhjyotsingh commented on the issue:

https://github.com/apache/zeppelin/pull/1883
  
Yes, expect `helium-dev/pom.xml`, LGTM!
Thanks for taking care of this.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1884: [ZEPPELIN-1936] Fix user impersonation setting propaga...

2017-01-11 Thread jongyoul
Github user jongyoul commented on the issue:

https://github.com/apache/zeppelin/pull/1884
  
LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1880: ZEPPELIN-1918. Fix build with Spark 2.1.0

2017-01-11 Thread ejono
Github user ejono commented on the issue:

https://github.com/apache/zeppelin/pull/1880
  
@zjffdu, ok, thanks for confirming that it's just a flaky test. It seemed 
like it could have been related, but I did not dig into it. Have you gotten the 
test to pass when using Spark 2.1.0?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1883: Bump up version to 0.8.0-SNAPSHOT

2017-01-11 Thread jongyoul
Github user jongyoul commented on the issue:

https://github.com/apache/zeppelin/pull/1883
  
@minahlee You need to change `helium-dev`, too.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #725: Added CSV and Tableau export functionality

2017-01-11 Thread jongyoul
Github user jongyoul commented on the issue:

https://github.com/apache/zeppelin/pull/725
  
It looks unmanaged now


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1886: [ZEPPELIN-1876] improved comptetion with schema/table/...

2017-01-11 Thread jongyoul
Github user jongyoul commented on the issue:

https://github.com/apache/zeppelin/pull/1886
  
@astroshim Could you please review this PR?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin pull request #1886: [ZEPPELIN-1876] improved comptetion with schema...

2017-01-11 Thread sotnich
GitHub user sotnich opened a pull request:

https://github.com/apache/zeppelin/pull/1886

[ZEPPELIN-1876] improved comptetion with schema/table/column separati…

…on + sqlcompleter tests

### What is this PR for?
This PR changes autocompletion behaviour in jdbc interpeter.
There are some changes:
* [main change] autocompletion now depends on what are you typing. Now 
there are four types of competion: schema, table, column and keywords. If you 
typing new word then autocompetion suggests only keywords and schema names. If 
you are typing after schema name with point then you get list of tables in that 
schema. Also if you typing a name after point after a table name you will get a 
list of column names of this table.
* autocomption now supports aliases in sql. If you write alias for a table 
in sql you will get a list of columns for an aliased table if you write down 
alias and point.
* autocompletion now load keywords only in low case (otherwise there are so 
many keywords in a list of autocompletion that it is becomes uncomfortable)

### What type of PR is it?
Improvement

### Todos
* [ ] - sort names in the output of autocompletion
* [ ] - list only schema names if we are typing a schema name (for example 
after keywork FROM)
* [ ] - add description in autocompletion list for schema names - schema, 
for table names - table and so
* [ ] - autocompletion must initialize on opening of interpeter (not only 
after execution of sql)
* [ ] - update autocompletion schemas only after execute update sql, not 
after every sql ???
* [ ] - new option for postgresql interpreter: 
postgresql.completer.schema.filter. Filter schema names loaded into 
autocompletion (no more garbage schema names).

### What is the Jira issue?
* Open an issue on Jira https://issues.apache.org/jira/browse/ZEPPELIN/
* Put link here, and add [ZEPPELIN-*Jira number*] in PR title, eg. 
[ZEPPELIN-533]

### How should this be tested?
Outline the steps to test the PR here.

### Screenshots (if appropriate)
https://issues.apache.org/jira/secure/attachment/12845228/auto1.JPG
https://issues.apache.org/jira/secure/attachment/12845229/auto2.JPG
https://issues.apache.org/jira/secure/attachment/12845230/auto3.JPG

### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? Yes


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/sotnich/zeppelin jdbc-1876

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/1886.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1886


commit e9fde84884226f600455cdbd035d9a59b538300c
Author: Sotnichenko Sergey 
Date:   2017-01-11T11:40:46Z

[ZEPPELIN-1876] improved comptetion with schema/table/column separation + 
sqlcompleter tests




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Created] (ZEPPELIN-1939) Imported and scheduled notebooks getting deleted from the filesystem

2017-01-11 Thread Frank Rosner (JIRA)
Frank Rosner created ZEPPELIN-1939:
--

 Summary: Imported and scheduled notebooks getting deleted from the 
filesystem
 Key: ZEPPELIN-1939
 URL: https://issues.apache.org/jira/browse/ZEPPELIN-1939
 Project: Zeppelin
  Issue Type: Bug
Affects Versions: 0.6.2
Reporter: Frank Rosner


h4. Problem

We are facing the problem that from time to time notebooks are disappearing on 
users. When we investigate we notice that they are actually deleted from the 
filesystem (git marks them as deleted, we have the git storage enabled).

It was very difficult to isolate the problem and we were not able to fully 
reproduce it but rather gathered the following information:

- (probably) all disappearing notebooks have been imported using the JSON 
import from the UI
- (probably) all disappearing notebooks have been scheduled using the built-in 
scheduler from the UI
- there are notebooks which are scheduled but never disappeared; they are 
probably not imported
- there are notebooks which are imported but never disappeared; they are not 
scheduled
- there are notebooks which are imported and scheduled but don't disappear
- there seems to be a pattern that it starts deleting from the ones that are 
scheduled first (e.g. "library notebook" which is scheduled first, dissapeared 
a lot already)
- other Zeppelins which import but never used the scheduler do not have 
disappearing notebooks

So it totally looks like something triggered through the scheduling which is 
somehow related to the import function. I don't know about the internals (how 
notebook IDs are generated etc.) but it seems that when the scheduler kicks in, 
something causes a hiccup.

Any ideas?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[GitHub] zeppelin issue #1842: [ZEPPELIN-1619] Load js package as a plugin visualizat...

2017-01-11 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue:

https://github.com/apache/zeppelin/pull/1842
  
When I enable zero or only one vizualization, 
https://cloud.githubusercontent.com/assets/10060731/21853851/fd09d836-d85b-11e6-99ee-4320e309676c.png;>

I didn't no that there is reordering feature. It'll be better to show some 
messages in this case as well so that ppl can know about this. What do you 
think? 

And when I tried to reorder the icons, it doesn't work `left -> right`. It 
only works `right -> left` like below. 

![record](https://cloud.githubusercontent.com/assets/10060731/21854089/cffc4c6a-d85c-11e6-9f6a-74b03f74b02a.gif)



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1842: [ZEPPELIN-1619] Load js package as a plugin visualizat...

2017-01-11 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue:

https://github.com/apache/zeppelin/pull/1842
  
@Leemoonsoo Tested and it works well. It's really awesome! And 👍 for 
having really well described docs. Let me create my own viz application as 
explained in the documentation with real user's point of view. I will leave 
another comment after that :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1600: Using HDFS to backup and restore notebook

2017-01-11 Thread aspen01
Github user aspen01 commented on the issue:

https://github.com/apache/zeppelin/pull/1600
  
@placeybordeaux How did you build a package?

```
$ mvn clean package -Pspark-1.6 -Phadoop-2.6 -Pyarn -Ppyspark -Psparkr 
-Pscala-2.10

...


Results :

Tests run: 66, Failures: 0, Errors: 0, Skipped: 0

...

[INFO] 

[INFO] BUILD SUCCESS
[INFO] 

[INFO] Total time: 19:23 min
[INFO] Finished at: 2017-01-11T23:00:58+09:00
[INFO] Final Memory: 160M/815M
[INFO] 


```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1758: [ZEPPELIN-1787] Add an example of Flink Notebook

2017-01-11 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue:

https://github.com/apache/zeppelin/pull/1758
  
@AlexanderShoshin Thanks! Will Merge if there are no more comments on this. 
 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin pull request #1834: [ZEPPELIN-1864] Improvement to show folder and ...

2017-01-11 Thread soralee
GitHub user soralee reopened a pull request:

https://github.com/apache/zeppelin/pull/1834

[ZEPPELIN-1864] Improvement to show folder and note after searching note

### What is this PR for?
This PR is for improvement to show folder and note after using the filter. 
And I found some bugs and fixed like this.

the following list is improvement and bug fixed.
1. After using the filter in Zeppelin Home, every note is shown by the form 
[FolderName/NoteName] like below. It would be nice to show folder icon and note 
icon as previous status.

![z1864_f_b](https://cloud.githubusercontent.com/assets/8110458/21604777/79dbb228-d1e8-11e6-974d-737520729d68.gif)
 
2. When using the filter, some functions and icons next to note and folder 
are disappeared.

![z1864_f_2_b](https://cloud.githubusercontent.com/assets/8110458/21605057/f5a0143e-d1e9-11e6-86f3-ebff5be4c41d.gif)

3. When using the filter, the `Rename Note` function doesn't work. ( When I 
was handling this PR, this bug was discovered.)

![z1864_f_4_b](https://cloud.githubusercontent.com/assets/8110458/21606384/71305796-d1f2-11e6-91a4-2ec14b8b4959.gif)


### What type of PR is it?
[ Bug Fix | Improvement ]

### Todos
* [x] - improve to show folder and note when finishing to use filter.
* [x] - some functions and icons next to note and folder are appeared when 
using filter.
* [x] - fix `Rename Note` function when using the filter.

### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-1864

### How should this be tested?
 - **[Test 1]** Before/After using the filter, check the list structure of 
your notes. It must be same appearance.

 - **[Test 2]** When using the filter, check the notes. Some icons and 
functions next to note and folder must be appeared.

 - **[Test 3]** When using the filter, click `Rename Note`. It must be 
appeared the path of Note.

### Screenshots (if appropriate)
**Test 1**.

![z1864_f_1_a](https://cloud.githubusercontent.com/assets/8110458/21606849/a79dbf82-d1f5-11e6-8d48-3a1977099ab1.gif)

**Test 2**.

![z1864_f_2_a](https://cloud.githubusercontent.com/assets/8110458/21606880/d1cf9550-d1f5-11e6-9311-ee54424d7e76.gif)

**Test 3**.

![z1864_f_4_a](https://cloud.githubusercontent.com/assets/8110458/21606272/9e0b096a-d1f1-11e6-8bfb-ab1ea1a30b88.gif)


### Questions:
* Does the licenses files need update? N/A
* Is there breaking changes for older versions? N/A
* Does this needs documentation? N/A


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/soralee/zeppelin ZEPPELIN-1864

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/1834.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1834


commit 69d6d6d710c72e07d28e0c29978fe24e15002f8d
Author: soralee 
Date:   2017-01-03T09:35:55Z

Improvement to show folder and note after searching note

commit 61680e5f814ca67dc015406852315a1a92d4e7a8
Author: soralee 
Date:   2017-01-03T11:51:31Z

Improvement to show folder and note after searching note

commit 3e4b8ae80f53e9c7b4709bb41a65ac31b0f62fb4
Author: soralee 
Date:   2017-01-09T09:19:11Z

fix for that filter of navbar and home don't work

commit fd2c2438d6fbc3880194cd6c6e3ed1993b71f3a0
Author: soralee 
Date:   2017-01-11T06:04:53Z

resolve conflict

commit 6fb53aa420e39ee9144513d2b68521bbac1f83a5
Author: soralee 
Date:   2017-01-11T06:26:23Z

resolve conflict




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin pull request #1834: [ZEPPELIN-1864] Improvement to show folder and ...

2017-01-11 Thread soralee
Github user soralee closed the pull request at:

https://github.com/apache/zeppelin/pull/1834


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin pull request #1845: [ZEPPELIN-1906] Use multiple InterpreterResult ...

2017-01-11 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/zeppelin/pull/1845


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin pull request #1834: [ZEPPELIN-1864] Improvement to show folder and ...

2017-01-11 Thread soralee
Github user soralee closed the pull request at:

https://github.com/apache/zeppelin/pull/1834


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin pull request #1834: [ZEPPELIN-1864] Improvement to show folder and ...

2017-01-11 Thread soralee
GitHub user soralee reopened a pull request:

https://github.com/apache/zeppelin/pull/1834

[ZEPPELIN-1864] Improvement to show folder and note after searching note

### What is this PR for?
This PR is for improvement to show folder and note after using the filter. 
And I found some bugs and fixed like this.

the following list is improvement and bug fixed.
1. After using the filter in Zeppelin Home, every note is shown by the form 
[FolderName/NoteName] like below. It would be nice to show folder icon and note 
icon as previous status.

![z1864_f_b](https://cloud.githubusercontent.com/assets/8110458/21604777/79dbb228-d1e8-11e6-974d-737520729d68.gif)
 
2. When using the filter, some functions and icons next to note and folder 
are disappeared.

![z1864_f_2_b](https://cloud.githubusercontent.com/assets/8110458/21605057/f5a0143e-d1e9-11e6-86f3-ebff5be4c41d.gif)

3. When using the filter, the `Rename Note` function doesn't work. ( When I 
was handling this PR, this bug was discovered.)

![z1864_f_4_b](https://cloud.githubusercontent.com/assets/8110458/21606384/71305796-d1f2-11e6-91a4-2ec14b8b4959.gif)


### What type of PR is it?
[ Bug Fix | Improvement ]

### Todos
* [x] - improve to show folder and note when finishing to use filter.
* [x] - some functions and icons next to note and folder are appeared when 
using filter.
* [x] - fix `Rename Note` function when using the filter.

### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-1864

### How should this be tested?
 - **[Test 1]** Before/After using the filter, check the list structure of 
your notes. It must be same appearance.

 - **[Test 2]** When using the filter, check the notes. Some icons and 
functions next to note and folder must be appeared.

 - **[Test 3]** When using the filter, click `Rename Note`. It must be 
appeared the path of Note.

### Screenshots (if appropriate)
**Test 1**.

![z1864_f_1_a](https://cloud.githubusercontent.com/assets/8110458/21606849/a79dbf82-d1f5-11e6-8d48-3a1977099ab1.gif)

**Test 2**.

![z1864_f_2_a](https://cloud.githubusercontent.com/assets/8110458/21606880/d1cf9550-d1f5-11e6-9311-ee54424d7e76.gif)

**Test 3**.

![z1864_f_4_a](https://cloud.githubusercontent.com/assets/8110458/21606272/9e0b096a-d1f1-11e6-8bfb-ab1ea1a30b88.gif)


### Questions:
* Does the licenses files need update? N/A
* Is there breaking changes for older versions? N/A
* Does this needs documentation? N/A


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/soralee/zeppelin ZEPPELIN-1864

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/1834.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1834


commit 69d6d6d710c72e07d28e0c29978fe24e15002f8d
Author: soralee 
Date:   2017-01-03T09:35:55Z

Improvement to show folder and note after searching note

commit 61680e5f814ca67dc015406852315a1a92d4e7a8
Author: soralee 
Date:   2017-01-03T11:51:31Z

Improvement to show folder and note after searching note

commit 3e4b8ae80f53e9c7b4709bb41a65ac31b0f62fb4
Author: soralee 
Date:   2017-01-09T09:19:11Z

fix for that filter of navbar and home don't work

commit fd2c2438d6fbc3880194cd6c6e3ed1993b71f3a0
Author: soralee 
Date:   2017-01-11T06:04:53Z

resolve conflict

commit 6fb53aa420e39ee9144513d2b68521bbac1f83a5
Author: soralee 
Date:   2017-01-11T06:26:23Z

resolve conflict




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Created] (ZEPPELIN-1938) Zeppelin does not close files in local-repo correctly / tries to delete them when changing interpreter settings

2017-01-11 Thread Frank Rosner (JIRA)
Frank Rosner created ZEPPELIN-1938:
--

 Summary: Zeppelin does not close files in local-repo correctly / 
tries to delete them when changing interpreter settings
 Key: ZEPPELIN-1938
 URL: https://issues.apache.org/jira/browse/ZEPPELIN-1938
 Project: Zeppelin
  Issue Type: Bug
Affects Versions: 0.6.2
Reporter: Frank Rosner


h4. Problem

Sometimes when we are trying to change some interpreter settings after already 
working with Zeppelin for some time we get an error message that says:

{noformat}
Unable to delete file: 
/usr/local/zeppelin/local-repo/2BGVKK81C/.nfs00103329930200100ac
{noformat}

Then the interpreter settings are not changed and Zeppelin starts behaving 
weird. After a restart it works again.

These files are created by NFS 3 which we use to store our configuration, 
notebooks, local repo, etc. They are created when files are opened afaik. The 
fact that it tries to delete them but cannot looks like a problem of Zeppelin 
not closing some files there but trying to delete them in the meantime.

h4. Questions

- Why does Zeppelin want to delete this files when making changes to the 
interpreter configuration?

- As making changes to the interpreter settings is working after a restart but 
not when working with Zeppelin for a while could it be that it is related to 
artifacts (jars etc.) being downloaded to the local repo? Why does changing the 
interpreter settings affect the local repo in the first place?




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[GitHub] zeppelin issue #1885: ZEPPELIN-1933. Set pig job name and allow to set pig p...

2017-01-11 Thread zjffdu
Github user zjffdu commented on the issue:

https://github.com/apache/zeppelin/pull/1885
  
CI failure is not relevant.

```
Failed tests: 
  NotebookTest.testAbortParagraphStatusOnInterpreterRestart:760 
expected: but was:
```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin pull request #1834: [ZEPPELIN-1864] Improvement to show folder and ...

2017-01-11 Thread soralee
Github user soralee closed the pull request at:

https://github.com/apache/zeppelin/pull/1834


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin pull request #1834: [ZEPPELIN-1864] Improvement to show folder and ...

2017-01-11 Thread soralee
GitHub user soralee reopened a pull request:

https://github.com/apache/zeppelin/pull/1834

[ZEPPELIN-1864] Improvement to show folder and note after searching note

### What is this PR for?
This PR is for improvement to show folder and note after using the filter. 
And I found some bugs and fixed like this.

the following list is improvement and bug fixed.
1. After using the filter in Zeppelin Home, every note is shown by the form 
[FolderName/NoteName] like below. It would be nice to show folder icon and note 
icon as previous status.

![z1864_f_b](https://cloud.githubusercontent.com/assets/8110458/21604777/79dbb228-d1e8-11e6-974d-737520729d68.gif)
 
2. When using the filter, some functions and icons next to note and folder 
are disappeared.

![z1864_f_2_b](https://cloud.githubusercontent.com/assets/8110458/21605057/f5a0143e-d1e9-11e6-86f3-ebff5be4c41d.gif)

3. When using the filter, the `Rename Note` function doesn't work. ( When I 
was handling this PR, this bug was discovered.)

![z1864_f_4_b](https://cloud.githubusercontent.com/assets/8110458/21606384/71305796-d1f2-11e6-91a4-2ec14b8b4959.gif)


### What type of PR is it?
[ Bug Fix | Improvement ]

### Todos
* [x] - improve to show folder and note when finishing to use filter.
* [x] - some functions and icons next to note and folder are appeared when 
using filter.
* [x] - fix `Rename Note` function when using the filter.

### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-1864

### How should this be tested?
 - **[Test 1]** Before/After using the filter, check the list structure of 
your notes. It must be same appearance.

 - **[Test 2]** When using the filter, check the notes. Some icons and 
functions next to note and folder must be appeared.

 - **[Test 3]** When using the filter, click `Rename Note`. It must be 
appeared the path of Note.

### Screenshots (if appropriate)
**Test 1**.

![z1864_f_1_a](https://cloud.githubusercontent.com/assets/8110458/21606849/a79dbf82-d1f5-11e6-8d48-3a1977099ab1.gif)

**Test 2**.

![z1864_f_2_a](https://cloud.githubusercontent.com/assets/8110458/21606880/d1cf9550-d1f5-11e6-9311-ee54424d7e76.gif)

**Test 3**.

![z1864_f_4_a](https://cloud.githubusercontent.com/assets/8110458/21606272/9e0b096a-d1f1-11e6-8bfb-ab1ea1a30b88.gif)


### Questions:
* Does the licenses files need update? N/A
* Is there breaking changes for older versions? N/A
* Does this needs documentation? N/A


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/soralee/zeppelin ZEPPELIN-1864

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/1834.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1834


commit 69d6d6d710c72e07d28e0c29978fe24e15002f8d
Author: soralee 
Date:   2017-01-03T09:35:55Z

Improvement to show folder and note after searching note

commit 61680e5f814ca67dc015406852315a1a92d4e7a8
Author: soralee 
Date:   2017-01-03T11:51:31Z

Improvement to show folder and note after searching note

commit 3e4b8ae80f53e9c7b4709bb41a65ac31b0f62fb4
Author: soralee 
Date:   2017-01-09T09:19:11Z

fix for that filter of navbar and home don't work

commit fd2c2438d6fbc3880194cd6c6e3ed1993b71f3a0
Author: soralee 
Date:   2017-01-11T06:04:53Z

resolve conflict

commit 6fb53aa420e39ee9144513d2b68521bbac1f83a5
Author: soralee 
Date:   2017-01-11T06:26:23Z

resolve conflict




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1879: [HOTFIX : ZEPPELIN-1932] paragraph blur error

2017-01-11 Thread soralee
Github user soralee commented on the issue:

https://github.com/apache/zeppelin/pull/1879
  
Tested and it works well :+1: 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1885: ZEPPELIN-1933. Set pig job name and allow to set pig p...

2017-01-11 Thread zjffdu
Github user zjffdu commented on the issue:

https://github.com/apache/zeppelin/pull/1885
  
@felixcheung Please help review.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1758: [ZEPPELIN-1787] Add an example of Flink Notebook

2017-01-11 Thread AlexanderShoshin
Github user AlexanderShoshin commented on the issue:

https://github.com/apache/zeppelin/pull/1758
  
@AhyoungRyu, thanks for the note. I've removed an url to the notebook.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin pull request #1828: [ZEPPELIN-1876] smart psql autocomplition

2017-01-11 Thread sotnich
Github user sotnich closed the pull request at:

https://github.com/apache/zeppelin/pull/1828


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1880: ZEPPELIN-1918. Fix build with Spark 2.1.0

2017-01-11 Thread zjffdu
Github user zjffdu commented on the issue:

https://github.com/apache/zeppelin/pull/1880
  
@ejono  CI is not stable, that failure is flaky test.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1880: ZEPPELIN-1918. Fix build with Spark 2.1.0

2017-01-11 Thread ejono
Github user ejono commented on the issue:

https://github.com/apache/zeppelin/pull/1880
  
@zjffdu, I did see your follow-up commit but was already testing from that 
commit. I'm not sure what was wrong. Wasn't the CI (which hit the same exact 
error) also building from that commit? If so, it seems that there is still a 
problem, as CI hasn't passed yet, right?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1884: [ZEPPELIN-1936] Fix user impersonation setting propaga...

2017-01-11 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue:

https://github.com/apache/zeppelin/pull/1884
  
LGTM 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1879: [HOTFIX : ZEPPELIN-1932] paragraph blur error

2017-01-11 Thread soralee
Github user soralee commented on the issue:

https://github.com/apache/zeppelin/pull/1879
  
@cloverhearts Thank you :+1: 
Let me test it out and I'll comment this. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1834: [ZEPPELIN-1864] Improvement to show folder and note af...

2017-01-11 Thread soralee
Github user soralee commented on the issue:

https://github.com/apache/zeppelin/pull/1834
  
Thank you @AhyoungRyu :+1: 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1834: [ZEPPELIN-1864] Improvement to show folder and note af...

2017-01-11 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue:

https://github.com/apache/zeppelin/pull/1834
  
Yup thanks for the explanation. Merge if there are no more discussions. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin pull request #1885: ZEPPELIN-1933. Set pig job name and allow to se...

2017-01-11 Thread zjffdu
GitHub user zjffdu opened a pull request:

https://github.com/apache/zeppelin/pull/1885

ZEPPELIN-1933. Set pig job name and allow to set pig property in pig 
interpreter setting

### What is this PR for?
Two improvements for pig interpreter.
* Set job name via paragraph title if it exists, otherwise use the last 
line of pig script
* Allow to set any pig property in interpreter setting


### What type of PR is it?
[ Improvement]

### Todos
* [ ] - Task

### What is the Jira issue?
* https://issues.apache.org/jira/browse/ZEPPELIN-1933

### How should this be tested?
Unit tested and manually tested. 

### Screenshots (if appropriate)

![image](https://cloud.githubusercontent.com/assets/164491/21840291/a6af18b4-d817-11e6-9778-02e12ec02be1.png)

### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/zjffdu/zeppelin ZEPPELIN-1933

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/1885.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1885


commit 9cee380d4496d918095a8a9ab04461c10830f466
Author: Jeff Zhang 
Date:   2017-01-11T07:58:18Z

ZEPPELIN-1933. Set pig job name and allow to set pig property in pig 
interpreter setting




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---