[GitHub] zeppelin issue #1955: [ZEPPELIN-2025] Cleanup R Tutorial

2017-01-27 Thread minahlee
Github user minahlee commented on the issue:

https://github.com/apache/zeppelin/pull/1955
  
Seems like layout depends on the screen size because editor line at 
different point.
I am using 13 inch laptop, and this is what I see:
![jan-28-2017 
16-24-33](https://cloud.githubusercontent.com/assets/8503346/22395095/8e9cef00-e576-11e6-894a-0f61f55aa577.gif)



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1950: ZEPPELIN-2015 Improve parsing logic of livy sql output

2017-01-27 Thread felixcheung
Github user felixcheung commented on the issue:

https://github.com/apache/zeppelin/pull/1950
  
merged to master and branch-0.7


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin pull request #1950: ZEPPELIN-2015 Improve parsing logic of livy sql...

2017-01-27 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/zeppelin/pull/1950


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin pull request #1942: [ZEPPELIN-1982] When using the 'Select * ...' s...

2017-01-27 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/zeppelin/pull/1942


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin pull request #1955: [ZEPPELIN-2025] Cleanup R Tutorial

2017-01-27 Thread 1ambda
GitHub user 1ambda opened a pull request:

https://github.com/apache/zeppelin/pull/1955

[ZEPPELIN-2025] Cleanup R Tutorial

### What is this PR for?

1. Remove useless paragraphs in R tutorial
2. Prettify layout

I attached screenshots for comparison. See the screenshot section below.

### What type of PR is it?
[Improvement]

### Todos

Done

### What is the Jira issue?

[ZEPPELIN-2025](https://issues.apache.org/jira/browse/ZEPPELIN-2025)

### How should this be tested?

1. Run Zeppelin
2. See the R tutorial


### Screenshots (if appropriate)

 Before


![before](https://cloud.githubusercontent.com/assets/4968473/22393959/5266c76a-e556-11e6-8501-34d87c31908e.gif)

 After


![after](https://cloud.githubusercontent.com/assets/4968473/22393961/5394bc50-e556-11e6-83f8-23ccaa05c12a.gif)

### Questions:
* Does the licenses files need update? - NO
* Is there breaking changes for older versions? - NO
* Does this needs documentation? - NO


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/1ambda/zeppelin 
ZEPPELIN-2025/cleanup-r-tutorial

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/1955.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1955


commit 178178eb275c677acf13ccbe1051ccc50b93ca90
Author: 1ambda <1am...@gmail.com>
Date:   2017-01-28T03:32:12Z

fix: Cleanup R Tutorial




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Created] (ZEPPELIN-2025) Clean R Tutorial

2017-01-27 Thread Hoon Park (JIRA)
Hoon Park created ZEPPELIN-2025:
---

 Summary: Clean R Tutorial
 Key: ZEPPELIN-2025
 URL: https://issues.apache.org/jira/browse/ZEPPELIN-2025
 Project: Zeppelin
  Issue Type: Improvement
Reporter: Hoon Park


1. Remove useless tutorial
2. Prettify layout



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[GitHub] zeppelin issue #1663: ZEPPELIN-1692: Ability to access Spark jobs UI from th...

2017-01-27 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue:

https://github.com/apache/zeppelin/pull/1663
  
The behavior from GIF is, 

When spark job is run in `%spark` paragraph, runtime info is displayed 
correctly.
After that, if the same paragraph is reused for other interpreter (e.g. 
%sh), i think runtime info should be reset. but currently it's still showing 
previous runtime info.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin pull request #1924: [Pyspark] checking nhooks count.

2017-01-27 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/zeppelin/pull/1924


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1936: [ZEPPELIN-2004] List all helium packages in Zeppelin G...

2017-01-27 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue:

https://github.com/apache/zeppelin/pull/1936
  
Thanks @AhyoungRyu for review.
Merge to master if there're no further discussions.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1804: [ZEPPELIN-1578] notes list in customizing zeppelin hom...

2017-01-27 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue:

https://github.com/apache/zeppelin/pull/1804
  
@soralee Tested the last commit. but empty screen is displayed when i set 
`ZEPPELIN_NOTEBOOK_HOMESCREEN`. Could you check?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1902: [ZEPPELIN-1821] Add HTTP client to elasticsearch inter...

2017-01-27 Thread 1ambda
Github user 1ambda commented on the issue:

https://github.com/apache/zeppelin/pull/1902
  
Works well as described.

- tested on elasticsearch 2.4.4 (transport, http) and 5.0.0 (http only)
- code looks nice. well abstracted client classes is shipped with some 
tests.

there some commented code lines. LGTM except that.





---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1663: ZEPPELIN-1692: Ability to access Spark jobs UI from th...

2017-01-27 Thread karuppayya
Github user karuppayya commented on the issue:

https://github.com/apache/zeppelin/pull/1663
  
Test failures seem unrelated
`[ERROR] Failed to execute goal 
org.apache.maven.plugins:maven-surefire-plugin:2.17:test (default-test) on 
project zeppelin-python: Execution default-test of goal 
org.apache.maven.plugins:maven-surefire-plugin:2.17:test failed: The forked VM 
terminated without properly saying goodbye. VM crash or System.exit called?
[ERROR] Command was /bin/sh -c cd /home/travis/build/apache/zeppelin/python 
&& /usr/lib/jvm/java-7-oracle/jre/bin/java -Xmx2g -Xms1g -Dfile.encoding=UTF-8 
-jar `




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1663: ZEPPELIN-1692: Ability to access Spark jobs UI from th...

2017-01-27 Thread karuppayya
Github user karuppayya commented on the issue:

https://github.com/apache/zeppelin/pull/1663
  
Thanks @Leemoonsoo for reviewing. 
I have rebased my the PR and resolved conflicts.
Also didnt get the behaviour from the GIF, can u please explain.
If its a simple change , I can fix it in this PR.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1804: [ZEPPELIN-1578] notes list in customizing zeppelin hom...

2017-01-27 Thread soralee
Github user soralee commented on the issue:

https://github.com/apache/zeppelin/pull/1804
  
Thanks @Leemoonsoo for review this!
Yeah, it's make sense! I just updated filename, screenshot, description for 
this PR as well.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin pull request #1954: [ZEPPELIN-525] Test failing in zeppelin-interpr...

2017-01-27 Thread AlexanderShoshin
Github user AlexanderShoshin closed the pull request at:

https://github.com/apache/zeppelin/pull/1954


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin pull request #1954: [ZEPPELIN-525] Test failing in zeppelin-interpr...

2017-01-27 Thread AlexanderShoshin
GitHub user AlexanderShoshin reopened a pull request:

https://github.com/apache/zeppelin/pull/1954

[ZEPPELIN-525] Test failing in zeppelin-interpreter

`RemoteSchedulerTest.test` was fall when CPU switched `RemoteScheduler` 
execution (which executes a job in a separate thread) back to test main thread 
execution after changing job status to `Status.FINISHED` but before updating 
running jobs list:
```
job.setStatus(lastStatus);

// if thread execution is switched here to the main thread test will fall

synchronized (queue) {
running.remove(job);
queue.notify();
}
```
Test checked job status, saw that job was terminated and expected to see an 
empty jobs runing list. 
```
while (!job.isTerminated() && cycles < MAX_WAIT_CYCLES) {
Thread.sleep(TICK_WAIT);
cycles++;
}

// this assert will fail because a job was not removed from running list yet
assertEquals(0, scheduler.getJobsRunning().size());
```
But `scheduler.running` list still contained the last job and the assertion 
failed.

### What is this PR for?
The goal is to synchronize updating of a job status and a scheduler running 
jobs list when a job is terminated.

### What type of PR is it?
Bug Fix

### What is the Jira issue?
[ZEPPELIN-525](https://issues.apache.org/jira/browse/ZEPPELIN-525)

### How should this be tested?
You may place a `Thread.sleep(1000);` code to the `RemoteScheduler.java` 
class after the `job.setStatus(lastStatus);` (line number 354). This will 
increase probability of threads switching after this line. Test should not fail.

### Questions:
* Does the licenses files need update? **no**
* Is there breaking changes for older versions? **no**
* Does this needs documentation? **no**


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/AlexanderShoshin/zeppelin ZEPPELIN-525

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/1954.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1954


commit 8a0f4afbdf2286748cff4cc415401670de904700
Author: Alexander Shoshin 
Date:   2017-01-27T08:30:11Z

synchronized a job status and a list of running jobs

synchronized changing of a job status and updating a list of running jobs 
after job termination




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin pull request #1954: [ZEPPELIN-525] Test failing in zeppelin-interpr...

2017-01-27 Thread AlexanderShoshin
GitHub user AlexanderShoshin opened a pull request:

https://github.com/apache/zeppelin/pull/1954

[ZEPPELIN-525] Test failing in zeppelin-interpreter

`RemoteSchedulerTest.test` was fall when CPU switched `RemoteScheduler` 
execution (which executes a job in a separate thread) back to test main thread 
execution after changing job status to `Status.FINISHED` but before updating 
running jobs list:
```
job.setStatus(lastStatus);

// if thread execution is switched here to the main thread test will fall

synchronized (queue) {
running.remove(job);
queue.notify();
}
```
Test checked job status, saw that job was terminated and expected to see an 
empty jobs runing list. 
```
while (!job.isTerminated() && cycles < MAX_WAIT_CYCLES) {
Thread.sleep(TICK_WAIT);
cycles++;
}

// this assert will fail because a job was not removed from running list yet
assertEquals(0, scheduler.getJobsRunning().size());
```
But `scheduler.running` list still contained the last job and the assertion 
failed.

### What is this PR for?
The goal is to synchronize updating of a job status and a scheduler running 
jobs list when a job is terminated.

### What type of PR is it?
Bug Fix

### What is the Jira issue?
[ZEPPELIN-525](https://issues.apache.org/jira/browse/ZEPPELIN-525)

### How should this be tested?
You may place a `Thread.sleep(1000);` code to the `RemoteScheduler.java` 
class after the `job.setStatus(lastStatus);` (line number 354). This will 
increase probability of threads switching after this line. Test should not fail.

### Questions:
* Does the licenses files need update? **no**
* Is there breaking changes for older versions? **no**
* Does this needs documentation? **no**


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/AlexanderShoshin/zeppelin ZEPPELIN-525

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/1954.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1954


commit 8a0f4afbdf2286748cff4cc415401670de904700
Author: Alexander Shoshin 
Date:   2017-01-27T08:30:11Z

synchronized a job status and a list of running jobs

synchronized changing of a job status and updating a list of running jobs 
after job termination




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1936: [ZEPPELIN-2004] List all helium packages in Zeppelin G...

2017-01-27 Thread AhyoungRyu
Github user AhyoungRyu commented on the issue:

https://github.com/apache/zeppelin/pull/1936
  
Looks great!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1949: [MINOR] Refactor to modern apis

2017-01-27 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue:

https://github.com/apache/zeppelin/pull/1949
  
LGTM and merge to master if no more comment.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #1924: [Pyspark] checking nhooks count.

2017-01-27 Thread astroshim
Github user astroshim commented on the issue:

https://github.com/apache/zeppelin/pull/1924
  
@Leemoonsoo I just create JIRA issue that is 
https://issues.apache.org/jira/browse/ZEPPELIN-2024.
Thanks.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Created] (ZEPPELIN-2024) checking nhooks count on pyspark interpreter

2017-01-27 Thread Shim HyungSung (JIRA)
Shim HyungSung created ZEPPELIN-2024:


 Summary: checking nhooks count on pyspark interpreter
 Key: ZEPPELIN-2024
 URL: https://issues.apache.org/jira/browse/ZEPPELIN-2024
 Project: Zeppelin
  Issue Type: Bug
Reporter: Shim HyungSung
 Fix For: 0.7.0


if the nhooks value is 0 in 
this(https://github.com/apache/zeppelin/blob/master/spark/src/main/resources/python/zeppelin_pyspark.py#L324)
 line, python code will run twice.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[GitHub] zeppelin pull request #1953: User Impersonation fails on setting hive_conf_l...

2017-01-27 Thread prabhjyotsingh
GitHub user prabhjyotsingh opened a pull request:

https://github.com/apache/zeppelin/pull/1953

User Impersonation fails on setting hive_conf_list in hive interpreter 
(JDBC)

### What is this PR for?
This is how a sample 
`jdbc:hive2://:,:/dbName;initFile=;sess_var_list?hive_conf_list#hive_var_list`
 looks like. And when "hive_conf_list" is set then, User Impersonation which is 
passed via "sess_var_list" fails.

Ref: 
https://cwiki.apache.org/confluence/display/Hive/HiveServer2+Clients#HiveServer2Clients-ConnectionURLFormat

### What type of PR is it?
[Bug Fix]


### What is the Jira issue?
* [ZEPPELIN-2023](https://issues.apache.org/jira/browse/ZEPPELIN-2023)

### How should this be tested?
Try setting tez.queue.name=someQueueName so the JDBC url, like following
```

jdbc:hive2://sameple-custer-3.novalocal:2181,sameple-custer-2.novalocal:2181,sameple-custer-4.novalocal:2181/;serviceDiscoveryMode=zooKeeper;zooKeeperNamespace=hiveserver2?tez.queue.name=someQueueName

 and now execute some query like 
```
select count(*) from table_name
```
 and check resource manager UI, this should show up on the designated queue 
with the webUi logged-in user.

### Screenshots (if appropriate)

### Questions:
* Does the licenses files need update? N/A
* Is there breaking changes for older versions? N/A
* Does this needs documentation? N/A


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/prabhjyotsingh/zeppelin ZEPPELIN-2023

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/1953.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #1953


commit fa8df9e631551dacbfe8bf8c02415216e4979b67
Author: Prabhjyot Singh 
Date:   2017-01-27T08:47:21Z

add proxy.user=user before "?"




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Created] (ZEPPELIN-2023) User Impersonation fails on setting hive_conf_list in hive interpreter (JDBC)

2017-01-27 Thread Prabhjyot Singh (JIRA)
Prabhjyot Singh created ZEPPELIN-2023:
-

 Summary: User Impersonation fails on setting hive_conf_list in 
hive interpreter (JDBC)
 Key: ZEPPELIN-2023
 URL: https://issues.apache.org/jira/browse/ZEPPELIN-2023
 Project: Zeppelin
  Issue Type: Bug
Affects Versions: 0.7.0
Reporter: Prabhjyot Singh
Assignee: Prabhjyot Singh


This is how a sample 
jdbc:hive2://:,:/dbName;initFile=;sess_var_list?hive_conf_list#hive_var_list
 looks like. And when "hive_conf_list" is set then, User Impersonation which is 
passed via "sess_var_list" fails.

Ref:  
https://cwiki.apache.org/confluence/display/Hive/HiveServer2+Clients#HiveServer2Clients-ConnectionURLFormat




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)