[GitHub] zeppelin issue #2145: [ZEPPELIN-2271] encoding password of credentials
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/2145 I think zeppelin should provide a pluggable interface for password storing and encrypting. Zeppelin could provide its default implementation for that but allow for extension. Storing password in file is not a mature and long term solution to me. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2156: [HOTFOX][Branch-0.7] Fix multi dynamic select forms be...
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2156 @Leemoonsoo Thanks! CI has been passed after rebasing from `branch-0.7`. Will merge into `branch-0.7` as a hotfix if there are no more comments on this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2145: [ZEPPELIN-2271] encoding password of credentials
Github user felixcheung commented on the issue: https://github.com/apache/zeppelin/pull/2145 I'm concerned that this would give people a false sense of security... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #2157: [HOTFIX] Fix CI
Github user asfgit closed the pull request at: https://github.com/apache/zeppelin/pull/2157 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2157: [HOTFIX] Fix CI
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2157 CI became green. I'm merging it to master and branch-0.7 as a hotfix. Created issue https://issues.apache.org/jira/browse/ZEPPELIN-2284 to make sure remove AngularObject on interpreter restart in the future. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[jira] [Created] (ZEPPELIN-2284) Handle angularObjects in angularObjectRegistry on interpreter restart.
Lee moon soo created ZEPPELIN-2284: -- Summary: Handle angularObjects in angularObjectRegistry on interpreter restart. Key: ZEPPELIN-2284 URL: https://issues.apache.org/jira/browse/ZEPPELIN-2284 Project: Zeppelin Issue Type: Bug Affects Versions: 0.7.1 Reporter: Lee moon soo On Interpreter restart, Related angularObjects in AngularObjectRegistry need to be removed. However, removal is not taken care properly. Related test case that should be reverted once this issue is fixed. https://github.com/apache/zeppelin/pull/2157/commits/2d9c1821ef3e7ee5a01cd4a0cf14de02675e2be9 -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[GitHub] zeppelin pull request #2157: [HOTFIX] Fix CI
Github user Leemoonsoo closed the pull request at: https://github.com/apache/zeppelin/pull/2157 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #2157: [HOTFIX] Fix CI
GitHub user Leemoonsoo reopened a pull request: https://github.com/apache/zeppelin/pull/2157 [HOTFIX] Fix CI ### What is this PR for? CI is failing since https://github.com/apache/zeppelin/commit/970b8117a48a31a9375bf7f76142117fd9b3bd86 This PR tries to make CI green ### What type of PR is it? Hot Fix ### How should this be tested? CI Green ### Questions: * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no You can merge this pull request into a Git repository by running: $ git pull https://github.com/Leemoonsoo/zeppelin hofix_ci2 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/2157.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2157 commit 2d9c1821ef3e7ee5a01cd4a0cf14de02675e2be9 Author: Lee moon soo Date: 2017-03-18T15:22:23Z update test commit 16881c6544cb260f6d656ed47c412f84f42d7179 Author: Lee moon soo Date: 2017-03-18T23:33:48Z prevent deadlock --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2098: [ZEPPELIN-2217] AdvancedTransformation for Visualizati...
Github user 1ambda commented on the issue: https://github.com/apache/zeppelin/pull/2098 updated Please check https://github.com/1ambda/zeppelin-ultimate-line-chart as well. Thanks! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2148: [branch-0.7][ZEPPELIN-2060] Make dynamic select form t...
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2148 It was merged yesterday but seems wan't closed automatically by asfgit. So I'm closing this manually now. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #2148: [branch-0.7][ZEPPELIN-2060] Make dynamic select...
Github user AhyoungRyu closed the pull request at: https://github.com/apache/zeppelin/pull/2148 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2154: [HOT FIX][MASTER] Fix multi dynamic select forms behav...
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2154 FYI, quick show for `edit on double click` with markdown interpreter  --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2154: [HOT FIX][MASTER] Fix multi dynamic select forms behav...
Github user AhyoungRyu commented on the issue:
https://github.com/apache/zeppelin/pull/2154
@guicaro Just noticed that the behaviour that you mentioned was intended
one.
In Zeppelin, we support `editOnDoubleClick` \w Markdown interpreter. With
this feature, you can hide/show the code block. Since you clicked the paragraph
several times while you're clicking the checkbox, the code section was hidden
because of this feature of `%md` interpreter.
So it's not neither dynamic form behaviour itself's issue nor this patch's.
You don't need to test this in #2156(don't wanna make you spend your time
in the weekend), you can simply check this with `%spark` interpreter in this
branch :)
```
%spark
println("Hello "+z.select("day", Seq(("1","mon"),
("2","tue"),
("3","wed"),
("4","thurs"),
("5","fri"),
("6","sat"),
("7","sun"
val options = Seq(("apple","Apple"), ("banana","Banana"),
("orange","Orange"))
println("Hello "+z.checkbox("fruit", options).mkString(" and "))
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2154: [HOT FIX][MASTER] Fix multi dynamic select forms behav...
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2154 @guicaro Seems sth screwed up in your git. It's okay I can try to reproduce it now :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2154: [HOT FIX][MASTER] Fix multi dynamic select forms behav...
Github user guicaro commented on the issue: https://github.com/apache/zeppelin/pull/2154 @AhyoungRyu just glanced through comments in #2156 I also wondered why changes in check boxes did not trigger a run when placed next to a select form and with the `Run on selection change` glad to see we are all on the same page :) I'm going to have to get back to you on verifying #2156 my local git is displaying all kinds of colors and merge conflicts :( after I tried using `dev/test_zeppelin_pr.py`, I'll take a look at it 5 or 6 hours it that's ok. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #2157: [HOTFIX] Fix CI
GitHub user Leemoonsoo opened a pull request: https://github.com/apache/zeppelin/pull/2157 [HOTFIX] Fix CI ### What is this PR for? CI is failing since https://github.com/apache/zeppelin/commit/970b8117a48a31a9375bf7f76142117fd9b3bd86 This PR tries to make CI green ### What type of PR is it? Hot Fix ### How should this be tested? CI Green ### Questions: * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no You can merge this pull request into a Git repository by running: $ git pull https://github.com/Leemoonsoo/zeppelin hofix_ci2 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/2157.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2157 commit 2d9c1821ef3e7ee5a01cd4a0cf14de02675e2be9 Author: Lee moon soo Date: 2017-03-18T15:22:23Z update test commit 16881c6544cb260f6d656ed47c412f84f42d7179 Author: Lee moon soo Date: 2017-03-18T23:33:48Z prevent deadlock --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2154: [HOT FIX][MASTER] Fix multi dynamic select forms behav...
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2154 @guicaro Thank you for the quick checking! I made some change in #2156(it's base branch is `branch-0.7` while this PR was created on `master`) for the checkbox. The every checking the checkbox will trigger running if `Run on selection change` is on. To keep the consistency, this PR will be updated like it does. If possible, could you check you can reproduce the issue or not in #2156? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #2131: ZEPPELIN-2256. poll job progress is called twic...
Github user asfgit closed the pull request at: https://github.com/apache/zeppelin/pull/2131 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #2143: [ZEPPELIN-2266] Parse helium description as HTM...
Github user asfgit closed the pull request at: https://github.com/apache/zeppelin/pull/2143 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2154: [HOT FIX][MASTER] Fix multi dynamic select forms behav...
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2154 The error is not related to this change. I'm working on the CI error. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2156: [HOTFOX][Branch-0.7] Fix multi dynamic select forms be...
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2156 Tested and LGTM! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2099: [ZEPPELIN-2106] providing paragraph config in create n...
Github user Remilito commented on the issue: https://github.com/apache/zeppelin/pull/2099 @Leemoonsoo thanks for the feedback, I think we should keep only B. I'll update the PR in a couple of days. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2156: [HOTFOX][Branch-0.7] Fix multi dynamic select forms be...
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2156 @Leemoonsoo Yeah it makes sense. So I updated again as you said. - When two types of dynamic form in the paragraph  - Only the checkbox is in the paragraph  Could you check again please? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2156: [HOTFOX][Branch-0.7] Fix multi dynamic select forms be...
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2156 Yes, i think user will expect that same behavior `dropdown` and `checkbox`. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2154: [HOT FIX][MASTER] Fix multi dynamic select forms behav...
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2154 2nd and 3rd build jobs keep failed even after restarting them several times. And the reasons are as below ``` 1. Restart Zeppelin 2. Create interpreter setting in 'Interpreter' menu on Zeppelin GUI 3. Then you can bind the interpreter on your note Install intp2(org.apache.commons:commons-math3:3.6.1) to /tmp/ZeppelinLTest_1489855375119/interpreter/intp2 ... Interpreter intp2 installed under /tmp/ZeppelinLTest_1489855375119/interpreter/intp2. 1. Restart Zeppelin 2. Create interpreter setting in 'Interpreter' menu on Zeppelin GUI 3. Then you can bind the interpreter on your note Install intp1(org.apache.commons:commons-csv:1.1) to /tmp/ZeppelinLTest_1489855376594/interpreter/intp1 ... Interpreter intp1 installed under /tmp/ZeppelinLTest_1489855376594/interpreter/intp1. 1. Restart Zeppelin 2. Create interpreter setting in 'Interpreter' menu on Zeppelin GUI 3. Then you can bind the interpreter on your note Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.869 sec - in org.apache.zeppelin.interpreter.install.InstallInterpreterTest Running org.apache.zeppelin.interpreter.InterpreterSettingTest SLF4J: Class path contains multiple SLF4J bindings. SLF4J: Found binding in [jar:file:/home/travis/build/AhyoungRyu/zeppelin/zeppelin-interpreter/target/lib/slf4j-log4j12-1.7.10.jar!/org/slf4j/impl/StaticLoggerBinder.class] SLF4J: Found binding in [jar:file:/home/travis/.m2/repository/org/slf4j/slf4j-log4j12/1.7.10/slf4j-log4j12-1.7.10.jar!/org/slf4j/impl/StaticLoggerBinder.class] SLF4J: See http://www.slf4j.org/codes.html#multiple_bindings for an explanation. SLF4J: Actual binding is of type [org.slf4j.impl.Log4jLoggerFactory] Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.506 sec - in org.apache.zeppelin.interpreter.InterpreterSettingTest Results : Failed tests: NotebookTest.testAngularObjectRemovalOnInterpreterRestart:699 expected null, but was: Tests run: 172, Failures: 1, Errors: 0, Skipped: 0 [ERROR] Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:2.17:test (default-test) on project zeppelin-zengine: There are test failures. [ERROR] [ERROR] Please refer to /home/travis/build/AhyoungRyu/zeppelin/zeppelin-zengine/target/surefire-reports for the individual test results. [ERROR] -> [Help 1] [ERROR] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch. [ERROR] Re-run Maven using the -X switch to enable full debug logging. [ERROR] [ERROR] For more information about the errors and possible solutions, please read the following articles: [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException [ERROR] [ERROR] After correcting the problems, you can resume the build with the command [ERROR] mvn -rf :zeppelin-zengine ``` Is this related with my change? If so, please point me. It'll be really appreciated :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2141: [ZEPPELIN-1720] Adding tests to verify behaviour of dy...
Github user guicaro commented on the issue: https://github.com/apache/zeppelin/pull/2141 @AhyoungRyu no worries, will be glad to review your work, fix `testMultipleDynamicFormsSameType` and fox my commits, will definetly ping you about this last issue :) Thanks --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2156: [HOTFOX][Branch-0.7] Fix multi dynamic select forms be...
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2156 @Leemoonsoo You mean the `checkbox` dynamic form? The `Run on selection change` is only for `select form`. Do you think this can make user confused? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2156: [HOTFOX][Branch-0.7] Fix multi dynamic select forms be...
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2156 When "Run on selection change" is checked, check box change does not run paragraph. @AhyoungRyu can you check? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2141: [ZEPPELIN-1720] Adding tests to verify behaviour of dy...
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2141 @guicaro I feel so sorry to you since it was my bad. Just created hotfix patch #2154 to fix below two issues that you reported. - Select form is not shown up when multiple dynamic forms (e.g. 2 select forms / 1 checkbox + 1 selectform) are in one paragraph - Can't see `Run on selection change` menu under the paragraph control menu It'll be appreciated if you can help me out to review #2154! BTW I tested all your test cases on my patch, most of them passed except `testMultipleDynamicFormsSameType`. It's because of [this line](https://github.com/apache/zeppelin/pull/2141/files#diff-48409cf8ca5ddb1aea1a62ada3cd091dR649). The expected matcher should be `"Howdy 1\nHowdy "` instead of `"Howdy \nHowdy "` since the paragraph runs right after the selection has been changed. (as I said before :D) And after you rebased, some irrelevant commits are mixed and pushed together in here. Could you handle them? Feel free to ping me if you're in trouble while you resolve it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #2155: [HOTFIX] Dynamic form in python interpreter
GitHub user Leemoonsoo opened a pull request:
https://github.com/apache/zeppelin/pull/2155
[HOTFIX] Dynamic form in python interpreter
### What is this PR for?
https://github.com/apache/zeppelin/pull/2106 rewrote python interpreter.
But dynamic form feature is not rewritten correctly.
### What type of PR is it?
Hot Fix
### Todos
* [x] - Bring dynamic form back
### What is the Jira issue?
https://github.com/apache/zeppelin/pull/2106
### How should this be tested?
run
```
%python
print("Hello "+z.input("name", "sun"))
```
```
%python
print("Hello "+z.select("day", [("1","mon"),
("2","tue"),
("3","wed"),
("4","thurs"),
("5","fri"),
("6","sat"),
("7","sun")]))
```
```
%python
options = [("apple","Apple"), ("banana","Banana"), ("orange","Orange")]
print("Hello "+ " and ".join(z.checkbox("fruit", options, ["apple"])))
```
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Leemoonsoo/zeppelin
python_get_interpreter_context
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2155.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2155
commit ab80f2ba4bc2f6972651d443d28ea9c29e909e94
Author: Lee moon soo
Date: 2017-03-18T16:17:36Z
implement dynamic form
commit 844f1bdc4e2008221588b915a186258fb4dfbcb1
Author: Lee moon soo
Date: 2017-03-18T16:17:44Z
Expose a method to get InterpreterOutput, so user can call
InterpreterOutput.clear()
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2156: [HOTFOX][Branch-0.7] Fix multi dynamic select f...
GitHub user AhyoungRyu opened a pull request:
https://github.com/apache/zeppelin/pull/2156
[HOTFOX][Branch-0.7] Fix multi dynamic select forms behaviour
### What is this PR for?
This PR is same with #2154 with base branch `branch-0.7`.
Please refer to #2154's description for the details about what the problem
is now.
### What type of PR is it?
Bug Fix & Hot Fix
### What is the Jira issue?
N/A
### How should this be tested?
1. Create multiple select forms
```
%md
My first selection is ${my selection1=1,1|2|3}
My second selection is ${my selection2=4,4|5|6}
```
2. Create different types of dynamic form (e.g. 1 select form + 1 checkbox)
```
%md
My selection is ${my selection=1,1|2|3}
My check list is ${checkbox:checkboxTest=list1|list2,
list1|list2|list3|list4}
```
There should be `Run on selection change` menu under the paragraph control
menu in the above cases. And the select form should appear!
### Screenshots (if appropriate)
- When multiple select forms are created
- When different dynamic forms are created (e.g. 1 checkbox + 1 select
form)
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/AhyoungRyu/zeppelin
branch-0.7-fix/multiDynamicFormBehaviour
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2156.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2156
commit c0641960b0b4878c302a97e8619150f73f80ee8a
Author: RyuAhyoung
Date: 2017-03-18T16:18:14Z
[branch-0.7] Fix multi dynamicforms behaviour
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #2154: [HOT FIX][MASTER] Fix multi dynamic select form...
GitHub user AhyoungRyu opened a pull request:
https://github.com/apache/zeppelin/pull/2154
[HOT FIX][MASTER] Fix multi dynamic select forms behaviour
### What is this PR for?
After #2100 merged, we can control the behaviour of running select form
using `Run on selection change` under each paragraph control menu. But
currently if user creates multiple dynamic forms in one paragraph, the select
form box itself[1] and `Run on selection` menu[2] don't appear as reported in
https://github.com/apache/zeppelin/pull/2141#issuecomment-287537706.
- [1]
- [2]
Regardless the number of select forms and the types of dynamic form, `Run
on selection change` menu should be shown up if the paragraph has at least 1
select form.
### What type of PR is it?
Bug Fix & Hot Fix
### What is the Jira issue?
N/A
### How should this be tested?
1. Create multiple select forms
```
%md
My first selection is ${my selection1=1,1|2|3}
My second selection is ${my selection2=4,4|5|6}
```
2. Create different types of dynamic form (e.g. 1 select form + 1 checkbox)
```
%md
My selection is ${my selection=1,1|2|3}
My check list is ${checkbox:checkboxTest=list1|list2,
list1|list2|list3|list4}
```
There should be `Run on selection change` menu under the paragraph control
menu in the above cases. And the select form should appear!
### Screenshots (if appropriate)
- When multiple select forms are created
- When different dynamic forms are created (e.g. 1 checkbox + 1 select
form)
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/AhyoungRyu/zeppelin
fix/multiDynamicFormBehaviour
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2154.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2154
commit a9a8d3d672405448ea41bd69e9026034caf37b82
Author: RyuAhyoung
Date: 2017-03-18T15:07:27Z
Fix multi dynamicforms behaviour
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2085: [ZEPPELIN-1999] get interpreter property with replaced...
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2085 Thanks @tinkoff-dwh for useful new feature. LGTM! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2152: [MINOR] Display chart by default in basic tutorial not...
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2152 Merge to master and branch-0.7 if no more comments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
Re: [CI] second job exceeds travis.org max job time
Nowadays, the second and the third profile takes around 40~45min. Which is very close to limit of travis 50min. I've seen sometimes second or the third profile just fails because of it takes longer than usual (by slow network download, etc). I think we need to split second/third profile so the build can be finished in 30 min, which gives enough margin for travis build and adding more tests. Thanks, moon On Fri, Mar 17, 2017 at 11:07 PM Jongyoul Lee wrote: > I found same issue. In my case, Zeppelin server won't run. I'm not sure why > it happens. > > On Sat, Mar 18, 2017 at 2:17 AM, Remy Gayet wrote: > > > nevermind. One of my test is hanging because of a bug somewhere in my > code. > > > > On Fri, Mar 17, 2017 at 12:15 PM, Remy Gayet > wrote: > > > > > Hello guys, > > > > > > the second build configuration (env below) is now taking too much time > ( > > > > > > 49min) and gets killed, as per travis.org policy ( > > > https://docs.travis-ci.com/user/customizing-the-build#Build-Timeouts). > > > > > > SCALA_VER=\"2.11\" SPARK_VER=\"2.1.0\" HADOOP_VER=\"2.6\" > > LIVY_VER=\"0.3.0\" PROFILE=\"-Pspark-2.1 -Phadoop-2.6 -Ppyspark -Psparkr > > -Pscalding -Phelium-dev -Pexamples -Pscala-2.11 -Plivy-0.3\" > > BUILD_FLAG=\"package -Pbuild-distr -DskipRat\" TEST_FLAG=\"verify > > -Pusing-packaged-distr -DskipRat\" TEST_PROJECTS=\"\"" > > > > > > Am I the only one experiencing this? If not, any thought on what to > > remove > > > to reduce this build duration? > > > > > > Cheers, > > > > > > Remy (Remilito) > > > > > > > > > > > > -- > > Remy GAYET, > > +33 6 798 798 62. > > > > > > -- > 이종열, Jongyoul Lee, 李宗烈 > http://madeng.net >
[GitHub] zeppelin issue #2141: [ZEPPELIN-1720] Adding tests to verify behaviour of dy...
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2141 @guicaro Thanks for letting me know. Let me check again. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2141: [ZEPPELIN-1720] Adding tests to verify behaviour of dy...
Github user guicaro commented on the issue: https://github.com/apache/zeppelin/pull/2141 Quick question, what is the behavior when we have more than 2 select forms? Shouldn't we also have a **"Run on selection"** check box? I believe this was one of the pain points for some (see [ZEPPELIN-1013](https://issues.apache.org/jira/browse/ZEPPELIN-1013)). Here is a screen shot showing a paragraph with 2 forms created programmatically but not showing the drop down menus nor the 'Run on selection" checkbox:  Maybe I'm missing something? I rebased yesterday from master and have changes up to March 17 on [my fork ](https://github.com/guicaro/zeppelin/commits/master) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #2106: Rewrite PythonInterpreter.
Github user asfgit closed the pull request at: https://github.com/apache/zeppelin/pull/2106 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #2141: [ZEPPELIN-1720] Adding tests to verify behaviour of dy...
Github user guicaro commented on the issue:
https://github.com/apache/zeppelin/pull/2141
@AhyoungRyu I'm currently looking at why testMultipleDynamicFormsSameType
is failing. It now fails after I rebased from master. It's the test case that
includes two select forms in one single paragraph. Basically the select foms
are not showing up in GUI. I tested this with new version of Chrome (Version
56.0.2924.87 (64-bit)) to see if this might be an issue with the old Firefox
version we use for Selenium, but also happens in Chrome. Here is the pic:
You can reproduce by entering the following string into a paragraph and
then running (this used to work before I rebased).
`%spark val options = Seq(("han","Han"), ("leia","Leia"), ("luke","Luke"));
println("Greetings "+z.checkbox("skywalkers", options).mkString(" and "))`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #2148: [branch-0.7][ZEPPELIN-2060] Make dynamic select form t...
Github user AhyoungRyu commented on the issue: https://github.com/apache/zeppelin/pull/2148 CI failed in two cases with below reason which is irrelevant with this change. ``` No output has been received in the last 10m0s, this potentially indicates a stalled build or something wrong with the build itself. Check the details on how to adjust your build configuration on: https://docs.travis-ci.com/user/common-build-problems/#Build-times-out-because-no-output-was-received The build has been terminated No output has been received in the last 10m0s, this potentially indicates a stalled build or something wrong with the build itself. Check the details on how to adjust your build configuration on: https://docs.travis-ci.com/user/common-build-problems/#Build-times-out-because-no-output-was-received The build has been terminated ``` So will merge into `branch-0.7` if there are no more comment. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
