[GitHub] zeppelin pull request #2326: [ZEPPELIN-2519] Disable watchers not in viewpor...

2017-05-24 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/zeppelin/pull/2326


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin pull request #2341: ZEPPELIN-2543: Add ability to change the log le...

2017-05-24 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/zeppelin/pull/2341


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin pull request #2338: [ZEPPELIN-2122] Add execution time for Spell

2017-05-24 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/zeppelin/pull/2338


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #2351: [ZEPPELIN-2544] clean task doesn't work in zeppelin-we...

2017-05-24 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue:

https://github.com/apache/zeppelin/pull/2351
  
Merge to master if no further comments


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #2355: [ZEPPELIN-2573] Improve navbar style

2017-05-24 Thread Leemoonsoo
Github user Leemoonsoo commented on the issue:

https://github.com/apache/zeppelin/pull/2355
  
@1ambda Could you help resolve conflicts?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin pull request #2357: [ZEPPELIN-2429] Improve `import notebook` dialo...

2017-05-24 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/zeppelin/pull/2357


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin pull request #2358: [ZEPPELIN-2428] Improve `create new note` dialo...

2017-05-24 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/zeppelin/pull/2358


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin pull request #2359: [ZEPPELIN-2575] Improve `rename note` dialog st...

2017-05-24 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/zeppelin/pull/2359


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin pull request #2360: [ZEPPELIN-2574] Improve `about` dialog style

2017-05-24 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/zeppelin/pull/2360


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin pull request #2362: [ZEPPELIN-2469] HeliumBundleFactoryTest fails o...

2017-05-24 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/zeppelin/pull/2362


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin pull request #2361: [ZEPPELIN-2131] Restrict `shift + arrow` key in...

2017-05-24 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/zeppelin/pull/2361


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Created] (ZEPPELIN-2584) Livy doesn't work under kerberos and ssl

2017-05-24 Thread Jeff Zhang (JIRA)
Jeff Zhang created ZEPPELIN-2584:


 Summary: Livy doesn't work under kerberos and ssl 
 Key: ZEPPELIN-2584
 URL: https://issues.apache.org/jira/browse/ZEPPELIN-2584
 Project: Zeppelin
  Issue Type: Bug
Affects Versions: 0.7.1
Reporter: Jeff Zhang
Assignee: Jeff Zhang






--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[GitHub] zeppelin issue #2343: [ZEPPELIN-2538] JDBC completer improvements for work w...

2017-05-24 Thread astroshim
Github user astroshim commented on the issue:

https://github.com/apache/zeppelin/pull/2343
  
@tinkoff-dwh Sorry it was my problem.
Tested and working good!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin pull request #2363: [ZEPPELIN-2152] Added proxy config support in H...

2017-05-24 Thread necosta
Github user necosta closed the pull request at:

https://github.com/apache/zeppelin/pull/2363


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin pull request #2363: [ZEPPELIN-2152] Added proxy config support in H...

2017-05-24 Thread necosta
GitHub user necosta reopened a pull request:

https://github.com/apache/zeppelin/pull/2363

[ZEPPELIN-2152] Added proxy config support in Helium bundle factory

### What is this PR for?
Proxy configuration implementation in Helium bundle factory. Used by Node, 
NPM and YarnPkg installers.


### What type of PR is it?
[Improvement]

### What is the Jira issue?
* https://issues.apache.org/jira/browse/ZEPPELIN-2152

### How should this be tested?
Trigger Helium plugins behind proxy

### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nokia/zeppelin zeppelin2152

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/2363.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2363






---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #2343: [ZEPPELIN-2538] JDBC completer improvements for work w...

2017-05-24 Thread tinkoff-dwh
Github user tinkoff-dwh commented on the issue:

https://github.com/apache/zeppelin/pull/2343
  
@astroshim 
it is strangely. do you package new jar? 407 line SqlConleter.java it is 
start of comment (multiline)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #2343: [ZEPPELIN-2538] JDBC completer improvements for work w...

2017-05-24 Thread astroshim
Github user astroshim commented on the issue:

https://github.com/apache/zeppelin/pull/2343
  
I think this feature is really cool.
BTW I got following exception whenever i try to run sql completion.

```
==> logs/zeppelin-interpreter-jdbc-jdbc.log <==
ERROR [2017-05-25 01:29:57,441] ({pool-1-thread-5} 
TThreadPoolServer.java[run]:296) - Error occurred during processing of message.
java.lang.NullPointerException
at 
org.apache.zeppelin.jdbc.SqlCompleter.completeKeyword(SqlCompleter.java:407)
at 
org.apache.zeppelin.jdbc.SqlCompleter.completeName(SqlCompleter.java:469)
at org.apache.zeppelin.jdbc.SqlCompleter.complete(SqlCompleter.java:105)
at 
org.apache.zeppelin.jdbc.JDBCInterpreter.completion(JDBCInterpreter.java:844)
at 
org.apache.zeppelin.interpreter.LazyOpenInterpreter.completion(LazyOpenInterpreter.java:136)
at 
org.apache.zeppelin.interpreter.remote.RemoteInterpreterServer.completion(RemoteInterpreterServer.java:573)
at 
org.apache.zeppelin.interpreter.thrift.RemoteInterpreterService$Processor$completion.getResult(RemoteInterpreterService.java:1940)
at 
org.apache.zeppelin.interpreter.thrift.RemoteInterpreterService$Processor$completion.getResult(RemoteInterpreterService.java:1925)
at org.apache.thrift.ProcessFunction.process(ProcessFunction.java:39)
at org.apache.thrift.TBaseProcessor.process(TBaseProcessor.java:39)
at 
org.apache.thrift.server.TThreadPoolServer$WorkerProcess.run(TThreadPoolServer.java:285)
at 
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
at 
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
at java.lang.Thread.run(Thread.java:745)

==> logs/zeppelin-.local.log <==
ERROR [2017-05-25 01:29:57,443] ({qtp517210187-14} 
NotebookServer.java[onMessage]:383) - Can't handle message
org.apache.zeppelin.interpreter.InterpreterException: 
org.apache.thrift.transport.TTransportException
at 
org.apache.zeppelin.interpreter.remote.RemoteInterpreter.completion(RemoteInterpreter.java:493)
at 
org.apache.zeppelin.interpreter.LazyOpenInterpreter.completion(LazyOpenInterpreter.java:136)
at org.apache.zeppelin.notebook.Paragraph.completion(Paragraph.java:304)
at org.apache.zeppelin.notebook.Note.completion(Note.java:664)
at 
org.apache.zeppelin.socket.NotebookServer.completion(NotebookServer.java:1345)
at 
org.apache.zeppelin.socket.NotebookServer.onMessage(NotebookServer.java:330)
at 
org.apache.zeppelin.socket.NotebookSocket.onWebSocketText(NotebookSocket.java:59)
at 
org.eclipse.jetty.websocket.common.events.JettyListenerEventDriver.onTextMessage(JettyListenerEventDriver.java:128)
at 
org.eclipse.jetty.websocket.common.message.SimpleTextMessage.messageComplete(SimpleTextMessage.java:69)
at 
org.eclipse.jetty.websocket.common.events.AbstractEventDriver.appendMessage(AbstractEventDriver.java:65)
at 
org.eclipse.jetty.websocket.common.events.JettyListenerEventDriver.onTextFrame(JettyListenerEventDriver.java:122)
at 
org.eclipse.jetty.websocket.common.events.AbstractEventDriver.incomingFrame(AbstractEventDriver.java:161)
at 
org.eclipse.jetty.websocket.common.WebSocketSession.incomingFrame(WebSocketSession.java:309)
at 
org.eclipse.jetty.websocket.common.extensions.ExtensionStack.incomingFrame(ExtensionStack.java:214)
at 
org.eclipse.jetty.websocket.common.Parser.notifyFrame(Parser.java:220)
at org.eclipse.jetty.websocket.common.Parser.parse(Parser.java:258)
at 
org.eclipse.jetty.websocket.common.io.AbstractWebSocketConnection.readParse(AbstractWebSocketConnection.java:632)
at 
org.eclipse.jetty.websocket.common.io.AbstractWebSocketConnection.onFillable(AbstractWebSocketConnection.java:480)
at 
org.eclipse.jetty.io.AbstractConnection$2.run(AbstractConnection.java:544)
at 
org.eclipse.jetty.util.thread.QueuedThreadPool.runJob(QueuedThreadPool.java:635)
at 
org.eclipse.jetty.util.thread.QueuedThreadPool$3.run(QueuedThreadPool.java:555)
at java.lang.Thread.run(Thread.java:745)
Caused by: org.apache.thrift.transport.TTransportException
at 
org.apache.thrift.transport.TIOStreamTransport.read(TIOStreamTransport.java:132)
at org.apache.thrift.transport.TTransport.readAll(TTransport.java:86)
at 
org.apache.thrift.protocol.TBinaryProtocol.readAll(TBinaryProtocol.java:429)
at 
org.apache.thrift.protocol.TBinaryProtocol.readI32(TBinaryProtocol.java:318)
at 
org.apache.thrift.protocol.TBinaryProtocol.readMessageBegin(TBinaryProtocol.java:219)
at org.apache.thrift.TServiceClient.receiveBase(TServiceClient.java:69)
at 
org.apache.zeppelin.interpreter.thrift.RemoteInterpreterService$Client.recv_completion(RemoteInterpreterService.java:372)
at 
org.apache.z

[GitHub] zeppelin issue #2349: [ZEPPELIN-2214] Set npm installer default npm registry

2017-05-24 Thread necosta
Github user necosta commented on the issue:

https://github.com/apache/zeppelin/pull/2349
  
@1ambda ,
Renamed "zeppelin.helium.npm.registry" to 
"zeppelin.helium.npm.installer.url"
I understand there is no need to update file "upgrade.md" as the change in 
conf value is inside the same version (0.8)
Ready for review.  Thanks


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #2363: [ZEPPELIN-2152] Added proxy config support in Helium b...

2017-05-24 Thread necosta
Github user necosta commented on the issue:

https://github.com/apache/zeppelin/pull/2363
  
@1ambda ,
* Added documentation although I'm unclear if that is what you are after. 
* Fixed bug where secure proxy was used for insecure connections (now http 
proxy for http connections, https proxy for https connections)
* Added proxy config for Helium Online registry


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin pull request #2363: [ZEPPELIN-2152] Added proxy config support in H...

2017-05-24 Thread necosta
GitHub user necosta reopened a pull request:

https://github.com/apache/zeppelin/pull/2363

[ZEPPELIN-2152] Added proxy config support in Helium bundle factory

### What is this PR for?
Proxy configuration implementation in Helium bundle factory. Used by Node, 
NPM and YarnPkg installers.


### What type of PR is it?
[Improvement]

### What is the Jira issue?
* https://issues.apache.org/jira/browse/ZEPPELIN-2152

### How should this be tested?
Trigger Helium plugins behind proxy

### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nokia/zeppelin zeppelin2152

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/2363.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2363


commit d9a086ab2d1c1e8362c7635760a2aa508df06f4d
Author: Nelson Costa 
Date:   2017-05-23T20:48:54Z

[ZEPPELIN-2152] Added proxy config support in Helium bundle factory

commit f55e6e26323ef1749a29ce3b3cdee1bf560a4316
Author: Nelson Costa 
Date:   2017-05-24T08:39:57Z

[ZEPPELIN-2152] Fixed bug in secure/insecure proxy. Added proxy for 
HeliumOnlineRegistry

commit 5e29cca41bab1e16ed97358429ade950b3fc2755
Author: Nelson Costa 
Date:   2017-05-24T09:38:55Z

[ZEPPELIN-2152] Fixed format issues




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin pull request #2363: [ZEPPELIN-2152] Added proxy config support in H...

2017-05-24 Thread necosta
Github user necosta closed the pull request at:

https://github.com/apache/zeppelin/pull/2363


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin pull request #2349: [ZEPPELIN-2214] Set npm installer default npm r...

2017-05-24 Thread necosta
GitHub user necosta reopened a pull request:

https://github.com/apache/zeppelin/pull/2349

[ZEPPELIN-2214] Set npm installer default npm registry

### What is this PR for?
Complements ZEPPELIN-2278, this is a fix for "connection timeout" bug when 
trying to run "npm install" behind a proxy. Instead of connecting to the 
official nodejs site from behind a proxy, we should use the already soft-coded 
env variable ZEPPELIN_HELIUM_NPM_REGISTRY repository.

### What type of PR is it?
Bug Fix

### ToDos
* [x] - Soft-code npm folder name as well (currently hardcoded "npm") - To 
be agreed on...

### What is the Jira issue?
* [ZEPPELIN-2214 - Bug on connecting to the official nodejs site from 
behind a proxy]

### How should this be tested?
Enable any Helium plugin from behind a proxy

### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nokia/zeppelin zeppelin2214

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/2349.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2349


commit 9fbf9638a0f4647cf3642220c9a5ad908ac8dfe3
Author: Nelson Costa 
Date:   2017-05-19T09:40:29Z

[ZEPPELIN-2214] Set npm installer default npm registry

commit 877dd9d1c31bb2544109146f4a69045b3ba6e0bb
Author: Nelson Costa 
Date:   2017-05-19T09:56:12Z

[ZEPPELIN-2214] Fixed broken CI

commit c6fc912aeffcb4b917e17a8dbec2b59a5eb7ed33
Author: Nelson Costa 
Date:   2017-05-22T07:33:13Z

[ZEPPELIN-2214] Renamed variables

commit f27ce8a80551a33027ad78474b3981d84d0f7aa9
Author: Nelson Costa 
Date:   2017-05-22T08:02:43Z

[ZEPPELIN-2214] Fixed broken CI

commit 5010a8c32c7ad03bc13bb9b515dbd94b0cf13250
Author: Nelson Costa 
Date:   2017-05-23T06:57:53Z

[ZEPPELIN-2214] Renamed yarn to yarnpkg

commit 8448a93ae2d36af0f3907e22c1bfc65cdd8a9664
Author: Nelson Costa 
Date:   2017-05-24T07:07:14Z

[ZEPPELIN-2214] Renamed npm registry to npm installer url




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin pull request #2349: [ZEPPELIN-2214] Set npm installer default npm r...

2017-05-24 Thread necosta
Github user necosta closed the pull request at:

https://github.com/apache/zeppelin/pull/2349


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Created] (ZEPPELIN-2583) Updating Official Website

2017-05-24 Thread Hoon Park (JIRA)
Hoon Park created ZEPPELIN-2583:
---

 Summary: Updating Official Website
 Key: ZEPPELIN-2583
 URL: https://issues.apache.org/jira/browse/ZEPPELIN-2583
 Project: Zeppelin
  Issue Type: Improvement
  Components: documentation
Reporter: Hoon Park


Updating Official Website. We are currently discussing on the mailing list too.

--

I would like to suggest updating official homepage. Here are few reasons.

1. It’s hard to find content for beginners.

For example, Let’s say I want to use python and don’t much know about Zeppelin. 
But the main page doesn’t say what should I do. 

As you know, The tutorial is quite outdated and The homepage doesn’t have a 
*getting started* section. 

Also, if I want to know how to use `%python` interpreter, I should click twice.

- Docs -> Version
- Interpreter -> Python

However, I don’t see beginner can do this easily. Even they don’t know what is 
the interpreter. 

2. Content is not organized for different types of users. 

Some users are admins. Others might be just individual users or developers. But 
the current official page doesn’t provide useful information for each group.  

For example, an admin might want to know about multiple user supports. (Login  
/ Logout) or Let’s say I want to configure zeppelin spark interpreter for my 
yarn / mesos cluster. But the problem is, It’s not easy to find that 
information. Also, some information is not included in official docs.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[GitHub] zeppelin issue #2343: [ZEPPELIN-2538] JDBC completer improvements for work w...

2017-05-24 Thread cloverhearts
Github user cloverhearts commented on the issue:

https://github.com/apache/zeppelin/pull/2343
  
I will test on this pr.
Thank you for greate feature. :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


Re: JdbcInterpreter might be too generic

2017-05-24 Thread Jongyoul Lee
In addtion to shim's idea, that feature was implemented when we didn't
support to change interpreter name. Now, that feature is out-date and I
suggest to reemove that feature now. Now, Zeppelin supports to make several
jdbc interpreter at the same time. I suggest to ise this way.

On Wed, 24 May 2017 at 05:39 Hyung Sung Shim  wrote:

> I agree with your idea and
> +1 to create one
> interpreter setting for each database.
> 2017년 5월 24일 (수) 오후 3:45, Jeff Zhang 님이 작성:
>
> > The current JdbcInterpreter implementation seems too generic for me.
> > Two main reasons
> >
> > 1. The logic of executing sql in JdbcInterpeter is a little weird. Here's
> > is what jdbc interpreter would do for "%jdbc(mysql) show tables"
> > The script part is actually `(mysql) show tables` rather than `show
> > tables`, jdbc interpreter first parse it to get property key `mysql` then
> > execute sql `show tables` for mysql.  This is kind weird to do parsing in
> > jdbc interpreter. I would use '%jdbc(mysql)' as interpreter name part,
> > `mysql` could be some kind of interpreter property, but never to make
> > interpreter to do parsing again. 'show tables' should be the sql script
> > part which is sent to jdbc interpreter. Doing specific parsing in
> > interpreter is not a good practise IMHO. This also make the parsing
> > repl/script logic a little weird in Paragraph.java
> >
> > 2. All the database would share the same interpreter setting. such as
> > keytab, principal, common.max_count. And it just depends on the
> propertyKey
> > to decide to connect which database. I would say it is better to create
> one
> > interpreter setting for each database rather than mixing them together,
> > this would cause JdbcInterpreter very fragile, as changes for one
> database
> > may affect other databases. I am not sure whether this is because
> creating
> > new interpreter setting is not available when the jdbc interpreter is
> > implemented. if user create interpreter setting for each database, then
> he
> > doesn't need to specify `(mysql)` as point 1.
> >
> > Welcome any comments and thoughts on this.
> >
>
-- 
이종열, Jongyoul Lee, 李宗烈
http://madeng.net


[jira] [Created] (ZEPPELIN-2582) Clarify docs on interpreters, interpreter groups and interpreter binding modes

2017-05-24 Thread Lucas Partridge (JIRA)
Lucas Partridge created ZEPPELIN-2582:
-

 Summary: Clarify docs on interpreters, interpreter groups and 
interpreter binding modes
 Key: ZEPPELIN-2582
 URL: https://issues.apache.org/jira/browse/ZEPPELIN-2582
 Project: Zeppelin
  Issue Type: Improvement
  Components: documentation
Affects Versions: 0.7.1
Reporter: Lucas Partridge


I've read the overview docs on interpreters at 
http://zeppelin.apache.org/docs/0.7.1/manual/interpreters.html and 
http://zeppelin.apache.org/docs/0.7.1/development/writingzeppelininterpreter.html
 but I'm still confused! E.g., at 
http://zeppelin.apache.org/docs/0.7.1/manual/interpreters.html#interpreter-binding-mode
 it says "In 'isolated' mode, each notebook will create new Interpreter 
process." Does that mean a new JVM process, or a new process (with its own 
interpreter instance) in the same JVM as the Interpreter Group?

Please can we have a simple explanation in one place about the relationship 
between the following entities:

JVM
Spark Driver program
Interpreter group
Interpreter settings
Interpreter
Interpreter binding mode for notebooks

A diagram showing the relationship between these entities for the 3 different 
interpreter binding notes (shared, scoped, isolated) would be extremely 
helpful. This would help users understand the implications of the different 
modes - for example, whether they can share a SparkContext and hence data or 
variables between different notebooks. Or what would happen to another user's 
notebook if a given Interpreter Group is restarted. Thanks!




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


[jira] [Created] (ZEPPELIN-2581) Support ANSI colors in shell outputs

2017-05-24 Thread Zoltan Haindrich (JIRA)
Zoltan Haindrich created ZEPPELIN-2581:
--

 Summary: Support ANSI colors in shell outputs
 Key: ZEPPELIN-2581
 URL: https://issues.apache.org/jira/browse/ZEPPELIN-2581
 Project: Zeppelin
  Issue Type: Improvement
Reporter: Zoltan Haindrich


It would be great to have color support for shell commands.

{code}
%sh
ls -la --color=yes
{code}

https://en.wikipedia.org/wiki/ANSI_escape_code

in case this is not possible...an option to remove/strip color codes from the 
output would be also usefull.




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)


Re: JdbcInterpreter might be too generic

2017-05-24 Thread Hyung Sung Shim
I agree with your idea and
+1 to create one
interpreter setting for each database.
2017년 5월 24일 (수) 오후 3:45, Jeff Zhang 님이 작성:

> The current JdbcInterpreter implementation seems too generic for me.
> Two main reasons
>
> 1. The logic of executing sql in JdbcInterpeter is a little weird. Here's
> is what jdbc interpreter would do for "%jdbc(mysql) show tables"
> The script part is actually `(mysql) show tables` rather than `show
> tables`, jdbc interpreter first parse it to get property key `mysql` then
> execute sql `show tables` for mysql.  This is kind weird to do parsing in
> jdbc interpreter. I would use '%jdbc(mysql)' as interpreter name part,
> `mysql` could be some kind of interpreter property, but never to make
> interpreter to do parsing again. 'show tables' should be the sql script
> part which is sent to jdbc interpreter. Doing specific parsing in
> interpreter is not a good practise IMHO. This also make the parsing
> repl/script logic a little weird in Paragraph.java
>
> 2. All the database would share the same interpreter setting. such as
> keytab, principal, common.max_count. And it just depends on the propertyKey
> to decide to connect which database. I would say it is better to create one
> interpreter setting for each database rather than mixing them together,
> this would cause JdbcInterpreter very fragile, as changes for one database
> may affect other databases. I am not sure whether this is because creating
> new interpreter setting is not available when the jdbc interpreter is
> implemented. if user create interpreter setting for each database, then he
> doesn't need to specify `(mysql)` as point 1.
>
> Welcome any comments and thoughts on this.
>


[jira] [Created] (ZEPPELIN-2580) Doesn't highlight syntax when interpreter have prefix

2017-05-24 Thread Alexandre Thorez (JIRA)
Alexandre Thorez created ZEPPELIN-2580:
--

 Summary: Doesn't highlight syntax when interpreter have prefix
 Key: ZEPPELIN-2580
 URL: https://issues.apache.org/jira/browse/ZEPPELIN-2580
 Project: Zeppelin
  Issue Type: Bug
  Components: Interpreters
Affects Versions: 0.7.1
Reporter: Alexandre Thorez
Priority: Minor


For example, when jdbc interpreter have argument like %jdbc(toto), highlight 
syntax doesn't work



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)