[GitHub] zeppelin issue #2442: [ZEPPELIN-2679] JDBC. precode for session

[tinkoff-dwh]

Github user tinkoff-dwh commented on the issue:

https://github.com/apache/zeppelin/pull/2442
  
Ready to review


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2474: [ZEPPELIN-2753] Basic Implementation of IPython Interp...

[zjffdu]

Github user zjffdu commented on the issue:

https://github.com/apache/zeppelin/pull/2474
  
@1ambda I did some investtigation on that, and puts some links in 
https://issues.apache.org/jira/browse/ZEPPELIN-2756, hope it would be helpful 
for you.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2462: ZEPPELIN-2527 Changed editor cursor to thin

[1ambda]

Github user 1ambda commented on the issue:

https://github.com/apache/zeppelin/pull/2462
  
Hi, @malayhm Could you take a look the comment I left? Thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2474: [ZEPPELIN-2753] Basic Implementation of IPython Interp...

[1ambda]

Github user 1ambda commented on the issue:

https://github.com/apache/zeppelin/pull/2474
  
Let create a PR to fix the ASCII issue, we can test this PR based on the 
ASCII PR.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2478: [ZEPPELIN-2761] - Neo4j Interpreter

[1ambda]

Github user 1ambda commented on the issue:

https://github.com/apache/zeppelin/pull/2478
  
Thanks for the great feature! since this is a big change, I guess it takes 
a time to review and requires multiple reviewers. Let me take a look.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2446: [ZEPPELIN-2699] Helium REST API bug-fixes. Also update...

[1ambda]

Github user 1ambda commented on the issue:

https://github.com/apache/zeppelin/pull/2446
  
@necosta Tested locally and it works well.

Could you rebase using the current master? since the base branch looks 
quite old. 
LGTM except for it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2475: [ZEPPELIN-2757] Enhance Authentication decrypting key ...

[1ambda]

Github user 1ambda commented on the issue:

https://github.com/apache/zeppelin/pull/2475
  
Left a comment, except for it, LGTM.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #2487: [ZEPPELIN-2769] Prevent SQL injection for GetUs...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/zeppelin/pull/2487


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2458: Zeppelin 2701 - Set HTML title for notebook page

[1ambda]

Github user 1ambda commented on the issue:

https://github.com/apache/zeppelin/pull/2458
  
CI is green, I think jenkins was restarted somehow. 

- https://travis-ci.org/ebuildy/zeppelin/builds/253975556

LGTM merge if no more discussion.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2458: Zeppelin 2701 - Set HTML title for notebook page

[soralee]

Github user soralee commented on the issue:

https://github.com/apache/zeppelin/pull/2458
  
@ebuildy could you check CI?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #2455: ZEPPELIN-1515. Notebook: HDFS as a backend stor...

[zjffdu]

Github user zjffdu closed the pull request at:

https://github.com/apache/zeppelin/pull/2455


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #2455: ZEPPELIN-1515. Notebook: HDFS as a backend stor...

[zjffdu]

GitHub user zjffdu reopened a pull request:

https://github.com/apache/zeppelin/pull/2455

ZEPPELIN-1515. Notebook: HDFS as a backend storage (Use hadoop client jar)

### What is this PR for?
This PR is trying to add hdfs as another implementation for `NotebookRepo`. 
There's another PR about using webhdfs to implement that. Actually hdfs client 
library is compatibility cross major versions. See 
http://hadoop.apache.org/docs/stable/hadoop-project-dist/hadoop-common/Compatibility.html#Wire_compatibility,
 if using webhdfs, the code become more complicated and may lose some features 
of hdfs. 

This PR is also required for HA of zeppelin, so that multiple zeppelin 
instances can share notes via hdfs.  Besides I add hadoop-client in pom file. 
So zeppelin will package hadoop client jar into its binary distribution. This 
is because zeppelin may be installed in a gateway machine where no hadoop is 
installed (only hadoop configuration file is existed in this machine) And since 
the hadoop client will work with multiple versions of hadoop, so it is fine to 
package into binary distribution. Spark also package hadoop client jar in its 
binary distribution. 

### What type of PR is it?
[Feature]

### Todos
* [ ] - Task

### What is the Jira issue?
* https://issues.apache.org/jira/browse/ZEPPELIN-1515

### How should this be tested?
Unit test is added.  Also manually verify it in a single node cluster. 

### Screenshots (if appropriate)

### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/zjffdu/zeppelin ZEPPELIN-1515

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/2455.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2455


commit 71b978d3d24afe32470b0516eeb6f2caff947cc1
Author: Jeff Zhang 
Date:   2017-06-30T06:48:22Z

ZEPPELIN-1515. Notebook: HDFS as a backend storage (Read & Write Mode)




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2458: Zeppelin 2701 - Set HTML title for notebook page

[soralee]

Github user soralee commented on the issue:

https://github.com/apache/zeppelin/pull/2458
  
Tested and LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2474: [ZEPPELIN-2753] Basic Implementation of IPython Interp...

[zjffdu]

Github user zjffdu commented on the issue:

https://github.com/apache/zeppelin/pull/2474
  
Thanks @Leemoonsoo for catching that. This is due to I miss cursor for code 
completion. Just pushed another commit to fix that and add more unit test for 
it.

```
// there's no completion for 'a.' because it is not recognized by 
compiler for now.
String st = "a='hello'\na.";
completions = interpreter.completion(st, st.length(), 
getInterpreterContext());
assertEquals(0, completions.size());

// define a first
st = "a='hello'";
result = interpreter.interpret(st, getInterpreterContext());
assertEquals(InterpreterResult.Code.SUCCESS, result.code());

// now we can get the completion for `a.`
st = "a.";
completions = interpreter.completion(st, st.length(), 
getInterpreterContext());
// it is differnet for python2 and python3 and may even different for 
different minor version
// so only verify it is larger than 20
assertTrue(completions.size() > 20);

st = "a.ca";
completions = interpreter.completion(st, st.length(), 
getInterpreterContext());
// a.capitalize
// a.casefold
assertEquals(2, completions.size());

// cursor is in the middle of code
st = "a.ca\b='hello";
completions = interpreter.completion(st, 4, getInterpreterContext());
// a.capitalize
// a.casefold
assertEquals(2, completions.size());

```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2474: [ZEPPELIN-2753] Basic Implementation of IPython Interp...

[Leemoonsoo]

Github user Leemoonsoo commented on the issue:

https://github.com/apache/zeppelin/pull/2474
  
Is it expected completion list?

![image](https://user-images.githubusercontent.com/1540981/28252185-32d695a8-6ac9-11e7-9f29-2257700990d0.png)



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2474: [ZEPPELIN-2753] Basic Implementation of IPython Interp...

[zjffdu]

Github user zjffdu commented on the issue:

https://github.com/apache/zeppelin/pull/2474
  
Yes, that works. It is covered in unit test 
(https://github.com/apache/zeppelin/pull/2474/files#diff-d9c8252d37a199d13b7157e88041c0e9R124).
  Also I manually verified it 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2474: [ZEPPELIN-2753] Basic Implementation of IPython Interp...

[Leemoonsoo]

Github user Leemoonsoo commented on the issue:

https://github.com/apache/zeppelin/pull/2474
  
Tested 88a1f2f and ZeppelinContext works well.

Does auto completion supposed to work?



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[DISCUSS] Release 0.8.0

[Park Hoon]

Hi, @user and @dev.

Recently, The last major release was about 5 months ago and many new
features bug fixes have been implemented / applied for few months.

Even though all features discussed in the thread before (“Roadmap for
0.8.0”[1]), some are available now.

So I think we can release 0.8.0 as the latest one while keeping 0.7.2 as
the most stable one as @moon suggested in the “Roadmap for 0.8.0” mailing
thread.

Shall we proceed to 0.8.0?

Here is the umbrella issue for the release 0.8.0. If you have issues to be
shared, Please add them to the ticket.

- https://issues.apache.org/jira/browse/ZEPPELIN-2385

[1]
https://lists.apache.org/thread.html/f4be5635e6e72d2a9dc23771ceeaef8a8e5933bfb14db7cab303bc22@%3Cdev.zeppelin.apache.org%3E

Regard,