[GitHub] zeppelin pull request #2553: Revert "[ZEPPELIN-2627] Interpreter refactor"

2017-08-27 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/zeppelin/pull/2553


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin pull request #2553: Revert "[ZEPPELIN-2627] Interpreter refactor"

2017-08-27 Thread zjffdu
GitHub user zjffdu opened a pull request:

https://github.com/apache/zeppelin/pull/2553

Revert "[ZEPPELIN-2627] Interpreter refactor"

This reverts commit 8d4902e717ba2932ddb0f7110f2a669811f5d1af.

### What is this PR for?

Just revert ZEPPELIN-2627


### What type of PR is it?
[Refactoring]

### Todos
* [ ] - Task

### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-2627

### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/zjffdu/zeppelin Revert_2627

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/2553.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2553


commit 222d957b80fad0e0d9e998d739fce620a8021913
Author: Jeff Zhang 
Date:   2017-08-28T05:51:57Z

Revert "[ZEPPELIN-2627] Interpreter refactor"

This reverts commit 8d4902e717ba2932ddb0f7110f2a669811f5d1af.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #2422: [ZEPPELIN-2627] Interpreter refactor

2017-08-27 Thread zjffdu
Github user zjffdu commented on the issue:

https://github.com/apache/zeppelin/pull/2422
  
Sorry, I found it conflicts with other PRs, will revert it now. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Created] (ZEPPELIN-2884) Move some interpreter classes to zeppelin-zengine

2017-08-27 Thread Jeff Zhang (JIRA)
Jeff Zhang created ZEPPELIN-2884:


 Summary: Move some interpreter classes to zeppelin-zengine
 Key: ZEPPELIN-2884
 URL: https://issues.apache.org/jira/browse/ZEPPELIN-2884
 Project: Zeppelin
  Issue Type: Sub-task
Reporter: Jeff Zhang


Some classes is only required in zeppelin server and not required by 
interpreter implementation, such as InterpreterFactory, InterpreterSetting and 
etc, these should be moved to zeppelin-zengine. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)


[GitHub] zeppelin pull request #2422: [ZEPPELIN-2627] Interpreter refactor

2017-08-27 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/zeppelin/pull/2422


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #2510: [ZEPPELIN-2756] Support ansi escape code for colorizin...

2017-08-27 Thread zjffdu
Github user zjffdu commented on the issue:

https://github.com/apache/zeppelin/pull/2510
  
@1ambda I have merged #2474, can you rebase this PR ? Thanks


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin pull request #2474: [ZEPPELIN-2753] Basic Implementation of IPython...

2017-08-27 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/zeppelin/pull/2474


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #2474: [ZEPPELIN-2753] Basic Implementation of IPython Interp...

2017-08-27 Thread zjffdu
Github user zjffdu commented on the issue:

https://github.com/apache/zeppelin/pull/2474
  
I will merge it if no more comments


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #2526: [ZEPPELIN-2848] Added new type of user to only run not...

2017-08-27 Thread felixcheung
Github user felixcheung commented on the issue:

https://github.com/apache/zeppelin/pull/2526
  
any more comment?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #2502: [ZEPPELIN-2807] Passing Z variables to SQL Interpreter...

2017-08-27 Thread felixcheung
Github user felixcheung commented on the issue:

https://github.com/apache/zeppelin/pull/2502
  
could you review my comments? there are a number of comments from before 
that I feel we should address first.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin issue #2422: [ZEPPELIN-2627] Interpreter refactor

2017-08-27 Thread zjffdu
Github user zjffdu commented on the issue:

https://github.com/apache/zeppelin/pull/2422
  
@Leemoonsoo @jongyoul I will commit if no more comments so that I can 
continue the other work. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin pull request #2474: [ZEPPELIN-2753] Basic Implementation of IPython...

2017-08-27 Thread zjffdu
GitHub user zjffdu reopened a pull request:

https://github.com/apache/zeppelin/pull/2474

[ZEPPELIN-2753] Basic Implementation of IPython Interpreter

### What is this PR for?
This is the first step for implement IPython Interpreter in Zeppelin.  I 
just use the jupyter_client to create and manage the ipython kernel. We don't 
need to care about python compilation and execution, all the things are 
delegated to ipython kernel. Ideally all the features of ipython should be 
available in Zeppelin as well.  

For now, user can use %python.ipython for IPython Interpreter. And if 
ipython is available, the default python interpreter will use ipython. But user 
can still set `zeppelin.python.useIPython` as false to enforce to use the old 
implementation of python interpreter. 

Main features:
* IPython interpreter support
** All the ipython features are available, including visualization, ipython 
magics. 
* ZeppelinContext support
* Streaming output support
* Support Ipython in PySpark

Regarding the visualization, ideally all the visualization libraries work 
in jupyter should also work here.
In unit test, I only verify the following 3 popular visualization library. 
could add more later.
* matplotlib
* bokeh
* ggplot

### What type of PR is it?
[Feature ]

### Todos
* [ ] - Task

### What is the Jira issue?
* https://issues.apache.org/jira/browse/ZEPPELIN-2753

### How should this be tested?
Unit test is added. 

### Screenshots (if appropriate)
Verify bokeh in IPython Interpreter

![image](https://user-images.githubusercontent.com/164491/27999716-756d749e-6552-11e7-90bb-4c6b08f4ab5c.png)

Verify matplotlib

![image](https://user-images.githubusercontent.com/164491/28046960-e881b28e-6619-11e7-9e1f-7f4662f842f3.png)

Verify ZeppelinContext


![image](https://user-images.githubusercontent.com/164491/28119378-4212620c-6747-11e7-89d5-3b5e609593ce.png)

Verify Streaming

![streaming](https://user-images.githubusercontent.com/164491/28950974-8f92fe1e-78fa-11e7-841f-3174da198bb7.gif)

### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/zjffdu/zeppelin ZEPPELIN-2753

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/2474.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2474


commit b0b5c95a6802c595177c187e8363c08c7e464a54
Author: Jeff Zhang 
Date:   2017-07-02T07:51:14Z

[ZEPPELIN-2753] Basic Implementation of IPython Interpreter

commit e869f31d07650685907eb00b0ce2d2c15869232d
Author: Jeff Zhang 
Date:   2017-08-26T03:59:43Z

address comments




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] zeppelin pull request #2474: [ZEPPELIN-2753] Basic Implementation of IPython...

2017-08-27 Thread zjffdu
Github user zjffdu closed the pull request at:

https://github.com/apache/zeppelin/pull/2474


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---