[GitHub] zeppelin issue #2575: [ZEPPELIN-2921] does not work conda environment in pyt...

2017-09-08 Thread cloverhearts 
Github user cloverhearts commented on the issue:

https://github.com/apache/zeppelin/pull/2575
  
https://github.com/apache/zeppelin/pull/2574

same pr and different base branch


---

[GitHub] zeppelin issue #2574: [ZEPPELIN-2921 : 0.7x] does not work conda environment...

2017-09-08 Thread cloverhearts 
Github user cloverhearts commented on the issue:

https://github.com/apache/zeppelin/pull/2574
  
https://travis-ci.org/malayhm/zeppelin/jobs/272788659
https://travis-ci.org/1ambda/zeppelin/jobs/273195461



---

[GitHub] zeppelin issue #2574: [ZEPPELIN-2921 : 0.7x] does not work conda environment...

2017-09-08 Thread cloverhearts 
Github user cloverhearts commented on the issue:

https://github.com/apache/zeppelin/pull/2574
  
```
Tests run: 2, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 12.456 sec 
<<< FAILURE! - in 
org.apache.zeppelin.interpreter.remote.RemoteInterpreterServerTest

testStartStop(org.apache.zeppelin.interpreter.remote.RemoteInterpreterServerTest)
  Time elapsed: 10.037 sec  <<< FAILURE!
java.lang.AssertionError: expected: but was:
at org.junit.Assert.fail(Assert.java:88)
at org.junit.Assert.failNotEquals(Assert.java:834)
at org.junit.Assert.assertEquals(Assert.java:118)
at org.junit.Assert.assertEquals(Assert.java:144)
at 
org.apache.zeppelin.interpreter.remote.RemoteInterpreterServerTest.testStartStop(RemoteInterpreterServerTest.java:62)
```

This error occurs equally in other PRs and branches.
It has been confirmed that it is not related to my changes.


---

[GitHub] zeppelin issue #2576: [hotfix] JDBC connection does not release when got exc...

2017-09-08 Thread cloverhearts 
Github user cloverhearts commented on the issue:

https://github.com/apache/zeppelin/pull/2576
  
If there is no new comment, I will merge it.


---

[GitHub] zeppelin issue #2576: [hotfix] JDBC connection does not release when got exc...

2017-09-08 Thread cloverhearts 
Github user cloverhearts commented on the issue:

https://github.com/apache/zeppelin/pull/2576
  
Tested :)
Thank you for good fix.


---

[GitHub] zeppelin issue #2574: [ZEPPELIN-2921 : 0.7x] does not work conda environment...

2017-09-08 Thread cloverhearts 
Github user cloverhearts commented on the issue:

https://github.com/apache/zeppelin/pull/2574
  
@1ambda I'll check it, thank you :)


---

[GitHub] zeppelin issue #2574: [ZEPPELIN-2921 : 0.7x] does not work conda environment...

2017-09-08 Thread 1ambda 
Github user 1ambda commented on the issue:

https://github.com/apache/zeppelin/pull/2574
  
@cloverhearts I am getting this error. 


![image](https://user-images.githubusercontent.com/4968473/30237013-42ab57c4-9563-11e7-9102-2dccee8db1fb.png)


![image](https://user-images.githubusercontent.com/4968473/30237008-33828cb8-9563-11e7-83a3-1c9248f36cb1.png)



---

[GitHub] zeppelin issue #2573: [ZEPPELIN-2920] move commonly used error handlers to u...

2017-09-08 Thread 1ambda 
Github user 1ambda commented on the issue:

https://github.com/apache/zeppelin/pull/2573
  
CI failed but irrelevant

```
Failed tests: 
  RemoteInterpreterServerTest.testStartStop:62 expected: but 
was:
```

- 
https://s3.amazonaws.com/archive.travis-ci.org/jobs/273195461/log.txt?X-Amz-Expires=30&X-Amz-Date=20170909T042527Z&X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Credential=AKIAJRYRXRSVGNKPKO5A/20170909/us-east-1/s3/aws4_request&X-Amz-SignedHeaders=host&X-Amz-Signature=92cb9be0c7d2f3504f8a989203f575f4401baeeb029b4ee48fead89b93e6c2cb


---

[GitHub] zeppelin issue #2572: [ZEPPELIN-2919] fix: Fallback to table when vis is not...

2017-09-08 Thread 1ambda 
Github user 1ambda commented on the issue:

https://github.com/apache/zeppelin/pull/2572
  
Thanks for the review. Merge if no more discussion.


---

[GitHub] zeppelin pull request #2563: ZEPPELIN-204 make scala code completion work ag...

2017-09-08 Thread asfgit 
Github user asfgit closed the pull request at:

https://github.com/apache/zeppelin/pull/2563


---

[GitHub] zeppelin issue #2563: ZEPPELIN-204 make scala code completion work again

2017-09-08 Thread felixcheung 
Github user felixcheung commented on the issue:

https://github.com/apache/zeppelin/pull/2563
  
we are just wrapping up, shouldn't need anything at this point.


---

[GitHub] zeppelin issue #2563: ZEPPELIN-204 make scala code completion work again

2017-09-08 Thread pellmont 
Github user pellmont commented on the issue:

https://github.com/apache/zeppelin/pull/2563
  
do I have to do something else before it can be merged? or just wait?


---

[GitHub] zeppelin issue #2576: [hotfix] JDBC connection does not release when got exc...

2017-09-08 Thread Leemoonsoo 
Github user Leemoonsoo commented on the issue:

https://github.com/apache/zeppelin/pull/2576
  
Tested jdbc interpreter test manually and CI failure looks irrelevant.

LGTM


---

[GitHub] zeppelin issue #2572: [ZEPPELIN-2919] fix: Fallback to table when vis is not...

2017-09-08 Thread Leemoonsoo 
Github user Leemoonsoo commented on the issue:

https://github.com/apache/zeppelin/pull/2572
  
LGTM!


---

[GitHub] zeppelin pull request #2576: [hotfix] JDBC connection does not release when ...

2017-09-08 Thread astroshim 
GitHub user astroshim opened a pull request:

https://github.com/apache/zeppelin/pull/2576

[hotfix] JDBC connection does not release when got exception.

### What is this PR for?
This PR fixes JDBC connection release problem.

for example when i run not executable command like following.

![image](https://user-images.githubusercontent.com/3348133/30206892-8248d1ae-94c8-11e7-9eae-a495be075892.png)

new JDBC connection is made like following.
```
$ netstat -an |grep EST |grep 3306 |wc -l
   1
$ netstat -an |grep EST |grep 3306 |wc -l
   2
$ netstat -an |grep EST |grep 3306 |wc -l
   3
```


### What type of PR is it?
Bug Fix


### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/astroshim/zeppelin fix/jdbcConnectionRelease

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/2576.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2576


commit 88d3edb980e508e72d4cdde8e75c1005efcadda8
Author: Shim 
Date:   2017-09-08T09:55:24Z

fix jdbc connection relase issue.

commit 3ae59e9f0285d011f682393bf359cb0a6f89
Author: Shim 
Date:   2017-09-08T10:20:25Z

fixed exception codes




---

[GitHub] zeppelin issue #2525: [ZEPPELIN-2647] Make admin role to bypass auth logic

2017-09-08 Thread yu74n 
Github user yu74n commented on the issue:

https://github.com/apache/zeppelin/pull/2525
  
After fixed 'testSyncWithAcl', I manually restart CI. All test passed.


---

[GitHub] zeppelin pull request #2575: [ZEPPELIN-2921] does not work conda environment...

2017-09-08 Thread cloverhearts 
GitHub user cloverhearts opened a pull request:

https://github.com/apache/zeppelin/pull/2575

[ZEPPELIN-2921] does not work conda environment in python interpreter

### What is this PR for?
It seems that the environment of the python interpreter has changed to the 
py4j environment, causing problems with the library path and the default 
environment.

### What type of PR is it?
Bug Fix

### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-2921

### How should this be tested?
Please run the following command line for each paragraph.
If the module such as scipy is normally imported, it is a success.
`%python.conda create --name Hello6 python=2.7`
`%python.conda activate Hello6`
`%python.conda install seaborn pandas numpy scipy matplotlib`
```
%python
import scipy as sp
import seaborn as sns
```
`%python.conda deactivate`

### Screenshots (if appropriate)
 Before

![image](https://user-images.githubusercontent.com/10525473/30199920-c75022ca-94af-11e7-8811-0c22310f1bac.png)

 After

![image](https://user-images.githubusercontent.com/10525473/30198880-23aaceb2-94ab-11e7-8bc6-bfad76c675f7.png)


### Questions:
* Does the licenses files need update? no 
* Is there breaking changes for older versions? no
* Does this needs documentation? no


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/cloverhearts/zeppelin 
fix/conda-interpreter-invalid-path-0.8

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/2575.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2575


commit e2d2f53ec2de8c64d1df2cbf3e31ba7611509f74
Author: CloverHearts 
Date:   2017-09-08T06:23:11Z

add conda local env

commit a6b1a00a8cd944346a61484baf6b822b04d2a993
Author: CloverHearts 
Date:   2017-09-08T08:47:36Z

keep python binary




---

[GitHub] zeppelin issue #2574: [ZEPPELIN-2921 : 0.7x] does not work conda environment...

2017-09-08 Thread cloverhearts 
Github user cloverhearts commented on the issue:

https://github.com/apache/zeppelin/pull/2574
  
@1ambda Thank you, and i will more test :)


---

Re: 1 Gb of zeppelin-web

2017-09-08 Thread Park Hoon 
Hi, it's due to mathjax.

When user builds zeppelin-web, it builds mathjax font as well.
We might use https://github.com/mathjax/MathJax-grunt-cleaner, but I
haven't tried since it's not managed well. (quite worried about introducing
not managed build tools IMO)

*Personally, I would like to remove mathjax.* Because 0.8.0+ Users can
migrate to https://www.npmjs.com/package/zeppelin-mathjax-spell

There is already opened issue in JIRA.

- https://issues.apache.org/jira/browse/ZEPPELIN-2542


Regard,

On Fri, Sep 8, 2017 at 3:20 PM, Prabhjyot Singh 
wrote:

> Haven't noticed it earlier, but I too see it.
>
> prabhjyotsingh@HW11610:~/ps-zeppelin$ du -h  -d 1 zeppelin-web/
> 151Mzeppelin-web//dist
> 247Mzeppelin-web//bower_components
> 179Mzeppelin-web//target
> 280Mzeppelin-web//node_modules
>   0Bzeppelin-web//etc
> 7.4Mzeppelin-web//.tmp
>  76Mzeppelin-web//node
>  12Kzeppelin-web//e2e
> 3.4Mzeppelin-web//src
> 944Mzeppelin-web/
>
>
> And also;
>
> prabhjyotsingh@HW11610:~/ps-zeppelin/zeppelin-web/dist$ du -h -d 1
> 144K./app
> 8.0K./dist
> 332K./extensions
> 316K./styles
>  52K./components
> 4.0K./WEB-INF
> 2.9M./scripts
>  14M./jax
> 132M./fonts
>  60K./assets
> 151M.
>
>
> Looks like one of the offenders is "fonts"!
>
>
> On 8 September 2017 at 11:43, Jeff Zhang  wrote:
> >
> > After I build zeppelin-web, the folder size of zeppelin-web increase to
> > around 1 gb, is it expected or we download some unnecessary stuff ?
>
>
>
>
> --
> Thankx and Regards,
>
> Prabhjyot Singh
>

[GitHub] zeppelin issue #2551: [ZEPPELIN-2880] - Fix username output when OIDC is ena...

2017-09-08 Thread byamthev 
Github user byamthev commented on the issue:

https://github.com/apache/zeppelin/pull/2551
  
Yes, I have now added a JUnit test. 


---

[GitHub] zeppelin issue #2574: [ZEPPELIN-2921 : 0.7x] does not work conda environment...

2017-09-08 Thread 1ambda 
Github user 1ambda commented on the issue:

https://github.com/apache/zeppelin/pull/2574
  
Thanks for the fix. Let me test and feedback soon.


---

[GitHub] zeppelin pull request #2574: [ZEPPELIN-2921 : 0.7x] does not work conda envi...

2017-09-08 Thread cloverhearts 
GitHub user cloverhearts opened a pull request:

https://github.com/apache/zeppelin/pull/2574

[ZEPPELIN-2921 : 0.7x] does not work conda environment in python interpreter

### What is this PR for?
It seems that the environment of the python interpreter has changed to the 
py4j environment, causing problems with the library path and the default 
environment.

### What type of PR is it?
Bug Fix

### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-2921

### How should this be tested?
Please run the following command line for each paragraph.
If the module such as scipy is normally imported, it is a success.
`%python.conda create --name Hello6 python=2.7`
`%python.conda activate Hello6`
`%python.conda install seaborn pandas numpy scipy matplotlib`
```
%python
import scipy as sp
import seaborn as sns
```
`%python.conda deactivate`

### Screenshots (if appropriate)
 Before

![image](https://user-images.githubusercontent.com/10525473/30199920-c75022ca-94af-11e7-8811-0c22310f1bac.png)

 After

![image](https://user-images.githubusercontent.com/10525473/30198880-23aaceb2-94ab-11e7-8bc6-bfad76c675f7.png)


### Questions:
* Does the licenses files need update? no 
* Is there breaking changes for older versions? no
* Does this needs documentation? no


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/cloverhearts/zeppelin 
fix/conda-interpreter-invalid-path-0.7

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/2574.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2574


commit b287825358ff05347d9062d352485e5cf02d23d7
Author: CloverHearts 
Date:   2017-09-08T06:23:11Z

add conda local env




---

[GitHub] zeppelin pull request #2573: [ZEPPELIN-2920] move commonly used error handle...

2017-09-08 Thread 1ambda 
GitHub user 1ambda opened a pull request:

https://github.com/apache/zeppelin/pull/2573

[ZEPPELIN-2920] move commonly used error handlers to util (FRONT)

### What is this PR for?

Sometimes I can see manually written error handler and it's repeated again 
and again.
Even sometimes I can see missing 401 (unauthorized error) handler. So I 
propose here generalizing error handler for frontend. 

### What type of PR is it?
[Improvement | Refactoring]

### What is the Jira issue?

[ZEPPELIN-2920](https://issues.apache.org/jira/browse/ZEPPELIN-2920)

### How should this be tested?

Add `error-handler.service.test.js` and CI will test it.
If you can test manually, u can easily reproduce errornous respsone by 
toggling offline in chrome developer tool like. 


![image](https://user-images.githubusercontent.com/4968473/30199834-6534160a-94af-11e7-9685-719b74e9fa50.png)


### Questions:
* Does the licenses files need update? - NO
* Is there breaking changes for older versions? - NO
* Does this needs documentation? - NO


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/1ambda/zeppelin 
ZEPPELIN-2920/refactor-add-error-handler-service

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/2573.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2573


commit 3ca554e02cf87e7e7e21f1734b516de82b0c30e7
Author: 1ambda <1am...@gmail.com>
Date:   2017-09-08T07:00:29Z

fix: Add error-handler service

commit 1a8142bfb834b6abdc80e73055f2cbd0166eaab7
Author: 1ambda <1am...@gmail.com>
Date:   2017-09-08T07:00:36Z

fix: Apply error-handler service




---

[GitHub] zeppelin issue #2572: [ZEPPELIN-2919] fix: Fallback to table when vis is not...

2017-09-08 Thread 1ambda 
Github user 1ambda commented on the issue:

https://github.com/apache/zeppelin/pull/2572
  
CI failed, but irrelevant. 

- 
https://s3.amazonaws.com/archive.travis-ci.org/jobs/273164416/log.txt?X-Amz-Expires=30&X-Amz-Date=20170908T065857Z&X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Credential=AKIAJRYRXRSVGNKPKO5A/20170908/us-east-1/s3/aws4_request&X-Amz-SignedHeaders=host&X-Amz-Signature=10a7491238b64313f21f40f14bf241e00fef1da11964882fda40996b34ac4b27

```
Results :

Failed tests: 
  RemoteInterpreterServerTest.testStartStop:62 expected: but 
was:

Tests run: 58, Failures: 1, Errors: 0, Skipped: 0
```


---