[GitHub] zeppelin issue #2676: [ZEPPELIN-3048] Add the option which prevents paragrap...

[kjmrknsn]

Github user kjmrknsn commented on the issue:

https://github.com/apache/zeppelin/pull/2676
  
@felixcheung I'm managing Zeppelin with a Hadoop cluster which data access 
control is introduced to via Apache Ranger because my company needs to control 
each data access to our Hadoop cluster strictly. I found only the following 2 
security issues about the Zeppelin cron scheduler: 

1. https://github.com/apache/zeppelin/pull/2671
2. https://github.com/apache/zeppelin/pull/2676 (This PR)

In my opinion, it's enough to fix these 2 issues instead of reconsider the 
whole access control of Zeppelin.


---

[GitHub] zeppelin issue #2671: [ZEPPELIN-3045] Add the option which prevents the cron...

[kjmrknsn]

Github user kjmrknsn commented on the issue:

https://github.com/apache/zeppelin/pull/2671
  
@felixcheung @zjffdu 

> we still want a check in the backend right, since this is a 
security/authentication issue.

OK, thanks.  So, I won't rewrite this PR to modify frontend. I'll reply to 
your review comments.



---

[GitHub] zeppelin issue #2374: [ZEPPELIN-2593] Add storage settings to persist on run...

[felixcheung]

Github user felixcheung commented on the issue:

https://github.com/apache/zeppelin/pull/2374
  
where are we on this?


---

[GitHub] zeppelin issue #2676: [ZEPPELIN-3048] Add the option which prevents paragrap...

[felixcheung]

Github user felixcheung commented on the issue:

https://github.com/apache/zeppelin/pull/2676
  
hmm, this is interesting, and likely important.
but given the set of issues related to cron perhaps it makes sense to 
rethink the entire auth/role-base access control around here? it feels like we 
are patching this with a bunch of extra config to manage instead of considering 
how this fits into the existing role system.



---

[GitHub] zeppelin issue #2671: [ZEPPELIN-3045] Add the option which prevents the cron...

[felixcheung]

Github user felixcheung commented on the issue:

https://github.com/apache/zeppelin/pull/2671
  
we still want a check in the backend right, since this is a 
security/authentication issue.


---

[GitHub] zeppelin issue #2679: [ZEPPELIN-3047] Let Firefox remember login and passwor...

[felixcheung]

Github user felixcheung commented on the issue:

https://github.com/apache/zeppelin/pull/2679
  
this looks reasonable but it is going to work the same in all other 
browsers?


---

[GitHub] zeppelin issue #2670: [ZEPPELIN-3052] Chrome console: TypeError: Cannot set ...

[felixcheung]

Github user felixcheung commented on the issue:

https://github.com/apache/zeppelin/pull/2670
  
that's odd, anyone knows what's wrong with the build profile?
```
All tests passed.
[WARNING] The requested profile "web-ci" could not be activated because it 
does not exist.
[ERROR] Failed to execute goal 
org.apache.maven.plugins:maven-failsafe-plugin:2.16:verify (default) on project 
zeppelin-server: There are test failures.
[ERROR] 
[ERROR] Please refer to 
/home/travis/build/buxiaoliang/zeppelin/zeppelin-server/target/failsafe-reports 
for the individual test results.
[ERROR] -> [Help 1]
[ERROR] 
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e 
switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR] 
[ERROR] For more information about the errors and possible solutions, 
please read the following articles:
[ERROR] [Help 1] 
http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
[ERROR] 
[ERROR] After correcting the problems, you can resume the build with the 
command
[ERROR]   mvn  -rf :zeppelin-server
The command "mvn $TEST_FLAG $MODULES $PROFILE -B $TEST_PROJECTS" exited 
with 1.
```


---

[GitHub] zeppelin issue #2675: [ZEPPELIN-3060] Unable to use interpreter names with s...

[felixcheung]

Github user felixcheung commented on the issue:

https://github.com/apache/zeppelin/pull/2675
  
well, IMHO `-` and `_` are very common in programming languages too (eg. 
python)
I think it's reasonable to accept these two in names.

Not sure about other characters though, `(` can be problematic 


---

Re: What IDE do you use for dev Zep now?

[小野圭二]

Are there anyone who is developing Angular part in Zeppelin with any IDE?
If You are, which do You use?

-keiji

2017-11-18 17:52 GMT+09:00 小野圭二 :

> Thx for the info, Jeff.
>
> -keiji
>
>
> 
>  ウイルス
> フリー｡ www.avast.com
> 
> <#m_2243688593178832881_DAB4FAD8-2DD7-40BB-A1B8-4E2AA1F9FDF2>
>
> 2017-11-17 18:40 GMT+09:00 Jeff Zhang :
>
>> I use it for java. No much experience on Angular.
>>
>>
>>
>> 小野圭二 于2017年11月17日周五 下午5:11写道：
>>
>> > Thank you for your quick reply, Jeff.
>> > I wonder how do you use Intellij as primary, Java or Angular?
>> > Do you have any opinions of benefits in Intellij?
>> >
>> > -keiji
>> >
>> > 2017-11-17 16:35 GMT+09:00 Jeff Zhang :
>> >
>> > > I use intellij
>> > >
>> > > 小野圭二 于2017年11月17日周五 下午1:29写道：
>> > >
>> > > > Hi,
>> > > >
>> > > > For improving and/or customizing Zeppelin, I  put my hand into the
>> > source
>> > > > code.
>> > > > They were small changes, so could maintain with vi or emacs so far.
>> But
>> > > the
>> > > > next will be more. And you know they do not have a fine view over
>> all.
>> > > > I am familiar with Eclipse, that reason why it will be the first
>> > choice.
>> > > >
>> > > > So this is my question to all,
>> > > > What kind of IDE do you use for developing Zeppelin now?
>> > > >
>> > > > If you are using Eclipse, that is fine for me, give me your idea
>> how do
>> > > you
>> > > > map it in Eclipse?
>> > > > I mean, for example,
>> > > > 1. Set Project at the top of GitHub source tree
>> > > > 2. Java and Angular set each as project in it.
>> > > >
>> > > > and so on
>> > > >
>> > > > Or do you have something recommendable IDE rather than Eclipse?
>> > > >
>> > > > Please reply with feel free.
>> > > > Thx
>> > > >
>> > > > -Keiji
>> > > >
>> > >
>> >
>>
>
>

[GitHub] zeppelin issue #2673: [ZEPPELIN-3054] Update conf/shiro.ini.template so that...

[Leemoonsoo]

Github user Leemoonsoo commented on the issue:

https://github.com/apache/zeppelin/pull/2673
  
Merge to master if no further discussions. Thanks @kjmrknsn for the 
improvement!


---

[GitHub] zeppelin issue #2677: [ZEPPELIN-3062] Removes ctrl+s default behavior from n...

[tessbianchi]

Github user tessbianchi commented on the issue:

https://github.com/apache/zeppelin/pull/2677
  
Yes of course! 


---

[GitHub] zeppelin pull request #2641: [ZEPPELIN-1363] Note level dynamic form

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/zeppelin/pull/2641


---

[GitHub] zeppelin issue #2678: [ZEPPELIN-3063] Notebook loses formatting when importi...

[Leemoonsoo]

Github user Leemoonsoo commented on the issue:

https://github.com/apache/zeppelin/pull/2678
  
Tested and LGTM


---

[GitHub] zeppelin issue #2677: [ZEPPELIN-3062] Removes ctrl+s default behavior from n...

[Leemoonsoo]

Github user Leemoonsoo commented on the issue:

https://github.com/apache/zeppelin/pull/2677
  
Thanks @tessbianchi for the contribution! It looks great to me.

One thing is OSX uses `Command` + `S` instead of `CTRL` + `S` for saving 
HTML page shortcut.


![image](https://user-images.githubusercontent.com/1540981/32984585-605fb472-cc5e-11e7-8727-97678686f542.png)

Do you think you can handle `Command` + `S` also in this PR?


---

[GitHub] zeppelin pull request #2679: [ZEPPELIN-3047] Let Firefox remember login and ...

[mephi42]

GitHub user mephi42 opened a pull request:

https://github.com/apache/zeppelin/pull/2679

[ZEPPELIN-3047] Let Firefox remember login and password

### What is this PR for?
It makes Zeppelin login window compatible with Firefox password manager, as 
explained here: 
https://stackoverflow.com/questions/18586938/remember-password-with-angularjs-and-ng-submit

### What type of PR is it?
Improvement

### What is the Jira issue?
* https://issues.apache.org/jira/browse/ZEPPELIN-3047

### How should this be tested?
* Open login window in Firefox, type anything. A suggestion to save 
username and password should appear.

### Questions:
* Does the licenses files need update? - No
* Is there breaking changes for older versions? - No
* Does this needs documentation? - No

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/mephi42/zeppelin remember-password

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/2679.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2679


commit acf6f25b387b156ee4dbf68d6f2a18a8cb0f551e
Author: mephi42 
Date:   2017-11-18T14:06:10Z

Let Firefox remember login and password


https://stackoverflow.com/questions/18586938/remember-password-with-angularjs-and-ng-submit




---

Allow Connection.setAutoCommit(bool) in the the JDBC adapter.

[Christian Tzolov]

​As introduced in [1] t
he JDBC interpreter uses Connection's auto-commit status to decide whether
forceful
​y​
commit the connection
​ or not​
.

​Unfortunately the
 commit is not supported by
​bunch of

​JDBC driver
implementation
​s​
. The Apache Calcite's Avatica is one of them.

​So the
interpreter uses Connection's auto-commit
​ property ​
doesn't allow setting the
​it via the configurations​
​
​
.

Since the JDBC API
​spec ​
provides a standard setAutoCommit(boolean) method
​[2] ​
t
​hat​

​allows setting
connection
​'​
s auto-commit status
​. I
 believe this should be exposed as
​e​
​explicit
 property
​ of the interpreter.​

JDBCInterpreter#getConnection(..)
​ {​

​   ​

​   ​
connection.setAutoCommit(use
​interpreter autocomit property
)
​ ​

​}​

The [ZEPPELIN-2451]
​ issues addresses the same problem but suggested ​approach is to
completely override the connection autocommit settings.

​Cheers,
Christian​


​[1]​ https://github.com/apache/zeppelin/pull/2284
[2]
https://docs.oracle.com/javase/8/docs/api/java/sql/Connection.html#setAutoCommit-boolean-


-- 
Christian Tzolov  | Principle Software
Engineer | Pivotal 

[GitHub] zeppelin issue #2396: [ZEPPELIN-2451]: Add JDBC config option for calling co...

[tzolov]

Github user tzolov commented on the issue:

https://github.com/apache/zeppelin/pull/2396
  
The `JDBC interpreter` uses Connection's auto-commit status to decide 
whether forceful to commit  the connection. As it as pointed above `commit` is 
not supported by many `NoSql` Jdbc implementation. The Apache Calcite's Avatica 
(which Druid uses by the way) is one of them. 

The interpreter doesn't allow setting the desired connection auto-commit 
status. Since the JDBC API provides a standard 
[setAutoCommit(boolean)](https://docs.oracle.com/javase/8/docs/api/java/sql/Connection.html#setAutoCommit-boolean-)
 method to alter connections auto-commit status i believe this should be 
exposed as Explicit property. 

Shouldn't the `zeppelin.jdbc.autocommit` be implemented as: 
```
JDBCInterpreter#getConnection(..)

connection.setAutoCommit(use zeppelin.jdbc.autocommit value)

```


---

Re: What IDE do you use for dev Zep now?

[小野圭二]

Thx for the info, Jeff.

-keiji


ウイルス
フリー｡ www.avast.com

<#DAB4FAD8-2DD7-40BB-A1B8-4E2AA1F9FDF2>

2017-11-17 18:40 GMT+09:00 Jeff Zhang :

> I use it for java. No much experience on Angular.
>
>
>
> 小野圭二 于2017年11月17日周五 下午5:11写道：
>
> > Thank you for your quick reply, Jeff.
> > I wonder how do you use Intellij as primary, Java or Angular?
> > Do you have any opinions of benefits in Intellij?
> >
> > -keiji
> >
> > 2017-11-17 16:35 GMT+09:00 Jeff Zhang :
> >
> > > I use intellij
> > >
> > > 小野圭二 于2017年11月17日周五 下午1:29写道：
> > >
> > > > Hi,
> > > >
> > > > For improving and/or customizing Zeppelin, I  put my hand into the
> > source
> > > > code.
> > > > They were small changes, so could maintain with vi or emacs so far.
> But
> > > the
> > > > next will be more. And you know they do not have a fine view over
> all.
> > > > I am familiar with Eclipse, that reason why it will be the first
> > choice.
> > > >
> > > > So this is my question to all,
> > > > What kind of IDE do you use for developing Zeppelin now?
> > > >
> > > > If you are using Eclipse, that is fine for me, give me your idea how
> do
> > > you
> > > > map it in Eclipse?
> > > > I mean, for example,
> > > > 1. Set Project at the top of GitHub source tree
> > > > 2. Java and Angular set each as project in it.
> > > >
> > > > and so on
> > > >
> > > > Or do you have something recommendable IDE rather than Eclipse?
> > > >
> > > > Please reply with feel free.
> > > > Thx
> > > >
> > > > -Keiji
> > > >
> > >
> >
>