[GitHub] zeppelin issue #2728: ZEPPELIN-3104. Support Hadoop 3.0

[zjffdu]

Github user zjffdu commented on the issue:

https://github.com/apache/zeppelin/pull/2728
  
@prabhjyotsingh Please help review it, thanks


---

[GitHub] zeppelin pull request #2728: ZEPPELIN-3104. Support Hadoop 3.0

[zjffdu]

GitHub user zjffdu opened a pull request:

https://github.com/apache/zeppelin/pull/2728

ZEPPELIN-3104. Support Hadoop 3.0

### What is this PR for?
This is for supporting hadoop3 which is released recently. Adding 2 
profiles: hadoop2 and hadoop3 for hadoop 2.x support and hadoop 3.x support


### What type of PR is it?
[ Improvement ]

### Todos
* [ ] - Task

### What is the Jira issue?
* https://issues.apache.org/jira/browse/ZEPPELIN-3104


### How should this be tested?
* Travis build is pass

### Screenshots (if appropriate)

### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/zjffdu/zeppelin ZEPPELIN-3104

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/2728.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2728


commit b5e93a679f9967282f913aaee43d38d89a9520c4
Author: Jeff Zhang 
Date:   2017-12-19T02:09:04Z

ZEPPELIN-3104. Support Hadoop 3.0




---

[GitHub] zeppelin pull request #2727: ZEPPELIN-3137. Add code style check

[zjffdu]

GitHub user zjffdu opened a pull request:

https://github.com/apache/zeppelin/pull/2727

ZEPPELIN-3137. Add code style check

### What is this PR for?

The is the first PR for adding code style check. It just adding the code 
style check in maven, but just disable it for now. And creating subtask under 
ZEPPELIN-3137 for each module.  This `checkstyle.xml` is from spark project. I 
think code style of spark is also fit for zeppelin project, just remove some 
spark related content in this `checkstyle.xml`


### What type of PR is it?
[Bug Fix | Improvement | Feature | Documentation | Hot Fix | Refactoring]

### Todos
* [ ] - Task

### What is the Jira issue?
* https://issues.apache.org/jira/browse/ZEPPELIN-3137

### How should this be tested?
* First time? Setup Travis CI as described on 
https://zeppelin.apache.org/contribution/contributions.html#continuous-integration
* Strongly recommended: add automated unit tests for any new or changed 
behavior
* Outline any manual steps to test the PR here.

### Screenshots (if appropriate)

### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/zjffdu/zeppelin ZEPPELIN-3137

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/2727.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2727


commit e305a7a7d62ac1ed73632e3acd72a8b8e1fffa48
Author: Jeff Zhang 
Date:   2018-01-12T07:32:06Z

ZEPPELIN-3137. Add code style check




---

[jira] [Created] (ZEPPELIN-3150) checkstyle for big query

[Jeff Zhang (JIRA)]

Jeff Zhang created ZEPPELIN-3150:


 Summary: checkstyle for big query
 Key: ZEPPELIN-3150
 URL: https://issues.apache.org/jira/browse/ZEPPELIN-3150
 Project: Zeppelin
  Issue Type: Sub-task
Reporter: Jeff Zhang






--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Created] (ZEPPELIN-3149) checkstyle for beam

[Jeff Zhang (JIRA)]

Jeff Zhang created ZEPPELIN-3149:


 Summary: checkstyle for beam
 Key: ZEPPELIN-3149
 URL: https://issues.apache.org/jira/browse/ZEPPELIN-3149
 Project: Zeppelin
  Issue Type: Sub-task
Reporter: Jeff Zhang






--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Created] (ZEPPELIN-3148) checkstyle for angular

[Jeff Zhang (JIRA)]

Jeff Zhang created ZEPPELIN-3148:


 Summary: checkstyle for angular
 Key: ZEPPELIN-3148
 URL: https://issues.apache.org/jira/browse/ZEPPELIN-3148
 Project: Zeppelin
  Issue Type: Sub-task
Reporter: Jeff Zhang






--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Created] (ZEPPELIN-3146) checkstyle for alluxio

[Jeff Zhang (JIRA)]

Jeff Zhang created ZEPPELIN-3146:


 Summary: checkstyle for alluxio
 Key: ZEPPELIN-3146
 URL: https://issues.apache.org/jira/browse/ZEPPELIN-3146
 Project: Zeppelin
  Issue Type: Sub-task
Reporter: Jeff Zhang






--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Created] (ZEPPELIN-3147) checkstyle for angular

[Jeff Zhang (JIRA)]

Jeff Zhang created ZEPPELIN-3147:


 Summary: checkstyle for angular
 Key: ZEPPELIN-3147
 URL: https://issues.apache.org/jira/browse/ZEPPELIN-3147
 Project: Zeppelin
  Issue Type: Sub-task
Reporter: Jeff Zhang






--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Created] (ZEPPELIN-3145) checkstyle for shell interpreter

[Jeff Zhang (JIRA)]

Jeff Zhang created ZEPPELIN-3145:


 Summary: checkstyle for shell interpreter
 Key: ZEPPELIN-3145
 URL: https://issues.apache.org/jira/browse/ZEPPELIN-3145
 Project: Zeppelin
  Issue Type: Sub-task
Reporter: Jeff Zhang






--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Created] (ZEPPELIN-3144) checkstyle for markdown interpreter

[Jeff Zhang (JIRA)]

Jeff Zhang created ZEPPELIN-3144:


 Summary: checkstyle for markdown interpreter
 Key: ZEPPELIN-3144
 URL: https://issues.apache.org/jira/browse/ZEPPELIN-3144
 Project: Zeppelin
  Issue Type: Sub-task
Reporter: Jeff Zhang






--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Created] (ZEPPELIN-3143) checkstyle for spark interpreter

[Jeff Zhang (JIRA)]

Jeff Zhang created ZEPPELIN-3143:


 Summary: checkstyle for spark interpreter
 Key: ZEPPELIN-3143
 URL: https://issues.apache.org/jira/browse/ZEPPELIN-3143
 Project: Zeppelin
  Issue Type: Sub-task
Reporter: Jeff Zhang






--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Created] (ZEPPELIN-3140) checkstyle for zeppelin-server

[Jeff Zhang (JIRA)]

Jeff Zhang created ZEPPELIN-3140:


 Summary: checkstyle for zeppelin-server
 Key: ZEPPELIN-3140
 URL: https://issues.apache.org/jira/browse/ZEPPELIN-3140
 Project: Zeppelin
  Issue Type: Sub-task
Reporter: Jeff Zhang






--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Created] (ZEPPELIN-3141) checkstyle for pig interpreter

[Jeff Zhang (JIRA)]

Jeff Zhang created ZEPPELIN-3141:


 Summary: checkstyle for pig interpreter
 Key: ZEPPELIN-3141
 URL: https://issues.apache.org/jira/browse/ZEPPELIN-3141
 Project: Zeppelin
  Issue Type: Sub-task
Reporter: Jeff Zhang






--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Created] (ZEPPELIN-3142) checkstyle for livy interpreter

[Jeff Zhang (JIRA)]

Jeff Zhang created ZEPPELIN-3142:


 Summary: checkstyle for livy interpreter
 Key: ZEPPELIN-3142
 URL: https://issues.apache.org/jira/browse/ZEPPELIN-3142
 Project: Zeppelin
  Issue Type: Sub-task
Reporter: Jeff Zhang






--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Created] (ZEPPELIN-3138) checkstyle for zeppelin-interpreter

[Jeff Zhang (JIRA)]

Jeff Zhang created ZEPPELIN-3138:


 Summary: checkstyle for zeppelin-interpreter
 Key: ZEPPELIN-3138
 URL: https://issues.apache.org/jira/browse/ZEPPELIN-3138
 Project: Zeppelin
  Issue Type: Sub-task
Reporter: Jeff Zhang






--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Created] (ZEPPELIN-3139) checkstyle for zeppelin-zengine

[Jeff Zhang (JIRA)]

Jeff Zhang created ZEPPELIN-3139:


 Summary: checkstyle for zeppelin-zengine
 Key: ZEPPELIN-3139
 URL: https://issues.apache.org/jira/browse/ZEPPELIN-3139
 Project: Zeppelin
  Issue Type: Sub-task
Reporter: Jeff Zhang






--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Created] (ZEPPELIN-3137) Add code check style

[Jeff Zhang (JIRA)]

Jeff Zhang created ZEPPELIN-3137:


 Summary: Add code check style
 Key: ZEPPELIN-3137
 URL: https://issues.apache.org/jira/browse/ZEPPELIN-3137
 Project: Zeppelin
  Issue Type: Improvement
Reporter: Jeff Zhang






--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] zeppelin pull request #2726: ZEPPELIN-3009. Don't iterate all the properties...

[zjffdu]

GitHub user zjffdu opened a pull request:

https://github.com/apache/zeppelin/pull/2726

ZEPPELIN-3009. Don't iterate all the properties when getting property from 
ZeppelinConfiguration

### What is this PR for?

Just read the zeppelin-site when ZeppelinConfiguration is constructed, and 
look for key when getting property from ZeppelinConfiguration instead of 
looping over properties each time at runtime. 


### What type of PR is it?
[Improvement ]

### Todos
* [ ] - Task

### What is the Jira issue?
* https://issues.apache.org/jira/browse/ZEPPELIN-3009

### How should this be tested?
* Unit tested is covered

### Screenshots (if appropriate)

### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/zjffdu/zeppelin ZEPPELIN-3009

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/2726.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2726


commit 70de8f981f08cd109b717186ee88bcb8a8400c6a
Author: Jeff Zhang 
Date:   2017-10-26T04:41:00Z

ZEPPELIN-3009. Don't iterate all the properties when getting property from 
ZeppelinConfiguration




---

[GitHub] zeppelin issue #2725: ZEPPELIN-3136. IPython Code Completion Improvement

[zjffdu]

Github user zjffdu commented on the issue:

https://github.com/apache/zeppelin/pull/2725
  
@prabhjyotsingh @felixcheung Mind to help review it ?


---

[GitHub] zeppelin issue #2602: [ZEPPELIN-2961] Remove unnecessary 'interpreter-settin...

[zjffdu]

Github user zjffdu commented on the issue:

https://github.com/apache/zeppelin/pull/2602
  
Sorry @Leemoonsoo I make another PR #2724 based on this PR, and committed. 


---

[GitHub] zeppelin pull request #2724: [ZEPPELIN-2961] Remove unnecessary interpreter-...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/zeppelin/pull/2724


---

[GitHub] zeppelin pull request #2725: ZPEPELIN-3136. IPython Code Completion Improvem...

[zjffdu]

GitHub user zjffdu opened a pull request:

https://github.com/apache/zeppelin/pull/2725

ZPEPELIN-3136. IPython Code Completion Improvement

### What is this PR for?

This is for better code completion support for IPythonInterpreter


### What type of PR is it?
[Improvement ]

### Todos
* [ ] - Task

### What is the Jira issue?
* https://issues.apache.org/jira/browse/ZEPPELIN-3136

### How should this be tested?
* Unit test is updated and Manually verified. 

### Screenshots (if appropriate)

![code_completion](https://user-images.githubusercontent.com/164491/34858941-3f28105a-f78e-11e7-8341-2fbfd306ba5b.gif)

### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/zjffdu/zeppelin ZEPPELIN-3136

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/2725.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2725


commit 1179fc82563b6b5c5251b2c288cb094a4a94bc8f
Author: Jeff Zhang 
Date:   2018-01-12T03:45:16Z

ZPEPELIN-3136. IPython Code Completion Improvement




---

[jira] [Created] (ZEPPELIN-3136) Code Completion Improvement

[Jeff Zhang (JIRA)]

Jeff Zhang created ZEPPELIN-3136:


 Summary: Code Completion Improvement
 Key: ZEPPELIN-3136
 URL: https://issues.apache.org/jira/browse/ZEPPELIN-3136
 Project: Zeppelin
  Issue Type: Sub-task
Reporter: Jeff Zhang






--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] zeppelin pull request #2724: [ZEPPELIN-2961] Remove unnecessary interpreter-...

[zjffdu]

GitHub user zjffdu opened a pull request:

https://github.com/apache/zeppelin/pull/2724

[ZEPPELIN-2961] Remove unnecessary interpreter-setting.json file in the 
spark interpreter.

### What is this PR for?

Based on @Leemoonsoo 's work in #2602 , remove the unnecessary 
`interpreter-setting.json` 


### What type of PR is it?
[ Improvement ]

### Todos
* [ ] - Task

### What is the Jira issue?
* https://issues.apache.org/jira/browse/ZEPPELIN-2961

### How should this be tested?
* Travis build pass and manually verified. 

### Screenshots (if appropriate)

### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/zjffdu/zeppelin ZEPPELIN-2961

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/2724.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2724


commit 1c5cb83746302d011dec5355bc405552dbbb5b8b
Author: Lee moon soo 
Date:   2017-09-29T19:35:51Z

[ZEPPELIN-2961] Remove unnecessary interpreter-setting.json file in the 
spark interpreter.




---

[GitHub] zeppelin issue #2706: ZEPPELIN-3105 Notebook not running via REST API after ...

[zjffdu]

Github user zjffdu commented on the issue:

https://github.com/apache/zeppelin/pull/2706
  
Thanks @weand merge it


---

[GitHub] zeppelin pull request #2706: ZEPPELIN-3105 Notebook not running via REST API...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/zeppelin/pull/2706


---

[GitHub] zeppelin pull request #2706: ZEPPELIN-3105 Notebook not running via REST API...

[weand]

Github user weand closed the pull request at:

https://github.com/apache/zeppelin/pull/2706


---

[GitHub] zeppelin pull request #2706: ZEPPELIN-3105 Notebook not running via REST API...

[weand]

GitHub user weand reopened a pull request:

https://github.com/apache/zeppelin/pull/2706

ZEPPELIN-3105 Notebook not running via REST API after Zeppelin Restart

### What is this PR for?
Fixes regression introduced with 
[ZEPPELIN-3013](https://issues.apache.org/jira/browse/ZEPPELIN-3013). Executing 
Notebook and
Paragraph via Rest API was not possible anymore, because some parsing
was introduced paragraph.setText(...). The setter was not invoked after
deserialization, thus transient variables paragraph.intpText and 
paragraph.scriptText were
not set.

This PR fixes that by invoking paragraph.parseText() after deserialization.

Also a test was added, and AbstractTestRestApi.shutdown() method was
overloaded to support the use case of not deleting the interpreter.json
during server restart within one test case.

### What type of PR is it?
[Bug Fix]

### Todos
-

### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-3105

### How should this be tested?
Refer to the test case added,
org.apache.zeppelin.rest.NotebookRestApiTest.testRunWithServerRestart()

### Screenshots (if appropriate)

### Questions:
* Does the licenses files need update? - no
* Is there breaking changes for older versions? - no
* Does this needs documentation? - no

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/weand/zeppelin ZEPPELIN-3105

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/2706.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2706


commit 591ec8da28dac68bc67d21bb25a504563a311210
Author: Andreas Weise 
Date:   2017-12-17T22:35:42Z

ZEPPELIN-3105 Notebook not running via REST API after Zeppelin Restart

commit ea8f3ead61f1b6c283ef7e75230c1cbd0c80e0b0
Author: Andreas Weise 
Date:   2017-12-18T22:14:06Z

ZEPPELIN-3105 Notebook not running via REST API after Zeppelin Restart

parseText within fromJson Method.

commit ff4398313a55ae5ddd238083de264c1c31230e9a
Author: Andreas Weise 
Date:   2017-12-19T20:14:22Z

Merge branch 'master' of https://github.com/apache/zeppelin.git into
ZEPPELIN-3105

commit 02e1f08bef36436252ce104e550b7b3186981455
Author: Andreas Weise 
Date:   2017-12-21T21:24:52Z

Merge branch 'master' of https://github.com/apache/zeppelin.git into 
ZEPPELIN-3105

commit d46182f789bb227f14aa0a5e54eb0e5d5d7c382a
Author: Andreas Weise 
Date:   2017-12-22T19:10:11Z

Merge branch 'master' of https://github.com/apache/zeppelin.git into
ZEPPELIN-3105

Conflicts:

zeppelin-server/src/test/java/org/apache/zeppelin/rest/AbstractTestRestApi.java




---

[GitHub] zeppelin pull request #2723: ZEPPELIN-3119. Build issue with CDH

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/zeppelin/pull/2723


---

[GitHub] zeppelin issue #2723: ZEPPELIN-3119. Build issue with CDH

[Tagar]

Github user Tagar commented on the issue:

https://github.com/apache/zeppelin/pull/2723
  
thank you @zjffdu 


---

[GitHub] zeppelin issue #2723: ZEPPELIN-3119. Build issue with CDH

[zjffdu]

Github user zjffdu commented on the issue:

https://github.com/apache/zeppelin/pull/2723
  
Will merge if no more comments 


---

[jira] [Created] (ZEPPELIN-3135) Provide an option to show/hide line numbers at Notebook level

[Malay Majithia (JIRA)]

Malay Majithia created ZEPPELIN-3135:


 Summary: Provide an option to show/hide line numbers at Notebook 
level
 Key: ZEPPELIN-3135
 URL: https://issues.apache.org/jira/browse/ZEPPELIN-3135
 Project: Zeppelin
  Issue Type: New Feature
Reporter: Malay Majithia
Assignee: Malay Majithia


At present, we can show/hide line numbers at the paragraph level. 
At times this becomes painful, can we add the same option at the notebook level 
as well.

Can we also show the line numbers by default for the paragraph and user can 
hide it if not required at the paragraph level or notebook level?






--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[GitHub] zeppelin issue #2701: [ZEPPELIN-3098] Livy Interpreter fails if row contains...

[zjffdu]

Github user zjffdu commented on the issue:

https://github.com/apache/zeppelin/pull/2701
  
@bushnoh Travis build issue has been fixed, could you retrigger the build 
of this PR ?


---

[GitHub] zeppelin issue #2706: ZEPPELIN-3105 Notebook not running via REST API after ...

[zjffdu]

Github user zjffdu commented on the issue:

https://github.com/apache/zeppelin/pull/2706
  
@weand Travis build issue has been fixed, could you retrigger the build of 
this PR ?


---

[GitHub] zeppelin issue #2721: [ZEPPELIN-3129] Zepplin UI Doesnt logs out in IE

[prabhjyotsingh]

Github user prabhjyotsingh commented on the issue:

https://github.com/apache/zeppelin/pull/2721
  
Thanks for the review will merge this if no more discussion.


---

[GitHub] zeppelin issue #2721: [ZEPPELIN-3129] Zepplin UI Doesnt logs out in IE

[Akhilsnaik]

Github user Akhilsnaik commented on the issue:

https://github.com/apache/zeppelin/pull/2721
  
Have Tested in Windows 7 IE 11 , 
The Fix works fine in IE 11. 




---

[GitHub] zeppelin pull request #2723: ZEPPELIN-3119. Build issue with CDH

[zjffdu]

GitHub user zjffdu opened a pull request:

https://github.com/apache/zeppelin/pull/2723

ZEPPELIN-3119. Build issue with CDH

### What is this PR for?
This PR is for building Zeppelin with CDH. Build command
```
mvn clean package -Pspark-1.6 -Ppyspark -Dhadoop.version=2.6.0-cdh5.12.0 
-Phadoop-2.6 -Pscala-2.10  -Pyarn -DskipTests
```


### What type of PR is it?
[Bug Fix]

### Todos
* [ ] - Task

### What is the Jira issue?
* https://issues.apache.org/jira/browse/ZEPPELIN-3119

### How should this be tested?
* Build it manually with CDH

### Screenshots (if appropriate)

### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/zjffdu/zeppelin ZEPPELIN-3119

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/2723.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2723


commit ffaf137198d3dfc8c5afa09d01073e82958e9155
Author: Jeff Zhang 
Date:   2017-12-29T00:27:50Z

ZEPPELIN-3119. Build issue with CDH




---

[GitHub] zeppelin issue #2602: [ZEPPELIN-2961] Remove unnecessary 'interpreter-settin...

[zjffdu]

Github user zjffdu commented on the issue:

https://github.com/apache/zeppelin/pull/2602
  
@Leemoonsoo I don't see 
`zeppelin/spark/src/main/sparkr-resources/interpreter-setting.json` removed. 


---