[GitHub] zeppelin issue #2757: [ZEPPELIN-3198] UI should not show Version/GIT Control...
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/2757 It sounds a little redundant to ask user to both implement these version related method and `isRevisionSupported`. How about creating a sub-interface of `NotebookRepo` which support version control ? And if NotebookRepo using is the implementation of this sub-interface, we show version control on UI ---
[GitHub] zeppelin issue #2762: [ZEPPELIN-3204] FIX: cursor in paragraph editor jumps
Github user Savalek commented on the issue: https://github.com/apache/zeppelin/pull/2762 @timovwb sorry about this. I change the task number. ---
[GitHub] zeppelin issue #2765: ZEPPELIN-3164. Fixed Checkstyle errors and warnings in...
Github user HorizonNet commented on the issue: https://github.com/apache/zeppelin/pull/2765 I just reran the last failing build. All builds are now green. ---
[GitHub] zeppelin issue #2750: ZEPPELIN-3108. Support Spark 2.3
Github user felixcheung commented on the issue: https://github.com/apache/zeppelin/pull/2750 Hmm we cant fix to one or two mirrors either, i think they tend to disappear - please see how other projects handles this ---
[GitHub] zeppelin issue #2737: ZEPPELIN-3181. Enable impersonation support for kerber...
Github user hayssams commented on the issue: https://github.com/apache/zeppelin/pull/2737 I suspect a problem with this PR if the Kerberos ticket duration is shorter than the interpreter lifetime. That is why I previously opened a PR that explicitly do a ticket renewal at an interval defined by the user. Please check the following PR https://github.com/apache/zeppelin/pull/2719 ---
[GitHub] zeppelin pull request #2767: ZEPPELIN-3145. Fixed Checkstyle errors and warn...
GitHub user HorizonNet opened a pull request: https://github.com/apache/zeppelin/pull/2767 ZEPPELIN-3145. Fixed Checkstyle errors and warnings in the shell module ### What is this PR for? Fixed all Checkstyle errors and warnings in the **shell** module. ### What type of PR is it? Improvement ### Todos * [ ] - Task ### What is the Jira issue? * https://issues.apache.org/jira/browse/ZEPPELIN-3145 ### How should this be tested? * CI pass ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no You can merge this pull request into a Git repository by running: $ git pull https://github.com/ultratendency/zeppelin ZEPPELIN-3145 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/2767.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2767 commit 206ffd02338753c23e9dd86806886226e91dbe7a Author: Jan Hentschel Date: 2018-02-05T22:10:23Z ZEPPELIN-3145. Fixed Checkstyle errors and warnings in the shell module ---
[GitHub] zeppelin issue #2750: ZEPPELIN-3108. Support Spark 2.3
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/2750 Fixed. Now using apache dist url ---
[GitHub] zeppelin issue #2750: ZEPPELIN-3108. Support Spark 2.3
Github user felixcheung commented on the issue: https://github.com/apache/zeppelin/pull/2750 Ah sorry. Please see http://www.apache.org/dev/release-publishing.html#distribution And specifically http://www.apache.org/dev/release-download-pages.html#links ---
[GitHub] zeppelin issue #2750: ZEPPELIN-3108. Support Spark 2.3
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/2750 @felixcheung IIUC, these are for release download page, for external project, we could use the dist link. ---
[GitHub] zeppelin issue #2750: ZEPPELIN-3108. Support Spark 2.3
Github user felixcheung commented on the issue: https://github.com/apache/zeppelin/pull/2750 well... that's not my understand and other implementations are pulling from the download script and then to the referred mirror, eg. https://github.com/apache/spark/blob/master/build/mvn#L81 https://github.com/apache/spark/blob/master/sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveExternalCatalogVersionsSuite.scala#L64 https://github.com/apache/spark/blob/master/R/pkg/R/install.R#L213 https://github.com/apache/spark/blob/master/external/docker/spark-mesos/Dockerfile#L27 https://github.com/graphframes/graphframes/commit/a1427217a2458ae89dde038f0ce79eec7913a7d6 https://github.com/Homebrew/homebrew-core/blob/master/Formula/apache-spark.rb ---
[GitHub] zeppelin issue #2750: ZEPPELIN-3108. Support Spark 2.3
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/2750 Thanks @felixcheung , These examples seems to fetch the download url dynamically, I don't think maven download plugin support this. If you don't mind, I will leave it as follow up PR to improve. As I want to include this PR in 0.8 which I plan to release soon. ---
