[GitHub] zeppelin issue #2716: [ZEPPELIN-3123] Fix to create pid per each interpreter
Github user mebelousov commented on the issue: https://github.com/apache/zeppelin/pull/2716 @woowahan-jaehoon thank you! Perhaps #2780 will delete all unused pid files and you can add the port to the pid filename. ---
[GitHub] zeppelin pull request #2876: ZEPPELIN-3344. Revert comments in queries in JD...
Github user mebelousov closed the pull request at: https://github.com/apache/zeppelin/pull/2876 ---
[GitHub] zeppelin pull request #2876: ZEPPELIN-3344. Revert comments in queries in JD...
GitHub user mebelousov reopened a pull request: https://github.com/apache/zeppelin/pull/2876 ZEPPELIN-3344. Revert comments in queries in JDBC interpreter ### What is this PR for? The original purpose of https://github.com/apache/zeppelin/pull/2158 was correct processing of ';'. This was done via full removing comments from code. Unfortunately Apache Phoenix uses hooks in comments https://forcedotcom.github.io/phoenix/#hintml. Thus we should not delete comments in scripts. There was discussion about comment rules for different databases (solr). The right way is keep style. Thus analysts can copy queries to another tool and can get same results and errors. ### What type of PR is it? [Bug Fix] ### What is the Jira issue? * https://issues.apache.org/jira/browse/ZEPPELIN-3344 ### How should this be tested? * Unit tests pass: testSplitSqlQueryWithComments and testSplitSqlQuery ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No You can merge this pull request into a Git repository by running: $ git pull https://github.com/tinkoff-dwh/zeppelin ZEPPELIN-3344 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/2876.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2876 commit eed54c89216e4e07e4c82b82f6a740928969205d Author: mebelousov Date: 2018-03-16T13:26:06Z ZEPPELIN-3344 Revert comments in JDBC interpreter commit 83c8e8faa5ba6b0e46ed51d530b2b3bae362d036 Author: mebelousov Date: 2018-03-16T13:34:42Z ZEPPELIN-3344 Rename test commit 698040083ce53c449a11133e0e3dc14e6e21d138 Author: mebelousov Date: 2018-03-20T05:57:02Z ZEPPELIN-3344 Fix checkstyle, add tests for comments ---
[GitHub] zeppelin issue #2881: ZEPPELIN-3313 z.getInterpreterContext().out().clear() ...
Github user r-kamath commented on the issue: https://github.com/apache/zeppelin/pull/2881 @zjffdu currently data update and refresh timing in ui grid is not guaranteed. This issue persists only when the interval is below 1sec. I modified your example with 2sec delay and the rendering is fine. However, frequent refreshing of ui table is causing too many `[Violation] 'setTimeout' handler took ms` and `[Violation] Added non-passive event listener to a scroll-blocking event. Consider marking event handler as 'passive' to make the page more responsive. See ` About support for Passive Event Listeners: https://stackoverflow.com/a/39187679 ---
[jira] [Created] (ZEPPELIN-3355) Support inline configuration for user session
Jeff Zhang created ZEPPELIN-3355: Summary: Support inline configuration for user session Key: ZEPPELIN-3355 URL: https://issues.apache.org/jira/browse/ZEPPELIN-3355 Project: Zeppelin Issue Type: Improvement Reporter: Jeff Zhang This is specifically useful for livy interpreter that each zeppelin session will create a livy session. And usually user want to pass custom configuration for his session. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] zeppelin issue #2870: [ZEPPELIN-3335] trim property name of interpreter sett...
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/2870 @rockiee281 seems you didn't do rebase correctly , or you can create another PR ---
[GitHub] zeppelin pull request #2883: ZEPPELIN-3355. Support inline configuration for...
GitHub user zjffdu opened a pull request: https://github.com/apache/zeppelin/pull/2883 ZEPPELIN-3355. Support inline configuration for user session ### What is this PR for? Generic ConfInterpreter only support process level configuration, this PR is trying to introduce UserSessionConfInterpreter which can customize session level configuration, One example is for livy interpreter that can customize livy session. ### What type of PR is it? [Feature ] ### Todos * [ ] - Task ### What is the Jira issue? * https://issues.apache.org/jira/browse/ZEPPELIN-3355 ### How should this be tested? * Ci pass and manually test livy interpreter ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No You can merge this pull request into a Git repository by running: $ git pull https://github.com/zjffdu/zeppelin ZEPPELIN-3355 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/2883.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2883 commit 4c558edaedc4cbb94051dae7ac8c01a7e3acc45c Author: Jeff Zhang Date: 2018-03-20T09:35:13Z ZEPPELIN-3355. Support inline configuration for user session ---
[GitHub] zeppelin issue #2852: [ZEPPELIN-3264] Notebook Snapshot feature.
Github user SleepyThread commented on the issue: https://github.com/apache/zeppelin/pull/2852 @zjffdu Implementation using Git Tag is also another approach but updating/delete Git tag regularly is not something feels right [ Usually in practice Git Tag are to be done only once ]. Hence, I have used file-based approach for storing a mapping of Snapshot ID => Revision ID. Let me know if you feel strongly about the other approach, and I work on the Git Tag based implementation. ---
[GitHub] zeppelin issue #2880: [ZEPPELIN-3351] Fix to build for spark 2.3
Github user felixcheung commented on the issue: https://github.com/apache/zeppelin/pull/2880 I think we should try to fix the build profile as in this PR. But we must fix the download source - otherwise given what Iâve seen recently, we cannot release (its not up to me) ---
[GitHub] zeppelin issue #2834: [ZEPPELIN-1967] Passing Z variables to Shell and SQL I...
Github user Tagar commented on the issue: https://github.com/apache/zeppelin/pull/2834 @zjffdu, @felixcheung would be exciting to have this feature be part of the 0.8.0 release. Since there is a way to maintain backward compatibility, it seems to be a low hanging fruit as it's a great improvement in Zeppelin functionality. Thanks @sanjaydasgupta and everyone! ---
[GitHub] zeppelin pull request #2884: trim property name of interpreter settings
GitHub user rockiee281 opened a pull request: https://github.com/apache/zeppelin/pull/2884 trim property name of interpreter settings ### What is this PR for? trim property name of interpreter settings ### What type of PR is it? Improvement ### Todos * [x] - Task ### What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-3335 ### How should this be tested? * First time? Setup Travis CI as described on https://zeppelin.apache.org/contribution/contributions.html#continuous-integration * Strongly recommended: add automated unit tests for any new or changed behavior * Outline any manual steps to test the PR here. ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? * Is there breaking changes for older versions? * Does this needs documentation? You can merge this pull request into a Git repository by running: $ git pull https://github.com/rockiee281/zeppelin ZEPPELIN-3335-fix Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/2884.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2884 ---
[GitHub] zeppelin issue #2870: [ZEPPELIN-3335] trim property name of interpreter sett...
Github user rockiee281 commented on the issue: https://github.com/apache/zeppelin/pull/2870 Sorry, I'm not familiar with git rebase ,create PR #2884 instead ---
[GitHub] zeppelin issue #2760: ZEPPELIN-3196. Plugin framework for Zeppelin Engine
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/2760 @Leemoonsoo @jongyoul @prabhjyotsingh @felixcheung Could you help review it ? Thanks, it is for 0.9. ---
[GitHub] zeppelin pull request #2803: ZEPPELIN-3232. Allow to write config files to f...
Github user zjffdu closed the pull request at: https://github.com/apache/zeppelin/pull/2803 ---
[GitHub] zeppelin issue #2760: ZEPPELIN-3196. Plugin framework for Zeppelin Engine
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/2760 Took a look changes and it looks good to me ---
[GitHub] zeppelin issue #2852: [ZEPPELIN-3264] Notebook Snapshot feature.
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/2852 > Git tag regularly is not something feels right [ Usually in practice Git Tag are to be done only once ]. That is my understanding of the snapshot scenario. Snapshot is only readable, but not writable. When user view snapshot of one note, zeppelin just fetch the note at that tag. Let me know if my understanding of your snapshot scenario is not correct. ---
