[GitHub] zeppelin issue #2831: ZEPPELIN-3281. Apply getRelativePath when it is LocalC...

[felixcheung]

Github user felixcheung commented on the issue:

https://github.com/apache/zeppelin/pull/2831
  
.. and I've reviewed all PRs and left one or two comments.


---

[GitHub] zeppelin issue #2891: ZEPPELIN-1070: Inject Credentials in any Interpreter-C...

[felixcheung]

Github user felixcheung commented on the issue:

https://github.com/apache/zeppelin/pull/2891
  
thanks, sounds like that could be useful.
what do you think about "secret" management?
also for template I think we should match the other way, where we have a 
longer discussion: #2834



---

[GitHub] zeppelin issue #2831: ZEPPELIN-3281. Apply getRelativePath when it is LocalC...

[felixcheung]

Github user felixcheung commented on the issue:

https://github.com/apache/zeppelin/pull/2831
  
of course, let's do the right thing. feel free to ping me in all PR, but 
generally I should get to it within a day, at least for the next few months. :)



---

[GitHub] zeppelin issue #2587: [ZEPPELIN-2909]. Support shared SparkContext across la...

[felixcheung]

Github user felixcheung commented on the issue:

https://github.com/apache/zeppelin/pull/2587
  
ok thanks, didn't realize it's been 7 months... :)


---

[GitHub] zeppelin issue #2892: ZEPPELIN-3162. Fixed Checkstyle issues in neo4j module

[felixcheung]

Github user felixcheung commented on the issue:

https://github.com/apache/zeppelin/pull/2892
  
seems like test fail for unrelated reason - is it out of date or something?
```
[WARNING] The requested profile "hadoop2" could not be activated because it 
does not exist.
[ERROR] Failed to execute goal 
com.github.eirslett:frontend-maven-plugin:1.3:npm (npm test) on project 
zeppelin-web: Failed to run task: 'npm run test' failed. (error code 1) -> 
[Help 1]
```


---

[GitHub] zeppelin issue #2893: ZEPPELIN-3161. Fixed Checkstyle issues in lens module

[felixcheung]

Github user felixcheung commented on the issue:

https://github.com/apache/zeppelin/pull/2893
  
merging if no more comment


---

[GitHub] zeppelin issue #2587: [ZEPPELIN-2909]. Support shared SparkContext across la...

[zjffdu]

Github user zjffdu commented on the issue:

https://github.com/apache/zeppelin/pull/2587
  
@felixcheung  It is documented here. 
https://github.com/apache/zeppelin/blame/master/docs/interpreter/livy.md#L219


---

[GitHub] zeppelin issue #2834: [ZEPPELIN-1967] Passing Z variables to Shell and SQL I...

[zjffdu]

Github user zjffdu commented on the issue:

https://github.com/apache/zeppelin/pull/2834
  
Yes, it is safe for me merge it into branch-0.8 


---

[GitHub] zeppelin issue #2831: ZEPPELIN-3281. Apply getRelativePath when it is LocalC...

[zjffdu]

Github user zjffdu commented on the issue:

https://github.com/apache/zeppelin/pull/2831
  
Thanks @felixcheung for review, these issues block the 0.8 release and 
recently there's no much review bandwidth in community, that's why I didn't 
wait for more views. Will wait for more long time for review in future, sorry 
for any inconvenience. 


---

[GitHub] zeppelin pull request #2893: ZEPPELIN-3161. Fixed Checkstyle issues in lens ...

[HorizonNet]

GitHub user HorizonNet opened a pull request:

https://github.com/apache/zeppelin/pull/2893

ZEPPELIN-3161. Fixed Checkstyle issues in lens module

### What is this PR for?
Fixes the Checkstyle issues in the lens module.


### What type of PR is it?
Improvement

### Todos
* [ ] - Task

### What is the Jira issue?
* https://issues.apache.org/jira/browse/ZEPPELIN-3161

### How should this be tested?
* CI pass

### Screenshots (if appropriate)

### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ultratendency/zeppelin ZEPPELIN-3161

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/2893.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2893


commit 037f0ba28598b925c6d47a1fa15140e4fbe76488
Author: Jan Hentschel 
Date:   2018-03-25T12:29:22Z

ZEPPELIN-3161. Fixed Checkstyle issues in lens module




---

[GitHub] zeppelin issue #2587: [ZEPPELIN-2909]. Support shared SparkContext across la...

[felixcheung]

Github user felixcheung commented on the issue:

https://github.com/apache/zeppelin/pull/2587
  
still, I think this feature is distinctive enough that we should document 
and bring some visibility (even if it just works)



---

[GitHub] zeppelin issue #2793: ZEPPELIN-3226. Fail to launch IPySparkInterpreter in e...

[felixcheung]

Github user felixcheung commented on the issue:

https://github.com/apache/zeppelin/pull/2793
  
hey @zjffdu thanks for making all these improvements, could we make sure 
there is at least one review before merging?
@Leemoonsoo 


---

[GitHub] zeppelin issue #2831: ZEPPELIN-3281. Apply getRelativePath when it is LocalC...

[felixcheung]

Github user felixcheung commented on the issue:

https://github.com/apache/zeppelin/pull/2831
  
hey @zjffdu thanks for making all these improvements, could we make sure 
there is at least one review before merging?
@Leemoonsoo 


---

[GitHub] zeppelin issue #2837: ZEPPELIN-3279. [FlakyTest] NotebookTest.testPerSession...

[felixcheung]

Github user felixcheung commented on the issue:

https://github.com/apache/zeppelin/pull/2837
  
hey @zjffdu thanks for making all these improvements, could we make sure 
there is at least one review before merging?
@Leemoonsoo 


---

[GitHub] zeppelin issue #2836: ZEPPELIN-3291. Throw exception instead of return null ...

[felixcheung]

Github user felixcheung commented on the issue:

https://github.com/apache/zeppelin/pull/2836
  
hey @zjffdu thanks for making all these improvements, could we make sure 
there is at least one review before merging?
@Leemoonsoo 


---

[GitHub] zeppelin issue #2843: ZEPPELIN-3299. Combine spark integration test with its...

[felixcheung]

Github user felixcheung commented on the issue:

https://github.com/apache/zeppelin/pull/2843
  
hey @zjffdu thanks for making all these improvements, could we make sure 
there is at least one review before merging?
@Leemoonsoo 


---

[GitHub] zeppelin issue #2838: ZEPPELIN-3277. NotebookServerTest.testMakeSureNoAngula...

[felixcheung]

Github user felixcheung commented on the issue:

https://github.com/apache/zeppelin/pull/2838
  
hey @zjffdu thanks for making all these improvements, could we make sure 
there is at least one review before merging?
@Leemoonsoo 


---

[GitHub] zeppelin issue #2844: ZEPPELIN-3296. Reorg livy integration test to minimize...

[felixcheung]

Github user felixcheung commented on the issue:

https://github.com/apache/zeppelin/pull/2844
  
hey @zjffdu thanks for making all these improvements, could we make sure 
there is at least one review before merging?
@Leemoonsoo 


---

[GitHub] zeppelin issue #2861: ZEPPELIN-3322. Update interpreterBind when restarting ...

[felixcheung]

Github user felixcheung commented on the issue:

https://github.com/apache/zeppelin/pull/2861
  
hey @zjffdu thanks for making all these improvements, could we make sure 
there is at least one review before merging?
@Leemoonsoo 


---

[GitHub] zeppelin issue #2846: ZEPPELIN-3302. Update SparkVersion.java to support Spa...

[felixcheung]

Github user felixcheung commented on the issue:

https://github.com/apache/zeppelin/pull/2846
  
hey @zjffdu thanks for making all these improvements, could we make sure 
there is at least one review before merging?
@Leemoonsoo 


---

[GitHub] zeppelin issue #2865: [HOTFIX] More proper error message when interpreter is...

[felixcheung]

Github user felixcheung commented on the issue:

https://github.com/apache/zeppelin/pull/2865
  
hey @zjffdu thanks for making all these improvements, could we make sure 
there is at least one review before merging?
@Leemoonsoo 


---

[GitHub] zeppelin issue #2866: ZEPPELIN-3328. Add plotting test for LivyInterpreter

[felixcheung]

Github user felixcheung commented on the issue:

https://github.com/apache/zeppelin/pull/2866
  
hey @zjffdu thanks for making all these improvements, could we make sure 
there is at least one review before merging?
@Leemoonsoo 


---

[GitHub] zeppelin issue #2869: ZEPPELIN-3330. Add more test for RemoteInterpreterServ...

[felixcheung]

Github user felixcheung commented on the issue:

https://github.com/apache/zeppelin/pull/2869
  
hey @zjffdu thanks for making all these improvements, could we make sure 
there is at least one review before merging?
@Leemoonsoo 


---

[GitHub] zeppelin issue #2874: ZEPPELIN-3339. Add more test for ZeppelinContext

[felixcheung]

Github user felixcheung commented on the issue:

https://github.com/apache/zeppelin/pull/2874
  
hey @zjffdu thanks for making all these improvements, could we make sure 
there is at least one review before merging?
@Leemoonsoo 


---

[GitHub] zeppelin issue #2871: ZEPPELIN-3337. Add more test to SparkRInterpreter

[felixcheung]

Github user felixcheung commented on the issue:

https://github.com/apache/zeppelin/pull/2871
  
hey @zjffdu thanks for making all these improvements, could we make sure 
there is at least one review before merging?
@Leemoonsoo 


---

[GitHub] zeppelin issue #2875: ZEPPELIN-3343. Interpreter Hook is broken

[felixcheung]

Github user felixcheung commented on the issue:

https://github.com/apache/zeppelin/pull/2875
  
hey @zjffdu thanks for making all these improvements, could we make sure 
there is at least one review before merging?
@Leemoonsoo 


---

[GitHub] zeppelin issue #2877: ZEPPELIN-3345. Don't load interpreter setting when it ...

[felixcheung]

Github user felixcheung commented on the issue:

https://github.com/apache/zeppelin/pull/2877
  
hey @zjffdu thanks for making all these improvements, could we make sure 
there is at least one review before merging?
@Leemoonsoo 


---

[GitHub] zeppelin issue #2878: ZEPPELIN-3331. Use NullLifecycleManager by default

[felixcheung]

Github user felixcheung commented on the issue:

https://github.com/apache/zeppelin/pull/2878
  
hey @zjffdu thanks for making all these improvements, could we make sure 
there is at least one review before merging?
@Leemoonsoo 


---

[GitHub] zeppelin issue #2882: ZEPPELIN-3290. Unnecessary message 'IPython is availab...

[felixcheung]

Github user felixcheung commented on the issue:

https://github.com/apache/zeppelin/pull/2882
  
hey @zjffdu thanks for making all these improvements, could we make sure 
there is at least one review before merging?
@Leemoonsoo 


---

[GitHub] zeppelin issue #2887: ZEPPELIN-3357. Livy security mode is broken

[felixcheung]

Github user felixcheung commented on the issue:

https://github.com/apache/zeppelin/pull/2887
  
hey @zjffdu thanks for making all these improvements, could we make sure 
there is at least one review before merging?
@Leemoonsoo 


---

[GitHub] zeppelin issue #2834: [ZEPPELIN-1967] Passing Z variables to Shell and SQL I...

[felixcheung]

Github user felixcheung commented on the issue:

https://github.com/apache/zeppelin/pull/2834
  
@zjffdu do we still merge commits to branch-0.8?


---

[GitHub] zeppelin issue #2834: [ZEPPELIN-1967] Passing Z variables to Shell and SQL I...

[sanjaydasgupta]

Github user sanjaydasgupta commented on the issue:

https://github.com/apache/zeppelin/pull/2834
  
@zjffdu Thanks for your review - that was very helpful.

Have fixed all the issues - please see [details added after your 
comment](https://github.com/apache/zeppelin/pull/2834/files/1e2c87dd36dc091ca898baf8e9f178d6d1a5e600#r176944574).


---

[jira] [Created] (ZEPPELIN-3364) Followup of ZEPPELIN-3362, improve ZeppelinContext & add more test

[Jeff Zhang (JIRA)]

Jeff Zhang created ZEPPELIN-3364:


 Summary: Followup of ZEPPELIN-3362, improve ZeppelinContext & add 
more test
 Key: ZEPPELIN-3364
 URL: https://issues.apache.org/jira/browse/ZEPPELIN-3364
 Project: Zeppelin
  Issue Type: Improvement
Reporter: Jeff Zhang






--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] zeppelin issue #2890: ZEPPELIN-3362. Unify ZeppelinContext of PythonInterpre...

[zjffdu]

Github user zjffdu commented on the issue:

https://github.com/apache/zeppelin/pull/2890
  
Thanks for the review @felixcheung , will do the improvement in another PR


---

[GitHub] zeppelin pull request #2890: ZEPPELIN-3362. Unify ZeppelinContext of PythonI...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/zeppelin/pull/2890


---

[GitHub] zeppelin issue #2834: [ZEPPELIN-1967] Passing Z variables to Shell and SQL I...

[zjffdu]

Github user zjffdu commented on the issue:

https://github.com/apache/zeppelin/pull/2834
  
@sanjaydasgupta Overall It LGTM, just left one minor comment. 


---

[GitHub] zeppelin issue #2834: [ZEPPELIN-1967] Passing Z variables to Shell and SQL I...

[sanjaydasgupta]

Github user sanjaydasgupta commented on the issue:

https://github.com/apache/zeppelin/pull/2834
  
Hello reviewers, this PR has accumulated many ideas from the wisdom of its 
past and present reviewers (@zjffdu @felixcheung @Tagar @Leemoonsoo ), and it 
would be interesting to see how the user community leverages it. Requesting you 
to consider adding it to release 0.8.0.


---