[GitHub] zeppelin issue #2894: ZEPPELIN-3364. Followup of ZEPPELIN-3362, improve Zepp...

[zjffdu]

Github user zjffdu commented on the issue:

https://github.com/apache/zeppelin/pull/2894
  
@prabhjyotsingh Do you mean ZeppelinServer will get the append event after 
the paragraph is completed ? 


---

[GitHub] zeppelin issue #2871: ZEPPELIN-3337. Add more test to SparkRInterpreter

[felixcheung]

Github user felixcheung commented on the issue:

https://github.com/apache/zeppelin/pull/2871
  
Agreed. This is a bit uncomfortablely long to be hard coded.





---

[GitHub] zeppelin issue #2891: ZEPPELIN-1070: Inject Credentials in any Interpreter-C...

[felixcheung]

Github user felixcheung commented on the issue:

https://github.com/apache/zeppelin/pull/2891
  
Curly braces


From: pellmont 
Sent: Monday, March 26, 2018 1:45:06 PM
To: apache/zeppelin
Cc: Felix Cheung; Manual
Subject: Re: [apache/zeppelin] ZEPPELIN-1070: Inject Credentials in any 
Interpreter-Code (#2891)


nice if I can contribute :-)

I think the current API for the credentials makes sense, of course it would 
be nice if the credentials could be shared across users without exposing the 
underlying passwords. But I think as long as there are different interpreters 
(especially those with "free-form-connections" like spark, livy, etc) it's 
impossible without implementing quite some code for each of the interpreters. 
Ending up with limited possibilities to cpnnect to a datasource.

What do you exactly mean by "match the other way"? Using the same syntax? 
Curly braces to be replaced and double-curly-braces to escape? Or do you mean 
by the configuration option(s)? Or both?

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on 
GitHub, or 
mute the 
thread.



---

[GitHub] zeppelin issue #2885: [ZEPPELIN-3001] Disable ace editor code completion whe...

[zjffdu]

Github user zjffdu commented on the issue:

https://github.com/apache/zeppelin/pull/2885
  
@prabhjyotsingh I try the latest PR, but it doesn't work when I enable 
zeppelin.spark.useNew. I can confirm the completion api return the same thing 
no matter whether zeppelin.spark.useNew is true or false. Could you help check 
what's difference in frontend ? Thanks


---

[GitHub] zeppelin issue #2891: ZEPPELIN-1070: Inject Credentials in any Interpreter-C...

[pellmont]

Github user pellmont commented on the issue:

https://github.com/apache/zeppelin/pull/2891
  
nice if I can contribute :-)

I think the current API for the credentials makes sense, of course it would 
be nice if the credentials could be shared across users without exposing the 
underlying passwords. But I think as long as there are different interpreters 
(especially those with "free-form-connections" like spark, livy, etc) it's 
impossible without implementing quite some code for each of the interpreters. 
Ending up with limited possibilities to cpnnect to a datasource.

What do you exactly mean by "match the other way"? Using the same syntax? 
Curly braces to be replaced and double-curly-braces to escape? Or do you mean 
by the configuration option(s)? Or both?


---

[GitHub] zeppelin issue #2894: ZEPPELIN-3364. Followup of ZEPPELIN-3362, improve Zepp...

[Tagar]

Github user Tagar commented on the issue:

https://github.com/apache/zeppelin/pull/2894
  
Thanks @zjffdu 

cc @prabhjyotsingh - you were saying in [a comment for 
ZEPPELIN-3292](https://issues.apache.org/jira/browse/ZEPPELIN-3292?focusedCommentId=16387420=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-16387420)
 there is some issue in the backend that have caused data duplication and you 
made a workaround in the [frontend 
here](https://github.com/apache/zeppelin/pull/2835) 

Can you please help review if this PR also hopefully fixes that data 
duplication in the backend? Not sure if we need a separate PR for that?

IPython/IPySpark is newer in Zeppelin and may have some issues so would be 
great to make it rock-solid as I know there are more PySpark users than Spark 
users using Scala API.. 


---

[GitHub] zeppelin pull request #2895: ZEPPELIN-3160. Fixed Checkstyle issues in kylin...

[HorizonNet]

GitHub user HorizonNet opened a pull request:

https://github.com/apache/zeppelin/pull/2895

ZEPPELIN-3160. Fixed Checkstyle issues in kylin module

### What is this PR for?
Fixed the Checkstyle issues in the kylin module.

### What type of PR is it?
Improvement

### Todos
* [ ] - Task

### What is the Jira issue?
* https://issues.apache.org/jira/browse/ZEPPELIN-3160

### How should this be tested?
* CI pass

### Screenshots (if appropriate)

### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ultratendency/zeppelin ZEPPELIN-3160

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/2895.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2895






---

[GitHub] zeppelin issue #2894: ZEPPELIN-3364. Followup of ZEPPELIN-3362, improve Zepp...

[zjffdu]

Github user zjffdu commented on the issue:

https://github.com/apache/zeppelin/pull/2894
  
@felixcheung Mind to help review it ? Thanks


---

[GitHub] zeppelin pull request #2894: ZEPPELIN-3364. Followup of ZEPPELIN-3362, impro...

[zjffdu]

GitHub user zjffdu opened a pull request:

https://github.com/apache/zeppelin/pull/2894

ZEPPELIN-3364. Followup of ZEPPELIN-3362, improve ZeppelinContext & add 
more test


### What is this PR for?

This PR address the remaining issue of ZEPPELIN-3362, and also add more 
test for ZeppelinContext.


### What type of PR is it?
[ Improvement ]

### Todos
* [ ] - Task

### What is the Jira issue?
* https://issues.apache.org/jira/browse/ZEPPELIN-3364

### How should this be tested?
* CI pass

### Screenshots (if appropriate)

### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/zjffdu/zeppelin ZEPPELIN-3364

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/2894.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2894


commit 18dc04fb5c149f5daeed6d05096dc106b485805e
Author: Jeff Zhang 
Date:   2018-03-25T14:13:44Z

ZEPPELIN-3364. Followup of ZEPPELIN-3362, improve ZeppelinContext & add 
more test




---

[GitHub] zeppelin issue #2892: ZEPPELIN-3162. Fixed Checkstyle issues in neo4j module

[HorizonNet]

Github user HorizonNet commented on the issue:

https://github.com/apache/zeppelin/pull/2892
  
I merged the latest master into this branch. Let's wait for the build.


---

[GitHub] zeppelin issue #2442: [ZEPPELIN-2679] JDBC. precode for session

[zjffdu]

Github user zjffdu commented on the issue:

https://github.com/apache/zeppelin/pull/2442
  
Sorry @mebelousov  I don't get why the general hooks could not satisfy you. 
The hook can run for each paragraph. Could you explain a little bit more ? 
Maybe an example would be very helpful. 


---

[GitHub] zeppelin issue #2834: [ZEPPELIN-1967] Passing Z variables to Shell and SQL I...

[sanjaydasgupta]

Github user sanjaydasgupta commented on the issue:

https://github.com/apache/zeppelin/pull/2834
  
@felixcheung  following [the earlier 
discussion](https://github.com/apache/zeppelin/pull/2834#discussion_r176976263),
 the _propertyName_ field in both _interpreter-setting.json_ files have been 
restored. Thanks for the catch.


---

[GitHub] zeppelin issue #2442: [ZEPPELIN-2679] JDBC. precode for session

[mebelousov]

Github user mebelousov commented on the issue:

https://github.com/apache/zeppelin/pull/2442
  
@zjffdu
The hooks as pre-code were discussed [previously 
](https://github.com/apache/zeppelin/pull/2096#issuecomment-284220634)
We want precode execute before pre-hook for easy finding the note. 
Meanwhile the hooks doesn't realized in JDBC interpreter.

The JDBC interpreter allow to split query and precode must run before each 
statement in paragraph. Therefore the single way for precode for all 
interpreters looks unrealizable.

The rename to `zeppelin.interpreter.precode` is good idea. Do this?


---

[jira] [Created] (ZEPPELIN-3365) Load interpreter-setting.json in RemoteInterpreterServer

[Jeff Zhang (JIRA)]

Jeff Zhang created ZEPPELIN-3365:


 Summary: Load interpreter-setting.json in RemoteInterpreterServer
 Key: ZEPPELIN-3365
 URL: https://issues.apache.org/jira/browse/ZEPPELIN-3365
 Project: Zeppelin
  Issue Type: Improvement
Reporter: Jeff Zhang


So that we could use the default value of interpreter-setting.json



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)