[GitHub] zeppelin issue #2940: Fix type note => user
Github user zjffdu commented on the issue: https://github.com/apache/zeppelin/pull/2940 LGTM ---
[GitHub] zeppelin pull request #2768: ZEPPELIN-3142. Fixed Checkstyle errors and warn...
Github user asfgit closed the pull request at: https://github.com/apache/zeppelin/pull/2768 ---
[GitHub] zeppelin issue #2941: [ZEPPELIN-3311] Zeppelin should ask user to re-login a...
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/2941 Thanks for the review will merge this if no more discussion. ---
[GitHub] zeppelin issue #2939: [ZEPPELIN-3423] Fix deprecated dynamic forms document ...
Github user jwagun commented on the issue: https://github.com/apache/zeppelin/pull/2939 Thanks for your review :) ---
[GitHub] zeppelin pull request #2943: ZEPPELIN-3428. Flaky test: SparkInterpreterLaun...
GitHub user zjffdu opened a pull request: https://github.com/apache/zeppelin/pull/2943 ZEPPELIN-3428. Flaky test: SparkInterpreterLauncherTest ### What is this PR for? SparkInterpreterLauncherTest will fail when you already have enviroment variable setup in the machine where you run the unit test. ### What type of PR is it? [Bug Fix] ### Todos * [ ] - Task ### What is the Jira issue? * https://issues.apache.org/jira/browse/ZEPPELIN-3428 ### How should this be tested? * CI pass ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No You can merge this pull request into a Git repository by running: $ git pull https://github.com/zjffdu/zeppelin ZEPPELIN-3428 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/2943.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2943 commit 6b89b22e38960fa03ef2aa8b6087fa8b70598bb7 Author: Jeff Zhang Date: 2018-04-25T00:31:56Z ZEPPELIN-3428. Flaky test: SparkInterpreterLauncherTest ---
[jira] [Created] (ZEPPELIN-3428) Flaky test of SparkInterpreterLauncherTest
Jeff Zhang created ZEPPELIN-3428:
Summary: Flaky test of SparkInterpreterLauncherTest
Key: ZEPPELIN-3428
URL: https://issues.apache.org/jira/browse/ZEPPELIN-3428
Project: Zeppelin
Issue Type: Improvement
Reporter: Jeff Zhang
It may fails due to enviroment issue.
{code:java}
Results :
Failed tests:
SparkInterpreterLauncherTest.testYarnClusterMode_1:129 expected:<3> but
was:<4>
SparkInterpreterLauncherTest.testYarnClusterMode_2:157 expected:<3> but
was:<4>
SparkInterpreterLauncherTest.testLocalMode:53 expected:<2> but was:<3>
SparkInterpreterLauncherTest.testYarnClientMode_1:78 expected:<2> but was:<3>
SparkInterpreterLauncherTest.testYarnClientMode_2:104 expected:<2> but
was:<3>{code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
Re: [DISCUSS] Adjust test logs for CI
+1 on that too From: Jongyoul Lee Sent: Sunday, April 22, 2018 9:30:27 PM To: dev Subject: Re: [DISCUSS] Adjust test logs for CI I like this idea!! On Mon, Apr 23, 2018 at 12:14 PM, Jeff Zhang wrote: > Another thing we can do is to skip the remaining test when we hit test > failure. Currently, zeppelin wont't stop run testing code even hit failed > test. > > http://maven.apache.org/surefire/maven-surefire- > plugin/examples/skip-after-failure.html > > > Jeff Zhang 于2018年4月23日周一 上午11:00写道： > > > > > Regarding selenium test, I agree with you that the log in selenium is > > almost useless. It is hard to figure out what's wrong when selenium test > > fails. Maybe other frontend expert can help on that. > > > > > > > > Jongyoul Lee 于2018年4月23日周一 上午10:55写道： > > > >> @felix, > >> We can enforce to set different log level like ERROR or WARN but I don't > >> think it's a proper solution. > >> > >> @Jeff, > >> I found current master might have a problem with Integration test of > using > >> Selenium but It's hard to see all logs from that tests because there are > >> so > >> many unrelated logs like "sleep...". I can fix this issue, but > generally, > >> I > >> think every contributor doesn't want to see unrelated logs except my > >> tests. > >> When developing a new feature, it would be helpful to see debugger/test > >> logs but after it's implemented, I think it's a bit less-useful and > it's a > >> bit bothersome for another developer. > >> > >> So it would be better to have a consensus to do our best to reduce my > >> logs, > >> especially made by test cases. > >> > >> How do you think of it? > >> > >> JL > >> > >> On Mon, Apr 23, 2018 at 10:04 AM, Jeff Zhang wrote: > >> > >> > Jongyoul, > >> > > >> > What kind of problem do you have ? Each module has log4j.properties > >> under > >> > its test folder that we can change the log level. > >> > > >> > > >> > > >> > Felix Cheung 于2018年4月23日周一 上午3:52写道： > >> > > >> > > Is there a way to do this via enable/disable component for logging > in > >> > > log4j? > >> > > > >> > > > >> > > From: Jongyoul Lee > >> > > Sent: Sunday, April 22, 2018 7:01:54 AM > >> > > To: dev > >> > > Subject: [DISCUSS] Adjust test logs for CI > >> > > > >> > > Hello contributors, > >> > > > >> > > I wonder how you guys think of reducing test logs to help to debug > >> with > >> > CI. > >> > > Recently, Zeppelin's Travis log is too big to read anything. > >> > > > >> > > So I suggest these kinds of step: > >> > > 1. leave test logs as much as you want to test your code passed in > CI > >> > > 2. If passed, please remove all of your test's logs > >> > > > >> > > How do you think of your guys? I know and understand our CI is not > >> good > >> > for > >> > > running multiple times with same code because of lack of resources. > >> > > > >> > > Best regards, > >> > > Jongyoul Lee > >> > > > >> > > -- > >> > > 이종열, Jongyoul Lee, 李宗烈 > >> > > http://madeng.net > >> > > > >> > > >> > >> > >> > >> -- > >> 이종열, Jongyoul Lee, 李宗烈 > >> http://madeng.net > >> > > > -- 이종열, Jongyoul Lee, 李宗烈 http://madeng.net
[GitHub] zeppelin issue #2941: [ZEPPELIN-3311] Zeppelin should ask user to re-login a...
Github user r-kamath commented on the issue: https://github.com/apache/zeppelin/pull/2941 LGTM ---
[GitHub] zeppelin pull request #2942: [HOTFIX] ZEPPELIN-3405 fix permission checks wi...
GitHub user r-kamath opened a pull request: https://github.com/apache/zeppelin/pull/2942 [HOTFIX] ZEPPELIN-3405 fix permission checks with roles ### What is this PR for? hotfix for #2931 https://github.com/apache/zeppelin/pull/2931#issuecomment-383736331 ### What type of PR is it? [Hot Fix] ### Todos * [ ] - Task ### What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-3405 ### How should this be tested? see PR description ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no You can merge this pull request into a Git repository by running: $ git pull https://github.com/r-kamath/zeppelin hotfix_ZEPPELIN-3405 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/2942.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2942 commit b93c2de93609c4837ddf8119b911e9a1c9bc8d07 Author: Renjith Kamath Date: 2018-04-24T11:17:44Z ZEPPELIN-3405 fix permission checks with roles Change-Id: Idc8aea9df2e4aa7df3de04212d3c1f6312d49a67 ---
[GitHub] zeppelin issue #2942: [HOTFIX] ZEPPELIN-3405 fix permission checks with role...
Github user r-kamath commented on the issue: https://github.com/apache/zeppelin/pull/2942 @weand @prabhjyotsingh @zjffdu ---
[GitHub] zeppelin issue #2941: [ZEPPELIN-3311] Zeppelin should ask user to re-login a...
Github user prabhjyotsingh commented on the issue: https://github.com/apache/zeppelin/pull/2941 @r-kamath @zjffdu can you help review this PR. ---
[GitHub] zeppelin pull request #2941: [ZEPPELIN-3311] Zeppelin should ask user to re-...
GitHub user prabhjyotsingh opened a pull request: https://github.com/apache/zeppelin/pull/2941 [ZEPPELIN-3311] Zeppelin should ask user to re-login after JWT cookie expires (KnoxJwtRealm) ### What is this PR for? Zeppelin should ask user to re-login after JWT cookie expires. ### What type of PR is it? [Bug Fix] ### What is the Jira issue? * [ZEPPELIN-3311](https://issues.apache.org/jira/browse/ZEPPELIN-3311) ### How should this be tested? Steps to reproduce : 1) Enable SSO for zeppelin 2) Login to zeppelin using SSO. 3) Now wait till JWT expires(knoxsso.token.ttl under Advanced knoxsso-topology could be set to lower values to get a short lived cookie) 4) Refresh zeppelin. Zeppelin doesn't ask for re-login, though JWT is already expired and not valid anymore. ### Questions: * Does the licenses files need update? N/A * Is there breaking changes for older versions? N/A * Does this needs documentation? N/A You can merge this pull request into a Git repository by running: $ git pull https://github.com/prabhjyotsingh/zeppelin ZEPPELIN-3311 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/2941.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2941 commit 0014d5ad81ba3834c5af06873fda017c7039697f Author: Prabhjyot Singh Date: 2018-04-24T10:12:55Z ZEPPELIN-3311: Zeppelin should ask user to re-login after JWT cookie expires (KnoxJwtRealm) Change-Id: I3957863fb030a3d3426d88576a4aa149d00edc39 ---
[GitHub] zeppelin pull request #2933: [ZEPPELIN-3416] Bump up the version of xercesIm...
Github user asfgit closed the pull request at: https://github.com/apache/zeppelin/pull/2933 ---
