[GitHub] zeppelin issue #3155: [ZEPPELIN-3741] Do not clear "Authorization" header if...

[prabhjyotsingh]

Github user prabhjyotsingh commented on the issue:

https://github.com/apache/zeppelin/pull/3155
  
Will merge this to master if no more discussion.


---

[GitHub] zeppelin issue #3156: [ZEPPELIN-3610] Cluster Raft module design

[liuxunorg]

Github user liuxunorg commented on the issue:

https://github.com/apache/zeppelin/pull/3156
  
@jongyoul @zjffdu ,I have followed the advice you put forward last time 
https://github.com/apache/zeppelin/pull/3074 . Change COPYCAT to ATOMIX 
library, please review my code, thank you!


---

[GitHub] zeppelin pull request #3154: ZEPPELIN-3737. Wrap JobManager page related stu...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/zeppelin/pull/3154


---

[GitHub] zeppelin pull request #3150: ZEPPELIN-3734. Remove runtimeinfo from note.jso...

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/zeppelin/pull/3150


---

[GitHub] zeppelin issue #3150: ZEPPELIN-3734. Remove runtimeinfo from note.json

[Tagar]

Github user Tagar commented on the issue:

https://github.com/apache/zeppelin/pull/3150
  
Thanks
On Tue, Aug 21, 2018 at 7:17 PM Jeff Zhang  wrote:

> Will merge if no more comments
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> , or 
mute
> the thread
> 

> .
>



---

[GitHub] zeppelin issue #3150: ZEPPELIN-3734. Remove runtimeinfo from note.json

[zjffdu]

Github user zjffdu commented on the issue:

https://github.com/apache/zeppelin/pull/3150
  
Will merge if no more comments 


---

[GitHub] zeppelin issue #3154: ZEPPELIN-3737. Wrap JobManager page related stuff into...

[zjffdu]

Github user zjffdu commented on the issue:

https://github.com/apache/zeppelin/pull/3154
  
Will merge if no more comments 


---

[GitHub] zeppelin issue #3151: ZEPPELIN-3735. Wrap WebSocket connection into Connecti...

[zjffdu]

Github user zjffdu commented on the issue:

https://github.com/apache/zeppelin/pull/3151
  
Will merge if no more comments 


---

[GitHub] zeppelin issue #3150: ZEPPELIN-3734. Remove runtimeinfo from note.json

[zjffdu]

Github user zjffdu commented on the issue:

https://github.com/apache/zeppelin/pull/3150
  
No, these fields won't be removed. Only the spark job url is removed. 


---

[GitHub] zeppelin issue #3150: ZEPPELIN-3734. Remove runtimeinfo from note.json

[Tagar]

Github user Tagar commented on the issue:

https://github.com/apache/zeppelin/pull/3150
  
Yep, what I meant are fields like

  "dateCreated": "2018-07-12 13:53:34.479",
  "dateStarted": "2018-07-23 16:27:18.751",
  "dateFinished": "2018-07-23 16:27:55.416",

under "results"

And also

  "user": "rdautkha...@corp.epsilon.com",
  "dateUpdated": "2018-07-23 16:27:18.714",

at the root of paragraph json data.

This information is used to render the string `Took {runtime} sec. Last 
updated by {user} at {dateUpdated}.` at the end of each paragraph, correct? I 
thought this PR removes persisting some of this information, so after zeppelin 
restart this information will get lost, isn't it?

Thanks


---

[GitHub] zeppelin issue #3157: [ZEPPELIN-3654] - New Hazelcast Jet interpreter

[selvinsource]

Github user selvinsource commented on the issue:

https://github.com/apache/zeppelin/pull/3157
  
@felixcheung @zjffdu 
I have just opened the PR for the Hazelcast Jet interpreter as discussed 
before.

Regarding the LICENSE file, I have a question. Do I need to put the license 
for all the jars used by Hazelcast Jet 
(https://github.com/hazelcast/hazelcast-jet/blob/master/pom.xml)? 
So far I only added the Apache License for Hazelcast Jet in  
zeppelin-distribution/src/bin_license/LICENSE.

I will be working on the utility method to display Hazelcast Jet DAG using 
%network to complete ZEPPELIN-3654.


---

[GitHub] zeppelin issue #3092: [ZEPPELIN-3653] - New Java interpreter

[selvinsource]

Github user selvinsource commented on the issue:

https://github.com/apache/zeppelin/pull/3092
  
@felixcheung @zjffdu 
FYI, I have added https://issues.apache.org/jira/browse/ZEPPELIN-3742 based 
on the discussion we had in this PR.


---

[jira] [Created] (ZEPPELIN-3742) Java interpreter to use JShell API

[Vincenzo Selvaggio (JIRA)]

Vincenzo Selvaggio created ZEPPELIN-3742:


 Summary: Java interpreter to use JShell API
 Key: ZEPPELIN-3742
 URL: https://issues.apache.org/jira/browse/ZEPPELIN-3742
 Project: Zeppelin
  Issue Type: Improvement
  Components: Interpreters
Reporter: Vincenzo Selvaggio


When Zeppelin will move to JDK 11, re-write the Java interpreter to use the 
JShell API which will allow a better REPL experience.

C{color:#24292e}urrent implementation is not ideal as a whole class with a main 
method is needed to run some simple java code, the better approach is to use a 
Java REPL API.{color}

With JShell API the user would be able to run multiple snippets across 
paragraph like the other interpreters such as Spark.

{color:#24292e}JSchell is to support both sharing variables between 
paragraphs{color}{color:#24292e} as well as using the ZeppelinContext for 
Zeppelin input/output support. At that point the Java interpreter will have 
comparable features to the other interpreters.{color}

 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] zeppelin pull request #3157: [ZEPPELIN-3654] - New Hazelcast Jet interpreter

[selvinsource]

GitHub user selvinsource opened a pull request:

https://github.com/apache/zeppelin/pull/3157

[ZEPPELIN-3654] - New Hazelcast Jet interpreter

### What is this PR for?
**New Hazelcast Jet interpreter**

Zeppelin has interpreters for different data processing systems like Flink, 
Spark, Kylin, Ignite, Geode, Beam, etc.

Hazelcast Jet is a general purpose distributed data processing engine, 
built on top of Hazelcast for stream/batch processing, comparable if not better 
in terms of performance to the engine supported by Zeppelin therefore a perfect 
candidate for a Zeppelin interpreter.

Part of the interpreter is to have a set of utility methods that print out 
Hazelcast data structures (IMap and ICache) and leverage Zeppelin's built in 
visualization (%table).

What's more, a nice addition is to have the Hazelcast Jet DAG of the 
pipeline displayed as a network graph using %network display system.


### What type of PR is it?
* Feature 

### Todos
* Utility method to display Hazelcast Jet DAG  using %network
* Review LICENCE file
* Any feedback from reviewers

### What is the Jira issue?
* [ZEPPELIN-3654]

### How should this be tested?
Manually
* Start the Zeppelin server
* Create a new note with the hazelcastjet interpreter binding
* Write an Hazelcast Jet job as per documentation 
(docs/interpreter/hazelcastjet.md)
Unit tests
* Run unit tests (HazelcastJetInterpreterTest.java)

### Screenshots (if appropriate)

### Questions:
* Does the licenses files need update?
Yes, added Apache License for Hazelcast Jet.
* Is there breaking changes for older versions?
No.
* Does this needs documentation?
Yes, it has been added to the PR, see docs/interpreter/hazelcastjet.md.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/selvinsource/zeppelin 
hazelcast-jet-interpreter

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/3157.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #3157


commit 80969224126847945247dd1737a71c0de5cd7fc7
Author: Vincenzo Selvaggio 
Date:   2018-08-19T21:58:27Z

Hazelcast Jet Interpreter first commit!

commit cf03b14f575f8d206c86a8de8c9cc78f0accaabf
Author: Vincenzo Selvaggio 
Date:   2018-08-19T22:15:03Z

Hazelcast Jet Interpreter folder restructure.

commit ebaf6c5200e1e4a3d2f3bb1659266d7f234e8686
Author: Vincenzo Selvaggio 
Date:   2018-08-21T19:13:11Z

Documentation example updated.
Some minor fixes.
Added LICENSE for Hazelcast Jet.

commit f179e90fe2ec5ed8229229d98425c8148aaa7c15
Author: Vincenzo Selvaggio 
Date:   2018-08-21T19:54:43Z

Fix rebased merge.




---

[GitHub] zeppelin pull request #3156: [ZEPPELIN-3610] Cluster Raft module design

[liuxunorg]

GitHub user liuxunorg opened a pull request:

https://github.com/apache/zeppelin/pull/3156

[ZEPPELIN-3610] Cluster Raft module design

### What is this PR for?

By using the Raft protocol, multiple Zeppelin-Server groups are built into 
a Zeppelin cluster, the cluster State Machine is maintained through the Raft 
protocol, and the services in the cluster are agreed upon. The Zeppelin-Server 
and Zeppelin-Interperter services and processes are stored in the Cluster 
MetaData. Metadata information;

### What type of PR is it?
[Feature]

### Todos
* [x] add raft algorithm atomix jar
* [x] add cluster state machine
* [x] add state machine query command
* [x] add state machine delete command
* [x] add state machine put command
* [x] Isolate the netty JAR package introduced by atomix

### What is the Jira issue?
* https://issues.apache.org/jira/browse/ZEPPELIN-3610

### How should this be tested?
[CI pass](https://travis-ci.org/liuxunorg/zeppelin/builds/418742522)

### Screenshots (if appropriate)

### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? Yes

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/liuxunorg/zeppelin ZEPPELIN-3610

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/3156.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #3156


commit 99cec8c8a204e9e20716c6721d82574da4d1e823
Author: liuxunorg <33611720@...>
Date:   2018-08-21T14:57:44Z

[ZEPPELIN-3610] Cluster Raft module design

### What is this PR for?

By using the Raft protocol, multiple Zeppelin-Server groups are built into 
a Zeppelin cluster, the cluster State Machine is maintained through the Raft 
protocol, and the services in the cluster are agreed upon. The Zeppelin-Server 
and Zeppelin-Interperter services and processes are stored in the Cluster 
MetaData. Metadata information;

### What type of PR is it?
[Feature]

### Todos
* [x] add raft algorithm atomix jar
* [x] add cluster state machine
* [x] add state machine query command
* [x] add state machine delete command
* [x] add state machine put command
* [x] Isolate the netty JAR package introduced by atomix

### What is the Jira issue?
* https://issues.apache.org/jira/browse/ZEPPELIN-3610

### How should this be tested?
CI pass

### Screenshots (if appropriate)

### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? Yes




---

[GitHub] zeppelin pull request #3117: [ZEPPELIN-3691] Scheduled note continues to wor...

[oxygen311]

Github user oxygen311 closed the pull request at:

https://github.com/apache/zeppelin/pull/3117


---

[GitHub] zeppelin pull request #3117: [ZEPPELIN-3691] Scheduled note continues to wor...

[oxygen311]

GitHub user oxygen311 reopened a pull request:

https://github.com/apache/zeppelin/pull/3117

[ZEPPELIN-3691] Scheduled note continues to work in the trash

### What is this PR for?
Fix bug with scheduled note working in the trash.

How to repeat bug:
1. Make scheduled note with cron;
2. Move it to trash;
3. Restart zeppelin.

### What type of PR is it?
Bug Fix

### What is the Jira issue?
[ZEPPELIN-3691](https://issues.apache.org/jira/browse/ZEPPELIN-3691)

### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/TinkoffCreditSystems/zeppelin DW-17950

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/3117.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #3117


commit b3e7d0c995c4c6cac868c7267e75b598203f3216
Author: oxygen311 
Date:   2018-08-08T14:15:25Z

Check is note in trash in `refreshCron`

commit 27f92e29f0fd3d1de92261f950a1a6ec48b62f19
Author: oxygen311 
Date:   2018-08-16T12:20:42Z

Add test for cron note in trash

commit 074613701fd436224ea276777057cd072a11b4bd
Author: oxygen311 
Date:   2018-08-20T11:12:14Z

Merge branch 'master' of https://github.com/apache/zeppelin into 
DW-17950-cronTrash

# Conflicts:
#   
zeppelin-zengine/src/main/java/org/apache/zeppelin/notebook/Notebook.java




---

[GitHub] zeppelin issue #3117: [ZEPPELIN-3691] Scheduled note continues to work in th...

[oxygen311]

Github user oxygen311 commented on the issue:

https://github.com/apache/zeppelin/pull/3117
  
@zjffdu 
Sorry, you are right. Fixed


---

[GitHub] zeppelin issue #3155: [ZEPPELIN-3741] Do not clear "Authorization" header if...

[prabhjyotsingh]

Github user prabhjyotsingh commented on the issue:

https://github.com/apache/zeppelin/pull/3155
  
@zjffdu @felixcheung @r-kamath can you help review this.

I've tested this on latest versions of Chrome (Mac), Firefox (Mac), Edge 
(Windows 10).


---

[GitHub] zeppelin pull request #3155: [ZEPPELIN-3741] Do not clear "Authorization" he...

[prabhjyotsingh]

GitHub user prabhjyotsingh opened a pull request:

https://github.com/apache/zeppelin/pull/3155

[ZEPPELIN-3741] Do not clear "Authorization" header if Z-server is running 
behind proxy

### What is this PR for?
There can be a case where Zeppelin-Sever is running as 
Form-Based-Authentication, however, it can be running behind a proxy which may 
be requiring Authorization header.
The idea of this PR is to not clear that header when it behind a proxy and 
control it with config.

### What type of PR is it?
[Bug Fix]

### What is the Jira issue?
* [ZEPPELIN-3741](https://issues.apache.org/jira/browse/ZEPPELIN-3741)

### How should this be tested?
* Configure Nginx to run with `auth_basic` option
* Start Zeppelin server behind a proxy server like Nginx 
* Make sure that `shiro.ini` is configured to run with `/** = authc`
* In `zeppelin-site.xml` configure 
`zeppelin.server.clear.authorization.header` as `false`
Now on logout from Zeppelin-Server should not clear *Authorization* header 
of Nginx


### Questions:
* Does the licenses files need update? N/A
* Is there breaking changes for older versions? N/A
* Does this needs documentation? Yes


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/prabhjyotsingh/zeppelin ZEPPELIN-3741

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/3155.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #3155


commit 91249e182053e4a022b93067dca4f48caea68dc5
Author: Prabhjyot Singh 
Date:   2018-08-21T09:40:04Z

ZEPPELIN-3741: Do not clear "Authorization" header if Z-server is running 
behind proxy

Change-Id: I6ff2e58026dd744821e9c5ccaf8fd0658cf610bd




---

[jira] [Created] (ZEPPELIN-3741) Do not clear "Authorization" header if Z-server is running behind proxy

[Prabhjyot Singh (JIRA)]

Prabhjyot Singh created ZEPPELIN-3741:
-

 Summary: Do not clear "Authorization" header if Z-server is 
running behind proxy
 Key: ZEPPELIN-3741
 URL: https://issues.apache.org/jira/browse/ZEPPELIN-3741
 Project: Zeppelin
  Issue Type: Bug
Affects Versions: 0.8.0
Reporter: Prabhjyot Singh
Assignee: Prabhjyot Singh


There can be a case where Zeppelin-Sever is running as 
Form-Based-Authentication, however, it can be running behind a proxy which may 
be requiring Authorization header.
Idea of this JIRA is to not clear those header when it behing proxy and control 
it with config.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (ZEPPELIN-3740) Adopt google-java-format

[Jongyoul Lee (JIRA)]

Jongyoul Lee created ZEPPELIN-3740:
--

 Summary: Adopt google-java-format
 Key: ZEPPELIN-3740
 URL: https://issues.apache.org/jira/browse/ZEPPELIN-3740
 Project: Zeppelin
  Issue Type: Improvement
Reporter: Jongyoul Lee


google-java-format and its maven plugin validate format and change files as 
well. It would help to manage our codes. I'll add it in the current pom.xml and 
enable one by one.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[DISCUSS] Adopt google-java-format

[Jongyoul Lee]

Hi devs,

We are using checkstyle and its maven plugin to check style. It looks
reasonable but I got a checkstyle violation since it's different from
IntelliJ's formatter setting of formatting lambda function.

Thus, how about adopting google-java-format in your IDE and its maven
plugin to fix formatter issues?

See https://github.com/google/google-java-format and
https://github.com/coveo/fmt-maven-plugin

It's, strictly, not a checker, but formatter as it changes wrong formats
when building it.

WDYT?

-- 
이종열, Jongyoul Lee, 李宗烈
http://madeng.net

[GitHub] zeppelin issue #3153: [ZEPPELIN-3738] Fix enabling JMX in ZeppelinServer

[felixcheung]

Github user felixcheung commented on the issue:

https://github.com/apache/zeppelin/pull/3153
  
LGTM


---