[GitHub] zeppelin pull request #3161: [MINOR] Fix incompatibilities for python3

2018-08-22 Thread jongyoul 
GitHub user jongyoul opened a pull request:

https://github.com/apache/zeppelin/pull/3161

[MINOR] Fix incompatibilities for python3

### What is this PR for?
Enabling `dev/merge_zeppelin_pr.py` under python3 environment

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/jongyoul/zeppelin 
minor/fix-merge-script-for-python3

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/3161.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #3161


commit 07478416cbc9d8d3db83d7306d7f16cbe98b03eb
Author: Jongyoul Lee 
Date:   2018-08-23T05:51:10Z

Fix incompatibilities for python3




---

[GitHub] zeppelin issue #3158: [ZEPPELIN-3740] Adopt `google-java-format` and `fmt-ma...

2018-08-22 Thread felixcheung 
Github user felixcheung commented on the issue:

https://github.com/apache/zeppelin/pull/3158
  
ok


---

[GitHub] zeppelin pull request #3160: [MINOR] Update `package-lock.json`

2018-08-22 Thread asfgit 
Github user asfgit closed the pull request at:

https://github.com/apache/zeppelin/pull/3160


---

[GitHub] zeppelin issue #3158: [ZEPPELIN-3740] Adopt `google-java-format` and `fmt-ma...

2018-08-22 Thread jongyoul 
Github user jongyoul commented on the issue:

https://github.com/apache/zeppelin/pull/3158
  
Agreed to maintain harder. This would be one of criteria. Actually, this 
formatter doesn't have to fix format manually, just run `mvn fmt:format` before 
rebasing it. I also started a discussion in dev@


---

[GitHub] zeppelin issue #3158: [ZEPPELIN-3740] Adopt `google-java-format` and `fmt-ma...

2018-08-22 Thread felixcheung 
Github user felixcheung commented on the issue:

https://github.com/apache/zeppelin/pull/3158
  
I see. might be good to get some consensus first - we seem to be doing 
quite a bit of style changes in the last few months, it would make maintenance 
or backporting harder, for example.


---

[GitHub] zeppelin issue #3158: [ZEPPELIN-3740] Adopt `google-java-format` and `fmt-ma...

2018-08-22 Thread jongyoul 
Github user jongyoul commented on the issue:

https://github.com/apache/zeppelin/pull/3158
  
@felixcheung IntelliJ's lambda format was not matched in our current 
checkstyle. I've tried to fix it by changing checkstyle, but I felt depressed 
because we should do every time whenever this inconsistency occurs. So I 
thought it would be better to change IDE's style and maven formatter to the 
same tool. That's the basic reason why I'd like to change style-related plugins


---

[GitHub] zeppelin issue #3158: [ZEPPELIN-3740] Adopt `google-java-format` and `fmt-ma...

2018-08-22 Thread felixcheung 
Github user felixcheung commented on the issue:

https://github.com/apache/zeppelin/pull/3158
  
what's wrong with `maven-checkstyle-plugin`?


---

[GitHub] zeppelin issue #3158: [ZEPPELIN-3740] Adopt `google-java-format` and `fmt-ma...

2018-08-22 Thread jongyoul 
Github user jongyoul commented on the issue:

https://github.com/apache/zeppelin/pull/3158
  
https://travis-ci.org/jongyoul/zeppelin/builds/419215810

4th profiles is unstable now for the current master.

Will merge it if there's no more discussion


---

[GitHub] zeppelin pull request #3160: [Update `package-lock.json`

2018-08-22 Thread jongyoul 
GitHub user jongyoul opened a pull request:

https://github.com/apache/zeppelin/pull/3160

[Update `package-lock.json`

### What is this PR for?
A few sentences describing the overall goals of the pull request's commits.
First time? Check out the contributing guide - 
https://zeppelin.apache.org/contribution/contributions.html


### What type of PR is it?
[Bug Fix | Improvement | Feature | Documentation | Hot Fix | Refactoring]

### Todos
* [ ] - Task

### What is the Jira issue?
* Open an issue on Jira https://issues.apache.org/jira/browse/ZEPPELIN/
* Put link here, and add [ZEPPELIN-*Jira number*] in PR title, eg. 
[ZEPPELIN-533]

### How should this be tested?
* First time? Setup Travis CI as described on 
https://zeppelin.apache.org/contribution/contributions.html#continuous-integration
* Strongly recommended: add automated unit tests for any new or changed 
behavior
* Outline any manual steps to test the PR here.

### Screenshots (if appropriate)

### Questions:
* Does the licenses files need update?
* Is there breaking changes for older versions?
* Does this needs documentation?


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/jongyoul/zeppelin 
minor/update-package-lock-json

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/3160.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #3160


commit 8996ec0122bf32cb0dafbf17deb7bf8b99805f8d
Author: Jongyoul Lee 
Date:   2018-08-23T02:35:39Z

Update `package-lock.json`




---

[GitHub] zeppelin issue #3157: [ZEPPELIN-3654] - New Hazelcast Jet interpreter

2018-08-22 Thread zjffdu 
Github user zjffdu commented on the issue:

https://github.com/apache/zeppelin/pull/3157
  
Thanks @selvinsource , it make sense to me. 


---

[GitHub] zeppelin pull request #3153: [ZEPPELIN-3738] Fix enabling JMX in ZeppelinSer...

2018-08-22 Thread asfgit 
Github user asfgit closed the pull request at:

https://github.com/apache/zeppelin/pull/3153


---

[GitHub] zeppelin pull request #3159: [WIP][ZEPPELIN-3733] Refactor `Notebook*` class...

2018-08-22 Thread jongyoul 
GitHub user jongyoul opened a pull request:

https://github.com/apache/zeppelin/pull/3159

[WIP][ZEPPELIN-3733] Refactor `Notebook*` classes to remove circular 
dependencies and several listeners

### What is this PR for?
Decoupling `Notebook*` classes as they depend each others. it makes 
circular dependencies, and it bothers that contributors understand code.

### What type of PR is it?
[Refactoring]

### Todos
* [ ] - Task

### What is the Jira issue?
* https://issues.apache.org/jira/browse/ZEPPELIN-3733

### How should this be tested?
CI passes

### Screenshots (if appropriate)

### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/jongyoul/zeppelin ZEPPELIN-3733

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/3159.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #3159


commit 31d78d79b739734befd163fb59585802fd57b92e
Author: Jongyoul Lee 
Date:   2018-08-20T16:02:29Z

Add trick to fix tests (+9 squashed commits)
Squashed commits:
[807e286] Fix tests
[3b6ad26] Fix style
Remove unused code
[2dc0946] Fix style
[7e96118] Remove unused code
[472696d] Remove unused code
[0ff6bdb] Change `ParagraphJobListener` from a parameter of constructor to 
setter
Add code to enable `NotebookService` to set `ParagraphJobListener` into 
`Notebook`
Add code to inject `NotebookServer` to `NotebookService`
Add conservative logic to prepare the case where `ParagraphJobListener` is 
null
[e97e165] Fix `NotebookServerTest`
[1eccc3c] Change scopes for some bound classes
[4c662c9] Add more injection code in NotebookRestApi
Bind `NotebookAuthorization` and `NotebookService`
Provide `getInstance()` of `ConfigurationService` and `NotebookService` to 
let `NotebookServer` call them




---

[GitHub] zeppelin pull request #3158: [ZEPPELIN-3740] Adopt `google-java-format` and ...

2018-08-22 Thread jongyoul 
GitHub user jongyoul opened a pull request:

https://github.com/apache/zeppelin/pull/3158

[ZEPPELIN-3740] Adopt `google-java-format` and `fmt-maven-plugin`

### What is this PR for?
Avoiding outdated checkstyle error.

To check format
`mvn validate`

To fix non-complying files
`mvn fmt:format`

### What type of PR is it?
[Improvement | Refactoring]

### Todos
* [x] - Adopt `fmt-maven-plugin`

### What is the Jira issue?
* https://issues.apache.org/jira/browse/ZEPPELIN-3740

### How should this be tested?
CI passs

### Screenshots (if appropriate)

### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? Yes for contributors


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/jongyoul/zeppelin ZEPPELIN-3740

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/3158.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #3158


commit f8f28799d9f317e1b0bd9a7000f2aa1902fbeeb3
Author: Jongyoul Lee 
Date:   2018-08-21T08:45:04Z

Adopt `fmt-maven-plugin` for google-java-format

commit f36dbde41ce5f2636cf6132c08d9f24b3cbcef33
Author: Jongyoul Lee 
Date:   2018-08-21T09:31:21Z

Disable `maven-checkstyle-plugin` to `zeppelin-server` and 
`zeppelin-zengine`
Enable `fmt-maven-plugin` to `zeppelin-server` and `zeppelin-zengine`

commit c2f8c046dd7354a262bf9b63918a81b946119d4a
Author: Jongyoul Lee 
Date:   2018-08-22T06:35:04Z

Remove checkstyle plugin for all modules

commit 91a645e7111a8f4aaf806a30bd2407b24fbfec2e
Author: Jongyoul Lee 
Date:   2018-08-22T08:00:22Z

Enable `fmt-maven-plugin` for all modules

commit f4a960d98987d7d912af4fca361166de36ec0954
Author: Jongyoul Lee 
Date:   2018-08-22T08:57:40Z

Add configuration to show all un-complying files

commit 3b884735e5099bccfc86052401d4063db79a2707
Author: Jongyoul Lee 
Date:   2018-08-22T09:14:51Z

Adopt all files




---

[GitHub] zeppelin pull request #3155: [ZEPPELIN-3741] Do not clear "Authorization" he...

2018-08-22 Thread asfgit 
Github user asfgit closed the pull request at:

https://github.com/apache/zeppelin/pull/3155


---

[GitHub] zeppelin issue #3157: [ZEPPELIN-3654] - New Hazelcast Jet interpreter

2018-08-22 Thread selvinsource 
Github user selvinsource commented on the issue:

https://github.com/apache/zeppelin/pull/3157
  
@zjffdu this PR is a start. As I said I still need to add Utils methods 
specific to Jet, in particular the Utils that convert the Jet DAG pipeline to a 
network graph using Zeppelin display system. If we don't have an Hazelcast Jet 
interpreter where would we put that code? It doesn't belong to the Java 
interpreter.

Also, when the Java interpreter will be moved to JShell API (for which I 
created a JIRA issue), there is a lot more that can be added to the Hazelcast 
Jet interpreter like configuring the JetInstance (being a client or a node of 
the cluster) in the interpreter properties so the user don't need to do that 
for every note or paragraph.

You could say the same for the Beam interpreter, right now it extends the 
Java interpreter and simply add some dependencies, however I still see value in 
that so that the end user can just code beam without worrying about the so many 
dependencies required.

Let me know what you think before I proceed in working on the Jet specific 
Utils methods.




---

[GitHub] zeppelin issue #3157: [ZEPPELIN-3654] - New Hazelcast Jet interpreter

2018-08-22 Thread zjffdu 
Github user zjffdu commented on the issue:

https://github.com/apache/zeppelin/pull/3157
  
@selvinsource I don't see any difference between Hazelcast Jet interpreter 
& java interpreter except extra dependency on hazelcast-jet. So why not use 
Hazelcast Jet just by adding hazelcast-jet as dependency of java interpreter ?


---

[GitHub] zeppelin pull request #3151: ZEPPELIN-3735. Wrap WebSocket connection into C...

2018-08-22 Thread asfgit 
Github user asfgit closed the pull request at:

https://github.com/apache/zeppelin/pull/3151


---

[jira] [Created] (ZEPPELIN-3743) java.lang.RuntimeException: Multiple py4j files found under /usr/lib/spark/python/lib

2018-08-22 Thread Valery Khamenya (JIRA) 
Valery Khamenya created ZEPPELIN-3743:
-

 Summary: java.lang.RuntimeException: Multiple py4j files found 
under /usr/lib/spark/python/lib
 Key: ZEPPELIN-3743
 URL: https://issues.apache.org/jira/browse/ZEPPELIN-3743
 Project: Zeppelin
  Issue Type: Bug
  Components: pySpark, python-interpreter
Affects Versions: 0.8.0
 Environment: AWS Linux running EMR 5.16.0 

Zeppelin 0.8 is installed using the latest official full bundle.

 
Reporter: Valery Khamenya


The following error is mistakenly reported:

{{  java.lang.RuntimeException: Multiple py4j files found under 
}}{{/usr/lib/spark/python/lib}}

{{The error happens e.g. during the execution of import plotly}}

{{The content of /usr/lib/spark/python/lib :}}

{{$ ll /usr/lib/spark/python/lib}}
{{total 580}}
{{-rw-r--r-- 1 root root 42437 29. Jun 18:11 py4j-0.10.7-src.zip}}
{{-rw-r--r-- 1 root root 1445 29. Jun 18:11 PY4J_LICENSE.txt}}
{{lrwxrwxrwx 1 root root 19 20. Aug 14:01 py4j-src.zip -> py4j-0.10.7-src.zip}}
{{-rw-r--r-- 1 root root 543385 29. Jun 18:11 pyspark.zip}}

That is, a symlink is treated as a file.

The line of code containing bug:

[https://github.com/apache/zeppelin/blob/001c621c773db837b4c90bbf7868c94f284247ce/spark/interpreter/src/main/java/org/apache/zeppelin/spark/PythonUtils.java#L74]

If symlinks are resolved to the explicit path to the targeted file, then there 
will be only one file.

 

 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)