[GitHub] felixcheung commented on issue #3244: [ZEPPELIN-3882] Neo4jInterpreter - Support Point and Date Types

[GitBox]

felixcheung commented on issue #3244: [ZEPPELIN-3882] Neo4jInterpreter - 
Support Point and Date Types
URL: https://github.com/apache/zeppelin/pull/3244#issuecomment-448892316
 
 
   it looks like the github rebase and merge option is picking the last commit 
description


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] felixcheung closed pull request #3244: [ZEPPELIN-3882] Neo4jInterpreter - Support Point and Date Types

[GitBox]

felixcheung closed pull request #3244: [ZEPPELIN-3882] Neo4jInterpreter - 
Support Point and Date Types
URL: https://github.com/apache/zeppelin/pull/3244
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/docs/interpreter/neo4j.md b/docs/interpreter/neo4j.md
index 1b14127d52..eec9e077b1 100644
--- a/docs/interpreter/neo4j.md
+++ b/docs/interpreter/neo4j.md
@@ -26,6 +26,9 @@ limitations under the License.
 ## Overview
 [Neo4j](https://neo4j.com/product/) is a native graph database, designed to 
store and process graphs from bottom to top.
 
+### Supported Version
+
+The Neo4j Interpreter supports all Neo4j versions since v3 via the official 
[Neo4j Java Driver](https://github.com/neo4j/neo4j-java-driver)
 
 ![Neo4j - Interpreter - 
Video]({{BASE_PATH}}/assets/themes/zeppelin/img/docs-img/neo4j-interpreter-video.gif)
 
diff --git a/neo4j/pom.xml b/neo4j/pom.xml
index b8a89ad27c..cc39fdcf10 100644
--- a/neo4j/pom.xml
+++ b/neo4j/pom.xml
@@ -33,9 +33,9 @@
   Zeppelin: Neo4j interpreter
   
   
-   1.4.3
-   3.2.3
-   3.2.3
+   1.7.1
+   3.4.10
+   3.4.10
2.8.9
 neo4j
   
diff --git 
a/neo4j/src/main/java/org/apache/zeppelin/graph/neo4j/Neo4jCypherInterpreter.java
 
b/neo4j/src/main/java/org/apache/zeppelin/graph/neo4j/Neo4jCypherInterpreter.java
index bcb9d7b96a..d7f848548e 100644
--- 
a/neo4j/src/main/java/org/apache/zeppelin/graph/neo4j/Neo4jCypherInterpreter.java
+++ 
b/neo4j/src/main/java/org/apache/zeppelin/graph/neo4j/Neo4jCypherInterpreter.java
@@ -201,6 +201,20 @@ private void addValueToLine(String key, List 
columns, List line,
   value = val.asList();
 } else if (val.hasType(InternalTypeSystem.TYPE_SYSTEM.MAP())) {
   value = val.asMap();
+} else if (val.hasType(InternalTypeSystem.TYPE_SYSTEM.POINT())) {
+  value = val.asPoint();
+} else if (val.hasType(InternalTypeSystem.TYPE_SYSTEM.DATE())) {
+  value = val.asLocalDate();
+} else if (val.hasType(InternalTypeSystem.TYPE_SYSTEM.TIME())) {
+  value = val.asOffsetTime();
+} else if (val.hasType(InternalTypeSystem.TYPE_SYSTEM.LOCAL_TIME())) {
+  value = val.asLocalTime();
+} else if 
(val.hasType(InternalTypeSystem.TYPE_SYSTEM.LOCAL_DATE_TIME())) {
+  value = val.asLocalDateTime();
+} else if (val.hasType(InternalTypeSystem.TYPE_SYSTEM.DATE_TIME())) {
+  value = val.asZonedDateTime();
+} else if (val.hasType(InternalTypeSystem.TYPE_SYSTEM.DURATION())) {
+  value = val.asIsoDuration();
 }
   }
   if (value instanceof Collection) {
diff --git 
a/neo4j/src/test/java/org/apache/zeppelin/graph/neo4j/Neo4jCypherInterpreterTest.java
 
b/neo4j/src/test/java/org/apache/zeppelin/graph/neo4j/Neo4jCypherInterpreterTest.java
index 24bd5130e6..7940d5f857 100644
--- 
a/neo4j/src/test/java/org/apache/zeppelin/graph/neo4j/Neo4jCypherInterpreterTest.java
+++ 
b/neo4j/src/test/java/org/apache/zeppelin/graph/neo4j/Neo4jCypherInterpreterTest.java
@@ -55,10 +55,15 @@
   private static final String REL_KNOWS = "KNOWS";
 
   private static final String CYPHER_FOREACH =
-  "FOREACH (x in range(1,1000) | CREATE (:%s{name: \"name\" + x, age: 
%s}))";
-  private static final String CHPHER_UNWIND = "UNWIND range(1,1000) as x "
-+ "MATCH (n), (m) WHERE id(n) = x AND id(m) = toInt(rand() * 1000) "
+  "FOREACH (x in range(1,100) | CREATE (:%s{name: \"name\" + x, age: 
%s, " +
+  "address: point({ longitude: 56.7, latitude: 12.78, height: 
8 }), " +
+  "birth: date('1984-04-04')}))";
+  private static final String CHPHER_UNWIND = "UNWIND range(1,100) as x "
++ "MATCH (n), (m) WHERE id(n) = x AND id(m) = toInt(rand() * 100) "
 + "CREATE (n)-[:%s]->(m)";
+  
+  private static final String TABLE_RESULT_PREFIX = "%table ";
+  private static final String NETWORK_RESULT_PREFIX = "%network ";
 
   @BeforeClass
   public static void setUpNeo4jServer() throws Exception {
@@ -73,7 +78,7 @@ public static void setUpNeo4jServer() throws Exception {
   public static void tearDownNeo4jServer() throws Exception {
 server.close();
   }
-  
+
   @Before
   public void setUpZeppelin() {
 Properties p = new Properties();
@@ -83,7 +88,7 @@ public void setUpZeppelin() {
 interpreter = new Neo4jCypherInterpreter(p);
 context = InterpreterContext.builder()
 .setInterpreterOut(new InterpreterOutput(null))
-.build();;
+.build();
   }
 
   @After
@@ -98,14 +103,15 @@ public void testTableWithArray() {
 "return 'a' as colA, 'b' as colB, [1, 2, 3] as colC", context);
 assertEquals(Code.SUCCESS, result.code());
 final String tableResult = 

[GitHub] xueyumusic commented on issue #3266: [ZEPPELIN-3914] upgrade Flink to 1.7.0

[GitBox]

xueyumusic commented on issue #3266: [ZEPPELIN-3914] upgrade Flink to 1.7.0
URL: https://github.com/apache/zeppelin/pull/3266#issuecomment-448887847
 
 
   Thanks for review, @felixcheung @zjffdu . We are deploying zeppelin recently 
and try to use with some flink interpreter. I will share some details 
later..Currently I personally feel that it looks lack of flink sql usage doc. 
From 
[here](http://zeppelin.apache.org/docs/0.9.0-SNAPSHOT/interpreter/flink.html) 
it seems only have api example. Also I wonder whether zeppelin could support 
flink table api or future will do. Thanks, @zjffdu 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Re: Requested gitbox migration

[Jeff Zhang]

Thanks Jongyoul

Felix Cheung  于2018年12月20日周四 下午12:05写道：

> Thanks!
>
> 
> From: Jongyoul Lee 
> Sent: Wednesday, December 19, 2018 6:09:50 PM
> To: dev
> Subject: Requested gitbox migration
>
> Please check the link below:
> https://issues.apache.org/jira/browse/INFRA-17477
>
> JL
>
> --
> 이종열, Jongyoul Lee, 李宗烈
> http://madeng.net
>


-- 
Best Regards

Jeff Zhang

Re: Requested gitbox migration

[Felix Cheung]

Thanks!


From: Jongyoul Lee 
Sent: Wednesday, December 19, 2018 6:09:50 PM
To: dev
Subject: Requested gitbox migration

Please check the link below:
https://issues.apache.org/jira/browse/INFRA-17477

JL

--
이종열, Jongyoul Lee, 李宗烈
http://madeng.net

[GitHub] fred521 commented on issue #3254: [ZEPPELIN-3575] Add 'Copy Column Name' to table visualisation-table

[GitBox]

fred521 commented on issue #3254: [ZEPPELIN-3575] Add 'Copy Column Name' to 
table visualisation-table 
URL: https://github.com/apache/zeppelin/pull/3254#issuecomment-448836624
 
 
   It won’t well as long as you use this component.
   
   The ui-Grid will generate tons of watchers in angularjs
   
   For example, 10 paragraphs of ui-grid in one notebook, and each paragraph
   has 10k records .
   
   It will generate 22k watchers in the angularjs session, slow down speed and
   performance a lot.
   
   Test that in some kind of angularjs debug tool.
   
   https://github.com/angular-ui/ui-grid/issues/5547
   
   
   On Wed, Dec 19, 2018 at 17:47 Xun Liu  wrote:
   
   > UI-Grid actually creates a lot of performance issue, why not deprecate it
   > but still introducing new feature?
   >
   > In my service, I completely wiped out UI-Grid
   >
   > What are the performance issues with UI-Grid? We should improve him, not
   > give up on him.
   >
   > —
   > You are receiving this because you were mentioned.
   > Reply to this email directly, view it on GitHub
   > , or 
mute
   > the thread
   > 

   > .
   >
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Requested gitbox migration

[Jongyoul Lee]

Please check the link below:
https://issues.apache.org/jira/browse/INFRA-17477

JL

-- 
이종열, Jongyoul Lee, 李宗烈
http://madeng.net

Re: [DISCUSS] Moving to gitbox

[Jongyoul Lee]

Got it. Then, let's try to do it.

On Sat, Dec 15, 2018 at 1:36 PM Felix Cheung 
wrote:

> I believe that’s what the earlier thread is for.
>
>
> 
> From: Jongyoul Lee 
> Sent: Thursday, December 13, 2018 9:54 PM
> To: dev
> Subject: Re: [DISCUSS] Moving to gitbox
>
> Yes, right.
>
> That's because Infra suggests that we leave a mail thread to make a
> consensus about it.
>
>
> On Fri, Dec 14, 2018 at 12:14 PM Felix Cheung 
> wrote:
>
> > Hi Jongyoul - is this the same as the earlier thread?
> >
> >
> > 
> > From: Jongyoul Lee 
> > Sent: Tuesday, December 11, 2018 6:28 PM
> > To: dev
> > Subject: [DISCUSS] Moving to gitbox
> >
> > Hi, devs,
> >
> > I'd like to make a consensus to move our repository from git-wip to
> gitbox.
> >
> > Please give your opinions with replies from this email.
> >
> > Thanks in advance,
> > JL
> >
> > --
> > 이종열, Jongyoul Lee, 李宗烈
> > http://madeng.net
> >
>
>
> --
> 이종열, Jongyoul Lee, 李宗烈
> http://madeng.net
>


-- 
이종열, Jongyoul Lee, 李宗烈
http://madeng.net

[GitHub] zeppelin issue #3254: [ZEPPELIN-3575] Add 'Copy Column Name' to table visual...

[liuxunorg]

Github user liuxunorg commented on the issue:

https://github.com/apache/zeppelin/pull/3254
  
> UI-Grid actually creates a lot of performance issue, why not deprecate it 
but still introducing new feature?
> 
> In my service, I completely wiped out UI-Grid

What are the performance issues with UI-Grid? We should improve him, not 
give up on him.


---

[GitHub] zeppelin issue #3254: [ZEPPELIN-3575] Add 'Copy Column Name' to table visual...

[egorklimov]

Github user egorklimov commented on the issue:

https://github.com/apache/zeppelin/pull/3254
  
@fred521 Could you please describe issues that you have faced?


---

[GitHub] zeppelin issue #3205: [ZEPPELIN-3814] Add apply button to table settings

[egorklimov]

Github user egorklimov commented on the issue:

https://github.com/apache/zeppelin/pull/3205
  
I decided to put floppy icon as in `advanced-transformation-setting`.

@jongyoul please help reviewing this.


---

[jira] [Created] (ZEPPELIN-3918) Problem compiling Zeppelin 0.9.0-SNAPSHOT

[AV (JIRA)]

AV created ZEPPELIN-3918:


 Summary: Problem compiling Zeppelin 0.9.0-SNAPSHOT
 Key: ZEPPELIN-3918
 URL: https://issues.apache.org/jira/browse/ZEPPELIN-3918
 Project: Zeppelin
  Issue Type: Bug
  Components: zeppelin-interpreter
Affects Versions: 0.9.0
 Environment: Debian Stretch x64
Reporter: AV


It seems that some resources are not available:

[ERROR] Failed to execute goal on project zeppelin-beam: Could not resolve 
dependencies for project org.apache.zeppelin:zeppelin-beam:jar:0.9.0-SNAPSHOT: 
The following artifacts could not be resolved: 
org.apache.zeppelin:zeppelin-scio_2.11:jar:0.9.0-SNAPSHOT, 
org.apache.beam:beam-runners-flink_2.11:jar:2.0.0: Could not find artifact 
org.apache.zeppelin:zeppelin-scio_2.11:jar:0.9.0-SNAPSHOT in apache.snapshots 
(http://repository.apache.org/snapshots) -> [Help 1]

Command Line:

mvn clean package -DskipTests -Dhadoop.version=2.7.3 
-Dspark.bin.download.url=file:///srv/spark-2.4.0-bin-hadoop2.7.tgz -Pscala-2.11 
-Pbuild-distr | tee build.log

 

Any ideas?



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] zeppelin issue #3265: [ZEPPELIN-3910] IPython delete temp file and close str...

[zjffdu]

Github user zjffdu commented on the issue:

https://github.com/apache/zeppelin/pull/3265
  
LGTM


---

[GitHub] zeppelin issue #3266: [ZEPPELIN-3914] upgrade Flink to 1.7.0

[zjffdu]

Github user zjffdu commented on the issue:

https://github.com/apache/zeppelin/pull/3266
  
LGTM


---