[GitHub] felixcheung commented on a change in pull request #3302: [ZEPPELIN-3988] Paragraph Text output includes \r\n is not displayed correctly.
felixcheung commented on a change in pull request #3302: [ZEPPELIN-3988]
Paragraph Text output includes \r\n is not displayed correctly.
URL: https://github.com/apache/zeppelin/pull/3302#discussion_r253374351
##
File path: zeppelin-web/src/app/notebook/paragraph/result/result.js
##
@@ -0,0 +1,9 @@
+export default class Result {
+ constructor(data) {
+this.data = data;
+ }
+
+ checkAndReplaceCarriageReturn() {
+return this.data.replace(/(\r\n)/gm, '\n');
Review comment:
I think the case was that it could have `\r` by itself..
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] Savalek closed pull request #3281: [ZEPPELIN-3943] - Add button "stop notebook execution"
Savalek closed pull request #3281: [ZEPPELIN-3943] - Add button "stop notebook execution" URL: https://github.com/apache/zeppelin/pull/3281 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] Leemoonsoo closed pull request #3299: [ZEPPELIN-3920] [FOLLOWUP] get correct hyperlink address when num job url is one
Leemoonsoo closed pull request #3299: [ZEPPELIN-3920] [FOLLOWUP] get correct hyperlink address when num job url is one URL: https://github.com/apache/zeppelin/pull/3299 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] Leemoonsoo opened a new pull request #3299: [ZEPPELIN-3920] [FOLLOWUP] get correct hyperlink address when num job url is one
Leemoonsoo opened a new pull request #3299: [ZEPPELIN-3920] [FOLLOWUP] get correct hyperlink address when num job url is one URL: https://github.com/apache/zeppelin/pull/3299 ### What is this PR for? After change https://github.com/apache/zeppelin/pull/3273, invalid value is assigned to the Job link when only one JobUrl exists. ### What type of PR is it? Bug Fix ### What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-3920 ### How should this be tested? Test manually ### Questions: * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] Leemoonsoo commented on issue #3295: Fix misspelled word
Leemoonsoo commented on issue #3295: Fix misspelled word URL: https://github.com/apache/zeppelin/pull/3295#issuecomment-460332823 Thanks @gignac-cha for the fix. LGTM This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] asfgit closed pull request #3298: [ZEPPELIN-3982] add how to setup development mode for Kubernetes support
asfgit closed pull request #3298: [ZEPPELIN-3982] add how to setup development mode for Kubernetes support URL: https://github.com/apache/zeppelin/pull/3298 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] Leemoonsoo commented on issue #3300: ZEPPELIN-3983. Travis fails due to downloading spark takes a lot of time
Leemoonsoo commented on issue #3300: ZEPPELIN-3983. Travis fails due to downloading spark takes a lot of time URL: https://github.com/apache/zeppelin/pull/3300#issuecomment-460332250 Looks great! +1 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] Leemoonsoo opened a new pull request #3303: [ZEPPELIN-3989] Configure IPython Interpreter in Docker image
Leemoonsoo opened a new pull request #3303: [ZEPPELIN-3989] Configure IPython Interpreter in Docker image URL: https://github.com/apache/zeppelin/pull/3303 ### What is this PR for? Configure IPython interpreter in Docker image by installing necessary dependencies. ### What type of PR is it? Improvement ### What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-3989 ### How should this be tested? Build docker image and see if %python interpreter works with Ipython kernel. ### Questions: * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] Leemoonsoo commented on a change in pull request #3303: [ZEPPELIN-3989] Configure IPython Interpreter in Docker image
Leemoonsoo commented on a change in pull request #3303: [ZEPPELIN-3989] Configure IPython Interpreter in Docker image URL: https://github.com/apache/zeppelin/pull/3303#discussion_r253588410 ## File path: scripts/docker/zeppelin/bin/Dockerfile ## @@ -63,12 +63,11 @@ RUN echo "$LOG_TAG Install python related packages" && \ apt-get install -y gfortran && \ # numerical/algebra packages apt-get install -y libblas-dev libatlas-dev liblapack-dev && \ -# font, image for matplotlib +# font, image apt-get install -y libpng-dev libfreetype6-dev libxft-dev && \ # for tkinter apt-get install -y python-tk libxml2-dev libxslt-dev zlib1g-dev && \ -pip install numpy && \ -pip install matplotlib +pip install numpy==1.12.1 pandas==0.21.1 matplotlib==2.1.1 pandasql==0.7.3 ipython==5.4.1 jupyter_client==5.1.0 ipykernel==4.7.0 bokeh==0.12.10 ggplot==0.11.5 grpcio==1.8.2 bkzep==0.4.0 Review comment: This library list came from https://github.com/apache/zeppelin/blob/master/testing/install_external_dependencies.sh#L48-L49 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] Leemoonsoo closed pull request #3299: [ZEPPELIN-3920] [FOLLOWUP] get correct hyperlink address when num job url is one
Leemoonsoo closed pull request #3299: [ZEPPELIN-3920] [FOLLOWUP] get correct hyperlink address when num job url is one URL: https://github.com/apache/zeppelin/pull/3299 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] Leemoonsoo opened a new pull request #3299: [ZEPPELIN-3920] [FOLLOWUP] get correct hyperlink address when num job url is one
Leemoonsoo opened a new pull request #3299: [ZEPPELIN-3920] [FOLLOWUP] get correct hyperlink address when num job url is one URL: https://github.com/apache/zeppelin/pull/3299 ### What is this PR for? After change https://github.com/apache/zeppelin/pull/3273, invalid value is assigned to the Job link when only one JobUrl exists. ### What type of PR is it? Bug Fix ### What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-3920 ### How should this be tested? Test manually ### Questions: * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
Re: ipython
Hi Can ipython server run inside its own docker container? How does ipython server run in Zeppelin container? Does it run inside the Zeppelin container? Thanks
[GitHub] asfgit closed pull request #3299: [ZEPPELIN-3920] [FOLLOWUP] get correct hyperlink address when num job url is one
asfgit closed pull request #3299: [ZEPPELIN-3920] [FOLLOWUP] get correct hyperlink address when num job url is one URL: https://github.com/apache/zeppelin/pull/3299 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] Leemoonsoo closed pull request #3303: [ZEPPELIN-3989] Configure IPython Interpreter in Docker image
Leemoonsoo closed pull request #3303: [ZEPPELIN-3989] Configure IPython Interpreter in Docker image URL: https://github.com/apache/zeppelin/pull/3303 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] Leemoonsoo opened a new pull request #3303: [ZEPPELIN-3989] Configure IPython Interpreter in Docker image
Leemoonsoo opened a new pull request #3303: [ZEPPELIN-3989] Configure IPython Interpreter in Docker image URL: https://github.com/apache/zeppelin/pull/3303 ### What is this PR for? Configure IPython interpreter in Docker image by installing necessary dependencies. ### What type of PR is it? Improvement ### What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-3989 ### How should this be tested? Build docker image and see if %python interpreter works with Ipython kernel. ### Questions: * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
