[GitHub] [zeppelin] prabhjyotsingh commented on issue #3462: ZEPPELIN-4138 Zeppelin Notebooks in vue.js framework
prabhjyotsingh commented on issue #3462: ZEPPELIN-4138 Zeppelin Notebooks in vue.js framework URL: https://github.com/apache/zeppelin/pull/3462#issuecomment-536152420 @malayhm is this WIP? for most of the operations I have to refresh my browser. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [zeppelin] AlexImb opened a new pull request #3467: [DOCS] Fix documentation typo
AlexImb opened a new pull request #3467: [DOCS] Fix documentation typo URL: https://github.com/apache/zeppelin/pull/3467 ### What is this PR for? Change mistyped name from *Heliun* to *Helium* ### What type of PR is it? Documentation ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Created] (ZEPPELIN-4358) Seaborn renders plots slowly in apache zeppelin notebooks
Nawid Sayed created ZEPPELIN-4358: - Summary: Seaborn renders plots slowly in apache zeppelin notebooks Key: ZEPPELIN-4358 URL: https://issues.apache.org/jira/browse/ZEPPELIN-4358 Project: Zeppelin Issue Type: Bug Components: pySpark Affects Versions: 0.8.1 Reporter: Nawid Sayed I am currently trying to generate visualizations in zeppelin (0.8.1) notebooks using the pyspark interpreter with python 3.7.3. Generating the following simple plot with seaborn (0.9.0) takes around 5 minutes (with very high CPU usage throughout the duration): ```%pyspark %pyspark import seaborn as sns import numpy as np import pandas as pd data = pd.DataFrame(np.random.rand(100,3)) sns.pairplot(data) ``` This behavior is rather inconsistent as the following (much more data intensive) plot is rendered instantly ```%pyspark %pyspark import seaborn as sns import numpy as np import pandas as pd df = pd.DataFrame(data = np.random.rand(1,2)) sns.lineplot(x = 0, y = 1, data = df) ``` I noticed that using matplotlib (3.1.0) is generally much faster for and almost as snappy as I am used to from jupyter notebook environments. I have already read about issue [ZEPPELIN-1894](https://jira.apache.org/jira/browse/ZEPPELIN-1894) but I can render the mentioned scatterplot instantly as well. I already stated my question on StackOverflow but I think here is a better place: -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [zeppelin] malayhm closed pull request #3462: ZEPPELIN-4138 Zeppelin Notebooks in vue.js framework
malayhm closed pull request #3462: ZEPPELIN-4138 Zeppelin Notebooks in vue.js framework URL: https://github.com/apache/zeppelin/pull/3462 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [zeppelin] malayhm commented on issue #3462: ZEPPELIN-4138 Zeppelin Notebooks in vue.js framework
malayhm commented on issue #3462: ZEPPELIN-4138 Zeppelin Notebooks in vue.js
framework
URL: https://github.com/apache/zeppelin/pull/3462#issuecomment-536090749
> @malayhm I fail to start the frontend, here's error:
>
> ```
> error: 'n' is not defined (no-undef) at
src/components/Notebook/NotebookList.vue:92:16:
> 90 | tree.push({
> 91 | title: this.getFileName(n.path),
> > 92 | key: n.id,
> |^
> 93 | isLeaf: true
> 94 | })
> 95 | }
>
>
> 5 errors found.
>
> Module Warning (from ./node_modules/eslint-loader/index.js):
> error: Expected an assignment or function call and instead saw an
expression (no-unused-expressions) at src/components/Notebook/Import.vue:181:7:
> 179 | this.defaultInterpreter = null
> 180 |
> > 181 | this.importType = 'file',
> | ^
> 182 | this.sourceNotebookFile = null
> 183 | this.sourceNotebookJSON = null
> 184 | this.fileUploaded = false
>
>
> error: Unexpected use of comma operator (no-sequences) at
src/components/Notebook/Import.vue:181:31:
> 179 | this.defaultInterpreter = null
> 180 |
> > 181 | this.importType = 'file',
> | ^
> 182 | this.sourceNotebookFile = null
> 183 | this.sourceNotebookJSON = null
> 184 | this.fileUploaded = false
>
>
> 2 errors found.
> ```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [zeppelin] malayhm opened a new pull request #3462: ZEPPELIN-4138 Zeppelin Notebooks in vue.js framework
malayhm opened a new pull request #3462: ZEPPELIN-4138 Zeppelin Notebooks in vue.js framework URL: https://github.com/apache/zeppelin/pull/3462 ### What is this PR for? This is the first PR which lays down the framework for Zeppelin Web Implementation using vue.js framework with basic functionality in place. ### What type of PR is it? Improvement ### Task Added * Splitter Layout: Header, Sidebar, Top Menu, Content, Status Bar, Tabbed Layout * I18n, Event Bus / Command Manager for cross components communication, Keyboard Shortcuts * Ant Design for UI Components - https://vue.ant.design/ * Basic Notebook List (without foldering and Recycle Bin) * Notebook Tabbed Layout (per notebook Web Socket connection) * New Notebook, Clone Notebook, Import Notebook (file upload and drag and drop), Move to Recycle Bin, Clear all outputs, Export JSON * Paragraph Listing, Remove paragraph Design Document: https://docs.google.com/document/d/1FCAVgODwYtpXUxtTdB3JVGrVNEqEzpUA6Dcyi6xvpB4/edit Full Task List: https://docs.google.com/spreadsheets/d/1cPI4t0Wqm0JVxjkLPNpah1I9vW-XmEcd9eDYISTV0iw/edit#gid=0 ### What is the Jira issue? * https://issues.apache.org/jira/browse/ZEPPELIN/ZEPPELIN-4138 ### How should this be tested? * Start the zeppelin server * Go to the zeppelin-web-vue folder * Run npm install (first time) * Run npm run serve to run Zeppelin web using vue.js on localhost:8081 ### Screenshots (if appropriate)     ### Questions: * Does the licenses files need update? - No * Is there breaking changes for older versions? - No * Does this needs documentation? - Not yet This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [zeppelin] primerano opened a new pull request #3466: Zeppelin-4341
primerano opened a new pull request #3466: Zeppelin-4341 URL: https://github.com/apache/zeppelin/pull/3466 ### What is this PR for? Allow getting of roles to work when more than 1 realm. ### What type of PR is it? Bug Fix ### Todos * [ ] - add test? This is hard due to multiple realms ### What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-4341 ### How should this be tested? Hard to test. I will look at your CI next week. I tested in my local environment * todo. check out https://zeppelin.apache.org/contribution/contributions.html#continuous-integration * i did not see any tests related to this code. ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [zeppelin] Leemoonsoo commented on issue #3465: [ZEPPELIN-4355] Fix broken tests in master branch
Leemoonsoo commented on issue #3465: [ZEPPELIN-4355] Fix broken tests in master branch URL: https://github.com/apache/zeppelin/pull/3465#issuecomment-536020510 @zjffdu Do you have any good idea about https://issues.apache.org/jira/browse/ZEPPELIN-4357 ? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [zeppelin] Leemoonsoo opened a new pull request #3465: [ZEPPELIN-4355] Fix broken tests in master branch
Leemoonsoo opened a new pull request #3465: [ZEPPELIN-4355] Fix broken tests in master branch URL: https://github.com/apache/zeppelin/pull/3465 ### What is this PR for? Recently, master branch tests are broken with multiple different reasons. This PR address some of them including - https://issues.apache.org/jira/browse/ZEPPELIN-4355 - `r-base` package installation fail on travis (maybe travis or r package repo changed somehow) - PersonalizeActionIT fails (not sure what made this test fail. but anyway made test verify correct behavior) After this PR, all tests except for LivyInterpreterIT (last 2 test profile in travis) will pass. https://issues.apache.org/jira/browse/ZEPPELIN-4357 ### What type of PR is it? Bug Fix ### What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-4355 ### How should this be tested? * All CI test should pass except for last 2 ### Questions: * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Created] (ZEPPELIN-4357) LivyInterpreterIT fail
Lee Moon Soo created ZEPPELIN-4357:
--
Summary: LivyInterpreterIT fail
Key: ZEPPELIN-4357
URL: https://issues.apache.org/jira/browse/ZEPPELIN-4357
Project: Zeppelin
Issue Type: Bug
Reporter: Lee Moon Soo
{code:java}
Tests run: 6, Failures: 2, Errors: 0, Skipped: 0, Time elapsed: 271.271 sec <<<
FAILURE! - in org.apache.zeppelin.livy.LivyInterpreterIT
testSharedInterpreter(org.apache.zeppelin.livy.LivyInterpreterIT) Time
elapsed: 38.941 sec <<< FAILURE!
java.lang.AssertionError: expected: but was:
at org.junit.Assert.fail(Assert.java:88)
at org.junit.Assert.failNotEquals(Assert.java:834)
at org.junit.Assert.assertEquals(Assert.java:118)
at org.junit.Assert.assertEquals(Assert.java:144)
at
org.apache.zeppelin.livy.LivyInterpreterIT.testSharedInterpreter(LivyInterpreterIT.java:768)
testSparkRInterpreter(org.apache.zeppelin.livy.LivyInterpreterIT) Time
elapsed: 23.92 sec <<< FAILURE!
java.lang.AssertionError: expected: but was:
at org.junit.Assert.fail(Assert.java:88)
at org.junit.Assert.failNotEquals(Assert.java:834)
at org.junit.Assert.assertEquals(Assert.java:118)
at org.junit.Assert.assertEquals(Assert.java:144)
at
org.apache.zeppelin.livy.LivyInterpreterIT.testSparkRInterpreter(LivyInterpreterIT.java:602)
INFO [2019-09-27 16:48:56,063] ({Thread-0} Logging.scala[info]:39) - Shutting
down cluster pool.
Results :
Failed tests:
LivyInterpreterIT.testSharedInterpreter:768 expected: but was:
LivyInterpreterIT.testSparkRInterpreter:602 expected: but was:
Tests run: 6, Failures: 2, Errors: 0, Skipped: 0
{code}
[https://api.travis-ci.org/v3/job/590204255/log.txt]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [zeppelin] asfgit closed pull request #3461: [ZEPPELIN-4280] [Followup] Add comments
asfgit closed pull request #3461: [ZEPPELIN-4280] [Followup] Add comments URL: https://github.com/apache/zeppelin/pull/3461 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [zeppelin] Leemoonsoo commented on issue #3461: [ZEPPELIN-4280] [Followup] Add comments
Leemoonsoo commented on issue #3461: [ZEPPELIN-4280] [Followup] Add comments URL: https://github.com/apache/zeppelin/pull/3461#issuecomment-536006403 Thanks @prabhjyotsingh. Merge to master and branch-0.8 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [zeppelin] malayhm commented on a change in pull request #3462: ZEPPELIN-4138 Zeppelin Notebooks in vue.js framework
malayhm commented on a change in pull request #3462: ZEPPELIN-4138 Zeppelin
Notebooks in vue.js framework
URL: https://github.com/apache/zeppelin/pull/3462#discussion_r329121359
##
File path: zeppelin-web-vue/src/components/Notebook/Create.vue
##
@@ -0,0 +1,136 @@
+
+
+
+
+Cancel
+
+ {{ this.actionLabel }}
+
+
+
+
+
+
+
+
+
+
+
+ {{interpreter.id}}
+
+
+
+
+
+
+
+
+
+
+
+
+
[GitHub] [zeppelin] prabhjyotsingh commented on issue #3461: [ZEPPELIN-4280] [Followup] Add comments
prabhjyotsingh commented on issue #3461: [ZEPPELIN-4280] [Followup] Add comments URL: https://github.com/apache/zeppelin/pull/3461#issuecomment-535976023 LGTM! Will merge this to both master and branch-0.8. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [zeppelin] prabhjyotsingh commented on issue #3431: [ZEPPELIN-2680] Allow opening notebook as a reader
prabhjyotsingh commented on issue #3431: [ZEPPELIN-2680] Allow opening notebook as a reader URL: https://github.com/apache/zeppelin/pull/3431#issuecomment-535974704 LGTM, will merge this to master if no more discussion. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [zeppelin] zjffdu commented on issue #3462: ZEPPELIN-4138 Zeppelin Notebooks in vue.js framework
zjffdu commented on issue #3462: ZEPPELIN-4138 Zeppelin Notebooks in vue.js framework URL: https://github.com/apache/zeppelin/pull/3462#issuecomment-535932225 > > Does it require zeppelin server run on localhost:8080? Can it work against other port? > > It should work. How can I make it work against other port ? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [zeppelin] ieglonew01f commented on issue #3462: ZEPPELIN-4138 Zeppelin Notebooks in vue.js framework
ieglonew01f commented on issue #3462: ZEPPELIN-4138 Zeppelin Notebooks in vue.js framework URL: https://github.com/apache/zeppelin/pull/3462#issuecomment-535914409 > Does it require zeppelin server run on localhost:8080? Can it work against other port? It should work. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [zeppelin] malayhm commented on issue #3462: ZEPPELIN-4138 Zeppelin Notebooks in vue.js framework
malayhm commented on issue #3462: ZEPPELIN-4138 Zeppelin Notebooks in vue.js framework URL: https://github.com/apache/zeppelin/pull/3462#issuecomment-535913181 https://github.com/apache/zeppelin/pull/3462#issuecomment-535859958 This is fixed, @zjffdu Could you try with the latest changes? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [zeppelin] malayhm commented on a change in pull request #3462: ZEPPELIN-4138 Zeppelin Notebooks in vue.js framework
malayhm commented on a change in pull request #3462: ZEPPELIN-4138 Zeppelin Notebooks in vue.js framework URL: https://github.com/apache/zeppelin/pull/3462#discussion_r329041172 ## File path: zeppelin-web-vue/public/index.html ## @@ -0,0 +1,17 @@ + + + + + + + +Zeppelin Studio Review comment: Done. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [zeppelin] zjffdu commented on issue #3462: ZEPPELIN-4138 Zeppelin Notebooks in vue.js framework
zjffdu commented on issue #3462: ZEPPELIN-4138 Zeppelin Notebooks in vue.js
framework
URL: https://github.com/apache/zeppelin/pull/3462#issuecomment-535859958
@malayhm I fail to start the frontend, here's error:
```
error: 'n' is not defined (no-undef) at
src/components/Notebook/NotebookList.vue:92:16:
90 | tree.push({
91 | title: this.getFileName(n.path),
> 92 | key: n.id,
|^
93 | isLeaf: true
94 | })
95 | }
5 errors found.
Module Warning (from ./node_modules/eslint-loader/index.js):
error: Expected an assignment or function call and instead saw an expression
(no-unused-expressions) at src/components/Notebook/Import.vue:181:7:
179 | this.defaultInterpreter = null
180 |
> 181 | this.importType = 'file',
| ^
182 | this.sourceNotebookFile = null
183 | this.sourceNotebookJSON = null
184 | this.fileUploaded = false
error: Unexpected use of comma operator (no-sequences) at
src/components/Notebook/Import.vue:181:31:
179 | this.defaultInterpreter = null
180 |
> 181 | this.importType = 'file',
| ^
182 | this.sourceNotebookFile = null
183 | this.sourceNotebookJSON = null
184 | this.fileUploaded = false
2 errors found.
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [zeppelin] zjffdu commented on a change in pull request #3462: ZEPPELIN-4138 Zeppelin Notebooks in vue.js framework
zjffdu commented on a change in pull request #3462: ZEPPELIN-4138 Zeppelin
Notebooks in vue.js framework
URL: https://github.com/apache/zeppelin/pull/3462#discussion_r328980138
##
File path: zeppelin-web-vue/src/services/api.js
##
@@ -0,0 +1,33 @@
+export default {
+ getWebsocketUrl () {
+let wsProtocol = location.protocol === 'https:' ? 'wss:' : 'ws:'
+return wsProtocol + '//' + location.hostname + ':' + this.getWSPort() +
'/ws'
+ },
+
+ getWSPort () {
+if (location.hostname.includes('qubole')) {
+ if (location.protocol === 'https:') {
+return 443
+ }
+}
+return this.getPort()
+ },
+
+ getPort () {
+let port = Number(location.port - 1)
+if (!port) {
+ port = 80
+ if (location.protocol === 'https:') {
+port = 443
+ }
+}
+if (port === || port === 9000) {
Review comment:
Where does `` and `9000` come from ?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [zeppelin] zjffdu commented on issue #3462: ZEPPELIN-4138 Zeppelin Notebooks in vue.js framework
zjffdu commented on issue #3462: ZEPPELIN-4138 Zeppelin Notebooks in vue.js framework URL: https://github.com/apache/zeppelin/pull/3462#issuecomment-535858978 > @zjffdu > > > package-lock.json is automatically generated for any operations where npm modifies either the node_modules tree, or package.json. It describes the exact tree that was generated, such that subsequent installs are able to generate identical trees, regardless of intermediate dependency updates. > > Source: > https://github.com/npm/npm/blob/v5.0.0/doc/files/package-lock.json.md > https://stackoverflow.com/questions/44206782/do-i-commit-the-package-lock-json-file-created-by-npm-5 Thanks for the info This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [zeppelin] malayhm commented on issue #3462: ZEPPELIN-4138 Zeppelin Notebooks in vue.js framework
malayhm commented on issue #3462: ZEPPELIN-4138 Zeppelin Notebooks in vue.js framework URL: https://github.com/apache/zeppelin/pull/3462#issuecomment-535857166 @zjffdu > package-lock.json is automatically generated for any operations where npm modifies either the node_modules tree, or package.json. It describes the exact tree that was generated, such that subsequent installs are able to generate identical trees, regardless of intermediate dependency updates. Source: https://github.com/npm/npm/blob/v5.0.0/doc/files/package-lock.json.md https://stackoverflow.com/questions/44206782/do-i-commit-the-package-lock-json-file-created-by-npm-5 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [zeppelin] malayhm commented on a change in pull request #3462: ZEPPELIN-4138 Zeppelin Notebooks in vue.js framework
malayhm commented on a change in pull request #3462: ZEPPELIN-4138 Zeppelin Notebooks in vue.js framework URL: https://github.com/apache/zeppelin/pull/3462#discussion_r328976142 ## File path: zeppelin-web-vue/public/index.html ## @@ -0,0 +1,17 @@ + + + + + + + +Zeppelin Studio Review comment: Will fix it. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [zeppelin] malayhm commented on a change in pull request #3462: ZEPPELIN-4138 Zeppelin Notebooks in vue.js framework
malayhm commented on a change in pull request #3462: ZEPPELIN-4138 Zeppelin
Notebooks in vue.js framework
URL: https://github.com/apache/zeppelin/pull/3462#discussion_r328975432
##
File path: zeppelin-web-vue/src/components/Notebook/Create.vue
##
@@ -0,0 +1,136 @@
+
+
+
+
+Cancel
+
+ {{ this.actionLabel }}
+
+
+
+
+
+
+
+
+
+
+
+ {{interpreter.id}}
+
+
+
+
+
+
+
+
+
+
+
+
+
[GitHub] [zeppelin] zjffdu commented on a change in pull request #3462: ZEPPELIN-4138 Zeppelin Notebooks in vue.js framework
zjffdu commented on a change in pull request #3462: ZEPPELIN-4138 Zeppelin
Notebooks in vue.js framework
URL: https://github.com/apache/zeppelin/pull/3462#discussion_r328974785
##
File path: zeppelin-web-vue/src/components/Notebook/Create.vue
##
@@ -0,0 +1,136 @@
+
+
+
+
+Cancel
+
+ {{ this.actionLabel }}
+
+
+
+
+
+
+
+
+
+
+
+ {{interpreter.id}}
+
+
+
+
+
+
+
+
+
+
+
+
+
[GitHub] [zeppelin] zjffdu commented on a change in pull request #3462: ZEPPELIN-4138 Zeppelin Notebooks in vue.js framework
zjffdu commented on a change in pull request #3462: ZEPPELIN-4138 Zeppelin
Notebooks in vue.js framework
URL: https://github.com/apache/zeppelin/pull/3462#discussion_r328974785
##
File path: zeppelin-web-vue/src/components/Notebook/Create.vue
##
@@ -0,0 +1,136 @@
+
+
+
+
+Cancel
+
+ {{ this.actionLabel }}
+
+
+
+
+
+
+
+
+
+
+
+ {{interpreter.id}}
+
+
+
+
+
+
+
+
+
+
+
+
+
[GitHub] [zeppelin] zjffdu commented on a change in pull request #3462: ZEPPELIN-4138 Zeppelin Notebooks in vue.js framework
zjffdu commented on a change in pull request #3462: ZEPPELIN-4138 Zeppelin Notebooks in vue.js framework URL: https://github.com/apache/zeppelin/pull/3462#discussion_r328973250 ## File path: zeppelin-web-vue/public/index.html ## @@ -0,0 +1,17 @@ + + + + + + + +Zeppelin Studio Review comment: Please rename it still to `Zeppelin Notebook`, changing product name is beyond the scope of this PR. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [zeppelin] zjffdu commented on issue #3462: ZEPPELIN-4138 Zeppelin Notebooks in vue.js framework
zjffdu commented on issue #3462: ZEPPELIN-4138 Zeppelin Notebooks in vue.js framework URL: https://github.com/apache/zeppelin/pull/3462#issuecomment-535852859 @malayhm From frontend engineer's perspective, is `package-lock.json` necessary to be committed ? It is pretty large, and looks like it would change very frequently. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [zeppelin] zjffdu commented on issue #3462: ZEPPELIN-4138 Zeppelin Notebooks in vue.js framework
zjffdu commented on issue #3462: ZEPPELIN-4138 Zeppelin Notebooks in vue.js framework URL: https://github.com/apache/zeppelin/pull/3462#issuecomment-535852194 Does it require zeppelin server run on localhost:8080 ? Can it work against other port ? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Created] (ZEPPELIN-4356) Zeppelin should stop/die/etc when can't create/access notebook repo
Bhavik Patel created ZEPPELIN-4356: -- Summary: Zeppelin should stop/die/etc when can't create/access notebook repo Key: ZEPPELIN-4356 URL: https://issues.apache.org/jira/browse/ZEPPELIN-4356 Project: Zeppelin Issue Type: Improvement Reporter: Bhavik Patel Fix For: 0.9.0 Currently when Zeppelin can't create/access the notebook repo, Zeppelin stays up but returns MultiException. Instead it would be better to stop/die/etc. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (ZEPPELIN-4355) CassandraInterpreterTest fails
Jeff Zhang created ZEPPELIN-4355:
Summary: CassandraInterpreterTest fails
Key: ZEPPELIN-4355
URL: https://issues.apache.org/jira/browse/ZEPPELIN-4355
Project: Zeppelin
Issue Type: Improvement
Affects Versions: 0.9.0
Reporter: Jeff Zhang
{code:java}
Failed tests: CassandraInterpreterTest.should_describe_table:693
expected:<...ndex_interval = 2048[];<...> but
was:<...ndex_interval = 2048[AND memtable_flush_period_in_ms =
0];<...>
CassandraInterpreterTest.should_describe_keyspace:609
expected:<...ndex_interval = 2048[;complex_table's
indicesNameTargetclustering2idxclustering2idx1indexed1idx2indexed2keys_map_idxkeys(key_indexed_map)pk2idxpk2As CQL
statementCREATE INDEX clustering2idx ON
live_data.complex_table (clustering2);CREATE INDEX idx1 ON
live_data.complex_table (indexed1);CREATE INDEX idx2 ON live_data.complex_table
(indexed2);CREATE INDEX keys_map_idx ON live_data.complex_table
(keys(key_indexed_map));CREATE INDEX pk2idx ON live_data.complex_table
(pk2);sensor_dataColumn TypeColumn NameData
Typesensor_iduuidmonthintcharacteristicsmaptext,
textmodel_numbertextprovidertextdatetimestampvaluedoubleAs CQL
statementCREATE TABLE live_data.sensor_data
(sensor_id uuid,month int,date timestamp,characteristics maptext, text
static,model_number text static,provider text static,value double,PRIMARY KEY
((sensor_id, month), date)) WITH CLUSTERING ORDER BY (date DESC)AND
read_repair_chance = 0.0AND dclocal_read_repair_chance = 0.1AND
gc_grace_seconds = 864000AND bloom_filter_fp_chance = 0.01AND caching = {
'keys' : 'ALL', 'rows_per_partition' : 'NONE' }AND comment = ''AND compaction =
{ 'class' : 'org.apache.cassandra.db.compaction.SizeTieredCompactionStrategy'
}AND compression = { 'sstable_compression' :
'org.apache.cassandra.io.compress.LZ4Compressor' }AND default_time_to_live =
0AND speculative_retry = '99.0PERCENTILE'AND min_index_interval = 128AND
max_index_interval = 2048;stationsColumn TypeColumn NameData
Typestation_iduuidsensorsfrozenmapuuid,
frozenlive_data.geolocationAs
CQL statementCREATE TABLE live_data.stations (station_id
uuid,sensors frozenmapuuid,
frozenlive_data.geolocation,PRIMARY KEY (station_id)) WITH
read_repair_chance = 0.0AND dclocal_read_repair_chance = 0.1AND
gc_grace_seconds = 864000AND bloom_filter_fp_chance = 0.01AND caching = {
'keys' : 'ALL', 'rows_per_partition' : 'NONE' }AND comment = ''AND compaction =
{ 'class' : 'org.apache.cassandra.db.compaction.SizeTieredCompactionStrategy'
}AND compression = { 'sstable_compression' :
'org.apache.cassandra.io.compress.LZ4Compressor' }AND default_time_to_live =
0AND speculative_retry = '99.0PERCENTILE'AND min_index_interval = 128AND
max_index_interval = 2048];<...> but was:<...ndex_interval =
2048[AND memtable_flush_period_in_ms = 0;complex_table's
indicesNameTargetclustering2idxclustering2idx1indexed1idx2indexed2keys_map_idxkeys(key_indexed_map)pk2idxpk2As CQL
statementCREATE INDEX clustering2idx ON
live_data.complex_table (clustering2);CREATE INDEX idx1 ON
live_data.complex_table (indexed1);CREATE INDEX idx2 ON live_data.complex_table
(indexed2);CREATE INDEX keys_map_idx ON live_data.complex_table
(keys(key_indexed_map));CREATE INDEX pk2idx ON live_data.complex_table
(pk2);sensor_dataColumn TypeColumn NameData
Typesensor_iduuidmonthintcharacteristicsmaptext,
textmodel_numbertextprovidertextdatetimestampvaluedoubleAs CQL
statementCREATE TABLE live_data.sensor_data
(sensor_id uuid,month int,date timestamp,characteristics maptext, text
static,model_number text static,provider text static,value double,PRIMARY KEY
((sensor_id, month), date)) WITH CLUSTERING ORDER BY (date DESC)AND
read_repair_chance = 0.0AND dclocal_read_repair_chance = 0.1AND
gc_grace_seconds = 864000AND bloom_filter_fp_chance = 0.01AND caching = {
'keys' : 'ALL', 'rows_per_partition' : 'NONE' }AND comment = ''AND compaction =
{ 'class' : 'org.apache.cassandra.db.compaction.SizeTieredCompactionStrategy'
}AND compression = { 'sstable_compression' :
'org.apache.cassandra.io.compress.LZ4Compressor' }AND default_time_to_live =
0AND speculative_retry = '99.0PERCENTILE'AND min_index_interval = 128AND
max_index_interval = 2048AND memtable_flush_period_in_ms =
0;stationsColumn TypeColumn NameData
Typestation_iduuidsensorsfrozenmapuuid,
frozenlive_data.geolocationAs
CQL statementCREATE TABLE live_data.stations (station_id
uuid,sensors frozenmapuuid,
frozenlive_data.geolocation,PRIMARY KEY (station_id)) WITH
read_repair_chance = 0.0AND dclocal_read_repair_chance = 0.1AND
gc_grace_seconds = 864000AND bloom_filter_fp_chance = 0.01AND caching = {
'keys' : 'ALL', 'rows_per_partition' : 'NONE' }AND comment = ''AND compaction =
{ 'class' : 'org.apache.cassandra.db.compaction.SizeTieredCompactionStrategy'
}AND compression = { 'sstable_compression' :
'org.apache.cassandra.io.compress.LZ4Compressor'
[GitHub] [zeppelin] zjffdu opened a new pull request #3464: [ZEPPELIN-4354]. Enhance z.angular for more flexiable data sharing
zjffdu opened a new pull request #3464: [ZEPPELIN-4354]. Enhance z.angular for more flexiable data sharing URL: https://github.com/apache/zeppelin/pull/3464 ### What is this PR for? This PR enhance method `z.angular` in `%spark.r` and `%spark.pyspark` so that angular variables defined in frontedn can be shared in backend `%spark`, `%spark.r`, `%spark.pyspark` ### What type of PR is it? [ Improvement | Feature ] ### Todos * [ ] - Task ### What is the Jira issue? * https://issues.apache.org/jira/browse/ZEPPELIN-4354 ### How should this be tested? * CI pass ### Screenshots (if appropriate)  ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Created] (ZEPPELIN-4354) Enhance z.angular for more flexiable data sharing
Jeff Zhang created ZEPPELIN-4354: Summary: Enhance z.angular for more flexiable data sharing Key: ZEPPELIN-4354 URL: https://issues.apache.org/jira/browse/ZEPPELIN-4354 Project: Zeppelin Issue Type: Improvement Affects Versions: 0.9.0 Reporter: Jeff Zhang -- This message was sent by Atlassian Jira (v8.3.4#803005)
