[GitHub] zeppelin issue #1863: [ZEPPELIN-1920] Fail to load app.js when ZEPPELIN_SERV...
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1863 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1865: [ZEPPELIN-1723] Math formula support library path erro...
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1865 Tested and LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1866: [MINOR] Remove redundant log4j license
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1866 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1857: [ZEPPELIN-1874] fix: sparkR doens't render output prop...
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1857 Merge to master if no more comments --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1854: [ZEPPELIN-1912] fix: Improve perosnalized mode tooltip...
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1854 LGTM and merge to master! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1857: [ZEPPELIN-1874] fix: sparkR doens't render output prop...
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1857 Tested and LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1844: [ZEPPELIN-1825] Use versioned notebook storage by defa...
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1844 Thanks @khalidhuseynov for the improvement. LGTM and merge if no more comments! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1844: [ZEPPELIN-1825] Use versioned notebook storage by defa...
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1844 `VFSNotebookRepo` can be configured to use [other filesystems](https://commons.apache.org/proper/commons-vfs/filesystems.html) instead of local filesystem. Those user might be confused when (default) notebook repo is changed to `GitNotebookRepo`. How about add an item in [upgrade.md](https://github.com/apache/zeppelin/blob/master/docs/install/upgrade.md#upgrading-from-zeppelin-06-to-07) for this change? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1841: [HOTFIX] fix: DON'T run npm clean in maven clean phase...
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1841 LGTM. It fixes CI build failure. Merge to master as a hotfix --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #1842: [WIP] [ZEPPELIN-1619] Load js package as a plug...
GitHub user Leemoonsoo opened a pull request: https://github.com/apache/zeppelin/pull/1842 [WIP] [ZEPPELIN-1619] Load js package as a plugin visualization ### What is this PR for? Current helium plugin application api (experimental) requires create library in java class, and need to create both backend / frontend code in the package. Which is good if your plugin requires both frontend and backend code running. However, when user just want to make new visualization which completely runs on front-end side in javascript, creating helium application in java project and taking care of backend code can be bit of overhead and obstacle for javascript developers. This PR adds capability to load pure javascript package as a visualization. ### how it works 1. create (copy, download) 'helium package json' (e.g. `zeppelin-examples/zeppelin-example-horizontalbar/zeppelin-example-horizontalbar.json`) file into `ZEPPELIN_HOME/helium` directory. The json file point visualization js package in npm repository or local file system in `artifact` field. `type` field in the json file need to be `VISUALIZATION` 2. Go to helium GUI menu. (e.g. http://localhost:8080/#/helium). The menu will list all available packages. ![image](https://cloud.githubusercontent.com/assets/1540981/21654974/bda34abe-d26c-11e6-8d16-db482faef9a2.png) 3. click 'enable' in any package want to use. Once a visualization package is enabled, `HeliumVisualizationFactory` will collect all enabled visualizations and create js bundle on the fly. 4. js bundle will be loaded on notebook and additional visualization becomes available ![image](https://cloud.githubusercontent.com/assets/1540981/21655057/27d61740-d26d-11e6-88f2-02c653e102c6.png) ### Programming API to create new plugin visualization. Simply extends [visualization.js](https://github.com/apache/zeppelin/blob/master/zeppelin-web/src/app/visualization/visualization.js) and overrides some methods, such as ``` /** * get transformation */ getTransformation() { // override this }; /** * Method will be invoked when data or configuration changed */ render(tableData) { // override this }; /** * Refresh visualization. */ refresh() { // override this }; /** * method will be invoked when visualization need to be destroyed. * Don't need to destroy this.targetEl. */ destroy() { // override this }; /** * return { * template : angular template string or url (url should end with .html), * scope : an object to bind to template scope * } */ getSetting() { // override this }; ``` This is exactly the same api that built-in visualization uses. an example implementation included `zeppelin-examples/zeppelin-example-horizontalbar/horizontalbar.js`. Actually [all built-in visualizations](https://github.com/apache/zeppelin/tree/master/zeppelin-web/src/app/visualization/builtins) are example ### Packaging and publishing visualization Each visualization will need `package.json` file (e.g. `zeppelin-examples/zeppelin-example-horizontalbar/package.json`) to be packaged. Package can be published in npm repository or package can be deployed to the local filesystem. `zeppelin-examples/zeppelin-example-horizontalbar/` is an example package that is deployed in the local filesystem ### Future work Development mode is not implemented here. Currently, developer need to create a locally deployed package. And click 'disable' -> 'enable' package in helium gui menu everytime developer made code change, so Zeppelin can bundle and reload updated code and display. There must be faster way to apply code change in plugin visualization development mode. This can be the future work. Any feedback would be appreciated! ### What type of PR is it? Feature ### Todos * [x] - Load plugin visualization js package on runtime * [ ] - Make the feature works in zeppelin Binary package * [ ] - Show loading indicator while 'enable' / 'disable' package * [ ] - Add document * [ ] - Add license of new dependency ### What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-1619 ### How should this be tested? Build Zeppelin with `-Pexamples` flag. That'll install example visualization package `horizontalbar`. You'll able to select `horizontalbar` along with other built-in visualizations ### Questions: * Does the licenses files need update? yes * Is there breaking cha
[GitHub] zeppelin issue #1814: [ZEPPELIN-1869] changed the API response to generate t...
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1814 @cloverhearts I think you need update related unittests, too. ``` Results : Failed tests: InterpreterRestApiTest.testAddDeleteRepository:352 Test create method: Expected: HTTP response <201> from /api/interpreter/repository/ but: got <200> OK InterpreterRestApiTest.testCreatedInterpreterDependencies:171 test create method: Expected: HTTP response <201> from /api/interpreter/setting but: got <200> OK InterpreterRestApiTest.testSettingsCRUD:124 test create method: Expected: HTTP response <201> from /api/interpreter/setting/ but: got <200> OK ZeppelinRestApiTest.testCloneNote:329 test note clone method: Expected: HTTP response <201> from /api/notebook/2C7FSPHN2 but: got <200> OK ZeppelinRestApiTest.testImportNotebook:265 Expected: HTTP response <201> from /api/notebook/import/ but: got <200> OK ZeppelinRestApiTest.testInsertParagraph:593 Test insert method: Expected: HTTP response <201> from /api/notebook/2C6FACAQZ/paragraph but: got <200> OK ZeppelinRestApiTest.testNoteCreateNoName:127->testNoteCreate:175 test note create method: Expected: HTTP response <201> from /api/notebook/ but: got <200> OK ZeppelinRestApiTest.testNoteCreateWithName:122->testNoteCreate:175 test note create method: Expected: HTTP response <201> from /api/notebook/ but: got <200> OK ZeppelinRestApiTest.testNoteCreateWithParagraphs:140 test note create method: Expected: HTTP response <201> from /api/notebook/ but: got <200> OK NotebookRestApiTest.testCloneNote:129 Expected: HTTP response <201> from /api/notebook/2C6JVYEJD but: got <200> OK NotebookSecurityRestApiTest.testThatOtherUserCannotAccessNoteIfPermissionSet:81->createNoteForUser:155 test note create method: Expected: HTTP response <201> from /api/notebook/ but: got <200> OK NotebookSecurityRestApiTest.testThatUserCanSearchNote:115->createNoteForUser:155 test note create method: Expected: HTTP response <201> from /api/notebook/ but: got <200> OK NotebookSecurityRestApiTest.testThatWriterCannotRemoveNote:98->createNoteForUser:155 test note create method: Expected: HTTP response <201> from /api/notebook/ but: got <200> OK NotebookSecurityRestApiTest.testThatOtherUserCanAccessNoteIfPermissionNotSet:72->createNoteForUser:155 test note create method: Expected: HTTP response <201> from /api/notebook/ but: got <200> OK NotebookSecurityRestApiTest.testThatUserCanCreateAndRemoveNote:63->createNoteForUser:155 test note create method: Expected: HTTP response <201> from /api/notebook/ but: got <200> OK Tests run: 82, Failures: 15, Errors: 0, Skipped: 1 ``` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1824: [ZEPPELIN-1850] Remove grunt-contrib-clean (grunt)
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1824 Since this PR merge, [first CI test profile fails](https://travis-ci.org/apache/zeppelin/jobs/188757727) with ``` [ERROR] Failed to execute goal com.github.eirslett:frontend-maven-plugin:1.3:npm (npm clean) on project zeppelin-web: Failed to run task: 'npm run clean' failed. java.io.IOException: Cannot run program "/home/travis/build/apache/zeppelin/zeppelin-web/node/node" (in directory "/home/travis/build/apache/zeppelin/zeppelin-web"): error=2, No such file or directory -> [Help 1] ``` @1ambda Could you take a look? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1788: ZEPPELIN-1826. Flaky Test: ZeppelinSparkClusterTest.zR...
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1788 LGTM and merge if no further discussions. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1835: [MINOR][DOCS] Add troubleshooting section to spark_clu...
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1835 LGTM and merge if no further discussions! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1838: [ZEPPELIN-1832] Fixed a bug in zombie process when Zep...
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1838 multiple ci test profile fails with the same error. ``` 09:51:15,163 ERROR org.apache.zeppelin.interpreter.remote.RemoteInterpreterEventPoller:245 - Can't handle event RemoteInterpreterEvent(type:OUTPUT_UPDATE_ALL, data:{"noteId":"2C75F1GM3","paragraphId":"20170104-095114_1076613332","messages":[]}) java.lang.NullPointerException at org.apache.zeppelin.interpreter.remote.RemoteInterpreterEventPoller.run(RemoteInterpreterEventPoller.java:186) 09:51:15,226 INFO org.apache.zeppelin.interpreter.InterpreterGroup:145 - Close interpreter group 2C8ACKHEJ:shared_process 09:51:15,226 INFO org.apache.zeppelin.interpreter.remote.RemoteInterpreterProcess:121 - shutdown interpreter process 09:51:16,226 ERROR org.apache.zeppelin.interpreter.remote.AppendOutputRunner:68 - Wait for OutputBuffer queue interrupted: null 09:51:17,657 INFO org.apache.zeppelin.interpreter.remote.RemoteInterpreterProcess:131 - Exception in RemoteInterpreterProcess while synchronized dereference, can safely ignore exception while client.shutdown() may terminates remote process 09:51:17,660 INFO org.apache.zeppelin.interpreter.remote.RemoteInterpreterManagedProcess:164 - Interpreter process exited 0 No output has been received in the last 10m0s, this potentially indicates a stalled build or something wrong with the build itself. Check the details on how to adjust your build configuration on: https://docs.travis-ci.com/user/common-build-problems/#Build-times-out-because-no-output-was-received The build has been terminated ``` @cloverhearts could you take a look? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1836: [ZEPPELIN-1887] fix: DON'T create new para when run al...
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1836 CI failure is irrelevant. Test and LGTM. While this provides fix for breaking feature, merging it as a hotfix. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1822: [ZEPPELIN-1789] Make exported data file name more expl...
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1822 @AhyoungRyu Thanks~ LGTM! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1775: [ZEPPELIN-1745] View revisions in non-editable mode
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1775 Tested and LGTM. Thanks @khalidhuseynov for the improvement. Merge to master if there're no more discussions. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1799: [ZEPPELIN-1165 : WIP] Code-based job workflow
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1799 ``` z.getZeppelinJobStatus("execute note id", "execute paragraph id").getJobStatus() ``` How about not repeating `Job`, `Status` and omit `Zeppelin` (while `z.` represents zeppelin) in method name? i.e. something like ``` z.getJob("note id", "paragraph id").getStatus() ``` or just ``` z.getJobStatus("note id", "paragraph id") ``` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1822: [ZEPPELIN-1789] Make exported data file name more expl...
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1822 Thanks @AhyoungRyu for the improvement. How about use [`dateFinished`](https://github.com/apache/zeppelin/blob/master/zeppelin-interpreter/src/main/java/org/apache/zeppelin/scheduler/Job.java#L73) instead of current time in the file name? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1812: [ZEPPELIN-1850] Use yarn instead of npm to reduce buil...
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1812 Tested and it works well. @1ambda Could you explain little bit about how `zeppelin-web/yarn.lock` can be updated in case of new dependency or dependency version change in `package.json` ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1823: [ZEPPELIN-1850] Remove strip-loader (webpack)
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1823 Tested and LGTM! Merge to master if there're no more comments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1824: [ZEPPELIN-1850] Remove grunt-contrib-clean (grunt)
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1824 LGTM and merge to master if there're no further discussions. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1818: [ZEPPELIN-1873] Use exclusively eslint for javascript ...
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1818 LGTM and merge to master if there're no further discussions. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1820: [ZEPPELIN-1841] Some of shortcut key is not working
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1820 LGTM and merge to master if there're no further comments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1829: [DOCS] Remove outdated 'Security Setup' section in SEC...
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1829 LGTM! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1833: [ZEPPELIN-1880] Fix shell interpreter output streaming...
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1833 Tested but i also see the same result @astroshim has. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1815: [ZEPPELIN-1722] Modernize visualization/transformation...
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1815 Merge to master if there're no more discussions --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1821: [ZEPPELIN-1875] permission dialog code is not stable
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1821 Tested and LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1694: [ZEPPELIN-1718] Prevent anonymous user to set note per...
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1694 After this patch, if i turn off shiro and load any notebook (without click permission button) browser console print 403 forbidden, ![image](https://cloud.githubusercontent.com/assets/1540981/21582774/b013229c-d01a-11e6-9fb8-e907bf8954a6.png) And ZeppelinServer prints stack trace ``` WARN [2017-01-01 12:03:26,784] ({qtp106298691-16} WebApplicationExceptionMapper.java[toResponse]:73) - org.apache.zeppelin.rest.exception.ForbiddenException at org.apache.zeppelin.rest.NotebookRestApi.checkIfUserIsAnon(NotebookRestApi.java:133) at org.apache.zeppelin.rest.NotebookRestApi.getNotePermissions(NotebookRestApi.java:98) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:606) at org.apache.cxf.service.invoker.AbstractInvoker.performInvocation(AbstractInvoker.java:180) at org.apache.cxf.service.invoker.AbstractInvoker.invoke(AbstractInvoker.java:96) at org.apache.cxf.jaxrs.JAXRSInvoker.invoke(JAXRSInvoker.java:205) at org.apache.cxf.jaxrs.JAXRSInvoker.invoke(JAXRSInvoker.java:102) at ``` Can we try not print error / warning on loading notebook ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1815: [ZEPPELIN-1722] Modernize visualization/transformation...
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1815 Addressed comments. I don't think style `visualization(el).transform(...).render();` is important topic here. Because this `Visualization` class is intended to be used by developer who want to create new visualization. And the developer doesn't need to call either `visualization(el).transform(...).render(); ` or `new ;` because instantiation of visualization is managed by `result.controller.js`. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1729: [ZEPPELIN-1758] support livy pyspark Interpreter's mag...
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1729 LGTM and merge to master if there're no further comments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1824: [ZEPPELIN-1850] Remove grunt-contrib-clean (grunt)
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1824 `mvn clean` in `zeppelin-web` module now removes [`bower_components`](https://github.com/apache/zeppelin/blob/master/zeppelin-web/pom.xml#L180). what do you think about making `mvn clean` run `npm run clean` as well? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1823: [ZEPPELIN-1850] Remove strip-loader (webpack)
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1823 Tested this branch, but i can see log message printed in javascript console (both in dist and dev mode). Is it expected behavior? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1716: [ ZEPPELIN-531 ] execute and stop note in job menu
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1716 Tested and LGTM. Merge to master if there're no further comments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1817: remove usage of non-standard string method
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1817 LGTM and merge to master if there're no further discussions. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1815: [ZEPPELIN-1722] Modernize visualization/transformation...
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1815 \cc @1ambda @felizbear --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1810: [MINOR] Fix navbar layout misalignment
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1810 Tested and LGTM. Thanks @cuspymd for the fix. Merge to master if there're no further comments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #1815: [ZEPPELIN-1722] Modernize visualization/transfo...
GitHub user Leemoonsoo opened a pull request: https://github.com/apache/zeppelin/pull/1815 [ZEPPELIN-1722] Modernize visualization/transformation using ES6 class and module syntax ### What is this PR for? Modernize visualization/transformation using ES6 class and module syntax. And remove global variable 'zeppelin' ### What type of PR is it? Refactoring ### Todos * [x] - Use ES6 class and module syntax ### What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-1722 ### Questions: * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no You can merge this pull request into a Git repository by running: $ git pull https://github.com/Leemoonsoo/zeppelin ZEPPELIN-1722 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/1815.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1815 commit 59d1a6ddaee1bb64bd43e98014a10cf003bafdff Author: Lee moon soo Date: 2016-12-29T06:47:57Z use class and import/export syntax for transformations(tabledata) and visualizations --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1736: [ZEPPELIN-1757] Menu of paragraph includes keyboard sh...
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1736 @soralee you're right. I checked again and it looks good to me. Thanks for the improvement and merge if there're no further comments! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1805: [ZEPPELIN-1850] Introduce Webpack (front)
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1805 Tested `console.log` in dev and dist. It now works as expected. LGTM and merge to master if there're no further discussions. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1736: [ZEPPELIN-1757] Menu of paragraph includes keyboard sh...
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1736 Tested again. And still not every items are displayed ![image](https://cloud.githubusercontent.com/assets/1540981/21507749/f6406426-cc2f-11e6-920d-79c9279061bd.png) @soralee could you check? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1805: [ZEPPELIN-1850] Introduce Webpack (front)
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1805 @1ambda Great improvement! Tested and it works well. One thing is, previously console.log() was printed only in dev mode. After this change, console.log() is printed both dev and dist. If it is not very difficult, can console.log() be muted in non-dev mode? Other than that, LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1775: [ZEPPELIN-1745] View revisions in non-editable mode
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1775 Tested this branch and found 1. select HEAD 2. and then switch to any revision. 3. change height of graph or change pivot setting 4. HEAD is changed by 3) @khalidhuseynov could you check scenario above? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1730: [ZEPPELIN-1736] Introduce trash & enable removing fold...
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1730 LGTM! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1800: [ZEPPELIN-1855] cleanup temporary test folders on tear...
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1800 LGTM and merge to master if there're no further comments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1802: [MINOR] fix: Validate before setting focus to paragrap...
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1802 LGTM and merge to master if there're no more comments --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1803: [MINOR] fix: Initialize zeppelin var in visualization/...
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1803 LGTM and merge to master if there're no further discussions --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1791: [ZEPPELIN-1847] fix: Copy only html when html file cha...
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1791 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1736: [ZEPPELIN-1757] Menu of paragraph includes keyboard sh...
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1736 This is screenshot i got from this branch. ![image](https://cloud.githubusercontent.com/assets/1540981/21468746/dcd02268-c9d9-11e6-961c-10e5f56ad115.png) I'm not sure why some items are missing and text are not aligned. @soralee Could you check? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1777: [ZEPPELIN-1831] Fix paragraph control dropdown alignme...
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1777 Tested and LGTM. Merge to master if there're no further comments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1738: Strings should not be concatenated using '+' in a loop
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1738 Thanks @bitchelov LGTM and merge to master if there're no further comments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1785: [ZEPPELIN-1833] Fix bug in ClientFactory.destroyObject...
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1785 LGTM and merge to master if there no further comments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1781: Followup for ZEPPELIN-1785
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1781 Thanks @zjffdu for this fix. LGTM and i'm merging this guy to master as a Hotfix. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1746: Collection.isEmpty() should be used to test for emptin...
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1746 LGTM and merge if there're no further discussions. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1738: Strings should not be concatenated using '+' in a loop
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1738 LGTM. @bitchelov Could you let me know your JIRA id ? so i can make you as a assignee of issue ZEPPELIN-1839 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1778: ZEPPELIN-1834 Deadlock in Zeppelin when running multip...
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1778 Thanks @benoyantony for the fix. LGTM and merge to master if there're no more discussions. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1751: ZEPPELIN-1786. Refactor LivyHelper
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1751 LGTM and merge to master if there're no further discussions --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1762: [ZEPPELIN-1810] Removed incorrect usage of getString
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1762 LGTM and merge to master if there're no further comments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1764: ZEPPELIN-1816. Implement getProgress in SparkRInterpre...
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1764 Merge to master if there're no further discussions. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1769: [ZEPPELIN-1818] Absolute local repo path in dependency...
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1769 Thanks for the fix @DrIgor! LGTM and merge to master if there're no further comments --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1770: [ZEPPELIN-1763] Prevent duplicate $scope.$on('setNoteM...
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1770 A test profile failure looks not related. (https://issues.apache.org/jira/browse/ZEPPELIN-1830) LGTM and merge to master if there're no further comments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1749: [ZEPPELIN-1298] Address invalid ticket warnings when s...
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1749 LGTM and merge to master if there're no further discussions. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1767: ZEPPELIN-1817 - Added documentation to Zeppelin's shir...
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1767 Thanks @vinayshukla for the contribution. We have a document about configuring shiro authentication on [website](https://github.com/apache/zeppelin/blob/master/docs/security/shiroauthentication.md). What do you think keeping information in the single document(website), instead of keeping two different document for the single feature? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1757: [ZEPPELIN-1074] Enhance SSL Support
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1757 Thanks @lresende for enhancement! Looks good to me. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1753: [ZEPPELIN-1594] Support personalized mode
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1753 Great!!! I checked this branch and found dynamic form is not being displayed in personalized mode. Could you check? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1770: [ZEPPELIN-1763] Prevent duplicate $scope.$on('setNoteM...
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1770 Thanks for the contribution. I'm getting build error on zeppelin-web module ``` [INFO] Running "jscs:test" (jscs) task [INFO] disallowMultipleLineBreaks: ; and it should have at most 2 line(s) between them at test/spec/controllers/notebook.js : [INFO]100 |scope.killSaveTimer(); [INFO]101 |expect(scope.saveTimer).toEqual(null); [INFO]102 | }); [INFO] -^ [INFO]103 | [INFO]104 | [INFO] >> 1 code style errors found! [INFO] Warning: Task "jscs:test" failed. Use --force to continue. [INFO] [INFO] Aborted due to warnings. ``` Could you check? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1764: ZEPPELIN-1816. Implement getProgress in SparkRInterpre...
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1764 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1772: [ZEPPELIN-1798][DOCS] Update docs with benv instead of...
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1772 Thanks @rawkintrevo for the contribution. LGTM and merge to master if there're no further comments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1771: [ZEPPELIN-1820] Fix action bar layout broken issue
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1771 Tested and works great. Thanks @marchpig for the fix. Merge to master if there're no further comments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1766: [MINOR] Set default interpreter \w first intp
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1766 LGTM! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1756: [ZEPPELIN-1804] Added Link this paragraph to keyboard ...
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1756 Merge to master if there're no more comments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1769: [ZEPPELIN-1818] Absolute local repo path in dependency...
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1769 Thanks for the contribution. Could you check CI build failure? Most test profile fails with ``` Tests in error: SparkInterpreterTest.setUp:92 û NullPointer SparkInterpreterTest.shareSingleSparkContext:244 û NullPointer SparkInterpreterTest.testBasicIntp:125 û NullPointer SparkInterpreterTest.testCreateDataFrame:172 û NullPointer SparkInterpreterTest.testDisableImplicitImport:282 û NullPointer SparkInterpreterTest.testEnableImplicitImport:264 û NullPointer SparkInterpreterTest.testEndWithComment:160 û NullPointer SparkInterpreterTest.testNextLineComments:149 û NullPointer SparkInterpreterTest.testNextLineCompanionObject:155 û NullPointer SparkInterpreterTest.testNextLineInvocation:144 û NullPointer SparkInterpreterTest.testReferencingUndefinedVal:219 û NullPointer SparkInterpreterTest.testSparkSql:198 û NullPointer SparkInterpreterTest.testZShow:185 û NullPointer SparkSqlInterpreterTest.setUp:61 û NullPointer SparkSqlInterpreterTest.setUp:61 û NullPointer SparkSqlInterpreterTest.setUp:61 û NullPointer PySparkInterpreterTest.setUp:87 û NullPointer PySparkInterpreterTest.setUp:94 û Interpreter java.lang.NullPointerException Tests run: 25, Failures: 1, Errors: 18, Skipped: 0 ``` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1756: [ZEPPELIN-1804] Added Link this paragraph to keyboard ...
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1756 Tested and LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1745: ZEPPELIN-1785. Remove ZEPPELIN_NOTEBOOK_DIR and ZEPPEL...
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1745 Thanks @zjffdu for the fix! LGTM and merge to master if there're no more discussions --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1740: ZEPPELIN-1773. Remove method destroy() in Interpreter
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1740 LGTM. CI failure looks irrelevant. Merge to master if there're no further discussions. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1754: [ZEPPELIN-1800] Update scio doc - fix type $ should be...
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1754 LGTM and merge to master if there're no more comments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1746: Collection.isEmpty() should be used to test for emptin...
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1746 @bitchelov Thanks for the contribution. Do you mind update description of the PR? PR description will be part of commit message when merged. So we expect some meaningful description for future reference. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1737: ZEPPELIN-1769. Support cancel job in SparkRInterperete...
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1737 @zjffdu Thanks! LGTM and merge to master if there're no further discussions. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1752: [HOT FIX] Fix broken display_formula.png by using rela...
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1752 LGTM. Merge it as a hotfix. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1733: [ZEPPELIN-1753] Fix blank notename issue
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1733 Tested and LGTM. Merge to master if there're no further comments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1730: [ZEPPELIN-1736] Introduce trash & enable removing fold...
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1730 @tae-jun thanks for the great contribution! LGTM and merge to master if there're no further discussions. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1675: [ZEPPELIN-1190] Visit and switch notebook revisions
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1675 LGTM and merge to master if there're no further discussions. @khalidhuseynov Great work! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1722: [ZEPPELIN-1776] substitute null check for the refactor...
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1722 LGTM and merge to master if there're no further discussions. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1744: Better output of JDBC Interpreter.
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1744 Merge to master if there're no more discussions. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1744: Better output of JDBC Interpreter.
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1744 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1612: ZEPPELIN-1607. Refactor Livy Interpreter to adapt scop...
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1612 LGTM and merge to master if there're no more comment. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1739: Branch 0.5.6 al
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1739 @andreistankevich could you close this PR if you accidentally created? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1728: [ZEPPELIN-1754] PING request stacking on websocket rec...
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1728 LGTM and merge to master if there're no more comment. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1734: [ZEPPELIN-1766] Improve Interpreter Binding UI better ...
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1734 @1ambda that looks more make sense to me. fyi, a related PR https://github.com/apache/zeppelin/pull/423 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1734: [ZEPPELIN-1766] Improve Interpreter Binding UI better ...
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1734 Thanks @1ambda for working on UX improvement. Personally, i'd prefer keep items in 1 column. Because it displays interpreter names (e.g. %spark, %pyspark, etc) at predictable location. i.e. beginning of each rows. This change doesn't newline after each item and each item has variable length and it's hard to quickly read interpreter through eyes, even though there's filter. IMO. Scrollbar will be there anyway when user have enough numbers of interpreter settings. Or when user have small screen size. For this reason, how about think other way to help user easily find 'save' button? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1727: [ZEPPELIN-1695] Use shared versions in test libraries ...
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1727 LGTM! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1692: [ZEPPELIN-1710 - WIP] Ace Editor upgrade
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1692 LGTM and merge to master if there're no more discussions. Great work @cloverhearts ! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #:
Github user Leemoonsoo commented on the pull request: https://github.com/apache/zeppelin/commit/cb0b45080251b224f44abe8719865b756290a397#commitcomment-20082316 I made mistake on backporting this commit. Our merge tool couldn't handle this case so i manually cherrypicked and resolved the conflict. And i forgot adding author info in the commit. Commit history is immutable, so i can not easily rewrite history and add author info. So, i'm leaving comment here to make sure that this commit is authored by @1ambda and backported from https://github.com/apache/zeppelin/pull/1725 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1725: [MINOR] Resolve bower dependency conflict, hang (zeppe...
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1725 @soralee reported that branch-0.6 is also failing with this problem. And i confirmed branch-0.6 build fails with the same problem and this fixes the problem. So i'm going to back port this patch to branch-0.6. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1723: [ZEPPELIN-1747] Fix Korean notename input problem
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1723 Thanks @cuspymd for providing review. LGTM and merge to master if there're no more comments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1724: [ZEPPELIN-1674] save barchart, areachart option
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1724 @prabhjyotsingh Thanks. Merge to master if there're no more comments. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1663: ZEPPELIN-1692: Ability to access Spark jobs UI from th...
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1663 Tried but still no luck .. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1724: [ZEPPELIN-1674] save barchart, areachart option
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1724 Thanks @prabhjyotsingh for the review. I think other charts doesn't have these options. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1663: ZEPPELIN-1692: Ability to access Spark jobs UI from th...
Github user Leemoonsoo commented on the issue: https://github.com/apache/zeppelin/pull/1663 Tried but no button is displayed. Maybe i'm missing something? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---