[GitHub] zeppelin issue #2373: [ZEPPELIN-2598] Securing Zeppelin with OpenID Connect

[andreaTP]

Github user andreaTP commented on the issue:

https://github.com/apache/zeppelin/pull/2373
  
@xixikaikai sure, we are using keycloak in production


---

[GitHub] zeppelin issue #2552: WIP: [ZEPPELIN-2881] Fix OIDC logout

[andreaTP]

Github user andreaTP commented on the issue:

https://github.com/apache/zeppelin/pull/2552
  
waiting is over but `pac4j` introduced a few regressions that needs to be 
fixed to have the documented process working...
I'm looking into, slowly, but if you wanna take over feel free to go ahead 
and contact me privately if you need any help. @saba0815 


---

[GitHub] zeppelin issue #2373: [ZEPPELIN-2598] Securing Zeppelin with OpenID Connect

[andreaTP]

Github user andreaTP commented on the issue:

https://github.com/apache/zeppelin/pull/2373
  
actually a more detailed description is available here: 
https://github.com/apache/zeppelin/pull/2552/files


---

[GitHub] zeppelin issue #2373: [ZEPPELIN-2598] Securing Zeppelin with OpenID Connect

[andreaTP]

Github user andreaTP commented on the issue:

https://github.com/apache/zeppelin/pull/2373
  
I think the link is broken.
here: https://github.com/apache/zeppelin/pull/2373/files


---

[GitHub] zeppelin issue #2551: [ZEPPELIN-2880] - Fix username output when OIDC is ena...

[andreaTP]

Github user andreaTP commented on the issue:

https://github.com/apache/zeppelin/pull/2551
  
ping, probably this is good to merge


---

[GitHub] zeppelin issue #2552: WIP: [ZEPPELIN-2881] Fix OIDC logout

[andreaTP]

Github user andreaTP commented on the issue:

https://github.com/apache/zeppelin/pull/2552
  
Hi thanks for getting back into this, unfortunately even if 
https://github.com/pac4j/pac4j/pull/975 got merged we do not have yet a release 
of pac4j out in public repositories that will enable this fix.
if you agree I wait to have first a release of pac4j and then I will update 
this PR accordingly.
WDYT?



---

[GitHub] zeppelin issue #2551: [ZEPPELIN-2880] - Fix username output when OIDC is ena...

[andreaTP]

Github user andreaTP commented on the issue:

https://github.com/apache/zeppelin/pull/2551
  
@felixcheung I think that docs improvements have sense in this case only on 
top of #2552 , could post-pone them?


---

[GitHub] zeppelin issue #2551: [ZEPPELIN-2880] - Fix username output when OIDC is ena...

[andreaTP]

Github user andreaTP commented on the issue:

https://github.com/apache/zeppelin/pull/2551
  
> should we consider returning/displaying more than just the principal name?
now the name field is configurable via `shiro.ini`, basically you can 
return different values in that field depending on configuration (e.g. look at 
tests https://github.com/bujiio/buji-pac4j/pull/63/files)


---

[GitHub] zeppelin issue #2552: WIP: [ZEPPELIN-2881] Fix OIDC logout

[andreaTP]

Github user andreaTP commented on the issue:

https://github.com/apache/zeppelin/pull/2552
  
sorry @felixcheung misunderstood your comment, should be fixed now!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2552: WIP: [ZEPPELIN-2881] Fix OIDC logout

[andreaTP]

Github user andreaTP commented on the issue:

https://github.com/apache/zeppelin/pull/2552
  
yes, the original code I think is the result of a few iterations.
This is the blocking pop-up:

https://github.com/apache/zeppelin/blob/6bd6c70881e8515a5b0679e5a8d6c235cfb1adf6/zeppelin-web/src/components/navbar/navbar.controller.js#L104
But you can also notice that a double `post` is performed without 
meaningful comments to justify why...

I think that someone like @1ambda or @Leemoonsoo maybe can clarify and add 
it's opinion to decide if keep the pop-up or not (personally I do not care ...)



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #2552: WIP: [ZEPPELIN-2881] Fix OIDC logout

[andreaTP]

GitHub user andreaTP opened a pull request:

https://github.com/apache/zeppelin/pull/2552

WIP: [ZEPPELIN-2881] Fix OIDC logout

### What is this PR for?
Fixing logout mechanism for OIDC.
Initial documentation for configuring OIDC in Zeppelin.

### What type of PR is it?
[Bug Fix & Improvement]

### Todos
* this PR is dependent from https://github.com/pac4j/pac4j/pull/975

### What is the Jira issue?
[ZEPPELIN-2881]

### How should this be tested?
You can test by using the guide provided in documentation. Please note that 
you will need to locally deploy pac4j until a stable release will be published 
officially.


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nokia/zeppelin logout

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/2552.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2552


commit 888bdac220a5afd7662c11c13359a95cc11a8fd5
Author: andrea 
Date:   2017-08-24T14:36:58Z

Implementing logout functionality for oidc

commit 145e5a4c70dffc815b4d9b964181255d4a17bae3
Author: andrea 
Date:   2017-08-25T13:54:17Z

added documentation




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2551: [ZEPPELIN-2880] - Fix username output when OIDC is ena...

[andreaTP]

Github user andreaTP commented on the issue:

https://github.com/apache/zeppelin/pull/2551
  
this is possible since this PR from @volumeint to bujiio:
https://github.com/bujiio/buji-pac4j/pull/63


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2373: [ZEPPELIN-2598] Securing Zeppelin with OpenID Connect

[andreaTP]

Github user andreaTP commented on the issue:

https://github.com/apache/zeppelin/pull/2373
  
Hi @SarunasG , actually I'm facing the very same situation here ...
I haven't had enough time to dig deeper, but it looks like that 'logout` 
action is not triggering the REST call to do a logout from the Oidc authority.
Eventually we will try to find a solution but please keep me copied if you 
can go further in your investigation too.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2483: [ZEPPELIN-2766] Make online resources url configurable...

[andreaTP]

Github user andreaTP commented on the issue:

https://github.com/apache/zeppelin/pull/2483
  
thanks! :+1: 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2373: [ZEPPELIN-2598] Securing Zeppelin with OpenID Connect

[andreaTP]

Github user andreaTP commented on the issue:

https://github.com/apache/zeppelin/pull/2373
  
Hi @SarunasG , yes I'm using Zeppelin with Keycloak from what I can see the 
only missing bit in your configuration is:
```
/** = oidcSecurityFilter
```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2483: [ZEPPELIN-2766] Make online resources url configurable...

[andreaTP]

Github user andreaTP commented on the issue:

https://github.com/apache/zeppelin/pull/2483
  
ping


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2483: [ZEPPELIN-2766] Make online resources url configurable...

[andreaTP]

Github user andreaTP commented on the issue:

https://github.com/apache/zeppelin/pull/2483
  
@1ambda 
travis link:
https://travis-ci.org/nokia/zeppelin/builds/256876805

I think that tests are not really "stable", I mean, they are time and 
context dependent.

i.e. if one test doesn't clean properly it's execution env next test will 
fail
selenium tests should be splitted to use less time.
It will require time, sorry I do not have enough to contribute this fix.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2483: [ZEPPELIN-2766] Make online resources url configurable...

[andreaTP]

Github user andreaTP commented on the issue:

https://github.com/apache/zeppelin/pull/2483
  
I agree that this has got a really low priority, but could I kindly ask for 
review to keep this into master since it does not break anything and just add 
some added flexibility to the build?

Thanks a lot in advance.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #2483: [ZEPPELIN-2766] Make online resources url confi...

[andreaTP]

Github user andreaTP closed the pull request at:

https://github.com/apache/zeppelin/pull/2483


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #2483: [ZEPPELIN-2766] Make online resources url confi...

[andreaTP]

GitHub user andreaTP reopened a pull request:

https://github.com/apache/zeppelin/pull/2483

[ZEPPELIN-2766] Make online resources url configurable at compile time

### What is this PR for?
At compile time Zeppelin is downloading several external resources.
I want to be able to provide alternative URLs to compile when internet is 
not available(i.e. behind corporate proxy).

### What type of PR is it?
[Improvement]

### What is the Jira issue?
[ZEPPELIN-2766]

### How should this be tested?
```
mvn -DskipTests -Dplugin.frontend.downloadRoot= 
-Dplugin.frontend.nodeDownloadRoot= 
-Dplugin.frontend.yarnDownloadRoot= 
-Dplugin.frontend.npmDownloadRoot= 
-Dpypi.repo.url= clean package
```

### Questions:
* Does the licenses files need update? NO
* Is there breaking changes for older versions? NO
* Does this needs documentation? NO


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nokia/zeppelin softCodeRepos

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/2483.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2483


commit 0aea864a99aa4adfdb210f8e67ed2da8aecb9bde
Author: andrea 
Date:   2017-07-11T13:55:01Z

Keep online resources configurable

commit 1e5fd85f4ddd3d85985d2d9f39959071cd9ae115
Author: andrea 
Date:   2017-07-14T09:54:13Z

remove deprecated downloadRoot

commit 647417c33f4b677f879b1ab4769a9f9db52d579a
Author: andrea 
Date:   2017-07-14T10:46:49Z

fix typo

commit 6894bcd5b27b9b5a1294ce8bae47a3444a95b4a7
Author: andrea 
Date:   2017-07-24T13:04:47Z

added docs for additional configurations




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2483: [ZEPPELIN-2766] Make online resources url configurable...

[andreaTP]

Github user andreaTP commented on the issue:

https://github.com/apache/zeppelin/pull/2483
  
added a small section under the mentioned `Md` file @1ambda 
please let me know if anything else is needed


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2483: [ZEPPELIN-2766] Make online resources url configurable...

[andreaTP]

Github user andreaTP commented on the issue:

https://github.com/apache/zeppelin/pull/2483
  
@1ambda haven't found any specific section in docs mentioning settings in 
maven profiles... could you point me to a section that could be improved with 
this additions?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2483: [ZEPPELIN-2766] Make online resources url configurable...

[andreaTP]

Github user andreaTP commented on the issue:

https://github.com/apache/zeppelin/pull/2483
  
should I do anything else to get this merged?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2483: [ZEPPELIN-2766] Make online resources url configurable...

[andreaTP]

Github user andreaTP commented on the issue:

https://github.com/apache/zeppelin/pull/2483
  
B,T,W, it is incredibly annoying for contributors to have to "baby-sit" 
travis to get a green CI here :-S


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #2483: [ZEPPELIN-2766] Make online resources url confi...

[andreaTP]

GitHub user andreaTP reopened a pull request:

https://github.com/apache/zeppelin/pull/2483

[ZEPPELIN-2766] Make online resources url configurable at compile time

### What is this PR for?
At compile time Zeppelin is downloading several external resources.
I want to be able to provide alternative URLs to compile when internet is 
not available(i.e. behind corporate proxy).

### What type of PR is it?
[Improvement]

### What is the Jira issue?
[ZEPPELIN-2766]

### How should this be tested?
```
mvn -DskipTests -Dplugin.frontend.downloadRoot= 
-Dplugin.frontend.nodeDownloadRoot= 
-Dplugin.frontend.yarnDownloadRoot= 
-Dplugin.frontend.npmDownloadRoot= 
-Dpypi.repo.url= clean package
```

### Questions:
* Does the licenses files need update? NO
* Is there breaking changes for older versions? NO
* Does this needs documentation? NO


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nokia/zeppelin softCodeRepos

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/2483.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2483


commit 0aea864a99aa4adfdb210f8e67ed2da8aecb9bde
Author: andrea 
Date:   2017-07-11T13:55:01Z

Keep online resources configurable

commit 1e5fd85f4ddd3d85985d2d9f39959071cd9ae115
Author: andrea 
Date:   2017-07-14T09:54:13Z

remove deprecated downloadRoot

commit 647417c33f4b677f879b1ab4769a9f9db52d579a
Author: andrea 
Date:   2017-07-14T10:46:49Z

fix typo




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #2483: [ZEPPELIN-2766] Make online resources url confi...

[andreaTP]

Github user andreaTP closed the pull request at:

https://github.com/apache/zeppelin/pull/2483


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2483: [ZEPPELIN-2766] Make online resources url configurable...

[andreaTP]

Github user andreaTP commented on the issue:

https://github.com/apache/zeppelin/pull/2483
  
rebased on top of master, removed a typo and removed `downloadRoot` 
parameter that turns out to be `deprecated`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2483: [ZEPPELIN-2766] Make online resources url configurable...

[andreaTP]

Github user andreaTP commented on the issue:

https://github.com/apache/zeppelin/pull/2483
  
yes, :-) done! @felixcheung 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #2483: [ZEPPELIN-2766] Make online resources url confi...

[andreaTP]

Github user andreaTP closed the pull request at:

https://github.com/apache/zeppelin/pull/2483


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #2483: [ZEPPELIN-2766] Make online resources url confi...

[andreaTP]

GitHub user andreaTP reopened a pull request:

https://github.com/apache/zeppelin/pull/2483

[ZEPPELIN-2766] Make online resources url configurable at compile time

### What is this PR for?
At compile time Zeppelin is downloading several external resources.
I want to be able to provide alternative URLs to compile when internet is 
not available(i.e. behind corporate proxy).

### What type of PR is it?
[Improvement]

### What is the Jira issue?
[ZEPPELIN-2766]

### How should this be tested?
```
mvn -DskipTests -Dplugin.frontend.downloadRoot= 
-Dplugin.frontend.nodeDownloadRoot= 
-Dplugin.frontend.yarnDownloadRoot= 
-Dplugin.frontend.npmDownloadRoot= 
-Dpypi.repo.url= clean package
```

### Questions:
* Does the licenses files need update? NO
* Is there breaking changes for older versions? NO
* Does this needs documentation? NO


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nokia/zeppelin softCodeRepos

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/2483.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2483


commit 08a25d8e4640d9f6bf06e78424ad5d6a4e4761af
Author: andrea 
Date:   2017-07-11T13:55:01Z

Keep online resources configurable




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2483: [ZEPPELIN-2766] Make online resources url configurable...

[andreaTP]

Github user andreaTP commented on the issue:

https://github.com/apache/zeppelin/pull/2483
  
yes of course @felixcheung , basically I'm exposing through maven 
properties the ability for users to customize where to download from certain 
packets that are normally downloaded from very specific internet resources.
In this way one can build zeppelin from sources specifying faster or 
internal or more reliable addresses for those packages.

You can note that this does not break anything but just expose some plugin 
capabilities to users and fallback to proper default one.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #2483: [ZEPPELIN-2766] Make online resources url confi...

[andreaTP]

GitHub user andreaTP reopened a pull request:

https://github.com/apache/zeppelin/pull/2483

[ZEPPELIN-2766] Make online resources url configurable at compile time

### What is this PR for?
At compile time Zeppelin is downloading several external resources.
I want to be able to provide alternative URLs to compile when internet is 
not available(i.e. behind corporate proxy).

### What type of PR is it?
[Improvement]

### What is the Jira issue?
[ZEPPELIN-2766]

### How should this be tested?
```
mvn -DskipTests -Dplugin.frontend.downloadRoot= 
-Dplugin.frontend.nodeDownloadRoot= 
-Dplugin.frontend.yarnDownloadRoot= 
-Dplugin.frontend.npmDownloadRoot= 
-Dpypi.repo.url= clean package
```

### Questions:
* Does the licenses files need update? NO
* Is there breaking changes for older versions? NO
* Does this needs documentation? NO


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nokia/zeppelin softCodeRepos

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/2483.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2483


commit faf8362e2e7b0ea308434c8c5fb96ae8cb07a1d2
Author: andrea 
Date:   2017-07-11T13:55:01Z

Keep online resources configurable




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #2483: [ZEPPELIN-2766] Make online resources url confi...

[andreaTP]

Github user andreaTP closed the pull request at:

https://github.com/apache/zeppelin/pull/2483


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #2483: [ZEPPELIN-2766] Make online resources url confi...

[andreaTP]

GitHub user andreaTP opened a pull request:

https://github.com/apache/zeppelin/pull/2483

[ZEPPELIN-2766] Make online resources url configurable at compile time

### What is this PR for?
At compile time Zeppelin is downloading several external resources.
I want to be able to provide alternative URLs to compile when internet is 
not available(i.e. behind corporate proxy).

### What type of PR is it?
[Improvement]

### What is the Jira issue?
[ZEPPELIN-2766]

### How should this be tested?
```
mvn -DskipTests -Dplugin.frontend.downloadRoot= 
-Dplugin.frontend.nodeDownloadRoot= 
-Dplugin.frontend.yarnDownloadRoot= 
-Dplugin.frontend.npmDownloadRoot= 
-Dpypi.repo.url= clean package
```

### Questions:
* Does the licenses files need update? NO
* Is there breaking changes for older versions? NO
* Does this needs documentation? NO


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nokia/zeppelin softCodeRepos

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/2483.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2483


commit faf8362e2e7b0ea308434c8c5fb96ae8cb07a1d2
Author: andrea 
Date:   2017-07-11T13:55:01Z

Keep online resources configurable




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2373: [ZEPPELIN-2598] Securing Zeppelin with OpenID Connect

[andreaTP]

Github user andreaTP commented on the issue:

https://github.com/apache/zeppelin/pull/2373
  
I think this issue is addressed 
https://github.com/apache/zeppelin/pull/2463 I'm not sure if having a switch 
for prod and dev is good BTW 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2373: [ZEPPELIN-2598] Securing Zeppelin with OpenID Connect

[andreaTP]

Github user andreaTP commented on the issue:

https://github.com/apache/zeppelin/pull/2373
  
thanks a lot!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2373: [ZEPPELIN-2598] Securing Zeppelin with OpenID Connect

[andreaTP]

Github user andreaTP commented on the issue:

https://github.com/apache/zeppelin/pull/2373
  
ok, now also CI is happy  :-)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #2373: [ZEPPELIN-2598] Securing Zeppelin with OpenID C...

[andreaTP]

Github user andreaTP closed the pull request at:

https://github.com/apache/zeppelin/pull/2373


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #2373: [ZEPPELIN-2598] Securing Zeppelin with OpenID C...

[andreaTP]

GitHub user andreaTP reopened a pull request:

https://github.com/apache/zeppelin/pull/2373

[ZEPPELIN-2598] Securing Zeppelin with OpenID Connect

### What is this PR for?
Integrating Open ID connect login into Zeppelin leveraging Shiro(already 
present) and Pac4J( that needs to be in the classpath).
Modifications done here should not affect any existing mechanisms but 
simply integrates and enable new once.

### What type of PR is it?
[Improvement]

### What is the Jira issue?
[ZEPPELIN-2598]

### Questions:
* Does the licenses files need update?
* Is there breaking changes for older versions?
* Does this needs documentation?


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nokia/zeppelin keycloak

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/2373.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2373


commit 4ce91213eedf7c6b9eee1339290fbff1818989bd
Author: andrea 
Date:   2017-05-16T16:33:41Z

Enabling authentication with OpenId connect

commit 03bbe30b5707580580e2ee5c27126e7541220ff9
Author: andrea 
Date:   2017-05-30T06:32:02Z

updates

commit 545686dced6999bda7b8b6c21761874c9453cbd1
Author: andrea 
Date:   2017-05-30T12:23:24Z

fix username after direct login

commit 7ec8cddbe1f8162eb0bde7e2dbf8c76e2a4656bf
Author: andrea 
Date:   2017-06-01T13:07:55Z

reverted to a minimum

commit 80c375d42a3dc3f3de40360a0500c3c657ac2070
Author: andrea 
Date:   2017-06-19T19:48:41Z

fixed style issues on master

commit 31270f2cdce5a001353b6149cee4873ffa6d0fa8
Author: andrea 
Date:   2017-06-19T19:54:30Z

Merge remote-tracking branch 'apache/master' into keycloak

commit 2d5af6d93ebc5544c2105d78e54ab0205e0aa892
Author: andrea 
Date:   2017-06-26T08:38:46Z

merge with master




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #2373: [ZEPPELIN-2598] Securing Zeppelin with OpenID C...

[andreaTP]

Github user andreaTP closed the pull request at:

https://github.com/apache/zeppelin/pull/2373


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #2373: [ZEPPELIN-2598] Securing Zeppelin with OpenID C...

[andreaTP]

GitHub user andreaTP reopened a pull request:

https://github.com/apache/zeppelin/pull/2373

[ZEPPELIN-2598] Securing Zeppelin with OpenID Connect

### What is this PR for?
Integrating Open ID connect login into Zeppelin leveraging Shiro(already 
present) and Pac4J( that needs to be in the classpath).
Modifications done here should not affect any existing mechanisms but 
simply integrates and enable new once.

### What type of PR is it?
[Improvement]

### What is the Jira issue?
[ZEPPELIN-2598]

### Questions:
* Does the licenses files need update?
* Is there breaking changes for older versions?
* Does this needs documentation?


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nokia/zeppelin keycloak

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/2373.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2373






---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2373: [ZEPPELIN-2598] Securing Zeppelin with OpenID Connect

[andreaTP]

Github user andreaTP commented on the issue:

https://github.com/apache/zeppelin/pull/2373
  
@Leemoonsoo @felixcheung @1ambda 
I have had to rebase on master again after a week of no updates.
Please tell me what to do to on this to get it merged or why this is not 
going to be merged.

Thanks a lot in advance!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #2373: [ZEPPELIN-2598] Securing Zeppelin with OpenID C...

[andreaTP]

Github user andreaTP closed the pull request at:

https://github.com/apache/zeppelin/pull/2373


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #2373: [ZEPPELIN-2598] Securing Zeppelin with OpenID C...

[andreaTP]

GitHub user andreaTP reopened a pull request:

https://github.com/apache/zeppelin/pull/2373

[ZEPPELIN-2598] Securing Zeppelin with OpenID Connect

### What is this PR for?
Integrating Open ID connect login into Zeppelin leveraging Shiro(already 
present) and Pac4J( that needs to be in the classpath).
Modifications done here should not affect any existing mechanisms but 
simply integrates and enable new once.

### What type of PR is it?
[Improvement]

### What is the Jira issue?
[ZEPPELIN-2598]

### Questions:
* Does the licenses files need update?
* Is there breaking changes for older versions?
* Does this needs documentation?


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nokia/zeppelin keycloak

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/2373.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2373


commit 4ce91213eedf7c6b9eee1339290fbff1818989bd
Author: andrea 
Date:   2017-05-16T16:33:41Z

Enabling authentication with OpenId connect

commit 03bbe30b5707580580e2ee5c27126e7541220ff9
Author: andrea 
Date:   2017-05-30T06:32:02Z

updates

commit 545686dced6999bda7b8b6c21761874c9453cbd1
Author: andrea 
Date:   2017-05-30T12:23:24Z

fix username after direct login

commit 7ec8cddbe1f8162eb0bde7e2dbf8c76e2a4656bf
Author: andrea 
Date:   2017-06-01T13:07:55Z

reverted to a minimum

commit 80c375d42a3dc3f3de40360a0500c3c657ac2070
Author: andrea 
Date:   2017-06-19T19:48:41Z

fixed style issues on master

commit 31270f2cdce5a001353b6149cee4873ffa6d0fa8
Author: andrea 
Date:   2017-06-19T19:54:30Z

Merge remote-tracking branch 'apache/master' into keycloak




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2373: [ZEPPELIN-2598] Securing Zeppelin with OpenID Connect

[andreaTP]

Github user andreaTP commented on the issue:

https://github.com/apache/zeppelin/pull/2373
  
rebased on top of master and fixed style issues, this PR is taking too long 
for reviewers...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2373: [ZEPPELIN-2598] Securing Zeppelin with OpenID Connect

[andreaTP]

Github user andreaTP commented on the issue:

https://github.com/apache/zeppelin/pull/2373
  
@necosta checked again but it works for me and on CI ... I have had this 
problem once try to fetch and pull and see if this solves


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2373: [ZEPPELIN-2598] Securing Zeppelin with OpenID Connect

[andreaTP]

Github user andreaTP commented on the issue:

https://github.com/apache/zeppelin/pull/2373
  
ping


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2373: [ZEPPELIN-2598] Securing Zeppelin with OpenID Connect

[andreaTP]

Github user andreaTP commented on the issue:

https://github.com/apache/zeppelin/pull/2373
  
I sincerely think that this implementation is enough to unlock the usage of 
pac4j, buji (due to the rest of updates sent there).
I think that the name parsing can be refactored later on, actual 
implementation is not optimal but "good enough" to me(i.e. I have no cases 
where it fails), in case @volumeint could you share your configuration to login 
through other oidc providers in docs in another PR?

Please let try to finalize this in this week
cc. @Leemoonsoo @1ambda @felixcheung 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2397: [ZEPPELIN-2592] Ensure open stream is closed

[andreaTP]

Github user andreaTP commented on the issue:

https://github.com/apache/zeppelin/pull/2397
  
`try-with-resources` is used only for `InputStream` here.
there is nothing on outputstream.

https://docs.oracle.com/javase/tutorial/essential/exceptions/tryResourceClose.html


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2397: [ZEPPELIN-2592] Ensure open stream is closed

[andreaTP]

Github user andreaTP commented on the issue:

https://github.com/apache/zeppelin/pull/2397
  
to be 100% sure to close properly the stream the `close` method should be 
called within a `finally` statement of a `try`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2373: [ZEPPELIN-2598] Securing Zeppelin with OpenID Connect

[andreaTP]

Github user andreaTP commented on the issue:

https://github.com/apache/zeppelin/pull/2373
  
do this minimal and cleaned up version needs anything else to be worked out 
in order to be merged?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2383: [ZEPPELIN-2606] Fix compilation with R interpreter ena...

[andreaTP]

Github user andreaTP commented on the issue:

https://github.com/apache/zeppelin/pull/2383
  
do this need anything else to be merged?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2373: [ZEPPELIN-2598] Securing Zeppelin with OpenID Connect

[andreaTP]

Github user andreaTP commented on the issue:

https://github.com/apache/zeppelin/pull/2373
  
@1ambda To be honest I'm not such an expert and I'm just integrating from a 
technical POV a solution that other experts in team found.

I will love to have such documentation too, but I cannot realistically 
propose myself for writing it... sorry. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #2383: [ZEPPELIN-2606] Fix compilation with R interpre...

[andreaTP]

GitHub user andreaTP reopened a pull request:

https://github.com/apache/zeppelin/pull/2383

[ZEPPELIN-2606] Fix compilation with R interpreter enabled

### What is this PR for?
`mvn -DskipTests clean package -Pr` fails

### What type of PR is it?
Bug Fix

### What is the Jira issue?
 [ZEPPELIN-2606]

### How should this be tested?
`mvn -DskipTests clean package -Pr`


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nokia/zeppelin rInterpreterFix

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/2383.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2383


commit b237615c83eddc4107d039c6d276a2cf5a089b00
Author: andrea 
Date:   2017-05-31T15:36:28Z

 [ZEPPELIN-2606] Fix compilation with R interpreter enabled

commit 6ef05953e07e962acab9087133b222435efa1ef1
Author: andrea 
Date:   2017-06-01T11:41:50Z

included R interpreter in travis




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2383: [ZEPPELIN-2606] Fix compilation with R interpreter ena...

[andreaTP]

Github user andreaTP commented on the issue:

https://github.com/apache/zeppelin/pull/2383
  
Since R is under spark we need to enable it differently AFAICS
now it is enabled at least in one test (where all other interpreters are 
compiled).
Travis is happy I close and re-open this.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #2383: [ZEPPELIN-2606] Fix compilation with R interpre...

[andreaTP]

Github user andreaTP closed the pull request at:

https://github.com/apache/zeppelin/pull/2383


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2383: [ZEPPELIN-2606] Fix compilation with R interpreter ena...

[andreaTP]

Github user andreaTP commented on the issue:

https://github.com/apache/zeppelin/pull/2383
  
good point, so I added it to the list, I think it fits the scope of this PR 
(let see what travis says)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2383: [ZEPPELIN-2606] Fix compilation with R interpreter ena...

[andreaTP]

Github user andreaTP commented on the issue:

https://github.com/apache/zeppelin/pull/2383
  
`INTERPRETERS` is surprisingly an exclusion list @zjffdu 
https://github.com/apache/zeppelin/blob/master/.travis.yml#L40


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2373: [ZEPPELIN-2598] Securing Zeppelin with OpenID Connect

[andreaTP]

Github user andreaTP commented on the issue:

https://github.com/apache/zeppelin/pull/2373
  
@1ambda potentially yes

@khalidhuseynov thanks for pointing out a public server I can test! I will 
go through later on

B.t.w. I realized that the MVP to get this working is just upgrading shiro 
and the ui triggers,
the rest of the libraries can be provided on an ad-hoc basis (i.e. in a 
`lib` dir) without any need of packaging them into zeppelin itself, this will 
enable also users to choose the preferred version.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2383: [ZEPPELIN-2606] Fix compilation with R interpreter ena...

[andreaTP]

Github user andreaTP commented on the issue:

https://github.com/apache/zeppelin/pull/2383
  
yes a full compilation with all interpreters available should be included 
in CI build IMO 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #2383: [ZEPPELIN-2606] Fix compilation with R interpre...

[andreaTP]

GitHub user andreaTP opened a pull request:

https://github.com/apache/zeppelin/pull/2383

[ZEPPELIN-2606] Fix compilation with R interpreter enabled

### What is this PR for?
`mvn -DskipTests clean package -Pr` fails

### What type of PR is it?
Bug Fix

### What is the Jira issue?
 [ZEPPELIN-2606]

### How should this be tested?
`mvn -DskipTests clean package -Pr`


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nokia/zeppelin rInterpreterFix

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/2383.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2383


commit b237615c83eddc4107d039c6d276a2cf5a089b00
Author: andrea 
Date:   2017-05-31T15:36:28Z

 [ZEPPELIN-2606] Fix compilation with R interpreter enabled




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #2373: [ZEPPELIN-2598] Securing Zeppelin with OpenID C...

[andreaTP]

GitHub user andreaTP opened a pull request:

https://github.com/apache/zeppelin/pull/2373

[ZEPPELIN-2598] Securing Zeppelin with OpenID Connect

### What is this PR for?
Integrating Open ID connect login into Zeppelin leveraging Shiro(already 
present) and Pac4J( that needs to be in the classpath).
Modifications done here should not affect any existing mechanisms but 
simply integrates and enable new once.

### What type of PR is it?
[Improvement]

### What is the Jira issue?
[ZEPPELIN-2598]

### Questions:
* Does the licenses files need update?
* Is there breaking changes for older versions?
* Does this needs documentation?


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nokia/zeppelin keycloak

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/2373.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2373


commit 4ce91213eedf7c6b9eee1339290fbff1818989bd
Author: andrea 
Date:   2017-05-16T16:33:41Z

Enabling authentication with OpenId connect




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2349: [ZEPPELIN-2214] Set npm installer default npm registry

[andreaTP]

Github user andreaTP commented on the issue:

https://github.com/apache/zeppelin/pull/2349
  
Since npm registry name can be changed arbitrarily it's worth to add a 
configuration key for the hard-coded `"/npm/-/"`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2322: [ZEPPELIN-2502] RemoteInterpreterServer hang forever d...

[andreaTP]

Github user andreaTP commented on the issue:

https://github.com/apache/zeppelin/pull/2322
  
ping


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2322: [ZEPPELIN-2502] RemoteInterpreterServer hang forever d...

[andreaTP]

Github user andreaTP commented on the issue:

https://github.com/apache/zeppelin/pull/2322
  
I reverted back modifications to concurrency management since it looks like 
they result in Ui response instability, I'm not sure why this happens, I 
believe that we can conclude with a clean PR like this.
In case I manage to refactor and use proper `java.util.concurrent` into 
`remote` I will send another PR.
WDYT? @Leemoonsoo @felixcheung 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2322: [ZEPPELIN-2502] RemoteInterpreterServer hang forever d...

[andreaTP]

Github user andreaTP commented on the issue:

https://github.com/apache/zeppelin/pull/2322
  
@Leemoonsoo sounds good :-) I'll do that tomorrow!
and I will follow up with this PR. Thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2322: [ZEPPELIN-2502] RemoteInterpreterServer hang forever d...

[andreaTP]

Github user andreaTP commented on the issue:

https://github.com/apache/zeppelin/pull/2322
  
@Leemoonsoo I can reproduce the error locally running on Chrome (i.e. the 
current encoding of the test doesn't work for me out of the box with chrome), 
should I separate these modifications in a separate PR? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2322: [ZEPPELIN-2502] RemoteInterpreterServer hang forever d...

[andreaTP]

Github user andreaTP commented on the issue:

https://github.com/apache/zeppelin/pull/2322
  
am I supposed to do anything else?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2322: [ZEPPELIN-2502] RemoteInterpreterServer hang forever d...

[andreaTP]

Github user andreaTP commented on the issue:

https://github.com/apache/zeppelin/pull/2322
  
I have had to fix some escaping problems to make travis happy, and it also 
required some retries 
anyhow travis is now happy: 
https://travis-ci.org/nokia/zeppelin/builds/230331180

I hope this PR is addressed and we can move on.
I still wait hint from @felixcheung and @Leemoonsoo on how to proceed on 
the rest.

thanks in advance


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2322: [ZEPPELIN-2502] RemoteInterpreterServer hang forever d...

[andreaTP]

Github user andreaTP commented on the issue:

https://github.com/apache/zeppelin/pull/2322
  
Looking at the code it looks quite harmful also the pattern used 
[here](https://github.com/apache/zeppelin/blob/master/zeppelin-interpreter/src/main/java/org/apache/zeppelin/interpreter/remote/RemoteInterpreterEventClient.java#L138),
 
[here](https://github.com/apache/zeppelin/blob/master/zeppelin-interpreter/src/main/java/org/apache/zeppelin/interpreter/remote/RemoteInterpreterEventClient.java#L191)
 and 
[here](https://github.com/apache/zeppelin/blob/master/zeppelin-interpreter/src/main/java/org/apache/zeppelin/interpreter/remote/RemoteInterpreterEventClient.java#L245)

if anything goes wrong the Thread can stay in `wait` status potentially 
forever and operations performed there are all but not transactional.

Could I ask if somebody can at least provide some kind of deadline also for 
those?
Better will be a little refactoring using something like 
[ConcurrentHashMap](https://docs.oracle.com/javase/7/docs/api/java/util/concurrent/ConcurrentHashMap.html)
 for operations.

I can even do the refactoring if I have positive feedbacks, anyhow I 
believe this PR is ok as is and I open a new issue and new PR in case.




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2322: [ZEPPELIN-2502] RemoteInterpreterServer hang forever d...

[andreaTP]

Github user andreaTP commented on the issue:

https://github.com/apache/zeppelin/pull/2322
  
@felixcheung good catch, after a second look I can see that while it is 
waiting on `pollEvent` it will also delay the `sendEvent` since it is 
`synchronized` too.

I guess all these problems are already solved by Java standard lib, if I 
have positive feedback I will go substituting `eventQueue` with a 
[LinkedBlockingQueue](https://docs.oracle.com/javase/7/docs/api/java/util/concurrent/LinkedBlockingQueue.html)
 and removing all `synchronized` statements since they become unuseful.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #2322: [ZEPPELIN-2502] RemoteInterpreterServer hang fo...

[andreaTP]

GitHub user andreaTP opened a pull request:

https://github.com/apache/zeppelin/pull/2322

[ZEPPELIN-2502] RemoteInterpreterServer hang forever during shutdown

### What is this PR for?
There is the chance to have a RemoteServerInterpreter hang forever during 
shutdown

### What type of PR is it?
[Bug Fix]

### What is the Jira issue?
[ZEPPELIN-2502] 

### How should this be tested?
Unit test provided for the fix.

### Questions:
* Is there breaking changes for older versions?
* Does this needs documentation?


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nokia/zeppelin processHang

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/2322.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2322






---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2183: [ZEPPELIN-2309] Backport maven and npm repo config to ...

[andreaTP]

Github user andreaTP commented on the issue:

https://github.com/apache/zeppelin/pull/2183
  
Sure. Thanks 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #2183: [ZEPPELIN-2309] Backport maven and npm repo con...

[andreaTP]

Github user andreaTP closed the pull request at:

https://github.com/apache/zeppelin/pull/2183


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2183: [ZEPPELIN-2309] Backport maven and npm repo config to ...

[andreaTP]

Github user andreaTP commented on the issue:

https://github.com/apache/zeppelin/pull/2183
  
Great! Thanks


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #2183: [ZEPPELIN-2309] Backport maven and npm repo con...

[andreaTP]

GitHub user andreaTP opened a pull request:

https://github.com/apache/zeppelin/pull/2183

[ZEPPELIN-2309] Backport maven and npm repo config to 0.7

### What is this PR for?
Backport configuration settings for maven central and npm repository to 0.7.

### What type of PR is it?
Improvement

### What is the Jira issue?
[ZEPPELIN-2309]

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nokia/zeppelin backportConfs

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/2183.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2183


commit c50c964edd205d7bd1ca6143bf4536e9ada621ed
Author: Andrea Peruffo 
Date:   2017-03-03T10:44:15Z

[ZEPPELIN-2277] Env variable to configure maven central repo

When deploying Zeppelin in private Cloud or within closed networks, it 
happens that Maven Central isn't directly reachable, so we want to configure 
our own proxy and do not have to wait for minutes long timeouts when importing 
external libraries. It is anyhow worth to let user configure maven central repo 
instead of hardcoding the URL.

Improvement

Outline the steps to test the PR here.

* Does the licenses files need update?
* Is there breaking changes for older versions?
* Does this needs documentation?

Author: Andrea Peruffo 

Closes #2093 from andreaTP/mavenRepo and squashes the following commits:

af9accc [Andrea Peruffo] [ZEPPELIN-2277] Env variable to configure maven 
central repo

commit bf8df5d00a2ff1c55816d65a393666d06cead47c
Author: Andrea Peruffo 
Date:   2017-03-17T09:59:44Z

[ZEPPELIN-2278] Env variable to configure Npm registry

When deploying Zeppelin in private Cloud or within closed networks, it 
happens that Npm Registry isn't directly reachable, so we want to configure our 
own proxy/registry otherwise we couldn't fetch dependencies. It is anyhow worth 
to let user configure npm registry instead of hardcoding the URL.

Improvement

[ZEPPELIN-2278]

* Does the licenses files need update?
* Is there breaking changes for older versions?
* Does this needs documentation?

Author: Andrea Peruffo 

Closes #2150 from andreaTP/npmConfig and squashes the following commits:

56fab25 [Andrea Peruffo] [ZEPPELIN-2278] Env variable to configure Npm 
registry




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2150: [ZEPPELIN-2278] Env variable to configure Npm registry

[andreaTP]

Github user andreaTP commented on the issue:

https://github.com/apache/zeppelin/pull/2150
  
Please go on! Thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2150: [ZEPPELIN-2278] Env variable to configure Npm registry

[andreaTP]

Github user andreaTP commented on the issue:

https://github.com/apache/zeppelin/pull/2150
  
Done, let see the result! 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #2150: [ZEPPELIN-2278] Env variable to configure Npm r...

[andreaTP]

Github user andreaTP closed the pull request at:

https://github.com/apache/zeppelin/pull/2150


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #2150: [ZEPPELIN-2278] Env variable to configure Npm r...

[andreaTP]

GitHub user andreaTP reopened a pull request:

https://github.com/apache/zeppelin/pull/2150

[ZEPPELIN-2278] Env variable to configure Npm registry

### What is this PR for?
When deploying Zeppelin in private Cloud or within closed networks, it 
happens that Npm Registry isn't directly reachable, so we want to configure our 
own proxy/registry otherwise we couldn't fetch dependencies. It is anyhow worth 
to let user configure npm registry instead of hardcoding the URL.


### What type of PR is it?
Improvement

### What is the Jira issue?
[ZEPPELIN-2278]

### Questions:
* Does the licenses files need update?
* Is there breaking changes for older versions?
* Does this needs documentation?


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nokia/zeppelin npmConfig

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/2150.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2150


commit 56fab25ff9f01014e5666f46b121ce65c8a07cb2
Author: Andrea Peruffo 
Date:   2017-03-17T09:59:44Z

[ZEPPELIN-2278] Env variable to configure Npm registry




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2150: [ZEPPELIN-2278] Env variable to configure Npm registry

[andreaTP]

Github user andreaTP commented on the issue:

https://github.com/apache/zeppelin/pull/2150
  
Travis itself succed https://travis-ci.org/nokia/zeppelin/builds/213131116


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2150: [ZEPPELIN-2278] Env variable to configure Npm registry

[andreaTP]

Github user andreaTP commented on the issue:

https://github.com/apache/zeppelin/pull/2150
  
no luck again :-(


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #2150: [ZEPPELIN-2278] Env variable to configure Npm r...

[andreaTP]

Github user andreaTP closed the pull request at:

https://github.com/apache/zeppelin/pull/2150


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2150: [ZEPPELIN-2278] Env variable to configure Npm registry

[andreaTP]

Github user andreaTP commented on the issue:

https://github.com/apache/zeppelin/pull/2150
  
@Leemoonsoo
rebased.
Unfortunately again failures on CI, this is on Jenkins side I guess 
https://builds.apache.org/job/zeppelin-pull-request/580/console
this is spurious since travis job is correctly started.

I go closing and re-opening the PR to trigger again the build (seemed to 
work last time)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #2150: [ZEPPELIN-2278] Env variable to configure Npm r...

[andreaTP]

GitHub user andreaTP reopened a pull request:

https://github.com/apache/zeppelin/pull/2150

[ZEPPELIN-2278] Env variable to configure Npm registry

### What is this PR for?
When deploying Zeppelin in private Cloud or within closed networks, it 
happens that Npm Registry isn't directly reachable, so we want to configure our 
own proxy/registry otherwise we couldn't fetch dependencies. It is anyhow worth 
to let user configure npm registry instead of hardcoding the URL.


### What type of PR is it?
Improvement

### What is the Jira issue?
[ZEPPELIN-2278]

### Questions:
* Does the licenses files need update?
* Is there breaking changes for older versions?
* Does this needs documentation?


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nokia/zeppelin npmConfig

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/2150.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2150


commit 56fab25ff9f01014e5666f46b121ce65c8a07cb2
Author: Andrea Peruffo 
Date:   2017-03-17T09:59:44Z

[ZEPPELIN-2278] Env variable to configure Npm registry




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2150: [ZEPPELIN-2278] Env variable to configure Npm registry

[andreaTP]

Github user andreaTP commented on the issue:

https://github.com/apache/zeppelin/pull/2150
  
probably you have a problem on Jenkins, Travis is currently building 
without errors:
https://travis-ci.org/nokia/zeppelin

still this PR is marked as Failed...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #2150: [ZEPPELIN-2278] Env variable to configure Npm r...

[andreaTP]

GitHub user andreaTP reopened a pull request:

https://github.com/apache/zeppelin/pull/2150

[ZEPPELIN-2278] Env variable to configure Npm registry

### What is this PR for?
When deploying Zeppelin in private Cloud or within closed networks, it 
happens that Npm Registry isn't directly reachable, so we want to configure our 
own proxy/registry otherwise we couldn't fetch dependencies. It is anyhow worth 
to let user configure npm registry instead of hardcoding the URL.


### What type of PR is it?
Improvement

### What is the Jira issue?
[ZEPPELIN-2278]

### Questions:
* Does the licenses files need update?
* Is there breaking changes for older versions?
* Does this needs documentation?


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nokia/zeppelin npmConfig

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/2150.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2150


commit 6bebed23805b409a050c22606250ba1bef9f3c44
Author: Andrea Peruffo 
Date:   2017-03-17T09:59:44Z

[ZEPPELIN-2278] Env variable to configure Npm registry




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #2150: [ZEPPELIN-2278] Env variable to configure Npm r...

[andreaTP]

Github user andreaTP closed the pull request at:

https://github.com/apache/zeppelin/pull/2150


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2150: [ZEPPELIN-2278] Env variable to configure Npm registry

[andreaTP]

Github user andreaTP commented on the issue:

https://github.com/apache/zeppelin/pull/2150
  
@AhyoungRyu rebased on top of current *master*


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2093: [ZEPPELIN-2277] Env variable to configure maven centra...

[andreaTP]

Github user andreaTP commented on the issue:

https://github.com/apache/zeppelin/pull/2093
  
Thanks a lot! appreciated this welcoming environment! (I was aiming to 
become committer number 200 also )


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2150: [ZEPPELIN-2278] Env variable to configure Npm registry

[andreaTP]

Github user andreaTP commented on the issue:

https://github.com/apache/zeppelin/pull/2150
  
Thanks for the feedback @1ambda , travis should be configured properly now, 
I will try to dig into but it looks tests spuriously fail, anyhow any help on 
getting the right direction is highly appreciated! 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2150: [ZEPPELIN-2278] Env variable to configure Npm registry

[andreaTP]

Github user andreaTP commented on the issue:

https://github.com/apache/zeppelin/pull/2150
  
failures looks unrelated ...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2093: [ZEPPELIN-2277] Env variable to configure maven centra...

[andreaTP]

Github user andreaTP commented on the issue:

https://github.com/apache/zeppelin/pull/2093
  
updated also commit message here


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #2150: [ZEPPELIN-2278] Env variable to configure Npm r...

[andreaTP]

GitHub user andreaTP opened a pull request:

https://github.com/apache/zeppelin/pull/2150

[ZEPPELIN-2278] Env variable to configure Npm registry

### What is this PR for?
When deploying Zeppelin in private Cloud or within closed networks, it 
happens that Npm Registry isn't directly reachable, so we want to configure our 
own proxy/registry otherwise we couldn't fetch dependencies. It is anyhow worth 
to let user configure npm registry instead of hardcoding the URL.


### What type of PR is it?
Improvement

### What is the Jira issue?
[ZEPPELIN-2278]

### Questions:
* Does the licenses files need update?
* Is there breaking changes for older versions?
* Does this needs documentation?


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/nokia/zeppelin npmConfig

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/2150.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2150


commit 653ff57f10e398b4c4fb1f5c779cc392069b74b5
Author: Andrea Peruffo 
Date:   2017-03-17T09:59:44Z

[ZEPPELIN-2278] Env variable to configure Npm registry




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2093: [ZEPPELIN-2277] Env variable to configure maven centra...

[andreaTP]

Github user andreaTP commented on the issue:

https://github.com/apache/zeppelin/pull/2093
  
Yep, opened Jira issue and linked accordingly on PR title.
https://issues.apache.org/jira/browse/ZEPPELIN-2277

@Leemoonsoo  thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2093: Env variable to configure maven central repo

[andreaTP]

Github user andreaTP commented on the issue:

https://github.com/apache/zeppelin/pull/2093
  
I believe this is ready to merge.
Please let me know if I need to do anything more.
cc. @Leemoonsoo 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2093: Env variable to configure maven central repo

[andreaTP]

Github user andreaTP commented on the issue:

https://github.com/apache/zeppelin/pull/2093
  
added even the row in the configuration table, thanks a lot for your 
patience!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2093: Env variable to configure maven central repo

[andreaTP]

Github user andreaTP commented on the issue:

https://github.com/apache/zeppelin/pull/2093
  
@Leemoonsoo thanks a lot for the hints, this simplify a lot and even CI is 
happy.
I already squashed commits since now this PR looks in a good shape, but 
feel free to ask/argue about anything else.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2093: Env variable to configure maven central repo

[andreaTP]

Github user andreaTP commented on the issue:

https://github.com/apache/zeppelin/pull/2093
  
@Leemoonsoo thanks a lot for your comments, I hope to have targeted all of 
them, not sure how it works here, I will squash commits at the end of the 
process if you agree.

b.t.w.
tests consistently fail at ```pySparkDepLoaderTest``` 
https://travis-ci.org/andreaTP/zeppelin/jobs/208145522#L2932 but don't know how 
to start debugging this, it immediately fail with reflection errors.
 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2093: Env variable to configure maven central repo

[andreaTP]

Github user andreaTP commented on the issue:

https://github.com/apache/zeppelin/pull/2093
  
ok, I don't know exactly how to proceed on debugging this :-S, the problem 
is with dependency loading in python interpreter...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---