[GitHub] zeppelin issue #1561: [Zeppelin 914]- Apply new mechanism to IgniteInterpret...
Github user meenakshisekar commented on the issue: https://github.com/apache/zeppelin/pull/1561 Ok sure please go ahead On Wed, Dec 28, 2016 at 3:29 PM, DrIgor wrote: > Hello! > > I would like to help with ZEPPELIN-804 > <https://issues.apache.org/jira/browse/ZEPPELIN-804> subtasks and make it > possible to complete refactoring > > If you don't mind I will rebase this PR and take a look at #1077 > <https://github.com/apache/zeppelin/pull/1077> > > â > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > <https://github.com/apache/zeppelin/pull/1561#issuecomment-269454686>, or mute > the thread > <https://github.com/notifications/unsubscribe-auth/AKjsi4s-lIESQAOnzEj0YICFLs17cr66ks5rMjMagaJpZM4Kf7Ua> > . > -- Thanks & Regards, Meenakshi. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #1548: [ZEPPELIN-917] Apply new mechanism to LensInter...
GitHub user meenakshisekar reopened a pull request:
https://github.com/apache/zeppelin/pull/1548
[ZEPPELIN-917] Apply new mechanism to LensInterpreter
### What is this PR for?
This handles replacing the registration of interpreter with static block by
the interpreter-setting.json file
### What type of PR is it?
[| Improvement |
### Todos
Sub-Task
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-917
### How should this be tested?
here shouldn't be any warning like below on starting the server
INFO [2016-09-29 00:25:46,247]({main} LensInterpreter.java[]:155) -
Bootstrapping Cassandra Interpreter WARN [2016-09-29 00:25:46,250]({main}
Interpreter.java[register]:347) - Static initialization is deprecated for
interpreter lens, You should change it to use interpreter-setting.json in your
jar or interpreter/{interpreter}/interpreter-setting.json INFO [2016-09-29
00:25:46,250]({main} InterpreterFactory.java[init]:204) -
Inclass=org.apache.zeppelin.lens.LensInterpreter
And ensure that the lens related paragraphs run without any error
### Screenshots (if appropriate)
### Questions:
- Does the licenses files need update? No
- Is there breaking changes for older versions? No
- Does this needs documentation? No
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/meenakshisekar/zeppelin ZEPPELIN-917
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1548.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1548
commit db2827f867199cdd5e3fe2bc05f614dd88e013f5
Author: meenakshisekar
Date: 2016-10-21T09:59:38Z
Commented the properties in interpreter file and added setting file.
commit f94c8a3d44d441174fff2e89708e9ec62c1f5d22
Author: meenakshisekar
Date: 2016-10-21T11:41:58Z
Commented the properties in interpreter file and added setting file.
commit ad3b83ca856c54727f1ffef324f187f69a276c83
Author: meenakshisekar
Date: 2016-10-24T11:57:46Z
Added indentation
commit 2cba9e74df90073bd03c2867a70c345e5346dc7e
Author: meenakshisekar
Date: 2016-10-27T07:12:54Z
Added the indentation similar to other interpreter setting file.
commit cc8bdc274f581e7725307e2a4706b4d8ce4e243c
Author: meenakshisekar
Date: 2016-10-27T07:12:54Z
Added the indentation similar to other interpreter setting file.
commit 269e8cb3c547d5f1ea932c571206c13931a462ca
Author: meenakshisekar
Date: 2016-10-27T08:02:10Z
Removed the tabs and added space.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1548: [ZEPPELIN-917] Apply new mechanism to LensInter...
Github user meenakshisekar closed the pull request at: https://github.com/apache/zeppelin/pull/1548 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #1561: [Zeppelin 914]- Apply new mechanism to IgniteIn...
Github user meenakshisekar closed the pull request at: https://github.com/apache/zeppelin/pull/1561 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #1561: [Zeppelin 914]- Apply new mechanism to IgniteIn...
GitHub user meenakshisekar reopened a pull request:
https://github.com/apache/zeppelin/pull/1561
[Zeppelin 914]- Apply new mechanism to IgniteInterpreter
What is this PR for?
This handles replacing the registration of interpreter with static block by
the interpreter-setting.json file
What type of PR is it?
[| Improvement |
Todos
Sub-Task
What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-914
How should this be tested?
There shouldn't be any warning like below on starting the server
INFO 2016-09-29 00:25:46,247 - Bootstrapping Ignite Interpreter WARN
2016-09-29 00:25:46,250 - Static initialization is deprecated for interpreter
Ignite, You should change it to use interpreter-setting.json in your jar or
interpreter/{interpreter}/interpreter-setting.json INFO 2016-09-29 00:25:46,250
- Inclass=org.apache.zeppelin.ignite
And ensure that the Ignite related paragraphs run without any error
Screenshots (if appropriate)
Questions:
Does the licenses files need update? No
Is there breaking changes for older versions? No
Does this needs documentation? No
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/meenakshisekar/zeppelin ZEPPELIN-914
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1561.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1561
commit 57241368855c62a2975bd44852f77618ddffdbb1
Author: meenakshisekar
Date: 2016-10-24T12:40:12Z
Added interpreter setting and removed registration from interperter.
commit 640ad3020a53ce4fbd7965402e877c514232e0c2
Author: meenakshisekar
Date: 2016-10-24T12:44:43Z
Added interpreter setting file.
commit d7d846b1bc4f42b427cd69aa96e4d6ad195ee3a3
Author: meenakshisekar
Date: 2016-10-24T12:44:43Z
Added interpreter setting file.
commit 18ee9694fb295790171ccd2917ec32f93ef0d883
Author: meenakshisekar
Date: 2016-10-26T10:14:38Z
Corrected the type O
commit 7c328a17c6f043ba4fb3ca358390614cbb66750f
Author: meenakshisekar
Date: 2016-10-26T10:27:25Z
Added indentation
commit 44bc6d1d93893b5c2ef717281c14b4bf620c084b
Author: meenakshisekar
Date: 2016-10-27T11:54:51Z
Added igniteSQl interpreter to the group.
commit 0ec5da8d017507fe2a2bbbd0948edecc70766104
Author: meenakshisekar
Date: 2016-10-31T07:36:35Z
Removed properties in interpreter file and added new line in json file.
commit a8599a49f789c2fdaf2bde424ba47ea964a7ba68
Author: meenakshisekar
Date: 2016-10-31T07:36:35Z
Removed properties in interpreter file and added new line in json file.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1548: [ZEPPELIN-917] Apply new mechanism to LensInter...
Github user meenakshisekar closed the pull request at: https://github.com/apache/zeppelin/pull/1548 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #1548: [ZEPPELIN-917] Apply new mechanism to LensInter...
GitHub user meenakshisekar reopened a pull request:
https://github.com/apache/zeppelin/pull/1548
[ZEPPELIN-917] Apply new mechanism to LensInterpreter
### What is this PR for?
This handles replacing the registration of interpreter with static block by
the interpreter-setting.json file
### What type of PR is it?
[| Improvement |
### Todos
Sub-Task
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-917
### How should this be tested?
here shouldn't be any warning like below on starting the server
INFO [2016-09-29 00:25:46,247]({main} LensInterpreter.java[]:155) -
Bootstrapping Cassandra Interpreter WARN [2016-09-29 00:25:46,250]({main}
Interpreter.java[register]:347) - Static initialization is deprecated for
interpreter lens, You should change it to use interpreter-setting.json in your
jar or interpreter/{interpreter}/interpreter-setting.json INFO [2016-09-29
00:25:46,250]({main} InterpreterFactory.java[init]:204) -
Inclass=org.apache.zeppelin.lens.LensInterpreter
And ensure that the lens related paragraphs run without any error
### Screenshots (if appropriate)
### Questions:
- Does the licenses files need update? No
- Is there breaking changes for older versions? No
- Does this needs documentation? No
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/meenakshisekar/zeppelin ZEPPELIN-917
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1548.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1548
commit db2827f867199cdd5e3fe2bc05f614dd88e013f5
Author: meenakshisekar
Date: 2016-10-21T09:59:38Z
Commented the properties in interpreter file and added setting file.
commit f94c8a3d44d441174fff2e89708e9ec62c1f5d22
Author: meenakshisekar
Date: 2016-10-21T11:41:58Z
Commented the properties in interpreter file and added setting file.
commit ad3b83ca856c54727f1ffef324f187f69a276c83
Author: meenakshisekar
Date: 2016-10-24T11:57:46Z
Added indentation
commit cc8bdc274f581e7725307e2a4706b4d8ce4e243c
Author: meenakshisekar
Date: 2016-10-27T07:12:54Z
Added the indentation similar to other interpreter setting file.
commit 2cba9e74df90073bd03c2867a70c345e5346dc7e
Author: meenakshisekar
Date: 2016-10-27T07:12:54Z
Added the indentation similar to other interpreter setting file.
commit 269e8cb3c547d5f1ea932c571206c13931a462ca
Author: meenakshisekar
Date: 2016-10-27T08:02:10Z
Removed the tabs and added space.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1561: [Zeppelin 914]- Apply new mechanism to IgniteInterpret...
Github user meenakshisekar commented on the issue: https://github.com/apache/zeppelin/pull/1561 Reopening for TRavis --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #1561: [Zeppelin 914]- Apply new mechanism to IgniteIn...
GitHub user meenakshisekar reopened a pull request:
https://github.com/apache/zeppelin/pull/1561
[Zeppelin 914]- Apply new mechanism to IgniteInterpreter
What is this PR for?
This handles replacing the registration of interpreter with static block by
the interpreter-setting.json file
What type of PR is it?
[| Improvement |
Todos
Sub-Task
What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-914
How should this be tested?
There shouldn't be any warning like below on starting the server
INFO 2016-09-29 00:25:46,247 - Bootstrapping Ignite Interpreter WARN
2016-09-29 00:25:46,250 - Static initialization is deprecated for interpreter
Ignite, You should change it to use interpreter-setting.json in your jar or
interpreter/{interpreter}/interpreter-setting.json INFO 2016-09-29 00:25:46,250
- Inclass=org.apache.zeppelin.ignite
And ensure that the Ignite related paragraphs run without any error
Screenshots (if appropriate)
Questions:
Does the licenses files need update? No
Is there breaking changes for older versions? No
Does this needs documentation? No
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/meenakshisekar/zeppelin ZEPPELIN-914
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1561.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1561
commit 57241368855c62a2975bd44852f77618ddffdbb1
Author: meenakshisekar
Date: 2016-10-24T12:40:12Z
Added interpreter setting and removed registration from interperter.
commit 640ad3020a53ce4fbd7965402e877c514232e0c2
Author: meenakshisekar
Date: 2016-10-24T12:44:43Z
Added interpreter setting file.
commit d7d846b1bc4f42b427cd69aa96e4d6ad195ee3a3
Author: meenakshisekar
Date: 2016-10-24T12:44:43Z
Added interpreter setting file.
commit 18ee9694fb295790171ccd2917ec32f93ef0d883
Author: meenakshisekar
Date: 2016-10-26T10:14:38Z
Corrected the type O
commit 7c328a17c6f043ba4fb3ca358390614cbb66750f
Author: meenakshisekar
Date: 2016-10-26T10:27:25Z
Added indentation
commit 44bc6d1d93893b5c2ef717281c14b4bf620c084b
Author: meenakshisekar
Date: 2016-10-27T11:54:51Z
Added igniteSQl interpreter to the group.
commit 0ec5da8d017507fe2a2bbbd0948edecc70766104
Author: meenakshisekar
Date: 2016-10-31T07:36:35Z
Removed properties in interpreter file and added new line in json file.
commit a8599a49f789c2fdaf2bde424ba47ea964a7ba68
Author: meenakshisekar
Date: 2016-10-31T07:36:35Z
Removed properties in interpreter file and added new line in json file.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1561: [Zeppelin 914]- Apply new mechanism to IgniteIn...
Github user meenakshisekar closed the pull request at: https://github.com/apache/zeppelin/pull/1561 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #1548: [ZEPPELIN-917] Apply new mechanism to LensInter...
GitHub user meenakshisekar reopened a pull request:
https://github.com/apache/zeppelin/pull/1548
[ZEPPELIN-917] Apply new mechanism to LensInterpreter
### What is this PR for?
This handles replacing the registration of interpreter with static block by
the interpreter-setting.json file
### What type of PR is it?
[| Improvement |
### Todos
Sub-Task
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-917
### How should this be tested?
here shouldn't be any warning like below on starting the server
INFO [2016-09-29 00:25:46,247]({main} LensInterpreter.java[]:155) -
Bootstrapping Cassandra Interpreter WARN [2016-09-29 00:25:46,250]({main}
Interpreter.java[register]:347) - Static initialization is deprecated for
interpreter lens, You should change it to use interpreter-setting.json in your
jar or interpreter/{interpreter}/interpreter-setting.json INFO [2016-09-29
00:25:46,250]({main} InterpreterFactory.java[init]:204) -
Inclass=org.apache.zeppelin.lens.LensInterpreter
And ensure that the lens related paragraphs run without any error
### Screenshots (if appropriate)
### Questions:
- Does the licenses files need update? No
- Is there breaking changes for older versions? No
- Does this needs documentation? No
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/meenakshisekar/zeppelin ZEPPELIN-917
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1548.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1548
commit db2827f867199cdd5e3fe2bc05f614dd88e013f5
Author: meenakshisekar
Date: 2016-10-21T09:59:38Z
Commented the properties in interpreter file and added setting file.
commit f94c8a3d44d441174fff2e89708e9ec62c1f5d22
Author: meenakshisekar
Date: 2016-10-21T11:41:58Z
Commented the properties in interpreter file and added setting file.
commit ad3b83ca856c54727f1ffef324f187f69a276c83
Author: meenakshisekar
Date: 2016-10-24T11:57:46Z
Added indentation
commit 2cba9e74df90073bd03c2867a70c345e5346dc7e
Author: meenakshisekar
Date: 2016-10-27T07:12:54Z
Added the indentation similar to other interpreter setting file.
commit cc8bdc274f581e7725307e2a4706b4d8ce4e243c
Author: meenakshisekar
Date: 2016-10-27T07:12:54Z
Added the indentation similar to other interpreter setting file.
commit 269e8cb3c547d5f1ea932c571206c13931a462ca
Author: meenakshisekar
Date: 2016-10-27T08:02:10Z
Removed the tabs and added space.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1548: [ZEPPELIN-917] Apply new mechanism to LensInterpreter
Github user meenakshisekar commented on the issue: https://github.com/apache/zeppelin/pull/1548 Reopening for travis build. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #1548: [ZEPPELIN-917] Apply new mechanism to LensInter...
Github user meenakshisekar closed the pull request at: https://github.com/apache/zeppelin/pull/1548 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1561: Zeppelin 914 Apply new mechanism to IgniteInterpreter
Github user meenakshisekar commented on the issue: https://github.com/apache/zeppelin/pull/1561 Reopening for Travis build. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #1561: Zeppelin 914 Apply new mechanism to IgniteInter...
Github user meenakshisekar closed the pull request at: https://github.com/apache/zeppelin/pull/1561 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #1561: Zeppelin 914 Apply new mechanism to IgniteInter...
GitHub user meenakshisekar reopened a pull request:
https://github.com/apache/zeppelin/pull/1561
Zeppelin 914 Apply new mechanism to IgniteInterpreter
What is this PR for?
This handles replacing the registration of interpreter with static block by
the interpreter-setting.json file
What type of PR is it?
[| Improvement |
Todos
Sub-Task
What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-914
How should this be tested?
There shouldn't be any warning like below on starting the server
INFO 2016-09-29 00:25:46,247 - Bootstrapping Ignite Interpreter WARN
2016-09-29 00:25:46,250 - Static initialization is deprecated for interpreter
Ignite, You should change it to use interpreter-setting.json in your jar or
interpreter/{interpreter}/interpreter-setting.json INFO 2016-09-29 00:25:46,250
- Inclass=org.apache.zeppelin.ignite
And ensure that the Ignite related paragraphs run without any error
Screenshots (if appropriate)
Questions:
Does the licenses files need update? No
Is there breaking changes for older versions? No
Does this needs documentation? No
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/meenakshisekar/zeppelin ZEPPELIN-914
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1561.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1561
commit 57241368855c62a2975bd44852f77618ddffdbb1
Author: meenakshisekar
Date: 2016-10-24T12:40:12Z
Added interpreter setting and removed registration from interperter.
commit 640ad3020a53ce4fbd7965402e877c514232e0c2
Author: meenakshisekar
Date: 2016-10-24T12:44:43Z
Added interpreter setting file.
commit d7d846b1bc4f42b427cd69aa96e4d6ad195ee3a3
Author: meenakshisekar
Date: 2016-10-24T12:44:43Z
Added interpreter setting file.
commit 18ee9694fb295790171ccd2917ec32f93ef0d883
Author: meenakshisekar
Date: 2016-10-26T10:14:38Z
Corrected the type O
commit 7c328a17c6f043ba4fb3ca358390614cbb66750f
Author: meenakshisekar
Date: 2016-10-26T10:27:25Z
Added indentation
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1561: Zeppelin 914 Apply new mechanism to IgniteInter...
GitHub user meenakshisekar reopened a pull request:
https://github.com/apache/zeppelin/pull/1561
Zeppelin 914 Apply new mechanism to IgniteInterpreter
What is this PR for?
This handles replacing the registration of interpreter with static block by
the interpreter-setting.json file
What type of PR is it?
[| Improvement |
Todos
Sub-Task
What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-914
How should this be tested?
There shouldn't be any warning like below on starting the server
INFO 2016-09-29 00:25:46,247 - Bootstrapping Ignite Interpreter WARN
2016-09-29 00:25:46,250 - Static initialization is deprecated for interpreter
Ignite, You should change it to use interpreter-setting.json in your jar or
interpreter/{interpreter}/interpreter-setting.json INFO 2016-09-29 00:25:46,250
- Inclass=org.apache.zeppelin.ignite
And ensure that the Ignite related paragraphs run without any error
Screenshots (if appropriate)
Questions:
Does the licenses files need update? No
Is there breaking changes for older versions? No
Does this needs documentation? No
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/meenakshisekar/zeppelin ZEPPELIN-914
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1561.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1561
commit 57241368855c62a2975bd44852f77618ddffdbb1
Author: meenakshisekar
Date: 2016-10-24T12:40:12Z
Added interpreter setting and removed registration from interperter.
commit 640ad3020a53ce4fbd7965402e877c514232e0c2
Author: meenakshisekar
Date: 2016-10-24T12:44:43Z
Added interpreter setting file.
commit d7d846b1bc4f42b427cd69aa96e4d6ad195ee3a3
Author: meenakshisekar
Date: 2016-10-24T12:44:43Z
Added interpreter setting file.
commit 18ee9694fb295790171ccd2917ec32f93ef0d883
Author: meenakshisekar
Date: 2016-10-26T10:14:38Z
Corrected the type O
commit 7c328a17c6f043ba4fb3ca358390614cbb66750f
Author: meenakshisekar
Date: 2016-10-26T10:27:25Z
Added indentation
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1561: Zeppelin 914 Apply new mechanism to IgniteInterpreter
Github user meenakshisekar commented on the issue: https://github.com/apache/zeppelin/pull/1561 Reopening for travis build --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #1561: Zeppelin 914 Apply new mechanism to IgniteInter...
Github user meenakshisekar closed the pull request at: https://github.com/apache/zeppelin/pull/1561 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1548: [ZEPPELIN-917] Apply new mechanism to LensInterpreter
Github user meenakshisekar commented on the issue: https://github.com/apache/zeppelin/pull/1548 @AhyoungRyu I changed the indentation comment and checked the changes in the file again. Do you mean something different. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1548: [ZEPPELIN-917] Apply new mechanism to LensInterpreter
Github user meenakshisekar commented on the issue: https://github.com/apache/zeppelin/pull/1548 CI Build is green. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #1548: [ZEPPELIN-917] Apply new mechanism to LensInter...
GitHub user meenakshisekar reopened a pull request:
https://github.com/apache/zeppelin/pull/1548
[ZEPPELIN-917] Apply new mechanism to LensInterpreter
### What is this PR for?
This handles replacing the registration of interpreter with static block by
the interpreter-setting.json file
### What type of PR is it?
[| Improvement |
### Todos
Sub-Task
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-917
### How should this be tested?
here shouldn't be any warning like below on starting the server
INFO [2016-09-29 00:25:46,247] ({main} LensInterpreter.java[]:155)
- Bootstrapping Cassandra Interpreter WARN [2016-09-29 00:25:46,250] ({main}
Interpreter.java[register]:347) - Static initialization is deprecated for
interpreter lens, You should change it to use interpreter-setting.json in your
jar or interpreter/{interpreter}/interpreter-setting.json INFO [2016-09-29
00:25:46,250] ({main} InterpreterFactory.java[init]:204) -
Inclass=org.apache.zeppelin.lens.LensInterpreter
And ensure that the lens related paragraphs run without any error
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/meenakshisekar/zeppelin ZEPPELIN-917
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1548.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1548
commit db2827f867199cdd5e3fe2bc05f614dd88e013f5
Author: meenakshisekar
Date: 2016-10-21T09:59:38Z
Commented the properties in interpreter file and added setting file.
commit f94c8a3d44d441174fff2e89708e9ec62c1f5d22
Author: meenakshisekar
Date: 2016-10-21T11:41:58Z
Commented the properties in interpreter file and added setting file.
commit ad3b83ca856c54727f1ffef324f187f69a276c83
Author: meenakshisekar
Date: 2016-10-24T11:57:46Z
Added indentation
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1548: [ZEPPELIN-917] Apply new mechanism to LensInterpreter
Github user meenakshisekar commented on the issue: https://github.com/apache/zeppelin/pull/1548 reopening for Travis build. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #1548: [ZEPPELIN-917] Apply new mechanism to LensInter...
Github user meenakshisekar closed the pull request at: https://github.com/apache/zeppelin/pull/1548 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #1561: Zeppelin 914 Apply new mechanism to IgniteInter...
GitHub user meenakshisekar opened a pull request:
https://github.com/apache/zeppelin/pull/1561
Zeppelin 914 Apply new mechanism to IgniteInterpreter
What is this PR for?
This handles replacing the registration of interpreter with static block by
the interpreter-setting.json file
What type of PR is it?
[| Improvement |
Todos
Sub-Task
What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-914
How should this be tested?
There shouldn't be any warning like below on starting the server
INFO 2016-09-29 00:25:46,247 - Bootstrapping Ignite Interpreter WARN
2016-09-29 00:25:46,250 - Static initialization is deprecated for interpreter
Ignite, You should change it to use interpreter-setting.json in your jar or
interpreter/{interpreter}/interpreter-setting.json INFO 2016-09-29 00:25:46,250
- Inclass=org.apache.zeppelin.ignite
And ensure that the Ignite related paragraphs run without any error
Screenshots (if appropriate)
Questions:
Does the licenses files need update? No
Is there breaking changes for older versions? No
Does this needs documentation? No
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/meenakshisekar/zeppelin ZEPPELIN-914
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1561.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1561
commit 57241368855c62a2975bd44852f77618ddffdbb1
Author: meenakshisekar
Date: 2016-10-24T12:40:12Z
Added interpreter setting and removed registration from interperter.
commit 640ad3020a53ce4fbd7965402e877c514232e0c2
Author: meenakshisekar
Date: 2016-10-24T12:44:43Z
Added interpreter setting file.
commit d7d846b1bc4f42b427cd69aa96e4d6ad195ee3a3
Author: meenakshisekar
Date: 2016-10-24T12:44:43Z
Added interpreter setting file.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1548: [ZEPPELIN-917] Apply new mechanism to LensInter...
Github user meenakshisekar closed the pull request at: https://github.com/apache/zeppelin/pull/1548 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #1548: [ZEPPELIN-917] Apply new mechanism to LensInter...
GitHub user meenakshisekar reopened a pull request:
https://github.com/apache/zeppelin/pull/1548
[ZEPPELIN-917] Apply new mechanism to LensInterpreter
### What is this PR for?
This handles replacing the registration of interpreter with static block by
the interpreter-setting.json file
### What type of PR is it?
[| Improvement |
### Todos
Sub-Task
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-917
### How should this be tested?
here shouldn't be any warning like below on starting the server
INFO [2016-09-29 00:25:46,247] ({main} LensInterpreter.java[]:155)
- Bootstrapping Cassandra Interpreter WARN [2016-09-29 00:25:46,250] ({main}
Interpreter.java[register]:347) - Static initialization is deprecated for
interpreter lens, You should change it to use interpreter-setting.json in your
jar or interpreter/{interpreter}/interpreter-setting.json INFO [2016-09-29
00:25:46,250] ({main} InterpreterFactory.java[init]:204) -
Inclass=org.apache.zeppelin.lens.LensInterpreter
And ensure that the lens related paragraphs run without any error
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/meenakshisekar/zeppelin ZEPPELIN-917
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1548.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1548
commit db2827f867199cdd5e3fe2bc05f614dd88e013f5
Author: meenakshisekar
Date: 2016-10-21T09:59:38Z
Commented the properties in interpreter file and added setting file.
commit f94c8a3d44d441174fff2e89708e9ec62c1f5d22
Author: meenakshisekar
Date: 2016-10-21T11:41:58Z
Commented the properties in interpreter file and added setting file.
commit ad3b83ca856c54727f1ffef324f187f69a276c83
Author: meenakshisekar
Date: 2016-10-24T11:57:46Z
Added indentation
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1548: Commented the properties in interpreter file an...
GitHub user meenakshisekar opened a pull request:
https://github.com/apache/zeppelin/pull/1548
Commented the properties in interpreter file and added setting file.
### What is this PR for?
This handles replacing the registration of interpreter with static block by
the interpreter-setting.json file
### What type of PR is it?
[| Improvement |
### Todos
Sub-Task
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-917
### How should this be tested?
here shouldn't be any warning like below on starting the server
INFO [2016-09-29 00:25:46,247] ({main} LensInterpreter.java[]:155)
- Bootstrapping Cassandra Interpreter WARN [2016-09-29 00:25:46,250] ({main}
Interpreter.java[register]:347) - Static initialization is deprecated for
interpreter lens, You should change it to use interpreter-setting.json in your
jar or interpreter/{interpreter}/interpreter-setting.json INFO [2016-09-29
00:25:46,250] ({main} InterpreterFactory.java[init]:204) -
Inclass=org.apache.zeppelin.lens.LensInterpreter
And ensure that the lens related paragraphs run without any error
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/meenakshisekar/zeppelin ZEPPELIN-917
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1548.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1548
commit db2827f867199cdd5e3fe2bc05f614dd88e013f5
Author: meenakshisekar
Date: 2016-10-21T09:59:38Z
Commented the properties in interpreter file and added setting file.
commit f94c8a3d44d441174fff2e89708e9ec62c1f5d22
Author: meenakshisekar
Date: 2016-10-21T11:41:58Z
Commented the properties in interpreter file and added setting file.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1522: [ ZEPPELIN-1461 ] Doesn't display "description" value ...
Github user meenakshisekar commented on the issue:
https://github.com/apache/zeppelin/pull/1522
@kjhong
The changes looks good to me, but here are few suggestions from my side.
* Felt that the Description field need to be editable. How about displaying
in a textArea?
* How about Storing the description as a separate set of key value pairs ?
so that it is completely readable.
For ex:
Currently **after your changes,** the json might look like
_"properties": {
"hdfs.maxlength": "1000",
"hdfs.user": "hdfs",
"hdfs.maxlength-description": "1000",
"hdfs.user-description": "hdfs",
},_
Instead if we store them as a different set of key value pairs the json
might look like,
_"properties": {
"hdfs.maxlength": "1000",
"hdfs.user": "hdfs",
},
and
"properties-description": {
"hdfs.maxlength": "1000",
"hdfs.user": "hdfs",
},_
which will be more readable and straight forward.
From **future changes** perspective, this will benefit us when
* There is an additional field getting added other than description
* When someone is calling the restApi (createInterpreter) of this via tools
like postman the datastructure will be clearly defined and easy to use instead
of complicating the values inside the same properties datastructure.
Let me know your views on these.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1445: [Zeppelin-1001] Take care of comma/tab escape in csv/t...
Github user meenakshisekar commented on the issue: https://github.com/apache/zeppelin/pull/1445 OOPS ! It is meenakshi.chandrase...@imaginea.com --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1445: [Zeppelin-1001] Take care of comma/tab escape in csv/t...
Github user meenakshisekar commented on the issue: https://github.com/apache/zeppelin/pull/1445 @corneadoug My jira user name is meenakshisekar --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1445: [Zeppelin-1001] Take care of comma/tab escape in csv/t...
Github user meenakshisekar commented on the issue: https://github.com/apache/zeppelin/pull/1445 @corneadoug Please go ahead with merge. Now CI has also passed --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1445: [Zeppelin-1001] Take care of comma/tab escape in csv/t...
Github user meenakshisekar commented on the issue: https://github.com/apache/zeppelin/pull/1445 @corneadoug working on this --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #1445: [Zeppelin-1001] Take care of comma/tab escape i...
GitHub user meenakshisekar reopened a pull request: https://github.com/apache/zeppelin/pull/1445 [Zeppelin-1001] Take care of comma/tab escape in csv/tsv download ### What is this PR for? When the data is downloaded as CSV/TSV, the comma/tab in the actual data has to be handled so that they come exactly as the same data when downloaded. ### What type of PR is it? [Bug Fix] ### Todos * [ ] - Task ### What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-1001 ### How should this be tested? Modify the data to be loaded to have a comma. Create a paragraph to pull up that data and display. Now click on the download as CSV/TSV button in the tool bar. Once the data is downloaded verify whether the original data is unaltered and the comma is escaped. ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No You can merge this pull request into a Git repository by running: $ git pull https://github.com/meenakshisekar/zeppelin ZEPPELIN-1001 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/1445.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1445 commit 73b1868dbf60d2ee1fb90bd0f168a64858d3593b Author: meenakshisekar Date: 2016-09-19T11:16:12Z Zeppelin-1001 Modified the data with comma/tab to be surronded by double quotes so that they are escaped. commit 657dcbee8cc3aafc70c7f73378efc560e93afccd Author: meenakshisekar Date: 2016-09-19T11:16:12Z Zeppelin-1001 Modified the data with comma/tab to be surronded by double quotes so that they are escaped. commit 2f7d78a74bc23507df89dd912e3d0b9e3a041980 Author: meenakshisekar Date: 2016-09-29T06:59:04Z Altered the code as per PR suggestion 1465 commit ce27b826fa8636891fa9530e7d6cf929465e2c8b Author: meenakshisekar Date: 2016-09-29T07:08:40Z Changes committed as per review comments in PR commit 5e14da8052cf00c025062637590347c256ca3f6d Author: meenakshisekar Date: 2016-09-29T07:16:39Z review comments fixed --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #1445: [Zeppelin-1001] Take care of comma/tab escape i...
Github user meenakshisekar closed the pull request at: https://github.com/apache/zeppelin/pull/1445 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1445: [Zeppelin-1001] Take care of comma/tab escape in csv/t...
Github user meenakshisekar commented on the issue: https://github.com/apache/zeppelin/pull/1445 CI build passed! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #1445: [Zeppelin-1001] Take care of comma/tab escape i...
GitHub user meenakshisekar reopened a pull request: https://github.com/apache/zeppelin/pull/1445 [Zeppelin-1001] Take care of comma/tab escape in csv/tsv download ### What is this PR for? When the data is downloaded as CSV/TSV, the comma/tab in the actual data has to be handled so that they come exactly as the same data when downloaded. ### What type of PR is it? [Bug Fix] ### Todos * [ ] - Task ### What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-1001 ### How should this be tested? Modify the data to be loaded to have a comma. Create a paragraph to pull up that data and display. Now click on the download as CSV/TSV button in the tool bar. Once the data is downloaded verify whether the original data is unaltered and the comma is escaped. ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No You can merge this pull request into a Git repository by running: $ git pull https://github.com/meenakshisekar/zeppelin ZEPPELIN-1001 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/1445.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1445 commit 73b1868dbf60d2ee1fb90bd0f168a64858d3593b Author: meenakshisekar Date: 2016-09-19T11:16:12Z Zeppelin-1001 Modified the data with comma/tab to be surronded by double quotes so that they are escaped. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #1445: [Zeppelin-1001] Take care of comma/tab escape i...
Github user meenakshisekar closed the pull request at: https://github.com/apache/zeppelin/pull/1445 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1445: [Zeppelin-1001] Take care of comma/tab escape in csv/t...
Github user meenakshisekar commented on the issue: https://github.com/apache/zeppelin/pull/1445 Re opening the pull request to run CI build. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #1445: [Zeppelin-1001] Take care of comma/tab escape i...
Github user meenakshisekar closed the pull request at: https://github.com/apache/zeppelin/pull/1445 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #1445: [Zeppelin-1001] Take care of comma/tab escape i...
GitHub user meenakshisekar reopened a pull request: https://github.com/apache/zeppelin/pull/1445 [Zeppelin-1001] Take care of comma/tab escape in csv/tsv download ### What is this PR for? When the data is downloaded as CSV/TSV, the comma/tab in the actual data has to be handled so that they come exactly as the same data when downloaded. ### What type of PR is it? [Bug Fix] ### Todos * [ ] - Task ### What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-1001 ### How should this be tested? Modify the data to be loaded to have a comma. Create a paragraph to pull up that data and display. Now click on the download as CSV/TSV button in the tool bar. Once the data is downloaded verify whether the original data is unaltered and the comma is escaped. ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No You can merge this pull request into a Git repository by running: $ git pull https://github.com/meenakshisekar/zeppelin ZEPPELIN-1001 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/1445.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1445 commit 73b1868dbf60d2ee1fb90bd0f168a64858d3593b Author: meenakshisekar Date: 2016-09-19T11:16:12Z Zeppelin-1001 Modified the data with comma/tab to be surronded by double quotes so that they are escaped. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1445: [Zeppelin-1001] Take care of comma/tab escape in csv/t...
Github user meenakshisekar commented on the issue: https://github.com/apache/zeppelin/pull/1445 Re opening the pull request to run CI build. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1445: [Zeppelin-1001] Take care of comma/tab escape in csv/t...
Github user meenakshisekar commented on the issue: https://github.com/apache/zeppelin/pull/1445 Re opening the pull request to run CI build. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #1445: [Zeppelin-1001] Take care of comma/tab escape i...
GitHub user meenakshisekar reopened a pull request: https://github.com/apache/zeppelin/pull/1445 [Zeppelin-1001] Take care of comma/tab escape in csv/tsv download ### What is this PR for? When the data is downloaded as CSV/TSV, the comma/tab in the actual data has to be handled so that they come exactly as the same data when downloaded. ### What type of PR is it? [Bug Fix] ### Todos * [ ] - Task ### What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-1001 ### How should this be tested? Modify the data to be loaded to have a comma. Create a paragraph to pull up that data and display. Now click on the download as CSV/TSV button in the tool bar. Once the data is downloaded verify whether the original data is unaltered and the comma is escaped. ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No You can merge this pull request into a Git repository by running: $ git pull https://github.com/meenakshisekar/zeppelin ZEPPELIN-1001 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/1445.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1445 commit 73b1868dbf60d2ee1fb90bd0f168a64858d3593b Author: meenakshisekar Date: 2016-09-19T11:16:12Z Zeppelin-1001 Modified the data with comma/tab to be surronded by double quotes so that they are escaped. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #1445: [Zeppelin-1001] Take care of comma/tab escape i...
Github user meenakshisekar closed the pull request at: https://github.com/apache/zeppelin/pull/1445 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1445: [Zeppelin-1001] Take care of comma/tab escape in csv/t...
Github user meenakshisekar commented on the issue: https://github.com/apache/zeppelin/pull/1445 @corneadoug Based on your comments i shall proceed further. Thanks, Meenakshi --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin issue #1445: [Zeppelin-1001] Take care of comma/tab escape in csv/t...
Github user meenakshisekar commented on the issue: https://github.com/apache/zeppelin/pull/1445 @corneadoug I'm working towards that. Shall let you know once it is done. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] zeppelin pull request #1445: [Zeppelin-1001] Take care of comma/tab escape i...
GitHub user meenakshisekar opened a pull request: https://github.com/apache/zeppelin/pull/1445 [Zeppelin-1001] Take care of comma/tab escape in csv/tsv download ### What is this PR for? When the data is downloaded as CSV/TSV, the comma/tab in the actual data has to be handled so that they come exactly as the same data when downloaded. ### What type of PR is it? [Bug Fix] ### Todos * [ ] - Task ### What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-1001 ### How should this be tested? Modify the data to be loaded to have a comma. Create a paragraph to pull up that data and display. Now click on the download as CSV/TSV button in the tool bar. Once the data is downloaded verify whether the original data is unaltered and the comma is escaped. ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No You can merge this pull request into a Git repository by running: $ git pull https://github.com/meenakshisekar/zeppelin ZEPPELIN-1001 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/1445.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1445 commit 73b1868dbf60d2ee1fb90bd0f168a64858d3593b Author: meenakshisekar Date: 2016-09-19T11:16:12Z Zeppelin-1001 Modified the data with comma/tab to be surronded by double quotes so that they are escaped. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
