[GitHub] zeppelin issue #2816: [ZEPPELIN-3263] Do not use Firefox >=55 for integratio...
Github user mephi42 commented on the issue: https://github.com/apache/zeppelin/pull/2816 Hi @jongyoul, sorry, I'm afraid I won't have time to finish this anytime soon. That said, the first 7 patches, which improve stability and performance of the test suite, are ready as far as I'm concerned. Maybe you could give them a try and get them in in case they look good? ---
[GitHub] zeppelin issue #2816: [ZEPPELIN-3263] Do not use Firefox >=55 for integratio...
Github user mephi42 commented on the issue: https://github.com/apache/zeppelin/pull/2816 Another update. This is now more than just FF>=55 disablement, so maybe I should rename the pull request. I tried to split the work into meaningful chunks, so if you think some commits are worth integrating right away, I can send them as separate pull requests. ---
[GitHub] zeppelin issue #2816: [ZEPPELIN-3263] Do not use Firefox >=55 for integratio...
Github user mephi42 commented on the issue: https://github.com/apache/zeppelin/pull/2816 I just pushed my WIP branch. With those changes things look better locally, but there are still issues. ---
[GitHub] zeppelin issue #2816: [ZEPPELIN-3263] Do not use Firefox >=55 for integratio...
Github user mephi42 commented on the issue: https://github.com/apache/zeppelin/pull/2816 @zjffdu I'm currently trying to stabilize them on my local machine. There are still a couple things that need debugging - the worst one being that sometimes click() on e.g. Login button produces no effect. @felixcheung, to me this is a useful safeguard when running locally and new Firefox is by accident in $PATH. ---
[GitHub] zeppelin pull request #2816: [ZEPPELIN-3263] Do not use Firefox >=55 for int...
GitHub user mephi42 opened a pull request: https://github.com/apache/zeppelin/pull/2816 [ZEPPELIN-3263] Do not use Firefox >=55 for integration testing ### What is this PR for? According to https://seleniumhq.wordpress.com/2017/08/09/firefox-55-and-selenium-ide , Firefox versions 55+ do not work with Selenium, so I would like to propose to skip them when creating the WebDriver. ### What type of PR is it? Improvement ### What is the Jira issue? * https://issues.apache.org/jira/browse/ZEPPELIN-3263 ### How should this be tested? * Run zeppelin-integration tests on the machine, where Firefox 55+ is installed. ### Questions: * Does the licenses files need update? No * Is there breaking changes for older versions? No * Does this needs documentation? No You can merge this pull request into a Git repository by running: $ git pull https://github.com/mephi42/zeppelin skip-firefox-55 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/2816.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2816 commit 2d2ca8a4042999b98bca8562af429fb35f8c4bdb Author: mephi42 <mephi42@...> Date: 2018-02-24T15:30:22Z [ZEPPELIN-3263] Do not use Firefox >=55 for integration testing It is not supported by Selenium. ---
[jira] [Created] (ZEPPELIN-3263) Do not use Firefox >=55 for integration testing
mephi42 created ZEPPELIN-3263: - Summary: Do not use Firefox >=55 for integration testing Key: ZEPPELIN-3263 URL: https://issues.apache.org/jira/browse/ZEPPELIN-3263 Project: Zeppelin Issue Type: Test Components: CI-infra Affects Versions: 0.7.3 Reporter: mephi42 I'm currently debugging locally why do integration tests fail for [https://github.com/apache/zeppelin/pull/2679] One of the problems in my setup was that I use Firefox 59, and Selenium simply hangs with it. At the same time, Chrome and Safari work fine. According to [https://seleniumhq.wordpress.com/2017/08/09/firefox-55-and-selenium-ide] , Firefox versions 55+ do not work with Selenium, so I would propose to skip them when creating the WebDriver. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] zeppelin pull request #2815: [ZEPPELIN-3262] Make install_external_dependenc...
GitHub user mephi42 opened a pull request: https://github.com/apache/zeppelin/pull/2815 [ZEPPELIN-3262] Make install_external_dependencies.sh work on macOS ### What is this PR for? This original purpose of this script is to setup Travis environment, but it's also useful for local development. Also make it possible to run this script multiple times. ### What type of PR is it? Improvement ### What is the Jira issue? * https://issues.apache.org/jira/browse/ZEPPELIN-3262 ### How should this be tested? * Run ./testing/install_external_dependencies.sh ### Questions: * Does the licenses files need update? - No * Is there breaking changes for older versions? - No * Does this needs documentation? - No You can merge this pull request into a Git repository by running: $ git pull https://github.com/mephi42/zeppelin install-external-dependencies-macos Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/2815.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2815 commit bc34749ef94261eb01424f81f310bb9f561ad477 Author: mephi42 <mephi42@...> Date: 2018-02-24T11:37:04Z [ZEPPELIN-3262] Make install_external_dependencies.sh work on macOS This original purpose of this script is to setup Travis environment, but it's also useful for local development. Also make it possible to run this script multiple times. ---
[jira] [Created] (ZEPPELIN-3262) Make install_external_dependencies.sh work on macOS
mephi42 created ZEPPELIN-3262: - Summary: Make install_external_dependencies.sh work on macOS Key: ZEPPELIN-3262 URL: https://issues.apache.org/jira/browse/ZEPPELIN-3262 Project: Zeppelin Issue Type: Test Components: CI-infra Affects Versions: 0.7.3 Reporter: mephi42 This original purpose of this script is to setup Travis environment, but it's also useful for local development. I would like to send a pull request with this improvement. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] zeppelin issue #2679: [ZEPPELIN-3047] Let Firefox remember login and passwor...
Github user mephi42 commented on the issue: https://github.com/apache/zeppelin/pull/2679 Looks better this time, but one of sub-builds has timed out. I will push a dummy change to regtigger it. ---
[GitHub] zeppelin issue #2679: [ZEPPELIN-3047] Let Firefox remember login and passwor...
Github user mephi42 commented on the issue: https://github.com/apache/zeppelin/pull/2679 Improved the implementation: before it used form hiding for Chrome, and now it simply changes that action, which is not used anyway. Also made sure that even though this change removes the code from the newly added "enter from username" change, the functionality still works: one can use enter from both username and password fields in order to submit the form. ---
[GitHub] zeppelin issue #2679: [ZEPPELIN-3047] Let Firefox remember login and passwor...
Github user mephi42 commented on the issue: https://github.com/apache/zeppelin/pull/2679 After some tinkering I managed to make it work in Firefox, Chrome and Safari on Mac. ---
[GitHub] zeppelin pull request #2679: [ZEPPELIN-3047] Let Firefox remember login and ...
GitHub user mephi42 opened a pull request: https://github.com/apache/zeppelin/pull/2679 [ZEPPELIN-3047] Let Firefox remember login and password ### What is this PR for? It makes Zeppelin login window compatible with Firefox password manager, as explained here: https://stackoverflow.com/questions/18586938/remember-password-with-angularjs-and-ng-submit ### What type of PR is it? Improvement ### What is the Jira issue? * https://issues.apache.org/jira/browse/ZEPPELIN-3047 ### How should this be tested? * Open login window in Firefox, type anything. A suggestion to save username and password should appear. ### Questions: * Does the licenses files need update? - No * Is there breaking changes for older versions? - No * Does this needs documentation? - No You can merge this pull request into a Git repository by running: $ git pull https://github.com/mephi42/zeppelin remember-password Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/2679.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2679 commit acf6f25b387b156ee4dbf68d6f2a18a8cb0f551e Author: mephi42 <meph...@gmail.com> Date: 2017-11-18T14:06:10Z Let Firefox remember login and password https://stackoverflow.com/questions/18586938/remember-password-with-angularjs-and-ng-submit ---
[jira] [Created] (ZEPPELIN-3047) Make login dialog compatible with built-in Firefox password manager
mephi42 created ZEPPELIN-3047: - Summary: Make login dialog compatible with built-in Firefox password manager Key: ZEPPELIN-3047 URL: https://issues.apache.org/jira/browse/ZEPPELIN-3047 Project: Zeppelin Issue Type: Improvement Components: security Affects Versions: 0.7.3 Reporter: mephi42 Priority: Minor Currently Firefox does not offer to remember Zeppelin username and password. I found the following discussion regarding that on StackOverflow: https://stackoverflow.com/questions/2398763/how-does-browser-know-when-to-prompt-user-to-save-password If I understand it correctly, Firefox wants username and password fields to be part of a , which is currently not the case. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
