[GitHub] zeppelin issue #2884: trim property name of interpreter settings
Github user rockiee281 commented on the issue: https://github.com/apache/zeppelin/pull/2884 Hi, @r-kamath the duplicated PR closed nowã Please review this PR. thanks ---
[GitHub] zeppelin pull request #2870: [ZEPPELIN-3335] trim property name of interpret...
Github user rockiee281 closed the pull request at: https://github.com/apache/zeppelin/pull/2870 ---
[GitHub] zeppelin issue #2870: [ZEPPELIN-3335] trim property name of interpreter sett...
Github user rockiee281 commented on the issue: https://github.com/apache/zeppelin/pull/2870 Sorry, I'm not familiar with git rebase ,create PR #2884 instead ---
[GitHub] zeppelin pull request #2884: trim property name of interpreter settings
GitHub user rockiee281 opened a pull request: https://github.com/apache/zeppelin/pull/2884 trim property name of interpreter settings ### What is this PR for? trim property name of interpreter settings ### What type of PR is it? Improvement ### Todos * [x] - Task ### What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-3335 ### How should this be tested? * First time? Setup Travis CI as described on https://zeppelin.apache.org/contribution/contributions.html#continuous-integration * Strongly recommended: add automated unit tests for any new or changed behavior * Outline any manual steps to test the PR here. ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? * Is there breaking changes for older versions? * Does this needs documentation? You can merge this pull request into a Git repository by running: $ git pull https://github.com/rockiee281/zeppelin ZEPPELIN-3335-fix Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/2884.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2884 ---
[GitHub] zeppelin issue #2870: [ZEPPELIN-3335] trim property name of interpreter sett...
Github user rockiee281 commented on the issue: https://github.com/apache/zeppelin/pull/2870 Hiï¼ @zjffdu rebase done ---
[GitHub] zeppelin issue #2870: [ZEPPELIN-3335] trim property name of interpreter sett...
Github user rockiee281 commented on the issue: https://github.com/apache/zeppelin/pull/2870 @felixcheung Hi, I check the build errors but seems those error was caused by other codes on the master branch. Should I wait until others resolve those problems? ---
[GitHub] zeppelin pull request #2870: [ZEPPELIN-3335] trim property name of interpret...
GitHub user rockiee281 opened a pull request: https://github.com/apache/zeppelin/pull/2870 [ZEPPELIN-3335] trim property name of interpreter settings ### What is this PR for? trim property name of interpreter settings ### What type of PR is it? Improvement ### Todos * [ ] - Task ### What is the Jira issue? https://issues.apache.org/jira/browse/ZEPPELIN-3335 ### How should this be tested? * First time? Setup Travis CI as described on https://zeppelin.apache.org/contribution/contributions.html#continuous-integration * Strongly recommended: add automated unit tests for any new or changed behavior * Outline any manual steps to test the PR here. ### Screenshots (if appropriate) ### Questions: * Does the licenses files need update? * Is there breaking changes for older versions? * Does this needs documentation? You can merge this pull request into a Git repository by running: $ git pull https://github.com/rockiee281/zeppelin ZEPPELIN-3335 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/2870.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2870 commit df2ce972907c62a697761e4591afcf3b19489499 Author: yunl.li Date: 2018-03-15T02:53:10Z trim properties when setting commit d4adec1ca946c1a6d9671422b7aad60784c5c345 Author: yunl.li Date: 2018-03-15T02:56:00Z remove blank line ---