[GitHub] zeppelin issue #2695: [ZEPPELIN-3089] Create user folders under Trash folder

2017-12-11 Thread yu74n 
Github user yu74n commented on the issue:

https://github.com/apache/zeppelin/pull/2695
  
Whether a user can find the notebook in trash or not is based on permission 
of the notebook, then If user 'B' has properly permission for the notebook 
deleted by user 'A', user 'B' can find the notebook in trash.
However, I find some issues in this PR. For example, user 'A' delete a 
notebook, then user 'B' restore the notebook from trash. In this PR, even if 
user 'B' has 'owner' permission for the notebook, cannot do that.


---

[GitHub] zeppelin issue #2695: [ZEPPELIN-3089] Create user folders under Trash folder

2017-12-05 Thread yu74n 
Github user yu74n commented on the issue:

https://github.com/apache/zeppelin/pull/2695
  
Yes, the default is anonymous. 
Deleted files will be moved under  ~Trash/anonymous/ folder.


---

[GitHub] zeppelin pull request #2695: [ZEPPELIN-3089] Create user folders under Trash...

2017-12-04 Thread yu74n 
GitHub user yu74n opened a pull request:

https://github.com/apache/zeppelin/pull/2695

[ZEPPELIN-3089] Create user folders under Trash folder

### What is this PR for?
In the situation where multi users a create notebook, "Empty Trash" button 
next to "Trash" folder on Top page is not working because "Empty Trash" button 
tries to delete all notebooks in Trash folder. which includes notebook no owner 
and no writer permission.

For resolving this issue, create a user folder under Trash folder, and 
"Empty Trash" button deletes all notebooks in a user folder, while "Restore" 
button restore all notebooks in a user folder.

### What type of PR is it?
Bug Fix

### What is the Jira issue?
* Open an issue on Jira https://issues.apache.org/jira/browse/ZEPPELIN-3089

### How should this be tested?
1. Login as user 'A' and create a notebook 'A'
2. Move notebook 'A' to Trash
3. Login as user 'B' and create a notebook 'B'
4. Move notebook 'B' to Trash
5. Click 'Empty Trash' button next to 'Trash' folder

### Screenshots (if appropriate)
https://user-images.githubusercontent.com/4197465/33562137-ccc3e358-d957-11e7-980e-253efaa5cd62.png";>

### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/yu74n/zeppelin trash-box-per-user

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/2695.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2695


commit 30bd15231d5cda7cfeb729dc21b13a9a47d1d99a
Author: Yuta Hongo 
Date:   2017-12-04T11:40:49Z

Delete all notes under the user folder on executing Empty Trash

commit af678acd9469ffa03061f0c476b2a7804477c38a
Author: Yuta Hongo 
Date:   2017-12-04T15:37:54Z

Resolve line length error




---

[GitHub] zeppelin pull request #2416: [ZEPPELIN-2647] Set admin user as owner when us...

2017-11-15 Thread yu74n 
Github user yu74n closed the pull request at:

https://github.com/apache/zeppelin/pull/2416


---

[GitHub] zeppelin issue #2416: [ZEPPELIN-2647] Set admin user as owner when user crea...

2017-11-15 Thread yu74n 
Github user yu74n commented on the issue:

https://github.com/apache/zeppelin/pull/2416
  
Close this PR because Continued at #2585


---

[GitHub] zeppelin pull request #2525: [ZEPPELIN-2647] Make admin role to bypass auth ...

2017-11-15 Thread yu74n 
Github user yu74n closed the pull request at:

https://github.com/apache/zeppelin/pull/2525


---

[GitHub] zeppelin issue #2525: [ZEPPELIN-2647] Make admin role to bypass auth logic

2017-11-15 Thread yu74n 
Github user yu74n commented on the issue:

https://github.com/apache/zeppelin/pull/2525
  
Close this PR because Continued at #2585


---

[GitHub] zeppelin issue #2585: [ZEPPELIN-2647] Bypass auth logic when a user logins a...

2017-11-09 Thread yu74n 
Github user yu74n commented on the issue:

https://github.com/apache/zeppelin/pull/2585
  
CI failed at testRunOnSelectionChange()
```bash
java.lang.AssertionError: Even if 'RunOnSelectionChange' is set as false, 
still can run the paragraph by pressing ENTER 
Expected: "My selection is 1"
but: was "My selection is 2"
```
This test is related to 'Run on selection change' checkbox in paragraph 
menu.
I think the reason why that test is failed would be timing error,  cause of 
the test code ran the paragraph before the checkbox was unchecked. Then I think 
the test is not related to my PR.

I rerun the CI job manually, all tests are passed.
https://travis-ci.org/yu74n/zeppelin/builds/299517426




---

[GitHub] zeppelin issue #2585: [ZEPPELIN-2647] Bypass auth logic when a user logins a...

2017-11-08 Thread yu74n 
Github user yu74n commented on the issue:

https://github.com/apache/zeppelin/pull/2585
  
Actually, I thought so too when I explained how if the owner name is blank. 
I've fixed that.
I've changed config template to be disable admin role.
Can you review that again?
@felixcheung 



---

[GitHub] zeppelin issue #2585: [ZEPPELIN-2647] Bypass auth logic when a user logins a...

2017-11-07 Thread yu74n 
Github user yu74n commented on the issue:

https://github.com/apache/zeppelin/pull/2585
  
if set blank as default owner username, apply blank('') to the admin role. 
but, I think, a user cannot set blank as login user name. so nearly equal as 
disable admin role.


---

[GitHub] zeppelin pull request #2585: [ZEPPELIN-2647] Bypass auth logic when a user l...

2017-11-06 Thread yu74n 
GitHub user yu74n reopened a pull request:

https://github.com/apache/zeppelin/pull/2585

[ZEPPELIN-2647] Bypass auth logic when a user logins as admin role

### What is this PR for?
For administrator, make new admin role that assigned user can see all 
notebooks.

### What type of PR is it?
Improvement

### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-2647

### How should this be tested?
1. Set role name to use as admin through ZEPPELIN_OWNER_ROLE =  
or zeppelin.owner.role = .
Default role name is admin
2. Login as user who is not assigned as admin and create notebook.
3. Logout the user and login another user who is assigned as admin, open 
the created notebook.

### Questions:
* Does the licenses files need update? N
* Is there breaking changes for older versions? Y/N
* Does this needs documentation? Y


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/yu74n/zeppelin bypass-auth-logic

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/2585.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2585


commit 26b818c4b09145c8814cf63af573f0af513e8ea2
Author: Yuta Hongo 
Date:   2017-08-10T01:38:01Z

Make admin role to bypass auth logic

commit 98a9de06173643b8f13cfd80fc5570bb78d7feb0
Author: Yuta Hongo 
Date:   2017-09-26T05:04:40Z

Rename property name

commit 532a49fb92e1ad092918e23a96c9c255ff671a5d
Author: Yuta Hongo 
Date:   2017-11-06T10:54:29Z

Set blank as default.owner.username default value




---

[GitHub] zeppelin pull request #2585: [ZEPPELIN-2647] Bypass auth logic when a user l...

2017-11-06 Thread yu74n 
Github user yu74n closed the pull request at:

https://github.com/apache/zeppelin/pull/2585


---

[GitHub] zeppelin issue #2585: [ZEPPELIN-2647] Bypass auth logic when a user logins a...

2017-11-06 Thread yu74n 
Github user yu74n commented on the issue:

https://github.com/apache/zeppelin/pull/2585
  
I've changed default value is blank.
if set blank as zeppelin.notebook.default.owner.username, disable admin 
role.


---

[GitHub] zeppelin issue #2585: [ZEPPELIN-2647] Bypass auth logic when a user logins a...

2017-11-05 Thread yu74n 
Github user yu74n commented on the issue:

https://github.com/apache/zeppelin/pull/2585
  
@felixcheung if unset zeppelin.notebook.default.owner.username, set 'admin' 
as default value. 

https://github.com/apache/zeppelin/pull/2585/files#diff-179ea3a816210bb9904baabec1a552e4R716


---

[GitHub] zeppelin issue #2585: [ZEPPELIN-2647] Bypass auth logic when a user logins a...

2017-11-02 Thread yu74n 
Github user yu74n commented on the issue:

https://github.com/apache/zeppelin/pull/2585
  
What do you think about that? @1ambda @felixcheung 


---

[GitHub] zeppelin issue #2585: [ZEPPELIN-2647] Bypass auth logic when a user logins a...

2017-11-02 Thread yu74n 
Github user yu74n commented on the issue:

https://github.com/apache/zeppelin/pull/2585
  
and rerun the failed travis job manually, the job is passed.
https://travis-ci.org/yu74n/zeppelin/jobs/295676369


---

[GitHub] zeppelin issue #2585: [ZEPPELIN-2647] Bypass auth logic when a user logins a...

2017-11-01 Thread yu74n 
Github user yu74n commented on the issue:

https://github.com/apache/zeppelin/pull/2585
  
All tests are passed, but NotebookTest has an error.
java.lang.RuntimeException: 
org.apache.thrift.transport.TTransportException: java.net.SocketException: 
Connection reset


---

[GitHub] zeppelin issue #2585: [ZEPPELIN-2647] Bypass auth logic when a user logins a...

2017-10-18 Thread yu74n 
Github user yu74n commented on the issue:

https://github.com/apache/zeppelin/pull/2585
  
Rerun all tests. 
'testPerUserScopedAction' is passed this time, but other 4 tests is failed.
These 4 tests was passed before.


---

[GitHub] zeppelin pull request #2585: [ZEPPELIN-2647] Bypass auth logic when a user l...

2017-10-12 Thread yu74n 
GitHub user yu74n reopened a pull request:

https://github.com/apache/zeppelin/pull/2585

[ZEPPELIN-2647] Bypass auth logic when a user logins as admin role

### What is this PR for?
For administrator, make new admin role that assigned user can see all 
notebooks.

### What type of PR is it?
Improvement

### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-2647

### How should this be tested?
1. Set role name to use as admin through ZEPPELIN_OWNER_ROLE =  
or zeppelin.owner.role = .
Default role name is admin
2. Login as user who is not assigned as admin and create notebook.
3. Logout the user and login another user who is assigned as admin, open 
the created notebook.

### Questions:
* Does the licenses files need update? N
* Is there breaking changes for older versions? Y/N
* Does this needs documentation? Y


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/yu74n/zeppelin bypass-auth-logic

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/2585.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2585


commit d3e9dcab1bc2efc355140857b91a08bb2035bb69
Author: Yuta Hongo 
Date:   2017-08-10T01:38:01Z

Make admin role to bypass auth logic

commit cfcea0dc5f7d16aecc7e9a8249a01bcb63c38952
Author: Yuta Hongo 
Date:   2017-09-26T05:04:40Z

Rename property name




---

[GitHub] zeppelin pull request #2585: [ZEPPELIN-2647] Bypass auth logic when a user l...

2017-10-12 Thread yu74n 
Github user yu74n closed the pull request at:

https://github.com/apache/zeppelin/pull/2585


---

[GitHub] zeppelin issue #2585: [ZEPPELIN-2647] Bypass auth logic when a user logins a...

2017-10-12 Thread yu74n 
Github user yu74n commented on the issue:

https://github.com/apache/zeppelin/pull/2585
  
test


---

[GitHub] zeppelin pull request #2585: [ZEPPELIN-2647] Bypass auth logic when a user l...

2017-10-12 Thread yu74n 
GitHub user yu74n reopened a pull request:

https://github.com/apache/zeppelin/pull/2585

[ZEPPELIN-2647] Bypass auth logic when a user logins as admin role

### What is this PR for?
For administrator, make new admin role that assigned user can see all 
notebooks.

### What type of PR is it?
Improvement

### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-2647

### How should this be tested?
1. Set role name to use as admin through ZEPPELIN_OWNER_ROLE =  
or zeppelin.owner.role = .
Default role name is admin
2. Login as user who is not assigned as admin and create notebook.
3. Logout the user and login another user who is assigned as admin, open 
the created notebook.

### Questions:
* Does the licenses files need update? N
* Is there breaking changes for older versions? Y/N
* Does this needs documentation? Y


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/yu74n/zeppelin bypass-auth-logic

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/2585.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2585


commit d3e9dcab1bc2efc355140857b91a08bb2035bb69
Author: Yuta Hongo 
Date:   2017-08-10T01:38:01Z

Make admin role to bypass auth logic

commit cfcea0dc5f7d16aecc7e9a8249a01bcb63c38952
Author: Yuta Hongo 
Date:   2017-09-26T05:04:40Z

Rename property name




---

[GitHub] zeppelin pull request #2585: [ZEPPELIN-2647] Bypass auth logic when a user l...

2017-10-12 Thread yu74n 
Github user yu74n closed the pull request at:

https://github.com/apache/zeppelin/pull/2585


---

[GitHub] zeppelin pull request #2585: [ZEPPELIN-2647] Bypass auth logic when a user l...

2017-10-12 Thread yu74n 
Github user yu74n closed the pull request at:

https://github.com/apache/zeppelin/pull/2585


---

[GitHub] zeppelin pull request #2585: [ZEPPELIN-2647] Bypass auth logic when a user l...

2017-10-12 Thread yu74n 
GitHub user yu74n reopened a pull request:

https://github.com/apache/zeppelin/pull/2585

[ZEPPELIN-2647] Bypass auth logic when a user logins as admin role

### What is this PR for?
For administrator, make new admin role that assigned user can see all 
notebooks.

### What type of PR is it?
Improvement

### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-2647

### How should this be tested?
1. Set role name to use as admin through ZEPPELIN_OWNER_ROLE =  
or zeppelin.owner.role = .
Default role name is admin
2. Login as user who is not assigned as admin and create notebook.
3. Logout the user and login another user who is assigned as admin, open 
the created notebook.

### Questions:
* Does the licenses files need update? N
* Is there breaking changes for older versions? Y/N
* Does this needs documentation? Y


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/yu74n/zeppelin bypass-auth-logic

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/2585.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2585


commit d3e9dcab1bc2efc355140857b91a08bb2035bb69
Author: Yuta Hongo 
Date:   2017-08-10T01:38:01Z

Make admin role to bypass auth logic

commit cfcea0dc5f7d16aecc7e9a8249a01bcb63c38952
Author: Yuta Hongo 
Date:   2017-09-26T05:04:40Z

Rename property name




---

[GitHub] zeppelin pull request #2585: [ZEPPELIN-2647] Bypass auth logic when a user l...

2017-10-12 Thread yu74n 
GitHub user yu74n reopened a pull request:

https://github.com/apache/zeppelin/pull/2585

[ZEPPELIN-2647] Bypass auth logic when a user logins as admin role

### What is this PR for?
For administrator, make new admin role that assigned user can see all 
notebooks.

### What type of PR is it?
Improvement

### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-2647

### How should this be tested?
1. Set role name to use as admin through ZEPPELIN_OWNER_ROLE =  
or zeppelin.owner.role = .
Default role name is admin
2. Login as user who is not assigned as admin and create notebook.
3. Logout the user and login another user who is assigned as admin, open 
the created notebook.

### Questions:
* Does the licenses files need update? N
* Is there breaking changes for older versions? Y/N
* Does this needs documentation? Y


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/yu74n/zeppelin bypass-auth-logic

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/2585.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2585


commit d3e9dcab1bc2efc355140857b91a08bb2035bb69
Author: Yuta Hongo 
Date:   2017-08-10T01:38:01Z

Make admin role to bypass auth logic

commit cfcea0dc5f7d16aecc7e9a8249a01bcb63c38952
Author: Yuta Hongo 
Date:   2017-09-26T05:04:40Z

Rename property name




---

[GitHub] zeppelin pull request #2585: [ZEPPELIN-2647] Bypass auth logic when a user l...

2017-10-12 Thread yu74n 
Github user yu74n closed the pull request at:

https://github.com/apache/zeppelin/pull/2585


---

[GitHub] zeppelin issue #2585: [ZEPPELIN-2647] Bypass auth logic when a user logins a...

2017-10-11 Thread yu74n 
Github user yu74n commented on the issue:

https://github.com/apache/zeppelin/pull/2585
  
I rebased and ran test again, but this test is still failed.
https://travis-ci.org/yu74n/zeppelin/jobs/286508544

I think probably my PR doesn't affect the test.
I ran test several times, but failed tests are changed.


---

[GitHub] zeppelin issue #2585: [ZEPPELIN-2647] Bypass auth logic when a user logins a...

2017-10-11 Thread yu74n 
Github user yu74n commented on the issue:

https://github.com/apache/zeppelin/pull/2585
  
@1ambda Sure


---

[GitHub] zeppelin pull request #2585: [ZEPPELIN-2647] Bypass auth logic when a user l...

2017-10-11 Thread yu74n 
GitHub user yu74n reopened a pull request:

https://github.com/apache/zeppelin/pull/2585

[ZEPPELIN-2647] Bypass auth logic when a user logins as admin role

### What is this PR for?
For administrator, make new admin role that assigned user can see all 
notebooks.

### What type of PR is it?
Improvement

### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-2647

### How should this be tested?
1. Set role name to use as admin through ZEPPELIN_OWNER_ROLE =  
or zeppelin.owner.role = .
Default role name is admin
2. Login as user who is not assigned as admin and create notebook.
3. Logout the user and login another user who is assigned as admin, open 
the created notebook.

### Questions:
* Does the licenses files need update? N
* Is there breaking changes for older versions? Y/N
* Does this needs documentation? Y


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/yu74n/zeppelin bypass-auth-logic

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/2585.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2585


commit 08bf4ba79a6585fc8059608fa0bcb20ad2e55df7
Author: Yuta Hongo 
Date:   2017-08-10T01:38:01Z

Make admin role to bypass auth logic

commit 0dd1d72fd6352dd8f6ccd81a85aec1d7a1d6b475
Author: Yuta Hongo 
Date:   2017-09-26T05:04:40Z

Rename property name




---

[GitHub] zeppelin pull request #2585: [ZEPPELIN-2647] Bypass auth logic when a user l...

2017-10-11 Thread yu74n 
Github user yu74n closed the pull request at:

https://github.com/apache/zeppelin/pull/2585


---

[GitHub] zeppelin issue #2585: Bypass auth logic when a user logins as admin role

2017-09-13 Thread yu74n 
Github user yu74n commented on the issue:

https://github.com/apache/zeppelin/pull/2585
  
continued from #2525 #2416 


---

[GitHub] zeppelin pull request #2585: Bypass auth logic when a user logins as admin r...

2017-09-13 Thread yu74n 
GitHub user yu74n opened a pull request:

https://github.com/apache/zeppelin/pull/2585

Bypass auth logic when a user logins as admin role

### What is this PR for?
For administrator, make new admin role that assigned user can see all 
notebooks.

### What type of PR is it?
Improvement

### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-2647

### How should this be tested?
1. Set role name to use as admin through ZEPPELIN_OWNER_ROLE =  
or zeppelin.owner.role = .
Default role name is admin
2. Login as user who is not assigned as admin and create notebook.
3. Logout the user and login another user who is assigned as admin, open 
the created notebook.

### Questions:
* Does the licenses files need update? N
* Is there breaking changes for older versions? Y/N
* Does this needs documentation? Y


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/yu74n/zeppelin bypass-auth-logic

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/2585.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2585


commit 08bf4ba79a6585fc8059608fa0bcb20ad2e55df7
Author: Yuta Hongo 
Date:   2017-08-10T01:38:01Z

Make admin role to bypass auth logic




---

[GitHub] zeppelin issue #2525: [ZEPPELIN-2647] Make admin role to bypass auth logic

2017-09-08 Thread yu74n 
Github user yu74n commented on the issue:

https://github.com/apache/zeppelin/pull/2525
  
After fixed 'testSyncWithAcl', I manually restart CI. All test passed.


---

[GitHub] zeppelin issue #2525: [ZEPPELIN-2647] Make admin role to bypass auth logic

2017-09-07 Thread yu74n 
Github user yu74n commented on the issue:

https://github.com/apache/zeppelin/pull/2525
  
I've fixed failed unit tests.


---

[GitHub] zeppelin issue #2525: [ZEPPELIN-2647] Make admin role to bypass auth logic

2017-08-24 Thread yu74n 
Github user yu74n commented on the issue:

https://github.com/apache/zeppelin/pull/2525
  
One more thing. Should we set admin role to notebook owner in public mode? 
I'm going to change this feature to set admin role to notebook owner, reader 
and writer in private mode though. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2525: [ZEPPELIN-2647] Make admin role to bypass auth logic

2017-08-24 Thread yu74n 
Github user yu74n commented on the issue:

https://github.com/apache/zeppelin/pull/2525
  
@1ambda thx
@felixcheung You are right, this feature affects all modes(private and 
public). I don't understand public mode in detail, is there any problem if we 
set admin role in public mode? Should I set admin role at 
NotebookAuthorization.setNewNotePermissions() when a notebook is created?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2416: [ZEPPELIN-2647] Set admin user as owner when user crea...

2017-08-11 Thread yu74n 
Github user yu74n commented on the issue:

https://github.com/apache/zeppelin/pull/2416
  
@1ambda I created new PR for this issue. Could you check the new one?
I will close the PR.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #2525: Make admin role to bypass auth logic

2017-08-11 Thread yu74n 
GitHub user yu74n opened a pull request:

https://github.com/apache/zeppelin/pull/2525

Make admin role to bypass auth logic

### What is this PR for?
For administrator, make new admin role that assigned user can see all 
notebooks.

### What type of PR is it?
Improvement

### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-2647

### How should this be tested?
1. Change Notebook workspace to private through whether 
ZEPPELIN_NOTEBOOK_PUBLIC = false or zeppelin.notebook.public = false.
2. Set role name to use as admin through ZEPPELIN_OWNER_ROLE =  
or zeppelin.owner.role = .
Default role name is admin
3. Login as user who is not assigned as admin and create notebook.
4. Logout the user and login another user who is assigned as admin, open 
the created notebook.

### Questions:
* Does the licenses files need update? N
* Is there breaking changes for older versions? Y/N
* Does this needs documentation? Y


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/yu74n/zeppelin admin-role

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/2525.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2525


commit e79260c1cae85dd5a740fb457b43efa88a981816
Author: Yuta Hongo 
Date:   2017-08-10T01:38:01Z

Make admin role to bypass auth logic




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #2416: [ZEPPELIN-2647] Set admin user as owner when us...

2017-06-16 Thread yu74n 
Github user yu74n closed the pull request at:

https://github.com/apache/zeppelin/pull/2416


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #2416: [ZEPPELIN-2647] Set admin user as owner when us...

2017-06-16 Thread yu74n 
GitHub user yu74n reopened a pull request:

https://github.com/apache/zeppelin/pull/2416

[ZEPPELIN-2647] Set admin user as owner when user create a notebook

### What is this PR for?
When a user creates a notebook, default users (an administrator can set 
default users in zeppelin-site.xml) are set as owner.

### What type of PR is it?
Improvement

### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-2647

### How should this be tested?
1. Change Notebook workspace to private through whether 
ZEPPELIN_NOTEBOOK_PUBLIC = false or zeppelin.notebook.public = false.
2. Set default owners through ZEPPELIN_DEFAULT_OWNER =  or zeppelin.notebook.owner = .
3. Create notebook.
4. Check if notebook's owner is set to both default users and the user who 
create the notebook.

### Questions:
* Does the licenses files need update? N
* Is there breaking changes for older versions? Y/N
* Does this needs documentation? Y


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/yu74n/zeppelin default-owner

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/2416.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2416


commit ec5faa911cf7c2e725a09ecf792348baaa536d24
Author: Yuta Hongo 
Date:   2017-06-16T05:41:27Z

Add new setting field to set default owner




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #2416: [ZEPPELIN-2647] Set admin user as owner when us...

2017-06-15 Thread yu74n 
GitHub user yu74n opened a pull request:

https://github.com/apache/zeppelin/pull/2416

[ZEPPELIN-2647] Set admin user as owner when user create a notebook

### What is this PR for?
When a user creates a notebook, default users (an administrator can set 
default users in zeppelin-site.xml) are set as owner.

### What type of PR is it?
Improvement

### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-2647

### How should this be tested?
1. Change Notebook workspace to private through whether 
ZEPPELIN_NOTEBOOK_PUBLIC = false or zeppelin.notebook.public = false.
2. Set default owners through ZEPPELIN_DEFAULT_OWNER =  or zeppelin.notebook.owner = .
3. Create notebook.
4. Check if notebook's owner is set to both default users and the user who 
create the notebook.

### Questions:
* Does the licenses files need update? N
* Is there breaking changes for older versions? Y/N
* Does this needs documentation? Y


You can merge this pull request into a Git repository by running:

$ git pull https://github.com/yu74n/zeppelin default-owner

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/zeppelin/pull/2416.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2416


commit ec5faa911cf7c2e725a09ecf792348baaa536d24
Author: Yuta Hongo 
Date:   2017-06-16T05:41:27Z

Add new setting field to set default owner




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---